[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

2023-10-20 Thread Jerin Philip via cfe-commits
@@ -94,7 +94,7 @@ class AttributeCommonInfo { IsRegularKeywordAttribute(IsRegularKeywordAttribute) {} constexpr Form(tok::TokenKind Tok) : SyntaxUsed(AS_Keyword), SpellingIndex(SpellingNotCalculated), - IsAlignas(Tok == tok::kw_alignas), +

[clang] [clang] Add clang::preferred_type attribute for bitfields (PR #69104)

2023-10-20 Thread David Blaikie via cfe-commits
@@ -3153,6 +3153,12 @@ def err_invalid_branch_protection_spec : Error< "invalid or misplaced branch protection specification '%0'">; def warn_unsupported_branch_protection_spec : Warning< "unsupported branch protection specification '%0'">, InGroup; +def warn_attribute_und

[clang] [Clang][LTO][GISel] Propagate `-fglobal-siel` to LTO (PR #69747)

2023-10-20 Thread Min-Yih Hsu via cfe-commits
https://github.com/mshockwave created https://github.com/llvm/llvm-project/pull/69747 Translate `-fglobal-isel` to `-plugin-opt=-global-isel=1`. >From 8abc9204d4148f1b224623ac54d5f58e2ab04e6b Mon Sep 17 00:00:00 2001 From: Min-Yih Hsu Date: Fri, 20 Oct 2023 11:03:30 -0700 Subject: [PATCH] [Cla

[clang] [Clang][LTO][GISel] Propagate `-fglobal-siel` to LTO (PR #69747)

2023-10-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Min-Yih Hsu (mshockwave) Changes Translate `-fglobal-isel` to `-plugin-opt=-global-isel=1`. --- Full diff: https://github.com/llvm/llvm-project/pull/69747.diff 2 Files Affected: - (modified) clang/lib/Driver/ToolChains/CommonArgs

[clang] [clang] Add clang::preferred_type attribute for bitfields (PR #69104)

2023-10-20 Thread David Blaikie via cfe-commits
@@ -3153,6 +3153,12 @@ def err_invalid_branch_protection_spec : Error< "invalid or misplaced branch protection specification '%0'">; def warn_unsupported_branch_protection_spec : Warning< "unsupported branch protection specification '%0'">, InGroup; +def warn_attribute_und

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

2023-10-20 Thread Jerin Philip via cfe-commits
@@ -94,7 +94,7 @@ class AttributeCommonInfo { IsRegularKeywordAttribute(IsRegularKeywordAttribute) {} constexpr Form(tok::TokenKind Tok) : SyntaxUsed(AS_Keyword), SpellingIndex(SpellingNotCalculated), - IsAlignas(Tok == tok::kw_alignas), +

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

2023-10-20 Thread Jerin Philip via cfe-commits
https://github.com/jerinphilip edited https://github.com/llvm/llvm-project/pull/65638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

2023-10-20 Thread Jerin Philip via cfe-commits
https://github.com/jerinphilip edited https://github.com/llvm/llvm-project/pull/65638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20] [Modules] [Driver] Don't enable -fdelayed-template-parsing by default on windows with C++20 modules (PR #69431)

2023-10-20 Thread David Blaikie via cfe-commits
https://github.com/dwblaikie edited https://github.com/llvm/llvm-project/pull/69431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20] [Modules] [Driver] Don't enable -fdelayed-template-parsing by default on windows with C++20 modules (PR #69431)

2023-10-20 Thread David Blaikie via cfe-commits
https://github.com/dwblaikie approved this pull request. Some minor comments but generally looks good to me. https://github.com/llvm/llvm-project/pull/69431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[clang] [C++20] [Modules] [Driver] Don't enable -fdelayed-template-parsing by default on windows with C++20 modules (PR #69431)

2023-10-20 Thread David Blaikie via cfe-commits
@@ -6870,8 +6852,38 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA, Args.AddLastArg(CmdArgs, options::OPT_finline_max_stacksize_EQ); + // FIXME: Find a better way to determine whether we are in C++20. + bool HaveCxx20 = + Std && + (Std->contain

[clang] [C++20] [Modules] [Driver] Don't enable -fdelayed-template-parsing by default on windows with C++20 modules (PR #69431)

2023-10-20 Thread David Blaikie via cfe-commits
@@ -6870,8 +6852,38 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA, Args.AddLastArg(CmdArgs, options::OPT_finline_max_stacksize_EQ); + // FIXME: Find a better way to determine whether we are in C++20. + bool HaveCxx20 = + Std && + (Std->contain

[clang] [C++20] [Modules] [Driver] Don't enable -fdelayed-template-parsing by default on windows with C++20 modules (PR #69431)

2023-10-20 Thread David Blaikie via cfe-commits
@@ -6870,8 +6852,38 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA, Args.AddLastArg(CmdArgs, options::OPT_finline_max_stacksize_EQ); + // FIXME: Find a better way to determine whether we are in C++20. + bool HaveCxx20 = + Std && + (Std->contain

[clang] [clang-format] Skip PP directives when determining brace kind (PR #69473)

2023-10-20 Thread Emilia Kond via cfe-commits
@@ -491,11 +491,19 @@ void UnwrappedLineParser::calculateBraceTypes(bool ExpectClassBody) { SmallVector LBraceStack; assert(Tok->is(tok::l_brace)); do { -// Get next non-comment token. -FormatToken *NextTok; -do { - NextTok = Tokens->getNextToken(); -

[clang] [clang-format] Skip PP directives when determining brace kind (PR #69473)

2023-10-20 Thread Emilia Kond via cfe-commits
https://github.com/rymiel updated https://github.com/llvm/llvm-project/pull/69473 >From 1e4e878d251b44aa68fb8bc6422a9ec4e3de4e12 Mon Sep 17 00:00:00 2001 From: Emilia Kond Date: Wed, 18 Oct 2023 18:03:32 +0300 Subject: [PATCH 1/2] [clang-format] Skip PP directives when determining brace kind

[libunwind] [libunwind][test] Avoid calling back into libunwind on sanitizer errors (PR #67861)

2023-10-20 Thread Alexander Richardson via cfe-commits
@@ -28,6 +28,14 @@ if @LIBUNWIND_USES_ARM_EHABI@: if not @LIBUNWIND_ENABLE_THREADS@: config.available_features.add('libunwind-no-threads') +config.extra_executor_env = "" arichardson wrote: Agreed that would be way better, I'll see if I can get back to th

[libunwind] [libunwind][test] Avoid calling back into libunwind on sanitizer errors (PR #67861)

2023-10-20 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson converted_to_draft https://github.com/llvm/llvm-project/pull/67861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

2023-10-20 Thread Anton Rydahl via cfe-commits
@@ -0,0 +1,142 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

2023-10-20 Thread Anton Rydahl via cfe-commits
@@ -0,0 +1,142 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [Driver] Corrections for linker flags passed with relocatable linking on OpenBSD (PR #67254)

2023-10-20 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/67254 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

2023-10-20 Thread Anton Rydahl via cfe-commits
@@ -0,0 +1,73 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

2023-10-20 Thread Anton Rydahl via cfe-commits
@@ -0,0 +1,73 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang-tools-extra] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

2023-10-20 Thread Anton Rydahl via cfe-commits
@@ -0,0 +1,349 @@ +//===--===// AntonRydahl wrote: I have written a section about this in the `libc++` documentation. Do you think the description is sufficiently detailed? https://github.com/l

[clang] Adding Separate OpenMP Offloading Backend to `libcxx/include/__algorithm/pstl_backends` (PR #66968)

2023-10-20 Thread Anton Rydahl via cfe-commits
@@ -0,0 +1,349 @@ +//===--===// AntonRydahl wrote: I have written a section about this in the `libc++` documentation. Do you think the description is sufficiently detailed? https://github.com/l

[clang] [clang] Add clang::preferred_type attribute for bitfields (PR #69104)

2023-10-20 Thread Vlad Serebrennikov via cfe-commits
@@ -3153,6 +3153,12 @@ def err_invalid_branch_protection_spec : Error< "invalid or misplaced branch protection specification '%0'">; def warn_unsupported_branch_protection_spec : Warning< "unsupported branch protection specification '%0'">, InGroup; +def warn_attribute_und

[clang] [Windows] Add git-clang-format wrapper bat file (PR #69228)

2023-10-20 Thread Björn Schäpers via cfe-commits
@@ -0,0 +1 @@ +py -3 git-clang-format %* HazardyKnusperkeks wrote: What is `py`? I have no program called `py` on my machine (Windows with msys2), so you would possibly break that? Why not write `python` or `python3`? https://github.com/llvm/llvm-project/pull/6

[clang] [Windows] Add git-clang-format wrapper bat file (PR #69228)

2023-10-20 Thread Björn Schäpers via cfe-commits
HazardyKnusperkeks wrote: I have no real opinion on this matter, as I don't use that program/script. But when it helps the windows users, why not? I also see no harm. https://github.com/llvm/llvm-project/pull/69228 ___ cfe-commits mailing list cfe-com

[clang-tools-extra] [clang-tidy] modernize-avoid-bind only return for non-void function (PR #69207)

2023-10-20 Thread via cfe-commits
5chmidti wrote: Well, I have two more PRs planned for this check :). If you feel like it, you can merge this. I've checked to see if anyone from the main file's git blame (of functional changes) are active (`involves:abc` search for issues and prs), but they aren't really. The most recent invo

[clang] [clang] Robustify openmp test (PR #69739)

2023-10-20 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan edited https://github.com/llvm/llvm-project/pull/69739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Robustify openmp test (PR #69739)

2023-10-20 Thread Nathan Sidwell via cfe-commits
https://github.com/urnathan ready_for_review https://github.com/llvm/llvm-project/pull/69739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Robustify openmp test (PR #69739)

2023-10-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Nathan Sidwell (urnathan) Changes If the source path contains 'alias' this would spuriously fail. Be more specific about not wanting [no]alias annotations. --- Full diff: https://github.com/llvm/llvm-project/pull/69739.diff 1 Files Aff

[clang] [clang] Add clang::preferred_type attribute for bitfields (PR #69104)

2023-10-20 Thread Aaron Ballman via cfe-commits
@@ -3153,6 +3153,12 @@ def err_invalid_branch_protection_spec : Error< "invalid or misplaced branch protection specification '%0'">; def warn_unsupported_branch_protection_spec : Warning< "unsupported branch protection specification '%0'">, InGroup; +def warn_attribute_und

[clang] [clang] Add clang::preferred_type attribute for bitfields (PR #69104)

2023-10-20 Thread Aaron Ballman via cfe-commits
@@ -5910,6 +5910,51 @@ static void handleBuiltinAliasAttr(Sema &S, Decl *D, D->addAttr(::new (S.Context) BuiltinAliasAttr(S.Context, AL, Ident)); } +static void handlePreferredTypeAttr(Sema &S, Decl *D, const ParsedAttr &AL) { + if (!AL.hasParsedType()) { +S.Diag(AL.get

[clang] [Windows] Add git-clang-format wrapper bat file (PR #69228)

2023-10-20 Thread Chris B via cfe-commits
@@ -0,0 +1 @@ +py -3 git-clang-format %* llvm-beanz wrote: `py.exe` is the Windows python launcher. It comes with Python for Windows (not msys2 or cygwin where the shebang line would work). It is the Windows way of choosing which python version you want. You ne

[clang-tools-extra] 9399094 - [clang-tidy] modernize-avoid-bind only return for non-void function (#69207)

2023-10-20 Thread via cfe-commits
Author: 5chmidti Date: 2023-10-20T21:28:02+02:00 New Revision: 9399094586aa803fb399ae508e5aa46c8728fdd6 URL: https://github.com/llvm/llvm-project/commit/9399094586aa803fb399ae508e5aa46c8728fdd6 DIFF: https://github.com/llvm/llvm-project/commit/9399094586aa803fb399ae508e5aa46c8728fdd6.diff LOG:

[clang-tools-extra] [clang-tidy] modernize-avoid-bind only return for non-void function (PR #69207)

2023-10-20 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL closed https://github.com/llvm/llvm-project/pull/69207 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] use relative paths for builtin headers during module compilation (PR #68023)

2023-10-20 Thread Jan Svoboda via cfe-commits
@@ -180,8 +180,9 @@ static void appendSubframeworkPaths(Module *Mod, OptionalFileEntryRef ModuleMap::findHeader( Module *M, const Module::UnresolvedHeaderDirective &Header, SmallVectorImpl &RelativePathName, bool &NeedsFramework) { - // Search for the header file withi

[clang] [clang] use relative paths for builtin headers during module compilation (PR #68023)

2023-10-20 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: Our downstream test `ClangScanDeps/modules-include-tree-prefix-map.c` started failing, so CC'ing @benlangmuir to take another look. https://github.com/llvm/llvm-project/pull/68023 ___ cfe-commits mailing list cfe-commits@lists.llvm

[clang] [clang] Add clang::preferred_type attribute for bitfields (PR #69104)

2023-10-20 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/69104 >From 976aa5c8f3d936a15e7123069a49d97ad3bf7a05 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Sun, 15 Oct 2023 13:14:55 +0300 Subject: [PATCH 01/10] [clang] Add clang::debug_info_type attribute --- cla

[clang] [clang] Add clang::preferred_type attribute for bitfields (PR #69104)

2023-10-20 Thread Vlad Serebrennikov via cfe-commits
@@ -5910,6 +5910,51 @@ static void handleBuiltinAliasAttr(Sema &S, Decl *D, D->addAttr(::new (S.Context) BuiltinAliasAttr(S.Context, AL, Ident)); } +static void handlePreferredTypeAttr(Sema &S, Decl *D, const ParsedAttr &AL) { + if (!AL.hasParsedType()) { +S.Diag(AL.get

[clang] a95d4b7 - [clang-format] Annotate do while while

2023-10-20 Thread via cfe-commits
Author: Björn Schäpers Date: 2023-10-20T21:46:40+02:00 New Revision: a95d4b795018199c1ed18f518f940b3a57b2e98a URL: https://github.com/llvm/llvm-project/commit/a95d4b795018199c1ed18f518f940b3a57b2e98a DIFF: https://github.com/llvm/llvm-project/commit/a95d4b795018199c1ed18f518f940b3a57b2e98a.diff

[clang] [clang-format] Annotate do while while (PR #69707)

2023-10-20 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks closed https://github.com/llvm/llvm-project/pull/69707 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add clang::preferred_type attribute for bitfields (PR #69104)

2023-10-20 Thread Erich Keane via cfe-commits
erichkeane wrote: > > However, will this actually work in practice in the debugger? If not, > > perhaps we should limit to just integer and enumeration types for now, > > leaving the extension for the future. > > I composed an example of that: > > ```c++ > struct A { > short a1; > short a

[clang] [clang] Add clang::preferred_type attribute for bitfields (PR #69104)

2023-10-20 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/69104 >From 976aa5c8f3d936a15e7123069a49d97ad3bf7a05 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Sun, 15 Oct 2023 13:14:55 +0300 Subject: [PATCH 01/11] [clang] Add clang::debug_info_type attribute --- cla

[clang] [clang] Add clang::preferred_type attribute for bitfields (PR #69104)

2023-10-20 Thread Vlad Serebrennikov via cfe-commits
@@ -3153,6 +3153,12 @@ def err_invalid_branch_protection_spec : Error< "invalid or misplaced branch protection specification '%0'">; def warn_unsupported_branch_protection_spec : Warning< "unsupported branch protection specification '%0'">, InGroup; +def warn_attribute_und

[clang] 1d4601a - [Driver] Corrections for linker flags passed with relocatable linking on OpenBSD (#67254)

2023-10-20 Thread via cfe-commits
Author: Brad Smith Date: 2023-10-20T15:52:07-04:00 New Revision: 1d4601a1ef84e4ffe2db84d17b53953b25699eef URL: https://github.com/llvm/llvm-project/commit/1d4601a1ef84e4ffe2db84d17b53953b25699eef DIFF: https://github.com/llvm/llvm-project/commit/1d4601a1ef84e4ffe2db84d17b53953b25699eef.diff LO

[clang] [Driver] Corrections for linker flags passed with relocatable linking on OpenBSD (PR #67254)

2023-10-20 Thread Brad Smith via cfe-commits
https://github.com/brad0 closed https://github.com/llvm/llvm-project/pull/67254 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][OHOS] Keep ARM ABI selection logic in sync between Clang and LLVM (PR #68656)

2023-10-20 Thread Brad Smith via cfe-commits
brad0 wrote: Ping. https://github.com/llvm/llvm-project/pull/68656 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add clang::preferred_type attribute for bitfields (PR #69104)

2023-10-20 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/69104 >From 976aa5c8f3d936a15e7123069a49d97ad3bf7a05 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Sun, 15 Oct 2023 13:14:55 +0300 Subject: [PATCH 01/12] [clang] Add clang::debug_info_type attribute --- cla

[clang-tools-extra] [libc++] Fix the behavior of throwing `operator new` under -fno-exceptions (PR #69498)

2023-10-20 Thread via cfe-commits
EricWF wrote: I'm tempted to just do the non-conforming thing here (because -fno-exceptions is non-conforming), and just assume that when you're building with -fno-exceptions, you're not trying to replace the throwing operator new, and you'll be fine if we have the throwing kind call the non-

[clang] [clang] use relative paths for builtin headers during module compilation (PR #68023)

2023-10-20 Thread Richard Howell via cfe-commits
@@ -180,8 +180,9 @@ static void appendSubframeworkPaths(Module *Mod, OptionalFileEntryRef ModuleMap::findHeader( Module *M, const Module::UnresolvedHeaderDirective &Header, SmallVectorImpl &RelativePathName, bool &NeedsFramework) { - // Search for the header file withi

[clang] [clang] use relative paths for builtin headers during module compilation (PR #68023)

2023-10-20 Thread Richard Howell via cfe-commits
https://github.com/rmaz updated https://github.com/llvm/llvm-project/pull/68023 >From 5e3c6319c6a98a07dab6571f65ad1320815d76bf Mon Sep 17 00:00:00 2001 From: Richard Howell Date: Mon, 2 Oct 2023 11:10:52 -0700 Subject: [PATCH] [clang] add module builtin headers relative to resource dir When inc

[clang] [libc++] Fix the behavior of throwing `operator new` under -fno-exceptions (PR #69498)

2023-10-20 Thread via cfe-commits
EricWF wrote: > We currently support both ways of building the library (-fexceptions and > -fno-exceptions). I don't know how widely used the -fno-exceptions variant is > used and we could discuss dropping it (and forcing people to always build the > library itself with -fexceptions), but IMO

[libunwind] [libunwind][AIX] static_cast the value from getLR() to avoid the warning from -Wconversion (PR #69767)

2023-10-20 Thread via cfe-commits
https://github.com/xingxue-ibm created https://github.com/llvm/llvm-project/pull/69767 This PR adds `static_cast` to the value returned from `getLR()` in the AIX unwinder to avoid warning if `-Wconversion` is specified for building in 32-bit mode. >From 2255e2c9a66420bba36bf4ba7f3d8db36d7e4df

[libunwind] [libunwind][AIX] static_cast the value from getLR() to avoid the warning from -Wconversion (PR #69767)

2023-10-20 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-libunwind Author: None (xingxue-ibm) Changes This PR adds `static_cast` to the value returned from `getLR()` in the AIX unwinder to avoid warning if `-Wconversion` is specified for building in 32-bit mode. --- Full diff: https://github.com/llvm/llvm-p

[clang] [clang] Add clang::preferred_type attribute for bitfields (PR #69104)

2023-10-20 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: > but I also see "you got what you asked for!" as being a reasonable defense to > that. That's my thinking indeed, and the reason why I opposed to Aaron's proposal to implicitly mark 1-bit bit-fields as `preferred_type(bool)`. https://github.com/llvm/llvm-project/pull/69104 ___

[clang] [clang-format] Skip PP directives when determining brace kind (PR #69473)

2023-10-20 Thread Owen Pan via cfe-commits
https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/69473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 09ec000 - [Modules] textual headers in submodules never resolve their `use`s (#69651)

2023-10-20 Thread via cfe-commits
Author: Ian Anderson Date: 2023-10-20T13:23:34-07:00 New Revision: 09ec0004eee2d9929d25cf519956cc470ffb33dd URL: https://github.com/llvm/llvm-project/commit/09ec0004eee2d9929d25cf519956cc470ffb33dd DIFF: https://github.com/llvm/llvm-project/commit/09ec0004eee2d9929d25cf519956cc470ffb33dd.diff

[clang] [Modules] textual headers in submodules never resolve their `use`s (PR #69651)

2023-10-20 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder closed https://github.com/llvm/llvm-project/pull/69651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU][MachineScheduler] Alternative way to control excess RP. (PR #68004)

2023-10-20 Thread Jeffrey Byrnes via cfe-commits
@@ -702,7 +702,7 @@ bool UnclusteredHighRPStage::initGCNSchedStage() { if (!GCNSchedStage::initGCNSchedStage()) return false; - if (DAG.RegionsWithHighRP.none() && DAG.RegionsWithExcessRP.none()) + if (DAG.RegionsWithExcessRP.none()) jrbyrnes wrote: W

[clang-tools-extra] [AMDGPU][MachineScheduler] Alternative way to control excess RP. (PR #68004)

2023-10-20 Thread Jeffrey Byrnes via cfe-commits
https://github.com/jrbyrnes commented: Just have a few questions about implementation details -- at a higher level, seems like we are trading one heuristic for another w.r.t flagging regions as ExcessRP -- so I'm curious about the relative performance. https://github.com/llvm/llvm-project/pull

[clang-tools-extra] [AMDGPU][MachineScheduler] Alternative way to control excess RP. (PR #68004)

2023-10-20 Thread Jeffrey Byrnes via cfe-commits
@@ -1117,16 +1118,23 @@ bool OccInitialScheduleStage::shouldRevertScheduling(unsigned WavesAfter) { bool UnclusteredHighRPStage::shouldRevertScheduling(unsigned WavesAfter) { // If RP is not reduced in the unclustered reschedule stage, revert to the // old schedule. - if

[libclc] [AMDGPU][MachineScheduler] Alternative way to control excess RP. (PR #68004)

2023-10-20 Thread Jeffrey Byrnes via cfe-commits
@@ -959,16 +970,6 @@ void GCNSchedStage::checkScheduling() { << DAG.MinOccupancy << ".\n"); } - unsigned MaxVGPRs = ST.getMaxNumVGPRs(MF); - unsigned MaxSGPRs = ST.getMaxNumSGPRs(MF); - if (PressureAfter.getVGPRNum(false) > MaxVGPRs || - Pressur

[libclc] [AMDGPU][MachineScheduler] Alternative way to control excess RP. (PR #68004)

2023-10-20 Thread Jeffrey Byrnes via cfe-commits
@@ -894,10 +894,22 @@ void GCNSchedStage::setupNewBlock() { void GCNSchedStage::finalizeGCNRegion() { DAG.Regions[RegionIdx] = std::pair(DAG.RegionBegin, DAG.RegionEnd); - DAG.RescheduleRegions[RegionIdx] = false; jrbyrnes wrote: Why was this removed? htt

[clang] [AMDGPU][MachineScheduler] Alternative way to control excess RP. (PR #68004)

2023-10-20 Thread Jeffrey Byrnes via cfe-commits
https://github.com/jrbyrnes commented: Just have a few questions about implementation details -- at a higher level, seems like we are trading one heuristic for another w.r.t flagging regions as ExcessRP -- so I'm curious about the relative performance. https://github.com/llvm/llvm-project/pull

[libclc] [AMDGPU][MachineScheduler] Alternative way to control excess RP. (PR #68004)

2023-10-20 Thread Jeffrey Byrnes via cfe-commits
https://github.com/jrbyrnes commented: Just have a few questions about implementation details -- at a higher level, seems like we are trading one heuristic for another w.r.t flagging regions as ExcessRP -- so I'm curious about the relative performance. https://github.com/llvm/llvm-project/pull

[clang] [Windows] Add git-clang-format wrapper bat file (PR #69228)

2023-10-20 Thread Owen Pan via cfe-commits
https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/69228 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Hook up Haiku PowerPC support (PR #69134)

2023-10-20 Thread Brad Smith via cfe-commits
brad0 wrote: Ping. https://github.com/llvm/llvm-project/pull/69134 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Fix RawStringLiteral being available to C and C++ versions prior to C++11 (PR #69775)

2023-10-20 Thread via cfe-commits
https://github.com/robozati created https://github.com/llvm/llvm-project/pull/69775 The `RawStringLiteral` code action runs both on C and C++ versions prior to C++11, where this feature is unavailable. This patch adds a condition to check if the context is running a version equal or greater t

[clang-tools-extra] [clangd] Fix RawStringLiteral being available to C and C++ versions prior to C++11 (PR #69775)

2023-10-20 Thread via cfe-commits
https://github.com/robozati edited https://github.com/llvm/llvm-project/pull/69775 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 538b7ba - Reland [clang] [unittest] Add a test for Generic_GCC::GCCVersion::Parse (#69078)

2023-10-20 Thread Martin Storsjö via cfe-commits
Author: Martin Storsjö Date: 2023-10-20T23:34:28+03:00 New Revision: 538b7ba2aacd6e400ee63c4f9ff1c2543ae69a90 URL: https://github.com/llvm/llvm-project/commit/538b7ba2aacd6e400ee63c4f9ff1c2543ae69a90 DIFF: https://github.com/llvm/llvm-project/commit/538b7ba2aacd6e400ee63c4f9ff1c2543ae69a90.diff

[clang] [clang] [unittest] Add a test for Generic_GCC::GCCVersion::Parse (PR #69078)

2023-10-20 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: > ```c > #if !defined(LLVM_BUILD_SHARED_LIBS) > ``` > > is not great but is not too bad. `-DBUILD_SHARED_LIBS=on` modes are slow to > execute tests and are not used often for Release builds. I went ahead and relanded this now, in 538b7ba2aacd6e400ee63c4f9ff1c2543ae69a90, with

[clang-tools-extra] [clangd] Fix RawStringLiteral being available to C and C++ versions prior to C++11 (PR #69775)

2023-10-20 Thread via cfe-commits
https://github.com/robozati updated https://github.com/llvm/llvm-project/pull/69775 >From c644be1d123769395bed6ea069a45c051e3fc66d Mon Sep 17 00:00:00 2001 From: robozati <139823421+roboz...@users.noreply.github.com> Date: Fri, 20 Oct 2023 17:23:21 -0300 Subject: [PATCH 1/2] Fix RawStringLiteral

[libunwind] [libunwind][AIX] static_cast the value from getLR() to avoid the warning from -Wconversion (PR #69767)

2023-10-20 Thread via cfe-commits
https://github.com/xingxue-ibm edited https://github.com/llvm/llvm-project/pull/69767 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind][AIX] static_cast the value from getLR() to avoid the warning from -Wconversion (PR #69767)

2023-10-20 Thread via cfe-commits
https://github.com/xingxue-ibm edited https://github.com/llvm/llvm-project/pull/69767 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind][AIX] static_cast the value from getLR() to avoid the warning from -Wconversion (PR #69767)

2023-10-20 Thread via cfe-commits
https://github.com/xingxue-ibm edited https://github.com/llvm/llvm-project/pull/69767 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] a432358 - [-Wunsafe-buffer-usage] Add AST info to the unclaimed DRE debug notes for analysis

2023-10-20 Thread via cfe-commits
Author: ziqingluo-90 Date: 2023-10-20T14:27:14-07:00 New Revision: a4323586fcbb20f39f00d5d1bc4a94a1aeea15c4 URL: https://github.com/llvm/llvm-project/commit/a4323586fcbb20f39f00d5d1bc4a94a1aeea15c4 DIFF: https://github.com/llvm/llvm-project/commit/a4323586fcbb20f39f00d5d1bc4a94a1aeea15c4.diff

[PATCH] D158561: [-Wunsafe-buffer-usage] Add AST info to the unclaimed DRE debug notes for analysis

2023-10-20 Thread Ziqing Luo via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa4323586fcbb: [-Wunsafe-buffer-usage] Add AST info to the unclaimed DRE debug notes for… (authored by ziqingluo-90). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[clang-tools-extra] [OpenMP][mlir] Add translation for `if` in `omp.teams` (PR #69404)

2023-10-20 Thread via cfe-commits
https://github.com/shraiysh updated https://github.com/llvm/llvm-project/pull/69404 >From cf9e3e16a8b6f56e76c725b6244154b825cc8cc0 Mon Sep 17 00:00:00 2001 From: Shraiysh Vaishay Date: Tue, 17 Oct 2023 19:59:11 -0500 Subject: [PATCH] [OpenMP][mlir] Add translation for `if` in `omp.teams` This

[clang] [OpenMP][mlir] Add translation for `if` in `omp.teams` (PR #69404)

2023-10-20 Thread via cfe-commits
https://github.com/shraiysh updated https://github.com/llvm/llvm-project/pull/69404 >From cf9e3e16a8b6f56e76c725b6244154b825cc8cc0 Mon Sep 17 00:00:00 2001 From: Shraiysh Vaishay Date: Tue, 17 Oct 2023 19:59:11 -0500 Subject: [PATCH] [OpenMP][mlir] Add translation for `if` in `omp.teams` This

[clang] Support target names with dots in more utilities (PR #65812)

2023-10-20 Thread Dan McGregor via cfe-commits
dankm wrote: No _good_ particular reason. I got hung up on the formatting issues then ran out of steam, and busy with $job. I just ran clang-format on this change and it came up clean. And now that I've done that the only reason I have left is I'm unable to merge my own changes. Would you min

[clang-tools-extra] [clangd] Fix RawStringLiteral being available to C and C++ versions prior to C++11 (PR #69775)

2023-10-20 Thread via cfe-commits
robozati wrote: Tests are randomly failing, let me get what is wrong. https://github.com/llvm/llvm-project/pull/69775 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Fix RawStringLiteral being available to C and C++ versions prior to C++11 (PR #69775)

2023-10-20 Thread via cfe-commits
https://github.com/robozati converted_to_draft https://github.com/llvm/llvm-project/pull/69775 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [OpenMP][mlir] Add translation for `if` in `omp.teams` (PR #69404)

2023-10-20 Thread via cfe-commits
https://github.com/shraiysh updated https://github.com/llvm/llvm-project/pull/69404 >From cf9e3e16a8b6f56e76c725b6244154b825cc8cc0 Mon Sep 17 00:00:00 2001 From: Shraiysh Vaishay Date: Tue, 17 Oct 2023 19:59:11 -0500 Subject: [PATCH 1/2] [OpenMP][mlir] Add translation for `if` in `omp.teams` T

[clang] [OpenMP][mlir] Add translation for `if` in `omp.teams` (PR #69404)

2023-10-20 Thread via cfe-commits
https://github.com/shraiysh updated https://github.com/llvm/llvm-project/pull/69404 >From cf9e3e16a8b6f56e76c725b6244154b825cc8cc0 Mon Sep 17 00:00:00 2001 From: Shraiysh Vaishay Date: Tue, 17 Oct 2023 19:59:11 -0500 Subject: [PATCH 1/2] [OpenMP][mlir] Add translation for `if` in `omp.teams` T

[clang-tools-extra] [OpenMP][mlir] Add translation for `if` in `omp.teams` (PR #69404)

2023-10-20 Thread via cfe-commits
https://github.com/shraiysh closed https://github.com/llvm/llvm-project/pull/69404 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP][mlir] Add translation for `if` in `omp.teams` (PR #69404)

2023-10-20 Thread via cfe-commits
https://github.com/shraiysh closed https://github.com/llvm/llvm-project/pull/69404 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Fix RawStringLiteral being available to C and C++ versions prior to C++11 (PR #69775)

2023-10-20 Thread via cfe-commits
https://github.com/robozati updated https://github.com/llvm/llvm-project/pull/69775 >From c644be1d123769395bed6ea069a45c051e3fc66d Mon Sep 17 00:00:00 2001 From: robozati <139823421+roboz...@users.noreply.github.com> Date: Fri, 20 Oct 2023 17:23:21 -0300 Subject: [PATCH 1/2] Fix RawStringLiteral

[clang-tools-extra] [clangd] Fix RawStringLiteral being available to C and C++ versions prior to C++11 (PR #69775)

2023-10-20 Thread via cfe-commits
https://github.com/robozati ready_for_review https://github.com/llvm/llvm-project/pull/69775 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Update stdckdint.h and make it available in pre-C23 modes. (PR #69649)

2023-10-20 Thread via cfe-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/69649 >From 0c57e45f6ee16e43cc6388b1ca6beb88bbc7b925 Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Thu, 19 Oct 2023 22:23:03 + Subject: [PATCH 1/3] Update stdckdint.h and make it available in pre-C23 modes.

[libunwind] [libunwind][libc++][libc++abi] Add cross-compilation flags to tests (PR #67201)

2023-10-20 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson updated https://github.com/llvm/llvm-project/pull/67201 >From 6d650b781080d46ccae02793529cf63b18859f3f Mon Sep 17 00:00:00 2001 From: Alex Richardson Date: Wed, 6 Sep 2023 11:41:56 -0700 Subject: [PATCH 1/4] [libunwind][libc++][libc++abi] Add cross-compilation fl

[clang] Support target names with dots in more utilities (PR #65812)

2023-10-20 Thread Dan McGregor via cfe-commits
dankm wrote: Hm. I have "fixup" commits in this branch, should I rebase those, or can we squash merge as-is? https://github.com/llvm/llvm-project/pull/65812 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[libunwind] [libunwind][libc++][libc++abi] Add cross-compilation flags to tests (PR #67201)

2023-10-20 Thread via cfe-commits
@@ -45,10 +45,10 @@ config.substitutions.append(('%{flags}', '-isysroot {}'.format('@CMAKE_OSX_SYSROOT@') if '@CMAKE_OSX_SYSROOT@' else '' )) config.substitutions.append(('%{compile_flags}', -'-nostdinc++ -I %{include} -I %{libcxx}/test/support' +'@CMAKE_CXX_FLAGS_

[libunwind] [libunwind][libc++][libc++abi] Add cross-compilation flags to tests (PR #67201)

2023-10-20 Thread via cfe-commits
https://github.com/EricWF edited https://github.com/llvm/llvm-project/pull/67201 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind][libc++][libc++abi] Add cross-compilation flags to tests (PR #67201)

2023-10-20 Thread via cfe-commits
EricWF wrote: We also don't want to make our test suite flags beholden to changes CMake chooses to make. https://github.com/llvm/llvm-project/pull/67201 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[clang] [clang][tidy] Ensure rewriter has the correct CWD (PR #67839)

2023-10-20 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: > Clang part looks fine. For a clang-tidy part, is there a way to test this > part ? What changes because we use now a absolute build directory. I'm > missing some tests for that part. So the clang-tidy part is necessary to keep the `clang-tidy/infrastructure/clang-tidy-ru

[clang] [RISCV][MC] MC layer support for the experimental zalasr extension (PR #69685)

2023-10-20 Thread Brendan Sweeney via cfe-commits
https://github.com/mehnadnerd updated https://github.com/llvm/llvm-project/pull/69685 >From d412fa8018ff4788c3ed8a1c8018c293be20040f Mon Sep 17 00:00:00 2001 From: brs Date: Thu, 19 Oct 2023 17:16:45 -0500 Subject: [PATCH] [RISCV][MC] MC layer support for the experimental zalasr extension ---

[clang] [RISCV][MC] MC layer support for the experimental zalasr extension (PR #69685)

2023-10-20 Thread Brendan Sweeney via cfe-commits
mehnadnerd wrote: I've updated it to add regression tests. https://github.com/llvm/llvm-project/pull/69685 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] WebKit checkers: support ref and deref defined on different classes. (PR #68170)

2023-10-20 Thread Ryosuke Niwa via cfe-commits
@@ -70,29 +88,45 @@ std::optional isRefCountable(const CXXRecordDecl* R) if (!R) return std::nullopt; - if (hasPublicRefAndDeref(R)) + bool hasRef = hasPublicRefMethod(R); + bool hasDeref = hasPublicDerefMethod(R); + if (hasRef && hasDeref) return true; CXX

[clang] [analyzer] WebKit checkers: support ref and deref defined on different classes. (PR #68170)

2023-10-20 Thread Ryosuke Niwa via cfe-commits
@@ -18,24 +18,26 @@ using namespace clang; namespace { -bool hasPublicRefAndDeref(const CXXRecordDecl *R) { +bool hasPublicRefMethod(const CXXRecordDecl *R) { assert(R); assert(R->hasDefinition()); - bool hasRef = false; - bool hasDeref = false; for (const CXXMet

<    1   2   3   4   >