[clang] 5109454 - [clang][index] Fix processing of CompoundAssignOperator at setting up reference roles (#69370)

2023-10-19 Thread via cfe-commits
Author: Aleksandr Platonov Date: 2023-10-19T23:09:31+03:00 New Revision: 51094545e28d222dc11eea513904506624d715c6 URL: https://github.com/llvm/llvm-project/commit/51094545e28d222dc11eea513904506624d715c6 DIFF: https://github.com/llvm/llvm-project/commit/51094545e28d222dc11eea513904506624d715c6.

[clang] [clang][index] Fix processing of CompoundAssignOperator at setting up reference roles (PR #69370)

2023-10-19 Thread Aleksandr Platonov via cfe-commits
https://github.com/ArcsinX closed https://github.com/llvm/llvm-project/pull/69370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] [unittest] Add a test for Generic_GCC::GCCVersion::Parse (PR #69078)

2023-10-19 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: > Perhaps this belongs in the ABI-breaking-checks build? Hmm, ideally I think it should be included in any build - let’s hope we don’t need to resort to that. @tstellar @MaskRay Do either of you happen to know about this; would it be ok ABI wise to remove `LLVM_LIBRARY_VISIBIL

[clang] ✨ [Sema, Lex, Parse] Preprocessor embed in C and C++ (and Obj-C and Obj-C++ by-proxy) (PR #68620)

2023-10-19 Thread The Phantom Derpstorm via cfe-commits
https://github.com/ThePhD edited https://github.com/llvm/llvm-project/pull/68620 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] b2f50b4 - [clang-format][NFC] Use UnwrappedLineParser::eof() for consistency

2023-10-19 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2023-10-19T13:38:49-07:00 New Revision: b2f50b49a8c45305d27f0393ee6248e3e8851788 URL: https://github.com/llvm/llvm-project/commit/b2f50b49a8c45305d27f0393ee6248e3e8851788 DIFF: https://github.com/llvm/llvm-project/commit/b2f50b49a8c45305d27f0393ee6248e3e8851788.diff LOG:

[clang] Use the correct namespace for looking up matching operator!= (PR #68922)

2023-10-19 Thread Utkarsh Saxena via cfe-commits
@@ -960,18 +960,13 @@ static bool shouldAddReversedEqEq(Sema &S, SourceLocation OpLoc, return true; } // Otherwise the search scope is the namespace scope of which F is a member. - LookupResult NonMembers(S, NotEqOp, OpLoc, - Sema::LookupNameK

[clang] Use the correct namespace for looking up matching operator!= (PR #68922)

2023-10-19 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/68922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Use the correct namespace for looking up matching operator!= (PR #68922)

2023-10-19 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/68922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [Docs][LTO] Updated HowToSubmitABug.rst for LTO crashes (PR #68389)

2023-10-19 Thread Wael Yehia via cfe-commits
https://github.com/w2yehia approved this pull request. https://github.com/llvm/llvm-project/pull/68389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Use XMACROS for MachO platforms. (PR #69262)

2023-10-19 Thread Juergen Ributzka via cfe-commits
https://github.com/ributzka updated https://github.com/llvm/llvm-project/pull/69262 >From d6a4d1cc70e7d3a13b94ff397bef8a0a75e21257 Mon Sep 17 00:00:00 2001 From: Juergen Ributzka Date: Mon, 28 Aug 2023 15:25:48 -0700 Subject: [PATCH 1/3] [llvm] Use XMACROS for MachO platforms. This change adds

[clang] [C++20] [Modules] [Driver] Don't enable -fdelayed-template-parsing by default on windows with C++20 modules (PR #69431)

2023-10-19 Thread Markus Böck via cfe-commits
zero9178 wrote: > > According to the docs [0], MSVC actually defaults to > > `-fno-delayed-template-parsing` (`/Zc:twoPhase-` with MSVC CLI) if using > > C++20. This is due to `-std:c++20` implying `/permissive-` which implies > > `/Zc:twoPhase-`. We could therefore just disable it based on la

[libunwind] [libc++] Implement ranges::contains (PR #65148)

2023-10-19 Thread via cfe-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/65148 >From 02e9afd761228f401df4d9f8dfaaca44ffae0c6e Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Thu, 31 Aug 2023 20:08:32 + Subject: [PATCH 01/16] [libc++] Implement ranges::contains Differential Revision

[clang] Support MemProf on darwin (PR #69640)

2023-10-19 Thread Manman Ren via cfe-commits
https://github.com/manman-ren created https://github.com/llvm/llvm-project/pull/69640 None >From 86dc0db55bf6aa629639b1beac5c2cf5f39177ec Mon Sep 17 00:00:00 2001 From: Manman Ren Date: Tue, 10 Oct 2023 20:54:07 -0700 Subject: [PATCH 1/2] memprof support on Darwin --- clang/lib/Driver/ToolCh

[clang] [OpenMP 5.2] Deprecate syntax of map modifiers without comma separators (PR #69534)

2023-10-19 Thread Fazlay Rabbi via cfe-commits
https://github.com/mdfazlay updated https://github.com/llvm/llvm-project/pull/69534 >From a8f51dbafe6350ac20f00b01565bf273dde776f4 Mon Sep 17 00:00:00 2001 From: Fazlay Rabbi Date: Wed, 18 Oct 2023 13:21:17 -0700 Subject: [PATCH] [OpenMP 5.2] Deprecate syntax of map modifiers without comma sep

[clang] Support MemProf on darwin (PR #69640)

2023-10-19 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff ea9e116e5a24e834142bc4024b57697b48599a9e 8ce32592e780e693a9378f30237a25629a822897 --

[clang] [Windows] Add git-clang-format wrapper bat file (PR #69228)

2023-10-19 Thread Chris B via cfe-commits
https://github.com/llvm-beanz edited https://github.com/llvm/llvm-project/pull/69228 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Windows] Add git-clang-format wrapper bat file (PR #69228)

2023-10-19 Thread Chris B via cfe-commits
llvm-beanz wrote: > Can you open an issue and link to it from here? Filed #69643. > It seems `git clang-format` works in Command Prompt without this new batch > file. IIUC, `git clang-format` works if you have WSL installed, but not with a default Windows installation. We definitely have use

[clang] 1d8985f - [Fuchsia] Add lldb-dap to LLDB distribution

2023-10-19 Thread Daniel Thornburgh via cfe-commits
Author: Daniel Thornburgh Date: 2023-10-19T14:45:34-07:00 New Revision: 1d8985fc14457429c8120b09ae842250bdd225b1 URL: https://github.com/llvm/llvm-project/commit/1d8985fc14457429c8120b09ae842250bdd225b1 DIFF: https://github.com/llvm/llvm-project/commit/1d8985fc14457429c8120b09ae842250bdd225b1.d

[clang-tools-extra] [MLIR] Add SyclRuntimeWrapper (PR #69648)

2023-10-19 Thread Nishant Patel via cfe-commits
https://github.com/nbpatel created https://github.com/llvm/llvm-project/pull/69648 This PR is a breakdown of the big PR #65539 which enables intel gpu integration. In this PR we add the code for the sycl runtime wrappers and also the cmake modules to find the dependent components. Integration

[clang] [MLIR] Add SyclRuntimeWrapper (PR #69648)

2023-10-19 Thread Nishant Patel via cfe-commits
https://github.com/nbpatel created https://github.com/llvm/llvm-project/pull/69648 This PR is a breakdown of the big PR #65539 which enables intel gpu integration. In this PR we add the code for the sycl runtime wrappers and also the cmake modules to find the dependent components. Integration

[clang] Update stdckdint.h and make it available in pre-C23 modes. (PR #69649)

2023-10-19 Thread via cfe-commits
https://github.com/ZijunZhaoCCK created https://github.com/llvm/llvm-project/pull/69649 Update some tests and docs. >From 0c57e45f6ee16e43cc6388b1ca6beb88bbc7b925 Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Thu, 19 Oct 2023 22:23:03 + Subject: [PATCH] Update stdckdint.h and make it avai

[clang] Update stdckdint.h and make it available in pre-C23 modes. (PR #69649)

2023-10-19 Thread via cfe-commits
@@ -1,12 +1,15 @@ // NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 3 +// RUN: %clang_cc1 -triple=x86_64 -emit-llvm -verify -std=c99 %s -o - | FileCheck %s ZijunZhaoCCK wrote: I don't add tests in clang/test/Head

[clang] [MLIR] Add SyclRuntimeWrapper (PR #69648)

2023-10-19 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff e353cd8173db939af22a6fd90705e35fbadb01a7 95b9d423a9e4fc0f317e2468696a9dafefd20f46 --

[clang] Update stdckdint.h and make it available in pre-C23 modes. (PR #69649)

2023-10-19 Thread via cfe-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/69649 >From 0c57e45f6ee16e43cc6388b1ca6beb88bbc7b925 Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Thu, 19 Oct 2023 22:23:03 + Subject: [PATCH] Update stdckdint.h and make it available in pre-C23 modes. Upda

[clang] Update stdckdint.h and make it available in pre-C23 modes. (PR #69649)

2023-10-19 Thread via cfe-commits
https://github.com/ZijunZhaoCCK ready_for_review https://github.com/llvm/llvm-project/pull/69649 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Update stdckdint.h and make it available in pre-C23 modes. (PR #69649)

2023-10-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-x86 Author: None (ZijunZhaoCCK) Changes Update some tests and docs. --- Full diff: https://github.com/llvm/llvm-project/pull/69649.diff 6 Files Affected: - (modified) clang/docs/ReleaseNotes.rst (+1-1) - (modified) clang/lib/Headers/stdckdin

[clang] [Modules] textual headers in submodules never resolve their `use`s (PR #69651)

2023-10-19 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder created https://github.com/llvm/llvm-project/pull/69651 When an include from a textual header is resolved, the textual header's submodule is used as the requesting module. The submodule's uses are resolved, but that doesn't work because only top level modul

[clang] [Modules] textual headers in submodules never resolve their `use`s (PR #69651)

2023-10-19 Thread Ian Anderson via cfe-commits
ian-twilightcoder wrote: Somewhat indirectly caused by https://reviews.llvm.org/D132779 https://github.com/llvm/llvm-project/pull/69651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Modules] textual headers in submodules never resolve their `use`s (PR #69651)

2023-10-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: Ian Anderson (ian-twilightcoder) Changes When an include from a textual header is resolved, the textual header's submodule is used as the requesting module. The submodule's uses are resolved, but that doesn't work because only top

[clang] [analyzer] WebKit checkers: support ref and deref defined on different classes. (PR #68170)

2023-10-19 Thread Artem Dergachev via cfe-commits
https://github.com/haoNoQ edited https://github.com/llvm/llvm-project/pull/68170 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] WebKit checkers: support ref and deref defined on different classes. (PR #68170)

2023-10-19 Thread Artem Dergachev via cfe-commits
https://github.com/haoNoQ commented: @rniwa I had a look and I think everything looks mostly good! I found one possible bug and made a couple comments about how I'm frustrated about code duplication. https://github.com/llvm/llvm-project/pull/68170 __

[clang] [analyzer] WebKit checkers: support ref and deref defined on different classes. (PR #68170)

2023-10-19 Thread Artem Dergachev via cfe-commits
@@ -18,24 +18,26 @@ using namespace clang; namespace { -bool hasPublicRefAndDeref(const CXXRecordDecl *R) { +bool hasPublicRefMethod(const CXXRecordDecl *R) { assert(R); assert(R->hasDefinition()); - bool hasRef = false; - bool hasDeref = false; for (const CXXMet

[clang] [analyzer] WebKit checkers: support ref and deref defined on different classes. (PR #68170)

2023-10-19 Thread Artem Dergachev via cfe-commits
@@ -70,29 +88,45 @@ std::optional isRefCountable(const CXXRecordDecl* R) if (!R) return std::nullopt; - if (hasPublicRefAndDeref(R)) + bool hasRef = hasPublicRefMethod(R); + bool hasDeref = hasPublicDerefMethod(R); + if (hasRef && hasDeref) return true; CXX

[clang] [analyzer] WebKit checkers: support ref and deref defined on different classes. (PR #68170)

2023-10-19 Thread Artem Dergachev via cfe-commits
@@ -44,9 +46,25 @@ bool hasPublicRefAndDeref(const CXXRecordDecl *R) { namespace clang { -std::optional -isRefCountable(const CXXBaseSpecifier* Base) -{ +std::optional +hasPublicRefInBase(const CXXBaseSpecifier *Base) { + assert(Base); + + const Type *T = Base->getType().ge

[clang] Update stdckdint.h and make it available in pre-C23 modes. (PR #69649)

2023-10-19 Thread Jessica Clarke via cfe-commits
@@ -33,8 +33,3 @@ #error "__STDC_VERSION_STDINT_H__ not defined" // expected-error@-1 {{"__STDC_VERSION_STDINT_H__ not defined"}} #endif - -#include -#ifndef __STDC_VERSION_STDCKDINT_H__ -#error "__STDC_VERSION_STDCKDINT_H__ not defined" jrtc27 wrote: And thi

[clang] Update stdckdint.h and make it available in pre-C23 modes. (PR #69649)

2023-10-19 Thread Jessica Clarke via cfe-commits
@@ -177,7 +177,7 @@ C23 Feature Support - Clang now supports ``N3007 Type inference for object definitions``. - Clang now supports which defines several macros for performing - checked integer arithmetic. + checked integer arithmetic. And it is also exposed in pre-C23

[clang] Update stdckdint.h and make it available in pre-C23 modes. (PR #69649)

2023-10-19 Thread Jessica Clarke via cfe-commits
@@ -21,9 +21,6 @@ /* C23 7.20.1 Defines several macros for performing checked integer arithmetic*/ -#if defined(__STDC_VERSION__) && __STDC_VERSION__ >= 202311L -#define __STDC_VERSION_STDCKDINT_H__ 202311L jrtc27 wrote: This needs to stay, `__STDC_VERSION_

[clang] [Profile] Refactor profile correlation. (PR #69656)

2023-10-19 Thread Zequan Wu via cfe-commits
https://github.com/ZequanWu created https://github.com/llvm/llvm-project/pull/69656 Refactor some code from #69493. >From 89f041c62da8c0924ee45a6ed8d9ab7afb560935 Mon Sep 17 00:00:00 2001 From: Zequan Wu Date: Thu, 19 Oct 2023 18:55:08 -0400 Subject: [PATCH] [Profile] Refactor profile correla

[clang] [Profile] Refactor profile correlation. (PR #69656)

2023-10-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Zequan Wu (ZequanWu) Changes Refactor some code from #69493. --- Patch is 37.13 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/69656.diff 21 Files Affected: - (modified) clang/lib/C

[clang] [Profile] Refactor profile correlation. (PR #69656)

2023-10-19 Thread David Li via cfe-commits
https://github.com/david-xl approved this pull request. https://github.com/llvm/llvm-project/pull/69656 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Update stdckdint.h and make it available in pre-C23 modes. (PR #69649)

2023-10-19 Thread via cfe-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/69649 >From 0c57e45f6ee16e43cc6388b1ca6beb88bbc7b925 Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Thu, 19 Oct 2023 22:23:03 + Subject: [PATCH] Update stdckdint.h and make it available in pre-C23 modes. Upda

[clang] Update stdckdint.h and make it available in pre-C23 modes. (PR #69649)

2023-10-19 Thread via cfe-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/69649 >From 0c57e45f6ee16e43cc6388b1ca6beb88bbc7b925 Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Thu, 19 Oct 2023 22:23:03 + Subject: [PATCH 1/2] Update stdckdint.h and make it available in pre-C23 modes.

[clang] 5070c1e - [analyzer] WebKit checkers: recognize dynamicDowncast as a safe function.

2023-10-19 Thread Artem Dergachev via cfe-commits
Author: Ryosuke Niwa Date: 2023-10-19T16:10:57-07:00 New Revision: 5070c1e3b07c5b384fe0a064aa99f25b8af4b7e9 URL: https://github.com/llvm/llvm-project/commit/5070c1e3b07c5b384fe0a064aa99f25b8af4b7e9 DIFF: https://github.com/llvm/llvm-project/commit/5070c1e3b07c5b384fe0a064aa99f25b8af4b7e9.diff

[clang] Update stdckdint.h and make it available in pre-C23 modes. (PR #69649)

2023-10-19 Thread via cfe-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/69649 >From 0c57e45f6ee16e43cc6388b1ca6beb88bbc7b925 Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Thu, 19 Oct 2023 22:23:03 + Subject: [PATCH 1/2] Update stdckdint.h and make it available in pre-C23 modes.

[clang] [Modules] textual headers in submodules never resolve their `use`s (PR #69651)

2023-10-19 Thread Ian Anderson via cfe-commits
https://github.com/ian-twilightcoder updated https://github.com/llvm/llvm-project/pull/69651 >From 7b88bf3102240d1734feab8919a049f8a92ca0e0 Mon Sep 17 00:00:00 2001 From: Ian Anderson Date: Thu, 19 Oct 2023 15:22:11 -0700 Subject: [PATCH] [Modules] textual headers in submodules never resolve th

[clang] Update stdckdint.h and make it available in pre-C23 modes. (PR #69649)

2023-10-19 Thread via cfe-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/69649 >From 0c57e45f6ee16e43cc6388b1ca6beb88bbc7b925 Mon Sep 17 00:00:00 2001 From: zijunzhao Date: Thu, 19 Oct 2023 22:23:03 + Subject: [PATCH 1/3] Update stdckdint.h and make it available in pre-C23 modes.

[clang] [Modules] textual headers in submodules never resolve their `use`s (PR #69651)

2023-10-19 Thread Michael Spencer via cfe-commits
https://github.com/Bigcheese approved this pull request. LGTM. The rest of clang reasons about this at the top level module, so so should this. https://github.com/llvm/llvm-project/pull/69651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[clang] [clang-format] Skip PP directives when determining brace kind (PR #69473)

2023-10-19 Thread Owen Pan via cfe-commits
@@ -491,11 +491,19 @@ void UnwrappedLineParser::calculateBraceTypes(bool ExpectClassBody) { SmallVector LBraceStack; assert(Tok->is(tok::l_brace)); do { -// Get next non-comment token. -FormatToken *NextTok; -do { - NextTok = Tokens->getNextToken(); -

[clang] [clang-format] Skip PP directives when determining brace kind (PR #69473)

2023-10-19 Thread Owen Pan via cfe-commits
owenca wrote: > Here's my solution to one of the regressions I caused (#68404) I don't think it's a regression. On the contrary, it actually exposed another bug. :) https://github.com/llvm/llvm-project/pull/69473 ___ cfe-commits mailing list cfe-com

[clang] [clang-format] Skip PP directives when determining brace kind (PR #69473)

2023-10-19 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/69473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Use XMACROS for MachO platforms. (PR #69262)

2023-10-19 Thread Juergen Ributzka via cfe-commits
ributzka wrote: Unrelated build issue on windows: C:\ws\src\mlir\include\mlir/IR/BuiltinTypeInterfaces.h(14): fatal error C1083: Cannot open include file: 'mlir/IR/BuiltinTypeInterfaces.h.inc': No such file or directory https://github.com/llvm/llvm-project/pull/69262 __

[clang-tools-extra] [Docs][LTO] Updated HowToSubmitABug.rst for LTO crashes (PR #68389)

2023-10-19 Thread Matheus Izvekov via cfe-commits
@@ -153,6 +153,67 @@ Please run this, then file a bug with the instructions and reduced .bc file that bugpoint emits. If something goes wrong with bugpoint, please submit the "foo.bc" file and the option that llc crashes with. +LTO bugs +--- + +If you

[clang] [llvm] Use XMACROS for MachO platforms. (PR #69262)

2023-10-19 Thread Juergen Ributzka via cfe-commits
https://github.com/ributzka updated https://github.com/llvm/llvm-project/pull/69262 >From ceaf58ba2f752b8a5353568013ff18603b0e615b Mon Sep 17 00:00:00 2001 From: Juergen Ributzka Date: Mon, 28 Aug 2023 15:25:48 -0700 Subject: [PATCH] [llvm] Use XMACROS for MachO platforms. This change adds the

[clang] [clang][repl] fix `new` on Mac M1 (PR #69072)

2023-10-19 Thread Vassil Vassilev via cfe-commits
@@ -275,7 +274,14 @@ Interpreter::create(std::unique_ptr CI) { if (Err) return std::move(Err); - auto PTU = Interp->Parse(Runtimes); + std::string runtimes = ""; + if (llvm::Triple(llvm::sys::getProcessTriple()).isOSDarwin()) +runtimes += "#include \n"; --

[clang] Let clang-cl support CUDA/HIP (PR #68921)

2023-10-19 Thread Nico Weber via cfe-commits
nico wrote: Hello, it looks like this breaks check-clang on mac: http://45.33.8.238/macm1/71368/step_7.txt Please take a look and revert for now if it takes a while to fix. https://github.com/llvm/llvm-project/pull/68921 ___ cfe-commits mailing list

[clang] [Windows] Add git-clang-format wrapper bat file (PR #69228)

2023-10-19 Thread Owen Pan via cfe-commits
owenca wrote: @mydeveloperday what do you think? https://github.com/llvm/llvm-project/pull/69228 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Skip PP directives when determining brace kind (PR #69473)

2023-10-19 Thread Emilia Kond via cfe-commits
@@ -491,11 +491,19 @@ void UnwrappedLineParser::calculateBraceTypes(bool ExpectClassBody) { SmallVector LBraceStack; assert(Tok->is(tok::l_brace)); do { -// Get next non-comment token. -FormatToken *NextTok; -do { - NextTok = Tokens->getNextToken(); -

[clang] [clang-format] Skip PP directives when determining brace kind (PR #69473)

2023-10-19 Thread Owen Pan via cfe-commits
@@ -491,11 +491,19 @@ void UnwrappedLineParser::calculateBraceTypes(bool ExpectClassBody) { SmallVector LBraceStack; assert(Tok->is(tok::l_brace)); do { -// Get next non-comment token. -FormatToken *NextTok; -do { - NextTok = Tokens->getNextToken(); -

[clang] [clang-format] Skip PP directives when determining brace kind (PR #69473)

2023-10-19 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/69473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Skip PP directives when determining brace kind (PR #69473)

2023-10-19 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/69473 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Skip PP directives when determining brace kind (PR #69473)

2023-10-19 Thread Owen Pan via cfe-commits
@@ -491,11 +491,19 @@ void UnwrappedLineParser::calculateBraceTypes(bool ExpectClassBody) { SmallVector LBraceStack; assert(Tok->is(tok::l_brace)); do { -// Get next non-comment token. -FormatToken *NextTok; -do { - NextTok = Tokens->getNextToken(); -

[clang] Let clang-cl support CUDA/HIP (PR #68921)

2023-10-19 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: [AMD Official Use Only - General] Will fix it now. Thanks. Sam From: Nico Weber ***@***.***> Sent: Thursday, October 19, 2023 8:03 PM To: llvm/llvm-project ***@***.***> Cc: Liu, Yaxun (Sam) ***@***.***>; State change ***@***.***> Subject: Re: [llvm/llvm-project] Let clang-cl su

[clang] [X86][AMX] remove related code of X86PreAMXConfigPass (PR #69569)

2023-10-19 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata approved this pull request. LGTM. Thanks! https://github.com/llvm/llvm-project/pull/69569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9d10fbb - Fix test clang/test/Driver/cl-offload.cu

2023-10-19 Thread Yaxun Liu via cfe-commits
Author: Yaxun (Sam) Liu Date: 2023-10-19T21:48:05-04:00 New Revision: 9d10fbbb299eae4a63f1028274e2ffe92bf8e75a URL: https://github.com/llvm/llvm-project/commit/9d10fbbb299eae4a63f1028274e2ffe92bf8e75a DIFF: https://github.com/llvm/llvm-project/commit/9d10fbbb299eae4a63f1028274e2ffe92bf8e75a.dif

[clang] Let clang-cl support CUDA/HIP (PR #68921)

2023-10-19 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: [AMD Official Use Only - General] Fixed by 9d10fbbb299eae4a63f1028274e2ffe92bf8e75a From: Nico Weber ***@***.***> Sent: Thursday, October 19, 2023 8:03 PM To: llvm/llvm-project ***@***.***> Cc: Liu, Yaxun (Sam) ***@***.***>; State change ***@***.***> Subject: Re: [llvm/llvm-proj

[clang] [RISCV] Support Xsfvqmaccdod and Xsfvqmaccqoq extensions (PR #68295)

2023-10-19 Thread Brandon Wu via cfe-commits
@@ -558,6 +558,12 @@ DecodeStatus RISCVDisassembler::getInstruction(MCInst &MI, uint64_t &Size, "XTHeadVdot custom opcode table"); TRY_TO_DECODE_FEATURE(RISCV::FeatureVendorXSfvcp, DecoderTableXSfvcp32, "SiFive VCIX custo

[clang] [RISCV] Support Xsfvqmaccdod and Xsfvqmaccqoq extensions (PR #68295)

2023-10-19 Thread Brandon Wu via cfe-commits
@@ -476,6 +524,31 @@ class GetFTypeInfo { !eq(Scalar, f64) : "FPR64"); } +multiclass VPatVMACC info_pairs, ValueType vec_m1> { + foreach pair = info_pairs in { +defvar VdInfo = pair.Wti; +defvar Vs2Info = pair.Vti; +let Predicates = [

[clang] [FixBUG][llvm-tblgen] : The correct td file ending with #endif cannot be compiled (PR #69411)

2023-10-19 Thread zhao jiangtao via cfe-commits
https://github.com/whousemyname updated https://github.com/llvm/llvm-project/pull/69411 >From 043d29cd597a7447037286293fe1a1b3ccf8d79d Mon Sep 17 00:00:00 2001 From: angryZ Date: Wed, 18 Oct 2023 10:39:56 +0800 Subject: [PATCH] [llvm][Tablegen][BUG] : The correct td file ending with #endif (th

[clang-tools-extra] [FixBUG][llvm-tblgen] : The correct td file ending with #endif cannot be compiled (PR #69411)

2023-10-19 Thread zhao jiangtao via cfe-commits
https://github.com/whousemyname updated https://github.com/llvm/llvm-project/pull/69411 >From 043d29cd597a7447037286293fe1a1b3ccf8d79d Mon Sep 17 00:00:00 2001 From: angryZ Date: Wed, 18 Oct 2023 10:39:56 +0800 Subject: [PATCH] [llvm][Tablegen][BUG] : The correct td file ending with #endif (th

[PATCH] D108905: [ItaniumCXXABI] Add -fassume-nothrow-exception-dtor to assume that an exception object' destructor is nothrow

2023-10-19 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay updated this revision to Diff 557798. MaskRay retitled this revision from "[ItaniumCXXABI] Make __cxa_end_catch calls unconditionally nounwind" to "[ItaniumCXXABI] Add -fassume-nothrow-exception-dtor to assume that an exception object' destructor is nothrow". MaskRay edited the summary o

[clang] [RISCV] Support Xsfvqmaccdod and Xsfvqmaccqoq extensions (PR #68295)

2023-10-19 Thread Craig Topper via cfe-commits
https://github.com/topperc approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/68295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ✨ [Sema, Lex, Parse] Preprocessor embed in C and C++ (and Obj-C and Obj-C++ by-proxy) (PR #68620)

2023-10-19 Thread via cfe-commits
h-vetinari wrote: JeanHeyd wrote up a [blog post](https://thephd.dev/implementing-embed-c-and-c++) about this implementation, which is probably helpful as background material for any prospective reviewers. :) https://github.com/llvm/llvm-project/pull/68620

[clang] [RISCV] Support Xsfvqmaccdod and Xsfvqmaccqoq extensions (PR #68295)

2023-10-19 Thread Brandon Wu via cfe-commits
https://github.com/4vtomat closed https://github.com/llvm/llvm-project/pull/68295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D108905: [ItaniumCXXABI] Add -fassume-nothrow-exception-dtor to assume that an exception object' destructor is nothrow

2023-10-19 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. This looks great to me, thanks. @rjmccall should sign off on it though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108905/new/ https://reviews.llvm.org/D108905 ___ cfe-commits

[clang] [clang][repl] fix `new` on Mac M1 (PR #69072)

2023-10-19 Thread Maksim Levental via cfe-commits
https://github.com/makslevental updated https://github.com/llvm/llvm-project/pull/69072 >From d7c57d94d7e75ed1e0df87ebf3c4464e7b951453 Mon Sep 17 00:00:00 2001 From: max Date: Sat, 14 Oct 2023 12:46:42 -0500 Subject: [PATCH 1/3] [clang][repl] fix `new` --- clang/lib/Interpreter/Interpreter.cp

[clang] Reland "[clang][Sema] Use original template pattern when declaring implicit deduction guides for nested template classes" (PR #69676)

2023-10-19 Thread via cfe-commits
https://github.com/antangelo created https://github.com/llvm/llvm-project/pull/69676 Reland of dd0fba11690f9fef304d5f48cde646e5eca8d3c0 When a nested template is instantiated, the template pattern of the inner class is not copied into the outer class ClassTemplateSpecializationDecl. The specia

[clang] Reland "[clang][Sema] Use original template pattern when declaring implicit deduction guides for nested template classes" (PR #69676)

2023-10-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (antangelo) Changes Reland of dd0fba11690f9fef304d5f48cde646e5eca8d3c0 When a nested template is instantiated, the template pattern of the inner class is not copied into the outer class ClassTemplateSpecializationDecl. The specializa

[clang] [clang][Sema] Use original template pattern when declaring implicit deduction guides for nested template classes (PR #68379)

2023-10-19 Thread via cfe-commits
antangelo wrote: I've posted a candidate reland of this PR at #69676 . https://github.com/llvm/llvm-project/pull/68379 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Convert all floating point vector type operands to integer vector type (PR #69559)

2023-10-19 Thread Craig Topper via cfe-commits
@@ -450,6 +474,18 @@ multiclass VPatVC_XVV; + // Add another patterns for float type return value. + if !ne(wti.SEW, 8) then { +defvar wfti = !cast("VF"#wti.SEW#wti.LMul.MX); topperc wrote: Do we need new tests for this? https://github.com/llvm/llvm-projec

[clang] [Sema] Fixed faulty shift count warning (PR #69521)

2023-10-19 Thread Karl-Johan Karlsson via cfe-commits
https://github.com/karka228 updated https://github.com/llvm/llvm-project/pull/69521 >From a9bfc65f6d6b0953cd762f851fb6044e1c4b8ab8 Mon Sep 17 00:00:00 2001 From: Karl-Johan Karlsson Date: Wed, 18 Oct 2023 16:40:53 +0200 Subject: [PATCH 1/2] [Sema] Fixed faulty shift count warning Constant valu

[clang] [Driver] Corrections for linker flags passed with relocatable linking on OpenBSD (PR #67254)

2023-10-19 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/67254 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Corrections for linker flags passed with relocatable linking on OpenBSD (PR #67254)

2023-10-19 Thread Fangrui Song via cfe-commits
MaskRay wrote: `-Bdynamic` is the linker default, so you can remove it. Gnu.cpp uses `-Bdynamic` like `)` to close `-Bstatic`: `-Bstatic ... `-Bdynamic` https://github.com/llvm/llvm-project/pull/67254 ___ cfe-commits mailing list cfe-commits@lists.llv

[clang] [PGO] Add ability to mark cold functions as optsize/minsize/optnone (PR #69030)

2023-10-19 Thread David Li via cfe-commits
@@ -0,0 +1,65 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang] [Driver] Corrections for linker flags passed with relocatable linking on OpenBSD (PR #67254)

2023-10-19 Thread Fangrui Song via cfe-commits
@@ -36,10 +36,12 @@ // RUN: | FileCheck --check-prefix=CHECK-MIPS64-LD %s // RUN: %clang --target=mips64el-unknown-openbsd -### %s 2>&1 \ // RUN: | FileCheck --check-prefix=CHECK-MIPS64EL-LD %s -// CHECK-LD-R: "-r" +// CHECK-LD-R-NOT: "-e" "__start" Mas

[clang] [clang] [unittest] Add a test for Generic_GCC::GCCVersion::Parse (PR #69078)

2023-10-19 Thread Fangrui Song via cfe-commits
MaskRay wrote: I hope that we do not drop `LLVM_LIBRARY_VISIBILITY` arbitrarily from `clang::driver::toolchains::*` classes, just because some unittests need to reference the symbols in a shared object. ```c #if !defined(LLVM_BUILD_SHARED_LIBS) ``` is not great but is not too bad. `-DBUILD_SH

[clang] [clang][repl] fix `new` on Mac M1 (PR #69072)

2023-10-19 Thread Maksim Levental via cfe-commits
https://github.com/makslevental updated https://github.com/llvm/llvm-project/pull/69072 >From f2d35a0f0356d5ea570019bc02558bd5fc143afb Mon Sep 17 00:00:00 2001 From: max Date: Sat, 14 Oct 2023 12:46:42 -0500 Subject: [PATCH 1/3] [clang][repl] fix `new` --- clang/lib/Interpreter/Interpreter.cp

[clang] [clang][repl] fix `new` on Mac M1 (PR #69072)

2023-10-19 Thread Maksim Levental via cfe-commits
https://github.com/makslevental updated https://github.com/llvm/llvm-project/pull/69072 >From 737bef4f36139f0347e9ab58838e41aadbb45d16 Mon Sep 17 00:00:00 2001 From: max Date: Sat, 14 Oct 2023 12:46:42 -0500 Subject: [PATCH] [clang][repl] fix `new` --- clang/lib/Interpreter/Interpreter.cpp

[clang-tools-extra] [clang-tidy] Improved cppcoreguidelines-pro-type-const-cast (PR #69501)

2023-10-19 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 approved this pull request. https://github.com/llvm/llvm-project/pull/69501 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Improved cppcoreguidelines-pro-type-const-cast (PR #69501)

2023-10-19 Thread Congcong Cai via cfe-commits
@@ -14,13 +14,42 @@ using namespace clang::ast_matchers; namespace clang::tidy::cppcoreguidelines { +static bool hasConstQualifier(QualType Type) { + const QualType PtrType = Type->getPointeeType(); + if (!PtrType.isNull()) +return hasConstQualifier(PtrType); + + retur

[clang-tools-extra] [clang-tidy] Improved cppcoreguidelines-pro-type-const-cast (PR #69501)

2023-10-19 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 edited https://github.com/llvm/llvm-project/pull/69501 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Convert all floating point vector type operands to integer vector type (PR #69559)

2023-10-19 Thread Brandon Wu via cfe-commits
@@ -450,6 +474,18 @@ multiclass VPatVC_XVV; + // Add another patterns for float type return value. + if !ne(wti.SEW, 8) then { +defvar wfti = !cast("VF"#wti.SEW#wti.LMul.MX); 4vtomat wrote: Yes, I'll add some tests for it~ https://github.com/llvm/llvm-proj

[clang-tools-extra] [clang-tidy] Improved cppcoreguidelines-pro-type-const-cast (PR #69501)

2023-10-19 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 edited https://github.com/llvm/llvm-project/pull/69501 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Improved cppcoreguidelines-pro-type-const-cast (PR #69501)

2023-10-19 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 edited https://github.com/llvm/llvm-project/pull/69501 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Improved cppcoreguidelines-pro-type-const-cast (PR #69501)

2023-10-19 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 edited https://github.com/llvm/llvm-project/pull/69501 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Improved cppcoreguidelines-pro-type-const-cast (PR #69501)

2023-10-19 Thread Congcong Cai via cfe-commits
@@ -14,13 +14,42 @@ using namespace clang::ast_matchers; namespace clang::tidy::cppcoreguidelines { +static bool hasConstQualifier(QualType Type) { + const QualType PtrType = Type->getPointeeType(); + if (!PtrType.isNull()) +return hasConstQualifier(PtrType); + + retur

[clang] [clang]Avoid to check created local variable multiple time when evaluating (PR #69106)

2023-10-19 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/69106 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Convert all floating point vector type operands to integer vector type (PR #69559)

2023-10-19 Thread Brandon Wu via cfe-commits
@@ -450,6 +474,18 @@ multiclass VPatVC_XVV; + // Add another patterns for float type return value. + if !ne(wti.SEW, 8) then { +defvar wfti = !cast("VF"#wti.SEW#wti.LMul.MX); 4vtomat wrote: Do you think test cases all of combination of vector type arguments

[clang] [clang][repl] fix `new` on Mac M1 (PR #69072)

2023-10-19 Thread Maksim Levental via cfe-commits
https://github.com/makslevental updated https://github.com/llvm/llvm-project/pull/69072 >From 940da2de0fc92e8e0da64fd35ad08effb6093447 Mon Sep 17 00:00:00 2001 From: max Date: Sat, 14 Oct 2023 12:46:42 -0500 Subject: [PATCH] [clang][repl] fix `new` --- clang/lib/Interpreter/Interpreter.cpp

[clang] [clang] [unittest] Add a test for Generic_GCC::GCCVersion::Parse (PR #69078)

2023-10-19 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: > I hope that we do not drop `LLVM_LIBRARY_VISIBILITY` arbitrarily from > `clang::driver::toolchains::*` classes, just because some unittests need to > reference the symbols in a shared object. That’s a reasonable point. > ```c > #if !defined(LLVM_BUILD_SHARED_LIBS) > ``` > >

[clang] [clang][repl] fix `new` on Mac M1 (PR #69072)

2023-10-19 Thread Maksim Levental via cfe-commits
makslevental wrote: @vgvassilev this seems acceptable? https://github.com/llvm/llvm-project/pull/69072 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   5   >