[clang] b4b35a5 - [clang] [unittest] Add a test for Generic_GCC::GCCVersion::Parse (#69078)

2023-10-18 Thread via cfe-commits
Author: Martin Storsjö Date: 2023-10-18T12:36:27+03:00 New Revision: b4b35a5d2b4ee26bf79b8a92715dd200f3f9cc49 URL: https://github.com/llvm/llvm-project/commit/b4b35a5d2b4ee26bf79b8a92715dd200f3f9cc49 DIFF: https://github.com/llvm/llvm-project/commit/b4b35a5d2b4ee26bf79b8a92715dd200f3f9cc49.diff

[clang] [clang] [unittest] Add a test for Generic_GCC::GCCVersion::Parse (PR #69078)

2023-10-18 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo closed https://github.com/llvm/llvm-project/pull/69078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] [Gnu] Improve GCCVersion parsing to match versions such as "10-win32" (PR #69079)

2023-10-18 Thread Martin Storsjö via cfe-commits
https://github.com/mstorsjo updated https://github.com/llvm/llvm-project/pull/69079 From 468befbb3eeaa0a23b001141976108157608e11d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Storsj=C3=B6?= Date: Sat, 14 Oct 2023 00:55:18 +0300 Subject: [PATCH] [clang] [Gnu] Improve GCCVersion parsing to m

[clang] [clang] [Gnu] Improve GCCVersion parsing to match versions such as "10-win32" (PR #69079)

2023-10-18 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: The prerequisite to this PR has been merged now. https://github.com/llvm/llvm-project/pull/69079 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 675231e - [SVE ACLE] Allow default zero initialisation for svcount_t. (#69321)

2023-10-18 Thread via cfe-commits
Author: Paul Walker Date: 2023-10-18T10:40:07+01:00 New Revision: 675231eb09ca37a8b76f748c0b73a1e26604ff20 URL: https://github.com/llvm/llvm-project/commit/675231eb09ca37a8b76f748c0b73a1e26604ff20 DIFF: https://github.com/llvm/llvm-project/commit/675231eb09ca37a8b76f748c0b73a1e26604ff20.diff L

[clang] [SVE ACLE] Allow default zero initialisation for svcount_t. (PR #69321)

2023-10-18 Thread Paul Walker via cfe-commits
https://github.com/paulwalker-arm closed https://github.com/llvm/llvm-project/pull/69321 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Link Flang runtime on Solaris (PR #65644)

2023-10-18 Thread Rainer Orth via cfe-commits
@@ -2,8 +2,9 @@ ! invocation. These libraries are added on top of other standard runtime ! libraries that the Clang driver will include. -! RUN: %flang -### -target ppc64le-linux-gnu %S/Inputs/hello.f90 2>&1 | FileCheck %s --check-prefixes=CHECK,GNU +! RUN: %flang -### -targe

[clang] [Driver] Link Flang runtime on Solaris (PR #65644)

2023-10-18 Thread Rainer Orth via cfe-commits
@@ -21,12 +22,12 @@ ! run on any other platform, such as Windows that use a .exe ! suffix. Clang's driver will try to resolve the path to the ld ! executable and may find the GNU linker from MinGW or Cygwin. -! GNU-LABEL: "{{.*}}ld{{(\.exe)?}}" -! GNU-SAME: "

[clang] [Driver] Link Flang runtime on Solaris (PR #65644)

2023-10-18 Thread Rainer Orth via cfe-commits
https://github.com/rorth updated https://github.com/llvm/llvm-project/pull/65644 >From 31bdd3477d9f54996b71584598bdd75f2cef31db Mon Sep 17 00:00:00 2001 From: Rainer Orth Date: Thu, 7 Sep 2023 19:19:32 +0200 Subject: [PATCH 1/3] [Driver] Link Flang runtime on Solaris I noticed that `flang-new`

[clang] [AMDGPU] Fix image intrinsic optimizer on loads from different resources (PR #69355)

2023-10-18 Thread Jay Foad via cfe-commits
https://github.com/jayfoad closed https://github.com/llvm/llvm-project/pull/69355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [AMDGPU] Fix image intrinsic optimizer on loads from different resources (PR #69355)

2023-10-18 Thread Jay Foad via cfe-commits
https://github.com/jayfoad closed https://github.com/llvm/llvm-project/pull/69355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

2023-10-18 Thread Sunil K via Phabricator via cfe-commits
koops updated this revision to Diff 557749. koops added a comment. Removed the tail-allocation. Other changes suggested in the previous review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123235/new/ https://reviews.llvm.org/D123235 Files: clang/include/clang/AST/ASTNodeTraverser.h

[clang-tools-extra] [analyzer] Add std::variant checker (PR #66481)

2023-10-18 Thread Gábor Spaits via cfe-commits
spaits wrote: @steakhal we have also run the checker on multiple open source projects (a few weeks ago) and it did not crash. (It did not have any findings. There were only two C++ 17 projects and they had retrieved value from std::variant at most 20 times). Could you please take another look

[clang] [clang][Interp] Implement __builtin_bit_cast (PR #68288)

2023-10-18 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: tbaederr wrote: @AaronBallman This is still in a rough WIP state, but I've added support for bitcasts with bitfields involved, take a look at the

[clang-tools-extra] [include-cleaner] Handle symbols from system headers. (PR #66089)

2023-10-18 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet edited https://github.com/llvm/llvm-project/pull/66089 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [include-cleaner] Handle symbols from system headers. (PR #66089)

2023-10-18 Thread kadir çetinkaya via cfe-commits
@@ -176,6 +180,104 @@ headersForSpecialSymbol(const Symbol &S, const SourceManager &SM, return std::nullopt; } +// A hand-mainained list of include mappings for system headers. +// The first element is the suffix of the physical file path for the system +// header, the seco

[clang-tools-extra] [include-cleaner] Handle symbols from system headers. (PR #66089)

2023-10-18 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet commented: thanks a lot, and so sorry for taking so long on getting to this https://github.com/llvm/llvm-project/pull/66089 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[clang-tools-extra] [include-cleaner] Handle symbols from system headers. (PR #66089)

2023-10-18 Thread kadir çetinkaya via cfe-commits
@@ -176,6 +180,104 @@ headersForSpecialSymbol(const Symbol &S, const SourceManager &SM, return std::nullopt; } +// A hand-mainained list of include mappings for system headers. +// The first element is the suffix of the physical file path for the system +// header, the seco

[clang-tools-extra] [include-cleaner] Handle symbols from system headers. (PR #66089)

2023-10-18 Thread kadir çetinkaya via cfe-commits
@@ -176,6 +180,104 @@ headersForSpecialSymbol(const Symbol &S, const SourceManager &SM, return std::nullopt; } +// A hand-mainained list of include mappings for system headers. +// The first element is the suffix of the physical file path for the system +// header, the seco

[clang-tools-extra] [include-cleaner] Handle symbols from system headers. (PR #66089)

2023-10-18 Thread kadir çetinkaya via cfe-commits
@@ -176,6 +180,104 @@ headersForSpecialSymbol(const Symbol &S, const SourceManager &SM, return std::nullopt; } +// A hand-mainained list of include mappings for system headers. +// The first element is the suffix of the physical file path for the system +// header, the seco

[clang-tools-extra] [include-cleaner] Handle symbols from system headers. (PR #66089)

2023-10-18 Thread kadir çetinkaya via cfe-commits
@@ -176,6 +180,104 @@ headersForSpecialSymbol(const Symbol &S, const SourceManager &SM, return std::nullopt; } +// A hand-mainained list of include mappings for system headers. +// The first element is the suffix of the physical file path for the system +// header, the seco

[clang-tools-extra] [include-cleaner] Handle symbols from system headers. (PR #66089)

2023-10-18 Thread kadir çetinkaya via cfe-commits
@@ -176,6 +180,104 @@ headersForSpecialSymbol(const Symbol &S, const SourceManager &SM, return std::nullopt; } +// A hand-mainained list of include mappings for system headers. +// The first element is the suffix of the physical file path for the system +// header, the seco

[clang-tools-extra] [include-cleaner] Handle symbols from system headers. (PR #66089)

2023-10-18 Thread kadir çetinkaya via cfe-commits
@@ -188,6 +290,20 @@ llvm::SmallVector> findHeaders(const SymbolLocation &Loc, OptionalFileEntryRef FE = SM.getFileEntryRefForID(FID); if (!FE) return {}; + +if (SrcMgr::isSystem( +SM.getSLocEntry(FID).getFile().getFileCharacteristic())) { +

[clang-tools-extra] [include-cleaner] Handle symbols from system headers. (PR #66089)

2023-10-18 Thread kadir çetinkaya via cfe-commits
@@ -188,6 +290,20 @@ llvm::SmallVector> findHeaders(const SymbolLocation &Loc, OptionalFileEntryRef FE = SM.getFileEntryRefForID(FID); if (!FE) return {}; + +if (SrcMgr::isSystem( kadircet wrote: i am afraid this check might be overly strict

[clang-tools-extra] [include-cleaner] Handle symbols from system headers. (PR #66089)

2023-10-18 Thread kadir çetinkaya via cfe-commits
@@ -176,6 +180,104 @@ headersForSpecialSymbol(const Symbol &S, const SourceManager &SM, return std::nullopt; } +// A hand-mainained list of include mappings for system headers. +// The first element is the suffix of the physical file path for the system +// header, the seco

[clang-tools-extra] [include-cleaner] Handle symbols from system headers. (PR #66089)

2023-10-18 Thread kadir çetinkaya via cfe-commits
@@ -176,6 +180,104 @@ headersForSpecialSymbol(const Symbol &S, const SourceManager &SM, return std::nullopt; } +// A hand-mainained list of include mappings for system headers. +// The first element is the suffix of the physical file path for the system +// header, the seco

[clang] [NVPTX] Fixed some wmma store builtins that had non-const src param. (PR #69354)

2023-10-18 Thread via cfe-commits
JackAKirk wrote: cc @Artem-B https://github.com/llvm/llvm-project/pull/69354 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D123235: [OpenMP] atomic compare fail : Parser & AST support

2023-10-18 Thread Alexey Bataev via Phabricator via cfe-commits
ABataev added inline comments. Comment at: clang/include/clang/AST/ASTNodeTraverser.h:217-220 +if (const auto *OMPC = dyn_cast(C)) { + Visit(OMPC); + return; +} Why do you need special logic here? Comment at: clang/include/cla

[PATCH] D151439: [Clang][SVE2.1] Add builtins for 2-way svdot (vectors, indexed)

2023-10-18 Thread Caroline via Phabricator via cfe-commits
CarolineConcatto updated this revision to Diff 557751. CarolineConcatto added a comment. Herald added a subscriber: sunshaoce. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151439/new/ https://reviews.llvm.org/D151439 Files: clang/include

[PATCH] D151199: [Clang][SVE2.1] Add pfalse builtin

2023-10-18 Thread Dinar Temirbulatov via Phabricator via cfe-commits
dtemirbulatov accepted this revision. dtemirbulatov added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151199/new/ https://reviews.llvm.org/D151199

[PATCH] D151197: [Clang][SVE2p1] Add svpsel builtins

2023-10-18 Thread Kerry McLaughlin via Phabricator via cfe-commits
kmclaughlin accepted this revision. kmclaughlin added a comment. This revision is now accepted and ready to land. Thank you for updating this @CarolineConcatto, LGTM Comment at: clang/include/clang/Basic/arm_sve.td:1886 + + nit: extra whitespace Repository:

[clang] [AMDGPU] Remove Code Object V3 (PR #67118)

2023-10-18 Thread Andrew Stubbs via cfe-commits
ams-cs wrote: @Pierre-vh Can we undo this please? Just for now. This broke the GCC build (which uses llvm-mc) because we still use v3 like @tob2 said. I don't know that anyone is using Fiji in production, but it's still a good proportion of what we have in our compiler test farm. As far as I

[PATCH] D151461: [Clang][SVE2.1] Add builtins and intrinsics for SVBFMLSLB/T

2023-10-18 Thread Caroline via Phabricator via cfe-commits
CarolineConcatto updated this revision to Diff 557754. CarolineConcatto added a comment. -rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151461/new/ https://reviews.llvm.org/D151461 Files: clang/include/clang/Basic/arm_sve.td clang/inclu

[clang] [AMDGPU] Remove Code Object V3 (PR #67118)

2023-10-18 Thread Pierre van Houtryve via cfe-commits
Pierre-vh wrote: I don't mind reverting, but do you have a timeline for removal of that device? v3 has been deprecated for a while, AFAIK. https://github.com/llvm/llvm-project/pull/67118 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang-tools-extra] [libc++] Add assertions for potential OOB reads in std::nth_element (PR #67023)

2023-10-18 Thread Daniel Kutenin via cfe-commits
https://github.com/danlark1 updated https://github.com/llvm/llvm-project/pull/67023 >From 059bbfab50592026ce2785c5f7d98eaf5c9f8bd6 Mon Sep 17 00:00:00 2001 From: Daniel Kutenin Date: Thu, 21 Sep 2023 14:55:11 +0100 Subject: [PATCH 1/7] Add bound checking in nth_element --- libcxx/include/__al

[clang] [libc++] Add assertions for potential OOB reads in std::nth_element (PR #67023)

2023-10-18 Thread Daniel Kutenin via cfe-commits
https://github.com/danlark1 updated https://github.com/llvm/llvm-project/pull/67023 >From 059bbfab50592026ce2785c5f7d98eaf5c9f8bd6 Mon Sep 17 00:00:00 2001 From: Daniel Kutenin Date: Thu, 21 Sep 2023 14:55:11 +0100 Subject: [PATCH 1/7] Add bound checking in nth_element --- libcxx/include/__al

[clang] [Driver] Add ExclusiveGroup feature to multilib.yaml. (PR #69447)

2023-10-18 Thread Simon Tatham via cfe-commits
https://github.com/statham-arm created https://github.com/llvm/llvm-project/pull/69447 This allows a YAML-based multilib configuration to specify explicitly that a subset of its library directories are alternatives to each other, i.e. at most one of that subset should be selected. So if you h

[clang] [Driver] Add ExclusiveGroup feature to multilib.yaml. (PR #69447)

2023-10-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Simon Tatham (statham-arm) Changes This allows a YAML-based multilib configuration to specify explicitly that a subset of its library directories are alternatives to each other, i.e. at most one of that subset should be selected.

[clang] [Driver] Add ExclusiveGroup feature to multilib.yaml. (PR #69447)

2023-10-18 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff ebdb0cbef5e9be57237403c46bfdbe985313bb1c 5b3289a7ad40850cbe1c438345a181b01c500639 --

[clang] [Driver] Add ExclusiveGroup feature to multilib.yaml. (PR #69447)

2023-10-18 Thread Simon Tatham via cfe-commits
https://github.com/statham-arm updated https://github.com/llvm/llvm-project/pull/69447 >From 3a0481134343339ce8132419fde875ac9977b734 Mon Sep 17 00:00:00 2001 From: Simon Tatham Date: Thu, 14 Sep 2023 14:51:17 +0100 Subject: [PATCH] [Driver] Add ExclusiveGroup feature to multilib.yaml. This al

[clang] [clang] Bail out if the result of function template instantiation is not a function. (PR #69449)

2023-10-18 Thread via cfe-commits
https://github.com/VitaNuo created https://github.com/llvm/llvm-project/pull/69449 None >From 27dc15e7467afa7bc4ee17a907a088e59719ca5d Mon Sep 17 00:00:00 2001 From: Viktoriia Bakalova Date: Wed, 18 Oct 2023 10:18:43 + Subject: [PATCH] [clang] Bail out if the result of function template i

[clang] [clang] Bail out if the result of function template instantiation is not a function. (PR #69449)

2023-10-18 Thread via cfe-commits
https://github.com/VitaNuo updated https://github.com/llvm/llvm-project/pull/69449 >From 27dc15e7467afa7bc4ee17a907a088e59719ca5d Mon Sep 17 00:00:00 2001 From: Viktoriia Bakalova Date: Wed, 18 Oct 2023 10:18:43 + Subject: [PATCH 1/2] [clang] Bail out if the result of function template ins

[clang] [AMDGPU] Remove Code Object V3 (PR #67118)

2023-10-18 Thread Andrew Stubbs via cfe-commits
ams-cs wrote: We're discussing replacing the devices with something newer, but there are practical and business issues with that, so no hard plans. Sorry. I'm leaning toward officially deprecating Fiji for GCC 14, and remove it from GCC 15 (so, sometime next year). If we can get these devices

[clang-tools-extra] [run-clang-tidy] Add option -export-directory (PR #69453)

2023-10-18 Thread Amadeus Gebauer via cfe-commits
https://github.com/amgebauer created https://github.com/llvm/llvm-project/pull/69453 Adding an additional parameter to run_clang_tidy.py to accept a directory where the clang-tidy fixes are saved to. This directory can then be used to run `clang-apply-replacements`. >From fd908df80b14933c849e

[clang-tools-extra] [run-clang-tidy] Add option -export-directory (PR #69453)

2023-10-18 Thread Amadeus Gebauer via cfe-commits
https://github.com/amgebauer edited https://github.com/llvm/llvm-project/pull/69453 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] [unittest] Add a test for Generic_GCC::GCCVersion::Parse (PR #69078)

2023-10-18 Thread Timm Baeder via cfe-commits
tbaederr wrote: This doesn't build for me locally: ``` mold: error: undefined symbol: tools/clang/unittests/Driver/CMakeFiles/ClangDriverTests.dir/GCCVersionTest.cpp.o: clang::driver::toolchains::Generic_GCC::GCCVersion::Parse(llvm::StringRef) ``` https://github.com/llvm/llvm-project/pull/6907

[clang] 66c9915 - [clang][Interp][NFC] Remove from(Boolean) overload

2023-10-18 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-10-18T14:23:29+02:00 New Revision: 66c99154a130553a50e499d898ef1fba5b755dcf URL: https://github.com/llvm/llvm-project/commit/66c99154a130553a50e499d898ef1fba5b755dcf DIFF: https://github.com/llvm/llvm-project/commit/66c99154a130553a50e499d898ef1fba5b755dcf.diff LO

[clang] [clang][Interp] IntegralAP zero-init (PR #68081)

2023-10-18 Thread Timm Baeder via cfe-commits
@@ -100,12 +100,13 @@ template class IntegralAP final { } static IntegralAP from(const Boolean &B) { assert(false); -return IntegralAP::zero(); +return IntegralAP::zero(1); tbaederr wrote: Removed that code in https://github.com/llvm/llvm-pro

[clang] [clang] [unittest] Add a test for Generic_GCC::GCCVersion::Parse (PR #69078)

2023-10-18 Thread Alex Bradbury via cfe-commits
asb wrote: @tbaederr Just came to report the same thing! @mstorsjo This broke builds that use `-DBUILD_SHARED_LIBS=True`. The problem seems to be that the `Generic_GCC` class has the `LLVM_LIBRARY_VISIBILITY` attribute meaning the `clang::driver::toolchains::Generic_GCC::GCCVersion::Parse(llv

[clang] [clang][Interp] IntegralAP zero-init (PR #68081)

2023-10-18 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/68081 >From d6b0b306353fb2d8eaef6835f6313277eaf94bbd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Tue, 3 Oct 2023 11:05:27 +0200 Subject: [PATCH] [clang][Interp] IntegralAP zero-init --- clang/

[PATCH] D151197: [Clang][SVE2p1] Add svpsel builtins

2023-10-18 Thread Caroline via Phabricator via cfe-commits
CarolineConcatto updated this revision to Diff 557756. CarolineConcatto added a comment. -Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151197/new/ https://reviews.llvm.org/D151197 Files: clang/include/clang/Basic/arm_sve.td clang/lib/C

[clang] [clang] [unittest] Add a test for Generic_GCC::GCCVersion::Parse (PR #69078)

2023-10-18 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: > @tbaederr Just came to report the same thing! > > @mstorsjo This broke builds that use `-DBUILD_SHARED_LIBS=True`. Thanks! That was my guess as well, I was running a build with that enabled to try to reproduce @tbaederr 's issue. > The problem seems to be that the `Generic_G

[clang] 1072b94 - Revert "[clang] [unittest] Add a test for Generic_GCC::GCCVersion::Parse (#69078)"

2023-10-18 Thread Martin Storsjö via cfe-commits
Author: Martin Storsjö Date: 2023-10-18T15:42:18+03:00 New Revision: 1072b94ed8e5a051100557185cb384364850635a URL: https://github.com/llvm/llvm-project/commit/1072b94ed8e5a051100557185cb384364850635a DIFF: https://github.com/llvm/llvm-project/commit/1072b94ed8e5a051100557185cb384364850635a.diff

[clang-tools-extra] [run-clang-tidy] Add option -export-directory (PR #69453)

2023-10-18 Thread Piotr Zegar via cfe-commits
PiotrZSL wrote: There is already --export_fixes that can be used in +- same way. Maybe better would be to change --export_fixes to take filename or directory (ends with / or exist as directory), and in that case it could save to directory or merge to single file. https://github.com/llvm/llvm-p

[clang] [HIP] Document func ptr and virtual func (PR #68126)

2023-10-18 Thread Siu Chi Chan via cfe-commits
scchan wrote: LGTM thanks https://github.com/llvm/llvm-project/pull/68126 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Bail out if the result of function template instantiation is not a function type. (PR #69459)

2023-10-18 Thread via cfe-commits
https://github.com/VitaNuo created https://github.com/llvm/llvm-project/pull/69459 …not a function. >From d8305b64a464e5cd992c836ef13d452f62235442 Mon Sep 17 00:00:00 2001 From: Viktoriia Bakalova Date: Wed, 18 Oct 2023 12:55:04 + Subject: [PATCH] [clang] Bail out if the result of function

[clang] [clang] Bail out if the result of function template instantiation is not a function type. (PR #69459)

2023-10-18 Thread via cfe-commits
https://github.com/VitaNuo edited https://github.com/llvm/llvm-project/pull/69459 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Bail out if the result of function template instantiation is not a function. (PR #69449)

2023-10-18 Thread Sam McCall via cfe-commits
https://github.com/sam-mccall edited https://github.com/llvm/llvm-project/pull/69449 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Bail out if the result of function template instantiation is not a function. (PR #69449)

2023-10-18 Thread Sam McCall via cfe-commits
https://github.com/sam-mccall approved this pull request. Thanks! Looks great, just comment nits https://github.com/llvm/llvm-project/pull/69449 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[clang] [clang] Bail out if the result of function template instantiation is not a function. (PR #69449)

2023-10-18 Thread Sam McCall via cfe-commits
@@ -0,0 +1,15 @@ +// RUN: %clang_cc1 -x c++ -std=c++14 -fsyntax-only -verify %s + +template +using Type = typename A::NestedType; // expected-error {{type 'float' cannot be used prior to '::' because it has no members}} + +template +void Func() { + using MyType = Type(); // ex

[clang] [clang] Bail out if the result of function template instantiation is not a function. (PR #69449)

2023-10-18 Thread Sam McCall via cfe-commits
@@ -2649,7 +2649,9 @@ TypeSourceInfo *Sema::SubstFunctionDeclType(TypeSourceInfo *T, } else { Result = Instantiator.TransformType(TLB, TL); } - if (Result.isNull()) + // When clang goes into recovery mode, it might substitute sam-mccall wrote: Not s

[PATCH] D151307: [Clang][SVE2.1] Add svwhile (predicate-as-counter) builtins

2023-10-18 Thread Kerry McLaughlin via Phabricator via cfe-commits
kmclaughlin accepted this revision. kmclaughlin added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151307/new/ https://reviews.llvm.org/D151307 _

[clang] [clang] Bail out if the result of function template instantiation is not a function type. (PR #69459)

2023-10-18 Thread via cfe-commits
https://github.com/VitaNuo updated https://github.com/llvm/llvm-project/pull/69459 >From d8305b64a464e5cd992c836ef13d452f62235442 Mon Sep 17 00:00:00 2001 From: Viktoriia Bakalova Date: Wed, 18 Oct 2023 12:55:04 + Subject: [PATCH 1/2] [clang] Bail out if the result of function template ins

[clang] [clang][Interp] IntegralAP zero-init (PR #68081)

2023-10-18 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/68081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Bail out if the result of function template instantiation is not a function type. (PR #69459)

2023-10-18 Thread via cfe-commits
VitaNuo wrote: This is the same as the approved https://github.com/llvm/llvm-project/pull/69449. https://github.com/llvm/llvm-project/pull/69459 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[clang] 00f34ee - [clang] Bail out if the result of function template instantiation is not a function type. (#69459)

2023-10-18 Thread via cfe-commits
Author: VitaNuo Date: 2023-10-18T15:22:40+02:00 New Revision: 00f34eefe4ed04c95eb60074ddfdd64e65878be9 URL: https://github.com/llvm/llvm-project/commit/00f34eefe4ed04c95eb60074ddfdd64e65878be9 DIFF: https://github.com/llvm/llvm-project/commit/00f34eefe4ed04c95eb60074ddfdd64e65878be9.diff LOG:

[clang] [clang] Bail out if the result of function template instantiation is not a function type. (PR #69459)

2023-10-18 Thread via cfe-commits
https://github.com/VitaNuo closed https://github.com/llvm/llvm-project/pull/69459 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Bail out if the result of function template instantiation is not a function. (PR #69449)

2023-10-18 Thread via cfe-commits
https://github.com/VitaNuo closed https://github.com/llvm/llvm-project/pull/69449 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Bail out if the result of function template instantiation is not a function. (PR #69449)

2023-10-18 Thread via cfe-commits
VitaNuo wrote: Pre-empted by https://github.com/llvm/llvm-project/pull/69459. https://github.com/llvm/llvm-project/pull/69449 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CXXNameMangler] Correct the mangling of SVE ACLE types within function names. (PR #69460)

2023-10-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Paul Walker (paulwalker-arm) Changes * Mark SVE ACLE types as substitution candidates. * Change mangling of svbfloat16_t from __SVBFloat16_t to __SVBfloat16_t. https://github.com/ARM-software/abi-aa/blob/main/aapcs64/aapcs64.rst This is

[clang] [CXXNameMangler] Correct the mangling of SVE ACLE types within function names. (PR #69460)

2023-10-18 Thread Paul Walker via cfe-commits
paulwalker-arm wrote: To aid review I've split the patch into several commits mainly so the mechanical update of 200+ ACLE tests is separate from the much smaller code changes. Given this is an ABI break I'd rather land the series as a single commit. https://github.com/llvm/llvm-project/pull

[clang] [analyzer][clangsa] Add new option to alpha.security.cert.InvalidPtrChecker (PR #67663)

2023-10-18 Thread via cfe-commits
Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= Message-ID: In-Reply-To: https://gith

[clang] [analyzer][clangsa] Add new option to alpha.security.cert.InvalidPtrChecker (PR #67663)

2023-10-18 Thread via cfe-commits
Endre =?utf-8?q?F=C3=BCl=C3=B6p?= , Endre =?utf-8?q?F=C3=BCl=C3=B6p?= , Endre =?utf-8?q?F=C3=BCl=C3=B6p?= , Endre =?utf-8?q?F=C3=BCl=C3=B6p?= , Endre =?utf-8?q?F=C3=BCl=C3=B6p?= , Endre =?utf-8?q?F=C3=BCl=C3=B6p?= , Endre =?utf-8?q?F=C3=BCl=C3=B6p?= , Endre =?utf-8?q?F=C3=BCl=C3=B6p?= , Endre =?utf

[clang] [analyzer][clangsa] Add new option to alpha.security.cert.InvalidPtrChecker (PR #67663)

2023-10-18 Thread via cfe-commits
Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= , Endre =?utf-8?q?Fülöp?= Message-ID: In-Reply-To:

[clang] [Clang][OpenMP] Check if value is contained in array, not if it's contained in the first element (PR #69462)

2023-10-18 Thread Juan Manuel Martinez Caamaño via cfe-commits
https://github.com/jmmartinez created https://github.com/llvm/llvm-project/pull/69462 None From c388e5f65d3dfc8fc193686e182e74c3dcfb27e1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Manuel=20MARTINEZ=20CAAMA=C3=91O?= Date: Wed, 18 Oct 2023 15:32:22 +0200 Subject: [PATCH] [Clang][OpenMP] Che

[clang] [Driver] Link Flang runtime on Solaris (PR #65644)

2023-10-18 Thread Andrzej Warzyński via cfe-commits
https://github.com/banach-space approved this pull request. LGTM, thanks for all the improvements! Before merging, could you update the summary and briefly mention the additional changes made here? Otherwise people might think that these changes are required, but that's not strictly the case.

[PATCH] D151439: [Clang][SVE2.1] Add builtins for 2-way svdot (vectors, indexed)

2023-10-18 Thread Dinar Temirbulatov via Phabricator via cfe-commits
dtemirbulatov added inline comments. Comment at: clang/test/Sema/aarch64-sve2p1-intrinsics/acle_sve2p1_imm.cpp:112 + svfloat32_t f32, svfloat16_t f16) { + svdot_lane_s32_s16_s16(s32, s16, s16, 1); // expected-error {{argument value 4 is outside the vali

[clang] [clang-format]: Split alignment of declarations around assignment (PR #69340)

2023-10-18 Thread Gedare Bloom via cfe-commits
https://github.com/gedare updated https://github.com/llvm/llvm-project/pull/69340 >From c5d25f8de3de16ff3ed873446da017e9c26e0767 Mon Sep 17 00:00:00 2001 From: Gedare Bloom Date: Tue, 17 Oct 2023 08:21:55 -0600 Subject: [PATCH 1/2] [clang-format]: Split alignment of declarations around assignm

[clang] [flang][driver] support -dumpversion and -dumpmachine (PR #68896)

2023-10-18 Thread Andrzej Warzyński via cfe-commits
banach-space wrote: > > Could this be implemented without any updates to Clang (beyond Options.td)? > > The options could work by changing options.td only. However, > `CLANG_VERSION_STRING` and `FLANG_VERSION_STRING` could be different. This is > to handle that. You are adding a support for t

[clang] clang/OpenCL: set sqrt fp accuracy on call to Z4sqrt (PR #66651)

2023-10-18 Thread via cfe-commits
alan-baker wrote: This is preferable to defining the function in the OpenCL headers (as was noted in the original PR). To me, the important part is covering the OpenCL use case. So if we want to only check the overloads OpenCL generates I think that would be ok, but I expect this generic imple

[clang] [clang-format]: Split alignment of declarations around assignment (PR #69340)

2023-10-18 Thread Gedare Bloom via cfe-commits
https://github.com/gedare updated https://github.com/llvm/llvm-project/pull/69340 >From c5d25f8de3de16ff3ed873446da017e9c26e0767 Mon Sep 17 00:00:00 2001 From: Gedare Bloom Date: Tue, 17 Oct 2023 08:21:55 -0600 Subject: [PATCH 1/3] [clang-format]: Split alignment of declarations around assignm

[clang] [NFC] Remove unused variable "AOBFileNames" (PR #69463)

2023-10-18 Thread Juan Manuel Martinez Caamaño via cfe-commits
https://github.com/jmmartinez created https://github.com/llvm/llvm-project/pull/69463 None From d616ff33ba0b1db6ac8f9fd3cd1b0e2a3c1a544a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Manuel=20MARTINEZ=20CAAMA=C3=91O?= Date: Wed, 18 Oct 2023 15:45:07 +0200 Subject: [PATCH] [NFC] Remove unused

[clang] [Clang][OpenMP] Check if value is contained in array, not if it's contained in the first element (PR #69462)

2023-10-18 Thread Juan Manuel Martinez Caamaño via cfe-commits
jmmartinez wrote: Hello @saiislam ! Can I bother you with a review of this patch? https://github.com/llvm/llvm-project/pull/69462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [run-clang-tidy] Add option -export-directory (PR #69453)

2023-10-18 Thread Amadeus Gebauer via cfe-commits
https://github.com/amgebauer updated https://github.com/llvm/llvm-project/pull/69453 >From d63de8e3d8e71df445983516a57cc41cf47f1a6e Mon Sep 17 00:00:00 2001 From: Amadeus Gebauer Date: Wed, 18 Oct 2023 14:02:44 +0200 Subject: [PATCH] [run-clang-tidy] Accept directory for -export-fixes --- ...

[clang-tools-extra] [run-clang-tidy] Add option -export-directory (PR #69453)

2023-10-18 Thread Amadeus Gebauer via cfe-commits
amgebauer wrote: @PiotrZSL Thank you for your feedback. I implemented it the way you suggest. Feel free to leave comments. https://github.com/llvm/llvm-project/pull/69453 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[clang] Correctly compute conversion seq for args to fn with reversed param order (PR #68999)

2023-10-18 Thread Utkarsh Saxena via cfe-commits
usx95 wrote: This breaks new code (expected) but does not respect `-Wno-ambiguous-reversed-operator`. https://godbolt.org/z/oMsGeK1nc @zygoloid IIUC this should be silenced by this warning but somehow does not. Will investigate further. Reverting to put out large unsuppresable breakages https

[PATCH] D151199: [Clang][SVE2.1] Add pfalse builtin

2023-10-18 Thread Caroline via Phabricator via cfe-commits
CarolineConcatto updated this revision to Diff 557758. CarolineConcatto added a comment. -Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151199/new/ https://reviews.llvm.org/D151199 Files: clang/include/clang/Basic/arm_sve.td clang/lib/C

[clang-tools-extra] [run-clang-tidy] Accept directory as value for -export-fixes (PR #69453)

2023-10-18 Thread Amadeus Gebauer via cfe-commits
https://github.com/amgebauer edited https://github.com/llvm/llvm-project/pull/69453 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] cf1bde9 - [Driver] Link Flang runtime on Solaris (#65644)

2023-10-18 Thread via cfe-commits
Author: Rainer Orth Date: 2023-10-18T16:12:10+02:00 New Revision: cf1bde9a15d711564c51e707b6200f1b5f508b9f URL: https://github.com/llvm/llvm-project/commit/cf1bde9a15d711564c51e707b6200f1b5f508b9f DIFF: https://github.com/llvm/llvm-project/commit/cf1bde9a15d711564c51e707b6200f1b5f508b9f.diff L

[clang] [Driver] Link Flang runtime on Solaris (PR #65644)

2023-10-18 Thread Rainer Orth via cfe-commits
https://github.com/rorth closed https://github.com/llvm/llvm-project/pull/65644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] a3a0f59 - Revert "Correctly compute conversion seq for args to fn with reversed param order (#68999)"

2023-10-18 Thread Dmitry Chernenkov via cfe-commits
Author: Dmitry Chernenkov Date: 2023-10-18T14:13:48Z New Revision: a3a0f59a1e1cb0ac02f06b19f730ea05a6541c96 URL: https://github.com/llvm/llvm-project/commit/a3a0f59a1e1cb0ac02f06b19f730ea05a6541c96 DIFF: https://github.com/llvm/llvm-project/commit/a3a0f59a1e1cb0ac02f06b19f730ea05a6541c96.diff

[clang-tools-extra] [run-clang-tidy] Accept directory as value for -export-fixes (PR #69453)

2023-10-18 Thread Piotr Zegar via cfe-commits
@@ -384,14 +386,26 @@ def main(): clang_tidy_binary = find_binary(args.clang_tidy_binary, "clang-tidy", build_path) -tmpdir = None if args.fix: clang_apply_replacements_binary = find_binary( args.clang_apply_replacements_binary, "clang-appl

[clang-tools-extra] [clang-tidy]Add new check bugprone-casting-through-void (PR #69465)

2023-10-18 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 created https://github.com/llvm/llvm-project/pull/69465 This check detects usage of ``static_cast`` pointer to the other pointer throght `static_cast` to `void *` in C++ code. Fixes: #68532 >From 627f68e57b2526fb72285ef4831fc3c02a6ee6d0 Mon Sep 17 00:00:00 2001 F

[clang-tools-extra] [clang-tidy]Add new check bugprone-casting-through-void (PR #69465)

2023-10-18 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Congcong Cai (HerrCai0907) Changes This check detects usage of ``static_cast`` pointer to the other pointer throght `static_cast` to `void *` in C++ code. Fixes: #68532 --- Full diff: https://github.com/llvm/llvm-project/pull/69465.d

[clang-tools-extra] [run-clang-tidy] Accept directory as value for -export-fixes (PR #69453)

2023-10-18 Thread Piotr Zegar via cfe-commits
@@ -384,14 +386,26 @@ def main(): clang_tidy_binary = find_binary(args.clang_tidy_binary, "clang-tidy", build_path) -tmpdir = None if args.fix: clang_apply_replacements_binary = find_binary( args.clang_apply_replacements_binary, "clang-appl

[clang-tools-extra] [run-clang-tidy] Accept directory as value for -export-fixes (PR #69453)

2023-10-18 Thread via cfe-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r b0b8e83e668ac02f81874c3548c8eb8dbf3c33f0..d63de8e3d8e71df445983516a57cc41cf47f1a6e clang-

[clang-tools-extra] [run-clang-tidy] Accept directory as value for -export-fixes (PR #69453)

2023-10-18 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL commented: Release notes will be needed, in clang-tools-extra/docs/ReleaseNotes.rst. Additionally probably similar change should be done to clang-tidy-diff.py https://github.com/llvm/llvm-project/pull/69453 ___ cfe-commits m

[clang-tools-extra] [clang][dataflow]Use cast_or_null instead of cast to prevent crash (PR #68510)

2023-10-18 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand approved this pull request. Thanks, looks good! You can submit as is, but if you're up for it, it would actually be better to add the new test case directly to the model's unittests. Something like this test (though just one case is enough -- please put it in a separa

[clang-tools-extra] [clang-tidy]Add new check bugprone-casting-through-void (PR #69465)

2023-10-18 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,46 @@ +//===--- CastingThroughVoidCheck.cpp - clang-tidy -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-tidy]Add new check bugprone-casting-through-void (PR #69465)

2023-10-18 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,46 @@ +//===--- CastingThroughVoidCheck.cpp - clang-tidy -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

  1   2   3   4   >