[clang-tools-extra] [clang-tidy] Improve `ExceptionSpecAnalyzer`s handling of conditional noexcept expressions (PR #68359)

2023-10-06 Thread Piotr Zegar via cfe-commits
@@ -284,6 +284,12 @@ Changes in existing checks ` check to properly escape single quotes. +- Improved :doc:`performance-noexcept-move-constructor + ` and + :doc:`performance-noexcept-swap` PiotrZSL wrote: duplicate this change note, here leave one for m

[clang-tools-extra] [clang-tidy] Improve `ExceptionSpecAnalyzer`s handling of conditional noexcept expressions (PR #68359)

2023-10-06 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL approved this pull request. +- LGTM, just split in release notes is needed. https://github.com/llvm/llvm-project/pull/68359 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[clang] [clang][dataflow] Various formatting tweaks to HTMLLogger. (PR #68392)

2023-10-06 Thread via cfe-commits
https://github.com/martinboehme created https://github.com/llvm/llvm-project/pull/68392 * Ensure timeline entries don't have linebreaks by setting `min-width: max-content`. * Give the timeline header some padding on the right so it doesn't run into the "Function" header. * Put some pa

[libunwind] [IPSCCP] Variable not visible at Og. (PR #66745)

2023-10-06 Thread Carlos Alberto Enciso via cfe-commits
https://github.com/CarlosAlbertoEnciso updated https://github.com/llvm/llvm-project/pull/66745 >From b24943f63025822a5c5ba90c4a7b47f7123ec4db Mon Sep 17 00:00:00 2001 From: Carlos Alberto Enciso Date: Mon, 18 Sep 2023 12:29:17 +0100 Subject: [PATCH 1/4] [IPSCCP] Variable not visible at Og: htt

[libunwind] [IPSCCP] Variable not visible at Og. (PR #66745)

2023-10-06 Thread J. Ryan Stinnett via cfe-commits
https://github.com/jryans edited https://github.com/llvm/llvm-project/pull/66745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [IPSCCP] Variable not visible at Og. (PR #66745)

2023-10-06 Thread J. Ryan Stinnett via cfe-commits
https://github.com/jryans edited https://github.com/llvm/llvm-project/pull/66745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [IPSCCP] Variable not visible at Og. (PR #66745)

2023-10-06 Thread J. Ryan Stinnett via cfe-commits
https://github.com/jryans edited https://github.com/llvm/llvm-project/pull/66745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Various formatting tweaks to HTMLLogger. (PR #68392)

2023-10-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-analysis Changes * Ensure timeline entries don't have linebreaks by setting `min-width: max-content`. * Give the timeline header some padding on the right so it doesn't run into the "Function" header. * Put some padding around the iterati

[clang] [Sema] Add check for bitfield assignments to larger integral types (PR #68276)

2023-10-06 Thread via cfe-commits
vabridgers wrote: Hi @AaronBallman and @erichkeane , any improvements you could suggest? I could expand the testing for sure. Before I invest time in that, I'd like to be sure the general approach is ok in Sema. Thanks. https://github.com/llvm/llvm-project/pull/68276 __

[clang-tools-extra] [clang-tidy] Improve `ExceptionSpecAnalyzer`s handling of conditional noexcept expressions (PR #68359)

2023-10-06 Thread via cfe-commits
https://github.com/AMS21 updated https://github.com/llvm/llvm-project/pull/68359 >From e82ff98aaf7b40fd5d598b486243adc54009bffc Mon Sep 17 00:00:00 2001 From: AMS21 Date: Thu, 5 Oct 2023 23:39:42 +0200 Subject: [PATCH] [clang-tidy] Improve `ExceptionSpecAnalyzer`s handling of conditional noexce

[clang] Reapply "[clang analysis][thread-safety] Handle return-by-reference..… (PR #68394)

2023-10-06 Thread Clement Courbet via cfe-commits
https://github.com/legrosbuffle created https://github.com/llvm/llvm-project/pull/68394 …. (#67776)" Now that `scudo` issues have been fixed (#68273). This reverts commit 462bdd5bf0861a27f451f7917802a954e2046bc7. >From 6bf1af81adef93f20f25db4023810fe7be750410 Mon Sep 17 00:00:00 2001 From: Cl

[clang] Reapply "[clang analysis][thread-safety] Handle return-by-reference..… (PR #68394)

2023-10-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-analysis Changes …. (#67776)" Now that `scudo` issues have been fixed (#68273). This reverts commit 462bdd5bf0861a27f451f7917802a954e2046bc7. --- Full diff: https://github.com/llvm/llvm-project/pull/68394.diff 5 Files Affected: - (modified) cl

[clang-tools-extra] [clang-tidy] Improve `ExceptionSpecAnalyzer`s handling of conditional noexcept expressions (PR #68359)

2023-10-06 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL approved this pull request. https://github.com/llvm/llvm-project/pull/68359 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Only check RVV types if we have them (PR #67669)

2023-10-06 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/67669 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 3717147 - [clang][Sema] Only check RVV types if we have them (#67669)

2023-10-06 Thread via cfe-commits
Author: Timm Baeder Date: 2023-10-06T09:56:05+02:00 New Revision: 3717147ee6e41f7fa3225c318104982499c5c505 URL: https://github.com/llvm/llvm-project/commit/3717147ee6e41f7fa3225c318104982499c5c505 DIFF: https://github.com/llvm/llvm-project/commit/3717147ee6e41f7fa3225c318104982499c5c505.diff L

[clang] [clang][Sema] Only check RVV types if we have them (PR #67669)

2023-10-06 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/67669 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] cd184c8 - Reapply "[clang analysis][thread-safety] Handle return-by-reference..… (#68394)

2023-10-06 Thread via cfe-commits
Author: Clement Courbet Date: 2023-10-06T10:50:08+02:00 New Revision: cd184c866e0aad1f957910b8c7a94f98a2b21ceb URL: https://github.com/llvm/llvm-project/commit/cd184c866e0aad1f957910b8c7a94f98a2b21ceb DIFF: https://github.com/llvm/llvm-project/commit/cd184c866e0aad1f957910b8c7a94f98a2b21ceb.dif

[clang] Reapply "[clang analysis][thread-safety] Handle return-by-reference..… (PR #68394)

2023-10-06 Thread Clement Courbet via cfe-commits
https://github.com/legrosbuffle closed https://github.com/llvm/llvm-project/pull/68394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [InstCombine] Canonicalize `(X +/- Y) & Y` into `~X & Y` when Y is a power of 2 (PR #67915)

2023-10-06 Thread Nikita Popov via cfe-commits
https://github.com/nikic commented: Seems like some test coverage is missing here? * Commuted add * Commuted sub (negative test) * Commuted and * Multi-use add (negative test) https://github.com/llvm/llvm-project/pull/67915 ___ cfe-commits mailing

[clang-tools-extra] [AMDGPU] Add encoding/decoding support for non-result-returning ATOMIC_CSUB instructions (PR #68197)

2023-10-06 Thread Stephen Thomas via cfe-commits
https://github.com/stepthomas updated https://github.com/llvm/llvm-project/pull/68197 >From ed42bb63a3fe4a840071b74a3f9613dda815aa29 Mon Sep 17 00:00:00 2001 From: Stephen Thomas Date: Wed, 4 Oct 2023 10:16:49 +0100 Subject: [PATCH] [AMDGPU] Add encoding/decoding support for non-result-returni

[libunwind] [AMDGPU] Add encoding/decoding support for non-result-returning ATOMIC_CSUB instructions (PR #68197)

2023-10-06 Thread Stephen Thomas via cfe-commits
https://github.com/stepthomas updated https://github.com/llvm/llvm-project/pull/68197 >From ed42bb63a3fe4a840071b74a3f9613dda815aa29 Mon Sep 17 00:00:00 2001 From: Stephen Thomas Date: Wed, 4 Oct 2023 10:16:49 +0100 Subject: [PATCH] [AMDGPU] Add encoding/decoding support for non-result-returni

[clang] [InstCombine] Simplify the pattern `a ne/eq (zext/sext (a ne/eq c))` (PR #65852)

2023-10-06 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw updated https://github.com/llvm/llvm-project/pull/65852 >From d9d8bcbb98e8f5aecb9733329389d61a489bd731 Mon Sep 17 00:00:00 2001 From: Yingwei Zheng Date: Sat, 9 Sep 2023 23:07:29 +0800 Subject: [PATCH 01/10] [InstCombine] Simplify the pattern `a ne/eq (zext (a ne/eq

[clang-tools-extra] [InstCombine] Simplify the pattern `a ne/eq (zext/sext (a ne/eq c))` (PR #65852)

2023-10-06 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw updated https://github.com/llvm/llvm-project/pull/65852 >From d9d8bcbb98e8f5aecb9733329389d61a489bd731 Mon Sep 17 00:00:00 2001 From: Yingwei Zheng Date: Sat, 9 Sep 2023 23:07:29 +0800 Subject: [PATCH 01/10] [InstCombine] Simplify the pattern `a ne/eq (zext (a ne/eq

[clang] [InstCombine] Canonicalize `(X +/- Y) & Y` into `~X & Y` when Y is a power of 2 (PR #67915)

2023-10-06 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw updated https://github.com/llvm/llvm-project/pull/67915 >From c4ce28c942c172e5646b5922f0b02b4169197840 Mon Sep 17 00:00:00 2001 From: Yingwei Zheng Date: Sun, 1 Oct 2023 21:52:47 +0800 Subject: [PATCH 1/2] [InstCombine] Canonicalize `(X +/- Y) & Y` into `~X & Y` when

[clang] [clang] Replace uses of CreatePointerBitCastOrAddrSpaceCast (NFC) (PR #68277)

2023-10-06 Thread Björn Pettersson via cfe-commits
@@ -1123,9 +1123,7 @@ void CodeGenFunction::StartFunction(GlobalDecl GD, QualType RetTy, if (!CurFnInfo->getReturnInfo().getIndirectByVal()) { ReturnValuePointer = CreateDefaultAlignTempAlloca(Int8PtrTy, "result.ptr"); - Builder.CreateStore(Builder.Cre

[clang-tools-extra] [clang-tidy][libc] Fix namespace check with macro (PR #68134)

2023-10-06 Thread Guillaume Chatelet via cfe-commits
https://github.com/gchatelet approved this pull request. https://github.com/llvm/llvm-project/pull/68134 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [InstCombine] Canonicalize `(X +/- Y) & Y` into `~X & Y` when Y is a power of 2 (PR #67915)

2023-10-06 Thread Nikita Popov via cfe-commits
nikic wrote: Can you please pre-commit the new tests as well (and double-check that there is no unexpected operand order canonicalization while doing that)? https://github.com/llvm/llvm-project/pull/67915 ___ cfe-commits mailing list cfe-commits@lists

[clang] [InstCombine] Simplify the pattern `a ne/eq (zext/sext (a ne/eq c))` (PR #65852)

2023-10-06 Thread Matthias Springer via cfe-commits
https://github.com/matthias-springer updated https://github.com/llvm/llvm-project/pull/65852 >From d9d8bcbb98e8f5aecb9733329389d61a489bd731 Mon Sep 17 00:00:00 2001 From: Yingwei Zheng Date: Sat, 9 Sep 2023 23:07:29 +0800 Subject: [PATCH 01/10] [InstCombine] Simplify the pattern `a ne/eq (zext

[clang] [InstCombine] Simplify the pattern `a ne/eq (zext/sext (a ne/eq c))` (PR #65852)

2023-10-06 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw updated https://github.com/llvm/llvm-project/pull/65852 >From d9d8bcbb98e8f5aecb9733329389d61a489bd731 Mon Sep 17 00:00:00 2001 From: Yingwei Zheng Date: Sat, 9 Sep 2023 23:07:29 +0800 Subject: [PATCH 01/10] [InstCombine] Simplify the pattern `a ne/eq (zext (a ne/eq

[clang-tools-extra] [InstCombine] Simplify the pattern `a ne/eq (zext/sext (a ne/eq c))` (PR #65852)

2023-10-06 Thread Matthias Springer via cfe-commits
https://github.com/matthias-springer updated https://github.com/llvm/llvm-project/pull/65852 >From d9d8bcbb98e8f5aecb9733329389d61a489bd731 Mon Sep 17 00:00:00 2001 From: Yingwei Zheng Date: Sat, 9 Sep 2023 23:07:29 +0800 Subject: [PATCH 01/10] [InstCombine] Simplify the pattern `a ne/eq (zext

[clang-tools-extra] [InstCombine] Simplify the pattern `a ne/eq (zext/sext (a ne/eq c))` (PR #65852)

2023-10-06 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw updated https://github.com/llvm/llvm-project/pull/65852 >From d9d8bcbb98e8f5aecb9733329389d61a489bd731 Mon Sep 17 00:00:00 2001 From: Yingwei Zheng Date: Sat, 9 Sep 2023 23:07:29 +0800 Subject: [PATCH 01/10] [InstCombine] Simplify the pattern `a ne/eq (zext (a ne/eq

[clang] [InstCombine] Simplify the pattern `a ne/eq (zext/sext (a ne/eq c))` (PR #65852)

2023-10-06 Thread Nikita Popov via cfe-commits
nikic wrote: Looks like incorrect conflict resolution in the last merge. https://github.com/llvm/llvm-project/pull/65852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [InstCombine] Simplify the pattern `a ne/eq (zext/sext (a ne/eq c))` (PR #65852)

2023-10-06 Thread Nikita Popov via cfe-commits
nikic wrote: Looks like incorrect conflict resolution in the last merge. https://github.com/llvm/llvm-project/pull/65852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MLIR][Presburger] Fix reduce bug in Fraction class and add tests (PR #68298)

2023-10-06 Thread via cfe-commits
https://github.com/Abhinav271828 updated https://github.com/llvm/llvm-project/pull/68298 >From 8b09dcb29a66c3c88bdf1acac2df65091ab60183 Mon Sep 17 00:00:00 2001 From: Abhinav271828 Date: Wed, 6 Sep 2023 14:11:26 +0100 Subject: [PATCH 1/5] Update upstream branch --- libcxx/modules/std/mdspan.c

[clang-tools-extra] [MLIR][Presburger] Fix reduce bug in Fraction class and add tests (PR #68298)

2023-10-06 Thread via cfe-commits
https://github.com/Abhinav271828 updated https://github.com/llvm/llvm-project/pull/68298 >From 8b09dcb29a66c3c88bdf1acac2df65091ab60183 Mon Sep 17 00:00:00 2001 From: Abhinav271828 Date: Wed, 6 Sep 2023 14:11:26 +0100 Subject: [PATCH 1/5] Update upstream branch --- libcxx/modules/std/mdspan.c

[clang-tools-extra] [MLIR][Presburger] Fix reduce bug in Fraction class and add tests (PR #68298)

2023-10-06 Thread via cfe-commits
https://github.com/Abhinav271828 edited https://github.com/llvm/llvm-project/pull/68298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MLIR][Presburger] Fix reduce bug in Fraction class and add tests (PR #68298)

2023-10-06 Thread via cfe-commits
https://github.com/Abhinav271828 edited https://github.com/llvm/llvm-project/pull/68298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [InstCombine] Simplify the pattern `a ne/eq (zext/sext (a ne/eq c))` (PR #65852)

2023-10-06 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw updated https://github.com/llvm/llvm-project/pull/65852 >From d9d8bcbb98e8f5aecb9733329389d61a489bd731 Mon Sep 17 00:00:00 2001 From: Yingwei Zheng Date: Sat, 9 Sep 2023 23:07:29 +0800 Subject: [PATCH 01/10] [InstCombine] Simplify the pattern `a ne/eq (zext (a ne/eq

[clang] [InstCombine] Simplify the pattern `a ne/eq (zext/sext (a ne/eq c))` (PR #65852)

2023-10-06 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw updated https://github.com/llvm/llvm-project/pull/65852 >From d9d8bcbb98e8f5aecb9733329389d61a489bd731 Mon Sep 17 00:00:00 2001 From: Yingwei Zheng Date: Sat, 9 Sep 2023 23:07:29 +0800 Subject: [PATCH 01/10] [InstCombine] Simplify the pattern `a ne/eq (zext (a ne/eq

[clang] [InstCombine] Simplify the pattern `a ne/eq (zext/sext (a ne/eq c))` (PR #65852)

2023-10-06 Thread Yingwei Zheng via cfe-commits
dtcxzyw wrote: The conflict resolution should be correct now. https://github.com/llvm/llvm-project/pull/65852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [InstCombine] Simplify the pattern `a ne/eq (zext/sext (a ne/eq c))` (PR #65852)

2023-10-06 Thread Yingwei Zheng via cfe-commits
dtcxzyw wrote: The conflict resolution should be correct now. https://github.com/llvm/llvm-project/pull/65852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D155688: [PATCH] [llvm] [InstCombine] Canonicalise ADD+GEP

2023-10-06 Thread Mats Petersson via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe13bed4c5f35: [PATCH] [llvm] [InstCombine] Canonicalise ADD+GEP (authored by d-smirnov, committed by MatsPetersson). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[clang] e13bed4 - [PATCH] [llvm] [InstCombine] Canonicalise ADD+GEP

2023-10-06 Thread Mats Petersson via cfe-commits
Author: Dmitriy Smirnov Date: 2023-10-06T12:29:06+01:00 New Revision: e13bed4c5f3544c076ce57e36d9a11eefa5a7815 URL: https://github.com/llvm/llvm-project/commit/e13bed4c5f3544c076ce57e36d9a11eefa5a7815 DIFF: https://github.com/llvm/llvm-project/commit/e13bed4c5f3544c076ce57e36d9a11eefa5a7815.dif

Re: [clang] a6acf3f - Revert "Fixes and closes #53952. Setting the ASTHasCompilerErrors member variable correctly based on the PP diagnostics. (#68127)"

2023-10-06 Thread Kazu Hirata via cfe-commits
Hmm. No, I was using a clean tree. I tried a50e63b38b931d945f97eac882278068221eca17 and the commit immediately before, and the build problem showed up at a50e63b38b931d945f97eac882278068221eca17. Let me re-apply the patch locally and try both gcc and clang (as the host compilers). Kazu Hirata

Re: [clang] a6acf3f - Revert "Fixes and closes #53952. Setting the ASTHasCompilerErrors member variable correctly based on the PP diagnostics. (#68127)"

2023-10-06 Thread Kazu Hirata via cfe-commits
I went back to a50e63b38b931d945f97eac882278068221eca17. There, my release+asserts build failed, but my release-without-asserts build was OK. I used clang-14.0.6 as the host compiler for both of these builds. I reapplied a50e63b38b931d945f97eac882278068221eca17 at the tip (5e159972917fb7d02347f98

[clang] 46518a1 - Revert "Revert "Fixes and closes #53952. Setting the ASTHasCompilerErrors member variable correctly based on the PP diagnostics. (#68127)""

2023-10-06 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2023-10-06T07:43:19-04:00 New Revision: 46518a14f1ab594c0fc7091bc55c10872b64075d URL: https://github.com/llvm/llvm-project/commit/46518a14f1ab594c0fc7091bc55c10872b64075d DIFF: https://github.com/llvm/llvm-project/commit/46518a14f1ab594c0fc7091bc55c10872b64075d.diff

Re: [clang] a6acf3f - Revert "Fixes and closes #53952. Setting the ASTHasCompilerErrors member variable correctly based on the PP diagnostics. (#68127)"

2023-10-06 Thread Aaron Ballman via cfe-commits
On Thu, Oct 5, 2023 at 6:52 PM Kazu Hirata wrote: > > I went back to a50e63b38b931d945f97eac882278068221eca17. There, my > release+asserts build failed, but my release-without-asserts build was OK. I > used clang-14.0.6 as the host compiler for both of these builds. > > I reapplied a50e63b38b9

[clang] Fixes and closes #53952. Setting the ASTHasCompilerErrors member variable correctly based on the PP diagnostics. (PR #68127)

2023-10-06 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: There was a mix-up. I landed the original changes, @kazutakahirata saw what appeared to be a linker error after pulling those changes down and did a revert, but that turned out to be an issue local to their machine so I've reverted the revert (re-landing the original change

[clang] [clang][NFC] Add missing placement-new after Allocate() calls (PR #68382)

2023-10-06 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! Thank you for the cleanup! https://github.com/llvm/llvm-project/pull/68382 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[clang] 99e6ef3 - [clang][NFC] Add missing placement-new after Allocate() calls (#68382)

2023-10-06 Thread via cfe-commits
Author: Vlad Serebrennikov Date: 2023-10-06T07:50:07-04:00 New Revision: 99e6ef3e7c6e342beb2ad6b5e64d1e5fd2f24d2b URL: https://github.com/llvm/llvm-project/commit/99e6ef3e7c6e342beb2ad6b5e64d1e5fd2f24d2b DIFF: https://github.com/llvm/llvm-project/commit/99e6ef3e7c6e342beb2ad6b5e64d1e5fd2f24d2b.

[clang] [clang][NFC] Add missing placement-new after Allocate() calls (PR #68382)

2023-10-06 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/68382 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][USR] Encode full decl-context also for anon namespaces (PR #68325)

2023-10-06 Thread Sam McCall via cfe-commits
https://github.com/sam-mccall approved this pull request. https://github.com/llvm/llvm-project/pull/68325 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D157331: [clang] Implement C23

2023-10-06 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Please wait for @jrtc27 to also sign off before landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157331/new/ https://r

[clang-tools-extra] [InstCombine] Simplify the pattern `a ne/eq (zext/sext (a ne/eq c))` (PR #65852)

2023-10-06 Thread Nikita Popov via cfe-commits
https://github.com/nikic approved this pull request. Yeah, it looks correct now. https://github.com/llvm/llvm-project/pull/65852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [InstCombine] Simplify the pattern `a ne/eq (zext/sext (a ne/eq c))` (PR #65852)

2023-10-06 Thread Nikita Popov via cfe-commits
https://github.com/nikic approved this pull request. Yeah, it looks correct now. https://github.com/llvm/llvm-project/pull/65852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 32a9c09 - [clang][CodeGen] Regenerate tests checks after 94795a37e892cfedb570c70a5101ea88348e60c7

2023-10-06 Thread Simon Pilgrim via cfe-commits
Author: Simon Pilgrim Date: 2023-10-06T13:27:31+01:00 New Revision: 32a9c096091081736480250da66a2702375a6210 URL: https://github.com/llvm/llvm-project/commit/32a9c096091081736480250da66a2702375a6210 DIFF: https://github.com/llvm/llvm-project/commit/32a9c096091081736480250da66a2702375a6210.diff

[clang] [clang] fix hasAnyBase not binding submatchers (PR #67939)

2023-10-06 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/67939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ASTMatcher] fix hasAnyBase not binding submatchers (PR #67939)

2023-10-06 Thread via cfe-commits
https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/67939 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Avoid evaluating the BitWidth expression over and over again (PR #66203)

2023-10-06 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > @cor3ntin Looking at this again... while I'd also like to see the general > solution, I'd probably apply this anyway since it makes it clearer that this > function can actually be fast. Its name is terrible for what it does. It > sounds like it's a simply getter but in re

[clang] [clang][NFC] Specify Type and ExtQuals as having 16-byte alignment (PR #68377)

2023-10-06 Thread Aaron Ballman via cfe-commits
@@ -1982,9 +1986,9 @@ class alignas(8) Type : public ExtQualsTypeCommonBase { Type(TypeClass tc, QualType canon, TypeDependence Dependence) : ExtQualsTypeCommonBase(this, canon.isNull() ? QualType(this_(), 0) : canon) { -static_assert(

[clang] [clang] Avoid evaluating the BitWidth expression over and over again (PR #66203)

2023-10-06 Thread Timm Baeder via cfe-commits
tbaederr wrote: Well, this is not going to make a noticeable difference in runtime. https://reviews.llvm.org/D155548 didn't land because there are no measurements to make where this makes a measurable difference. As for my earlier comment, it would also make sense to rename that function to `

[clang] [clang][NFC] Specify Type and ExtQuals as having 16-byte alignment (PR #68377)

2023-10-06 Thread Aaron Ballman via cfe-commits
@@ -1507,6 +1508,9 @@ class ExtQuals : public ExtQualsTypeCommonBase, public llvm::FoldingSetNode { : ExtQualsTypeCommonBase(baseType, canon.isNull() ? QualType(this_(), 0) : canon), Quals(quals) { +static_assert(alignof(decltyp

[clang-tools-extra] [InstCombine] Canonicalize `(X +/- Y) & Y` into `~X & Y` when Y is a power of 2 (PR #67915)

2023-10-06 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw updated https://github.com/llvm/llvm-project/pull/67915 >From c4ce28c942c172e5646b5922f0b02b4169197840 Mon Sep 17 00:00:00 2001 From: Yingwei Zheng Date: Sun, 1 Oct 2023 21:52:47 +0800 Subject: [PATCH 1/2] [InstCombine] Canonicalize `(X +/- Y) & Y` into `~X & Y` when

[clang] [InstCombine] Canonicalize `(X +/- Y) & Y` into `~X & Y` when Y is a power of 2 (PR #67915)

2023-10-06 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw updated https://github.com/llvm/llvm-project/pull/67915 >From c4ce28c942c172e5646b5922f0b02b4169197840 Mon Sep 17 00:00:00 2001 From: Yingwei Zheng Date: Sun, 1 Oct 2023 21:52:47 +0800 Subject: [PATCH 1/2] [InstCombine] Canonicalize `(X +/- Y) & Y` into `~X & Y` when

[clang-tools-extra] [InstCombine] Simplify the pattern `a ne/eq (zext/sext (a ne/eq c))` (PR #65852)

2023-10-06 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw closed https://github.com/llvm/llvm-project/pull/65852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [InstCombine] Simplify the pattern `a ne/eq (zext/sext (a ne/eq c))` (PR #65852)

2023-10-06 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw closed https://github.com/llvm/llvm-project/pull/65852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Avoid evaluating the BitWidth expression over and over again (PR #66203)

2023-10-06 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > Well, this is not going to make a noticeable difference in runtime. > https://reviews.llvm.org/D155548 didn't land because there are no > measurements to make where this makes a measurable difference. Those changes didn't land because no measurements were attempted. Putti

[clang] [clang] Avoid evaluating the BitWidth expression over and over again (PR #66203)

2023-10-06 Thread Timm Baeder via cfe-commits
tbaederr wrote: > > Well, this is not going to make a noticeable difference in runtime. > > https://reviews.llvm.org/D155548 didn't land because there are no > > measurements to make where this makes a measurable difference. > > Those changes didn't land because no measurements were attempted.

[clang] [clang] Avoid evaluating the BitWidth expression over and over again (PR #66203)

2023-10-06 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > > > Well, this is not going to make a noticeable difference in runtime. > > > https://reviews.llvm.org/D155548 didn't land because there are no > > > measurements to make where this makes a measurable difference. > > > > > > Those changes didn't land because no measureme

[clang] [clang][Sema] Use original template pattern when declaring implicit deduction guides for nested template classes (PR #68379)

2023-10-06 Thread Erich Keane via cfe-commits
https://github.com/erichkeane commented: This seems reasonable, however it needs a release note. https://github.com/llvm/llvm-project/pull/68379 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[clang] [Sema] Add check for bitfield assignments to larger integral types (PR #68276)

2023-10-06 Thread Erich Keane via cfe-commits
https://github.com/erichkeane commented: Also needs a release note. https://github.com/llvm/llvm-project/pull/68276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Add check for bitfield assignments to larger integral types (PR #68276)

2023-10-06 Thread Erich Keane via cfe-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/68276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Add check for bitfield assignments to larger integral types (PR #68276)

2023-10-06 Thread Erich Keane via cfe-commits
@@ -6171,6 +6171,9 @@ def warn_signed_bitfield_enum_conversion : Warning< "signed bit-field %0 needs an extra bit to represent the largest positive " "enumerators of %1">, InGroup, DefaultIgnore; +def warn_bitfield_too_small_for_integral_type : Warning< + "bit-field %0 (

[clang] [Sema] Add check for bitfield assignments to larger integral types (PR #68276)

2023-10-06 Thread Erich Keane via cfe-commits
@@ -0,0 +1,36 @@ +// RUN: %clang_cc1 -Wconversion -fsyntax-only -verify %s + +typedef struct _xx { + int bf:9; // expected-note{{widen this field to 32 bits to store all values of 'int'}} + // expected-note@-1{{widen this field to 16 bits to store all values of 'short'}}

[clang] [clang] Avoid evaluating the BitWidth expression over and over again (PR #66203)

2023-10-06 Thread via cfe-commits
cor3ntin wrote: > Ah, I didn't realize you had measured on your own. But yeah, having some > concrete numbers to play with would help. I'd like to see rough numbers too but I'm really hoping we can progress https://reviews.llvm.org/D155548. I think it's the worse case it's harmless, at best it

[clang] [clang] Avoid evaluating the BitWidth expression over and over again (PR #66203)

2023-10-06 Thread Timm Baeder via cfe-commits
tbaederr wrote: http://llvm-compile-time-tracker.com/index.php?config=NewPM-O3&stat=instructions%3Au&remote=tbaederr https://github.com/llvm/llvm-project/pull/66203 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[clang] [IPSCCP] Variable not visible at Og. (PR #66745)

2023-10-06 Thread Carlos Alberto Enciso via cfe-commits
https://github.com/CarlosAlbertoEnciso updated https://github.com/llvm/llvm-project/pull/66745 >From b24943f63025822a5c5ba90c4a7b47f7123ec4db Mon Sep 17 00:00:00 2001 From: Carlos Alberto Enciso Date: Mon, 18 Sep 2023 12:29:17 +0100 Subject: [PATCH 1/4] [IPSCCP] Variable not visible at Og: htt

[clang] [IPSCCP] Variable not visible at Og. (PR #66745)

2023-10-06 Thread J. Ryan Stinnett via cfe-commits
https://github.com/jryans edited https://github.com/llvm/llvm-project/pull/66745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [IPSCCP] Variable not visible at Og. (PR #66745)

2023-10-06 Thread J. Ryan Stinnett via cfe-commits
https://github.com/jryans edited https://github.com/llvm/llvm-project/pull/66745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [IPSCCP] Variable not visible at Og. (PR #66745)

2023-10-06 Thread J. Ryan Stinnett via cfe-commits
https://github.com/jryans edited https://github.com/llvm/llvm-project/pull/66745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Emit dummy values for unknown C variables (PR #66749)

2023-10-06 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM aside from a commenting nit. https://github.com/llvm/llvm-project/pull/66749 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[clang] [clang][Interp] Emit dummy values for unknown C variables (PR #66749)

2023-10-06 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/66749 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Emit dummy values for unknown C variables (PR #66749)

2023-10-06 Thread Aaron Ballman via cfe-commits
@@ -208,7 +208,7 @@ class Program final { llvm::DenseMap Records; /// Dummy parameter to generate pointers from. AaronBallman wrote: The comment is no longer quite correct. https://github.com/llvm/llvm-project/pull/66749 _

[clang] Fixes and closes #53952. Setting the ASTHasCompilerErrors member variable correctly based on the PP diagnostics. (PR #68127)

2023-10-06 Thread Rajkumar Ananthu via cfe-commits
rajkumarananthu wrote: Thanks for taking care of this @AaronBallman https://github.com/llvm/llvm-project/pull/68127 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix typo "x84_64" (PR #68419)

2023-10-06 Thread Casey Carter via cfe-commits
https://github.com/CaseyCarter created https://github.com/llvm/llvm-project/pull/68419 Apparently great minds think alike: I noticed these while correcting the same typo in MSVC's sources. >From 2c4ce58cb944774bcfc404ebbeed167c320fbb28 Mon Sep 17 00:00:00 2001 From: Casey Carter Date: Fri, 6

[clang] Fix typo "x84_64" (PR #68419)

2023-10-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-x86 Changes Apparently great minds think alike: I noticed these while correcting the same typo in MSVC's sources. --- Full diff: https://github.com/llvm/llvm-project/pull/68419.diff 2 Files Affected: - (modified) clang/test/Driver/cuda-detect

[clang] [CUDA][HIP] Fix host/device context in concept (PR #67721)

2023-10-06 Thread Yaxun Liu via cfe-commits
@@ -176,3 +176,34 @@ Predefined Macros * - ``HIP_API_PER_THREAD_DEFAULT_STREAM`` - Alias to ``__HIP_API_PER_THREAD_DEFAULT_STREAM__``. Deprecated. +C++20 Concepts with HIP and CUDA + + +In Clang, when working with HIP or CUDA, it's impor

[clang] Fix typo "x84_64" (PR #68419)

2023-10-06 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang approved this pull request. Good catch, thanks! https://github.com/llvm/llvm-project/pull/68419 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Avoid evaluating the BitWidth expression over and over again (PR #66203)

2023-10-06 Thread Timm Baeder via cfe-commits
tbaederr wrote: ^ Removing integer and boolean expressions seems to have some negative impact though. https://github.com/llvm/llvm-project/pull/66203 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[clang] Fix typo "x84_64" (PR #68419)

2023-10-06 Thread Casey Carter via cfe-commits
CaseyCarter wrote: The test failure _cannot possibly_ be related to this nearly non-functional change. Shall I merge anyway, or rerun? ``` TEST 'BOLT :: RISCV/reloc-tls.s' FAILED   | Exit Code: 1   |     | Command Output (stderr):   | --   | RUN: at lin

[clang] Fix typo "x84_64" (PR #68419)

2023-10-06 Thread Phoebe Wang via cfe-commits
phoebewang wrote: I think it's ok to merge. https://github.com/llvm/llvm-project/pull/68419 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 07f7f1c - Fix typo "x84_64" (#68419)

2023-10-06 Thread via cfe-commits
Author: Casey Carter Date: 2023-10-06T08:04:35-07:00 New Revision: 07f7f1ce10dd668718a3ad009a284706ef00555c URL: https://github.com/llvm/llvm-project/commit/07f7f1ce10dd668718a3ad009a284706ef00555c DIFF: https://github.com/llvm/llvm-project/commit/07f7f1ce10dd668718a3ad009a284706ef00555c.diff

[clang] Fix typo "x84_64" (PR #68419)

2023-10-06 Thread Casey Carter via cfe-commits
https://github.com/CaseyCarter closed https://github.com/llvm/llvm-project/pull/68419 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Add check for bitfield assignments to larger integral types (PR #68276)

2023-10-06 Thread via cfe-commits
@@ -6171,6 +6171,9 @@ def warn_signed_bitfield_enum_conversion : Warning< "signed bit-field %0 needs an extra bit to represent the largest positive " "enumerators of %1">, InGroup, DefaultIgnore; +def warn_bitfield_too_small_for_integral_type : Warning< + "bit-field %0 (

[clang] [Sema] Add check for bitfield assignments to larger integral types (PR #68276)

2023-10-06 Thread via cfe-commits
@@ -0,0 +1,36 @@ +// RUN: %clang_cc1 -Wconversion -fsyntax-only -verify %s + +typedef struct _xx { + int bf:9; // expected-note{{widen this field to 32 bits to store all values of 'int'}} + // expected-note@-1{{widen this field to 16 bits to store all values of 'short'}}

[clang] [Sema] Add check for bitfield assignments to larger integral types (PR #68276)

2023-10-06 Thread via cfe-commits
vabridgers wrote: I'll add a release note also in the next iteration. Thanks https://github.com/llvm/llvm-project/pull/68276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [InstCombine] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

2023-10-06 Thread Matt Arsenault via cfe-commits
@@ -6397,6 +6397,41 @@ static Value *simplifyBinaryIntrinsic(Function *F, Value *Op0, Value *Op1, return Constant::getNullValue(ReturnType); break; } + case Intrinsic::ptrmask: { +if (isa(Op0) || isa(Op1)) + return PoisonValue::get(Op0->getType()); + +

[clang] [HIP] Document func ptr and virtual func (PR #68126)

2023-10-06 Thread Yaxun Liu via cfe-commits
@@ -176,3 +176,65 @@ Predefined Macros * - ``HIP_API_PER_THREAD_DEFAULT_STREAM`` - Alias to ``__HIP_API_PER_THREAD_DEFAULT_STREAM__``. Deprecated. +Function Pointers Support in Clang with HIP +=== + +Function pointers' support va

[clang] [clang][ASTImporter] Fix crash when import `VarTemplateDecl` in record (PR #67522)

2023-10-06 Thread Balázs Kéri via cfe-commits
https://github.com/balazske approved this pull request. https://github.com/llvm/llvm-project/pull/67522 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MLIR][Presburger] Fix reduce bug in Fraction class and add tests (PR #68298)

2023-10-06 Thread Arjun P via cfe-commits
https://github.com/Superty closed https://github.com/llvm/llvm-project/pull/68298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   >