https://github.com/shraiysh created
https://github.com/llvm/llvm-project/pull/68364
This patch adds support for `thread_limit` and upperbound on `num_teams` clause
for the teams construct in OpenMP.
Added testcases for the same.
>From 2d3b34476df53f39d6cc6b7eee02b9d0d33e7a04 Mon Sep 17 00:00:
llvmbot wrote:
@llvm/pr-subscribers-flang-openmp
Changes
This patch adds support for `thread_limit` and upperbound on `num_teams` clause
for the teams construct in OpenMP.
Added testcases for the same.
---
Full diff: https://github.com/llvm/llvm-project/pull/68364.diff
3 Files Affected
https://github.com/vabridgers edited
https://github.com/llvm/llvm-project/pull/68276
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-flang-openmp
Changes
This patch adds support for `thread_limit` and upperbound on `num_teams` clause
for the teams construct in OpenMP.
Added testcases for the same.
---
Full diff: https://github.com/llvm/llvm-project/pull/68364.diff
3 Files Affected
llvmbot wrote:
@llvm/pr-subscribers-flang-openmp
Changes
This patch adds support for `thread_limit` and upperbound on `num_teams` clause
for the teams construct in OpenMP.
Added testcases for the same.
---
Full diff: https://github.com/llvm/llvm-project/pull/68364.diff
3 Files Affected
@@ -19,20 +19,38 @@ namespace llvm {
// Visitor class that finds all indirect call.
struct PGOIndirectCallVisitor : public InstVisitor {
std::vector IndirectCalls;
+ std::vector VTableAddrs;
PGOIndirectCallVisitor() = default;
void visitCallBase(CallBase &Call) {
https://github.com/modiking edited
https://github.com/llvm/llvm-project/pull/66825
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
huangjd wrote:
It looks like after using HashKeyMap, the purpose of SymbolMap and
GUIDToFuncNameMap can be merged. SymbolMap maps StringRef to Function*,
GUIDToFuncNameMap maps ProfileFuncRef's hash code to StringRef, and it's almost
exclusively cascaded to SymbolMap lookup, so we can actually
huangjd wrote:
It looks like after using HashKeyMap, the purpose of SymbolMap and
GUIDToFuncNameMap can be merged. SymbolMap maps StringRef to Function*,
GUIDToFuncNameMap maps ProfileFuncRef's hash code to StringRef, and it's almost
exclusively cascaded to SymbolMap lookup, so we can actually
@@ -3088,9 +3088,6 @@ void ItaniumCXXABI::EmitThreadLocalInitFuncs(
CharUnits Align = CGM.getContext().getDeclAlign(VD);
Val = Builder.CreateAlignedLoad(Var->getValueType(), Val, Align);
}
-if (Val->getType() != Wrapper->getReturnType())
- Val = Builder
@@ -2138,6 +2138,8 @@ class IRBuilderBase {
return Insert(CastInst::CreatePointerCast(V, DestTy), Name);
}
+ // With opaque pointers enabled, this is same as CreateAddressSpaceCast.
s-barannikov wrote:
I'll try to rephrase @arsenm comment.
If the types
@@ -2192,6 +2194,9 @@ static bool IsStandardConversion(Sema &S, Expr* From,
QualType ToType,
From->isIntegerConstantExpr(S.getASTContext())) {
SCS.Second = ICK_Compatible_Conversion;
FromType = ToType;
+ } else if (ToType->isFixedPointType() || FromType->
@@ -156,7 +156,8 @@ ImplicitConversionRank
clang::GetConversionRank(ImplicitConversionKind Kind) {
// it was omitted by the patch that added
// ICK_Zero_Queue_Conversion
ICR_C_Conversion,
-ICR_C_Conversion_Extension
+ICR_C_
https://github.com/rjmccall edited
https://github.com/llvm/llvm-project/pull/68344
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2138,6 +2138,8 @@ class IRBuilderBase {
return Insert(CastInst::CreatePointerCast(V, DestTy), Name);
}
+ // With opaque pointers enabled, this is same as CreateAddressSpaceCast.
JOE1994 wrote:
> If the types (= address spaces) are the same,
> Crea
@@ -2138,6 +2138,8 @@ class IRBuilderBase {
return Insert(CastInst::CreatePointerCast(V, DestTy), Name);
}
+ // With opaque pointers enabled, this is same as CreateAddressSpaceCast.
JOE1994 wrote:
```suggestion
// With opaque pointers enabled, this c
@@ -3088,9 +3088,6 @@ void ItaniumCXXABI::EmitThreadLocalInitFuncs(
CharUnits Align = CGM.getContext().getDeclAlign(VD);
Val = Builder.CreateAlignedLoad(Var->getValueType(), Val, Align);
}
-if (Val->getType() != Wrapper->getReturnType())
- Val = Builder
@@ -0,0 +1,51 @@
+#include "mlir/Analysis/Presburger/Fraction.h"
+#include "./Utils.h"
+#include
+#include
+
+using namespace mlir;
+using namespace presburger;
+
+TEST(FractionTest, getAsInteger) {
+ Fraction f(3, 1);
+ EXPECT_EQ(f.getAsInteger(), MPInt(3));
+}
+
+TEST(Fracti
https://github.com/Superty requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/68298
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,51 @@
+#include "mlir/Analysis/Presburger/Fraction.h"
+#include "./Utils.h"
+#include
+#include
+
+using namespace mlir;
+using namespace presburger;
+
+TEST(FractionTest, getAsInteger) {
+ Fraction f(3, 1);
+ EXPECT_EQ(f.getAsInteger(), MPInt(3));
+}
+
+TEST(Fracti
https://github.com/Superty edited
https://github.com/llvm/llvm-project/pull/68298
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,51 @@
+#include "mlir/Analysis/Presburger/Fraction.h"
+#include "./Utils.h"
+#include
+#include
+
+using namespace mlir;
+using namespace presburger;
+
+TEST(FractionTest, getAsInteger) {
+ Fraction f(3, 1);
+ EXPECT_EQ(f.getAsInteger(), MPInt(3));
+}
+
+TEST(Fracti
https://github.com/Superty requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/68298
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,51 @@
+#include "mlir/Analysis/Presburger/Fraction.h"
+#include "./Utils.h"
+#include
+#include
+
+using namespace mlir;
+using namespace presburger;
+
+TEST(FractionTest, getAsInteger) {
+ Fraction f(3, 1);
+ EXPECT_EQ(f.getAsInteger(), MPInt(3));
+}
+
+TEST(Fracti
joker-eph wrote:
Reverted, the bots have been broken all day.
https://github.com/llvm/llvm-project/pull/68136
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jrtc27 added inline comments.
Comment at: clang/test/C/C2x/n2683_2.c:5-6
+#include
+#include
+// CHECK-LABEL: define dso_local void @test_add_overflow_to64(
+// CHECK-SAME: ) #[[ATTR0:[0-9]+]] {
UTC won't insert such a blank line if it doesn't exist in the inpu
ZijunZhao updated this revision to Diff 557622.
ZijunZhao added a comment.
1. set `--triple=x86-64` as the first argument
2. run the script for the tests
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157331/new/
https://reviews.llvm.org/D157331
Fi
https://github.com/luamfb created
https://github.com/llvm/llvm-project/pull/68368
Fix issue https://github.com/llvm/llvm-project/issues/66990
>From 1f0249fdb0cf7b1799eb9e532bfbb4a3ffe983b0 Mon Sep 17 00:00:00 2001
From: luamfb
Date: Thu, 5 Oct 2023 21:50:10 -0300
Subject: [PATCH] [analyzer] Co
https://github.com/kasuga-fj updated
https://github.com/llvm/llvm-project/pull/65246
>From 01ca65833b2248547f1fb4f7d739517e619ac4cd Mon Sep 17 00:00:00 2001
From: "kasuga.ryotaro"
Date: Wed, 30 Aug 2023 13:26:31 +0900
Subject: [PATCH] [Clang] Fix missing diagnostic for non-standard layout type
@@ -3088,9 +3088,6 @@ void ItaniumCXXABI::EmitThreadLocalInitFuncs(
CharUnits Align = CGM.getContext().getDeclAlign(VD);
Val = Builder.CreateAlignedLoad(Var->getValueType(), Val, Align);
}
-if (Val->getType() != Wrapper->getReturnType())
- Val = Builder
https://github.com/s-barannikov approved this pull request.
LGTM with the suggestion applied.
https://github.com/llvm/llvm-project/pull/68277
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
https://github.com/ahatanak edited
https://github.com/llvm/llvm-project/pull/67454
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ahatanak edited
https://github.com/llvm/llvm-project/pull/67454
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ThomasRaoux wrote:
I ran the patch on our triton kernels and I don't see any functional problems
left.
https://github.com/llvm/llvm-project/pull/67866
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
https://github.com/shiltian created
https://github.com/llvm/llvm-project/pull/68373
This patch makes `num_teams` and `thread_limit` mandatory for bare kernels,
similar to a reguar kernel language that when launching a kernel, the grid size
has to be set explicitly.
>From 3f88ed4ca8df5e0432afda
llvmbot wrote:
@llvm/pr-subscribers-clang
Changes
This patch makes `num_teams` and `thread_limit` mandatory for bare kernels,
similar to a reguar kernel language that when launching a kernel, the grid size
has to be set explicitly.
---
Patch is 34.10 KiB, truncated to 20.00 KiB below, fu
https://github.com/ThomasRaoux approved this pull request.
Looks like it required quite a lot of cases to be handled :(
Thanks for doing this, it solves some of the problems triton had with latest
LLVM. Changes look good to me.
https://github.com/llvm/llvm-project/pull/67866
__
@@ -0,0 +1,1248 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
UTC_ARGS: --version 3
+; ## Support i16x2 instructions
+; RUN: llc < %s -mtriple=nvptx64-nvidia-cuda -mcpu=sm_90 -mattr=+ptx80 \
+; RUN: -O0 -disable-post-ra -frame-pointer=
https://github.com/ThomasRaoux edited
https://github.com/llvm/llvm-project/pull/67866
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ThomasRaoux approved this pull request.
Looks like it required quite a lot of cases to be handled :(
Thanks for doing this, it solves some of the problems triton had with latest
LLVM. Changes look good to me.
https://github.com/llvm/llvm-project/pull/67866
__
https://github.com/JOE1994 updated
https://github.com/llvm/llvm-project/pull/68277
>From 2c3fb032e7fdefa553ed4833bbeed8852eb6a410 Mon Sep 17 00:00:00 2001
From: Youngsuk Kim
Date: Mon, 2 Oct 2023 12:28:33 -0400
Subject: [PATCH 1/2] [clang] Replace uses of
CreatePointerBitCastOrAddrSpaceCast (N
https://github.com/JOE1994 updated
https://github.com/llvm/llvm-project/pull/68277
>From 2c3fb032e7fdefa553ed4833bbeed8852eb6a410 Mon Sep 17 00:00:00 2001
From: Youngsuk Kim
Date: Mon, 2 Oct 2023 12:28:33 -0400
Subject: [PATCH 1/3] [clang] Replace uses of
CreatePointerBitCastOrAddrSpaceCast (N
Author: Owen Pan
Date: 2023-10-05T19:24:08-07:00
New Revision: 84cbd9f4ffba17a74516d1afa442568dc54eabb1
URL:
https://github.com/llvm/llvm-project/commit/84cbd9f4ffba17a74516d1afa442568dc54eabb1
DIFF:
https://github.com/llvm/llvm-project/commit/84cbd9f4ffba17a74516d1afa442568dc54eabb1.diff
LOG:
https://github.com/aartbik updated
https://github.com/llvm/llvm-project/pull/68360
>From 6094912685a0cfa5c13e023e8ec97238a84fca2f Mon Sep 17 00:00:00 2001
From: Aart Bik
Date: Thu, 5 Oct 2023 13:22:28 -0700
Subject: [PATCH 1/4] [mlir][sparse] introduce MapRef, unify conversion/codegen
for read
jhuber6 wrote:
Does `thread_limit` directly imply the number of threads? I thought that it
merely set an upper bound such that it cannot be increased beyond that via
environment variables.
https://github.com/llvm/llvm-project/pull/68373
___
cfe-commi
https://github.com/Endilll created
https://github.com/llvm/llvm-project/pull/68377
While working on LLDB visualizer for `QualType`, I stumbled upon `Type` and
`ExtQuals` defined with `alignas(8)`. Such alignment leaves only 3 lower bits
available for pointer tagging, whereas `QualType` require
llvmbot wrote:
@llvm/pr-subscribers-clang
Changes
While working on LLDB visualizer for `QualType`, I stumbled upon `Type` and
`ExtQuals` defined with `alignas(8)`. Such alignment leaves only 3 lower bits
available for pointer tagging, whereas `QualType` requires 4 (3 qualifiers +
discrim
Endilll wrote:
My plan is to phase-out `TypeAlignment` in subsequent patches, because we have
proper language support for `alignas` and `alignof` now. It's the only one of
its kind passed to `Allocate()` (I inspected all references to this function).
CC @zygolod as the author of ee0ce302c5eb4f2
Endilll wrote:
CC @zygoloid as the author of ee0ce302c5eb4f26738f334f2fd8b165fa65dfca
https://github.com/llvm/llvm-project/pull/68377
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff da0ce32cc3221686f30a6267f43d8c5dd469ef80
8503ff3e70e585a4a3597e3ee8111269f48105cc --
Endilll wrote:
Relevant code snippets:
https://github.com/llvm/llvm-project/blob/777a6e6f10b2b90496d248b7fa904fce834484be/clang/lib/AST/ASTContext.cpp#L5813C1-L5816C33
https://github.com/llvm/llvm-project/blob/777a6e6f10b2b90496d248b7fa904fce834484be/clang/lib/AST/ASTContext.cpp#L4997C1-L5002C70
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/68377
>From 8503ff3e70e585a4a3597e3ee8111269f48105cc Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Thu, 5 Oct 2023 13:18:14 +0300
Subject: [PATCH 1/2] [clang] Align Type and ExtQuals on 16-byte boundary
---
shiltian wrote:
> Does `thread_limit` directly imply the number of threads? I thought that it
> merely set an upper bound such that it cannot be increased beyond that via
> environment variables.
Based on the spec, yes. However, here since `ompx_bare` is an extension, we can
redefine semantic
https://github.com/antangelo created
https://github.com/llvm/llvm-project/pull/68379
When a nested template is instantiated, the template pattern of the inner class
is not copied into the outer class ClassTemplateSpecializationDecl. The
specialization contains a ClassTemplateDecl with an empty
llvmbot wrote:
@llvm/pr-subscribers-clang
Changes
When a nested template is instantiated, the template pattern of the inner class
is not copied into the outer class ClassTemplateSpecializationDecl. The
specialization contains a ClassTemplateDecl with an empty record that points to
the or
https://github.com/Endilll created
https://github.com/llvm/llvm-project/pull/68382
While working on #68377 inspecting `Allocate()` calls, I found out that there
are couple of places where we forget to use placement-new to create objects in
the allocated memory.
>From d987a8523086ab8b6d49f3954
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/68382
>From d987a8523086ab8b6d49f395429afda75769a731 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Fri, 6 Oct 2023 07:20:07 +0300
Subject: [PATCH 1/2] [clang][NFC] Add missing placement-new after Allocate()
llvmbot wrote:
@llvm/pr-subscribers-clang
Changes
While working on #68377 inspecting `Allocate()` calls, I found out that
there are couple of places where we forget to use placement-new to create
objects in the allocated memory.
---
Full diff: https://github.com/llvm/llvm-project/pull/68
rajkumarananthu wrote:
Hi @AaronBallman I could see a revert of my change here:
https://reviews.llvm.org/rGa6acf3fd49a20c570a390af2a3c84e10b9545b68
Can you please help me confirm whether the change is accepted or reverted.
Should we resubmit the changes here?
Thanks
Rajkumar Ananthu
https://
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff a06e94cf3b375cdfd81f42f60e16ce0c3783ff4a
d987a8523086ab8b6d49f395429afda75769a731 --
glandium wrote:
This unveiled an interesting problem in our builds: `llvm-config --cxxflags`
doesn't include the `/MT`/`/MD` flag, so when building something that links
with one of the .lib from LLVM, you can end up with a failure because you're
not building with the same flag as LLVM was buil
glandium wrote:
> Which used to be MT and with this change is now MD.
(because our script was still using LLVM_USE_CRT_RELEASE)
https://github.com/llvm/llvm-project/pull/66850
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.
phyBrackets wrote:
Not sure but the issue in the reverted commit seems like a backporting issue,
so you may need to backport the changes in case. But I'd say wait for Aaron
comment.
https://github.com/llvm/llvm-project/pull/68127
___
cfe-commits mai
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/68377
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1982,9 +1986,9 @@ class alignas(8) Type : public ExtQualsTypeCommonBase {
Type(TypeClass tc, QualType canon, TypeDependence Dependence)
: ExtQualsTypeCommonBase(this,
canon.isNull() ? QualType(this_(), 0) : canon) {
-static_assert(
https://github.com/cor3ntin commented:
Generally LGTM, i just have 1 small concern regarding allowing a bigger `Type`
https://github.com/llvm/llvm-project/pull/68377
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
@@ -1982,9 +1986,9 @@ class alignas(8) Type : public ExtQualsTypeCommonBase {
Type(TypeClass tc, QualType canon, TypeDependence Dependence)
: ExtQualsTypeCommonBase(this,
canon.isNull() ? QualType(this_(), 0) : canon) {
-static_assert(
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/68377
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Timm Baeder
Date: 2023-10-06T08:41:49+02:00
New Revision: aad7e0a994f4e3d73137fc4a1001785110f9bbe6
URL:
https://github.com/llvm/llvm-project/commit/aad7e0a994f4e3d73137fc4a1001785110f9bbe6
DIFF:
https://github.com/llvm/llvm-project/commit/aad7e0a994f4e3d73137fc4a1001785110f9bbe6.diff
L
https://github.com/tbaederr closed
https://github.com/llvm/llvm-project/pull/68312
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tbaederr wrote:
Ping
https://github.com/llvm/llvm-project/pull/67669
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
301 - 371 of 371 matches
Mail list logo
