[clang] [clang-cl] Fix value of __FUNCTION__ in MSVC mode. (PR #67592)

zahiraam wrote: > struct S { int x; }; > namespace NS { > class C {}; > } > > S foo(S s1, NS::C c1) { > S s12{12}; > using namespace NS; > C c; > } @AaronBallman By pretty printed you mean the use of __PRETTY_FUNCTION__ right? In MSVC this macro is not defined. The equivalent one is FUNCS

[clang] [ConstantRange] Handle `Intrinsic::cttz` and `Intrinsic::ctpop` (PR #67917)

https://github.com/dtcxzyw updated https://github.com/llvm/llvm-project/pull/67917 >From b5d134c88a04c524b1d9120a1c1a5dae3722904c Mon Sep 17 00:00:00 2001 From: Yingwei Zheng Date: Sun, 1 Oct 2023 22:17:35 +0800 Subject: [PATCH 1/2] [ConstantRange] Handle `Intrinsic::cttz` and `Intrinsic::ctpo

[clang-tools-extra] [ConstantRange] Handle `Intrinsic::cttz` and `Intrinsic::ctpop` (PR #67917)

https://github.com/dtcxzyw updated https://github.com/llvm/llvm-project/pull/67917 >From b5d134c88a04c524b1d9120a1c1a5dae3722904c Mon Sep 17 00:00:00 2001 From: Yingwei Zheng Date: Sun, 1 Oct 2023 22:17:35 +0800 Subject: [PATCH 1/2] [ConstantRange] Handle `Intrinsic::cttz` and `Intrinsic::ctpo

[clang] [ConstantRange] Handle `Intrinsic::cttz` (PR #67917)

https://github.com/dtcxzyw edited https://github.com/llvm/llvm-project/pull/67917 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [ConstantRange] Handle `Intrinsic::cttz` (PR #67917)

https://github.com/dtcxzyw edited https://github.com/llvm/llvm-project/pull/67917 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HIP] Support compressing device binary (PR #67162)

yxsamliu wrote: [AMD Official Use Only - General] I have reverted the commit. Will fix and reland. Thanks. Sam From: mikaelholmen ***@***.***> Sent: Thursday, October 5, 2023 4:05 AM To: llvm/llvm-project ***@***.***> Cc: Liu, Yaxun (Sam) ***@***.***>; State change ***@***.***> Subject: Re: [l

[PATCH] D151730: [RISCV] Support target attribute for function

BeMg added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151730/new/ https://reviews.llvm.org/D151730 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[clang-tools-extra] [ConstantRange] Handle `Intrinsic::cttz` (PR #67917)

https://github.com/dtcxzyw updated https://github.com/llvm/llvm-project/pull/67917 >From b5d134c88a04c524b1d9120a1c1a5dae3722904c Mon Sep 17 00:00:00 2001 From: Yingwei Zheng Date: Sun, 1 Oct 2023 22:17:35 +0800 Subject: [PATCH 1/3] [ConstantRange] Handle `Intrinsic::cttz` and `Intrinsic::ctpo

[clang] [ConstantRange] Handle `Intrinsic::cttz` (PR #67917)

https://github.com/dtcxzyw updated https://github.com/llvm/llvm-project/pull/67917 >From b5d134c88a04c524b1d9120a1c1a5dae3722904c Mon Sep 17 00:00:00 2001 From: Yingwei Zheng Date: Sun, 1 Oct 2023 22:17:35 +0800 Subject: [PATCH 1/3] [ConstantRange] Handle `Intrinsic::cttz` and `Intrinsic::ctpo

[clang] [ConstantRange] Handle `Intrinsic::cttz` (PR #67917)

https://github.com/dtcxzyw edited https://github.com/llvm/llvm-project/pull/67917 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HIP] Support compressing device binary (PR #67162)

jhuber6 wrote: For reference, I've had similar problems in the past. Usually it happens because the header needs to be aligned on a `uint64_t` to be read. The ELF section has 8-byte alignment, but that can be incorrect when extracting from something like an archive. I just make a copy in that

[clang-tools-extra] [ConstantRange] Handle `Intrinsic::cttz` (PR #67917)

@@ -1735,6 +1746,122 @@ ConstantRange ConstantRange::ctlz(bool ZeroIsPoison) const { return getNonEmpty(APInt(getBitWidth(), getUnsignedMax().countl_zero()), APInt(getBitWidth(), getUnsignedMin().countl_zero() + 1)); } +static ConstantRange getUnsignedCo

[clang] [ConstantRange] Handle `Intrinsic::cttz` (PR #67917)

@@ -1735,6 +1746,122 @@ ConstantRange ConstantRange::ctlz(bool ZeroIsPoison) const { return getNonEmpty(APInt(getBitWidth(), getUnsignedMax().countl_zero()), APInt(getBitWidth(), getUnsignedMin().countl_zero() + 1)); } +static ConstantRange getUnsignedCo

[clang] [libc] Partially implement 'rand' for the GPU (PR #66167)

jhuber6 wrote: > Can you double check this error from the linux x86_64 bot: > > ``` > /var/lib/buildkite-agent/builds/linux-56-7f758798dd-khkmx-1/llvm-project/github-pull-requests/libc/test/src/stdlib/rand_test.cpp:27:2: > error: unterminated conditional directive > -- > | #ifndef LIBC_TARGET

[clang] [MLIR][Presburger] Fix reduce bug in Fraction class and add tests (PR #68298)

https://github.com/Abhinav271828 updated https://github.com/llvm/llvm-project/pull/68298 >From 8b09dcb29a66c3c88bdf1acac2df65091ab60183 Mon Sep 17 00:00:00 2001 From: Abhinav271828 Date: Wed, 6 Sep 2023 14:11:26 +0100 Subject: [PATCH 1/4] Update upstream branch --- libcxx/modules/std/mdspan.c

[clang-tools-extra] [MLIR][Presburger] Fix reduce bug in Fraction class and add tests (PR #68298)

https://github.com/Abhinav271828 updated https://github.com/llvm/llvm-project/pull/68298 >From 8b09dcb29a66c3c88bdf1acac2df65091ab60183 Mon Sep 17 00:00:00 2001 From: Abhinav271828 Date: Wed, 6 Sep 2023 14:11:26 +0100 Subject: [PATCH 1/4] Update upstream branch --- libcxx/modules/std/mdspan.c

[clang-tools-extra] [ConstantRange] Handle `Intrinsic::cttz` (PR #67917)

https://github.com/dtcxzyw updated https://github.com/llvm/llvm-project/pull/67917 >From b5d134c88a04c524b1d9120a1c1a5dae3722904c Mon Sep 17 00:00:00 2001 From: Yingwei Zheng Date: Sun, 1 Oct 2023 22:17:35 +0800 Subject: [PATCH 1/4] [ConstantRange] Handle `Intrinsic::cttz` and `Intrinsic::ctpo

[clang] [ConstantRange] Handle `Intrinsic::cttz` (PR #67917)

https://github.com/dtcxzyw updated https://github.com/llvm/llvm-project/pull/67917 >From b5d134c88a04c524b1d9120a1c1a5dae3722904c Mon Sep 17 00:00:00 2001 From: Yingwei Zheng Date: Sun, 1 Oct 2023 22:17:35 +0800 Subject: [PATCH 1/4] [ConstantRange] Handle `Intrinsic::cttz` and `Intrinsic::ctpo

[clang-tools-extra] [ConstantRange] Handle `Intrinsic::cttz` (PR #67917)

@@ -1735,6 +1746,122 @@ ConstantRange ConstantRange::ctlz(bool ZeroIsPoison) const { return getNonEmpty(APInt(getBitWidth(), getUnsignedMax().countl_zero()), APInt(getBitWidth(), getUnsignedMin().countl_zero() + 1)); } +static ConstantRange getUnsignedCo

[clang] [ConstantRange] Handle `Intrinsic::cttz` (PR #67917)

@@ -1735,6 +1746,122 @@ ConstantRange ConstantRange::ctlz(bool ZeroIsPoison) const { return getNonEmpty(APInt(getBitWidth(), getUnsignedMax().countl_zero()), APInt(getBitWidth(), getUnsignedMin().countl_zero() + 1)); } +static ConstantRange getUnsignedCo

[PATCH] D157613: [Clang][ExtendLifetimes][3/4] Add -fextend-lifetimes flag to Clang to extend the lifetime of local variables

StephenTozer added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:3492-3499 +// Ignore fake uses and the instructions that load their +// operands. +if (Intrinsic->getIntrinsicID() == llvm::Intrinsic::fake_use) { + const llvm::Value *Fa

[clang-tools-extra] [ConstantRange] Handle `Intrinsic::cttz` (PR #67917)

https://github.com/dtcxzyw edited https://github.com/llvm/llvm-project/pull/67917 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ConstantRange] Handle `Intrinsic::cttz` (PR #67917)

https://github.com/dtcxzyw edited https://github.com/llvm/llvm-project/pull/67917 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 32d16b6 - [clang][Sema][NFC] Remove an unnecessary static_cast

Author: Timm Bäder Date: 2023-10-05T16:15:13+02:00 New Revision: 32d16b64d3125e76f65d7d88a302a33618eb0e6e URL: https://github.com/llvm/llvm-project/commit/32d16b64d3125e76f65d7d88a302a33618eb0e6e DIFF: https://github.com/llvm/llvm-project/commit/32d16b64d3125e76f65d7d88a302a33618eb0e6e.diff LO

[clang] [clang][Diagnostics] Add bitfield source range to zero width diags (PR #68312)

https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/68312 Before: ``` array.cpp:157:8: error: named bit-field 'a' has zero width 157 | char a : 12 - 12; |^ 1 error generated. ``` After: ``` array.cpp:157:8: error: named bit-field 'a' has zero width

[clang] [OpenMP] Prevent AMDGPU from overriding visibility on DT_nohost variables (PR #68264)

https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/68264 >From ddccf41b5c3a198db80199d2432afe60c41cad7b Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Wed, 4 Oct 2023 16:50:20 -0500 Subject: [PATCH] [OpenMP] Prevent AMDGPU from overriding visibility on DT_nohost va

[clang-tools-extra] [clang-tidy][IncludeCleaner] Fix analysis supression in presence of verbatim spellings (PR #68185)

https://github.com/VitaNuo approved this pull request. https://github.com/llvm/llvm-project/pull/68185 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] llvm-canon (PR #68176)

plotfi wrote: I recall approving the original PR on phab. I can re-review if needed. This work was approved to land before, so personally I think it might be overkill to RFC it on discourse again but I am not certain of the right process to take. > Added @plotfi as a reviewer; one drive-by qu

[clang] [clang-cl] Fix value of __FUNCTION__ in MSVC mode. (PR #67592)

AaronBallman wrote: > @AaronBallman By pretty printed you mean the use of **PRETTY_FUNCTION** right? No, I mean using the `DeclPrinter` and `TypePrinter` interfaces that are used to implement `-ast-print`: https://github.com/llvm/llvm-project/blob/32d16b64d3125e76f65d7d88a302a33618eb0e6e/clang/

[clang] [clang-cl] Fix value of __FUNCTION__ in MSVC mode. (PR #67592)

AaronBallman wrote: We have unit tests for these that live at: https://github.com/llvm/llvm-project/blob/32d16b64d3125e76f65d7d88a302a33618eb0e6e/clang/unittests/AST/TypePrinterTest.cpp and https://github.com/llvm/llvm-project/blob/32d16b64d3125e76f65d7d88a302a33618eb0e6e/clang/unittests/AST/D

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

w2yehia added a comment. @alanphipps thanks for handling the AIX case. From inspection it looks sufficient. I wasn't able to apply the patch with `arc`, so I'll wait for it to land and report/fix any AIX specific issues. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138846/new/ https:

[clang] [OpenMP] Prevent AMDGPU from overriding visibility on DT_nohost variables (PR #68264)

@@ -308,12 +308,13 @@ static bool requiresAMDGPUProtectedVisibility(const Decl *D, if (GV->getVisibility() != llvm::GlobalValue::HiddenVisibility) return false; - return D->hasAttr() || - (isa(D) && D->hasAttr()) || - (isa(D) && - (D->hasAttr()

[clang] llvm-canon (PR #68176)

nikic wrote: Please don't use the term canon/canonicalize for this pass or tool. LLVM has an existing notion of "canonicalization" which does coincide with what is being done here. https://github.com/llvm/llvm-project/pull/68176 ___ cfe-commits maili

[clang] 5a36904 - Reapply "InstCombine: Introduce SimplifyDemandedUseFPClass"

Author: Matt Arsenault Date: 2023-10-05T07:49:38-07:00 New Revision: 5a36904c515b9253d90aa0400e6c4dd661e7102b URL: https://github.com/llvm/llvm-project/commit/5a36904c515b9253d90aa0400e6c4dd661e7102b DIFF: https://github.com/llvm/llvm-project/commit/5a36904c515b9253d90aa0400e6c4dd661e7102b.diff

[clang-tools-extra] [Support] Add KnownBits::computeForSubBorrow (PR #67788)

https://github.com/christiankissig updated https://github.com/llvm/llvm-project/pull/67788 >From 5d86936c3a48c613460983c980271fcab8128b75 Mon Sep 17 00:00:00 2001 From: Christian Kissig Date: Tue, 26 Sep 2023 12:18:59 + Subject: [PATCH 1/5] [Support] Add KnownBits::computeForSubBorrow * Im

[clang] [RISCV] Support Xsfvfnrclipxfqf extensions (PR #68297)

@@ -630,7 +630,7 @@ TEST(getTargetFeatureForExtension, RetrieveTargetFeatureFromOneExt) { TEST(RiscvExtensionsHelp, CheckExtensions) { std::string ExpectedOutput = -R"(All available -march extensions for RISC-V + R"(All available -march extensions for RISC-V --

[clang] 6907c3d - [clang] Replace uses of Type::getPointerType (NFC)

Author: JOE1994 Date: 2023-10-05T10:57:41-04:00 New Revision: 6907c3dafd946c5598efe5cbc646809aee873254 URL: https://github.com/llvm/llvm-project/commit/6907c3dafd946c5598efe5cbc646809aee873254 DIFF: https://github.com/llvm/llvm-project/commit/6907c3dafd946c5598efe5cbc646809aee873254.diff LOG:

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

to268 updated this revision to Diff 557614. to268 added a comment. Fix arm buildbot issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133289/new/ https://reviews.llvm.org/D133289 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/

[clang] [clang] Replace uses of CreatePointerBitCastOrAddrSpaceCast (NFC) (PR #68277)

@@ -2138,6 +2138,8 @@ class IRBuilderBase { return Insert(CastInst::CreatePointerCast(V, DestTy), Name); } + // With opaque pointers enabled, this is same as CreateAddressSpaceCast. arsenm wrote: I don't think this is quite accurate, CreateAddrSpaceCas

[clang] [clang] Replace uses of CreatePointerBitCastOrAddrSpaceCast (NFC) (PR #68277)

@@ -2138,6 +2138,8 @@ class IRBuilderBase { return Insert(CastInst::CreatePointerCast(V, DestTy), Name); } + // With opaque pointers enabled, this is same as CreateAddressSpaceCast. nikic wrote: All the IRBuilder cast methods are no-ops if old type ==

[clang] [HIP] Support compressing device binary (PR #67162)

yxsamliu wrote: [AMD Official Use Only - General] Thanks. I will fix it by memcpy instead of dereferencing int* casted from char*. Sam From: Joseph Huber ***@***.***> Sent: Thursday, October 5, 2023 9:23 AM To: llvm/llvm-project ***@***.***> Cc: Liu, Yaxun (Sam) ***@***.***>; State change ***@

[clang] [Support] Deprecate system_endianness (PR #68279)

https://github.com/kuhar approved this pull request. nit: typos in the commit/PR message: bit --> big code lgtm https://github.com/llvm/llvm-project/pull/68279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[clang-tools-extra] llvm-canon (PR #68176)

AaronBallman wrote: > Thanks for reaching out guys. > > I recall approving the original PR on phab. I can re-review if needed. This > work was approved to land before, so personally I think it might be overkill > to RFC it on discourse again but I am not certain of the right process to > take

[clang] 7e28234 - Reland "[HIP] Support compressing device binary"

Author: Yaxun (Sam) Liu Date: 2023-10-05T11:20:46-04:00 New Revision: 7e2823438e920d25364ff92b62ad90020c31bb59 URL: https://github.com/llvm/llvm-project/commit/7e2823438e920d25364ff92b62ad90020c31bb59 DIFF: https://github.com/llvm/llvm-project/commit/7e2823438e920d25364ff92b62ad90020c31bb59.dif

[clang] [OpenMP] Prevent AMDGPU from overriding visibility on DT_nohost variables (PR #68264)

@@ -308,12 +308,13 @@ static bool requiresAMDGPUProtectedVisibility(const Decl *D, if (GV->getVisibility() != llvm::GlobalValue::HiddenVisibility) return false; - return D->hasAttr() || - (isa(D) && D->hasAttr()) || - (isa(D) && - (D->hasAttr()

[PATCH] D72390: [www] Remove stale text about default c++ standard from cxx_status.html

russell.gallop abandoned this revision. russell.gallop added a comment. Herald added a project: All. Latest page looks fine: https://clang.llvm.org/cxx_status.html#cxx11 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72390/new/ https://reviews.llvm.

[clang] [clang][USR] Encode full decl-context also for anon namespaces (PR #68325)

https://github.com/kadircet created https://github.com/llvm/llvm-project/pull/68325 Otherwise we create collisions, e.g. a struct named Foo inside an anonymous namespace will get the same USR no matter what the surrounding decl-context is. From 5603c6ee481332f82c8ec1589e3e1610c570526d Mon Sep

[clang] [clang][USR] Encode full decl-context also for anon namespaces (PR #68325)

llvmbot wrote: @llvm/pr-subscribers-clang Changes Otherwise we create collisions, e.g. a struct named Foo inside an anonymous namespace will get the same USR no matter what the surrounding decl-context is. --- Full diff: https://github.com/llvm/llvm-project/pull/68325.diff 2 Files Affec

[clang] [clang][NFC] Refactor Builtins.def to be a tablegen file (PR #68324)

@@ -172,6 +173,8 @@ cl::opt Action( "Generate clang attribute text node dumper"), clEnumValN(GenClangAttrNodeTraverse, "gen-clang-attr-node-traverse", "Generate clang attribute traverser"), +clEnumValN(GenClangBuiltins, "gen

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

glaubitz added a comment. Maybe these patches need to be reposted to Github as they seem to be ignored here now after the swtich from Phabricator. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149867/new/ https://reviews.llvm.org/D149867 ___

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

jrtc27 added a comment. Posting on GitHub loses all context; please don't do that. Whose review are you looking for? You've addressed my feedback and you had approval from Aaron on the prior version, with the latest version just being a few minor tweaks to address the couple of comments I had l

[clang] fix usr rhs (PR #68329)

https://github.com/kadircet created https://github.com/llvm/llvm-project/pull/68329 None From 5603c6ee481332f82c8ec1589e3e1610c570526d Mon Sep 17 00:00:00 2001 From: Kadir Cetinkaya Date: Thu, 5 Oct 2023 16:55:17 +0200 Subject: [PATCH 1/2] [clang][USR] Encode full decl-context also for anon n

[clang] [RISCV] Fix wrong implication for zvknhb. (PR #66860)

https://github.com/topperc approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/66860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Fix wrong implication for zvknhb. (PR #66860)

https://github.com/topperc edited https://github.com/llvm/llvm-project/pull/66860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Fix wrong implication for zvknhb. (PR #66860)

@@ -1013,7 +1013,6 @@ static const char *ImpliedExtsZvfhmin[] = {"zve32f"}; static const char *ImpliedExtsZvkn[] = {"zvkb", "zvkned", "zvknhb", "zvkt"}; static const char *ImpliedExtsZvknc[] = {"zvbc", "zvkn"}; static const char *ImpliedExtsZvkng[] = {"zvkg", "zvkn"}; -static c

[clang] [RISCV] Fix wrong implication for zvknhb. (PR #66860)

https://github.com/topperc requested changes to this pull request. https://github.com/llvm/llvm-project/pull/66860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Ensure NoTrapAfterNoreturn is false for the wasm backend (PR #65876)

https://github.com/aheejin approved this pull request. Thanks for your patience! Will merge this. https://github.com/llvm/llvm-project/pull/65876 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[clang] 13ffc61 - [C2X] N3007 Type inference for object definitions

Author: Guillot Tony Date: 2023-10-05T12:16:00-04:00 New Revision: 13ffc61a4224012ab1abb4e806d03fc149aec91f URL: https://github.com/llvm/llvm-project/commit/13ffc61a4224012ab1abb4e806d03fc149aec91f DIFF: https://github.com/llvm/llvm-project/commit/13ffc61a4224012ab1abb4e806d03fc149aec91f.diff

[clang] 6b31b02 - [Support] Deprecate system_endianness (#68279)

Author: Kazu Hirata Date: 2023-10-05T09:17:09-07:00 New Revision: 6b31b026006ee688019e7cf762ab1641df8ff8f6 URL: https://github.com/llvm/llvm-project/commit/6b31b026006ee688019e7cf762ab1641df8ff8f6 DIFF: https://github.com/llvm/llvm-project/commit/6b31b026006ee688019e7cf762ab1641df8ff8f6.diff L

[clang] [Support] Deprecate system_endianness (PR #68279)

https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/68279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] fix usr rhs (PR #68329)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 0ca7e609fc5ebdd9c95f6cba3c608cae4b575846 44a0c88778e5fea419838b2fae1ccd92dab696f5 --

[clang-tools-extra] Ensure NoTrapAfterNoreturn is false for the wasm backend (PR #65876)

https://github.com/aheejin closed https://github.com/llvm/llvm-project/pull/65876 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Ensure NoTrapAfterNoreturn is false for the wasm backend (PR #65876)

https://github.com/aheejin closed https://github.com/llvm/llvm-project/pull/65876 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Support] Deprecate system_endianness (PR #68279)

kazutakahirata wrote: > nit: typos in the commit/PR message: bit --> big Thanks! Fixed the commit message as I merged the commit. https://github.com/llvm/llvm-project/pull/68279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[clang-tools-extra] [clang-tidy][IncludeCleaner] Fix analysis supression in presence of verbatim spellings (PR #68185)

https://github.com/kadircet closed https://github.com/llvm/llvm-project/pull/68185 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [mlir][llvm] Fix elem type passing into `getelementptr` (PR #68136)

https://github.com/rikhuijzer closed https://github.com/llvm/llvm-project/pull/68136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [mlir][llvm] Fix elem type passing into `getelementptr` (PR #68136)

rikhuijzer wrote: Thanks both for the review and clarifications. I'm learning a lot. https://github.com/llvm/llvm-project/pull/68136 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Correct behavior of `LLVM_UNREACHABLE_OPTIMIZE=OFF` for `Release` builds (PR #68284)

https://github.com/AaronBallman commented: Oh wow, that bug has been around for quite a while. I like your solution to it! The code LGTM, no tests required because there isn't really a decent way to test this from lit. However, it would be nice to add a release note to `clang/docs/ReleateNotes

[clang] [clang] Correct behavior of `LLVM_UNREACHABLE_OPTIMIZE=OFF` for `Release` builds (PR #68284)

erichkeane wrote: Agree with Aaron on all points! https://github.com/llvm/llvm-project/pull/68284 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Support Xsfvqmaccdod and Xsfvqmaccqoq extensions (PR #68295)

@@ -318,6 +345,16 @@ multiclass VPseudoVC_XVW { + def "Pseudo" # NAME # "_VV_" # mx : VPseudoTernaryNoMaskWithPolicy; topperc wrote: 80 characters https://github.com/llvm/llvm-project/pull/68295 ___ cfe-commits mailin

[clang] [InstCombine] Canonicalize `(X +/- Y) & Y` into `~X & Y` when Y is a power of 2 (PR #67915)

goldsteinn wrote: LGTM. https://github.com/llvm/llvm-project/pull/67915 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D157331: [clang] Implement C23

aaron.ballman added inline comments. Comment at: clang/test/C/C2x/n2683_2.c:7-15 +// CHECK:%result64 = alloca i64, align 8 +// CHECK:%flag_add = alloca i8, align 1 +// CHECK:store i64 0, ptr %result64, align 8 +// CHECK:%0 = call { i64, i1 } @llvm.sadd.with.overfl

[clang] [InstCombine] Simplify the pattern `a ne/eq (zext/sext (a ne/eq c))` (PR #65852)

goldsteinn wrote: Continue to LGTM... https://github.com/llvm/llvm-project/pull/65852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [InstCombine] Simplify the pattern `a ne/eq (zext/sext (a ne/eq c))` (PR #65852)

goldsteinn wrote: Continue to LGTM... https://github.com/llvm/llvm-project/pull/65852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Highlight code snippets (PR #66514)

Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: tbaederr wrote: > Also, redirecting output to a file doesn't always di

[PATCH] D157331: [clang] Implement C23

jrtc27 added inline comments. Comment at: clang/test/C/C2x/n2683_2.c:7-15 +// CHECK:%result64 = alloca i64, align 8 +// CHECK:%flag_add = alloca i8, align 1 +// CHECK:store i64 0, ptr %result64, align 8 +// CHECK:%0 = call { i64, i1 } @llvm.sadd.with.overflow.i64(

[PATCH] D157331: [clang] Implement C23

aaron.ballman added inline comments. Comment at: clang/test/C/C2x/n2683_2.c:7-15 +// CHECK:%result64 = alloca i64, align 8 +// CHECK:%flag_add = alloca i8, align 1 +// CHECK:store i64 0, ptr %result64, align 8 +// CHECK:%0 = call { i64, i1 } @llvm.sadd.with.overfl

[clang] [clang] Correct behavior of `LLVM_UNREACHABLE_OPTIMIZE=OFF` for `Release` builds (PR #68284)

https://github.com/MasterAwesome updated https://github.com/llvm/llvm-project/pull/68284 >From 8598d5f4cfad4f3887ec40b7c3d21e385f731d9d Mon Sep 17 00:00:00 2001 From: Arvind Mukund Date: Wed, 4 Oct 2023 22:25:08 -0700 Subject: [PATCH 1/3] Correct unreachable hint in release mode When LLVM_UNRE

[clang] [RISCV] Support Xsfvqmaccdod and Xsfvqmaccqoq extensions (PR #68295)

@@ -318,6 +345,16 @@ multiclass VPseudoVC_XVW { + def "Pseudo" # NAME # "_VV_" # mx : VPseudoTernaryNoMaskWithPolicy; michaelmaitland wrote: Is there an 80 character limitation for TableGen? IIRC we haven't set style guidelines for TableGen which is why theres

[clang] [clang] Correct behavior of `LLVM_UNREACHABLE_OPTIMIZE=OFF` for `Release` builds (PR #68284)

MasterAwesome wrote: @erichkeane @AaronBallman, I've added the release notes and rebased the change on `main`. https://github.com/llvm/llvm-project/pull/68284 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[clang] [RISCV] Support Xsfvqmaccdod and Xsfvqmaccqoq extensions (PR #68295)

@@ -318,6 +345,16 @@ multiclass VPseudoVC_XVW { + def "Pseudo" # NAME # "_VV_" # mx : VPseudoTernaryNoMaskWithPolicy; topperc wrote: I don't believe tblgen is meant to be exempt from the 80 column rule. Lack of a clang-format is the reason there are files over

[clang] [RISCV] Support Xsfvqmaccdod and Xsfvqmaccqoq extensions (PR #68295)

https://github.com/topperc edited https://github.com/llvm/llvm-project/pull/68295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Add another SIFoldOperands instance after shrink (PR #67878)

rampitec wrote: > I've taken another look at this. The patch does not show any benefit from > running another `SIFoldOperands` pass _after_ `SIShrinkInstructions` per se; > you get exactly the same results (modulo a couple of add instructions that > have their operands commuted differently) if

[libunwind] [AMDGPU] Add another SIFoldOperands instance after shrink (PR #67878)

rampitec wrote: > I've taken another look at this. The patch does not show any benefit from > running another `SIFoldOperands` pass _after_ `SIShrinkInstructions` per se; > you get exactly the same results (modulo a couple of add instructions that > have their operands commuted differently) if

[clang] [InstCombine] Simplify the pattern `a ne/eq (zext/sext (a ne/eq c))` (PR #65852)

https://github.com/nikic approved this pull request. Basically LGTM, but I think this is still missing negative tests for non-equality pred1/pred2? https://github.com/llvm/llvm-project/pull/65852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang-tools-extra] [InstCombine] Simplify the pattern `a ne/eq (zext/sext (a ne/eq c))` (PR #65852)

https://github.com/nikic approved this pull request. Basically LGTM, but I think this is still missing negative tests for non-equality pred1/pred2? https://github.com/llvm/llvm-project/pull/65852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang] Correct behavior of `LLVM_UNREACHABLE_OPTIMIZE=OFF` for `Release` builds (PR #68284)

@@ -343,6 +343,8 @@ Bug Fixes in This Version - Fix a crash when evaluating value-dependent structured binding variables at compile time. Fixes (`#67690 `_) +- Fixes a regression where ``LLVM_UNREACHABLE_OPTIMIZE=OFF`` cann

[clang] [clang] Correct behavior of `LLVM_UNREACHABLE_OPTIMIZE=OFF` for `Release` builds (PR #68284)

https://github.com/AaronBallman approved this pull request. LGTM modulo Erich's comment on the release notes. https://github.com/llvm/llvm-project/pull/68284 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[clang] 6795503 - Fix the ARM bots

Author: Aaron Ballman Date: 2023-10-05T13:17:47-04:00 New Revision: 67955033fde0518305d1291edc1ee1cfebb986d0 URL: https://github.com/llvm/llvm-project/commit/67955033fde0518305d1291edc1ee1cfebb986d0 DIFF: https://github.com/llvm/llvm-project/commit/67955033fde0518305d1291edc1ee1cfebb986d0.diff

[clang] clang: Add pragma clang fp reciprocal (PR #68267)

https://github.com/arsenm edited https://github.com/llvm/llvm-project/pull/68267 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Refactor Builtins.def to be a tablegen file (PR #68324)

https://github.com/AaronBallman commented: My review may take a bit because GitHub is struggling to render the changes in Builtins.td. However, I want to state up front just how incredibly excited I am for this refactoring. This will go a long ways towards letting us start to generate documen

[clang] [clang][Diagnostics] Add bitfield source range to zero width diags (PR #68312)

https://github.com/cjdb approved this pull request. https://github.com/llvm/llvm-project/pull/68312 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Ignore GCC 11 `[[malloc(x)]]` attribute (PR #68059)

@@ -2064,13 +2064,26 @@ static void handleTLSModelAttr(Sema &S, Decl *D, const ParsedAttr &AL) { static void handleRestrictAttr(Sema &S, Decl *D, const ParsedAttr &AL) { QualType ResultType = getFunctionOrMethodResultType(D); - if (ResultType->isAnyPointerType() || ResultT

[clang] [clang] Ignore GCC 11 `[[malloc(x)]]` attribute (PR #68059)

https://github.com/AaronBallman commented: Thank you for the fix! We generally want ignored attributes to be diagnosed as being ignored; otherwise users have a much harder time determining whether the attribute is working or not. I think we should issue an "attribute ignored" warning when we'

[PATCH] D157331: [clang] Implement C23

ZijunZhao updated this revision to Diff 557618. ZijunZhao marked 3 inline comments as done. ZijunZhao added a comment. Name a regex pattern and then use that to avoid post-commit CI breakage. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157331/new/

[clang] [llvm-profdata] Do not create numerical strings for MD5 function names read from a Sample Profile. (PR #66164)

@@ -0,0 +1,215 @@ +//===--- ProfileFuncRef.h - Sample profile function reference ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [OpenMPIRBuilder] Remove wrapper function in `createTask`, `createTeams` (PR #67723)

@@ -340,6 +340,44 @@ BasicBlock *llvm::splitBBWithSuffix(IRBuilderBase &Builder, bool CreateBranch, return splitBB(Builder, CreateBranch, Old->getName() + Suffix); } +// This function creates a fake integer value and a fake use for the integer +// value. It returns the fake

[PATCH] D157331: [clang] Implement C23

xbolva00 added a comment. Please use update_cc_test_checks.py Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157331/new/ https://reviews.llvm.org/D157331 ___ cfe-commits mailing list cfe-commits@lists.llv

[clang-tools-extra] [OpenMPIRBuilder] Remove wrapper function in `createTask`, `createTeams` (PR #67723)

@@ -340,6 +340,44 @@ BasicBlock *llvm::splitBBWithSuffix(IRBuilderBase &Builder, bool CreateBranch, return splitBB(Builder, CreateBranch, Old->getName() + Suffix); } +// This function creates a fake integer value and a fake use for the integer +// value. It returns the fake

[PATCH] D157331: [clang] Implement C23

jrtc27 added inline comments. Comment at: clang/test/C/C2x/n2683_2.c:14 +// CHECK:store i64 %2, ptr %[[RES64]], align 8 +// CHECK:%frombool = zext i1 %1 to i8 +// CHECK:store i8 %frombool, ptr %[[FLAG_ADD:.*]], align 1 You missed this one. But please

<    1   2   3   4   >