Hahnfeld updated this revision to Diff 557603.
Hahnfeld marked an inline comment as done.
Hahnfeld added a comment.
Address minor naming convention nit.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158413/new/
https://reviews.llvm.org/D158413
Files:
clang/include/clang/Lex/Preproces
Hahnfeld added inline comments.
Comment at: clang/lib/Lex/Preprocessor.cpp:1000
+ std::vector toks;
+ while (1) {
+Token tok;
v.g.vassilev wrote:
> Hahnfeld wrote:
> > aaron.ballman wrote:
> > > v.g.vassilev wrote:
> > > > aaron.ballman wrote:
> > > > > Hah
https://github.com/kasuga-fj updated
https://github.com/llvm/llvm-project/pull/65246
>From aa41086f545daec80770bf17a3cfcc3d3168e394 Mon Sep 17 00:00:00 2001
From: "kasuga.ryotaro"
Date: Wed, 30 Aug 2023 13:26:31 +0900
Subject: [PATCH] [Clang] Fix missing diagnostic for non-standard layout type
Author: Timm Bäder
Date: 2023-10-05T09:37:37+02:00
New Revision: 4d7f4a7c82cb742dd9711cce1cfbe574ac08c068
URL:
https://github.com/llvm/llvm-project/commit/4d7f4a7c82cb742dd9711cce1cfbe574ac08c068
DIFF:
https://github.com/llvm/llvm-project/commit/4d7f4a7c82cb742dd9711cce1cfbe574ac08c068.diff
LO
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG4d7f4a7c82cb: [clang][Interp] Only lazily visit constant
globals (authored by tbaeder).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST AC
mstorsjo wrote:
> > ... I understand this is only a bug on MacOS?
>
> I'm using clang only to compile my binary packages on macOS (the Linux
> binaries are compiled with gcc), so I got bitten by this bug only on macOS.
> The other platforms/targets may or may not be affected, I don't know; but
https://github.com/tbaederr edited
https://github.com/llvm/llvm-project/pull/68276
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Timm Bäder
Date: 2023-10-05T09:46:15+02:00
New Revision: 57147bb25303aef5edf251d1f2243e75dc687aec
URL:
https://github.com/llvm/llvm-project/commit/57147bb25303aef5edf251d1f2243e75dc687aec
DIFF:
https://github.com/llvm/llvm-project/commit/57147bb25303aef5edf251d1f2243e75dc687aec.diff
LO
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG57147bb25303: [clang][Interp] Support LambdaThisCaptures
(authored by tbaeder).
Changed prior to commit:
https://reviews.llvm.org/D154262?vs=53642
mikaelholmen wrote:
Hi,
I noticed that with UBSan this new testcase fails
```
09:59:08 Failed Tests (1):
09:59:08 Clang :: Driver/clang-offload-bundler-zlib.c
```
with
```
09:39:53 ../../clang/lib/Driver/OffloadBundler.cpp:1012:25: runtime error: load
of misaligned address 0x55ceca16e46c for
ftynse wrote:
What I meant in the comment was that MLIR doesn't need to make a hard switch to
using opaque pointers and immediately turn off typed pointers. I didn't really
imply that an operations in the IR should freely mix the two. Typed pointers
should and will be removed from the LLVM dia
https://github.com/ftynse approved this pull request.
https://github.com/llvm/llvm-project/pull/68136
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tbaederr created
https://github.com/llvm/llvm-project/pull/68288
>From https://reviews.llvm.org/D154951 - which is never gonna make it out of
>Phabricator anyway.
The tests are failing because https://reviews.llvm.org/D154581 is not pushed.
Aaron's review mentioned that we
llvmbot wrote:
@llvm/pr-subscribers-clang
Changes
>From https://reviews.llvm.org/D154951 - which is never gonna make it out of
>Phabricator anyway.
The tests are failing because https://reviews.llvm.org/D154581 is not pushed.
Aaron's review mentioned that we should support bitfields bef
https://github.com/JonChesterfield commented:
This stuff looks very cuda/opencl specific. It's definitely surprising for C++
code. Do we need it for openmp? If not it seems better to guard the hack with
visibility behind if (hip)
https://github.com/llvm/llvm-project/pull/68264
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/68090
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: cor3ntin
Date: 2023-10-05T10:17:50+02:00
New Revision: 49666ec0386174b9fcf637560951b8ee29ca82c7
URL:
https://github.com/llvm/llvm-project/commit/49666ec0386174b9fcf637560951b8ee29ca82c7
DIFF:
https://github.com/llvm/llvm-project/commit/49666ec0386174b9fcf637560951b8ee29ca82c7.diff
LOG:
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/68090
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Owen Pan
Date: 2023-10-05T01:18:49-07:00
New Revision: 8902f12e61aa2d3053ad4d536e36569fc8bc9512
URL:
https://github.com/llvm/llvm-project/commit/8902f12e61aa2d3053ad4d536e36569fc8bc9512
DIFF:
https://github.com/llvm/llvm-project/commit/8902f12e61aa2d3053ad4d536e36569fc8bc9512.diff
LOG:
https://github.com/cor3ntin updated
https://github.com/llvm/llvm-project/pull/66222
>From dc95c839c104a0af50da1466e7249bde306bd662 Mon Sep 17 00:00:00 2001
From: Corentin Jabot
Date: Wed, 13 Sep 2023 17:36:39 +0200
Subject: [PATCH 1/8] [Clang] Handle consteval expression in array bounds
expres
@@ -53,6 +55,16 @@ static Value truncToI32(ConversionPatternRewriter &rewriter,
Location loc,
return rewriter.create(loc, rewriter.getI32Type(), value);
}
+/// Returns warp-size as a value.
+static Value getWarpSizeValue(ImplicitLocOpBuilder &b) {
grypp wro
https://github.com/kasuga-fj updated
https://github.com/llvm/llvm-project/pull/65246
>From 57219322f804a099c66c7ea8f4dd069fdd907e21 Mon Sep 17 00:00:00 2001
From: "kasuga.ryotaro"
Date: Wed, 30 Aug 2023 13:26:31 +0900
Subject: [PATCH] [Clang] Fix missing diagnostic for non-standard layout type
tbaederr wrote:
Ping
https://github.com/llvm/llvm-project/pull/67520
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vabridgers updated
https://github.com/llvm/llvm-project/pull/68276
>From 3f5fc972933535ba57c1a833fbd329f81c365f91 Mon Sep 17 00:00:00 2001
From: Vince Bridgers
Date: Thu, 5 Oct 2023 02:39:12 +0200
Subject: [PATCH] [Sema] Add check for bitfield assignments to integral types
W
https://github.com/zero9178 approved this pull request.
https://github.com/llvm/llvm-project/pull/68279
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vabridgers wrote:
@shafik , I updated the check into -Wconversion. Temporarily addressed the CI
failure (to get a passing baseline). Awaiting further review comments. Thank
you.
https://github.com/llvm/llvm-project/pull/68276
___
cfe-commits mailing
Author: Jonas Hahnfeld
Date: 2023-10-05T11:04:07+02:00
New Revision: 3116d60494f219bfcb284d05d9ebed5b6c196ca5
URL:
https://github.com/llvm/llvm-project/commit/3116d60494f219bfcb284d05d9ebed5b6c196ca5
DIFF:
https://github.com/llvm/llvm-project/commit/3116d60494f219bfcb284d05d9ebed5b6c196ca5.diff
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG3116d60494f2: [Lex] Introduce
Preprocessor::LexTokensUntilEOF() (authored by Hahnfeld).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST AC
https://github.com/ilg-ul updated
https://github.com/llvm/llvm-project/pull/68091
>From f3812174546270051c4a2903b9a99408bf5b7ba0 Mon Sep 17 00:00:00 2001
From: Liviu Ionescu
Date: Tue, 3 Oct 2023 14:07:48 +0300
Subject: [PATCH 1/4] [clang][driver] Use platform specific calls to get the
executa
https://github.com/ilg-ul updated
https://github.com/llvm/llvm-project/pull/68091
>From f3812174546270051c4a2903b9a99408bf5b7ba0 Mon Sep 17 00:00:00 2001
From: Liviu Ionescu
Date: Tue, 3 Oct 2023 14:07:48 +0300
Subject: [PATCH 1/5] [clang][driver] Use platform specific calls to get the
executa
nolange wrote:
> @nolange, English is not my first language, and I know sometimes I'm very
> confusing. In my understanding, the title suggest that if clang is not
> invoked directly but via a symlink, it does not behave correctly, i.e.
> instead of picking the headers from the folders where c
https://github.com/ilg-ul updated
https://github.com/llvm/llvm-project/pull/68091
>From f3812174546270051c4a2903b9a99408bf5b7ba0 Mon Sep 17 00:00:00 2001
From: Liviu Ionescu
Date: Tue, 3 Oct 2023 14:07:48 +0300
Subject: [PATCH 1/6] [clang][driver] Use platform specific calls to get the
executa
@@ -5150,9 +5150,11 @@ void Clang::ConstructJob(Compilation &C, const JobAction
&JA,
const bool IsAssertBuild = true;
#endif
- // Disable the verification pass in -asserts builds.
fhahn wrote:
Hmm, I might be missing something here, but doesn't this disab
https://github.com/ilg-ul edited https://github.com/llvm/llvm-project/pull/68091
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/66222
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: cor3ntin
Date: 2023-10-05T11:36:27+02:00
New Revision: c72d3a0966afd2dcb4421dde922c0faf06d65c0e
URL:
https://github.com/llvm/llvm-project/commit/c72d3a0966afd2dcb4421dde922c0faf06d65c0e
DIFF:
https://github.com/llvm/llvm-project/commit/c72d3a0966afd2dcb4421dde922c0faf06d65c0e.diff
LOG:
ilg-ul wrote:
@nolange, thank you for rephrasing the title.
https://github.com/llvm/llvm-project/pull/68091
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
https://github.com/tbaederr updated
https://github.com/llvm/llvm-project/pull/68288
>From e208c2fc7932d80d441d90bfa0fd949b8910a4c4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timm=20B=C3=A4der?=
Date: Tue, 11 Jul 2023 13:45:04 +0200
Subject: [PATC
@@ -5150,9 +5150,11 @@ void Clang::ConstructJob(Compilation &C, const JobAction
&JA,
const bool IsAssertBuild = true;
#endif
- // Disable the verification pass in -asserts builds.
mizvekov wrote:
I edited the line to append the `unless otherwise specified
ilg-ul wrote:
The latest patch fixes the issue #66704 without changing the meaning of
InstalledDir.
It is specific to macOS headers, the libraries were ok.
I also checked the other places where `installedDir` is used, but I'm not
familiar with them (`Hexagon.cpp`, `MipsLinux.cpp`, `OHOS.cpp`,
llvmbot wrote:
@llvm/pr-subscribers-backend-risc-v
Changes
SiFive Int8 Matrix Multiplication Extensions Specification
https://sifive.cdn.prismic.io/sifive/c4f0e51d-4dd3-402a-98bc-1ffad6011259_int8-matmul-spec.pdf
---
Patch is 185.07 KiB, truncated to 20.00 KiB below, full version:
https
https://github.com/4vtomat created
https://github.com/llvm/llvm-project/pull/68296
Bfloat16 Matrix Multiply Accumulate Instruction
https://sifive.cdn.prismic.io/sifive/c391d53e-ffcf-4091-82f6-c37bf3e883ed_xsfvfwmaccqqq-spec.pdf
>From fc484770303cf50819e09dafd0f4f00760e67e3c Mon Sep 17 00:00:00
llvmbot wrote:
@llvm/pr-subscribers-llvm-support
Changes
Bfloat16 Matrix Multiply Accumulate Instruction
https://sifive.cdn.prismic.io/sifive/c391d53e-ffcf-4091-82f6-c37bf3e883ed_xsfvfwmaccqqq-spec.pdf
---
Patch is 39.83 KiB, truncated to 20.00 KiB below, full version:
https://github.co
llvmbot wrote:
@llvm/pr-subscribers-llvm-support
Changes
FP32-to-int8 Ranged Clip Instructions
https://sifive.cdn.prismic.io/sifive/0aacff47-f530-43dc-8446-5caa2260ece0_xsfvfnrclipxfqf-spec.pdf
---
Patch is 182.97 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/
Author: Jonas Hahnfeld
Date: 2023-10-05T12:09:14+02:00
New Revision: abb9eb2778dc68ca3bc2ca786632e65682741469
URL:
https://github.com/llvm/llvm-project/commit/abb9eb2778dc68ca3bc2ca786632e65682741469
DIFF:
https://github.com/llvm/llvm-project/commit/abb9eb2778dc68ca3bc2ca786632e65682741469.diff
This revision was automatically updated to reflect the committed changes.
Closed by commit rGabb9eb2778dc: [Lex] Handle repl_input_end in
Preprocessor::LexTokensUntilEOF() (authored by Hahnfeld).
Changed prior to commit:
https://reviews.llvm.org/D158415?vs=556849&id=557607#toc
Repository:
rG
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 3a35ca01fc55f27315d1652ec1dedff10e79918b
8042b2232c45a93418bab17eff78a38b527fcb95 --
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 3a35ca01fc55f27315d1652ec1dedff10e79918b
fc484770303cf50819e09dafd0f4f00760e67e3c --
ilg-ul wrote:
The Linux tests were fine, but the Windows tests failed in
`Interpreter/const.cpp`, which does not seem to be related to my patch.
https://github.com/llvm/llvm-project/pull/68091
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 3a35ca01fc55f27315d1652ec1dedff10e79918b
8281ab66e5315f5b8b4290894c8b9229bd6518d2 --
https://github.com/Rin18 updated https://github.com/llvm/llvm-project/pull/67697
>From 1bf78c81c678de436795a07c0b62037f782aa53f Mon Sep 17 00:00:00 2001
From: Rin Dobrescu
Date: Mon, 25 Sep 2023 11:34:15 +
Subject: [PATCH 1/4] [AArch64][LoopVectorize] Use either fixed-width or
scalable VF w
https://github.com/Rin18 updated https://github.com/llvm/llvm-project/pull/67697
>From 1bf78c81c678de436795a07c0b62037f782aa53f Mon Sep 17 00:00:00 2001
From: Rin Dobrescu
Date: Mon, 25 Sep 2023 11:34:15 +
Subject: [PATCH 1/4] [AArch64][LoopVectorize] Use either fixed-width or
scalable VF w
https://github.com/4vtomat updated
https://github.com/llvm/llvm-project/pull/68296
>From fc484770303cf50819e09dafd0f4f00760e67e3c Mon Sep 17 00:00:00 2001
From: Brandon Wu
Date: Wed, 4 Oct 2023 10:23:52 -0700
Subject: [PATCH 1/2] [RISCV] Support Xsfvfwmaccqqq extensions
Bfloat16 Matrix Multipl
llvmbot wrote:
@llvm/pr-subscribers-mlir-presburger
Changes
We modify `Fraction.reduce()` to work with negative fractions as well.
We add tests to verify the implementation of arithmetic and relational
operators on Fractions.
---
Full diff: https://github.com/llvm/llvm-project/pull/68298.
llvmbot wrote:
@llvm/pr-subscribers-mlir-presburger
Changes
We modify `Fraction.reduce()` to work with negative fractions as well.
We add tests to verify the implementation of arithmetic and relational
operators on Fractions.
---
Full diff: https://github.com/llvm/llvm-project/pull/68298.
https://github.com/Rin18 edited https://github.com/llvm/llvm-project/pull/67697
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
4vtomat wrote:
ping
https://github.com/llvm/llvm-project/pull/66860
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Groverkss requested changes to this pull request.
Please remove the libcxx changes
https://github.com/llvm/llvm-project/pull/68298
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
https://github.com/Groverkss requested changes to this pull request.
Please remove the libcxx changes
https://github.com/llvm/llvm-project/pull/68298
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
jayfoad wrote:
> > > I've just tested this on 1 graphics shaders and it seems to make no
> > > difference at all. I tried gfx900 and gfx1100. Can anyone else from the
> > > graphics team confirm this?
> >
> >
> > I can confirm no difference on gfx1102
>
> gfx11 is the same as gfx10, it j
d-smirnov updated this revision to Diff 557609.
d-smirnov added a comment.
Updated
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155688/new/
https://reviews.llvm.org/D155688
Files:
clang/test/CodeGenCXX/microsoft-abi-dynamic-cast.cpp
llvm/lib/
d-smirnov marked an inline comment as done.
d-smirnov added a comment.
Updated
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155688/new/
https://reviews.llvm.org/D155688
___
cfe-commits mailing list
cfe-
https://github.com/kiranchandramohan edited
https://github.com/llvm/llvm-project/pull/67723
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -5748,6 +5758,7 @@ OpenMPIRBuilder::createTeams(const LocationDescription
&Loc,
BasicBlock *BodyBB = splitBB(Builder, /*CreateBranch=*/true,
"teams.entry");
Builder.SetInsertPoint(BodyBB, BodyBB->begin());
}
+ InsertPointTy OuterAllocaIP(&OuterAllocaBB, OuterAll
@@ -5748,6 +5758,7 @@ OpenMPIRBuilder::createTeams(const LocationDescription
&Loc,
BasicBlock *BodyBB = splitBB(Builder, /*CreateBranch=*/true,
"teams.entry");
Builder.SetInsertPoint(BodyBB, BodyBB->begin());
}
+ InsertPointTy OuterAllocaIP(&OuterAllocaBB, OuterAll
@@ -340,6 +340,44 @@ BasicBlock *llvm::splitBBWithSuffix(IRBuilderBase
&Builder, bool CreateBranch,
return splitBB(Builder, CreateBranch, Old->getName() + Suffix);
}
+// This function creates a fake integer value and a fake use for the integer
+// value. It returns the fake
@@ -340,6 +340,44 @@ BasicBlock *llvm::splitBBWithSuffix(IRBuilderBase
&Builder, bool CreateBranch,
return splitBB(Builder, CreateBranch, Old->getName() + Suffix);
}
+// This function creates a fake integer value and a fake use for the integer
+// value. It returns the fake
https://github.com/kiranchandramohan commented:
Could you expand the summary to describe the changes.
What are the changes required to remove the wrapper function (Why was it
required in the first place?)
Why are the fake vals necessary?
https://github.com/llvm/llvm-project/pull/67723
https://github.com/kiranchandramohan edited
https://github.com/llvm/llvm-project/pull/67723
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -340,6 +340,44 @@ BasicBlock *llvm::splitBBWithSuffix(IRBuilderBase
&Builder, bool CreateBranch,
return splitBB(Builder, CreateBranch, Old->getName() + Suffix);
}
+// This function creates a fake integer value and a fake use for the integer
+// value. It returns the fake
@@ -5748,6 +5758,7 @@ OpenMPIRBuilder::createTeams(const LocationDescription
&Loc,
BasicBlock *BodyBB = splitBB(Builder, /*CreateBranch=*/true,
"teams.entry");
Builder.SetInsertPoint(BodyBB, BodyBB->begin());
}
+ InsertPointTy OuterAllocaIP(&OuterAllocaBB, OuterAll
@@ -340,6 +340,44 @@ BasicBlock *llvm::splitBBWithSuffix(IRBuilderBase
&Builder, bool CreateBranch,
return splitBB(Builder, CreateBranch, Old->getName() + Suffix);
}
+// This function creates a fake integer value and a fake use for the integer
+// value. It returns the fake
@@ -340,6 +340,44 @@ BasicBlock *llvm::splitBBWithSuffix(IRBuilderBase
&Builder, bool CreateBranch,
return splitBB(Builder, CreateBranch, Old->getName() + Suffix);
}
+// This function creates a fake integer value and a fake use for the integer
+// value. It returns the fake
https://github.com/kiranchandramohan edited
https://github.com/llvm/llvm-project/pull/67723
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jayfoad wrote:
I've taken another look at this. The patch does not show any benefit from
running another `SIFoldOperands` pass _after_ `SIShrinkInstructions` per se;
you get exactly the same results (modulo a couple of add instructions that have
their operands commuted differently) if you put
jayfoad wrote:
I've taken another look at this. The patch does not show any benefit from
running another `SIFoldOperands` pass _after_ `SIShrinkInstructions` per se;
you get exactly the same results (modulo a couple of add instructions that have
their operands commuted differently) if you put
@@ -179,12 +183,14 @@ void IncludeCleanerCheck::check(const
MatchFinder::MatchResult &Result) {
if (getCurrentMainFile().endswith(PHeader))
continue;
}
-
-if (llvm::none_of(
-IgnoreHeadersRegex,
-[Resolved = (*I.Resolved).getFileEn
https://github.com/kadircet updated
https://github.com/llvm/llvm-project/pull/68185
From 91ce80c89689518c20f18efd172628a51aebb769 Mon Sep 17 00:00:00 2001
From: Kadir Cetinkaya
Date: Wed, 4 Oct 2023 09:38:28 +0200
Subject: [PATCH 1/3] [clang-tidy][IncludeCleaner] Fix analysis supression in
pre
kadircet wrote:
> Overall looks fine, but please update release notes for this (update current
> entry or even merge them together instead of adding new one). And make sure
> that there is a commit description for this change when committing, instead
> of just having only a title.
done.
http
jmorse added a comment.
The code changes here look good, but it's time to be annoying about the tests
-- most of them appear to run the optimisation pipelines, which is testing all
of LLVM as well as clang in these tests. Possibly a simple fix to that is to
put these in cross-project-tests. Oth
dtcxzyw wrote:
Ping.
https://github.com/llvm/llvm-project/pull/65852
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dtcxzyw wrote:
Ping.
https://github.com/llvm/llvm-project/pull/65852
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -10517,41 +10598,19 @@ bool VectorExprEvaluator::VisitCastExpr(const
CastExpr *E) {
return Success(Elts, E);
}
case CK_BitCast: {
-// Evaluate the operand into an APInt we can extract from.
-llvm::APInt SValInt;
-if (!EvalAndBitcastToAPInt(Info, SE, SVal
AaronBallman wrote:
Added @plotfi as a reviewer; one drive-by question is whether adding a new LLVM
tool like this requires an RFC to be posted to Discourse or not
(https://llvm.org/docs/DeveloperPolicy.html#introducing-new-components-into-llvm).
(I don't have any opinions on the tool; just tr
@@ -7441,6 +7500,28 @@ static bool handleLValueToRValueBitCast(EvalInfo &Info,
APValue &DestValue,
return true;
}
+static bool handleLValueToRValueBitCast(EvalInfo &Info, APValue &DestValue,
+APValue &SourceValue,
+
https://github.com/stepthomas updated
https://github.com/llvm/llvm-project/pull/68197
>From ed42bb63a3fe4a840071b74a3f9613dda815aa29 Mon Sep 17 00:00:00 2001
From: Stephen Thomas
Date: Wed, 4 Oct 2023 10:16:49 +0100
Subject: [PATCH] [AMDGPU] Add encoding/decoding support for
non-result-returni
https://github.com/dtcxzyw updated
https://github.com/llvm/llvm-project/pull/67915
>From c4ce28c942c172e5646b5922f0b02b4169197840 Mon Sep 17 00:00:00 2001
From: Yingwei Zheng
Date: Sun, 1 Oct 2023 21:52:47 +0800
Subject: [PATCH] [InstCombine] Canonicalize `(X +/- Y) & Y` into `~X & Y` when
Y i
Author: Guillot Tony
Date: 2023-10-05T08:11:02-04:00
New Revision: 5d78b78c853830516e734cfa64bfba70479e35dc
URL:
https://github.com/llvm/llvm-project/commit/5d78b78c853830516e734cfa64bfba70479e35dc
DIFF:
https://github.com/llvm/llvm-project/commit/5d78b78c853830516e734cfa64bfba70479e35dc.diff
This revision was automatically updated to reflect the committed changes.
Closed by commit rG5d78b78c8538: [C2X] N3007 Type inference for object
definitions (authored by to268, committed by aaron.ballman).
Changed prior to commit:
https://reviews.llvm.org/D133289?vs=557115&id=557610#toc
Reposi
https://github.com/ilg-ul edited https://github.com/llvm/llvm-project/pull/68091
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilg-ul edited https://github.com/llvm/llvm-project/pull/68091
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vabridgers updated
https://github.com/llvm/llvm-project/pull/68276
>From 5e95a4318434e0e72fe37ebfb286405d40ff7a73 Mon Sep 17 00:00:00 2001
From: Vince Bridgers
Date: Thu, 5 Oct 2023 02:39:12 +0200
Subject: [PATCH] [Sema] Add check for bitfield assignments to integral types
W
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/68264
>From 52d11d0d975f03a3cd2760b42236b5ec8097331b Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Wed, 4 Oct 2023 16:50:20 -0500
Subject: [PATCH 1/2] [OpenMP] Prevent AMDGPU from overriding visibility on
DT_nohos
jhuber6 wrote:
> This stuff looks very cuda/opencl specific. It's definitely surprising for
> C++ code. Do we need it for openmp? If not it seems better to guard the hack
> with visibility behind if (hip)
You reminded me that I need to refine this logic as well. What it's doing here
is basica
@@ -1,5 +1,5 @@
// RUN: %clang_cc1 -debug-info-kind=limited -verify -fopenmp -x c++ -triple
nvptx64-unknown-unknown -fopenmp-targets=nvptx64-nvidia-cuda -emit-llvm %s
-fopenmp-is-target-device -o - | FileCheck %s
-// RUN: %clang_cc1 -debug-info-kind=limited -verify -fopenmp -x
https://github.com/egorzhdan approved this pull request.
The Darwin toolchain also does this. This change LGTM, although I'm not an
expert in FreeBSD.
https://github.com/llvm/llvm-project/pull/68011
___
cfe-commits mailing list
cfe-commits@lists.llvm.
Author: Aaron Ballman
Date: 2023-10-05T08:52:12-04:00
New Revision: dc1000d5b24cfad2b0429b55f034488397d809dc
URL:
https://github.com/llvm/llvm-project/commit/dc1000d5b24cfad2b0429b55f034488397d809dc
DIFF:
https://github.com/llvm/llvm-project/commit/dc1000d5b24cfad2b0429b55f034488397d809dc.diff
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 5099dc341f7fa9baec160c2991072eb445469d46
0be9c9fc769eb580a602ce075d8904d683c3596b --
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/68264
>From 52d11d0d975f03a3cd2760b42236b5ec8097331b Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Wed, 4 Oct 2023 16:50:20 -0500
Subject: [PATCH 1/2] [OpenMP] Prevent AMDGPU from overriding visibility on
DT_nohos
zahiraam wrote:
> struct S { int x; };
> namespace NS {
> class C {};
> }
>
> S foo(S s1, NS::C c1) {
> S s12{12};
> using namespace NS;
> C c;
> }
@AaronBallman By pretty printed you mean the use of __PRETTY_FUNCTION__ right?
In MSVC this macro is not defined. The equivalent one is FUNCS
1 - 100 of 371 matches
Mail list logo
