[clang] [clang-format] Fix alignment in presence of template functions (PR #68029)

HazardyKnusperkeks wrote: > Can you add an issue to show the incorrect format before this patch? Done. https://github.com/llvm/llvm-project/pull/68029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[clang] 1f01269 - [clang-format] Fix alignment in presence of template functions (#68029)

Author: Björn Schäpers Date: 2023-10-03T15:35:30+02:00 New Revision: 1f0126902876cb42a7502047e62bdf512fd96b02 URL: https://github.com/llvm/llvm-project/commit/1f0126902876cb42a7502047e62bdf512fd96b02 DIFF: https://github.com/llvm/llvm-project/commit/1f0126902876cb42a7502047e62bdf512fd96b02.diff

[clang] [clang-format] Fix alignment in presence of template functions (PR #68029)

https://github.com/HazardyKnusperkeks closed https://github.com/llvm/llvm-project/pull/68029 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64][FMV] Add rcpc3 support, introduce bits for features extensi… (PR #68104)

https://github.com/ilinpv created https://github.com/llvm/llvm-project/pull/68104 …on and initialization. The patch implements FEAT_LRCPC3 support (Load-Acquire RCpc instructions version 3) in Function Multi Versioning. To maintain compatibility while features list grows extension bit FEAT_EX

[clang] [clang][driver] Use platform specific calls to get the executable absolute path (PR #68091)

@@ -331,6 +340,56 @@ static void SetInstallDir(SmallVectorImpl &argv, // path being a symlink. SmallString<128> InstalledPath(argv[0]); +#if defined(__linux__) AaronBallman wrote: Can we use [`getMainExecutable()`](https://github.com/llvm/llvm-project/b

[clang] [AArch64][FMV] Add rcpc3 support, introduce bits for features extensi… (PR #68104)

llvmbot wrote: @llvm/pr-subscribers-clang Changes …on and initialization. The patch implements FEAT_LRCPC3 support (Load-Acquire RCpc instructions version 3) in Function Multi Versioning. To maintain compatibility while features list grows extension bit FEAT_EXT and initialization bit FE

[clang-tools-extra] [IPSCCP] Variable not visible at Og: (PR #66745)

https://github.com/CarlosAlbertoEnciso updated https://github.com/llvm/llvm-project/pull/66745 >From b24943f63025822a5c5ba90c4a7b47f7123ec4db Mon Sep 17 00:00:00 2001 From: Carlos Alberto Enciso Date: Mon, 18 Sep 2023 12:29:17 +0100 Subject: [PATCH] [IPSCCP] Variable not visible at Og: https:/

[clang] [IPSCCP] Variable not visible at Og: (PR #66745)

https://github.com/jryans edited https://github.com/llvm/llvm-project/pull/66745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [IPSCCP] Variable not visible at Og: (PR #66745)

https://github.com/jryans edited https://github.com/llvm/llvm-project/pull/66745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [IPSCCP] Variable not visible at Og: (PR #66745)

https://github.com/CarlosAlbertoEnciso updated https://github.com/llvm/llvm-project/pull/66745 >From b24943f63025822a5c5ba90c4a7b47f7123ec4db Mon Sep 17 00:00:00 2001 From: Carlos Alberto Enciso Date: Mon, 18 Sep 2023 12:29:17 +0100 Subject: [PATCH] [IPSCCP] Variable not visible at Og: https:/

[clang-tools-extra] [IPSCCP] Variable not visible at Og: (PR #66745)

@@ -371,6 +372,52 @@ static bool runIPSCCP( StoreInst *SI = cast(GV->user_back()); SI->eraseFromParent(); } + +// Try to create a debug constant expression for the glbal variable +// initializer value. CarlosAlbertoEnciso wrote: Moving

[clang] [IPSCCP] Variable not visible at Og: (PR #66745)

@@ -371,6 +372,52 @@ static bool runIPSCCP( StoreInst *SI = cast(GV->user_back()); SI->eraseFromParent(); } + +// Try to create a debug constant expression for the glbal variable +// initializer value. CarlosAlbertoEnciso wrote: Moving

[clang] [flang][Driver] Support -rpath, -shared, and -static in the frontend (PR #66702)

tarunprabhu wrote: Thanks @DavidTruby. For this particular patch, the main concern is how the compiler flags are mapped to the corresponding linker flags on Windows. All of that work is done by clang, and I haven't touched any of it so I am not worried about correctness. The two main conce

[clang] [IPSCCP] Variable not visible at Og: (PR #66745)

@@ -371,6 +372,52 @@ static bool runIPSCCP( StoreInst *SI = cast(GV->user_back()); SI->eraseFromParent(); } + +// Try to create a debug constant expression for the glbal variable +// initializer value. +SmallVector GVEs; +GV->getDebugInfo(GVEs);

[clang-tools-extra] [IPSCCP] Variable not visible at Og: (PR #66745)

@@ -371,6 +372,52 @@ static bool runIPSCCP( StoreInst *SI = cast(GV->user_back()); SI->eraseFromParent(); } + +// Try to create a debug constant expression for the glbal variable +// initializer value. +SmallVector GVEs; +GV->getDebugInfo(GVEs);

[clang] [IPSCCP] Variable not visible at Og: (PR #66745)

@@ -371,6 +372,52 @@ static bool runIPSCCP( StoreInst *SI = cast(GV->user_back()); SI->eraseFromParent(); } + +// Try to create a debug constant expression for the glbal variable +// initializer value. +SmallVector GVEs; +GV->getDebugInfo(GVEs);

[clang-tools-extra] [IPSCCP] Variable not visible at Og: (PR #66745)

@@ -371,6 +372,52 @@ static bool runIPSCCP( StoreInst *SI = cast(GV->user_back()); SI->eraseFromParent(); } + +// Try to create a debug constant expression for the glbal variable +// initializer value. +SmallVector GVEs; +GV->getDebugInfo(GVEs);

[clang-tools-extra] [IPSCCP] Variable not visible at Og: (PR #66745)

@@ -371,6 +372,52 @@ static bool runIPSCCP( StoreInst *SI = cast(GV->user_back()); SI->eraseFromParent(); } + +// Try to create a debug constant expression for the glbal variable +// initializer value. +SmallVector GVEs; +GV->getDebugInfo(GVEs);

[clang] [IPSCCP] Variable not visible at Og: (PR #66745)

@@ -371,6 +372,52 @@ static bool runIPSCCP( StoreInst *SI = cast(GV->user_back()); SI->eraseFromParent(); } + +// Try to create a debug constant expression for the glbal variable +// initializer value. +SmallVector GVEs; +GV->getDebugInfo(GVEs);

[clang] [IPSCCP] Variable not visible at Og: (PR #66745)

@@ -371,6 +372,52 @@ static bool runIPSCCP( StoreInst *SI = cast(GV->user_back()); SI->eraseFromParent(); } + +// Try to create a debug constant expression for the glbal variable +// initializer value. +SmallVector GVEs; +GV->getDebugInfo(GVEs);

[clang-tools-extra] [IPSCCP] Variable not visible at Og: (PR #66745)

@@ -371,6 +372,52 @@ static bool runIPSCCP( StoreInst *SI = cast(GV->user_back()); SI->eraseFromParent(); } + +// Try to create a debug constant expression for the glbal variable +// initializer value. +SmallVector GVEs; +GV->getDebugInfo(GVEs);

[clang] [IPSCCP] Variable not visible at Og: (PR #66745)

@@ -371,6 +372,52 @@ static bool runIPSCCP( StoreInst *SI = cast(GV->user_back()); SI->eraseFromParent(); } + +// Try to create a debug constant expression for the glbal variable +// initializer value. +SmallVector GVEs; +GV->getDebugInfo(GVEs);

[clang-tools-extra] [IPSCCP] Variable not visible at Og: (PR #66745)

@@ -371,6 +372,52 @@ static bool runIPSCCP( StoreInst *SI = cast(GV->user_back()); SI->eraseFromParent(); } + +// Try to create a debug constant expression for the glbal variable +// initializer value. +SmallVector GVEs; +GV->getDebugInfo(GVEs);

[clang] Complex div (PR #68106)

https://github.com/zahiraam created https://github.com/llvm/llvm-project/pull/68106 None >From 2e06d07abe22526188c71c6e00ca9037620c9259 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Tue, 3 Oct 2023 05:43:48 -0700 Subject: [PATCH 1/2] Testing. --- clang/lib/AST/Expr.cpp | 2 +- 1 file cha

[clang] Complex div (PR #68106)

https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/68106 >From 2e06d07abe22526188c71c6e00ca9037620c9259 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Tue, 3 Oct 2023 05:43:48 -0700 Subject: [PATCH 1/3] Testing. --- clang/lib/AST/Expr.cpp | 2 +- 1 file changed,

[clang] Complex div (PR #68106)

https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/68106 >From 2e06d07abe22526188c71c6e00ca9037620c9259 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Tue, 3 Oct 2023 05:43:48 -0700 Subject: [PATCH 1/4] Testing. --- clang/lib/AST/Expr.cpp | 2 +- 1 file changed,

[clang] Complex div (PR #68106)

https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/68106 >From 2e06d07abe22526188c71c6e00ca9037620c9259 Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Tue, 3 Oct 2023 05:43:48 -0700 Subject: [PATCH 1/5] Testing. --- clang/lib/AST/Expr.cpp | 2 +- 1 file changed,

[PATCH] D156565: Diagnose use of VLAs in C++ by default

aaron.ballman marked an inline comment as done. aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:147-149 +def ext_vla_cxx_static_assert : ExtWarn< + "variable length arrays in C++ are a Clang extension; did you mean to use " + "'

[clang] Complex div (PR #68106)

https://github.com/zahiraam closed https://github.com/llvm/llvm-project/pull/68106 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Inliner] Improve propagation of return attributes. (PR #67756)

nikic wrote: It looks like x86-bswap.c still has the C++ guarded code in it. Any thoughts on > Though I think we might be better off passing `-no-enable-noundef-analysis` > to these tests, as noundef is really not what they want to test. to avoid the test duplication? https://github.com/llvm

[clang] [clang] Implement constexpr bit_cast for vectors (PR #66894)

https://github.com/DaMatrix updated https://github.com/llvm/llvm-project/pull/66894 >From f24c57fdd4e9cd3208c661d2f716c0251cff1c5e Mon Sep 17 00:00:00 2001 From: DaPorkchop_ Date: Sun, 13 Aug 2023 22:39:12 +0200 Subject: [PATCH] [clang] Implement constexpr bit_cast for vectors --- .../include

[clang] Extension: allow recursive macros (PR #65851)

https://github.com/kelbon updated https://github.com/llvm/llvm-project/pull/65851 >From d10ce5dd9e49fe85eac2e1f93a65cb27b511a71f Mon Sep 17 00:00:00 2001 From: Kelbon Nik Date: Sat, 9 Sep 2023 17:51:15 +0400 Subject: [PATCH 01/18] add define2 pp directive --- clang/include/clang/Basic/TokenKi

[clang] [clang][driver] Use platform specific calls to get the executable absolute path (PR #68091)

@@ -331,6 +340,56 @@ static void SetInstallDir(SmallVectorImpl &argv, // path being a symlink. SmallString<128> InstalledPath(argv[0]); +#if defined(__linux__) bjope wrote: I was kind of thinking the same. And then started to wonder about why SetInstall

[clang] [clang][driver] Use platform specific calls to get the executable absolute path (PR #68091)

https://github.com/bjope edited https://github.com/llvm/llvm-project/pull/68091 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Update Zfa extension version to 1.0 (PR #67964)

https://github.com/asb updated https://github.com/llvm/llvm-project/pull/67964 >From 79ab61e07a01e503f22e717c4b0e64b7741c59a0 Mon Sep 17 00:00:00 2001 From: Alex Bradbury Date: Mon, 2 Oct 2023 11:06:44 +0100 Subject: [PATCH 1/3] [RISCV] Update Zfa extension version to 1.0 The Zfa specification

[clang] 8092933 - [RISCV][AArch64] Don't allow -mvscale-min/max options to be passed to the clang driver. (#68065)

Author: Craig Topper Date: 2023-10-03T07:26:08-07:00 New Revision: 8092933246507a7b6c4385afbf0b9750a6d00de9 URL: https://github.com/llvm/llvm-project/commit/8092933246507a7b6c4385afbf0b9750a6d00de9 DIFF: https://github.com/llvm/llvm-project/commit/8092933246507a7b6c4385afbf0b9750a6d00de9.diff

[clang] [RISCV][AArch64] Don't allow -mvscale-min/max options to be passed to the clang driver. (PR #68065)

https://github.com/topperc closed https://github.com/llvm/llvm-project/pull/68065 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Avoid need for SLocEntryLoaded BitVector (PR #67960)

https://github.com/kuhar commented: The ADT change looks good to me, I'm not familiar with the clang code though. https://github.com/llvm/llvm-project/pull/67960 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[PATCH] D133361: [BPF] Attribute preserve_static_offset for structs

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. 2 nits on the CFE, else LGTM! Obviously you still need an LLVM reviewer for the backend changes. Comment at: clang/lib/CodeGen/CGExpr.cpp:3701 + QualType PointeeTy

[clang] [diag] Silence `-Wfixed-enum-extension` in C23 (PR #68060)

@@ -5019,7 +5019,7 @@ void Parser::ParseEnumSpecifier(SourceLocation StartLoc, DeclSpec &DS, else if (getLangOpts().MicrosoftExt) Diag(ColonLoc, diag::ext_ms_c_enum_fixed_underlying_type) << BaseRange; -else +else if (!getLangOpt

[clang] [RISCV] Update Zfa extension version to 1.0 (PR #67964)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff b1295dd5c923c6828775406b4063de1531fd4782 f21c479811de5cb476ef8d2abe0265b1bf8ea24f --

[clang] Avoid need for SLocEntryLoaded BitVector (PR #67960)

@@ -474,9 +474,10 @@ static_assert(sizeof(FileInfo) <= sizeof(ExpansionInfo), /// SourceManager keeps an array of these objects, and they are uniquely /// identified by the FileID datatype. class SLocEntry { - static constexpr int OffsetBits = 8 * sizeof(SourceLocation::UIntTy

[clang] Avoid need for SLocEntryLoaded BitVector (PR #67960)

@@ -489,6 +490,8 @@ class SLocEntry { bool isExpansion() const { return IsExpansion; } bool isFile() const { return !isExpansion(); } + bool isLoaded() const { return Loaded; } + void setLoaded(bool Value) { Loaded = Value; } vgvassilev wrote: ```sugges

[PATCH] D156565: Diagnose use of VLAs in C++ by default

tahonermann added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:147-149 +def ext_vla_cxx_static_assert : ExtWarn< + "variable length arrays in C++ are a Clang extension; did you mean to use " + "'static_assert'?">, InGroup; aaron

[clang] Avoid need for SLocEntryLoaded BitVector (PR #67960)

https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/67960 >From 9fde224de6baa5b1fb3713d810ce835d4456b457 Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Fri, 29 Sep 2023 08:37:57 +0200 Subject: [PATCH 1/8] Avoid need for SLocEntryLoade

[clang] Avoid need for SLocEntryLoaded BitVector (PR #67960)

https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/67960 >From 9fde224de6baa5b1fb3713d810ce835d4456b457 Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Fri, 29 Sep 2023 08:37:57 +0200 Subject: [PATCH 1/9] Avoid need for SLocEntryLoade

[clang-tools-extra] Bugfix for chosing the correct deduction guide (PR #66487)

erichkeane wrote: > The paper where this came from is: https://wg21.link/P0620R0. most of this > paper was already implemented. Where is the paper tracking doc I need to > update? https://clang.llvm.org/cxx_status.html claims this paper is > implemented. Sorry if the following questions are tr

[clang] Bugfix for chosing the correct deduction guide (PR #66487)

erichkeane wrote: > The paper where this came from is: https://wg21.link/P0620R0. most of this > paper was already implemented. Where is the paper tracking doc I need to > update? https://clang.llvm.org/cxx_status.html claims this paper is > implemented. Sorry if the following questions are tr

[clang] 06a05f3 - [NFC] remove duplicate ModuleId alias (#67899)

Author: David Stone Date: 2023-10-03T22:43:51+08:00 New Revision: 06a05f334698c10a60459d30b4074fabedf72c48 URL: https://github.com/llvm/llvm-project/commit/06a05f334698c10a60459d30b4074fabedf72c48 DIFF: https://github.com/llvm/llvm-project/commit/06a05f334698c10a60459d30b4074fabedf72c48.diff L

[clang] remove duplicate ModuleId alias (PR #67899)

https://github.com/ChuanqiXu9 closed https://github.com/llvm/llvm-project/pull/67899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix constant evaluating a captured variable in a lambda (PR #68090)

shafik wrote: Can you write a more detailed description explaining what the problem is what the fix is. This is what usually ends up in the git log and we want that to be as descriptive as possible for folks who use it to understand changes quickly without digging into details. https://githu

[libunwind] [AMDGPU] Add another SIFoldOperands instance after shrink (PR #67878)

jayfoad wrote: I've just tested this on 1 graphics shaders and it seems to make no difference at all. I tried gfx900 and gfx1100. Can anyone else from the graphics team confirm this? https://github.com/llvm/llvm-project/pull/67878 ___ cfe-commits

[clang] [AMDGPU] Add another SIFoldOperands instance after shrink (PR #67878)

jayfoad wrote: I've just tested this on 1 graphics shaders and it seems to make no difference at all. I tried gfx900 and gfx1100. Can anyone else from the graphics team confirm this? https://github.com/llvm/llvm-project/pull/67878 ___ cfe-commits

[clang] [RISCV] Update Zfa extension version to 1.0 (PR #67964)

asb wrote: > ⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️ This is a whitespace change > 20 lines away from the edit made in the test file, so I don't believe it's appropriate to reformat in this PR. https://github.com/llvm/llvm-project/pull/67964

[clang] [RISCV] Mark the Zfa extension as non-experimental (PR #68113)

https://github.com/asb created https://github.com/llvm/llvm-project/pull/68113 Following the version bump in #67964 and the bug fix in #68026 I believe we're ready to mark Zfa as non-experimental. I'll note the GCC torture suite passes now with Zfa enabled (though it's more of a litmus test tha

[clang] [RISCV] Mark the Zfa extension as non-experimental (PR #68113)

llvmbot wrote: @llvm/pr-subscribers-clang-driver Changes Following the version bump in #67964 and the bug fix in #68026 I believe we're ready to mark Zfa as non-experimental. I'll note the GCC torture suite passes now with Zfa enabled (though it's more of a litmus test than anything else

[clang] [Clang] Fix constant evaluating a captured variable in a lambda (PR #68090)

@@ -8367,7 +8367,13 @@ bool LValueExprEvaluator::VisitVarDecl(const Expr *E, const VarDecl *VD) { if (auto *FD = Info.CurrentCall->LambdaCaptureFields.lookup(VD)) { // Start with 'Result' referring to the complete closure object... - Result = *Info.CurrentCall-

[clang] [Clang] Fix constant evaluating a captured variable in a lambda (PR #68090)

https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/68090 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [diag] Silence `-Wfixed-enum-extension` in C23 (PR #68060)

https://github.com/smeenai updated https://github.com/llvm/llvm-project/pull/68060 >From b931e047168d2312f05c0fbf2813915cc4e06ae8 Mon Sep 17 00:00:00 2001 From: Shoaib Meenai Date: Mon, 2 Oct 2023 17:50:36 -0700 Subject: [PATCH 1/2] [diag] Silence `-Wfixed-enum-extension` in C23 The C23 standa

[clang] [diag] Silence `-Wfixed-enum-extension` in C23 (PR #68060)

@@ -5019,7 +5019,7 @@ void Parser::ParseEnumSpecifier(SourceLocation StartLoc, DeclSpec &DS, else if (getLangOpts().MicrosoftExt) Diag(ColonLoc, diag::ext_ms_c_enum_fixed_underlying_type) << BaseRange; -else +else if (!getLangOpt

[clang] [diag] Silence `-Wfixed-enum-extension` in C23 (PR #68060)

https://github.com/erichkeane commented: I believe this needs a release note as well (see docs/ReleaseNotes.rst), else this LGTM. https://github.com/llvm/llvm-project/pull/68060 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[clang] [RISCV] Mark the Zfa extension as non-experimental (PR #68113)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 06a05f334698c10a60459d30b4074fabedf72c48 83e868a92647efb783e43db48705b0db63188d84 --

[clang] [AMDGPU] Add another SIFoldOperands instance after shrink (PR #67878)

Sisyph wrote: > I've just tested this on 1 graphics shaders and it seems to make no > difference at all. I tried gfx900 and gfx1100. Can anyone else from the > graphics team confirm this? I can confirm no difference on gfx1102 https://github.com/llvm/llvm-project/pull/67878 __

[clang] [clang] use absolute path for builtin headers during module compilation (PR #68023)

https://github.com/rmaz updated https://github.com/llvm/llvm-project/pull/68023 >From 3617539eecb4bfcb9f2a20a1ae1cff71b298 Mon Sep 17 00:00:00 2001 From: Richard Howell Date: Mon, 2 Oct 2023 11:10:52 -0700 Subject: [PATCH] [clang] use absolute path for builtin headers during module compilat

[libunwind] [AMDGPU] Add another SIFoldOperands instance after shrink (PR #67878)

Sisyph wrote: > I've just tested this on 1 graphics shaders and it seems to make no > difference at all. I tried gfx900 and gfx1100. Can anyone else from the > graphics team confirm this? I can confirm no difference on gfx1102 https://github.com/llvm/llvm-project/pull/67878 __

[clang] [Clang] Fix constant evaluating a captured variable in a lambda (PR #68090)

@@ -8367,7 +8367,13 @@ bool LValueExprEvaluator::VisitVarDecl(const Expr *E, const VarDecl *VD) { if (auto *FD = Info.CurrentCall->LambdaCaptureFields.lookup(VD)) { // Start with 'Result' referring to the complete closure object... - Result = *Info.CurrentCall-

[clang] [diag] Silence `-Wfixed-enum-extension` in C23 (PR #68060)

https://github.com/smeenai updated https://github.com/llvm/llvm-project/pull/68060 >From b931e047168d2312f05c0fbf2813915cc4e06ae8 Mon Sep 17 00:00:00 2001 From: Shoaib Meenai Date: Mon, 2 Oct 2023 17:50:36 -0700 Subject: [PATCH 1/3] [diag] Silence `-Wfixed-enum-extension` in C23 The C23 standa

[clang] [diag] Silence `-Wfixed-enum-extension` in C23 (PR #68060)

@@ -216,6 +216,9 @@ Improvements to Clang's diagnostics - The fix-it emitted by ``-Wformat`` for scoped enumerations now take the enumeration's underlying type into account instead of suggesting a type just based on the format string specifier being used. +- ``-Wfixed-enum-

[clang] [diag] Silence `-Wfixed-enum-extension` in C23 (PR #68060)

https://github.com/smeenai updated https://github.com/llvm/llvm-project/pull/68060 >From b931e047168d2312f05c0fbf2813915cc4e06ae8 Mon Sep 17 00:00:00 2001 From: Shoaib Meenai Date: Mon, 2 Oct 2023 17:50:36 -0700 Subject: [PATCH 1/4] [diag] Silence `-Wfixed-enum-extension` in C23 The C23 standa

[clang] [diag] Silence `-Wfixed-enum-extension` in C23 (PR #68060)

https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/68060 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [SystemZ][z/OS] Implement executePostLayoutBinding for GOFFObjectWriter (PR #67868)

https://github.com/Everybody0523 updated https://github.com/llvm/llvm-project/pull/67868 >From 80073957d9adf8d107515d49a741df2b2130f82d Mon Sep 17 00:00:00 2001 From: Neumann Hon Date: Fri, 29 Sep 2023 19:52:27 -0400 Subject: [PATCH] [SystemZ][z/OS] Implement executePostLayoutBinding for GOFFO

[PATCH] D155775: [HIP][Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload

thakis added a comment. This seems to break tests on Mac and windows, see eg http://45.33.8.238/macm1/70415/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155775/new/ htt

[PATCH] D155775: [HIP][Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload

thakis added a comment. Windows: http://45.33.8.238/win/84498/step_7.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155775/new/ https://reviews.llvm.org/D155775 ___ cfe-commits mailing list cfe-commit

[clang] [clang][Modules] Make `Module::Requirement` a struct (PR #67900)

https://github.com/davidstone updated https://github.com/llvm/llvm-project/pull/67900 >From b5e64ac8d36fef66cb8ef698f74997616d2957bc Mon Sep 17 00:00:00 2001 From: David Stone Date: Sat, 30 Sep 2023 22:57:34 -0600 Subject: [PATCH 1/2] [clang][Modules] Make `Module::Requirement` a struct `Modul

[clang] Bugfix for chosing the correct deduction guide (PR #66487)

https://github.com/HoBoIs updated https://github.com/llvm/llvm-project/pull/66487 From 258462cc65403af147bb47cbeb95210df8e18cd3 Mon Sep 17 00:00:00 2001 From: hobois Date: Fri, 15 Sep 2023 09:28:21 +0200 Subject: [PATCH 1/2] Choose the correct deduction guide If there are two guides, one of th

[PATCH] D155775: [HIP][Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload

AlexVlx added a comment. In D155775#4652683 , @thakis wrote: > This seems to break tests on Mac and windows, see eg > http://45.33.8.238/macm1/70415/step_7.txt > > Please take a look and revert for now if it takes a while to fix. Whoops, thank you for f

[clang-tools-extra] [RISCV] Eliminate dead li after emitting VSETVLIs (PR #65934)

dtcxzyw wrote: Ping. https://github.com/llvm/llvm-project/pull/65934 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Bugfix for chosing the correct deduction guide (PR #66487)

https://github.com/HoBoIs edited https://github.com/llvm/llvm-project/pull/66487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Bugfix for chosing the correct deduction guide (PR #66487)

@@ -390,6 +390,10 @@ Bug Fixes to C++ Support we now produce a diagnostic. Fixes: (`#65522 `_) +- Fixed a bug where clang couldn't choose the correct deduction guide from + two implicitly generated deduction guides. One o

[PATCH] D155775: [HIP][Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload

yaxunl added a comment. In D155775#4652686 , @AlexVlx wrote: > In D155775#4652683 , @thakis wrote: > >> This seems to break tests on Mac and windows, see eg >> http://45.33.8.238/macm1/70415/step_7.txt >> >> Plea

[PATCH] D138846: MC/DC in LLVM Source-Based Code Coverage: LLVM back-end and compiler-rt

alanphipps added a comment. Hi @hans @w2yehia Please let me know if you have any additional concerns. I'd like to reland this within the next day or so. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138846/new/ https://reviews.llvm.org/D138846

[clang] [clang][codegen] Add a verifier IR pass before any further passes. (PR #68015)

rjmccall wrote: Thank you. If your PR is just changing things so that we run the existing verifier on the direct result of IR generation instead of only verifying it after a few passes run, I agree that it's the right thing to do. https://github.com/llvm/llvm-project/pull/68015 __

[clang] [clang][codegen] Add a verifier IR pass before any further passes. (PR #68015)

https://github.com/rjmccall approved this pull request. https://github.com/llvm/llvm-project/pull/68015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SYCL] Disable RTTI for SYCL device code (PR #68020)

elizabethandrews wrote: Without the diagnostic we have downstream, this change causes a seg fault when using dynamic_cast in kernel code. It passes without error without this change (although technically it shouldn't be allowed). I'm marking this PR as draft

[clang] [SYCL] Disable RTTI for SYCL device code (PR #68020)

https://github.com/elizabethandrews converted_to_draft https://github.com/llvm/llvm-project/pull/68020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 1ab68d7 - [clang][codegen] Add a verifier IR pass before any further passes. (#68015)

Author: Matheus Izvekov Date: 2023-10-03T18:05:54+02:00 New Revision: 1ab68d708aea5f8dd7d9d39dd1de8b23228814f0 URL: https://github.com/llvm/llvm-project/commit/1ab68d708aea5f8dd7d9d39dd1de8b23228814f0 DIFF: https://github.com/llvm/llvm-project/commit/1ab68d708aea5f8dd7d9d39dd1de8b23228814f0.dif

[clang] [clang][codegen] Add a verifier IR pass before any further passes. (PR #68015)

https://github.com/mizvekov closed https://github.com/llvm/llvm-project/pull/68015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Inliner] Improve propagation of return attributes. (PR #67756)

RKSimon wrote: The X86 test split is fine if you want to pre-commit that now https://github.com/llvm/llvm-project/pull/67756 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Remove preloaded SLocEntries from PCM files (PR #66962)

tahonermann wrote: > That said, isBeforeInTranslationUnit is slow already, and I don't think it's > hot in clang, moreso in tools like clang-tidy whose performance is > less-critical. So let's make it right, and then optimize it again if problems > arise. It may not be a hot function in Clang

[clang] [Inliner] Improve propagation of return attributes. (PR #67756)

@@ -1,5 +1,4 @@ // RUN: %clang_cc1 -x c -ffreestanding %s -triple=x86_64-apple-darwin -emit-llvm -o - | FileCheck %s -// RUN: %clang_cc1 -x c++ -std=c++11 -ffreestanding %s -triple=x86_64-apple-darwin -emit-llvm -o - | FileCheck %s RKSimon wrote: It looks like

[clang] [Inliner] Improve propagation of return attributes. (PR #67756)

RKSimon wrote: > The X86 test split is fine if you want to pre-commit that now Sorry bswap.c still needs cleaning up https://github.com/llvm/llvm-project/pull/67756 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[clang] [Inliner] Improve propagation of return attributes. (PR #67756)

nikic wrote: (Another alternative would be to use different check-prefixes for C/C++) https://github.com/llvm/llvm-project/pull/67756 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Do not try to classify dependent call expression (PR #68078)

https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/68078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Correctly handle callees whose type is a Record type when classifying expressions (PR #68078)

https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/68078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Correctly handle callees whose type is a Record type when classifying expressions (PR #68078)

https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/68078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Handle consteval expression in array bounds expressions (PR #66222)

cor3ntin wrote: @shafik ping! https://github.com/llvm/llvm-project/pull/66222 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Mark the Zfa extension as non-experimental (PR #68113)

https://github.com/topperc requested changes to this pull request. Please update the header comment at the top of RISCVInstrInfoZfa.td https://github.com/llvm/llvm-project/pull/68113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D148474: [Clang] Fix ResolveConstructorOverload to not select a conversion function if we are going use copy elision

shafik added a comment. @dim the crash should be fixed by landing: https://github.com/llvm/llvm-project/pull/67373 I need to rebase and test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148474/new/ https://reviews.llvm.org/D148474 ___ cfe-c

[clang-tools-extra] Bugfix for chosing the correct deduction guide (PR #66487)

https://github.com/HoBoIs updated https://github.com/llvm/llvm-project/pull/66487 From 258462cc65403af147bb47cbeb95210df8e18cd3 Mon Sep 17 00:00:00 2001 From: hobois Date: Fri, 15 Sep 2023 09:28:21 +0200 Subject: [PATCH 1/2] Choose the correct deduction guide If there are two guides, one of th

[clang] [clang][ExprConst] Don't try to evaluate value-dependent DeclRefExprs (PR #67778)

Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: @@ -177,3 +177,16 @@ namespace LambdaCallOp { p(); } } + +/// This used to crash due to an assertion failure, +/// see gh#67690 cor3ntin wrote: @tbaederr that's not a thing we distinguish in our tests in

<    1   2   3   4   5   >