@@ -1020,21 +1022,23 @@ void EmitAssemblyHelper::RunOptimizationPipeline(
}
if (CodeGenOpts.FatLTO) {
- MPM = PB.buildFatLTODefaultPipeline(Level, PrepareForThinLTO,
- PrepareForThinLTO ||
-
philnik777 wrote:
> Please make sure you add a description to your PR. This is what usually goes
> into the git log and we want those entries to be as descriptive and helpful
> for folks who read the git logs, thank you.
Do you have any specific suggestions what should be in the message? The l
philnik777 wrote:
> Please make sure you add a description to your PR. This is what usually goes
> into the git log and we want those entries to be as descriptive and helpful
> for folks who read the git logs, thank you.
Do you have any specific suggestions what should be in the message? The l
shafik wrote:
Thank you for this work.
https://github.com/llvm/llvm-project/pull/67996
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/67960
>From 9fde224de6baa5b1fb3713d810ce835d4456b457 Mon Sep 17 00:00:00 2001
From: Giulio Eulisse <10544+...@users.noreply.github.com>
Date: Fri, 29 Sep 2023 08:37:57 +0200
Subject: [PATCH 1/5] Avoid need for SLocEntryLoade
https://github.com/rmaz created https://github.com/llvm/llvm-project/pull/68023
When including builtin headers as part of a system module, ensure we use
absolute paths to those headers. Otherwise the module will fail to compile when
specifying relative resource directories.
>From 6803c872fad25
@@ -103,6 +103,14 @@ template
class PagedVector {
/// Return the size of the vector.
[[nodiscard]] size_t size() const { return Size; }
+ /// Return true if the element at `Index` belongs to a page which was already
+ /// materialized, i.e., had at least one element ac
llvmbot wrote:
@llvm/pr-subscribers-clang-modules
Changes
When including builtin headers as part of a system module, ensure we use
absolute paths to those headers. Otherwise the module will fail to compile when
specifying relative resource directories.
---
Full diff: https://github.com/l
AaronBallman wrote:
Another thing to test is what happens when the user passes `-frtti` explicitly
to enable RTTI.
https://github.com/llvm/llvm-project/pull/68020
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
AaronBallman wrote:
It would be good to add a test for functionality that relies on RTTI to work:
`dynamic_cast` and `typeid` within a kernel would be interesting to try out.
https://github.com/llvm/llvm-project/pull/68020
_
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff e8a74f2334ed82a422f0779d1b5dbc9550e394fb
a5f77527267c5313dc6747ff219de1c828bc968e --
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff e8a74f2334ed82a422f0779d1b5dbc9550e394fb
a5f77527267c5313dc6747ff219de1c828bc968e --
@@ -4515,6 +4515,36 @@ TemplateDeclInstantiator::SubstFunctionType(FunctionDecl
*D,
return NewTInfo;
}
+/// Intorduce the instantiated local variables into the local
cor3ntin wrote:
```suggestion
/// Introduce the instantiated local variables into the loca
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/65193
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin commented:
I found a couple of typos, and this needs a release note to indicate
https://github.com/llvm/llvm-project/issues/64462 was fixed.
I'd like @erichkeane to take a last look but otherwise I think this looks
reasonable
(Sorry for the delay)
https://github.c
@@ -7396,6 +7397,11 @@ class Sema final {
llvm::ContextualFoldingSet
SatisfactionCache;
+ /// Intorduce the instantiated local variables into the local
+ /// instantiation scope.
cor3ntin wrote:
```suggestion
/// Introduce the instantiated local v
https://github.com/ahatanak closed
https://github.com/llvm/llvm-project/pull/68001
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Akira Hatanaka
Date: 2023-10-02T12:46:00-07:00
New Revision: 1925c7aa373e6e36a955888f98037253acf6097e
URL:
https://github.com/llvm/llvm-project/commit/1925c7aa373e6e36a955888f98037253acf6097e
DIFF:
https://github.com/llvm/llvm-project/commit/1925c7aa373e6e36a955888f98037253acf6097e.diff
=?utf-8?q?F=C3=A9lix?= Cloutier
Message-ID:
In-Reply-To:
cor3ntin wrote:
@AaronBallman you have opinion on this?
https://github.com/llvm/llvm-project/pull/65684
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
jyknight added inline comments.
Comment at: clang/lib/Sema/SemaType.cpp:2617
+ } else if (getLangOpts().CPlusPlus) {
+if (getLangOpts().CPlusPlus11 && IsStaticAssertLike(ArraySize, Context))
+ VLADiag = getLangOpts().GNUMode
aaron.ballman wrote:
> jykni
@@ -923,6 +923,8 @@ void EmitAssemblyHelper::RunOptimizationPipeline(
PB.crossRegisterProxies(LAM, FAM, CGAM, MAM);
ModulePassManager MPM;
+ // Add a verifier pass, before any other passes, to catch CodeGen issues.
+ MPM.addPass(VerifierPass());
mizvekov
cor3ntin wrote:
@zyn0217 Can you add a release note indicating that #63898 was fixed? Otherwise
it looks good to me.
Sorry for the long delay, feel free to ping me again
https://github.com/llvm/llvm-project/pull/66641
___
cfe-commits mailing list
cfe
https://github.com/cor3ntin approved this pull request.
Maybe we should change the existing evaluator to be consistent? Otherwise LGTM
https://github.com/llvm/llvm-project/pull/67131
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/65193
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane commented:
Just a pair of nits based on the style guide, else LGTM.
https://github.com/llvm/llvm-project/pull/65193
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cf
@@ -2256,33 +2256,55 @@ ExprResult
Sema::BuildBlockForLambdaConversion(SourceLocation CurrentLocation,
return BuildBlock;
}
+static FunctionDecl *getPatternFunctionDecl(FunctionDecl *FD) {
+ if (FD->getTemplatedKind() == FunctionDecl::TK_MemberSpecialization) {
+while
@@ -7370,7 +7370,8 @@ class Sema final {
public:
LambdaScopeForCallOperatorInstantiationRAII(
Sema &SemasRef, FunctionDecl *FD, MultiLevelTemplateArgumentList MLTAL,
-LocalInstantiationScope &Scope);
+LocalInstantiationScope &Scope,
+bool s
https://github.com/HazardyKnusperkeks created
https://github.com/llvm/llvm-project/pull/68029
None
From 435592764243b0c70857dc7c340046ee3dc50ac9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Sch=C3=A4pers?=
Date: Mon, 2 Oct 2023 22:12:19 +0200
Subject: [PATCH] [clang-format] Fix alignm
nikic wrote:
@zygoloid Thanks for the explanation! I wasn't aware this fell under
unspecified behavior. It's weird that alignment information can survive a `void
*` cast, but it does make some sense.
What seems worrying here is that apparently GCC and Clang do not agree on
semantics in this c
https://github.com/owenca updated
https://github.com/llvm/llvm-project/pull/67955
>From 15d37075331311020020c5741e2432cd3fc0be74 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Sun, 1 Oct 2023 23:01:30 -0700
Subject: [PATCH] [clang-format] Annotate ctors/dtors as CtorDtorDeclName
instead
After
https://github.com/davidstone updated
https://github.com/llvm/llvm-project/pull/67899
>From 07dd53a92efe420466b747dae821f892622e621f Mon Sep 17 00:00:00 2001
From: David Stone
Date: Sat, 30 Sep 2023 22:30:29 -0600
Subject: [PATCH] [clang] Remove duplicate `ModuleId` alias
This alias is already
https://github.com/vgvassilev edited
https://github.com/llvm/llvm-project/pull/67960
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -489,6 +490,8 @@ class SLocEntry {
bool isExpansion() const { return IsExpansion; }
bool isFile() const { return !isExpansion(); }
+ [[nodiscard]] bool isLoaded() const { return Loaded; }
vgvassilev wrote:
Do we need to add `[[nodiscard]]` to the inte
https://github.com/vgvassilev commented:
That's indeed what I was proposing. Do we observe some performance benefits
from this PR on the downstream codebase?
https://github.com/llvm/llvm-project/pull/67960
___
cfe-commits mailing list
cfe-commits@list
elizabethandrews wrote:
Thanks for taking a look! We have diagnostics disabling RTTI in kernels
downstream. It doesn't look like those diagnostics exist here though because
compilation passes without error in my test using these constructs in a kernel.
Let me
hiraditya added inline comments.
Comment at: compiler-rt/lib/tsan/rtl/CMakeLists.txt:5
append_list_if(COMPILER_RT_HAS_MSSE4_2_FLAG -msse4.2 TSAN_RTL_CFLAGS)
-append_list_if(SANITIZER_LIMIT_FRAME_SIZE -Wframe-larger-than=530
+append_list_if(SANITIZER_LIMIT_FRAME_SIZE -Wframe-larg
@@ -489,6 +490,8 @@ class SLocEntry {
bool isExpansion() const { return IsExpansion; }
bool isFile() const { return !isExpansion(); }
+ [[nodiscard]] bool isLoaded() const { return Loaded; }
ktf wrote:
No, I guess not. It's just my clang-tidy integration
https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/67960
>From 9fde224de6baa5b1fb3713d810ce835d4456b457 Mon Sep 17 00:00:00 2001
From: Giulio Eulisse <10544+...@users.noreply.github.com>
Date: Fri, 29 Sep 2023 08:37:57 +0200
Subject: [PATCH 1/6] Avoid need for SLocEntryLoade
ktf wrote:
IIRC I saw a ~0.3 MB reduction in memory usage in my usual test. I do not see
any performance change, although that is not particularly the focus of my
investigation here, so I cannot exclude it (hopefully for the better).
https://github.com/llvm/llvm-project/pull/67960
tahonermann added inline comments.
Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:147-149
+def ext_vla_cxx_static_assert : ExtWarn<
+ "variable length arrays in C++ are a Clang extension; did you mean to use "
+ "'static_assert'?">, InGroup;
I fin
mstorsjo wrote:
> cc @mstorsjo @sylvain-audi @aganea
Sorry, I don't really know anything about this area at all, so I don't think I
have anything to add here.
https://github.com/llvm/llvm-project/pull/66816
___
cfe-commits mailing list
cfe-commits@li
vgvassilev wrote:
> @vgvassilev If that is an acceptable interface for the LLVM interface then,
> yes, it would be perfect from our side, and I'm more than happy to update the
> PR in the next few days.
>
> Just to be sure that I understood your proposal.
>
> `getFullyQualified*` calls will a
aheejin wrote:
Will merge this; the remaining CI failures don't seem to related.
https://github.com/llvm/llvm-project/pull/67770
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Heejin Ahn
Date: 2023-10-02T13:47:56-07:00
New Revision: 8ebd226375488426fd834239cb5c51b3ea0c8004
URL:
https://github.com/llvm/llvm-project/commit/8ebd226375488426fd834239cb5c51b3ea0c8004
DIFF:
https://github.com/llvm/llvm-project/commit/8ebd226375488426fd834239cb5c51b3ea0c8004.diff
LO
https://github.com/aheejin closed
https://github.com/llvm/llvm-project/pull/67770
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jkorous-apple created
https://github.com/llvm/llvm-project/pull/68037
None
>From 553173411b33b4439d6d6c458c31e08ab0a08e28 Mon Sep 17 00:00:00 2001
From: Jan Korous
Date: Mon, 2 Oct 2023 11:51:18 -0700
Subject: [PATCH] [WIP][-Wunsafe-buffer-usage] Start emitting std::array fi
https://github.com/fel-cab updated
https://github.com/llvm/llvm-project/pull/68016
>From dd44de067c26ba94b6561c5ed7fa4a5d812a3d1a Mon Sep 17 00:00:00 2001
From: Felipe Cabarcas
Date: Mon, 18 Sep 2023 12:07:12 +
Subject: [PATCH 01/10] testing Profiler features
---
openmp/libomptarget/src/i
https://github.com/fel-cab updated
https://github.com/llvm/llvm-project/pull/68016
>From dd44de067c26ba94b6561c5ed7fa4a5d812a3d1a Mon Sep 17 00:00:00 2001
From: Felipe Cabarcas
Date: Mon, 18 Sep 2023 12:07:12 +
Subject: [PATCH 01/10] testing Profiler features
---
openmp/libomptarget/src/i
https://github.com/jkorous-apple created
https://github.com/llvm/llvm-project/pull/68038
None
>From 998d7174049deb0ec319155e3740b2d9031d2ff0 Mon Sep 17 00:00:00 2001
From: Jan Korous
Date: Mon, 2 Oct 2023 13:41:24 -0700
Subject: [PATCH] [WIP][-Wunsafe-buffer-usage] Generalize
DerefSimplePtrAr
shafik wrote:
The PR description could have used more details. Was this fixing a crash bug, a
conformance issue, lack of diagnostic etc What is the new behavior would also
be helpful.
Was there a bug report linked to this fix? Is so that should be linked in the
description.
If we are fixing
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 8ebd226375488426fd834239cb5c51b3ea0c8004
553173411b33b4439d6d6c458c31e08ab0a08e28 --
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 93e0127b5036602d786a45f76c6daac67c590723
998d7174049deb0ec319155e3740b2d9031d2ff0 --
@@ -348,6 +348,10 @@ bool ModuleMap::resolveAsBuiltinHeader(
if (!File)
return false;
+ // Ensure the path to the module directory is absolute, otherwise
+ // builtin headers will fail to resolve when using relative resource
+ // directory paths without a -I.
+ llvm:
https://github.com/isuckatcs created
https://github.com/llvm/llvm-project/pull/68039
At the moment in `Interp` the source array initialization (`getCommonExpr()`)
of an `ArrayInitLoopExpr` is evaluated during every iteration, when it should
only be evaluated once.
The initializer is always wr
https://github.com/isuckatcs updated
https://github.com/llvm/llvm-project/pull/68039
>From baf0fc082f2cfa86346a93b22c39b92e9e7e261b Mon Sep 17 00:00:00 2001
From: isuckatcs <65320245+isucka...@users.noreply.github.com>
Date: Mon, 2 Oct 2023 22:29:14 +0200
Subject: [PATCH 1/3] impl
---
clang/li
llvmbot wrote:
@llvm/pr-subscribers-clang
Changes
At the moment in `Interp` the source array initialization (`getCommonExpr()`)
of an `ArrayInitLoopExpr` is evaluated during every iteration, when it should
only be evaluated once.
The initializer is always wrapped inside an `OpaqueValueEx
Author: Pranav Kant
Date: 2023-10-02T14:14:52-07:00
New Revision: 457f582ffe23e951380bc345c4c96ec053c09681
URL:
https://github.com/llvm/llvm-project/commit/457f582ffe23e951380bc345c4c96ec053c09681
DIFF:
https://github.com/llvm/llvm-project/commit/457f582ffe23e951380bc345c4c96ec053c09681.diff
L
https://github.com/pranavk closed
https://github.com/llvm/llvm-project/pull/67196
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jrtc27 added inline comments.
Comment at: compiler-rt/lib/tsan/rtl/CMakeLists.txt:5
append_list_if(COMPILER_RT_HAS_MSSE4_2_FLAG -msse4.2 TSAN_RTL_CFLAGS)
-append_list_if(SANITIZER_LIMIT_FRAME_SIZE -Wframe-larger-than=530
+append_list_if(SANITIZER_LIMIT_FRAME_SIZE -Wframe-larger-
https://github.com/isuckatcs updated
https://github.com/llvm/llvm-project/pull/68039
>From baf0fc082f2cfa86346a93b22c39b92e9e7e261b Mon Sep 17 00:00:00 2001
From: isuckatcs <65320245+isucka...@users.noreply.github.com>
Date: Mon, 2 Oct 2023 22:29:14 +0200
Subject: [PATCH 1/4] impl
---
clang/li
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 55d8f0cd31311ed3ebc85bef2c9b5cfca1579076
3724f695e7699840998d8af16a60f02f90f64b95 --
https://github.com/rmaz updated https://github.com/llvm/llvm-project/pull/68023
>From a44aa3a04dd6391cf4660cefe451ac1d53aa429d Mon Sep 17 00:00:00 2001
From: Richard Howell
Date: Mon, 2 Oct 2023 11:10:52 -0700
Subject: [PATCH] [clang] use absolute path for builtin headers during module
compilat
goldsteinn wrote:
> Apart from that, the functional changes themselves look good to me.
Fixed. Okay to push?
https://github.com/llvm/llvm-project/pull/67756
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman
@@ -0,0 +1,252 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,61 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
@@ -0,0 +1,252 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,252 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,252 @@
+//===--===//
var-const wrote:
Can you please go through various `robust` test files and add tests for
`contains` where it makes sense? Let me know if you need any help with th
@@ -0,0 +1,252 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/var-const requested changes to this pull request.
Thanks for addressing most of the feedback! Did another round.
https://github.com/llvm/llvm-project/pull/65148
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.ll
https://github.com/var-const unassigned
https://github.com/llvm/llvm-project/pull/65148
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,252 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,61 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
@@ -0,0 +1,252 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,252 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/var-const unassigned
https://github.com/llvm/llvm-project/pull/65148
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/var-const unassigned
https://github.com/llvm/llvm-project/pull/65148
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -79,15 +79,15 @@ struct TimeTraceProfilerEntry {
// Calculate timings for FlameGraph. Cast time points to microsecond
precision
jdoerfert wrote:
Can you split the changes to this file into a separate PR? Also check the file,
the comment still states micro
https://github.com/shraiysh created
https://github.com/llvm/llvm-project/pull/68042
This patch adds translation from `omp.teams` operation to LLVM IR using
OpenMPIRBuilder. The clauses are not handled in this patch.
>From c7c9e907d897ae667331761d8097ccb7852c5d93 Mon Sep 17 00:00:00 2001
From:
llvmbot wrote:
@llvm/pr-subscribers-flang-openmp
Changes
This patch adds translation from `omp.teams` operation to LLVM IR using
OpenMPIRBuilder. The clauses are not handled in this patch.
---
Full diff: https://github.com/llvm/llvm-project/pull/68042.diff
2 Files Affected:
- (modified
llvmbot wrote:
@llvm/pr-subscribers-flang-openmp
Changes
This patch adds translation from `omp.teams` operation to LLVM IR using
OpenMPIRBuilder. The clauses are not handled in this patch.
---
Full diff: https://github.com/llvm/llvm-project/pull/68042.diff
2 Files Affected:
- (modified
https://github.com/qiongsiwu approved this pull request.
LGTM! Thanks!
https://github.com/llvm/llvm-project/pull/67853
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 457f582ffe23e951380bc345c4c96ec053c09681
dc0304897ba3f8731bb6062f357fe885ca7e584b --
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 457f582ffe23e951380bc345c4c96ec053c09681
dc0304897ba3f8731bb6062f357fe885ca7e584b --
owenca wrote:
Can you add an issue to show the incorrect format before this patch?
https://github.com/llvm/llvm-project/pull/68029
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -18525,12 +18525,17 @@ TEST_F(FormatTest, AlignConsecutiveAssignments) {
" a_longer_name_for_wrap}};",
Alignment);
- Alignment.ColumnLimit = 60;
+ Alignment = getLLVMStyleWithColumns(60);
+ Alignment.AlignConsecutiveAssig
jansvoboda11 wrote:
I got around investigating
"SemaCXX/warn-unsafe-buffer-usage-fixits-parm-span.cpp" and found out it uses
this pattern:
```
%clang_cc1 ... -include %s %s
```
This means `FileID(1)` is the main input file `%s` and `FileID(2)` is the
built-ins buffer that includes `%s` as `Fi
jansvoboda11 wrote:
Since I moved up the special-casing of built-ins buffer up in my last commit,
it was happening before we got chance to walk up from `FileID(3)` to
`FileID(2)`, meaning it wasn't kicking in. I think we need to sink the
special-casing into `isInTheSameTranslationUnit()` and a
jansvoboda11 wrote:
Turns out some clients are calling `isBeforeInTranslationUnit()` before
checking if both `SourceLocations` are indeed in the same TU. I left behind a
FIXME to call `llvm_unreachable()`, but for now, I just compare the `FileIDs`
to keep things working.
https://github.com/ll
jansvoboda11 wrote:
I don't understand why the tie-breaking code calls the previously visited
`FileID` a parent. We're walking **up** the include/expansion tree, so I think
it should be called child instead. LMK if I'm misunderstanding.
https://github.com/llvm/llvm-project/pull/66962
_
https://github.com/jansvoboda11 updated
https://github.com/llvm/llvm-project/pull/66962
>From 61e8961cde95e9e8ce8cea3efd6aa52273f430e9 Mon Sep 17 00:00:00 2001
From: Jan Svoboda
Date: Wed, 20 Sep 2023 16:50:48 -0700
Subject: [PATCH 1/3] [clang][modules] Remove preloaded SLocEntries from PCM
fi
https://github.com/mydeveloperday approved this pull request.
Looks like it fixes some bugs in the tests too!
https://github.com/llvm/llvm-project/pull/67955
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman
https://github.com/mydeveloperday approved this pull request.
https://github.com/llvm/llvm-project/pull/68029
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,190 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,190 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,190 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -864,74 +864,7 @@ FileID
SourceManager::getFileIDLocal(SourceLocation::UIntTy SLocOffset) const {
/// This function knows that the SourceLocation is in a loaded buffer, not a
/// local one.
FileID SourceManager::getFileIDLoaded(SourceLocation::UIntTy SLocOffset) const
{
-
jaredgrubb updated this revision to Diff 557542.
jaredgrubb added a comment.
Address review comments, and adjusting the patch to address other merges since
this patch was started.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145262/new/
https://reviews.llvm.org/D145262
Files:
clang
Author: Matheus Izvekov
Date: 2023-10-03T00:45:00+02:00
New Revision: 22d8f1dd533e3e56512237811b8d8db83d85edce
URL:
https://github.com/llvm/llvm-project/commit/22d8f1dd533e3e56512237811b8d8db83d85edce
DIFF:
https://github.com/llvm/llvm-project/commit/22d8f1dd533e3e56512237811b8d8db83d85edce.dif
https://github.com/mizvekov closed
https://github.com/llvm/llvm-project/pull/67066
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
301 - 400 of 461 matches
Mail list logo
