[clang-tools-extra] [clang-cl] Fix value of __FUNCTION__ in MSVC mode. (PR #67592)

https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/67592 >From 55b67a58ef8b9856e5f0a8f535b8617f59711dec Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Wed, 27 Sep 2023 11:59:04 -0700 Subject: [PATCH 1/7] Fix value of __FUNCTION__ and __func__ in MSVC mode. --- cl

[clang-tools-extra] [clang-cl] Fix value of __FUNCTION__ in MSVC mode. (PR #67592)

zahiraam wrote: > Could you add a description explaining what is currently wrong with the value > of `__FUNCTION__` is MSVC mode? I think we also need a release note. Hope the RN is at the right place? Thanks. https://github.com/llvm/llvm-project/pull/67592

[clang-tools-extra] [clangd] Allow specifying what headers are always included via "" or <> (PR #67749)

https://github.com/kleinesfilmroellchen updated https://github.com/llvm/llvm-project/pull/67749 From 2e3f397ffc8967fdc13ced1ec0c4a7dc55a2400d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?kleines=20Filmr=C3=B6llchen?= Date: Mon, 2 Oct 2023 17:51:16 +0200 Subject: [PATCH] [clangd] Allow specifying wh

[clang] [clang-cl] Fix value of __FUNCTION__ in MSVC mode. (PR #67592)

https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/67592 >From 55b67a58ef8b9856e5f0a8f535b8617f59711dec Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Wed, 27 Sep 2023 11:59:04 -0700 Subject: [PATCH 1/7] Fix value of __FUNCTION__ and __func__ in MSVC mode. --- cl

[clang-tools-extra] [clang-cl] Fix value of __FUNCTION__ in MSVC mode. (PR #67592)

https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/67592 >From 55b67a58ef8b9856e5f0a8f535b8617f59711dec Mon Sep 17 00:00:00 2001 From: Ammarguellat Date: Wed, 27 Sep 2023 11:59:04 -0700 Subject: [PATCH 1/7] Fix value of __FUNCTION__ and __func__ in MSVC mode. --- cl

[libunwind] [libunwind][libc++][libc++abi] Add cross-compilation flags to tests (PR #67201)

https://github.com/arichardson updated https://github.com/llvm/llvm-project/pull/67201 >From 337df13c04d7ac289de3d77f9e29f20693e206e9 Mon Sep 17 00:00:00 2001 From: Alex Richardson Date: Wed, 6 Sep 2023 11:41:56 -0700 Subject: [PATCH] [libunwind][libc++][libc++abi] Add cross-compilation flags t

[clang] [clang][analyzer] Move checker alpha.unix.StdCLibraryFunctions out of alpha. (PR #66207)

balazske wrote: @haoNoQ Could you check if this change is OK to merge? https://github.com/llvm/llvm-project/pull/66207 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-cl] Fix value of __FUNCTION__ in MSVC mode. (PR #67592)

@@ -2218,6 +2219,24 @@ printTo(raw_ostream &OS, ArrayRef Args, const PrintingPolicy &Policy, } else { if (!FirstArg) OS << Comma; + + if (Policy.UseClassForTemplateArgument && + Argument.getKind() == TemplateArgument::Type && + !Argumen

[clang] [clang-cl] Fix value of __FUNCTION__ in MSVC mode. (PR #67592)

@@ -463,8 +470,73 @@ void ctor_tests() { constexpr SL global_sl = SL::current(); static_assert(is_equal(global_sl.function(), "")); +template +class TestBI { +public: + TestBI() { +#ifdef MS + static_assert(is_equal(__FUNCTION__, "test_func::TestBI::TestBI")); + s

[clang-tools-extra] [clang-cl] Fix value of __FUNCTION__ in MSVC mode. (PR #67592)

@@ -291,6 +291,10 @@ struct PrintingPolicy { /// parameters. unsigned AlwaysIncludeTypeForTemplateArgument : 1; + // Prints "class" keyword before type template arguments. This is used when + // printing a function via the _FUNCTION__ or __func__ macro in MSVC mode. + u

[clang] [clang][Interp] Fix value truncation when casting int128 to smaller size (PR #67961)

https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/67961 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind][test] Avoid calling back into libunwind on sanitizer errors (PR #67861)

https://github.com/arichardson updated https://github.com/llvm/llvm-project/pull/67861 >From 1bd6aa67df58f4becff8fbb1abdb2a244db58e94 Mon Sep 17 00:00:00 2001 From: Alex Richardson Date: Fri, 29 Sep 2023 11:53:11 -0700 Subject: [PATCH] [libunwind][test] Avoid calling back into libunwind on san

[clang] [clang] Add test for CWG2267 (PR #67931)

https://github.com/shafik approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/67931 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c2fd3eb - [clang] Add test for CWG2267 (#67931)

Author: Vlad Serebrennikov Date: 2023-10-02T20:00:41+04:00 New Revision: c2fd3ebe83444de05482d5a5a332dc2cf0db1a92 URL: https://github.com/llvm/llvm-project/commit/c2fd3ebe83444de05482d5a5a332dc2cf0db1a92 DIFF: https://github.com/llvm/llvm-project/commit/c2fd3ebe83444de05482d5a5a332dc2cf0db1a92.

[clang] [clang] Add test for CWG2267 (PR #67931)

https://github.com/Endilll closed https://github.com/llvm/llvm-project/pull/67931 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind] Fix running tests with MSan (PR #67860)

https://github.com/arichardson updated https://github.com/llvm/llvm-project/pull/67860 >From e39c568ba557fbca5d3ef17f3d4f4d74f15e8205 Mon Sep 17 00:00:00 2001 From: Alex Richardson Date: Fri, 29 Sep 2023 13:25:39 -0700 Subject: [PATCH] [libunwind] Fix running tests with MSan In order to run te

[clang] Introduce paged vector (PR #66430)

nikic wrote: > I also noticed that LoadedSLocEntryTable uses 42 elements tables, which > probably introduces some extra divisions to do the indexing. I can try > switching to 32 elements. I've tested the following change that forces power of two pages sizes, but it did not have any impact: h

[clang] Mark an ObjCIvarDecl as invalid if its type contains errors (PR #68001)

https://github.com/ahatanak created https://github.com/llvm/llvm-project/pull/68001 This fixes an assertion failure in InitializationSequence::Perform. >From 82f68bfe98ab0bebf6d1c33a09645aaa55326c2b Mon Sep 17 00:00:00 2001 From: Akira Hatanaka Date: Mon, 2 Oct 2023 09:03:00 -0700 Subject: [PA

[clang] Mark an ObjCIvarDecl as invalid if its type contains errors (PR #68001)

llvmbot wrote: @llvm/pr-subscribers-clang Changes This fixes an assertion failure in InitializationSequence::Perform. --- Full diff: https://github.com/llvm/llvm-project/pull/68001.diff 2 Files Affected: - (modified) clang/lib/Sema/SemaDecl.cpp (+3) - (modified) clang/test/SemaObjCXX/i

[clang-tools-extra] [clang] remove ClassScopeFunctionSpecializationDecl (PR #66636)

https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/66636 >From d11d546f3190936ba45c57b4825073026d817878 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Fri, 25 Aug 2023 14:07:32 -0400 Subject: [PATCH 1/4] [clang] remove ClassScopeFunctionSpecializationDecl

[clang-tools-extra] [clang] remove ClassScopeFunctionSpecializationDecl (PR #66636)

sdkrystian wrote: Updated the release notes. I didn't go into exhaustive detail, but I can add more if anyone here deems it necessary @erichkeane @AaronBallman https://github.com/llvm/llvm-project/pull/66636 ___ cfe-commits mailing list cfe-commits@l

[clang] Mark an ObjCIvarDecl as invalid if its type contains errors (PR #68001)

https://github.com/ravikandhadai approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/68001 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc] Fix linking of AMDGPU device runtime control constants for math (PR #65676)

https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/65676 >From d11fae15878622eb2eb452aedf616e01b577e102 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Thu, 7 Sep 2023 16:08:30 -0500 Subject: [PATCH 1/2] [libc] Fix linking of AMDGPU device runtime control constants

[clang] [libc] Fix linking of AMDGPU device runtime control constants for math (PR #65676)

https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/65676 >From d11fae15878622eb2eb452aedf616e01b577e102 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Thu, 7 Sep 2023 16:08:30 -0500 Subject: [PATCH 1/2] [libc] Fix linking of AMDGPU device runtime control constants

[clang] [libc] Fix linking of AMDGPU device runtime control constants for math (PR #65676)

jhuber6 wrote: Ping. This is a bug fix that prevents this from actually being used and doesn't change any existing behavior. https://github.com/llvm/llvm-project/pull/65676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[clang-tools-extra] [libc] Fix linking of AMDGPU device runtime control constants for math (PR #65676)

jhuber6 wrote: Ping. This is a bug fix that prevents this from actually being used and doesn't change any existing behavior. https://github.com/llvm/llvm-project/pull/65676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[clang] [NFC][clang] change remaining context-dependent type nodes to ContextualFoldingSet (PR #67751)

shafik wrote: Thank you for improving the description. The description is usually what ends up in the git log and so it is important for that summary there to be as helpful and descriptive as possible. https://github.com/llvm/llvm-project/pull/67751 ___

[clang] [Sema] Use underlying type of scoped enum for -Wformat diagnostics (PR #67378)

smeenai wrote: Ping. https://github.com/llvm/llvm-project/pull/67378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix HIP wrapper inclusion of 'algorithm' when using libc++ (PR #67981)

https://github.com/yxsamliu approved this pull request. LGTM. Thanks. It passed internal PSDB https://github.com/llvm/llvm-project/pull/67981 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[clang] 959e69a - [Clang] Fix HIP wrapper inclusion of 'algorithm' when using libc++ (#67981)

Author: Joseph Huber Date: 2023-10-02T11:42:54-05:00 New Revision: 959e69ab46405f36c374dfbfc2edc5b527923dae URL: https://github.com/llvm/llvm-project/commit/959e69ab46405f36c374dfbfc2edc5b527923dae DIFF: https://github.com/llvm/llvm-project/commit/959e69ab46405f36c374dfbfc2edc5b527923dae.diff

[clang] [Clang] Fix HIP wrapper inclusion of 'algorithm' when using libc++ (PR #67981)

https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/67981 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D155688: [PATCH] [llvm] [InstCombine] Canonicalise ADD+GEP

d-smirnov updated this revision to Diff 557537. d-smirnov added a comment. amended Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155688/new/ https://reviews.llvm.org/D155688 Files: clang/test/CodeGenCXX/microsoft-abi-dynamic-cast.cpp llvm/lib/

[clang] [HIP] Support compressing device binary (PR #67162)

https://github.com/yxsamliu updated https://github.com/llvm/llvm-project/pull/67162 >From 71dc0a3afcc873d1afeb3ae265bc006860da1d82 Mon Sep 17 00:00:00 2001 From: "Yaxun (Sam) Liu" Date: Thu, 21 Sep 2023 13:52:16 -0400 Subject: [PATCH] [HIP] Support compressing device binary Add option -f[no-]o

[clang] [HIP] Support compressing device binary (PR #67162)

@@ -1183,6 +1183,10 @@ def fgpu_inline_threshold_EQ : Joined<["-"], "fgpu-inline-threshold=">, def fgpu_sanitize : Flag<["-"], "fgpu-sanitize">, Group, HelpText<"Enable sanitizer for supported offloading devices">; def fno_gpu_sanitize : Flag<["-"], "fno-gpu-sanitize">, Grou

[clang] [HIP] Support compressing device binary (PR #67162)

jhuber6 wrote: > > We need to support compression/uncompression of standalone bundled bitcode, > and standalone bundled code objects that are not embedded in ELF or COFF > binaries. An OS-neutral binary format is preferred. I think my ideal solution would be LLVM supporting some module metada

[PATCH] D158069: [clang][Interp] Fix getIndex() for composite array elements

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/Pointer.h:81-88 + /// Equality operators are just for tests. + bool operator==(const Pointer &P) const { +return Pointee == P.Pointee && Base == P.Base && Offset == P.Offset; + } + + bool operator!=(con

[clang] -fsanitize=function: fix MSVC hashing to sugared type (PR #66816)

https://github.com/rnk approved this pull request. Yep, looks good to me. https://github.com/llvm/llvm-project/pull/66816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9c89b29 - -fsanitize=function: fix MSVC hashing to sugared type (#66816)

Author: Matheus Izvekov Date: 2023-10-02T19:09:39+02:00 New Revision: 9c89b29555a7ccfc3942340f558c3bbea8d10532 URL: https://github.com/llvm/llvm-project/commit/9c89b29555a7ccfc3942340f558c3bbea8d10532 DIFF: https://github.com/llvm/llvm-project/commit/9c89b29555a7ccfc3942340f558c3bbea8d10532.dif

[clang] -fsanitize=function: fix MSVC hashing to sugared type (PR #66816)

https://github.com/mizvekov closed https://github.com/llvm/llvm-project/pull/66816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] -fsanitize=function: fix MSVC hashing to sugared type (PR #66816)

mizvekov wrote: @tru Would you agree to backport this fix to 17? Strictly speaking there is an API change here, but I think it's a bit obscure and in any case, this change could catch misuse of it. https://github.com/llvm/llvm-project/pull/66816 ___

[clang] [Sema] Use underlying type of scoped enum for -Wformat diagnostics (PR #67378)

https://github.com/cjdb commented: Thanks for working on this, it seems like an important fix. Would you mind updating the release notes please? I'll approve afterwards. https://github.com/llvm/llvm-project/pull/67378 ___ cfe-commits mailing list cfe-

[clang] -fsanitize=function: fix MSVC hashing to sugared type (PR #66816)

tru wrote: We guarantee abi/api stability between the patch versions, so I would say no. Maybe if we think it's critical enough we could do a 17.1.0, but this doesn't seem to be the case when reading the description at least. Is this a regression from LLVM 16? I could be convinced, but my def

[clang] Introduce paged vector (PR #66430)

dwblaikie wrote: > This only affects builds with GCC. My understanding was that we basically only cared about performance of clang on clang - that we expect people who want an efficient clang to bootstrap? Could `always_inline` the function, but those sort of annotations would get out of date

[clang] -fsanitize=function: fix MSVC hashing to sugared type (PR #66816)

mizvekov wrote: Yep, it's a regression from 16. This bug makes ubsan unusable for MSVC target in real world projects. We could alternatively backport just the canonicalization, but not the rename, if that makes it better. https://github.com/llvm/llvm-project/pull/66816 ___

[clang] [Driver] Silence stdlib warning when linking C on FreeBSD (PR #68011)

https://github.com/dankm created https://github.com/llvm/llvm-project/pull/68011 Similar to the Gnu toolchain, ignore uses of '-stdlib=libc++' when linking C code. CMake insists on adding it to the command line when linking C, and a bunch of other build systems to similarly. >From 70d76223501e

[clang] [Driver] Silence stdlib warning when linking C on FreeBSD (PR #68011)

llvmbot wrote: @llvm/pr-subscribers-clang Changes Similar to the Gnu toolchain, ignore uses of '-stdlib=libc++' when linking C code. CMake insists on adding it to the command line when linking C, and a bunch of other build systems to similarly. --- Full diff: https://github.com/llvm/llvm

[PATCH] D155688: [PATCH] [llvm] [InstCombine] Canonicalise ADD+GEP

d-smirnov updated this revision to Diff 557538. d-smirnov marked 2 inline comments as done. d-smirnov added a comment. amended Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155688/new/ https://reviews.llvm.org/D155688 Files: clang/test/CodeGenCX

[PATCH] D155688: [PATCH] [llvm] [InstCombine] Canonicalise ADD+GEP

d-smirnov marked an inline comment as done. d-smirnov added a comment. @nikic Amended. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155688/new/ https://reviews.llvm.org/D155688 ___ cfe-commits mailing l

[clang] -fsanitize=function: fix MSVC hashing to sugared type (PR #66816)

tru wrote: cc @mstorsjo @sylvain-audi @aganea https://github.com/llvm/llvm-project/pull/66816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [Sema] Use underlying type of scoped enum for -Wformat diagnostics (PR #67378)

https://github.com/smeenai updated https://github.com/llvm/llvm-project/pull/67378 >From a1c307ddcc309b6b915feaad6d09f74ecc3f6e79 Mon Sep 17 00:00:00 2001 From: Shoaib Meenai Date: Mon, 25 Sep 2023 13:48:10 -0700 Subject: [PATCH 1/2] [Sema] Use underlying type of scoped enum for -Wformat diagn

[clang-tools-extra] [Sema] Use underlying type of scoped enum for -Wformat diagnostics (PR #67378)

smeenai wrote: I updated the release notes. I was planning to ask for a pick into 17, but I'll just tweak the release notes for the pick and modify the Clang 18 release notes afterwards if it's accepted. https://github.com/llvm/llvm-project/pull/67378 __

[clang] [clang] Add test for CWG472 (PR #67948)

https://github.com/shafik commented: None of the implementations seem to agree with the resolution of the DR: https://godbolt.org/z/a7nEvW5Gr https://github.com/llvm/llvm-project/pull/67948 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[clang-tools-extra] [Sema] Use underlying type of scoped enum for -Wformat diagnostics (PR #67378)

https://github.com/cjdb approved this pull request. LGTM, thanks! Do you require assistance committing? https://github.com/llvm/llvm-project/pull/67378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[clang] [PowerPC] Fix use of FPSCR builtins in smmintrin.h (PR #67299)

JeremyRand wrote: ACK 5abcf8964394eb5124d606b00a94781147fd8f8d. I can confirm that this fixes SSE4.1 support in [ncnn](https://github.com/Tencent/ncnn) for POWER9 LE (and gives a nice 3x speedup when benchmarking ncnn, which indicates that the additional intrinsics are actually getting used).

[clang] -fsanitize=alignment: check memcpy/memmove arguments (PR #67766)

MaskRay wrote: > > @zygoloid Is reusing the message for regular stores clear (current > > behavior) enough? > > ``` > > // CHECK-MEMCPY-STORE: misaligned.cpp:[[#@LINE+4]]{{(:12)?}}: runtime > > error: store to misaligned address [[PTR:0x[0-9a-f]*]] for type 'int *', > > which requires 4 byte a

[clang] [libc++] Implement ranges::contains_subrange (PR #66963)

shafik wrote: Please make sure you add a description to your PR. This is what usually goes into the git log and we want those entries to be as descriptive and helpful for folks who read the git logs, thank you. https://github.com/llvm/llvm-project/pull/66963 ___

[clang-tools-extra] [libc++] Implement ranges::contains_subrange (PR #66963)

shafik wrote: Please make sure you add a description to your PR. This is what usually goes into the git log and we want those entries to be as descriptive and helpful for folks who read the git logs, thank you. https://github.com/llvm/llvm-project/pull/66963 ___

[clang-tools-extra] [Sema] Use underlying type of scoped enum for -Wformat diagnostics (PR #67378)

smeenai wrote: I have commit access. Thanks for the review! https://github.com/llvm/llvm-project/pull/67378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [runtimes] Fix parsing of LIB{CXX,CXXABI,UNWIND}_TEST_PARAMS (PR #67691)

vvereschaka wrote: @ldionne @arichardson any progress? https://github.com/llvm/llvm-project/pull/67691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [runtimes] Fix parsing of LIB{CXX, CXXABI, UNWIND}_TEST_PARAMS (PR #67691)

vvereschaka wrote: @ldionne @arichardson any progress? https://github.com/llvm/llvm-project/pull/67691 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add test for CWG1341 (PR #67965)

shafik wrote: Thank you for the tests. https://github.com/llvm/llvm-project/pull/67965 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Bump latest release to 17 for C++ DR Status page (PR #67996)

https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/67996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Bump latest release to 17 for C++ DR Status page (PR #67996)

https://github.com/cor3ntin approved this pull request. Lgtm https://github.com/llvm/llvm-project/pull/67996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Bump latest release to 17 for C++ DR Status page (PR #67996)

https://github.com/Endilll closed https://github.com/llvm/llvm-project/pull/67996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e0cb340 - [clang] Bump latest release to 17 for C++ DR Status page (#67996)

Author: Vlad Serebrennikov Date: 2023-10-02T22:05:36+04:00 New Revision: e0cb340f8ef77e2fefa42a3d6f4bd9aab42ad660 URL: https://github.com/llvm/llvm-project/commit/e0cb340f8ef77e2fefa42a3d6f4bd9aab42ad660 DIFF: https://github.com/llvm/llvm-project/commit/e0cb340f8ef77e2fefa42a3d6f4bd9aab42ad660.

[clang] [IRPGO][ValueProfile] Instrument virtual table address that could be used to do virtual table address comparision for indirect-call-promotion. (PR #66825)

teresajohnson wrote: > > Interesting work! On my side I was thinking about a different approach > > using existing profiling and the whole program devirtualization (WPD) > > framework: > > > > 1. Existing profiling identifies what targets an indirect call goes to > > 2. With WPD information, w

[clang] [clang] Add test for CWG472 (PR #67948)

Endilll wrote: > None of the implementations seem to agree with the resolution of the DR: > https://godbolt.org/z/a7nEvW5Gr It's definitely not the first time CWG goes against every major implementation with their DR resolution. https://github.com/llvm/llvm-project/pull/67948

[clang] [HIP] Support compressing device binary (PR #67162)

https://github.com/yxsamliu updated https://github.com/llvm/llvm-project/pull/67162 >From b1c9550da1074414228a45594478fec7ecbf1779 Mon Sep 17 00:00:00 2001 From: "Yaxun (Sam) Liu" Date: Thu, 21 Sep 2023 13:52:16 -0400 Subject: [PATCH] [HIP] Support compressing device binary Add option -f[no-]o

[clang] [clang][codegen] Add a verifier IR pass before any further passes. (PR #68015)

https://github.com/mizvekov created https://github.com/llvm/llvm-project/pull/68015 This helps check clang generated good IR in the first place, as otherwise this can cause UB in subsequent passes, with the final verification pass not catching any issues. This for example would have helped ca

[clang] [clang][codegen] Add a verifier IR pass before any further passes. (PR #68015)

llvmbot wrote: @llvm/pr-subscribers-clang-codegen Changes This helps check clang generated good IR in the first place, as otherwise this can cause UB in subsequent passes, with the final verification pass not catching any issues. This for example would have helped catch https://github.co

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

zequanwu added a comment. Hi, compiling llvm-10 code with this change causing compilation errors: ../../third_party/swiftshader/third_party/llvm-10.0/llvm/include/llvm/ADT/Optional.h:289:8: error: cannot overload a member function with ref-qualifier '&&' with a member function without a ref-

[clang] [HIP] Support compressing device binary (PR #67162)

yxsamliu wrote: > > We need to support compression/uncompression of standalone bundled bitcode, > > and standalone bundled code objects that are not embedded in ELF or COFF > > binaries. An OS-neutral binary format is preferred. > > I think my ideal solution would be LLVM supporting some modul

[clang] [HIP] Support compressing device binary (PR #67162)

@@ -881,6 +900,184 @@ CreateFileHandler(MemoryBuffer &FirstInput, "'" + FilesType + "': invalid file type specified"); } +OffloadBundlerConfig::OffloadBundlerConfig() { + auto IgnoreEnvVarOpt = + llvm::sys::Process::GetEnv("OFFLOAD_BUNDLER_IGNO

[clang] [NFC][Clang][CodeGen] Improve performance for vtable metadata generation (PR #67066)

https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/67066 >From 44d43a8e7fa5b19671bc3f56f934dfb63a632aa4 Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Thu, 21 Sep 2023 22:57:27 +0200 Subject: [PATCH] [NFC][Clang][CodeGen] Improve performance for vtable metadata

[clang] [NFC][Clang][CodeGen] Improve performance for vtable metadata generation (PR #67066)

https://github.com/mizvekov edited https://github.com/llvm/llvm-project/pull/67066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] -fsanitize=function: fix MSVC hashing to sugared type (PR #66816)

@@ -3838,13 +3838,13 @@ void MicrosoftMangleContextImpl::mangleSEHFinallyBlock( Mangler.mangleName(EnclosingDecl); } -void MicrosoftMangleContextImpl::mangleTypeName( +void MicrosoftMangleContextImpl::mangleCanonicalTypeName( QualType T, raw_ostream &Out, bool Normalize

[clang] 0b07b06 - [Sema] Use underlying type of scoped enum for -Wformat diagnostics (#67378)

Author: Shoaib Meenai Date: 2023-10-02T11:32:54-07:00 New Revision: 0b07b06effe5fdf779b75bb5ac6cf15e477cb0be URL: https://github.com/llvm/llvm-project/commit/0b07b06effe5fdf779b75bb5ac6cf15e477cb0be DIFF: https://github.com/llvm/llvm-project/commit/0b07b06effe5fdf779b75bb5ac6cf15e477cb0be.diff

[clang] [Sema] Use underlying type of scoped enum for -Wformat diagnostics (PR #67378)

https://github.com/smeenai closed https://github.com/llvm/llvm-project/pull/67378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Improve omp offload profiler (PR #68016)

https://github.com/fel-cab created https://github.com/llvm/llvm-project/pull/68016 Summary: Adding information to the LIBOMPTARGET profiler runtime kernel and API calls. Key changes: * Adding information to runtime calls for better understanding of how the application is executing. For examp

[clang] Avoid need for SLocEntryLoaded BitVector (PR #67960)

@@ -103,6 +103,14 @@ template class PagedVector { /// Return the size of the vector. [[nodiscard]] size_t size() const { return Size; } + /// Return true if the element at `Index` belongs to a page which was already + /// materialized, i.e., had at least one element ac

[clang] Bugfix for chosing the correct deduction guide (PR #66487)

shafik wrote: I added a comment in the issue her: https://github.com/llvm/llvm-project/issues/67959#issuecomment-1743564143 Please make sure to add references to the standard in appropriate places in this PR. https://github.com/llvm/llvm-project/pull/66487

[clang] [LTO] A static relocation model can override the PIC level wrt treating external address as directly accessible (PR #65512)

wolfy1961 wrote: Ping ... https://github.com/llvm/llvm-project/pull/65512 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D148381: [Clang] Implement the 'counted_by' attribute

aaron.ballman added a comment. In D148381#4652056 , @void wrote: > FINALLY! found out how to do suggestions for typos. <3 Thank you for your perseverance! Comment at: clang/lib/Sema/SemaDeclAttr.cpp:8420-8428 +if (Result.getResult

[clang-tools-extra] Improve omp offload profiler (PR #68016)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 0b07b06effe5fdf779b75bb5ac6cf15e477cb0be 7c550d3190614d7572bc2d63051d7ce56c8f73b6 --

[clang] Improve omp offload profiler (PR #68016)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 0b07b06effe5fdf779b75bb5ac6cf15e477cb0be 7c550d3190614d7572bc2d63051d7ce56c8f73b6 --

[libunwind] Improve omp offload profiler (PR #68016)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 0b07b06effe5fdf779b75bb5ac6cf15e477cb0be 7c550d3190614d7572bc2d63051d7ce56c8f73b6 --

[clang] [clang] remove ClassScopeFunctionSpecializationDecl (PR #66636)

https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/66636 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] remove ClassScopeFunctionSpecializationDecl (PR #66636)

https://github.com/AaronBallman approved this pull request. LGTM aside from a minor suggestion with the release note. https://github.com/llvm/llvm-project/pull/66636 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[clang-tools-extra] [clang] remove ClassScopeFunctionSpecializationDecl (PR #66636)

@@ -46,6 +46,9 @@ C/C++ Language Potentially Breaking Changes C++ Specific Potentially Breaking Changes - +- The `ClassScopeFunctionSpecializationDecl` AST node has been removed. Dependent class scope +explicit function template special

[clang] [RISCV] Update Zfa extension version to 1.0 (PR #67964)

https://github.com/asb updated https://github.com/llvm/llvm-project/pull/67964 >From 79ab61e07a01e503f22e717c4b0e64b7741c59a0 Mon Sep 17 00:00:00 2001 From: Alex Bradbury Date: Mon, 2 Oct 2023 11:06:44 +0100 Subject: [PATCH 1/2] [RISCV] Update Zfa extension version to 1.0 The Zfa specification

[clang] [RISCV] Update Zfa extension version to 1.0 (PR #67964)

https://github.com/asb edited https://github.com/llvm/llvm-project/pull/67964 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:211-212 with terminals with dark background colors. This is also more consistent with GCC. +- Clang now displays an improved diagnostic and a note when defaulted special + member is a contexpr in a

[clang] [Driver] Silence stdlib warning when linking C on FreeBSD (PR #68011)

dankm wrote: This fixes this inconsistency: Linux: ``` $ clang -o test -stdlib=libc++ test.c $ ./test Hello world ``` FreeBSD: ``` $ clang -o test -stdlib=libc++ test.c clang: warning: argument unused during compilation: '-stdlib=libc++' [-Wunused-command-line-argument] $ ./test Hello world ``

[clang] [clang][codegen] Add a verifier IR pass before any further passes. (PR #68015)

@@ -1020,21 +1022,23 @@ void EmitAssemblyHelper::RunOptimizationPipeline( } if (CodeGenOpts.FatLTO) { - MPM = PB.buildFatLTODefaultPipeline(Level, PrepareForThinLTO, - PrepareForThinLTO || -

[clang] [clang][codegen] Add a verifier IR pass before any further passes. (PR #68015)

@@ -923,6 +923,8 @@ void EmitAssemblyHelper::RunOptimizationPipeline( PB.crossRegisterProxies(LAM, FAM, CGAM, MAM); ModulePassManager MPM; + // Add a verifier pass, before any other passes, to catch CodeGen issues. + MPM.addPass(VerifierPass()); rjmccall

[clang] [Driver] Silence stdlib warning when linking C on FreeBSD (PR #68011)

https://github.com/dankm edited https://github.com/llvm/llvm-project/pull/68011 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SYCL] Disable RTTI for SYCL device code (PR #68020)

https://github.com/elizabethandrews created https://github.com/llvm/llvm-project/pull/68020 None >From d15c78fbce7b00de68fa65976ad86278492c07ed Mon Sep 17 00:00:00 2001 From: Elizabeth Andrews Date: Mon, 2 Oct 2023 09:36:35 -0700 Subject: [PATCH] [SYCL] Disable RTTI for SYCL device code ---

[clang-tools-extra] Improve omp offload profiler (PR #68016)

https://github.com/fel-cab updated https://github.com/llvm/llvm-project/pull/68016 >From dd44de067c26ba94b6561c5ed7fa4a5d812a3d1a Mon Sep 17 00:00:00 2001 From: Felipe Cabarcas Date: Mon, 18 Sep 2023 12:07:12 + Subject: [PATCH 1/9] testing Profiler features --- openmp/libomptarget/src/int

[clang] Improve omp offload profiler (PR #68016)

https://github.com/fel-cab updated https://github.com/llvm/llvm-project/pull/68016 >From dd44de067c26ba94b6561c5ed7fa4a5d812a3d1a Mon Sep 17 00:00:00 2001 From: Felipe Cabarcas Date: Mon, 18 Sep 2023 12:07:12 + Subject: [PATCH 1/9] testing Profiler features --- openmp/libomptarget/src/int

[libunwind] Improve omp offload profiler (PR #68016)

https://github.com/fel-cab updated https://github.com/llvm/llvm-project/pull/68016 >From dd44de067c26ba94b6561c5ed7fa4a5d812a3d1a Mon Sep 17 00:00:00 2001 From: Felipe Cabarcas Date: Mon, 18 Sep 2023 12:07:12 + Subject: [PATCH 1/9] testing Profiler features --- openmp/libomptarget/src/int

<    1   2   3   4   5   >