[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

2023-10-02 Thread Vlad Serebrennikov via Phabricator via cfe-commits
Endill added inline comments. Comment at: clang/docs/ReleaseNotes.rst:94-98 +- Implemented `P0847R7: Deducing this `. Some related core issues were also + implemented (`CWG2553 `, `CWG2554 `, + `

[clang-tools-extra] [clang] remove ClassScopeFunctionSpecializationDecl (PR #66636)

2023-10-02 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/66636 >From d11d546f3190936ba45c57b4825073026d817878 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Fri, 25 Aug 2023 14:07:32 -0400 Subject: [PATCH 1/3] [clang] remove ClassScopeFunctionSpecializationDecl

[clang] [clang][analyzer] Move checker alpha.unix.StdCLibraryFunctions out of alpha. (PR #66207)

2023-10-02 Thread Balázs Kéri via cfe-commits
@@ -1026,6 +1026,100 @@ Check for null pointers being passed as arguments to C string functions: return strlen(0); // warn } +.. _unix-StdCLibraryFunctions: + +unix.StdCLibraryFunctions (C) +""" +Check for calls of standard library function

[PATCH] D153769: [clangd] Implement the 'Organize Imports' source action. Fix include-cleaner findings in batch.

2023-10-02 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:810-815 + Server->applyTweak(Args.tweakID, + {Args.file.file().str(), + Args.selection, + Args.requestedActionKinds, +

[clang] Bugfix for chosing the correct deduction guide (PR #66487)

2023-10-02 Thread via cfe-commits
cor3ntin wrote: @erichkeane https://github.com/llvm/llvm-project/pull/66487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] b52a5c6 - [clang][Interp] Try to fix another build failure on Windows

2023-10-02 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-10-02T15:11:17+02:00 New Revision: b52a5c636064ca7138eb996d74941bbe6f07080c URL: https://github.com/llvm/llvm-project/commit/b52a5c636064ca7138eb996d74941bbe6f07080c DIFF: https://github.com/llvm/llvm-project/commit/b52a5c636064ca7138eb996d74941bbe6f07080c.diff LO

[clang] f756061 - [Clang] Add missing words to ReleaseNotes.rst

2023-10-02 Thread Corentin Jabot via cfe-commits
Author: Corentin Jabot Date: 2023-10-02T15:14:32+02:00 New Revision: f756061387c801e86d2a0f7ec6e162bb5b5bbfdf URL: https://github.com/llvm/llvm-project/commit/f756061387c801e86d2a0f7ec6e162bb5b5bbfdf DIFF: https://github.com/llvm/llvm-project/commit/f756061387c801e86d2a0f7ec6e162bb5b5bbfdf.diff

[clang] [analyzer] Fix crash in BasicValueFactory.cpp with __int128_t integers (PR #67212)

2023-10-02 Thread Aaron Ballman via cfe-commits
@@ -208,6 +208,14 @@ Other Changes fully stripped); :doc:`llvm-symbolizer ` can symbolize the markup afterwards using ``debuginfod``. +* A few crashes have been found and fixed using randomized testing related + to the use of _BitInt() in tidy checks and in clang analysis

[clang] [Clang] Fix HIP wrapper inclusion of 'algorithm' when using libc++ (PR #67981)

2023-10-02 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: Did you test it with internal CI? We may need some HIP header changes to avoid regressing existing HIP apps. https://github.com/llvm/llvm-project/pull/67981 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[clang] [Clang] Fix HIP wrapper inclusion of 'algorithm' when using libc++ (PR #67981)

2023-10-02 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > Did you test it with internal CI? We may need some HIP header changes to > avoid regressing existing HIP apps. No, I don't know how to do that. Hopefully people aren't relying on this to be included elsewhere, since its replacement in this single file is pretty striaghtforwar

[clang] clang/OpenCL: set sqrt fp accuracy on call to Z4sqrt (PR #66651)

2023-10-02 Thread Romaric Jodin via cfe-commits
@@ -5612,6 +5612,10 @@ RValue CodeGenFunction::EmitCall(const CGFunctionInfo &CallInfo, BundleList); EmitBlock(Cont); } + if (CI->getCalledFunction() && CI->getCalledFunction()->hasName() && + CI->getCalledFunction()->getName().startsw

[clang] [clang] Add check for duplicates to make_cxx_dr_status script (PR #67969)

2023-10-02 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/67969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add test for CWG1341 (PR #67965)

2023-10-02 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/67965 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D155688: [PATCH] [llvm] [InstCombine] Canonicalise ADD+GEP

2023-10-02 Thread Nikita Popov via Phabricator via cfe-commits
nikic added inline comments. Comment at: llvm/lib/Transforms/InstCombine/InstructionCombining.cpp:2338-2340 +if (BinaryOperator *Idx = +dyn_cast_or_null(GEP.getOperand(1))) + if ((Idx->getOpcode() == Instruction::Add) && Idx->hasOneUse()) {

[clang] [analyzer] Fix crash in BasicValueFactory.cpp with __int128_t integers (PR #67212)

2023-10-02 Thread via cfe-commits
https://github.com/vabridgers updated https://github.com/llvm/llvm-project/pull/67212 >From 2467ec4991000d139fb3bad61446e019b7ab6142 Mon Sep 17 00:00:00 2001 From: Vince Bridgers Date: Sat, 23 Sep 2023 01:26:14 +0200 Subject: [PATCH] [analyzer] Fix crash in BasicValueFactory.cpp with __int128_t

[clang] [analyzer] Fix crash in BasicValueFactory.cpp with __int128_t integers (PR #67212)

2023-10-02 Thread via cfe-commits
@@ -208,6 +208,14 @@ Other Changes fully stripped); :doc:`llvm-symbolizer ` can symbolize the markup afterwards using ``debuginfod``. +* A few crashes have been found and fixed using randomized testing related + to the use of _BitInt() in tidy checks and in clang analysis

[clang] [analyzer] Fix crash in BasicValueFactory.cpp with __int128_t integers (PR #67212)

2023-10-02 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. Assuming precommit CI comes back green, the changes LGTM, thank you! https://github.com/llvm/llvm-project/pull/67212 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[clang-tools-extra] [clang] remove ClassScopeFunctionSpecializationDecl (PR #66636)

2023-10-02 Thread Aaron Ballman via cfe-commits
@@ -752,8 +745,6 @@ class CollectExtraHighlightings } if (auto *Args = D->getTemplateSpecializationArgsAsWritten()) H.addAngleBracketTokens(Args->getLAngleLoc(), Args->getRAngleLoc()); -if (auto *I = D->getDependentSpecializationInfo()) - H.addAngleBracke

[PATCH] D156565: Diagnose use of VLAs in C++ by default

2023-10-02 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman marked 4 inline comments as done. aaron.ballman added a subscriber: tbaeder. aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:143 +def ext_vla_cxx : ExtWarn< + "variable length arrays are a Clang extension">, InGroup

[clang] [clang][Interp] Add IntegralAP for arbitrary-precision integers (PR #65844)

2023-10-02 Thread Nico Weber via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: nico wrote: Better now, thanks! Next time, I'd be nice to mention this issue in the fixup commits so that they're all linked together. Linking

[PATCH] D156565: Diagnose use of VLAs in C++ by default

2023-10-02 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman updated this revision to Diff 557531. aaron.ballman marked 4 inline comments as done. aaron.ballman added a comment. Updated based on review feedback. Specifically: - Updated a FIXME comment in a test to clarify what's happening. - Reworded diagnostic to add "in C++" CHANGES SINCE

[clang] 6a01da4 - [clang]Interp] Re-add some header deps of Source.h

2023-10-02 Thread Sam McCall via cfe-commits
Author: Sam McCall Date: 2023-10-02T15:57:16+02:00 New Revision: 6a01da4b7cbd70988151f1aa0af6213cf14246e8 URL: https://github.com/llvm/llvm-project/commit/6a01da4b7cbd70988151f1aa0af6213cf14246e8 DIFF: https://github.com/llvm/llvm-project/commit/6a01da4b7cbd70988151f1aa0af6213cf14246e8.diff LO

[clang] Bugfix for chosing the correct deduction guide (PR #66487)

2023-10-02 Thread Erich Keane via cfe-commits
@@ -2129,7 +2129,7 @@ Decl *TemplateDeclInstantiator::VisitFunctionDecl( Function = CXXDeductionGuideDecl::Create( SemaRef.Context, DC, D->getInnerLocStart(), InstantiatedExplicitSpecifier, NameInfo, T, TInfo, -D->getSourceRange().getEnd(), /*Ctor=*/

[clang] Bugfix for chosing the correct deduction guide (PR #66487)

2023-10-02 Thread Erich Keane via cfe-commits
https://github.com/erichkeane commented: This seems right to me, however we need to do 2 things: 1- This needs a release note. 2- We need to track down when this changed in the standard, and why. If it was a DR, we need to do make sure we update that we've implemented that DR. If it was a n

[clang] [clang][Interp] Implement IntegralAP::comp (PR #67954)

2023-10-02 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/67954 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Fix value truncation when casting int128 to smaller size (PR #67961)

2023-10-02 Thread Erich Keane via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: @@ -249,6 +248,11 @@ template class IntegralAP final { R->V = A.V - B.V; return false; // Success! } + erichkeane wrote: Is this template forward declared? Either way, I think as none of the calls

[clang] [clang][Interp] Implement __builtin_popcount() (PR #67929)

2023-10-02 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/67929 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Implement __builtin_popcount() (PR #67929)

2023-10-02 Thread Erich Keane via cfe-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/67929 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Implement __builtin_popcount() (PR #67929)

2023-10-02 Thread Erich Keane via cfe-commits
@@ -260,3 +260,12 @@ namespace SourceLocation { static_assert(c.a.n == __LINE__ - 1, ""); } } + +namespace popcount { + static_assert(__builtin_popcount(~0u) == __CHAR_BIT__ * sizeof(unsigned int), ""); erichkeane wrote: I would suggest more 'difficult

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

2023-10-02 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. Looks like there is quite a few places in the LLVM build that need updating (IteratorTest.cpp, Wasm.h, ElfDumper.cpp) so that builds don't fail as we commit this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new

[PATCH] D133361: [BPF] Attribute preserve_static_offset for structs

2023-10-02 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. In D133361#4652102 , @eddyz87 wrote: > Rebase, changes as requested by @aaron.ballman and @erichkeane. > > Hi @aaron.ballman, @erichkeane, > > Thank you for taking a look. > I beleive this commit covers all feedback except "cla

[clang] [InstCombine] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

2023-10-02 Thread Alexander Richardson via cfe-commits
arichardson wrote: Since the langref definition is based on GEP, can we use index width instead of pointer width? If you disagree with this, it would still be good if you could add a test where the datalayout has index width < pointer width to show the current semantics. https://github.com/ll

[clang] 0e87f6f - [clang] Add test for CWG1341 (#67965)

2023-10-02 Thread via cfe-commits
Author: Vlad Serebrennikov Date: 2023-10-02T18:21:49+04:00 New Revision: 0e87f6f8c244f0bedadf031c8848cb78977fc11a URL: https://github.com/llvm/llvm-project/commit/0e87f6f8c244f0bedadf031c8848cb78977fc11a DIFF: https://github.com/llvm/llvm-project/commit/0e87f6f8c244f0bedadf031c8848cb78977fc11a.

[clang] [clang] Add test for CWG1341 (PR #67965)

2023-10-02 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll closed https://github.com/llvm/llvm-project/pull/67965 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D156565: Diagnose use of VLAs in C++ by default

2023-10-02 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156565/new/ https://reviews.llvm.org/D156565 ___ cfe-commits mailing list cfe-comm

[clang] [OpenMPIRBuilder] Remove wrapper function in `createTask` (PR #67723)

2023-10-02 Thread via cfe-commits
https://github.com/shraiysh updated https://github.com/llvm/llvm-project/pull/67723 >From 6aabc3c10ea2d587120b74966b7ce96f9b8167af Mon Sep 17 00:00:00 2001 From: Shraiysh Vaishay Date: Thu, 28 Sep 2023 13:35:07 -0500 Subject: [PATCH 1/2] [OpenMPIRBuilder] Remove wrapper function in `createTask`

[libunwind] [OpenMPIRBuilder] Remove wrapper function in `createTask` (PR #67723)

2023-10-02 Thread via cfe-commits
https://github.com/shraiysh updated https://github.com/llvm/llvm-project/pull/67723 >From 6aabc3c10ea2d587120b74966b7ce96f9b8167af Mon Sep 17 00:00:00 2001 From: Shraiysh Vaishay Date: Thu, 28 Sep 2023 13:35:07 -0500 Subject: [PATCH 1/2] [OpenMPIRBuilder] Remove wrapper function in `createTask`

[clang] [OpenMPIRBuilder] Remove wrapper function in `createTask` (PR #67723)

2023-10-02 Thread via cfe-commits
https://github.com/shraiysh updated https://github.com/llvm/llvm-project/pull/67723 >From 6aabc3c10ea2d587120b74966b7ce96f9b8167af Mon Sep 17 00:00:00 2001 From: Shraiysh Vaishay Date: Thu, 28 Sep 2023 13:35:07 -0500 Subject: [PATCH 1/2] [OpenMPIRBuilder] Remove wrapper function in `createTask`

[libunwind] [OpenMPIRBuilder] Remove wrapper function in `createTask` (PR #67723)

2023-10-02 Thread via cfe-commits
https://github.com/shraiysh updated https://github.com/llvm/llvm-project/pull/67723 >From 6aabc3c10ea2d587120b74966b7ce96f9b8167af Mon Sep 17 00:00:00 2001 From: Shraiysh Vaishay Date: Thu, 28 Sep 2023 13:35:07 -0500 Subject: [PATCH 1/3] [OpenMPIRBuilder] Remove wrapper function in `createTask`

[clang] [OpenMPIRBuilder] Remove wrapper function in `createTask` (PR #67723)

2023-10-02 Thread via cfe-commits
https://github.com/shraiysh updated https://github.com/llvm/llvm-project/pull/67723 >From 6aabc3c10ea2d587120b74966b7ce96f9b8167af Mon Sep 17 00:00:00 2001 From: Shraiysh Vaishay Date: Thu, 28 Sep 2023 13:35:07 -0500 Subject: [PATCH 1/3] [OpenMPIRBuilder] Remove wrapper function in `createTask`

[PATCH] D133361: [BPF] Attribute preserve_static_offset for structs

2023-10-02 Thread Eduard Zingerman via Phabricator via cfe-commits
eddyz87 added a comment. In D133361#4652368 , @erichkeane wrote: > I don't see the comment response you had to me. Sorry, forgot to click submit. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:7601 + auto *Rec = cast(D); + Rec->addAtt

[libunwind] [OpenMPIRBuilder] Remove wrapper function in `createTask` (PR #67723)

2023-10-02 Thread via cfe-commits
https://github.com/shraiysh edited https://github.com/llvm/llvm-project/pull/67723 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMPIRBuilder] Remove wrapper function in `createTask` (PR #67723)

2023-10-02 Thread via cfe-commits
https://github.com/shraiysh edited https://github.com/llvm/llvm-project/pull/67723 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Only emit function_param_value_unknown in C++11 (PR #67990)

2023-10-02 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/67990 This is also what the current interpreter does. No test for now since the only reproducer I have is from https://reviews.llvm.org/D156565 and doesn't work without that patch. >From 5e43ab378e64ea8a852f8bf5571d

[PATCH] D156565: Diagnose use of VLAs in C++ by default

2023-10-02 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added inline comments. Comment at: clang/test/SemaCXX/offsetof.cpp:31 + int array1[__builtin_offsetof(HasArray, array[i])]; // expected-warning {{variable length arrays are a Clang extension}} \ + new-interp-note

[clang] [clang][Interp] Only emit function_param_value_unknown in C++11 (PR #67990)

2023-10-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes This is also what the current interpreter does. No test for now since the only reproducer I have is from https://reviews.llvm.org/D156565 and doesn't work without that patch. --- Full diff: https://github.com/llvm/llvm-project/pull/67990.

[clang] Avoid need for SLocEntryLoaded BitVector (PR #67960)

2023-10-02 Thread Jakub Kuderski via cfe-commits
@@ -103,6 +103,12 @@ template class PagedVector { /// Return the size of the vector. [[nodiscard]] size_t size() const { return Size; } + [[nodiscard]] bool isMaterialized(size_t Index) const { +assert(Index < Size); +assert(Index / PageSize < PageToDataPtrs.siz

[clang] Avoid need for SLocEntryLoaded BitVector (PR #67960)

2023-10-02 Thread Jakub Kuderski via cfe-commits
@@ -103,6 +103,12 @@ template class PagedVector { /// Return the size of the vector. [[nodiscard]] size_t size() const { return Size; } + [[nodiscard]] bool isMaterialized(size_t Index) const { kuhar wrote: Could you add a documentation comment above?

[PATCH] D133361: [BPF] Attribute preserve_static_offset for structs

2023-10-02 Thread Eduard Zingerman via Phabricator via cfe-commits
eddyz87 added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:3700 +return false; + if (auto *BaseDecl = E->getType()->getPointeeType()->getAsRecordDecl()) +return hasBPFPreserveStaticOffset(BaseDecl); erichkeane wrote: > getPointeeType can als

[clang] 1a3a1d9 - [clang] Add check for duplicates to make_cxx_dr_status script (#67969)

2023-10-02 Thread via cfe-commits
Author: Vlad Serebrennikov Date: 2023-10-02T18:34:37+04:00 New Revision: 1a3a1d9674df00451ab6f7153b78d5f60abcd3c9 URL: https://github.com/llvm/llvm-project/commit/1a3a1d9674df00451ab6f7153b78d5f60abcd3c9 DIFF: https://github.com/llvm/llvm-project/commit/1a3a1d9674df00451ab6f7153b78d5f60abcd3c9.

[clang] [clang] Add check for duplicates to make_cxx_dr_status script (PR #67969)

2023-10-02 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll closed https://github.com/llvm/llvm-project/pull/67969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Fix value truncation when casting int128 to smaller size (PR #67961)

2023-10-02 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/67961 >From 80bd890c332654458014c4acc20709b9cbb6eb90 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Sun, 1 Oct 2023 19:57:03 +0200 Subject: [PATCH

[PATCH] D133361: [BPF] Attribute preserve_static_offset for structs

2023-10-02 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:3700 +return false; + if (auto *BaseDecl = E->getType()->getPointeeType()->getAsRecordDecl()) +return hasBPFPreserveStaticOffset(BaseDecl); eddyz87 wrote: > erichkeane wrote: > >

[clang] [clang][Interp] Fix value truncation when casting int128 to smaller size (PR #67961)

2023-10-02 Thread Erich Keane via cfe-commits
Timm =?utf-8?q?B=C3=A4der?= Message-ID: In-Reply-To: https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/67961 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[clang] [clang][Interp] Implement __builtin_popcount() (PR #67929)

2023-10-02 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/67929 >From a3633c87cd53ee1d092a68e21d9dd41945a848d6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Sun, 1 Oct 2023 19:41:15 +0200 Subject: [PATCH] [clang][Interp] Implement __builtin_popcount() -

[clang] [clang][ExprConst] Fix crash on uninitialized array subobject (PR #67817)

2023-10-02 Thread Takuya Shimizu via cfe-commits
@@ -2411,10 +2411,15 @@ static bool CheckEvaluationResult(CheckEvaluationResultKind CERK, const FieldDecl *SubobjectDecl, CheckedTemporaries &CheckedTemps) { if (!Value.hasValue()) { -assert(SubobjectDec

[clang] [clang][Interp] Implement __builtin_popcount() (PR #67929)

2023-10-02 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/67929 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D133361: [BPF] Attribute preserve_static_offset for structs

2023-10-02 Thread Eduard Zingerman via Phabricator via cfe-commits
eddyz87 added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:3700 +return false; + if (auto *BaseDecl = E->getType()->getPointeeType()->getAsRecordDecl()) +return hasBPFPreserveStaticOffset(BaseDecl); erichkeane wrote: > eddyz87 wrote: > > eri

[PATCH] D133361: [BPF] Attribute preserve_static_offset for structs

2023-10-02 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added inline comments. Comment at: llvm/test/CodeGen/BPF/preserve-static-offset/load-align.ll:61 +!0 = !{i32 1, !"wchar_size", i32 4} +!1 = !{!"clang version 18.0.0 (/home/eddy/work/llvm-project/clang c899a1ca75d0f1b559204eff79a2578d2cafc7ab)"} +!2 = !{!3, !4, i64 128

[clang] [clang][Interp] Fix value truncation when casting int128 to smaller size (PR #67961)

2023-10-02 Thread via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 1a3a1d9674df00451ab6f7153b78d5f60ab

[libunwind] [OpenMPIRBuilder] Remove wrapper function in `createTask`, `createTeams` (PR #67723)

2023-10-02 Thread via cfe-commits
https://github.com/shraiysh updated https://github.com/llvm/llvm-project/pull/67723 >From 6aabc3c10ea2d587120b74966b7ce96f9b8167af Mon Sep 17 00:00:00 2001 From: Shraiysh Vaishay Date: Thu, 28 Sep 2023 13:35:07 -0500 Subject: [PATCH 1/4] [OpenMPIRBuilder] Remove wrapper function in `createTask`

[clang] [OpenMPIRBuilder] Remove wrapper function in `createTask`, `createTeams` (PR #67723)

2023-10-02 Thread via cfe-commits
https://github.com/shraiysh updated https://github.com/llvm/llvm-project/pull/67723 >From 6aabc3c10ea2d587120b74966b7ce96f9b8167af Mon Sep 17 00:00:00 2001 From: Shraiysh Vaishay Date: Thu, 28 Sep 2023 13:35:07 -0500 Subject: [PATCH 1/4] [OpenMPIRBuilder] Remove wrapper function in `createTask`

[clang-tools-extra] [OpenMPIRBuilder] Remove wrapper function in `createTask`, `createTeams` (PR #67723)

2023-10-02 Thread via cfe-commits
https://github.com/shraiysh updated https://github.com/llvm/llvm-project/pull/67723 >From 6aabc3c10ea2d587120b74966b7ce96f9b8167af Mon Sep 17 00:00:00 2001 From: Shraiysh Vaishay Date: Thu, 28 Sep 2023 13:35:07 -0500 Subject: [PATCH 1/4] [OpenMPIRBuilder] Remove wrapper function in `createTask`

[clang] [clang][Interp] Fix value truncation when casting int128 to smaller size (PR #67961)

2023-10-02 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/67961 >From d7ee51b3736ee65279f07bb0f4d5ccc31911cfda Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Sun, 1 Oct 2023 19:57:03 +0200 Subject: [PATCH

[clang] dd01633 - [analyzer] Fix crash in BasicValueFactory.cpp with __int128_t integers (#67212)

2023-10-02 Thread via cfe-commits
Author: vabridgers Date: 2023-10-02T09:54:22-05:00 New Revision: dd01633c8160e54cc1bc379498cbade646375813 URL: https://github.com/llvm/llvm-project/commit/dd01633c8160e54cc1bc379498cbade646375813 DIFF: https://github.com/llvm/llvm-project/commit/dd01633c8160e54cc1bc379498cbade646375813.diff LO

[clang] [analyzer] Fix crash in BasicValueFactory.cpp with __int128_t integers (PR #67212)

2023-10-02 Thread via cfe-commits
https://github.com/vabridgers closed https://github.com/llvm/llvm-project/pull/67212 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Inliner] Improve propagation of return attributes. (PR #67756)

2023-10-02 Thread Nikita Popov via cfe-commits
nikic wrote: For the clang tests you've split, the `.c` versions still have `defined(__cplusplus)` checks, which doesn't make much sense. Though I think we might be better off passing `-no-enable-noundef-analysis` to these tests, as noundef is really not what they want to test. https://github

[PATCH] D133361: [BPF] Attribute preserve_static_offset for structs

2023-10-02 Thread Eduard Zingerman via Phabricator via cfe-commits
eddyz87 added inline comments. Comment at: llvm/test/CodeGen/BPF/preserve-static-offset/load-align.ll:61 +!0 = !{i32 1, !"wchar_size", i32 4} +!1 = !{!"clang version 18.0.0 (/home/eddy/work/llvm-project/clang c899a1ca75d0f1b559204eff79a2578d2cafc7ab)"} +!2 = !{!3, !4, i64 128} -

[clang] Avoid need for SLocEntryLoaded BitVector (PR #67960)

2023-10-02 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/67960 >From 9fde224de6baa5b1fb3713d810ce835d4456b457 Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Fri, 29 Sep 2023 08:37:57 +0200 Subject: [PATCH 1/2] Avoid need for SLocEntryLoade

[clang] [clang] Bump latest release to 17 for C++ DR Status page (PR #67996)

2023-10-02 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll created https://github.com/llvm/llvm-project/pull/67996 `make_cxx_dr_status` has a hardcoded number of the latest release, for the puproses of determining whether a particular DR is available to users or not yet. I'm bumping it to 17. >From ecea1993e65880c077eec769b

[clang] [Inliner] Improve propagation of return attributes. (PR #67756)

2023-10-02 Thread Nikita Popov via cfe-commits
nikic wrote: Apart from that, the functional changes themselves look good to me. https://github.com/llvm/llvm-project/pull/67756 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Bump latest release to 17 for C++ DR Status page (PR #67996)

2023-10-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes `make_cxx_dr_status` has a hardcoded number of the latest release, for the puproses of determining whether a particular DR is available to users or not yet. I'm bumping it to 17. --- Full diff: https://github.com/llvm/llvm-project/pull/67

[clang] Avoid need for SLocEntryLoaded BitVector (PR #67960)

2023-10-02 Thread Giulio Eulisse via cfe-commits
@@ -103,6 +103,12 @@ template class PagedVector { /// Return the size of the vector. [[nodiscard]] size_t size() const { return Size; } + [[nodiscard]] bool isMaterialized(size_t Index) const { ktf wrote: ```suggestion /// @return true in case the el

[clang] Avoid need for SLocEntryLoaded BitVector (PR #67960)

2023-10-02 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/67960 >From 9fde224de6baa5b1fb3713d810ce835d4456b457 Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Fri, 29 Sep 2023 08:37:57 +0200 Subject: [PATCH 1/3] Avoid need for SLocEntryLoade

[clang] [clang] Bump latest release to 17 for C++ DR Status page (PR #67996)

2023-10-02 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/67996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Bump latest release to 17 for C++ DR Status page (PR #67996)

2023-10-02 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/67996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [mlir][sparse] Update Enum name for CompressedWithHigh (PR #67845)

2023-10-02 Thread Yinying Li via cfe-commits
https://github.com/yinying-lisa-li closed https://github.com/llvm/llvm-project/pull/67845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Avoid need for SLocEntryLoaded BitVector (PR #67960)

2023-10-02 Thread Jakub Kuderski via cfe-commits
@@ -103,6 +103,14 @@ template class PagedVector { /// Return the size of the vector. [[nodiscard]] size_t size() const { return Size; } + /// @return true in case the element at index @a Index belongs to a page which + /// was already materialised. ku

[clang] f1fed12 - [Clang] Fix crash when ill-formed code is treated as a deduction guide (#67373)

2023-10-02 Thread via cfe-commits
Author: Shafik Yaghmour Date: 2023-10-02T08:08:39-07:00 New Revision: f1fed124524151b73fbf153e946840730986ca6c URL: https://github.com/llvm/llvm-project/commit/f1fed124524151b73fbf153e946840730986ca6c DIFF: https://github.com/llvm/llvm-project/commit/f1fed124524151b73fbf153e946840730986ca6c.dif

[clang-tools-extra] [Clang] Fix crash when ill-formed code is treated as a deduction guide (PR #67373)

2023-10-02 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik closed https://github.com/llvm/llvm-project/pull/67373 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9aedb60 - [clang][Interp] Implement __builtin_popcount() (#67929)

2023-10-02 Thread via cfe-commits
Author: Timm Baeder Date: 2023-10-02T17:14:31+02:00 New Revision: 9aedb60c70386c6be28e3c9b7fa5326cade25702 URL: https://github.com/llvm/llvm-project/commit/9aedb60c70386c6be28e3c9b7fa5326cade25702 DIFF: https://github.com/llvm/llvm-project/commit/9aedb60c70386c6be28e3c9b7fa5326cade25702.diff L

[clang] [clang][Interp] Implement __builtin_popcount() (PR #67929)

2023-10-02 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/67929 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D154262: [clang][Interp] LambdaThisCaptures

2023-10-02 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154262/new/ https://reviews.llvm.org/D154262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D156453: [clang][Interp] Create only globals when initializing a global variable

2023-10-02 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156453/new/ https://reviews.llvm.org/D156453 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D157252: [clang][ExprConst] Handle 0 type size in builtin_memcpy etc.

2023-10-02 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157252/new/ https://reviews.llvm.org/D157252 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D158516: [clang][Interp] Only lazily visit constant globals

2023-10-02 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158516/new/ https://reviews.llvm.org/D158516 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang] Hint for branch likelihood (PR #67972)

2023-10-02 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/67972 >From 154f82bd0e35e9d8ad8f8812ba3eb1cf8d211003 Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Mon, 2 Oct 2023 13:01:14 +0200 Subject: [PATCH 1/2] Hint for branch likelihood --

[clang] Recover performance loss after PagedVector introduction (PR #67972)

2023-10-02 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf edited https://github.com/llvm/llvm-project/pull/67972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AIX][TOC] Add -mtocdata/-mno-tocdata options on AIX (PR #67999)

2023-10-02 Thread Zaara Syeda via cfe-commits
https://github.com/syzaara created https://github.com/llvm/llvm-project/pull/67999 This patch enables support that the XL compiler had for AIX under -qdatalocal/-qdataimported. >From b789b57067bfe9df948a6ff2d65bf2381b23d042 Mon Sep 17 00:00:00 2001 From: Zaara Syeda Date: Thu, 28 Sep 2023 15:

[clang] [AIX][TOC] Add -mtocdata/-mno-tocdata options on AIX (PR #67999)

2023-10-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-mc Changes This patch enables support that the XL compiler had for AIX under -qdatalocal/-qdataimported. --- Patch is 38.39 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/67999.diff 22 Files Affected: - (

[clang] Recover performance loss after PagedVector introduction (PR #67972)

2023-10-02 Thread Giulio Eulisse via cfe-commits
ktf wrote: @nikic I have pushed a new commit where I change the size of the page to 32 elements from the current 42. It should at least get rid of a division. https://github.com/llvm/llvm-project/pull/67972 ___ cfe-commits mailing list cfe-commits@lis

[clang] Recover performance loss after PagedVector introduction (PR #67972)

2023-10-02 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/67972 >From 154f82bd0e35e9d8ad8f8812ba3eb1cf8d211003 Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Mon, 2 Oct 2023 13:01:14 +0200 Subject: [PATCH 1/3] Hint for branch likelihood --

[clang] Avoid need for SLocEntryLoaded BitVector (PR #67960)

2023-10-02 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/67960 >From 9fde224de6baa5b1fb3713d810ce835d4456b457 Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Fri, 29 Sep 2023 08:37:57 +0200 Subject: [PATCH 1/4] Avoid need for SLocEntryLoade

[clang-tools-extra] [clang-cl] Fix value of __FUNCTION__ and __FUNC__ in MSVC mode for c++. (PR #66120)

2023-10-02 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/66120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-cl] Fix value of __FUNCTION__ and __FUNC__ in MSVC mode for c++. (PR #66120)

2023-10-02 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/66120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 2d4de5a - [clang][Interp] Implement IntegralAP::comp (#67954)

2023-10-02 Thread via cfe-commits
Author: Timm Baeder Date: 2023-10-02T17:41:14+02:00 New Revision: 2d4de5acfa2a1f84d5566acd1ecc122d309c11c8 URL: https://github.com/llvm/llvm-project/commit/2d4de5acfa2a1f84d5566acd1ecc122d309c11c8 DIFF: https://github.com/llvm/llvm-project/commit/2d4de5acfa2a1f84d5566acd1ecc122d309c11c8.diff L

[clang] [clang][Interp] Implement IntegralAP::comp (PR #67954)

2023-10-02 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/67954 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Fix value truncation when casting int128 to smaller size (PR #67961)

2023-10-02 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/67961 >From 377e0b069ff0d68ff4a4cdd690b62e555bdf8d8a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Mon, 2 Oct 2023 10:46:22 +0200 Subject: [PATCH] [clang][Interp] Fix value truncation when casting

[clang-tools-extra] [clang-cl] Fix value of __FUNCTION__ in MSVC mode. (PR #67592)

2023-10-02 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/67592 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Move checker alpha.unix.StdCLibraryFunctions out of alpha. (PR #66207)

2023-10-02 Thread Balázs Kéri via cfe-commits
https://github.com/balazske updated https://github.com/llvm/llvm-project/pull/66207 From 5b9ad350fedad88a4d2ac93bafc29bae893c32e7 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bal=C3=A1zs=20K=C3=A9ri?= Date: Wed, 13 Sep 2023 14:56:18 +0200 Subject: [PATCH 1/2] [clang][analyzer] Move checker alpha.u

<    1   2   3   4   5   >