[clang] Introduce paged vector (PR #66430)

2023-09-26 Thread Giulio Eulisse via cfe-commits
https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430 >From 47392e5996cccada1d638495a9376b0430142c8c Mon Sep 17 00:00:00 2001 From: Giulio Eulisse <10544+...@users.noreply.github.com> Date: Thu, 14 Sep 2023 21:58:21 +0200 Subject: [PATCH 1/6] Introduce PagedVector class

[clang] Introduce paged vector (PR #66430)

2023-09-26 Thread Giulio Eulisse via cfe-commits
ktf wrote: @vgvassilev Ping again. https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

2023-09-26 Thread NagaChaitanya Vellanki via Phabricator via cfe-commits
chaitanyav updated this revision to Diff 557373. chaitanyav added a comment. Rebase with upstream Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/Sema

[clang-tools-extra] 6dfdf68 - [clang-tidy][NFC] Removing lefover AST dump()

2023-09-26 Thread Piotr Zegar via cfe-commits
Author: Piotr Zegar Date: 2023-09-26T20:24:52Z New Revision: 6dfdf68aea6aa1c6beaf4a7aa2cc7b0a40bfc160 URL: https://github.com/llvm/llvm-project/commit/6dfdf68aea6aa1c6beaf4a7aa2cc7b0a40bfc160 DIFF: https://github.com/llvm/llvm-project/commit/6dfdf68aea6aa1c6beaf4a7aa2cc7b0a40bfc160.diff LOG: [

[clang] [Clang] Fix crash when ill-formed code is treated as a deduction guide (PR #67373)

2023-09-26 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik updated https://github.com/llvm/llvm-project/pull/67373 >From beab5db738483795ecb0bace2842acdbb1c9869a Mon Sep 17 00:00:00 2001 From: Shafik Yaghmour Date: Mon, 25 Sep 2023 13:56:43 -0700 Subject: [PATCH] [Clang] Fix crash when ill-formed code is treated as a deductio

[clang] [clang] Predefined macros for float128 support (PR #67196)

2023-09-26 Thread Eric Christopher via cfe-commits
https://github.com/echristo commented: In general this looks good. Since we don't have full compiler-rt support for this yet we may want to wait until that to merge. Alex is already looking at this and coordinating with his needs is probably the best solution. https://github.com/llvm/llvm-proj

[clang] [clang][Diagnostics] Make 'note' color CYAN (PR #66997)

2023-09-26 Thread via cfe-commits
cor3ntin wrote: > This doesn't really fix the problem, it just shuffles it around. I expect > people with blue(ish) terminals will experience the same issue after this is > applied, so we ought to try and detect what colours to print out, and then > have compatible themes. Not really, CYAN is

[clang] [Clang] Fix crash when ill-formed code is treated as a deduction guide (PR #67373)

2023-09-26 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik resolved https://github.com/llvm/llvm-project/pull/67373 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix crash when ill-formed code is treated as a deduction guide (PR #67373)

2023-09-26 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik resolved https://github.com/llvm/llvm-project/pull/67373 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Make 'note' color CYAN (PR #66997)

2023-09-26 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. A shed by any other color would store bikes as well. https://github.com/llvm/llvm-project/pull/66997 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[clang] [analyzer] Moving TaintPropagation checker out of alpha (PR #67352)

2023-09-26 Thread Artem Dergachev via cfe-commits
haoNoQ wrote: > @haoNoQ I don't really understand your remark that > > > The report may be technically correct but I think the entire idea of the > > checker never made sense in the first place. It doesn't matter that > > untrusted data is used to specify buffer size once; it matters that data

[clang] [clang] Predefined macros for float128 support (PR #67196)

2023-09-26 Thread Alexander Shaposhnikov via cfe-commits
https://github.com/alexander-shaposhnikov approved this pull request. LG https://github.com/llvm/llvm-project/pull/67196 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] Introduce the initial support for OpenMP kernel language (PR #66844)

2023-09-26 Thread Shilei Tian via cfe-commits
@@ -0,0 +1,21 @@ +// RUN: %clang_cc1 -verify -fopenmp %s +// RUN: %clang_cc1 -verify -fopenmp-simd %s +// RUN: %clang_cc1 -verify -fopenmp -fopenmp-targets=nvptx64 %s + +void foo() { +} + +void bar() { +#pragma omp target ompx_bare // expected-error {{unexpected OpenMP clause 'om

[clang] [OpenMP] Introduce the initial support for OpenMP kernel language (PR #66844)

2023-09-26 Thread Shilei Tian via cfe-commits
https://github.com/shiltian resolved https://github.com/llvm/llvm-project/pull/66844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D117773: [clang-tidy] added JSON output to clang-tidy-diff.py

2023-09-26 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. Herald added a reviewer: njames93. Herald added a subscriber: PiotrZSL. Herald added a project: All. Is this change still relevant of can we close this PR? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117773/new/ https://re

[PATCH] D116875: [clang-tidy] Add performance-inefficient-array-traversal check

2023-09-26 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. Herald added a subscriber: PiotrZSL. Herald added a project: All. Is this change still relevant or can we close the PR? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116875/new/ https://reviews.llvm.org/D116875

[PATCH] D144136: Add a "remark" to report on array accesses

2023-09-26 Thread Bill Wendling via Phabricator via cfe-commits
void added a comment. In D144136#4639907 , @kees wrote: > Can you refresh this patch to work with https://reviews.llvm.org/D148381 ? My > testing seems to imply that it doesn't know the size of the array. I assume > the `if (!IsUnboundedArray)` check is

[PATCH] D117197: [clang-format] Add new option to support adding a space between Javascript Union and Intersection types

2023-09-26 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. Herald added a project: All. Herald added a reviewer: rymiel. Is this change still relevant or can we close this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117197/new/ https://reviews.llvm.org/D117197 ___ cfe-commi

[clang] [OpenMP] Introduce the initial support for OpenMP kernel language (PR #66844)

2023-09-26 Thread Johannes Doerfert via cfe-commits
https://github.com/jdoerfert commented: Where is the code that prevents the init/deinit calls from being created? https://github.com/llvm/llvm-project/pull/66844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[clang] [OpenMP] Introduce the initial support for OpenMP kernel language (PR #66844)

2023-09-26 Thread Johannes Doerfert via cfe-commits
@@ -752,27 +751,41 @@ void CGOpenMPRuntimeGPU::emitNonSPMDKernel(const OMPExecutableDirective &D, EntryFunctionState EST; WrapperFunctionsMap.clear(); + bool IsBareKernel = D.getSingleClause(); jdoerfert wrote: How can a non-spmd kernel be bare? We shou

[clang] [OpenMP] Introduce the initial support for OpenMP kernel language (PR #66844)

2023-09-26 Thread Johannes Doerfert via cfe-commits
https://github.com/jdoerfert edited https://github.com/llvm/llvm-project/pull/66844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D84658: [clang] Overload NamedDecl::printName to provide a user-friendly name for unnamed entities

2023-09-26 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik added a comment. Herald added a project: All. It looks like some of these changes made it through different PRs but a lot of this is not in. It would be nice to get a updated version of this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[clang] 6e608dc - [clang-format] Correctly annotate return type of function pointer (#66893)

2023-09-26 Thread via cfe-commits
Author: Owen Pan Date: 2023-09-26T14:17:49-07:00 New Revision: 6e608dc44b5f8998813a3051da0a5f80c2db7d2b URL: https://github.com/llvm/llvm-project/commit/6e608dc44b5f8998813a3051da0a5f80c2db7d2b DIFF: https://github.com/llvm/llvm-project/commit/6e608dc44b5f8998813a3051da0a5f80c2db7d2b.diff LOG:

[clang] [clang-format] Correctly annotate return type of function pointer (PR #66893)

2023-09-26 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/66893 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Make 'note' color CYAN (PR #66997)

2023-09-26 Thread Christopher Di Bella via cfe-commits
cjdb wrote: > Not really, CYAN is only cyan if that's what your terminal decides to render > the color 6 as, you can configure it to be orange if you want. Oh, interesting. In that case, I see no problems. https://github.com/llvm/llvm-project/pull/66997

[clang] f2c97ff - [clang-format] Fix a bug in NamespaceEndCommentsFixer (#67422)

2023-09-26 Thread via cfe-commits
Author: Owen Pan Date: 2023-09-26T14:22:29-07:00 New Revision: f2c97ffe4688ba85274146b4c9fc4bcffa92ecbc URL: https://github.com/llvm/llvm-project/commit/f2c97ffe4688ba85274146b4c9fc4bcffa92ecbc DIFF: https://github.com/llvm/llvm-project/commit/f2c97ffe4688ba85274146b4c9fc4bcffa92ecbc.diff LOG:

[clang] [clang-format] Fix a bug in NamespaceEndCommentsFixer (PR #67422)

2023-09-26 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/67422 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc++] Implement ranges::contains_subrange (PR #66963)

2023-09-26 Thread via cfe-commits
https://github.com/ZijunZhaoCCK resolved https://github.com/llvm/llvm-project/pull/66963 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D145214: [TSAN] add support for riscv64

2023-09-26 Thread Aditya Kumar via Phabricator via cfe-commits
hiraditya added a comment. In D145214#4650928 , @alexfanqi wrote: > In D145214#4650189 , @hiraditya > wrote: > >> I tested it on a licheepi board (riscv64 debian) and all the tests modified >> in this patch have

[PATCH] D157547: Arm64EC entry/exit thunks, consolidated.

2023-09-26 Thread Daniel Paoliello via Phabricator via cfe-commits
dpaoliello added a comment. @efriedma the patch is failing to apply - can you please update your baseline, or move this to a GitHub PR? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157547/new/ https://reviews.llvm.org/D157547 ___

[PATCH] D145214: [TSAN] add support for riscv64

2023-09-26 Thread Alex Fan via Phabricator via cfe-commits
alexfanqi added a comment. >> While testing compiler-rt/test/tsan/RISCV64Config only >> compiler-rt/test/tsan/mmap_lots.cpp failed. I couldn't run all the >> compiler-rt tests on Licheepi because it is very slow I had this only test failure before. When the upper memory space is fully mapped o

[clang] [clang][modules] Adopt `FileEntryRef` in the `HeaderFileInfo` block in PCM files (PR #67383)

2023-09-26 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: > test case with multiple virtual entries to the same file that would now be > serialized once? If you're asking because of this: > First, this patch removes the loop over FileManager::VirtualFileEntries. It's > redundant, since all virtual file entries have a non-virtual/

[PATCH] D145214: [TSAN] add support for riscv64

2023-09-26 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: compiler-rt/lib/tsan/rtl/tsan_platform.h:971 }; -const uptr indicator = 0x0e00ull; +const uptr indicator = 0x0f00ull; const uptr ind_lsb = 1ull << LeastSignificantSetBitIndex(indicator);

[PATCH] D153131: [clang analysis][thread-safety] Handle return-by-reference...

2023-09-26 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert accepted this revision. aaronpuchert added a comment. Looks still good to me. As I wrote on D153132 , I don't think we need it anymore, but if you disagree I think I can accept it as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[clang] [MLIR] Pass hostShared flag in gpu.alloc op to runtime wrappers (PR #66401)

2023-09-26 Thread Nishant Patel via cfe-commits
nbpatel wrote: @joker-eph can you help merge this as well?its approved https://github.com/llvm/llvm-project/pull/66401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [MLIR] Pass hostShared flag in gpu.alloc op to runtime wrappers (PR #66401)

2023-09-26 Thread Nishant Patel via cfe-commits
nbpatel wrote: @joker-eph can you help merge this as well?its approved https://github.com/llvm/llvm-project/pull/66401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MLIR] Pass hostShared flag in gpu.alloc op to runtime wrappers (PR #66401)

2023-09-26 Thread Mehdi Amini via cfe-commits
https://github.com/joker-eph closed https://github.com/llvm/llvm-project/pull/66401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [MLIR] Pass hostShared flag in gpu.alloc op to runtime wrappers (PR #66401)

2023-09-26 Thread Mehdi Amini via cfe-commits
https://github.com/joker-eph closed https://github.com/llvm/llvm-project/pull/66401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Adopt `FileEntryRef` in the `HeaderFileInfo` block in PCM files (PR #67383)

2023-09-26 Thread Ben Langmuir via cfe-commits
https://github.com/benlangmuir edited https://github.com/llvm/llvm-project/pull/67383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Adopt `FileEntryRef` in the `HeaderFileInfo` block in PCM files (PR #67383)

2023-09-26 Thread Ben Langmuir via cfe-commits
https://github.com/benlangmuir approved this pull request. https://github.com/llvm/llvm-project/pull/67383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Adopt `FileEntryRef` in the `HeaderFileInfo` block in PCM files (PR #67383)

2023-09-26 Thread Ben Langmuir via cfe-commits
@@ -612,24 +612,21 @@ FileManager::getNoncachedStatValue(StringRef Path, } void FileManager::GetUniqueIDMapping( -SmallVectorImpl &UIDToFiles) const { +SmallVectorImpl &UIDToFiles) const { UIDToFiles.clear(); UIDToFiles.resize(NextFileUID); - // Map file entri

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

2023-09-26 Thread Nick Desaulniers via cfe-commits
@@ -3176,6 +3178,11 @@ def err_alignas_underaligned : Error< "requested alignment is less than minimum alignment of %1 for type %0">; def warn_aligned_attr_underaligned : Warning, InGroup; +def err_ctor_dtor_attr_on_non_void_func : Error< + "%0 attribute can only be applie

[PATCH] D145214: [TSAN] add support for riscv64

2023-09-26 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka accepted this revision. vitalybuka added inline comments. Comment at: compiler-rt/lib/tsan/rtl/CMakeLists.txt:5 append_list_if(COMPILER_RT_HAS_MSSE4_2_FLAG -msse4.2 TSAN_RTL_CFLAGS) -append_list_if(SANITIZER_LIMIT_FRAME_SIZE -Wframe-larger-than=530 +append_list_if(SAN

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

2023-09-26 Thread Nick Desaulniers via cfe-commits
nickdesaulniers wrote: ah, yeah I was curious about what precisely `reserved for the implementation` meant. System libraries? That means they should be able to opt out via `-Wno-whatever`. For anything thats */test/*, I assume they can be adjusted to just not use a reserved priority? https:/

[clang] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

2023-09-26 Thread Nick Desaulniers via cfe-commits
@@ -574,8 +574,8 @@ class X86InstrInfo final : public X86GenInstrInfo { outliner::Candidate &C) const override; void buildClearRegister(Register Reg, MachineBasicBlock &MBB, - MachineBasicBlock::iterator Iter, -

[clang-tools-extra] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

2023-09-26 Thread Nick Desaulniers via cfe-commits
@@ -574,8 +574,8 @@ class X86InstrInfo final : public X86GenInstrInfo { outliner::Candidate &C) const override; void buildClearRegister(Register Reg, MachineBasicBlock &MBB, - MachineBasicBlock::iterator Iter, -

[clang] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

2023-09-26 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers resolved https://github.com/llvm/llvm-project/pull/67193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

2023-09-26 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers resolved https://github.com/llvm/llvm-project/pull/67193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

2023-09-26 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers unresolved https://github.com/llvm/llvm-project/pull/67193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

2023-09-26 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers unresolved https://github.com/llvm/llvm-project/pull/67193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D145214: [TSAN] add support for riscv64

2023-09-26 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay accepted this revision. MaskRay added a comment. Other than -Wframe-larger-than=656 and `const uptr indicator = 0x0f00ull;` changes, others looks good to me. I agree that this should be reviewed by @dvyukov :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D157913: [Coverage] Allow Clang coverage to be used with debug info correlation.

2023-09-26 Thread Petr Hosek via Phabricator via cfe-commits
phosek added a comment. We've been investigating a serious performance regression in our latest Clang roll that is affecting coverage. Whereas previously, we could process all coverage data in under an hour, now the job times out after 6 hours. After investigation, I found out that this change

[PATCH] D148654: Modify BoundsSan to improve debuggability

2023-09-26 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka resigned from this revision. vitalybuka added a comment. I assume we moved to https://github.com/llvm/llvm-project/pull/65972 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148654/new/ https://reviews.llvm.org/D148654 ___

[clang] [clang][modules] Adopt `FileEntryRef` in the `HeaderFileInfo` block in PCM files (PR #67383)

2023-09-26 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 edited https://github.com/llvm/llvm-project/pull/67383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add bugprone-move-shared-pointer-contents check. (PR #67467)

2023-09-26 Thread via cfe-commits
https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/67467 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add bugprone-move-shared-pointer-contents check. (PR #67467)

2023-09-26 Thread via cfe-commits
https://github.com/5chmidti commented: I noticed a problem with your matcher, so I reviewed the rest of it while I was at it. The problem is that you do not consider a type-dependent `std::shared_ptr` and the following test case fails: ```c++ template void dependentType() { std::shared_ptr

[clang-tools-extra] [clang-tidy] Add bugprone-move-shared-pointer-contents check. (PR #67467)

2023-09-26 Thread via cfe-commits
@@ -0,0 +1,37 @@ +//===--- MoveSharedPointerContentsCheck.h - clang-tidy --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-tidy] Add bugprone-move-shared-pointer-contents check. (PR #67467)

2023-09-26 Thread via cfe-commits
@@ -0,0 +1,60 @@ +//===--- MoveSharedPointerContentsCheck.cpp - clang-tidy --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-tidy] Add bugprone-move-shared-pointer-contents check. (PR #67467)

2023-09-26 Thread via cfe-commits
@@ -0,0 +1,60 @@ +//===--- MoveSharedPointerContentsCheck.cpp - clang-tidy --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-tidy] Add bugprone-move-shared-pointer-contents check. (PR #67467)

2023-09-26 Thread via cfe-commits
@@ -0,0 +1,60 @@ +//===--- MoveSharedPointerContentsCheck.cpp - clang-tidy --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [X86] Change target of __builtin_ia32_cmp[p|s][s|d] from avx into sse/sse2 (PR #67410)

2023-09-26 Thread Freddy Ye via cfe-commits
@@ -4742,6 +4742,125 @@ static __inline__ __m128d __DEFAULT_FN_ATTRS _mm_castsi128_pd(__m128i __a) { return (__m128d)__a; } +/// Compares each of the corresponding double-precision values of two +///128-bit vectors of [2 x double], using the operation specified by the +

[clang] Change all CHECK lines in test to include DAG to work when the compiler emits debug info in a different order. (PR #67503)

2023-09-26 Thread via cfe-commits
https://github.com/dyung created https://github.com/llvm/llvm-project/pull/67503 When the changes in f8aab28 were merged into our downstream compiler, it started failing because the compiler with our downstream patches applied was emitting the debug information in a different order than origina

[clang] Change all CHECK lines in test to include DAG to work when the compiler emits debug info in a different order. (PR #67503)

2023-09-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes When the changes in f8aab28 were merged into our downstream compiler, it started failing because the compiler with our downstream patches applied was emitting the debug information in a different order than originally expected. The debug

[clang-tools-extra] [libc++] Implement ranges::contains_subrange (PR #66963)

2023-09-26 Thread via cfe-commits
https://github.com/ZijunZhaoCCK updated https://github.com/llvm/llvm-project/pull/66963 >From 5a2c930770cf548c5e3f3451e76b48cb067e6762 Mon Sep 17 00:00:00 2001 From: Zijun Zhao Date: Wed, 13 Sep 2023 14:26:01 -0700 Subject: [PATCH 1/4] [libc++] Implement ranges::contains_subrange --- libcxx/i

[clang] [libc++] Implement ranges::contains_subrange (PR #66963)

2023-09-26 Thread via cfe-commits
https://github.com/ZijunZhaoCCK resolved https://github.com/llvm/llvm-project/pull/66963 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc++] Implement ranges::contains_subrange (PR #66963)

2023-09-26 Thread via cfe-commits
https://github.com/ZijunZhaoCCK resolved https://github.com/llvm/llvm-project/pull/66963 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc++] Implement ranges::contains_subrange (PR #66963)

2023-09-26 Thread via cfe-commits
https://github.com/ZijunZhaoCCK resolved https://github.com/llvm/llvm-project/pull/66963 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Default x86_64's medium code model -mlarge-data-threshold to 65535 (PR #67506)

2023-09-26 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks created https://github.com/llvm/llvm-project/pull/67506 This matches gcc. See https://discourse.llvm.org/t/rfc-matching-gccs-mlarge-data-threshold-for-x86-64s-medium-code-model/73727. >From b406b086709a1f5012aa444bc7774962c82c4f30 Mon Sep 17 00:00:00 2001 From: Ar

[clang] [clang] Default x86_64's medium code model -mlarge-data-threshold to 65535 (PR #67506)

2023-09-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes This matches gcc. See https://discourse.llvm.org/t/rfc-matching-gccs-mlarge-data-threshold-for-x86-64s-medium-code-model/73727. --- Full diff: https://github.com/llvm/llvm-project/pull/67506.diff 2 Files Affected: - (modified) clang/i

[clang-tools-extra] [libc++] Implement ranges::contains_subrange (PR #66963)

2023-09-26 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 2f2319cf2406d9830a331cbf015881c55ae78806 5f33fa63e76b5d0c066773113447749c3428aa99 --

[clang] [libc++] Implement ranges::contains_subrange (PR #66963)

2023-09-26 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 2f2319cf2406d9830a331cbf015881c55ae78806 5f33fa63e76b5d0c066773113447749c3428aa99 --

[clang] Introduce paged vector (PR #66430)

2023-09-26 Thread Richard Smith via cfe-commits
https://github.com/zygoloid unresolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-26 Thread Richard Smith via cfe-commits
https://github.com/zygoloid resolved https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

2023-09-26 Thread NagaChaitanya Vellanki via Phabricator via cfe-commits
chaitanyav added a comment. Bootstrapping build failed due to -werror flag (https://buildkite.com/llvm-project/libcxx-ci/builds/30031) | /home/libcxx-builder/.buildkite-agent/builds/google-libcxx-builder-4613821dc47f-1/llvm-project/libcxx-ci/libcxx/test/std/containers/unord/unord.multiset/eq

[clang] 491b281 - [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

2023-09-26 Thread Takuya Shimizu via cfe-commits
Author: Takuya Shimizu Date: 2023-09-27T09:26:06+09:00 New Revision: 491b2810fb7fe5f080fa9c4f5945ed0a6909dc92 URL: https://github.com/llvm/llvm-project/commit/491b2810fb7fe5f080fa9c4f5945ed0a6909dc92 DIFF: https://github.com/llvm/llvm-project/commit/491b2810fb7fe5f080fa9c4f5945ed0a6909dc92.diff

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

2023-09-26 Thread Takuya Shimizu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG491b2810fb7f: [clang][SemaCXX] Diagnose tautological uses of consteval if and… (authored by hazohelet). Changed prior to commit: https://reviews.l

[libunwind] [libunwind][nfc] Avoid type warning of debug printf (PR #67390)

2023-09-26 Thread Kazushi Marukawa via cfe-commits
kaz7 wrote: @arichardson Thank for your kind comment. I confused them already. I update my patch following your 2nd suggestion. https://github.com/llvm/llvm-project/pull/67390 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[libunwind] [libunwind][nfc] Avoid type warning of debug printf (PR #67390)

2023-09-26 Thread Kazushi Marukawa via cfe-commits
https://github.com/kaz7 updated https://github.com/llvm/llvm-project/pull/67390 >From 18e3568db4a3a11c794f077e9effd0a713dbd2dc Mon Sep 17 00:00:00 2001 From: "Kazushi (Jam) Marukawa" Date: Sun, 24 Sep 2023 08:08:24 +0200 Subject: [PATCH 1/2] [libunwind][nfc] Avoid type warning of debug printf A

[libunwind] [libunwind][nfc] Avoid type warning of debug printf (PR #67390)

2023-09-26 Thread Kazushi Marukawa via cfe-commits
https://github.com/kaz7 edited https://github.com/llvm/llvm-project/pull/67390 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind][nfc] Avoid type warning of debug printf (PR #67390)

2023-09-26 Thread Kazushi Marukawa via cfe-commits
kaz7 wrote: Update the top comment to describe what I modify. https://github.com/llvm/llvm-project/pull/67390 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D159483: [Modules] Add a flag to control builtin headers being in system modules

2023-09-26 Thread Michael Spencer via Phabricator via cfe-commits
Bigcheese accepted this revision. Bigcheese added a comment. This revision is now accepted and ready to land. The implementation of this change looks good. I share the concern that changing the default may break other users, but that's easily remedied and this is the correct default. It would be

[clang] Introduce paged vector (PR #66430)

2023-09-26 Thread Richard Smith via cfe-commits
@@ -0,0 +1,320 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

2023-09-26 Thread Richard Smith via cfe-commits
@@ -0,0 +1,320 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

2023-09-26 Thread Richard Smith via cfe-commits
@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

2023-09-26 Thread Richard Smith via cfe-commits
@@ -0,0 +1,320 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

2023-09-26 Thread Richard Smith via cfe-commits
@@ -0,0 +1,320 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

2023-09-26 Thread Richard Smith via cfe-commits
@@ -0,0 +1,320 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

2023-09-26 Thread Richard Smith via cfe-commits
@@ -0,0 +1,320 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

2023-09-26 Thread Richard Smith via cfe-commits
@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

2023-09-26 Thread Richard Smith via cfe-commits
@@ -0,0 +1,322 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

2023-09-26 Thread Richard Smith via cfe-commits
@@ -0,0 +1,320 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[libunwind] [libunwind][nfc] Avoid type warning of debug printf (PR #67390)

2023-09-26 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson approved this pull request. Change LGTM assuming CI is also happy. https://github.com/llvm/llvm-project/pull/67390 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[clang] 4d5d9a5 - Revert "[Coverage] Allow Clang coverage to be used with debug info correlation."

2023-09-26 Thread Zequan Wu via cfe-commits
Author: Zequan Wu Date: 2023-09-26T20:57:09-04:00 New Revision: 4d5d9a539058c87b42b472daedfb95377f5e1612 URL: https://github.com/llvm/llvm-project/commit/4d5d9a539058c87b42b472daedfb95377f5e1612 DIFF: https://github.com/llvm/llvm-project/commit/4d5d9a539058c87b42b472daedfb95377f5e1612.diff LOG

[clang-tools-extra] [libcxx] Allow string to use SSO in constant evaluation. (PR #66576)

2023-09-26 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/66576 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libcxx] Allow string to use SSO in constant evaluation. (PR #66576)

2023-09-26 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik commented: I think this is fine but I agree we should have a compat warning for this and I would like to see more testing as well. https://github.com/llvm/llvm-project/pull/66576 ___ cfe-commits mailing list cfe-commits@lists

[clang] [libcxx] Allow string to use SSO in constant evaluation. (PR #66576)

2023-09-26 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/66576 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libcxx] Allow string to use SSO in constant evaluation. (PR #66576)

2023-09-26 Thread Shafik Yaghmour via cfe-commits
@@ -0,0 +1,22 @@ +//===--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[clang] [Clang] Fix crash when visting a fold expression in a default argument (PR #67514)

2023-09-26 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik created https://github.com/llvm/llvm-project/pull/67514 CheckDefaultArgumentVisitor::Visit(...) assumes that the children of Expr will not be NULL. This is not a valid assumption and when we have a CXXFoldExpr the children can be NULL and this causes a crash. Fixes:

[clang] [Clang] Fix crash when visting a fold expression in a default argument (PR #67514)

2023-09-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes CheckDefaultArgumentVisitor::Visit(...) assumes that the children of Expr will not be NULL. This is not a valid assumption and when we have a CXXFoldExpr the children can be NULL and this causes a crash. Fixes: https://github.com/llvm/llv

[PATCH] D144136: Add a "remark" to report on array accesses

2023-09-26 Thread Kees Cook via Phabricator via cfe-commits
kees added a comment. In D144136#4651030 , @void wrote: > or can it be simplified into something like this: > > array-bounds.c:341:2: remark: accessing flexible array, counted by 'count', > with 'index - 1' [-Rarray-bounds] > 341 | TEST_AC

<    1   2   3   4   5   >