[clang] [clang][Interp] Add IntegralAP for arbitrary-precision integers (PR #65844)

2023-09-26 Thread Erich Keane via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: @@ -0,0 +1,249 @@ +//===--- Integral.h - Wrapper for numeric types for the VM --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exce

[clang] [clang][Interp] Add IntegralAP for arbitrary-precision integers (PR #65844)

2023-09-26 Thread Erich Keane via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: @@ -0,0 +1,249 @@ +//===--- Integral.h - Wrapper for numeric types for the VM --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exce

[clang] [clang] Fix pretty-printing assume_aligned attributes (PR #67331)

2023-09-26 Thread Erich Keane via cfe-commits
@@ -320,11 +320,12 @@ namespace { } std::string getIsOmitted() const override { - if (type == "IdentifierInfo *") + StringRef T = type; + if (T == "IdentifierInfo *" || T == "Expr *") return "!get" + getUpperName().str() + "()"; - if (type

[clang] [clang] Fix pretty-printing assume_aligned attributes (PR #67331)

2023-09-26 Thread Erich Keane via cfe-commits
erichkeane wrote: Also, it appears that the clang-format bot dislikes this commit (but frustratingly won't tell us why?), so perhaps run `git clang-format against all the commits here` https://github.com/llvm/llvm-project/pull/67331 ___ cfe-commits m

[clang] [clang][Interp] Add IntegralAP for arbitrary-precision integers (PR #65844)

2023-09-26 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: @@ -1596,6 +1599,9 @@ bool ByteCodeExprGen::visitZeroInitializer(QualType QT, return this->emitZeroSint64(E); case PT_Uint64: return this->emitZeroUint64(E); + case

[clang] [clang][Interp] Add IntegralAP for arbitrary-precision integers (PR #65844)

2023-09-26 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: @@ -0,0 +1,249 @@ +//===--- Integral.h - Wrapper for numeric types for the VM --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exce

[clang] [clang][Interp] Add IntegralAP for arbitrary-precision integers (PR #65844)

2023-09-26 Thread Timm Baeder via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: @@ -0,0 +1,249 @@ +//===--- Integral.h - Wrapper for numeric types for the VM --*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exce

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

2023-09-26 Thread Erich Keane via cfe-commits
@@ -171,6 +171,11 @@ Attribute Changes in Clang automatic diagnostic to use parameters of types that the format style supports but that are never the result of default argument promotion, such as ``float``. (`#59824: `_)

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

2023-09-26 Thread Erich Keane via cfe-commits
erichkeane wrote: > runtime, whereas a `consteval` one cannot. WDYT? This makes sense to me. Also, see my comment on https://github.com/llvm/llvm-project/pull/67376. It looks like someone else is messing with this area as well, and are editing things in an incompatible way, so we should mak

[libunwind] [libunwind][nfc] Avoid type warning of debug printf (PR #67390)

2023-09-26 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson commented: Could also use %p instead of `0x% Pri*`and cast the `uintptr_t` to `void *`? That would avoid the need for the new macros. https://github.com/llvm/llvm-project/pull/67390 ___ cfe-commits mailing list cfe-commi

[libunwind] [libunwind][nfc] Avoid type warning of debug printf (PR #67390)

2023-09-26 Thread Alexander Richardson via cfe-commits
arichardson wrote: Or alternatively use PRIxPTR unconditionally, using PRIuPTR with 0x-prefixed outputs is super confusing https://github.com/llvm/llvm-project/pull/67390 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[clang] Introduce paged vector (PR #66430)

2023-09-26 Thread Giulio Eulisse via cfe-commits
@@ -0,0 +1,323 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

2023-09-26 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman updated https://github.com/llvm/llvm-project/pull/67360 >From 6e9bcfa7fc5eb3da4592909b9e199215064df700 Mon Sep 17 00:00:00 2001 From: Aaron Ballman Date: Mon, 25 Sep 2023 15:03:56 -0400 Subject: [PATCH 1/2] Diagnose problematic uses of constructor/destructor att

[clang] [clang] Fix pretty-printing assume_aligned attributes (PR #67331)

2023-09-26 Thread Balazs Benics via cfe-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/67331 >From 988dcf4f568a58d9b1127b2adf8890a7c7867ac5 Mon Sep 17 00:00:00 2001 From: Balazs Benics Date: Mon, 25 Sep 2023 15:37:34 +0200 Subject: [PATCH 1/2] [clang] Fix pretty-printing assume_aligned attributes Insid

[clang] [clang] Fix pretty-printing assume_aligned attributes (PR #67331)

2023-09-26 Thread Balazs Benics via cfe-commits
@@ -320,11 +320,12 @@ namespace { } std::string getIsOmitted() const override { - if (type == "IdentifierInfo *") + StringRef T = type; + if (T == "IdentifierInfo *" || T == "Expr *") return "!get" + getUpperName().str() + "()"; - if (type

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

2023-09-26 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > > runtime, whereas a `consteval` one cannot. WDYT? > > This makes sense to me. Also, see my comment on #67376. It looks like someone > else is messing with this area as well, and are editing things in an > incompatible way, so we should make sure that these don't conflict

[clang] [clang] Fix pretty-printing assume_aligned attributes (PR #67331)

2023-09-26 Thread Balazs Benics via cfe-commits
steakhal wrote: > Also, it appears that the clang-format bot dislikes this commit (but > frustratingly won't tell us why?), so perhaps run `git clang-format against > all the commits here` Yup, I have it on save already. It complains about lines I never touched. As per guidelines, I only run c

[clang] [clang] Fix pretty-printing assume_aligned attributes (PR #67331)

2023-09-26 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/67331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D145214: [TSAN] add support for riscv64

2023-09-26 Thread Alex Fan via Phabricator via cfe-commits
alexfanqi updated this revision to Diff 557362. alexfanqi added a comment. thanks @hiraditya Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145214/new/ https://reviews.llvm.org/D145214 Files: clang/lib/Driver/ToolChains/Linux.cpp compiler-rt/cm

[clang] [clang] Fix pretty-printing assume_aligned attributes (PR #67331)

2023-09-26 Thread Balazs Benics via cfe-commits
https://github.com/steakhal resolved https://github.com/llvm/llvm-project/pull/67331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix pretty-printing assume_aligned attributes (PR #67331)

2023-09-26 Thread Balazs Benics via cfe-commits
https://github.com/steakhal resolved https://github.com/llvm/llvm-project/pull/67331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix pretty-printing assume_aligned attributes (PR #67331)

2023-09-26 Thread Balazs Benics via cfe-commits
steakhal wrote: Thanks for the review @erichkeane! https://github.com/llvm/llvm-project/pull/67331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

2023-09-26 Thread Aaron Ballman via cfe-commits
@@ -171,6 +171,11 @@ Attribute Changes in Clang automatic diagnostic to use parameters of types that the format style supports but that are never the result of default argument promotion, such as ``float``. (`#59824: `_)

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

2023-09-26 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 8586cd5ad8a7fa4f84b5913cbeaf634d68500095 5c9509d2765f2cc803757b2d151a672f8571ab15 --

[clang] [clang][dataflow] Show triangle in `` element. (PR #67431)

2023-09-26 Thread via cfe-commits
https://github.com/martinboehme created https://github.com/llvm/llvm-project/pull/67431 Also, change the mouse cursor into a pointer instead of a text cursor. This makes it more discoverable that the element can be opened and closed. >From fe52a064d08bb9e328eafe70ddd7edf21931408e Mon Sep 17 0

[clang] [clang][dataflow] Show triangle in `` element. (PR #67431)

2023-09-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-analysis Changes Also, change the mouse cursor into a pointer instead of a text cursor. This makes it more discoverable that the element can be opened and closed. --- Full diff: https://github.com/llvm/llvm-project/pull/67431.diff 2 Files Affec

[clang] [clang][dataflow] Show triangle in `` element. (PR #67431)

2023-09-26 Thread via cfe-commits
@@ -122,10 +122,22 @@ code.line:has(.bb-select):before { font-size: x-small; flex-grow: 1; } -.value summary { +.value > summary { martinboehme wrote: Figured I would change this too for consistency. (And maybe it's also more efficient?) https://github.c

[clang] [clang][dataflow] Show triangle in `` element. (PR #67431)

2023-09-26 Thread via cfe-commits
@@ -122,10 +122,22 @@ code.line:has(.bb-select):before { font-size: x-small; flex-grow: 1; } -.value summary { +.value > summary { background-color: #ace; display: flex; justify-content: space-between; + cursor: pointer; +} +.value > summary::before { + content:

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

2023-09-26 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman updated https://github.com/llvm/llvm-project/pull/67360 >From 6e9bcfa7fc5eb3da4592909b9e199215064df700 Mon Sep 17 00:00:00 2001 From: Aaron Ballman Date: Mon, 25 Sep 2023 15:03:56 -0400 Subject: [PATCH 1/3] Diagnose problematic uses of constructor/destructor att

[libunwind] b29b6cc - Revert "[libunwind] Relax a REQUIRES on a test that passes on FreeBSD"

2023-09-26 Thread Alex Richardson via cfe-commits
Author: Alex Richardson Date: 2023-09-26T07:15:39-07:00 New Revision: b29b6ccc4e5abb301a8bab037069f0a9b097b247 URL: https://github.com/llvm/llvm-project/commit/b29b6ccc4e5abb301a8bab037069f0a9b097b247 DIFF: https://github.com/llvm/llvm-project/commit/b29b6ccc4e5abb301a8bab037069f0a9b097b247.dif

[clang] Introduce paged vector (PR #66430)

2023-09-26 Thread Giulio Eulisse via cfe-commits
ktf wrote: Ping @vgvassilev. I think all the comments you had have been addressed. Could you have a look again? https://github.com/llvm/llvm-project/pull/66430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[clang] 78d649a - [libc++][lit] Allow overriding the executor for tests (#66545)

2023-09-26 Thread via cfe-commits
Author: Alexander Richardson Date: 2023-09-26T15:19:31+01:00 New Revision: 78d649a417b48cb8a2ba2e755f0e7c8fb8b1bb83 URL: https://github.com/llvm/llvm-project/commit/78d649a417b48cb8a2ba2e755f0e7c8fb8b1bb83 DIFF: https://github.com/llvm/llvm-project/commit/78d649a417b48cb8a2ba2e755f0e7c8fb8b1bb8

[clang] [libc++][lit] Allow overriding the executor for tests (PR #66545)

2023-09-26 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson closed https://github.com/llvm/llvm-project/pull/66545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] 78d649a - [libc++][lit] Allow overriding the executor for tests (#66545)

2023-09-26 Thread via cfe-commits
Author: Alexander Richardson Date: 2023-09-26T15:19:31+01:00 New Revision: 78d649a417b48cb8a2ba2e755f0e7c8fb8b1bb83 URL: https://github.com/llvm/llvm-project/commit/78d649a417b48cb8a2ba2e755f0e7c8fb8b1bb83 DIFF: https://github.com/llvm/llvm-project/commit/78d649a417b48cb8a2ba2e755f0e7c8fb8b1bb8

[clang] [libc++][lit] Allow overriding the executor for tests (PR #66545)

2023-09-26 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson resolved https://github.com/llvm/llvm-project/pull/66545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D145214: [TSAN] add support for riscv64

2023-09-26 Thread Alex Fan via Phabricator via cfe-commits
alexfanqi added a comment. In D145214#4650189 , @hiraditya wrote: > I tested it on a licheepi board (riscv64 debian) and all the tests modified > in this patch have passed. LGTM. Can you help me land this patch? > There are other tsan failures but i th

[clang] [clang][modules] Adopt `FileEntryRef` in the `HeaderFileInfo` block in PCM files (PR #67383)

2023-09-26 Thread Richard Howell via cfe-commits
rmaz wrote: LGTM, possible to come up with some test case with multiple virtual entries to the same file that would now be serialized once? https://github.com/llvm/llvm-project/pull/67383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[clang] [InstCombine] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

2023-09-26 Thread Alexander Richardson via cfe-commits
@@ -6397,6 +6397,48 @@ static Value *simplifyBinaryIntrinsic(Function *F, Value *Op0, Value *Op1, return Constant::getNullValue(ReturnType); break; } + case Intrinsic::ptrmask: { +// Fail loudly in case this is ever changed. +// TODO: If vector types are s

[clang] [InstCombine] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

2023-09-26 Thread Nikita Popov via cfe-commits
@@ -6397,6 +6397,48 @@ static Value *simplifyBinaryIntrinsic(Function *F, Value *Op0, Value *Op1, return Constant::getNullValue(ReturnType); break; } + case Intrinsic::ptrmask: { +// Fail loudly in case this is ever changed. +// TODO: If vector types are s

[clang] [InstCombine] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

2023-09-26 Thread Nikita Popov via cfe-commits
https://github.com/nikic resolved https://github.com/llvm/llvm-project/pull/67166 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [InstCombine] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

2023-09-26 Thread Alexander Richardson via cfe-commits
@@ -6397,6 +6397,48 @@ static Value *simplifyBinaryIntrinsic(Function *F, Value *Op0, Value *Op1, return Constant::getNullValue(ReturnType); break; } + case Intrinsic::ptrmask: { +// Fail loudly in case this is ever changed. +// TODO: If vector types are s

[clang] Introduce paged vector (PR #66430)

2023-09-26 Thread Vassil Vassilev via cfe-commits
@@ -0,0 +1,323 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

2023-09-26 Thread Vassil Vassilev via cfe-commits
@@ -0,0 +1,323 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

2023-09-26 Thread Vassil Vassilev via cfe-commits
@@ -1625,6 +1625,39 @@ SmallVector has grown a few other minor advantages over std::vector, causing and is no longer "private to the implementation". A name like ``SmallVectorHeader`` might be more appropriate. +.. _dss_pagedvector: + +llvm/ADT/PagedVector.h +^^

[clang] Introduce paged vector (PR #66430)

2023-09-26 Thread Vassil Vassilev via cfe-commits
@@ -0,0 +1,323 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

2023-09-26 Thread Vassil Vassilev via cfe-commits
@@ -0,0 +1,323 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

2023-09-26 Thread Vassil Vassilev via cfe-commits
@@ -0,0 +1,323 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] [InstCombine] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

2023-09-26 Thread Nikita Popov via cfe-commits
https://github.com/nikic resolved https://github.com/llvm/llvm-project/pull/67166 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [InstCombine] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

2023-09-26 Thread Nikita Popov via cfe-commits
@@ -898,6 +910,53 @@ Value *InstCombinerImpl::SimplifyDemandedUseBits(Value *V, APInt DemandedMask, } break; } + case Intrinsic::ptrmask: { +// Fail loudly in case this is ever changed. +// Likely not much needs to be changed here to

[clang] [InstCombine] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

2023-09-26 Thread Nikita Popov via cfe-commits
https://github.com/nikic resolved https://github.com/llvm/llvm-project/pull/67166 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [InstCombine] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

2023-09-26 Thread Nikita Popov via cfe-commits
https://github.com/nikic resolved https://github.com/llvm/llvm-project/pull/67166 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Moving TaintPropagation checker out of alpha (PR #67352)

2023-09-26 Thread via cfe-commits
DonatNagyE wrote: I agree that it's a blocking issue that some numerical arguments act as taint sinks unconditionally (even if the analyzer knows about constraints that show that the actual value is valid). I'd suggest that those concrete issues should be addressed by separate improvement comm

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

2023-09-26 Thread Aaron Ballman via cfe-commits
@@ -171,6 +171,11 @@ Attribute Changes in Clang automatic diagnostic to use parameters of types that the format style supports but that are never the result of default argument promotion, such as ``float``. (`#59824: `_)

[clang] [InstCombine] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

2023-09-26 Thread Nikita Popov via cfe-commits
@@ -6397,6 +6397,48 @@ static Value *simplifyBinaryIntrinsic(Function *F, Value *Op0, Value *Op1, return Constant::getNullValue(ReturnType); break; } + case Intrinsic::ptrmask: { +// Fail loudly in case this is ever changed. +// TODO: If vector types are s

[clang] [InstCombine] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

2023-09-26 Thread Nikita Popov via cfe-commits
@@ -6397,6 +6397,48 @@ static Value *simplifyBinaryIntrinsic(Function *F, Value *Op0, Value *Op1, return Constant::getNullValue(ReturnType); break; } + case Intrinsic::ptrmask: { +// Fail loudly in case this is ever changed. +// TODO: If vector types are s

[clang] Introduce paged vector (PR #66430)

2023-09-26 Thread Vassil Vassilev via cfe-commits
@@ -699,7 +700,7 @@ class SourceManager : public RefCountedBase { /// /// Negative FileIDs are indexes into this table. To get from ID to an index, /// use (-ID - 2). - SmallVector LoadedSLocEntryTable; + llvm::PagedVector LoadedSLocEntryTable; vgvassil

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

2023-09-26 Thread Erich Keane via cfe-commits
@@ -171,6 +171,11 @@ Attribute Changes in Clang automatic diagnostic to use parameters of types that the format style supports but that are never the result of default argument promotion, such as ``float``. (`#59824: `_)

[clang] 3caedfd - [clang] Fix pretty-printing assume_aligned attributes (#67331)

2023-09-26 Thread via cfe-commits
Author: Balazs Benics Date: 2023-09-26T16:55:04+02:00 New Revision: 3caedfd1f2f012738fbd86008e190b95673e605c URL: https://github.com/llvm/llvm-project/commit/3caedfd1f2f012738fbd86008e190b95673e605c DIFF: https://github.com/llvm/llvm-project/commit/3caedfd1f2f012738fbd86008e190b95673e605c.diff

[clang] [clang] Fix pretty-printing assume_aligned attributes (PR #67331)

2023-09-26 Thread Balazs Benics via cfe-commits
https://github.com/steakhal closed https://github.com/llvm/llvm-project/pull/67331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Introduce paged vector (PR #66430)

2023-09-26 Thread Vassil Vassilev via cfe-commits
@@ -501,7 +502,7 @@ class ASTReader /// /// When the pointer at index I is non-NULL, the declaration with ID /// = I + 1 has already been loaded. - std::vector DeclsLoaded; + llvm::PagedVector DeclsLoaded; vgvassilev wrote: @zygoloid, @ChuanqiXu9 shoul

[clang] [InstCombine] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

2023-09-26 Thread Alexander Richardson via cfe-commits
@@ -6397,6 +6397,48 @@ static Value *simplifyBinaryIntrinsic(Function *F, Value *Op0, Value *Op1, return Constant::getNullValue(ReturnType); break; } + case Intrinsic::ptrmask: { +// Fail loudly in case this is ever changed. +// TODO: If vector types are s

[clang] [InstCombine] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

2023-09-26 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson edited https://github.com/llvm/llvm-project/pull/67166 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [InstCombine] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

2023-09-26 Thread Alexander Richardson via cfe-commits
@@ -6397,6 +6397,48 @@ static Value *simplifyBinaryIntrinsic(Function *F, Value *Op0, Value *Op1, return Constant::getNullValue(ReturnType); break; } + case Intrinsic::ptrmask: { +// Fail loudly in case this is ever changed. +// TODO: If vector types are s

[clang] [InstCombine] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

2023-09-26 Thread Alexander Richardson via cfe-commits
https://github.com/arichardson resolved https://github.com/llvm/llvm-project/pull/67166 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][ObjC] Add optionality to property attribute strings. (PR #66507)

2023-09-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes Add a new attribute, "?", to the property attribute string for properties of protocols that are declared @optional. (Previously https://reviews.llvm.org/D135273) rdar://100463524 --- Full diff: https://github.com/llvm/llvm-project/pull/6

[clang] 06f10b8 - [Clang][ObjC] Add optionality to property attribute strings. (#66507)

2023-09-26 Thread via cfe-commits
Author: Alastair Houghton Date: 2023-09-26T08:30:31-07:00 New Revision: 06f10b80847a75b9329174fa7eb0388e214eb19b URL: https://github.com/llvm/llvm-project/commit/06f10b80847a75b9329174fa7eb0388e214eb19b DIFF: https://github.com/llvm/llvm-project/commit/06f10b80847a75b9329174fa7eb0388e214eb19b.d

[clang] [Clang][ObjC] Add optionality to property attribute strings. (PR #66507)

2023-09-26 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs closed https://github.com/llvm/llvm-project/pull/66507 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][ObjC] Add optionality to property attribute strings. (PR #66507)

2023-09-26 Thread Alastair Houghton via cfe-commits
https://github.com/al45tair edited https://github.com/llvm/llvm-project/pull/66507 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

2023-09-26 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman updated https://github.com/llvm/llvm-project/pull/67360 >From 6e9bcfa7fc5eb3da4592909b9e199215064df700 Mon Sep 17 00:00:00 2001 From: Aaron Ballman Date: Mon, 25 Sep 2023 15:03:56 -0400 Subject: [PATCH 1/4] Diagnose problematic uses of constructor/destructor att

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

2023-09-26 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman resolved https://github.com/llvm/llvm-project/pull/67360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

2023-09-26 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman resolved https://github.com/llvm/llvm-project/pull/67360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

2023-09-26 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. Do we have a codegen test for the constexpr case? I'm concerned that we don't 'force' emission of these functions . Either way, I think this set of diagnostic changes makes sense. https://github.com/llvm/llvm-project/pull/67360 ___

[clang] [InstCombine] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

2023-09-26 Thread via cfe-commits
@@ -6397,6 +6397,48 @@ static Value *simplifyBinaryIntrinsic(Function *F, Value *Op0, Value *Op1, return Constant::getNullValue(ReturnType); break; } + case Intrinsic::ptrmask: { +// Fail loudly in case this is ever changed. +// TODO: If vector types are s

[clang] [InstCombine] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

2023-09-26 Thread via cfe-commits
https://github.com/goldsteinn edited https://github.com/llvm/llvm-project/pull/67166 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

2023-09-26 Thread Nick Desaulniers via cfe-commits
@@ -574,8 +574,8 @@ class X86InstrInfo final : public X86GenInstrInfo { outliner::Candidate &C) const override; void buildClearRegister(Register Reg, MachineBasicBlock &MBB, - MachineBasicBlock::iterator Iter, -

[clang-tools-extra] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

2023-09-26 Thread Nick Desaulniers via cfe-commits
@@ -9796,27 +9796,34 @@ X86InstrInfo::insertOutlinedCall(Module &M, MachineBasicBlock &MBB, return It; } -void X86InstrInfo::buildClearRegister(Register Reg, - MachineBasicBlock &MBB, +void X86InstrInfo::buildClearRegister(Register Reg,

[clang-tools-extra] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

2023-09-26 Thread Nick Desaulniers via cfe-commits
@@ -9066,21 +9066,18 @@ bool AArch64InstrInfo::shouldOutlineFromFunctionByDefault( void AArch64InstrInfo::buildClearRegister(Register Reg, MachineBasicBlock &MBB, MachineBasicBlock::iterator Iter, -

[clang] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

2023-09-26 Thread Nick Desaulniers via cfe-commits
@@ -574,8 +574,8 @@ class X86InstrInfo final : public X86GenInstrInfo { outliner::Candidate &C) const override; void buildClearRegister(Register Reg, MachineBasicBlock &MBB, - MachineBasicBlock::iterator Iter, -

[clang] [CodeGen] Avoid potential sideeffects from XOR (PR #67193)

2023-09-26 Thread Nick Desaulniers via cfe-commits
@@ -9066,21 +9066,18 @@ bool AArch64InstrInfo::shouldOutlineFromFunctionByDefault( void AArch64InstrInfo::buildClearRegister(Register Reg, MachineBasicBlock &MBB, MachineBasicBlock::iterator Iter, -

[clang] [InstCombine] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

2023-09-26 Thread via cfe-commits
@@ -6397,6 +6397,48 @@ static Value *simplifyBinaryIntrinsic(Function *F, Value *Op0, Value *Op1, return Constant::getNullValue(ReturnType); break; } + case Intrinsic::ptrmask: { +// Fail loudly in case this is ever changed. +// TODO: If vector types are s

[clang] [InstCombine] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

2023-09-26 Thread via cfe-commits
https://github.com/goldsteinn updated https://github.com/llvm/llvm-project/pull/67166 >From f405167577470a3e53fdd9a52fbe90710e5899e4 Mon Sep 17 00:00:00 2001 From: Noah Goldstein Date: Fri, 22 Sep 2023 08:21:21 -0500 Subject: [PATCH 1/9] [InstSimplify] Add tests for simplify `llvm.ptrmask`; NFC

[clang] [InstCombine] Add combines/simplifications for `llvm.ptrmask` (PR #67166)

2023-09-26 Thread Alexander Richardson via cfe-commits
@@ -6397,6 +6397,48 @@ static Value *simplifyBinaryIntrinsic(Function *F, Value *Op0, Value *Op1, return Constant::getNullValue(ReturnType); break; } + case Intrinsic::ptrmask: { +// Fail loudly in case this is ever changed. +// TODO: If vector types are s

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

2023-09-26 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman updated https://github.com/llvm/llvm-project/pull/67360 >From 6e9bcfa7fc5eb3da4592909b9e199215064df700 Mon Sep 17 00:00:00 2001 From: Aaron Ballman Date: Mon, 25 Sep 2023 15:03:56 -0400 Subject: [PATCH 1/5] Diagnose problematic uses of constructor/destructor att

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

2023-09-26 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers edited https://github.com/llvm/llvm-project/pull/67360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

2023-09-26 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers approved this pull request. https://github.com/llvm/llvm-project/pull/67360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

2023-09-26 Thread Nick Desaulniers via cfe-commits
@@ -3176,6 +3178,11 @@ def err_alignas_underaligned : Error< "requested alignment is less than minimum alignment of %1 for type %0">; def warn_aligned_attr_underaligned : Warning, InGroup; +def err_ctor_dtor_attr_on_non_void_func : Error< + "%0 attribute can only be applie

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

2023-09-26 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers edited https://github.com/llvm/llvm-project/pull/67360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

2023-09-26 Thread Aaron Ballman via cfe-commits
@@ -3176,6 +3178,11 @@ def err_alignas_underaligned : Error< "requested alignment is less than minimum alignment of %1 for type %0">; def warn_aligned_attr_underaligned : Warning, InGroup; +def err_ctor_dtor_attr_on_non_void_func : Error< + "%0 attribute can only be applie

[clang] [Clang][HIP] Remove 'clangPostLink' from SDL handling (PR #67366)

2023-09-26 Thread Saiyedul Islam via cfe-commits
https://github.com/saiislam approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/67366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c1afed9 - [Clang][HIP] Remove 'clangPostLink' from SDL handling (#67366)

2023-09-26 Thread via cfe-commits
Author: Joseph Huber Date: 2023-09-26T11:27:38-05:00 New Revision: c1afed9f48c2d4ebb21ac1672948e82d23c69174 URL: https://github.com/llvm/llvm-project/commit/c1afed9f48c2d4ebb21ac1672948e82d23c69174 DIFF: https://github.com/llvm/llvm-project/commit/c1afed9f48c2d4ebb21ac1672948e82d23c69174.diff

[clang] [Clang][HIP] Remove 'clangPostLink' from SDL handling (PR #67366)

2023-09-26 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/67366 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] a42787d - [clang] Add -mlarge-data-threshold for x86_64 medium code model (#66839)

2023-09-26 Thread via cfe-commits
Author: Arthur Eubanks Date: 2023-09-26T09:44:31-07:00 New Revision: a42787d10854fe2fdaca019634aed03adebcb864 URL: https://github.com/llvm/llvm-project/commit/a42787d10854fe2fdaca019634aed03adebcb864 DIFF: https://github.com/llvm/llvm-project/commit/a42787d10854fe2fdaca019634aed03adebcb864.diff

[clang] [clang] Add -mlarge-data-threshold for x86_64 medium code model (PR #66839)

2023-09-26 Thread Arthur Eubanks via cfe-commits
https://github.com/aeubanks closed https://github.com/llvm/llvm-project/pull/66839 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Introduce class RawAddress and modify Address in preparation for adding information to it that is needed for pointer authentication (PR #67454)

2023-09-26 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff c1afed9f48c2d4ebb21ac1672948e82d23c69174 225dbb93be9940535f80982b7c82b55911985d7c --

[clang] [libcxx] Allow string to use SSO in constant evaluation. (PR #66576)

2023-09-26 Thread James Y Knight via cfe-commits
https://github.com/jyknight updated https://github.com/llvm/llvm-project/pull/66576 >From 209a8f9c06a7633737e9f022bc4e61d580ad95e7 Mon Sep 17 00:00:00 2001 From: James Y Knight Date: Sat, 16 Sep 2023 12:32:21 + Subject: [PATCH 1/3] [libcxx] Allow string to use SSO in constant evaluation. P

[clang-tools-extra] [libcxx] Allow string to use SSO in constant evaluation. (PR #66576)

2023-09-26 Thread James Y Knight via cfe-commits
https://github.com/jyknight updated https://github.com/llvm/llvm-project/pull/66576 >From 209a8f9c06a7633737e9f022bc4e61d580ad95e7 Mon Sep 17 00:00:00 2001 From: James Y Knight Date: Sat, 16 Sep 2023 12:32:21 + Subject: [PATCH 1/3] [libcxx] Allow string to use SSO in constant evaluation. P

[clang] b443510 - Diagnose problematic uses of constructor/destructor attribute (#67360)

2023-09-26 Thread via cfe-commits
Author: Aaron Ballman Date: 2023-09-26T12:54:30-04:00 New Revision: b4435104ca3904529723b0673cc0f624cf8c54e6 URL: https://github.com/llvm/llvm-project/commit/b4435104ca3904529723b0673cc0f624cf8c54e6 DIFF: https://github.com/llvm/llvm-project/commit/b4435104ca3904529723b0673cc0f624cf8c54e6.diff

[clang] Diagnose problematic uses of constructor/destructor attribute (PR #67360)

2023-09-26 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/67360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D141192: [Clang] Fix warnings on bad shifts.

2023-09-26 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D141192#4647977 , @budimirarandjelovicsyrmia wrote: > Ping. Given the lack of response, I think it's safe to assume this patch has been abandoned by the author. I'd recommend starting a new patch review for it on GitH

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

2023-09-26 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:267-269 +- Fix segfault while running clang-rename on a non existing file. + (`#36471 `_) +- Fix crash when diagnosing incorrect usage of ``_Nullable``

<    1   2   3   4   5   >