https://github.com/bzEq deleted https://github.com/llvm/llvm-project/pull/66316
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dtcxzyw resolved
https://github.com/llvm/llvm-project/pull/67166
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dtcxzyw resolved
https://github.com/llvm/llvm-project/pull/67166
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
orcguru wrote:
Currently obj mode has one issue: define more than one __thread variable, and
all access return the first variable.
I'm investigating the root cause and will update patch accordingly. ASM mode is
fine.
https://github.com/llvm/llvm-project/pull/66316
__
nridge accepted this revision.
nridge added a comment.
This revision is now accepted and ready to land.
Thank you, the updates look good! Please go ahead and merge after addressing
the last minor nits.
Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:594
+
rjodinchr wrote:
@arsenm Could you review this PR again please?
https://github.com/llvm/llvm-project/pull/66651
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
liaolucy added a comment.
ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158824/new/
https://reviews.llvm.org/D158824
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cg
@@ -5612,6 +5612,10 @@ RValue CodeGenFunction::EmitCall(const CGFunctionInfo
&CallInfo,
BundleList);
EmitBlock(Cont);
}
+ if (CI->getCalledFunction() && CI->getCalledFunction()->hasName() &&
+ CI->getCalledFunction()->getName().startsw
HighCommander4 wrote:
I wonder if `TreeTransform::TransformUserDefinedLiteral()` should be doing
something like `RebuildUserDefinedLiteral()`.
Anyways, the patch looks reasonable to me but someone more familiar with Sema
should review it.
https://github.com/llvm/llvm-project/pull/66641
__
@@ -5612,6 +5612,10 @@ RValue CodeGenFunction::EmitCall(const CGFunctionInfo
&CallInfo,
BundleList);
EmitBlock(Cont);
}
+ if (CI->getCalledFunction() && CI->getCalledFunction()->hasName() &&
+ CI->getCalledFunction()->getName().startsw
tbaeder added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154262/new/
https://reviews.llvm.org/D154262
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
tbaeder added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157252/new/
https://reviews.llvm.org/D157252
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
tbaeder added a comment.
Ping
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D154581/new/
https://reviews.llvm.org/D154581
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tbaeder added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156453/new/
https://reviews.llvm.org/D156453
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
tbaeder added a comment.
Ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158516/new/
https://reviews.llvm.org/D158516
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
https://github.com/jchlanda updated
https://github.com/llvm/llvm-project/pull/66496
>From 9c8caed3c8def15ccdbfdf831f36d0befed1fc84 Mon Sep 17 00:00:00 2001
From: Jakub Chlanda
Date: Fri, 15 Sep 2023 12:08:04 +0100
Subject: [PATCH 1/6] [NVPTX] Add support for maxclusterrank in launch_bounds
Sin
@@ -5607,6 +5607,21 @@ bool Sema::CheckRegparmAttr(const ParsedAttr &AL,
unsigned &numParams) {
return false;
}
+// Helper to get CudaArch.
+static CudaArch getCudaArch(const TargetInfo &TI) {
jchlanda wrote:
Done in: 3c17966b26a613f3b1a117f992d45b751cbff4
@@ -274,8 +288,8 @@ const Stmt *ExprMutationAnalyzer::findDirectMutation(const
Expr *Exp) {
const auto NonConstMethod = cxxMethodDecl(unless(isConst()));
const auto AsNonConstThis = expr(anyOf(
- cxxMemberCallExpr(callee(NonConstMethod),
-on(c
https://github.com/mzyKi edited https://github.com/llvm/llvm-project/pull/66846
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mzyKi edited https://github.com/llvm/llvm-project/pull/66846
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430
>From b5f984b5521c5b226a7c5297d19eb53953481890 Mon Sep 17 00:00:00 2001
From: Giulio Eulisse <10544+...@users.noreply.github.com>
Date: Thu, 14 Sep 2023 21:58:21 +0200
Subject: [PATCH] Introduce PagedVector class
The
@@ -0,0 +1,307 @@
+//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++
+//-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier
https://github.com/ecnelises created
https://github.com/llvm/llvm-project/pull/67298
PowerPC AIX backend does not support float128 at all. Diagnose even when
specifying -mfloat128 to avoid backend crash.
>From 58cd725354eae6aa733c98374a804de0ef595c60 Mon Sep 17 00:00:00 2001
From: Qiu Chaofan
qiucf abandoned this revision.
qiucf added a comment.
Migrated to https://github.com/llvm/llvm-project/pull/67298
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159159/new/
https://reviews.llvm.org/D159159
__
llvmbot wrote:
@llvm/pr-subscribers-clang
Changes
PowerPC AIX backend does not support float128 at all. Diagnose even when
specifying -mfloat128 to avoid backend crash.
---
Full diff: https://github.com/llvm/llvm-project/pull/67298.diff
2 Files Affected:
- (modified) clang/lib/Basic/Ta
https://github.com/ecnelises created
https://github.com/llvm/llvm-project/pull/67299
smmintrin.h uses __builtin_mffs, __builtin_mffsl, __builtin_mtfsf and
__builtin_set_fpscr_rn. This patch replaces the uses with ppc prefix and
implement the missing ones.
This fixes issue #64664.
>From 5abcf
qiucf abandoned this revision.
qiucf added a comment.
Migrated to https://github.com/llvm/llvm-project/pull/67299
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D158066/new/
https://reviews.llvm.org/D158066
__
https://github.com/ecnelises edited
https://github.com/llvm/llvm-project/pull/67299
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/martinboehme created
https://github.com/llvm/llvm-project/pull/67300
After https://reviews.llvm.org/D153273, we're now able to use `CFGLifetimeEnds`
together with the other CFG options we use.
>From baa1bbf7bfe684fc81b37fa3e1795170f5ee6156 Mon Sep 17 00:00:00 2001
From: Mart
llvmbot wrote:
@llvm/pr-subscribers-clang
Changes
smmintrin.h uses __builtin_mffs, __builtin_mffsl, __builtin_mtfsf and
__builtin_set_fpscr_rn. This patch replaces the uses with ppc prefix and
implement the missing ones.
This fixes issue #64664.
Migrated from https://reviews.llvm.org/D1
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff af199ee00db0796bd007e768d9056447d9bef999
b5f984b5521c5b226a7c5297d19eb53953481890 --
llvmbot wrote:
@llvm/pr-subscribers-clang-analysis
Changes
After https://reviews.llvm.org/D153273, we're now able to use `CFGLifetimeEnds`
together with the other CFG options we use.
---
Full diff: https://github.com/llvm/llvm-project/pull/67300.diff
6 Files Affected:
- (modified) clan
https://github.com/bjope updated https://github.com/llvm/llvm-project/pull/65624
From caa626ea4e813c7061b44f6b4336f31fce511f4b Mon Sep 17 00:00:00 2001
From: Bjorn Pettersson
Date: Thu, 7 Sep 2023 13:08:22 +0200
Subject: [PATCH] [clang][CodeGen] Simplify code based on opaque pointers
- Update C
sunshaoce wrote:
> ⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️
>
> You can test this locally with the following command:
> ```shell
> git-clang-format --diff b8b4ee6b450766796b162b4811a6b3f723d07268
> d07486764071679c8cbcd5e7c4905eb41b4770b3 --
> clang/utils/TableGen/Cl
https://github.com/bjope closed https://github.com/llvm/llvm-project/pull/65624
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Björn Pettersson
Date: 2023-09-25T11:21:24+02:00
New Revision: b4858c634e35e70627d59f5070d4ddcd8604e4f3
URL:
https://github.com/llvm/llvm-project/commit/b4858c634e35e70627d59f5070d4ddcd8604e4f3
DIFF:
https://github.com/llvm/llvm-project/commit/b4858c634e35e70627d59f5070d4ddcd8604e4f3.di
https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430
>From 1512bc16040e1015b6f8ed2b51ed8efb7fd97b8e Mon Sep 17 00:00:00 2001
From: Giulio Eulisse <10544+...@users.noreply.github.com>
Date: Thu, 14 Sep 2023 21:58:21 +0200
Subject: [PATCH] Introduce PagedVector class
The
ktf wrote:
I am afraid I will need a bit of the to fix the C2248 from Visual Studio.
https://github.com/llvm/llvm-project/pull/66430
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Timm =?utf-8?q?Bäder?= ,
Timm =?utf-8?q?Bäder?=
Message-ID:
In-Reply-To:
https://github.com/tbaederr created
https://github.com/llvm/llvm-project/pull/67306
None
>From 2cd32e94dd4eb194fd70b481f50eeaa2b6f72b66 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timm=20B=C3=A4der?=
Date: Wed, 13 Sep 202
https://github.com/rovka updated https://github.com/llvm/llvm-project/pull/66882
>From c1016a45d9cf57def642d14ba256db10e767cf5f Mon Sep 17 00:00:00 2001
From: Diana Picus
Date: Wed, 20 Sep 2023 10:19:46 +0200
Subject: [PATCH 1/2] Pre-commit testcases
---
llvm/test/CodeGen/AMDGPU/fix-sgpr-copie
@@ -5612,6 +5612,10 @@ RValue CodeGenFunction::EmitCall(const CGFunctionInfo
&CallInfo,
BundleList);
EmitBlock(Cont);
}
+ if (CI->getCalledFunction() && CI->getCalledFunction()->hasName() &&
+ CI->getCalledFunction()->getName().startsw
https://github.com/ilya-biryukov created
https://github.com/llvm/llvm-project/pull/67307
By ensuring the base is only visited once. This avoids infinite recursion and
expontential running times in some corner cases.
See the added tests for examples.
Apart from the cases that caused infinite r
llvmbot wrote:
@llvm/pr-subscribers-clang-tidy
Changes
By ensuring the base is only visited once. This avoids infinite recursion and
expontential running times in some corner cases.
See the added tests for examples.
Apart from the cases that caused infinite recursion and used to crash, t
rengolin wrote:
> Is this suggestion correct?
Doesn't look right to me. I seems it's suggesting 4 spaces tabs, which isn't
what we normally use. Something wrong with the clang-format job, maybe?
@tru @tstellar
https://github.com/llvm/llvm-project/pull/65744
__
https://github.com/sam-mccall approved this pull request.
https://github.com/llvm/llvm-project/pull/67307
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Qiu Chaofan
Date: 2023-09-25T17:53:39+08:00
New Revision: 3e97db89ae8e5b4d7bb6c0bf52773c43c9e06c51
URL:
https://github.com/llvm/llvm-project/commit/3e97db89ae8e5b4d7bb6c0bf52773c43c9e06c51
DIFF:
https://github.com/llvm/llvm-project/commit/3e97db89ae8e5b4d7bb6c0bf52773c43c9e06c51.diff
L
This revision was automatically updated to reflect the committed changes.
Closed by commit rG3e97db89ae8e: [PowerPC] Emit IR module flag for current
float abi (authored by qiucf).
Changed prior to commit:
https://reviews.llvm.org/D116016?vs=530843&id=557298#toc
Repository:
rG LLVM Github Mon
https://github.com/ilya-biryukov updated
https://github.com/llvm/llvm-project/pull/67307
>From bd300e3bf41df7cc90e4d4acf5e46da9847be46a Mon Sep 17 00:00:00 2001
From: Ilya Biryukov
Date: Mon, 25 Sep 2023 11:46:03 +0200
Subject: [PATCH 1/2] [ASTMatchers] Fix classIsDerivedFrom for recusrive case
Author: Ilya Biryukov
Date: 2023-09-25T12:10:29+02:00
New Revision: f5cb9cb59d7c9c6ac3d5c41c677f68c9b75d34a3
URL:
https://github.com/llvm/llvm-project/commit/f5cb9cb59d7c9c6ac3d5c41c677f68c9b75d34a3
DIFF:
https://github.com/llvm/llvm-project/commit/f5cb9cb59d7c9c6ac3d5c41c677f68c9b75d34a3.diff
https://github.com/ilya-biryukov closed
https://github.com/llvm/llvm-project/pull/67307
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tru wrote:
No I don't think it's job's fault. I ran clang-format on this file and it's not
formatted at all, so I think when we ask it to just format a patch like we do
in the job, it gets a bit confused and give you a bit of non-sense formatting.
This is just a limitation of not running forma
tru wrote:
Looking at it - it seems like none of Tablegen is correctly clang-formatted. If
that's not desired, maybe it should have a local .clang-format file to disable
the formatting of these files.
Do we have a clang-tblgen maintainer? Couldn't find anything in the codeowners
and git log h
mizvekov wrote:
@efriedma-quic gentle ping :-)
https://github.com/llvm/llvm-project/pull/66816
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jchlanda updated
https://github.com/llvm/llvm-project/pull/66496
>From 9c8caed3c8def15ccdbfdf831f36d0befed1fc84 Mon Sep 17 00:00:00 2001
From: Jakub Chlanda
Date: Fri, 15 Sep 2023 12:08:04 +0100
Subject: [PATCH 1/7] [NVPTX] Add support for maxclusterrank in launch_bounds
Sin
@@ -537,59 +537,46 @@ void NVPTXAsmPrinter::emitKernelFunctionDirectives(const
Function &F,
raw_ostream &O) const {
// If the NVVM IR has some of reqntid* specified, then output
// the reqntid directive, and set the unspec
https://github.com/Ami-zhang created
https://github.com/llvm/llvm-project/pull/67310
None
>From a8a8b30c472b88815e373132198ee97f3658869a Mon Sep 17 00:00:00 2001
From: zhanglimin
Date: Thu, 31 Aug 2023 15:04:17 +0800
Subject: [PATCH] [Driver] Support -fsanitize=cfi-icall on loongarch64
---
c
https://github.com/martinboehme created
https://github.com/llvm/llvm-project/pull/67311
The assertion fails on the test TransferTest.EvaluateBlockWithUnreachablePreds
(which I think, ironically, was introuced in the same patch as the assertion).
This just wasn't obvious because the assertion is
llvmbot wrote:
@llvm/pr-subscribers-clang
Changes
The assertion fails on the test TransferTest.EvaluateBlockWithUnreachablePreds
(which I think, ironically, was introuced in the same patch as the assertion).
This just wasn't obvious because the assertion is inside an `LLVM_DEBUG` block
and
https://github.com/rovka edited https://github.com/llvm/llvm-project/pull/66882
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/martinboehme created
https://github.com/llvm/llvm-project/pull/67313
`LLVM_DEBUG` blocks are only run if the `-debug` command line flag is passed.
We don't do this in any of our CI builds, so the assertion has limited value and
it's likely it will start failing over time.
>F
llvmbot wrote:
@llvm/pr-subscribers-clang-analysis
Changes
`LLVM_DEBUG` blocks are only run if the `-debug` command line flag is passed.
We don't do this in any of our CI builds, so the assertion has limited value and
it's likely it will start failing over time.
---
Full diff: https://git
https://github.com/5chmidti updated
https://github.com/llvm/llvm-project/pull/66583
>From 8f5e9e6024b0db8f251625669adbc5d607da83cb Mon Sep 17 00:00:00 2001
From: Julian Schmidt <44101708+5chmi...@users.noreply.github.com>
Date: Sat, 16 Sep 2023 16:24:13 +0200
Subject: [PATCH 1/9] [clang-tidy] ad
https://github.com/rovka closed https://github.com/llvm/llvm-project/pull/66882
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ktf resolved https://github.com/llvm/llvm-project/pull/66430
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jplehr wrote:
It appears that this change made the AMDGPU OpenMP buildbot unhappy
https://lab.llvm.org/buildbot/#/builders/193/builds/39050
https://github.com/llvm/llvm-project/pull/66882
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://
https://github.com/ktf resolved https://github.com/llvm/llvm-project/pull/66430
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,322 @@
+//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++
+//-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier
https://github.com/ktf resolved https://github.com/llvm/llvm-project/pull/66430
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cor3ntin wrote:
@tru I'd ask @AaronBallman. My vote would be to reformat.
https://github.com/llvm/llvm-project/pull/65744
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
orcguru wrote:
When a module contains three TLS LD variables
>From assembly file generated by "as -a64 -many -o"
```
02f8 (idx: 33) a[TC]:
2f8: 00 00 00 00
02f8: R_TLS_LD (idx: 41) a[TL]
2fc: 00 00 00 00
0300 (idx: 35) _$T
Author: cor3ntin
Date: 2023-09-25T14:02:39+02:00
New Revision: b7ff03206d668cd5a620a9d4e1b22ea112ed56e3
URL:
https://github.com/llvm/llvm-project/commit/b7ff03206d668cd5a620a9d4e1b22ea112ed56e3
DIFF:
https://github.com/llvm/llvm-project/commit/b7ff03206d668cd5a620a9d4e1b22ea112ed56e3.diff
LOG:
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/65664
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/emaste approved this pull request.
Sure; we're generally moving away from supporting any 32-bit platforms so it is
exceedingly unlikely that we would add riscv32 support.
https://github.com/llvm/llvm-project/pull/67277
___
cfe-commi
https://github.com/ktf updated https://github.com/llvm/llvm-project/pull/66430
>From 4b02b55cccd73b0fe3efea52054735fca6e6c159 Mon Sep 17 00:00:00 2001
From: Giulio Eulisse <10544+...@users.noreply.github.com>
Date: Thu, 14 Sep 2023 21:58:21 +0200
Subject: [PATCH] Introduce PagedVector class
The
orcguru wrote:
Missing an update in `recordRelocation()` similar as the patch:
https://reviews.llvm.org/D155415.
Working on it now.
https://github.com/llvm/llvm-project/pull/66316
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.
zahiraam wrote:
> This implementation has bugs, see [#66114
> (comment)](https://github.com/llvm/llvm-project/issues/66114#issuecomment-1732319259)
@RIscRIpt Thanks. Will look at them.
https://github.com/llvm/llvm-project/pull/66120
___
cfe-commits m
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155775/new/
https://reviews.llvm.org/D155775
___
cfe-commits mailing list
cfe-c
ldionne wrote:
> Thank you for your review! Here are some comments and my thoughts.
>
> > Note that you should probably rebase your patch onto main and force-push to
> > update the PR
>
> Does it mean that I can rebase and force-push since (it should be avoided in
> normal case but) this is a
rovka wrote:
@jplehr Thanks for pointing that out. I tried reproducing the failure locally
(Ubuntu 22.04 running on AMD hardware) but couldn't manage to run the tests for
amdgcn-amd-amdhsa, although the AMDGPU target is in LLVM_TARGETS_TO_BUILD. I'm
assuming this is because I'm missing some pa
rovka wrote:
@jplehr Thanks for pointing that out. I tried reproducing the failure locally
(Ubuntu 22.04 running on AMD hardware) but couldn't manage to run the tests for
amdgcn-amd-amdhsa, although the AMDGPU target is in LLVM_TARGETS_TO_BUILD. I'm
assuming this is because I'm missing some pa
rengolin wrote:
> @tru I'd ask @AaronBallman. My vote would be to reformat.
Not as a requirement for this patch, I imagine?
https://github.com/llvm/llvm-project/pull/65744
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/66846
>From 6d8e737ab1a883371a7491b676e1e202a087701f Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Tue, 19 Sep 2023 16:15:20 +0800
Subject: [PATCH 1/2] [clang-analysis]Fix false positive in mutation check when
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/66846
>From 6d8e737ab1a883371a7491b676e1e202a087701f Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Tue, 19 Sep 2023 16:15:20 +0800
Subject: [PATCH 1/2] [clang-analysis]Fix false positive in mutation check when
AaronBallman wrote:
> > @tru I'd ask @AaronBallman. My vote would be to reformat.
>
> Not as a requirement for this patch, I imagine?
If we wanted to reformat the file as an NFC commit (before or after this
patch), that would be fine. But let's please not reformat as part of this patch
(that
https://github.com/AaronBallman approved this pull request.
LGTM (fine to land without tests as it only adds comments to generated header
files)
https://github.com/llvm/llvm-project/pull/65744
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
Author: David Truby
Date: 2023-09-25T14:32:52+01:00
New Revision: 247b7d068497de085b7fd66c6531034afa9709f0
URL:
https://github.com/llvm/llvm-project/commit/247b7d068497de085b7fd66c6531034afa9709f0
DIFF:
https://github.com/llvm/llvm-project/commit/247b7d068497de085b7fd66c6531034afa9709f0.diff
L
https://github.com/DavidTruby closed
https://github.com/llvm/llvm-project/pull/67125
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 resolved
https://github.com/llvm/llvm-project/pull/66846
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 resolved
https://github.com/llvm/llvm-project/pull/66846
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -274,8 +288,8 @@ const Stmt *ExprMutationAnalyzer::findDirectMutation(const
Expr *Exp) {
const auto NonConstMethod = cxxMethodDecl(unless(isConst()));
const auto AsNonConstThis = expr(anyOf(
- cxxMemberCallExpr(callee(NonConstMethod),
-on(c
@@ -274,8 +288,8 @@ const Stmt *ExprMutationAnalyzer::findDirectMutation(const
Expr *Exp) {
const auto NonConstMethod = cxxMethodDecl(unless(isConst()));
const auto AsNonConstThis = expr(anyOf(
- cxxMemberCallExpr(callee(NonConstMethod),
-on(c
antmo abandoned this revision.
antmo added a comment.
yes indeed you fixed this @shafik. thanks for the update. abandoning this
revision
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D156711/new/
https://reviews.llvm.org/D156711
__
Author: Brad Smith
Date: 2023-09-25T09:43:10-04:00
New Revision: c1300efc78a17374065744c8985b4598fb8c3166
URL:
https://github.com/llvm/llvm-project/commit/c1300efc78a17374065744c8985b4598fb8c3166
DIFF:
https://github.com/llvm/llvm-project/commit/c1300efc78a17374065744c8985b4598fb8c3166.diff
LO
https://github.com/brad0 closed https://github.com/llvm/llvm-project/pull/67277
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/steakhal created
https://github.com/llvm/llvm-project/pull/67331
Inside `writePrettyPrintFunction()`, we check if we need to emit the given
argument:
```C++
if (!arg->isOptional() || arg->getIsOmitted() == "false") {
FoundNonOptArg = true;
continue;
}
```
For the `Ass
llvmbot wrote:
@llvm/pr-subscribers-clang
Changes
Inside `writePrettyPrintFunction()`, we check if we need to emit the given
argument:
```C++
if (!arg->isOptional() || arg->getIsOmitted() == "false") {
FoundNonOptArg = true;
continue;
}
```
For the `AssumeAligned` attribute, the se
orcguru wrote:
> Missing an update in `recordRelocation()` similar as the patch:
> https://reviews.llvm.org/D155415.
>
> Working on it now.
Done. Added one test case aix-tls-ld-xcoff-reloc-large.ll to track this kind of
issue. If full set of test case is necessary, please let me know, and I w
tarunprabhu wrote:
> I think Windows does not work likely because `ld` is absent in PATH. You need
> `-Bxxx/bin` to specify a directory that contains `ld`, but I don't remember
> whether `ld.exe` is needed instead.
I think what I saw on the buildkite was Link.exe, but I don't know if that is
jplehr wrote:
Sure, I'll look into it later today and get back to you.
https://github.com/llvm/llvm-project/pull/66882
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/66846
>From 6d8e737ab1a883371a7491b676e1e202a087701f Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Tue, 19 Sep 2023 16:15:20 +0800
Subject: [PATCH 1/4] [clang-analysis]Fix false positive in mutation check when
1 - 100 of 311 matches
Mail list logo
