[clang] [clang-format] Properly indent lines inside Verilog case structure (PR #65861)

https://github.com/sstwcw updated https://github.com/llvm/llvm-project/pull/65861 >From c1982d451e6ca8e3cf1269677aabe984000f6801 Mon Sep 17 00:00:00 2001 From: sstwcw Date: Sat, 9 Sep 2023 20:35:33 + Subject: [PATCH 1/3] [clang-format] Properly indent lines inside Verilog case structure W

[clang] 00e794b - [clang-format] Properly indent lines inside Verilog case structure (#65861)

Author: sstwcw Date: 2023-09-16T14:30:19Z New Revision: 00e794b4dd9699403f2df3ac9c8147fc139730b2 URL: https://github.com/llvm/llvm-project/commit/00e794b4dd9699403f2df3ac9c8147fc139730b2 DIFF: https://github.com/llvm/llvm-project/commit/00e794b4dd9699403f2df3ac9c8147fc139730b2.diff LOG: [clang

[clang] [clang-format] Properly indent lines inside Verilog case structure (PR #65861)

https://github.com/sstwcw closed https://github.com/llvm/llvm-project/pull/65861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] add misc-math-constant check (PR #66583)

https://github.com/5chmidti created https://github.com/llvm/llvm-project/pull/66583 This check finds constants and function calls to math functions that can be replaced with c++20's mathematical constants ('numbers' header) and offers fixit-hints. Does not match the use of variables or macros w

[clang-tools-extra] [clang-tidy] add misc-math-constant check (PR #66583)

llvmbot wrote: @llvm/pr-subscribers-clang-tidy Changes This check finds constants and function calls to math functions that can be replaced with c++20's mathematical constants ('numbers' header) and offers fixit-hints. Does not match the use of variables or macros with that value and inste

[clang-tools-extra] [clang-tidy] add misc-math-constant check (PR #66583)

5chmidti wrote: For macros I have only implemented matching literals, not function calls or formulas. I also don't suggest using modern language constructs for macros, there are other checks that do this. https://github.com/llvm/llvm-project/pull/66583 _

[clang] [Clang][test] Replace legacy -target with --target=. (PR #66572)

https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/66572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] add misc-math-constant check (PR #66583)

https://github.com/5chmidti updated https://github.com/llvm/llvm-project/pull/66583 >From 6e14980c7b7fe22e8b614d641ba72117982b798f Mon Sep 17 00:00:00 2001 From: Julian Schmidt <44101708+5chmi...@users.noreply.github.com> Date: Sat, 16 Sep 2023 16:24:13 +0200 Subject: [PATCH] [clang-tidy] add mi

[clang-tools-extra] [clang-tidy] add misc-math-constant check (PR #66583)

PiotrZSL wrote: In general scope of the check is fine, but specially as it's limited to C++20 and way how its written would be good to rename it into modernize-use-std-numbers. https://github.com/llvm/llvm-project/pull/66583 ___ cfe-commits mailing l

[clang-tools-extra] [clang-tidy] add misc-math-constant check (PR #66583)

5chmidti wrote: - How do I correctly parse the values in a macro? While the test locally works, it doesn't in CI. I also don't differentiate between what kind of numeric constant the token is, which might be another problem. Any pointers on how to do this correctly are greatly appreciated. - M

[clang-tools-extra] [clang-tidy] add misc-math-constant check (PR #66583)

5chmidti wrote: > In general scope of the check is fine, but specially as it's limited to C++20 > and way how its written would be good to rename it into > modernize-use-std-numbers. Sure thing. I don't have a strong feeling about the category. https://github.com/llvm/llvm-project/pull/66583

[clang] 5bdd5d0 - Fix PR#62594 : static lambda call operator is not convertible to function pointer on win32

Author: faisal vali Date: 2023-09-16T13:29:59-05:00 New Revision: 5bdd5d064d5171b2d5ff6268528cfffd2f86b8ea URL: https://github.com/llvm/llvm-project/commit/5bdd5d064d5171b2d5ff6268528cfffd2f86b8ea DIFF: https://github.com/llvm/llvm-project/commit/5bdd5d064d5171b2d5ff6268528cfffd2f86b8ea.diff L

[clang-tools-extra] [clang-tidy] add misc-math-constant check (PR #66583)

https://github.com/5chmidti updated https://github.com/llvm/llvm-project/pull/66583 >From 32d56e1bfb79ec0be5344ec11bb465777c2fd236 Mon Sep 17 00:00:00 2001 From: Julian Schmidt <44101708+5chmi...@users.noreply.github.com> Date: Sat, 16 Sep 2023 16:24:13 +0200 Subject: [PATCH] [clang-tidy] add mi

[clang-tools-extra] [clang-tidy] add misc-math-constant check (PR #66583)

https://github.com/5chmidti updated https://github.com/llvm/llvm-project/pull/66583 >From 248c433be176806766f8c2ae9f19ca61f392220e Mon Sep 17 00:00:00 2001 From: Julian Schmidt <44101708+5chmi...@users.noreply.github.com> Date: Sat, 16 Sep 2023 16:24:13 +0200 Subject: [PATCH] [clang-tidy] add mo

[clang-tools-extra] [clang-tidy] add modernize-math-constant check (PR #66583)

https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/66583 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D150075: Fix PR#62594 : static lambda call operator is not convertible to function pointer on win32

faisalv closed this revision. faisalv added a comment. Sorry about the delay - this patch has landed - https://github.com/llvm/llvm-project/commit/5bdd5d064d5171b2d5ff6268528cfffd2f86b8ea Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150075

[clang-tools-extra] [clang-tidy] add modernize-math-constant check (PR #66583)

PiotrZSL wrote: > Sure thing. I don't have a strong feeling about the category. I'ts not only about category but also name, check suggests std::numbers, then better name it modernize-use-std-numbers, reason for that is simple. Before C++20 we may want to have a check for example -prefer-math-c

[clang-tools-extra] [clang-tidy] add modernize-math-constant check (PR #66583)

PiotrZSL wrote: Simply better to reduce scope of check name to avoid overlap, unless check would support pre-c++20, then it could be fine. https://github.com/llvm/llvm-project/pull/66583 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang-tools-extra] [clang-tidy] add modernize-math-constant check (PR #66583)

5chmidti wrote: > I'ts not only about category but also name, check suggests std::numbers, then > better name it modernize-use-std-numbers, reason for that is simple. Before > C++20 we may want to have a check for example -prefer-math-constants that > would change 3.14 hardcoded in code into M

[clang-tools-extra] [clang-tidy] add modernize-math-constant check (PR #66583)

https://github.com/5chmidti updated https://github.com/llvm/llvm-project/pull/66583 >From 0f14b63b7336532f45abd40749a2a7cd11cfe7e6 Mon Sep 17 00:00:00 2001 From: Julian Schmidt <44101708+5chmi...@users.noreply.github.com> Date: Sat, 16 Sep 2023 16:24:13 +0200 Subject: [PATCH] [clang-tidy] add mo

[clang-tools-extra] [clang-tidy] add modernize-use-std-numbers (PR #66583)

https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/66583 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] add modernize-use-std-numbers (PR #66583)

https://github.com/5chmidti updated https://github.com/llvm/llvm-project/pull/66583 >From 26fb41a2903110b6fc8bd986284d41b1fe6814d5 Mon Sep 17 00:00:00 2001 From: Julian Schmidt <44101708+5chmi...@users.noreply.github.com> Date: Sat, 16 Sep 2023 16:24:13 +0200 Subject: [PATCH] [clang-tidy] add mo

[clang-tools-extra] [clang-tidy] add modernize-use-std-numbers (PR #66583)

https://github.com/5chmidti updated https://github.com/llvm/llvm-project/pull/66583 >From 8f5e9e6024b0db8f251625669adbc5d607da83cb Mon Sep 17 00:00:00 2001 From: Julian Schmidt <44101708+5chmi...@users.noreply.github.com> Date: Sat, 16 Sep 2023 16:24:13 +0200 Subject: [PATCH] [clang-tidy] add mo

[clang-tools-extra] [clang-tidy] add modernize-use-std-numbers (PR #66583)

https://github.com/5chmidti updated https://github.com/llvm/llvm-project/pull/66583 >From 8f5e9e6024b0db8f251625669adbc5d607da83cb Mon Sep 17 00:00:00 2001 From: Julian Schmidt <44101708+5chmi...@users.noreply.github.com> Date: Sat, 16 Sep 2023 16:24:13 +0200 Subject: [PATCH 1/3] [clang-tidy] ad

[PATCH] D152504: [clang][ThreadSafety] Analyze cleanup functions

aaronpuchert accepted this revision. aaronpuchert added a comment. Thanks, looks good! I'd like to hear from @aaron.ballman if this warrants a release note, but that can be added separately. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152504/new/ https://reviews.llvm.org/D152504 ___

[PATCH] D152504: [clang][ThreadSafety] Analyze cleanup functions

aaronpuchert added inline comments. Comment at: clang/test/Sema/warn-thread-safety-analysis.c:26 + // Define the mutex struct. Oh, I wouldn't mind if you were to drop this spurious added newline. But you can do this when committing, no need for a new patch se

[clang] Fix math-errno issue (PR #66381)

https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/66381 >From 997e3b69ac5c20a9130b957c86c08b16d23af07c Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Thu, 14 Sep 2023 06:27:35 -0700 Subject: [PATCH 1/6] Fix math-errno issue --- clang/lib/CodeGen/CGBuiltin

[clang] Fix math-errno issue (PR #66381)

https://github.com/zahiraam resolved https://github.com/llvm/llvm-project/pull/66381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix math-errno issue (PR #66381)

https://github.com/zahiraam resolved https://github.com/llvm/llvm-project/pull/66381 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix requires misannotation with comma (PR #65908)

https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/65908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix requires misannotation with comma (PR #65908)

https://github.com/owenca commented: Nits. https://github.com/llvm/llvm-project/pull/65908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix requires misannotation with comma (PR #65908)

@@ -1135,6 +1145,14 @@ TEST_F(TokenAnnotatorTest, UnderstandsRequiresExpressions) { EXPECT_TOKEN(Tokens[3], tok::kw_requires, TT_RequiresExpression); EXPECT_TOKEN(Tokens[4], tok::l_paren, TT_RequiresExpressionLParen); EXPECT_TOKEN(Tokens[14], tok::l_brace, TT_RequiresExp

[clang] [clang-format] Fix requires misannotation with comma (PR #65908)

@@ -1019,10 +1019,12 @@ TEST_F(TokenAnnotatorTest, UnderstandsRequiresClausesAndConcepts) { Tokens = annotate("void f() & requires(true) {}"); EXPECT_EQ(Tokens.size(), 12u) << Tokens; + EXPECT_TOKEN(Tokens[5], tok::kw_requires, TT_RequiresClause); EXPECT_TOKEN(Tokens[

[clang] [clang-format] Fix requires misannotation with comma (PR #65908)

@@ -1019,10 +1019,12 @@ TEST_F(TokenAnnotatorTest, UnderstandsRequiresClausesAndConcepts) { Tokens = annotate("void f() & requires(true) {}"); EXPECT_EQ(Tokens.size(), 12u) << Tokens; + EXPECT_TOKEN(Tokens[5], tok::kw_requires, TT_RequiresClause); EXPECT_TOKEN(Tokens[

[clang] [Clang] Allow mixed scalar type constraints for inline asm (PR #65465)

@@ -0,0 +1,8 @@ +// RUN: %clang_cc1 %s -emit-llvm -o /dev/null + +unsigned test(float f) topperc wrote: What IR does this generate? https://github.com/llvm/llvm-project/pull/65465 ___ cfe-commits mailing list cfe-commi

[clang] [Clang] Allow mixed scalar type constraints for inline asm (PR #65465)

@@ -0,0 +1,8 @@ +// RUN: %clang_cc1 %s -emit-llvm -o /dev/null + +unsigned test(float f) topperc wrote: This test is using -emit-llvm, but the patch is in SelectionDAG. SelectionDAG doesn't run with -emit-llvm https://github.com/llvm/llvm-project/pull/65465 ___

[clang] [clang-format] Fix requires misannotation with comma (PR #65908)

https://github.com/rymiel updated https://github.com/llvm/llvm-project/pull/65908 >From 0cfeaee5ec5c431bc15fb037f2a20c944c508c2a Mon Sep 17 00:00:00 2001 From: Emilia Kond Date: Sun, 10 Sep 2023 23:01:39 +0300 Subject: [PATCH 1/3] [clang-format] Fix requires misannotation with comma clang-form

[clang] [clang-format] Fix requires misannotation with comma (PR #65908)

https://github.com/rymiel resolved https://github.com/llvm/llvm-project/pull/65908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix requires misannotation with comma (PR #65908)

https://github.com/rymiel resolved https://github.com/llvm/llvm-project/pull/65908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix requires misannotation with comma (PR #65908)

https://github.com/rymiel resolved https://github.com/llvm/llvm-project/pull/65908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format][NFC] Clean up signatures of some parser functions (PR #66569)

@@ -370,9 +364,9 @@ bool UnwrappedLineParser::parseLevel(const FormatToken *OpeningBrace, else if (FormatTok->getType() == TT_MacroBlockEnd) kind = tok::r_brace; -auto ParseDefault = [this, OpeningBrace, NextLevelLBracesType, IfKind, +auto ParseDefault = [th

[clang] [clang-format] Fix requires misannotation with comma (PR #65908)

https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/65908 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Documentation] Replace recommonmark by myst-parser (PR #65664)

andreil99 wrote: @cor3ntin No, I did not update all the sphinx bots, only specific ones, as I mentioned above in https://github.com/llvm/llvm-project/pull/65664#issuecomment-1714983618 > I can update the publishing bots. For the bots running on > https://lab.llvm.org/buildbot/#/workers/92 we w

[clang] [clang-format][NFC] Clean up signatures of some parser functions (PR #66569)

https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/66569 >From bf3160066ae83d43837f18825d00c963d0c29ca8 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Fri, 15 Sep 2023 21:59:47 -0700 Subject: [PATCH 1/2] [clang-format][NFC] Clean up signatures of some parser functions

[clang] [clang-format][NFC] Clean up signatures of some parser functions (PR #66569)

@@ -370,9 +364,9 @@ bool UnwrappedLineParser::parseLevel(const FormatToken *OpeningBrace, else if (FormatTok->getType() == TT_MacroBlockEnd) kind = tok::r_brace; -auto ParseDefault = [this, OpeningBrace, NextLevelLBracesType, IfKind, +auto ParseDefault = [th

[clang] [clang-format][NFC] Clean up signatures of some parser functions (PR #66569)

https://github.com/owenca resolved https://github.com/llvm/llvm-project/pull/66569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Enable --print-supported-extensions for all targets (PR #66586)

https://github.com/cbalint13 created https://github.com/llvm/llvm-project/pull/66586 This uses MCSubtargetInfo instead to cover all the architectures. This now also list descriptions along with the names. The advantage fetching from MCSubtargetInfo is that we rely on tablegen architecture des

[PATCH] D152279: [Driver] Default -msmall-data-limit= to 0

MaskRay added a comment. In D152279#4638173 , @asb wrote: > In D152279#4612099 , @craig.topper > wrote: > >> In D152279#4612087 , @MaskRay >> wrote: >> >>> I am still in

[clang] [clang] Enable --print-supported-extensions for all targets (PR #66586)

cbalint13 wrote: @DavidSpickett , This PR list all flags for a specific target. --- Additionally, beyond this PR: * We can limit to list flags only for a desired e.g. -mcpu=XYZ, e.g. the user can query like: ```./bin/clang -target x86_64-linux-gnu -mcpu=sandybridge --print-supported-extensi

[clang] [clang] Enable --print-supported-extensions for all targets (PR #66586)

https://github.com/cbalint13 updated https://github.com/llvm/llvm-project/pull/66586 >From 87c21561e1c087caeb6105f5824e809da85e67ac Mon Sep 17 00:00:00 2001 From: Balint Cristian Date: Sun, 17 Sep 2023 02:36:45 +0300 Subject: [PATCH] [clang] Enable --print-supported-extensions for all targets

[clang] [clang] Enable --print-supported-extensions for all targets (PR #66586)

https://github.com/cbalint13 edited https://github.com/llvm/llvm-project/pull/66586 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Enable --print-supported-extensions for all targets (PR #66586)

https://github.com/cbalint13 updated https://github.com/llvm/llvm-project/pull/66586 >From 47422fc341cc2a830aa7abec6d105018271f13bd Mon Sep 17 00:00:00 2001 From: Balint Cristian Date: Sun, 17 Sep 2023 03:00:59 +0300 Subject: [PATCH] [clang] Enable --print-supported-extensions for all targets

[clang] [clang-format][NFC] Clean up signatures of some parser functions (PR #66569)

https://github.com/rymiel approved this pull request. https://github.com/llvm/llvm-project/pull/66569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Docs] Document X86 interrupt attribute (PR #65662)

https://github.com/antangelo updated https://github.com/llvm/llvm-project/pull/65662 >From adab00268e5a6ca765dd2b70b2b3a7a332641ab9 Mon Sep 17 00:00:00 2001 From: Antonio Abbatangelo Date: Thu, 31 Aug 2023 16:40:06 -0400 Subject: [PATCH] [clang][Docs] Document X86 interrupt attribute --- clan

[clang] [clang][Docs] Document X86 interrupt attribute (PR #65662)

llvmbot wrote: @llvm/pr-subscribers-clang Changes Adds documentation for the X86 `__attribute__((interrupt))` attribute, in a similar format to interrupt attributes of other platforms. Migrated from https://reviews.llvm.org/D159317 --- Full diff: https://github.com/llvm/llvm-project/pull/

[clang-tools-extra] [clang-tidy] add modernize-use-std-numbers (PR #66583)

@@ -0,0 +1,25 @@ +.. title:: clang-tidy - modernize-use-std-numbers + +modernize-use-std-numbers += + +This check finds constants and function calls to math functions that can be replaced +with c++20's mathematical constants ('numbers' header) and offers f

[clang-tools-extra] [clang-tidy] add modernize-use-std-numbers (PR #66583)

@@ -0,0 +1,377 @@ +//===--- UseStdNumbersCheck.cpp - clang_tidy -===// EugeneZelenko wrote: Please make it same length as similar line at bottom of comment. https://github.com/llvm/llvm-project/pull/66583 _

[clang-tools-extra] [clang-tidy] add modernize-use-std-numbers (PR #66583)

@@ -168,6 +168,12 @@ New checks Replace ``enable_if`` with C++20 requires clauses. +- New :doc:`modernize-use-std-numbers + ` check. + + Finds constants and function calls to math functions that can be replaced + with c++20's mathematical constants ('numbers' header). --

[clang-tools-extra] [clang-tidy] add modernize-use-std-numbers (PR #66583)

@@ -0,0 +1,25 @@ +.. title:: clang-tidy - modernize-use-std-numbers + +modernize-use-std-numbers += + +This check finds constants and function calls to math functions that can be replaced EugeneZelenko wrote: Please synchronize first stat

[clang-tools-extra] [libc++] Prevent calling the projection more than three times (PR #66315)

pandaninjas wrote: Any idea why the CI is failing? It mentions line 86 not being constexpr because of assert, but it doesn't seem like I've done anything which should affect that... https://github.com/llvm/llvm-project/pull/66315 ___ cfe-commits mail

[clang] [libc++] Prevent calling the projection more than three times (PR #66315)

pandaninjas wrote: Any idea why the CI is failing? It mentions line 86 not being constexpr because of assert, but it doesn't seem like I've done anything which should affect that... https://github.com/llvm/llvm-project/pull/66315 ___ cfe-commits mail

[clang] da35b2e - [clang][Docs] Document X86 interrupt attribute (#65662)

Author: antangelo Date: 2023-09-17T01:26:26-04:00 New Revision: da35b2e57a164ec62278f1685d0c684c5bc2d666 URL: https://github.com/llvm/llvm-project/commit/da35b2e57a164ec62278f1685d0c684c5bc2d666 DIFF: https://github.com/llvm/llvm-project/commit/da35b2e57a164ec62278f1685d0c684c5bc2d666.diff LOG

[clang] [clang][Docs] Document X86 interrupt attribute (PR #65662)

https://github.com/antangelo closed https://github.com/llvm/llvm-project/pull/65662 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   >