[PATCH] D156045: [clang][Interp] Enable existing source_location tests

2023-09-09 Thread Takuya Shimizu via Phabricator via cfe-commits
hazohelet added a comment. @tbaeder Now it's working correctly. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156045/new/ https://reviews.llvm.org/D156045 ___ cfe-commits mailing list cfe-commits

[PATCH] D156400: [clang][Interp] Implement __builtin_offsetof

2023-09-09 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder updated this revision to Diff 556339. tbaeder marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156400/new/ https://reviews.llvm.org/D156400 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/In

[PATCH] D157911: clang: Add __builtin_exp10* and use new llvm.exp10 intrinsic

2023-09-09 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm updated this revision to Diff 556343. arsenm added a comment. Release notes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157911/new/ https://reviews.llvm.org/D157911 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Builtins.def clang/lib/CodeGen/CGBuiltin.cpp

[clang] [Driver] Replace usage of -Bshareable linker flag with -shared (PR #65842)

2023-09-09 Thread Brad Smith via cfe-commits
https://github.com/brad0 created https://github.com/llvm/llvm-project/pull/65842: The two flags mean the same thing for the bfd / lld linkers so just use the same flag consistently everywhere. >From 42f0ede652ebf38cb21fb07549e3dfcbbd43f3d1 Mon Sep 17 00:00:00 2001 From: Brad Smith Date: Sat,

[clang] [Driver] Replace usage of -Bshareable linker flag with -shared (PR #65842)

2023-09-09 Thread Brad Smith via cfe-commits
https://github.com/brad0 review_requested https://github.com/llvm/llvm-project/pull/65842 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Replace usage of -Bshareable linker flag with -shared (PR #65842)

2023-09-09 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65842 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Replace usage of -Bshareable linker flag with -shared (PR #65842)

2023-09-09 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65842 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Replace usage of -Bshareable linker flag with -shared (PR #65842)

2023-09-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes The two flags mean the same thing for the bfd / lld linkers so just use the same flag consistently everywhere. -- Full diff: https://github.com/llvm/llvm-project/pull/65842.diff 4 Files Affected: - (modified) clang/lib/Driver/ToolChains/Drag

[PATCH] D139277: [clangd] Use all query-driver arguments in cache key

2023-09-09 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added a comment. This was superseded by D146941 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139277/new/ https://reviews.llvm.org/D139277 ___ cfe-commits maili

[PATCH] D159138: [clang][Sema] Fix format size estimator's handling of %o, %x, %X with alternative form

2023-09-09 Thread Takuya Shimizu via Phabricator via cfe-commits
hazohelet marked 4 inline comments as done. hazohelet added a comment. Thanks for the review! Comment at: clang/docs/ReleaseNotes.rst:125 * ``-Woverriding-t-option`` is renamed to ``-Woverriding-option``. * ``-Winterrupt-service-routine`` is renamed to ``-Wexcessive-regsave``

[PATCH] D157526: [clang][Sema] Remove irrelevant diagnostics from constraint satisfaction failure

2023-09-09 Thread Takuya Shimizu via Phabricator via cfe-commits
hazohelet added a comment. When I first ran `git clang-format` locally, it somehow forced 4-space indent. After starting to use clang-format from the trunk, I haven't seen the suspicious behavior locally, but the CI format check failure might be caused by that. The format seems okay as-is, so I'

[clang] [clang][Interp] Add IntegralAP for arbitrary-precision integers (PR #65844)

2023-09-09 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr review_requested https://github.com/llvm/llvm-project/pull/65844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Add IntegralAP for arbitrary-precision integers (PR #65844)

2023-09-09 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr review_requested https://github.com/llvm/llvm-project/pull/65844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Add IntegralAP for arbitrary-precision integers (PR #65844)

2023-09-09 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr review_requested https://github.com/llvm/llvm-project/pull/65844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Add IntegralAP for arbitrary-precision integers (PR #65844)

2023-09-09 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/65844: This adds `IntegralAP` backing the two new primtypes `IntAP` (unsinged arbitrary-precision int) and `IntAPS` (same but signed). We use this for `int128` support (which isn't available on all host systems we s

[clang] [clang][Interp] Add IntegralAP for arbitrary-precision integers (PR #65844)

2023-09-09 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr review_requested https://github.com/llvm/llvm-project/pull/65844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Add IntegralAP for arbitrary-precision integers (PR #65844)

2023-09-09 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr review_requested https://github.com/llvm/llvm-project/pull/65844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Add IntegralAP for arbitrary-precision integers (PR #65844)

2023-09-09 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Add IntegralAP for arbitrary-precision integers (PR #65844)

2023-09-09 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Add IntegralAP for arbitrary-precision integers (PR #65844)

2023-09-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes This adds `IntegralAP` backing the two new primtypes `IntAP` (unsinged arbitrary-precision int) and `IntAPS` (same but signed). We use this for `int128` support (which isn't available on all host systems we support AFAIK) and I think we can

[clang] 39db3b0 - [clang][Interp][NFC] Remove unused Integral::from() overload

2023-09-09 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-09-09T11:07:55+02:00 New Revision: 39db3b097a9b41bf5798209916cc54eecef40eee URL: https://github.com/llvm/llvm-project/commit/39db3b097a9b41bf5798209916cc54eecef40eee DIFF: https://github.com/llvm/llvm-project/commit/39db3b097a9b41bf5798209916cc54eecef40eee.diff LO

[clang] 38c7230 - [clang][Interp][NFC] Remove unused Boolean::from() overload

2023-09-09 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-09-09T11:07:55+02:00 New Revision: 38c723064530fa3b2e6960e601b6905529b4a32e URL: https://github.com/llvm/llvm-project/commit/38c723064530fa3b2e6960e601b6905529b4a32e DIFF: https://github.com/llvm/llvm-project/commit/38c723064530fa3b2e6960e601b6905529b4a32e.diff LO

[clang] 211f7dd - [clang][Interp][NFC] Tiny indentation fix

2023-09-09 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-09-09T11:07:55+02:00 New Revision: 211f7ddbe14b4486084882b02e70352b944f6286 URL: https://github.com/llvm/llvm-project/commit/211f7ddbe14b4486084882b02e70352b944f6286 DIFF: https://github.com/llvm/llvm-project/commit/211f7ddbe14b4486084882b02e70352b944f6286.diff LO

[clang] 2744d9b - [clang][Interp][NFC] Use delegate() vor ParenExprs

2023-09-09 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2023-09-09T11:07:56+02:00 New Revision: 2744d9b649f79a3f1021164e73b3a4d729cd1963 URL: https://github.com/llvm/llvm-project/commit/2744d9b649f79a3f1021164e73b3a4d729cd1963 DIFF: https://github.com/llvm/llvm-project/commit/2744d9b649f79a3f1021164e73b3a4d729cd1963.diff LO

[PATCH] D156400: [clang][Interp] Implement __builtin_offsetof

2023-09-09 Thread Corentin Jabot via Phabricator via cfe-commits
cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM, thanks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156400/new/ https://reviews.llvm.org/D156400 ___ cfe-commits mailing list c

[clang] [Clang][RISCV] Use Decl for checkRVVTypeSupport (PR #65778)

2023-09-09 Thread Yueh-Ting Chen via cfe-commits
https://github.com/eopXD updated https://github.com/llvm/llvm-project/pull/65778: >From 91e607dd38475ceae604c794e40bd1721aa7dae4 Mon Sep 17 00:00:00 2001 From: eopXD Date: Fri, 8 Sep 2023 09:59:25 -0700 Subject: [PATCH] [Clang][RISCV] Use Decl for checkRVVTypeSupport Using ValueDecl will cause

[clang] [Clang][RISCV] Use Decl for checkRVVTypeSupport (PR #65778)

2023-09-09 Thread Yueh-Ting Chen via cfe-commits
https://github.com/eopXD resolved https://github.com/llvm/llvm-project/pull/65778 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][RISCV] Use Decl for checkRVVTypeSupport (PR #65778)

2023-09-09 Thread Yueh-Ting Chen via cfe-commits
https://github.com/eopXD review_requested https://github.com/llvm/llvm-project/pull/65778 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][RISCV] Use Decl for checkRVVTypeSupport (PR #65778)

2023-09-09 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65778 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][RISCV] Use Decl for checkRVVTypeSupport (PR #65778)

2023-09-09 Thread Yueh-Ting Chen via cfe-commits
https://github.com/eopXD resolved https://github.com/llvm/llvm-project/pull/65778 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][RISCV] Use Decl for checkRVVTypeSupport (PR #65778)

2023-09-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes Using ValueDecl will cause error for OpenMP. Decl should do the work. -- Full diff: https://github.com/llvm/llvm-project/pull/65778.diff 4 Files Affected: - (modified) clang/include/clang/Sema/Sema.h (+1-1) - (modified) clang/lib/Sema/SemaCh

[clang] [Clang] Allow mixed scalar type constraints for inline asm (PR #65465)

2023-09-09 Thread via cfe-commits
https://github.com/cor3ntin labeled https://github.com/llvm/llvm-project/pull/65465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Allow mixed scalar type constraints for inline asm (PR #65465)

2023-09-09 Thread via cfe-commits
https://github.com/cor3ntin unlabeled https://github.com/llvm/llvm-project/pull/65465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

2023-09-09 Thread via cfe-commits
https://github.com/cor3ntin unlabeled https://github.com/llvm/llvm-project/pull/65748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Replace llvm.memcpy et al's i1 isVolatile with i8 VolFlags (PR #65748)

2023-09-09 Thread via cfe-commits
https://github.com/cor3ntin labeled https://github.com/llvm/llvm-project/pull/65748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [MLIR] Enabling Intel GPU Integration. (PR #65539)

2023-09-09 Thread Guray Ozen via cfe-commits
@@ -811,8 +812,13 @@ LogicalResult ConvertAllocOpToGpuRuntimeCallPattern::matchAndRewrite( // descriptor. Type elementPtrType = this->getElementPtrType(memRefType); auto stream = adaptor.getAsyncDependencies().front(); + + auto isHostShared = rewriter.create( + loc

[clang-tools-extra] [MLIR] Enabling Intel GPU Integration. (PR #65539)

2023-09-09 Thread Guray Ozen via cfe-commits
@@ -811,8 +812,13 @@ LogicalResult ConvertAllocOpToGpuRuntimeCallPattern::matchAndRewrite( // descriptor. Type elementPtrType = this->getElementPtrType(memRefType); auto stream = adaptor.getAsyncDependencies().front(); + + auto isHostShared = rewriter.create( + loc

[clang] [Clang][RISCV] Use Decl for checkRVVTypeSupport (PR #65778)

2023-09-09 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev approved this pull request. LG https://github.com/llvm/llvm-project/pull/65778 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST] Only dump desugared type when visibly different (PR #65214)

2023-09-09 Thread Aaron Ballman via cfe-commits
@@ -49,6 +49,28 @@ ABI Changes in This Version - Following the SystemV ABI for x86-64, ``__int128`` arguments will no longer be split between a register and a stack slot. +AST Dumping Potentially Breaking Changes AaronBallman wrote: Fantastic release note!!

[clang] [AST] Only dump desugared type when visibly different (PR #65214)

2023-09-09 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/65214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST] Only dump desugared type when visibly different (PR #65214)

2023-09-09 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM, thank you! https://github.com/llvm/llvm-project/pull/65214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] BreakBeforeNoexceptSpecifier option added (PR #65808)

2023-09-09 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks resolved https://github.com/llvm/llvm-project/pull/65808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] BreakBeforeNoexceptSpecifier option added (PR #65808)

2023-09-09 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks updated https://github.com/llvm/llvm-project/pull/65808: From d0415b4436a11e649fbeae53b8060f70bae03254 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn=20Sch=C3=A4pers?= Date: Fri, 8 Sep 2023 13:07:09 +0200 Subject: [PATCH 1/2] [clang-format] BreakBefore

[clang] [clang-format] BreakBeforeNoexceptSpecifier option added (PR #65808)

2023-09-09 Thread via cfe-commits
=?utf-8?q?Björn_Schäpers?= https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] BreakBeforeNoexceptSpecifier option added (PR #65808)

2023-09-09 Thread via cfe-commits
=?utf-8?q?Björn_Schäpers?= https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] BreakBeforeNoexceptSpecifier option added (PR #65808)

2023-09-09 Thread via cfe-commits
=?utf-8?q?Björn_Schäpers?= llvmbot wrote: @llvm/pr-subscribers-clang Changes It really bugs me that it breaks to ``` c++ ...) noexcept( noexcept(condition)... ``` This is a fix for people like me. -- Full diff: https://github.com/llvm/llvm-project/pull/65808.diff 7 Files Affected: - (

[clang] [clang-format] BreakBeforeNoexceptSpecifier option added (PR #65808)

2023-09-09 Thread via cfe-commits
=?utf-8?q?Björn_Schäpers?= llvmbot wrote: @llvm/pr-subscribers-clang-format Changes It really bugs me that it breaks to ``` c++ ...) noexcept( noexcept(condition)... ``` This is a fix for people like me. -- Full diff: https://github.com/llvm/llvm-project/pull/65808.diff 7 Files Affecte

[clang] [clang][Interp] Add IntegralAP for arbitrary-precision integers (PR #65844)

2023-09-09 Thread via cfe-commits
@@ -117,7 +118,8 @@ std::optional Context::classify(QualType T) const { case 8: return PT_Uint8; default: - return std::nullopt; + return PT_IntAP; + // return std::nullopt; yronglin wrote: Can this comment be remove? https://git

[clang] [clang][Interp] Add IntegralAP for arbitrary-precision integers (PR #65844)

2023-09-09 Thread Timm Baeder via cfe-commits
@@ -117,7 +118,8 @@ std::optional Context::classify(QualType T) const { case 8: return PT_Uint8; default: - return std::nullopt; + return PT_IntAP; + // return std::nullopt; tbaederr wrote: Yes. There are a few such comments left

[clang] add define2 pp directive (PR #65851)

2023-09-09 Thread via cfe-commits
https://github.com/kelbon review_requested https://github.com/llvm/llvm-project/pull/65851 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] add define2 pp directive (PR #65851)

2023-09-09 Thread via cfe-commits
https://github.com/kelbon review_requested https://github.com/llvm/llvm-project/pull/65851 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] add define2 pp directive (PR #65851)

2023-09-09 Thread via cfe-commits
https://github.com/kelbon created https://github.com/llvm/llvm-project/pull/65851: Add 'define2' directive, which works as 'define', but allows recursive macros Motivation: * There are huge amount of code, which uses code generation/ boiler plate macros /misused terrible templates which is b

[clang] [Clang][RISCV] Use Decl for checkRVVTypeSupport (PR #65778)

2023-09-09 Thread Yueh-Ting Chen via cfe-commits
eopXD wrote: @jrtc27 Anymore comments before merging this? https://github.com/llvm/llvm-project/pull/65778 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] add define2 pp directive (PR #65851)

2023-09-09 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65851 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] add define2 pp directive (PR #65851)

2023-09-09 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65851 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] add define2 pp directive (PR #65851)

2023-09-09 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65851 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Extension: allow recursive macros (PR #65851)

2023-09-09 Thread via cfe-commits
https://github.com/kelbon edited https://github.com/llvm/llvm-project/pull/65851 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Extension: allow recursive macros (PR #65851)

2023-09-09 Thread via cfe-commits
cor3ntin wrote: Compiler extensions are best proposed through a RFC, ie a discourse post here: https://discourse.llvm.org/c/clang/6 Explaining the motivation for the feature, which the pr description already does a good job. There are questions about the name, theorically this is an identifie

[clang] c23d65b - [clang] NFCI: Use `FileEntryRef` in `ModuleMapParser`

2023-09-09 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-09-09T09:12:35-07:00 New Revision: c23d65b90fb7fb07cb12e2d70d0c34376b8fcdad URL: https://github.com/llvm/llvm-project/commit/c23d65b90fb7fb07cb12e2d70d0c34376b8fcdad DIFF: https://github.com/llvm/llvm-project/commit/c23d65b90fb7fb07cb12e2d70d0c34376b8fcdad.diff L

[clang] 37b0889 - [clang] NFCI: Use `FileEntryRef` in `ModuleMap`

2023-09-09 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-09-09T09:12:35-07:00 New Revision: 37b08892fc1ada83f09b4630190f8fb7346923cd URL: https://github.com/llvm/llvm-project/commit/37b08892fc1ada83f09b4630190f8fb7346923cd DIFF: https://github.com/llvm/llvm-project/commit/37b08892fc1ada83f09b4630190f8fb7346923cd.diff L

[clang] ef99617 - [clang] NFCI: Use `FileEntryRef` in `diagnoseFrameworkInclude()`

2023-09-09 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-09-09T09:12:35-07:00 New Revision: ef996175a7d38f7b4a0b60264dc861ab36376a47 URL: https://github.com/llvm/llvm-project/commit/ef996175a7d38f7b4a0b60264dc861ab36376a47 DIFF: https://github.com/llvm/llvm-project/commit/ef996175a7d38f7b4a0b60264dc861ab36376a47.diff L

[PATCH] D141757: [clangd] allow extracting to variable for lambda expressions

2023-09-09 Thread Julian Schmidt via Phabricator via cfe-commits
5chmidti updated this revision to Diff 556348. 5chmidti added a comment. addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141757/new/ https://reviews.llvm.org/D141757 Files: clang-tools-extra/clangd/refactor/tweaks/ExtractVariabl

[PATCH] D141757: [clangd] allow extracting to variable for lambda expressions

2023-09-09 Thread Julian Schmidt via Phabricator via cfe-commits
5chmidti updated this revision to Diff 556349. 5chmidti added a comment. Fixup to last revision change: - do not block the partial selection of lambdas There is no reason to block the partial selection of lambdas. Other expressions can be partially selected as well and still offer an extraction

[PATCH] D157911: clang: Add __builtin_exp10* and use new llvm.exp10 intrinsic

2023-09-09 Thread Serge Pavlov via Phabricator via cfe-commits
sepavloff accepted this revision. sepavloff added a comment. This revision is now accepted and ready to land. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157911/new/ https://reviews.llvm.org/D157911 ___ cfe-commits mailing list cfe-co

[PATCH] D141757: [clangd] allow extracting to variable for lambda expressions

2023-09-09 Thread Julian Schmidt via Phabricator via cfe-commits
5chmidti marked an inline comment as done. 5chmidti added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:187 +// Allow expressions, but only allow completely selected lambda +// expressions or unselected lambda expression

[clang] Extension: allow recursive macros (PR #65851)

2023-09-09 Thread via cfe-commits
kelbon wrote: > There are questions about the name, theorically this is an identifier that c > and c++ committees may want to use in the future. Yes, the name define2 is a placeholder, but the more I look at it, the more it looks appropriate > Is this something you plan to propose to other

[clang-tools-extra] 98e6deb - [clang][tools] Use `FileEntryRef` in `include_cleaner::Header`

2023-09-09 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-09-09T09:54:13-07:00 New Revision: 98e6deb62cefaa7d5c67081bd5b72ad26bada46e URL: https://github.com/llvm/llvm-project/commit/98e6deb62cefaa7d5c67081bd5b72ad26bada46e DIFF: https://github.com/llvm/llvm-project/commit/98e6deb62cefaa7d5c67081bd5b72ad26bada46e.diff L

[clang] Update GoogleTest to v1.14.0 (PR #65823)

2023-09-09 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/65823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Update GoogleTest to v1.14.0 (PR #65823)

2023-09-09 Thread Fangrui Song via cfe-commits
MaskRay wrote: Thank you for the change! `ninja check-llvm check-clang check-clang-tools check-flang check-mlir check-lld check-polly` parses. > The GoogleTest code also uses a different code style (Google C++ style > instead of LLVM style). Shall I reformat the entire GoogleTest code base? I

[clang-tools-extra] eea232d - [clang][tools] Remove path separator assumption

2023-09-09 Thread Jan Svoboda via cfe-commits
Author: Jan Svoboda Date: 2023-09-09T11:38:32-07:00 New Revision: eea232da827abae1a4fd71a0fb1f4d239d7b2f6a URL: https://github.com/llvm/llvm-project/commit/eea232da827abae1a4fd71a0fb1f4d239d7b2f6a DIFF: https://github.com/llvm/llvm-project/commit/eea232da827abae1a4fd71a0fb1f4d239d7b2f6a.diff L

[PATCH] D159064: [Modules] Make clang modules for the C standard library headers

2023-09-09 Thread Ian Anderson via Phabricator via cfe-commits
iana updated this revision to Diff 556355. iana added a comment. - Drop the -verify off the new tests so that I can get the full errors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159064/new/ https://reviews.llvm.org/D159064 Files: clang/lib/B

[clang] Extension: allow recursive macros (PR #65851)

2023-09-09 Thread Emilia Kond via cfe-commits
rymiel wrote: How would you deal with the issue of infinite loops? The following program: ```cpp #define2 boom(X) boom(X) boom(0) ``` Will continue to infinitely(?) consume memory until it is killed, either by the user or due to running out of memory on the system https://github.com/llvm/llv

[PATCH] D159064: [Modules] Make clang modules for the C standard library headers

2023-09-09 Thread Ian Anderson via Phabricator via cfe-commits
iana updated this revision to Diff 556356. iana added a comment. - Drop the -verify off the stddef tests so that I can get the full errors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159064/new/ https://reviews.llvm.org/D159064 Files: clang/li

[clang] [AST] Only dump desugared type when visibly different (PR #65214)

2023-09-09 Thread Jessica Clarke via cfe-commits
https://github.com/jrtc27 review_requested https://github.com/llvm/llvm-project/pull/65214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AST] Only dump desugared type when visibly different (PR #65214)

2023-09-09 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. ", where the aka will be skipped" in the commit message still doesn't make sense to me , otherwise lgtm https://github.com/llvm/llvm-project/pull/65214 ___ cfe-commits mailing list cfe-commits@li

[clang] [AST] Only dump desugared type when visibly different (PR #65214)

2023-09-09 Thread Jessica Clarke via cfe-commits
jrtc27 wrote: > ", where the aka will be skipped" in the commit message still doesn't make > sense to me , otherwise lgtm Comments in Clang's ASTDiagnostic use "aka" and "aka clause" synonymously, referring to the parenthesised clause in `'foo' (aka 'bar')` that is sometimes printed in diagno

[clang] 6a08cf1 - clang: Add __builtin_exp10* and use new llvm.exp10 intrinsic

2023-09-09 Thread Matt Arsenault via cfe-commits
Author: Matt Arsenault Date: 2023-09-09T23:14:12+03:00 New Revision: 6a08cf12d9cbc960159bf40e47078a882ca510ce URL: https://github.com/llvm/llvm-project/commit/6a08cf12d9cbc960159bf40e47078a882ca510ce DIFF: https://github.com/llvm/llvm-project/commit/6a08cf12d9cbc960159bf40e47078a882ca510ce.diff

[PATCH] D157911: clang: Add __builtin_exp10* and use new llvm.exp10 intrinsic

2023-09-09 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm closed this revision. arsenm added a comment. 6a08cf12d9cbc960159bf40e47078a882ca510ce CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157911/new/ https://reviews.llvm.org/D157911 __

[clang] [clang-format] BreakBeforeNoexceptSpecifier option added (PR #65808)

2023-09-09 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks updated https://github.com/llvm/llvm-project/pull/65808: From 3d3b20f66212f86bd46853432f1be31e5977df83 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bj=C3=B6rn=20Sch=C3=A4pers?= Date: Fri, 8 Sep 2023 13:07:09 +0200 Subject: [PATCH] [clang-format] BreakBeforeNoex

[clang] 84e3fdf - [clang-format] BreakBeforeNoexceptSpecifier option added (#65808)

2023-09-09 Thread via cfe-commits
Author: Björn Schäpers Date: 2023-09-09T22:31:58+02:00 New Revision: 84e3fdfc65232a4c940c2c3c9a2a8fe6c9b7806d URL: https://github.com/llvm/llvm-project/commit/84e3fdfc65232a4c940c2c3c9a2a8fe6c9b7806d DIFF: https://github.com/llvm/llvm-project/commit/84e3fdfc65232a4c940c2c3c9a2a8fe6c9b7806d.diff

[clang] [clang-format] BreakBeforeNoexceptSpecifier option added (PR #65808)

2023-09-09 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks closed https://github.com/llvm/llvm-project/pull/65808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][TSA] Consider cleanup functions for thread safety analysis (PR #65462)

2023-09-09 Thread Aaron Puchert via cfe-commits
Timm =?utf-8?q?Bäder?= aaronpuchert wrote: We still have until the end of September to finish the review on Phabricator. I would suggest that we keep the review there until we have to move. Here I can't see the difference to the last version that I reviewed. https://github.com/llvm/llvm-proj

[clang] Extension: allow recursive macros (PR #65851)

2023-09-09 Thread via cfe-commits
kelbon wrote: > How would you deal with the issue of infinite loops? The following program: > > ```c++ > #define2 boom(X) boom(X) > > boom(0) > ``` > > Will continue to infinitely(?) consume memory until it is killed, either by > the user or due to running out of memory on the system As fo o

[clang] [clang-format] Properly indent lines inside Verilog case structure (PR #65861)

2023-09-09 Thread via cfe-commits
https://github.com/sstwcw created https://github.com/llvm/llvm-project/pull/65861: When a statement following a case label had to be broken into multiple lines, the continuation parts were not indented correctly. Old: ```Verilog case (data) 16'd0: result = // break here 10'b0111

[clang] [clang-format] Properly indent lines inside Verilog case structure (PR #65861)

2023-09-09 Thread via cfe-commits
https://github.com/sstwcw review_requested https://github.com/llvm/llvm-project/pull/65861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Properly indent lines inside Verilog case structure (PR #65861)

2023-09-09 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Properly indent lines inside Verilog case structure (PR #65861)

2023-09-09 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Properly indent lines inside Verilog case structure (PR #65861)

2023-09-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes When a statement following a case label had to be broken into multiple lines, the continuation parts were not indented correctly. Old: ```Verilog case (data) 16'd0: result = // break here 10'b01; endcase ``` New: ```Veril

[clang] [clang-format] Properly indent lines inside Verilog case structure (PR #65861)

2023-09-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Changes When a statement following a case label had to be broken into multiple lines, the continuation parts were not indented correctly. Old: ```Verilog case (data) 16'd0: result = // break here 10'b01; endcase ``` New: `

[clang] Update GoogleTest to v1.14.0 (PR #65823)

2023-09-09 Thread Mehdi Amini via cfe-commits
https://github.com/joker-eph approved this pull request. Agree with @MaskRay for the style: we should minimize the diff with upstream as much as possible! https://github.com/llvm/llvm-project/pull/65823 ___ cfe-commits mailing list cfe-commits@lists.l

[clang] [Clang][OpenMP] Emit unroll directive w/o captured region (PR #65862)

2023-09-09 Thread Shilei Tian via cfe-commits
https://github.com/shiltian review_requested https://github.com/llvm/llvm-project/pull/65862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][OpenMP] Emit unroll directive w/o captured region (PR #65862)

2023-09-09 Thread Shilei Tian via cfe-commits
https://github.com/shiltian created https://github.com/llvm/llvm-project/pull/65862: The front end doesn't create captured region for unroll directive. This leads to a crash when `-fopenmp-simd` is used, as reported in #63570. Fix #63570. >From 7ba55161a5d24e9d67c00696bca9e4d06b907689 Mon Sep

[clang] [Clang][OpenMP] Emit unroll directive w/o captured region (PR #65862)

2023-09-09 Thread Shilei Tian via cfe-commits
https://github.com/shiltian review_requested https://github.com/llvm/llvm-project/pull/65862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][OpenMP] Emit unroll directive w/o captured region (PR #65862)

2023-09-09 Thread Shilei Tian via cfe-commits
https://github.com/shiltian review_requested https://github.com/llvm/llvm-project/pull/65862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][OpenMP] Emit unroll directive w/o captured region (PR #65862)

2023-09-09 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][OpenMP] Emit unroll directive w/o captured region (PR #65862)

2023-09-09 Thread via cfe-commits
https://github.com/llvmbot labeled https://github.com/llvm/llvm-project/pull/65862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][OpenMP] Emit unroll directive w/o captured region (PR #65862)

2023-09-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Changes The front end doesn't create captured region for unroll directive. This leads to a crash when `-fopenmp-simd` is used, as reported in #63570. Fix #63570. -- Full diff: https://github.com/llvm/llvm-project/pull/65862.diff 2 Files Affected: -

[clang] [Clang][OpenMP] Emit unroll directive w/o captured region (PR #65862)

2023-09-09 Thread Shilei Tian via cfe-commits
https://github.com/shiltian edited https://github.com/llvm/llvm-project/pull/65862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][OpenMP] Emit unroll directive w/o captured stmt (PR #65862)

2023-09-09 Thread Shilei Tian via cfe-commits
https://github.com/shiltian edited https://github.com/llvm/llvm-project/pull/65862 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implement [[msvc::no_unique_address]] (PR #65675)

2023-09-09 Thread via cfe-commits
cor3ntin wrote: We should consider whether we want to support __msvc_no_unique_address__ or similar https://github.com/llvm/llvm-project/issues/61196 https://github.com/llvm/llvm-project/pull/65675 ___ cfe-commits mailing list cfe-commits@lists.llvm.

  1   2   >