[PATCH] D154382: [ClangRepl] support code completion at a REPL

capfredf updated this revision to Diff 552736. capfredf added a comment. Herald added a subscriber: kadircet. Herald added a project: clang-tools-extra. fix code in Clangd Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154382/new/ https://reviews.ll

[PATCH] D155775: [HIP][Clang][Driver][RFC] Add driver support for C++ Parallel Algorithm Offload

AlexVlx updated this revision to Diff 552738. AlexVlx added a comment. Use `--hipstdpar` instead of `-hipstdpar` in the test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155775/new/ https://reviews.llvm.org/D155775 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/i

[PATCH] D158140: WIP: [clang-repl] Basic WebAssembly support for running inside a JS engine

v.g.vassilev added inline comments. Comment at: clang/lib/Interpreter/WASM.cpp:79 + int Result = + lld::wasm::link(LinkerArgs, llvm::outs(), llvm::errs(), false, false); + if (!Result) sbc100 wrote: > argentite wrote: > > v.g.vassilev wrote: > > > I am not

[PATCH] D155858: Add a concept AST node.

massberg updated this revision to Diff 552742. massberg marked 4 inline comments as done. massberg added a comment. Resolved the next round of comments. There are still some left to be addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155858/

[PATCH] D158562: [clang][Sema] Add truncation warning on fortified snprintf

nickdesaulniers added a comment. Thanks for the patch! Comment at: clang/lib/Sema/SemaChecking.cpp:1134 }; + auto ProcessFormatStringLiteral = + [&](const Expr *FormatExpr, StringRef &FormatStrRef, size_t &StrLen) { naive question, so will we create a

[PATCH] D158140: WIP: [clang-repl] Basic WebAssembly support for running inside a JS engine

sbc100 added a comment. ood idea after all. Is there a suitable place where we could mo Comment at: clang/lib/Interpreter/WASM.cpp:79 + int Result = + lld::wasm::link(LinkerArgs, llvm::outs(), llvm::errs(), false, false); + if (!Result) v.g.vassilev wrot

[PATCH] D158430: [flang][driver] Mark -fuse-ld as visible in Flang

kiranchandramohan added a comment. @erjin Could you land this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158430/new/ https://reviews.llvm.org/D158430 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D157283: [clang] Match -isysroot behaviour with system compiler on Darwin

jroelofs accepted this revision. jroelofs added a comment. This revision is now accepted and ready to land. LGTM, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157283/new/ https://reviews.llvm.org/D157283 ___

[PATCH] D158071: [clang] Remove rdar links; NFC

JDevlieghere added a comment. I had a cursory look and the handful of radar links I opened and read through didn't have any context that wasn't already in the tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158071/new/ https://reviews.llvm.or

[PATCH] D158008: [AArch64] Add patterns for FMADD, FMSUB

dzhidzhoev accepted this revision. dzhidzhoev added a subscriber: arsenm. dzhidzhoev added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:5393 + (EXTRACT_SUBREG V128:$Rn, hsub), FPR16:$Rm, FPR16:$Ra)>; + } + overmighty w

[PATCH] D155769: [HIP][Clang][docs][RFC] Add documentation for C++ Parallel Algorithm Offload

AlexVlx updated this revision to Diff 552754. AlexVlx added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a reviewer: kiranchandramohan. Herald added a project: LLVM. Update per review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155769/new/ https

[clang] c73de29 - [clang][doc] Mentions -Wno-reserved-module-identifiers

Author: Mark de Wever Date: 2023-08-23T18:31:29+02:00 New Revision: c73de296916274e35cb509bc8f612c559e054efc URL: https://github.com/llvm/llvm-project/commit/c73de296916274e35cb509bc8f612c559e054efc DIFF: https://github.com/llvm/llvm-project/commit/c73de296916274e35cb509bc8f612c559e054efc.diff

[PATCH] D158523: [clang][doc] Mentions -Wno-reserved-module-identifiers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc73de2969162: [clang][doc] Mentions -Wno-reserved-module-identifiers (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D158582: [AMDGPU] Respect unresolved symbol option if forwarded to linker

lamb-j added a comment. Is void amdgpu::Linker::ConstructJob() constructing a job for the host linker or the device linker? Or both? > The `-Wl` and `-Xlinker` options are intended for the host linker and we > intentionally do not pass them to the device linker. In the example I'm testing, bot

[PATCH] D155769: [HIP][Clang][docs][RFC] Add documentation for C++ Parallel Algorithm Offload

yaxunl added a comment. seems some irrelevant change got into this patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155769/new/ https://reviews.llvm.org/D155769 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D158616: To allow RAV to visit initializer when bitfield and initializer both given

erichkeane added a comment. This needs a test and a release note, and it failed pre-commit CI. I don't have a good idea how to test this however, there is perhaps one of the visitor unit tests that can show this off? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[clang] dc8e46c - [flang][driver] Mark -fuse-ld as visible in Flang

Author: Hao Jin Date: 2023-08-23T12:53:16-04:00 New Revision: dc8e46c7e5ea5f98218c9789164ff410cc14079c URL: https://github.com/llvm/llvm-project/commit/dc8e46c7e5ea5f98218c9789164ff410cc14079c DIFF: https://github.com/llvm/llvm-project/commit/dc8e46c7e5ea5f98218c9789164ff410cc14079c.diff LOG:

[PATCH] D158430: [flang][driver] Mark -fuse-ld as visible in Flang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdc8e46c7e5ea: [flang][driver] Mark -fuse-ld as visible in Flang (authored by erjin, committed by bryanpkc). Repository: rG LLVM Github Monorepo C

[PATCH] D155769: [HIP][Clang][docs][RFC] Add documentation for C++ Parallel Algorithm Offload

AlexVlx updated this revision to Diff 552763. AlexVlx added a comment. Remove noise. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155769/new/ https://reviews.llvm.org/D155769 Files: clang/docs/HIPSupport.rst Index: clang/docs/HIPSupport.rst =

[PATCH] D155978: [SPIRV] Add SPIR-V logical triple.

Keenuts added inline comments. Comment at: llvm/unittests/TargetParser/TripleTest.cpp:1307 + EXPECT_TRUE(T.isSPIRV()); + T.setArch(Triple::spirv32); Keenuts wrote: > Anastasia wrote: > > pmatos wrote: > > > Keenuts wrote: > > > > pmatos wrote: > > > > > I am

[PATCH] D158572: [clang][modules] Use relative offsets for input files

benlangmuir added inline comments. Comment at: clang/include/clang/Serialization/ModuleFile.h:249 + /// Absolute offset of the start of the input-files block. + uint64_t InputFilesOffsetBase; + Doesn't `InputFilesCursor` already know where the input files block

[PATCH] D158582: WIP: [AMDGPU] Respect unresolved symbol option if forwarded to linker

lamb-j retitled this revision from "[AMDGPU] Respect unresolved symbol option if forwarded to linker" to "WIP: [AMDGPU] Respect unresolved symbol option if forwarded to linker". lamb-j edited the summary of this revision. lamb-j updated this revision to Diff 552773. lamb-j planned changes to this

[PATCH] D158582: [AMDGPU] Respect unresolved symbol option if forwarded to linker

lamb-j retitled this revision from "WIP: [AMDGPU] Respect unresolved symbol option if forwarded to linker" to "[AMDGPU] Respect unresolved symbol option if forwarded to linker". lamb-j updated this revision to Diff 552775. lamb-j requested review of this revision. Repository: rG LLVM Github Mo

[PATCH] D158626: [AArch64] Add missing vrnd intrinsics

dmgreen added a comment. Sounds good. Can you make sure you upload with context, it makes the patches easier to read in phabricator: https://llvm.org/docs/DeveloperPolicy.html#making-and-submitting-a-patch. Comment at: llvm/lib/Target/AArch64/AArch64InstrFormats.td:6297

[PATCH] D158582: [AMDGPU] Prepend --no-undefined option for linker instead of append

lamb-j retitled this revision from "[AMDGPU] Respect unresolved symbol option if forwarded to linker" to "[AMDGPU] Prepend --no-undefined option for linker instead of append". lamb-j updated this revision to Diff 552777. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D148997: [clang] Add a new annotation token: annot_repl_input_end

aaron.ballman added a comment. In D148997#4561620 , @v.g.vassilev wrote: > In D148997#4561614 , @bnbarham > wrote: > >> In D148997#4561577 , @v.g.vassilev >> wrote: >>

[PATCH] D158570: [Darwin][StableABI][ASan] Remove version mismatch check from stable abi shim

thetruestblue added a comment. Thinking about it, we might need to do the opposite as what I proposed here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158570/new/ https://reviews.llvm.org/D158570 ___

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

aaron.ballman added inline comments. Comment at: clang/lib/Headers/stddef.h:118-122 +#ifdef __cplusplus +namespace std { +typedef decltype(nullptr) nullptr_t; +} +using ::std::nullptr_t; ldionne wrote: > iana wrote: > > aaron.ballman wrote: > > > ldionne wrote: >

[clang] f24aa69 - [clang] Match -isysroot behaviour with system compiler on Darwin

Author: Dmitry Polukhin Date: 2023-08-23T18:10:18+01:00 New Revision: f24aa691aa4f25291db8f7c61c6e9007288859e7 URL: https://github.com/llvm/llvm-project/commit/f24aa691aa4f25291db8f7c61c6e9007288859e7 DIFF: https://github.com/llvm/llvm-project/commit/f24aa691aa4f25291db8f7c61c6e9007288859e7.dif

[PATCH] D157283: [clang] Match -isysroot behaviour with system compiler on Darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rGf24aa691aa4f: [clang] Match -isysroot behaviour with system compiler on Darwin (authored by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[PATCH] D158526: [clang] Properly print unnamed members in diagnostics

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158526/new/ https://reviews.llvm.org/D158526 ___

[PATCH] D158582: [AMDGPU] Prepend --no-undefined option for linker instead of append

yaxunl added inline comments. Comment at: clang/test/Driver/amdgpu-toolchain-opencl.cl:34 +// RUN: %clang -### --target=amdgcn-amd-amdhsa-opencl -Xlinker --unresolved-symbols=ignore-all -x cl -mcpu=fiji -nogpulib %s 2>&1 | FileCheck -check-prefix=CHK-LINK_UR %s +// CHK-LINK_UR:

[PATCH] D152054: [OpenMP] Codegen support for thread_limit on target directive

ABataev added inline comments. Comment at: clang/test/OpenMP/target_parallel_for_simd_tl_codegen.cpp:30 +// OMP51-NEXT: entry: +// OMP51-NEXT:[[DOTGLOBAL_TID__ADDR_I:%.*]] = alloca i32, align 4 +// OMP51-NEXT:[[DOTPART_ID__ADDR_I:%.*]] = alloca ptr, align 8 -

[PATCH] D157452: [RFC][Clang][Codegen] `std::type_info` needs special care with explicit address spaces

AlexVlx added a comment. Gentle ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157452/new/ https://reviews.llvm.org/D157452 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[PATCH] D158641: [AArch64][Android][DRAFT] Fix FMV ifunc resolver usage on old Android APIs.

ilinpv created this revision. ilinpv added reviewers: srhines, danielkiss, enh, MaskRay, rprichard. Herald added subscribers: Enna1, kristof.beyls, krytarowski. Herald added a project: All. ilinpv requested review of this revision. Herald added projects: clang, Sanitizers. Herald added subscribers:

[PATCH] D156054: [Clang][Sema] DR722 (nullptr and varargs) and missing -Wvarargs diagnostics

aaron.ballman added inline comments. Comment at: clang/test/SemaCXX/varargs.cpp:34 enum Unscoped1 { One = 0x7FFF }; - (void)__builtin_va_arg(ap, Unscoped1); // ok + (void)__builtin_va_arg(ap, Unscoped1); // expected-warning {{second argument to 'va_arg' is of promotable

[PATCH] D158329: [X86] Support arch=x86-64{,-v2,-v3,-v4} for target_clones attribute

MaskRay added a comment. (I think there is no action item on my side and this patch is good for review) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158329/new/ https://reviews.llvm.org/D158329 ___ cfe-

[clang] 6ff70ec - [OpenMP][NFC] Remove typo in test name

Author: Johannes Doerfert Date: 2023-08-23T10:40:30-07:00 New Revision: 6ff70ec60eae2f973c46c5d1d6a28684f21f1cb4 URL: https://github.com/llvm/llvm-project/commit/6ff70ec60eae2f973c46c5d1d6a28684f21f1cb4 DIFF: https://github.com/llvm/llvm-project/commit/6ff70ec60eae2f973c46c5d1d6a28684f21f1cb4.d

[PATCH] D158557: [clang] Fix crash in __builtin_strncmp and other related builtin functions

aaron.ballman added a comment. Precommit CI found issues that should be addressed, but otherwise the changes LGTM. You should add a release note for the fix, though! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158557/new/ https://reviews.llvm.org/D158557

[PATCH] D158557: [clang] Fix crash in __builtin_strncmp and other related builtin functions

erichkeane added a comment. I think there is value to ensuring we diagnose the negative-to-size_t conversion here, but I also think there is value to a CodeGen test to ensure we emit the correct value. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158557/new/ https://reviews.llvm.org/

[PATCH] D157810: [clang][ExtractAPI] Create extractapi::RecordLocation

Arsenic updated this revision to Diff 552794. Arsenic added a comment. - Create function to directly get DocComments from Decl CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157810/new/ https://reviews.llvm.org/D157810 Files: clang/include/clang/ExtractAPI/API.h clang/include/clang/

[PATCH] D158612: [flang][driver] Ensure negative flags have the same visibility as positive

MaskRay accepted this revision. MaskRay added inline comments. Comment at: flang/test/Driver/fintegrated-as.f90:15 +! +! Without `-fno-integrated-as` (default) / With `-fintegrated-as` +!-

[PATCH] D158301: Add back overriding-t-options for -m-version-min diagnostic

aaron.ballman added inline comments. Comment at: clang/test/Driver/darwin-version.c:217 // RUN: FileCheck --check-prefix=CHECK-VERSION-TNO-OSV1 %s -// CHECK-VERSION-TNO-OSV1: overriding '-mmacos-version-min=10.6' option with '-target x86_64-apple-macos10.11.2' +// CHECK-VERSI

[PATCH] D158573: [clang][modules] Move `UNHASHED_CONTROL_BLOCK` up in the AST file

benlangmuir added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:2685 + for (unsigned I = 0; I < ASTFileSignature::size; ++I) +Sig[I] = endian::readNext(Blob); + return Sig; uint8_t has no endianness and has alignment 1 anyway; you can j

[PATCH] D158646: [clang-tools-extra][ExtractAPI] create clang-symbolgraph-merger

Arsenic created this revision. Arsenic added a reviewer: dang. Arsenic added projects: All, clang-tools-extra. Herald added a reviewer: ributzka. Arsenic requested review of this revision. Create a clang tool to merge all the JSON symbolgraph emited by --emit-symbol-graph or -extract-api options

[PATCH] D158582: [AMDGPU] Prepend --no-undefined option for linker instead of append

lamb-j updated this revision to Diff 552803. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158582/new/ https://reviews.llvm.org/D158582 Files: clang/lib/Driver/ToolChains/AMDGPU.cpp clang/test/Driver/amdgpu-toolchain-opencl.cl clang/test/Drive

[PATCH] D158071: [clang] Remove rdar links; NFC

aaron.ballman added a comment. In D158071#4610454 , @JDevlieghere wrote: > I had a cursory look and the handful of radar links I opened and read through > didn't have any context that wasn't already in the tests. Thank you for the quick look! FWIW, I'm

[PATCH] D158582: [AMDGPU] Prepend --no-undefined option for linker instead of append

yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158582/new/ https://reviews.llvm.org/D158582 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D157452: [RFC][Clang][Codegen] `std::type_info` needs special care with explicit address spaces

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157452/new/ https://reviews.llvm.org/D157452 ___ cfe-commits mailing list cfe-

[PATCH] D158301: Add back overriding-t-options for -m-version-min diagnostic

MaskRay added inline comments. Comment at: clang/test/Driver/darwin-version.c:217 // RUN: FileCheck --check-prefix=CHECK-VERSION-TNO-OSV1 %s -// CHECK-VERSION-TNO-OSV1: overriding '-mmacos-version-min=10.6' option with '-target x86_64-apple-macos10.11.2' +// CHECK-VERSION-TNO

[PATCH] D158381: [OpenMP] Properly set static thread limit (w/o analysis)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc5488c8dcc8c: [OpenMP] Properly set static thread limit (w/o analysis) (authored by jdoerfert). Herald added projects: clang, OpenMP. Herald added su

[PATCH] D158383: [OpenMP] Add NVIDIA annotations for static grid thread limit

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf3958ce0086a: [OpenMP] Add NVIDIA annotations for static grid thread limit (authored by jdoerfert). Herald added a project: clang. Herald added a sub

[PATCH] D156259: [clang-format] Fix a bug that erroneously placed function arguments on a new line despite all arguments being able to fit on the same line.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd06b92391513: [clang-format] Fix a bug that wraps before function arguments (authored by jp4a50, committed by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[clang] d06b923 - [clang-format] Fix a bug that wraps before function arguments

Author: Jon Phillips Date: 2023-08-23T11:18:23-07:00 New Revision: d06b923915137c86e9f281e7fce28240e13665ea URL: https://github.com/llvm/llvm-project/commit/d06b923915137c86e9f281e7fce28240e13665ea DIFF: https://github.com/llvm/llvm-project/commit/d06b923915137c86e9f281e7fce28240e13665ea.diff

[PATCH] D158363: [clang-format] Fix segmentation fault when formatting nested namespaces

owenpan requested changes to this revision. owenpan added a comment. This revision now requires changes to proceed. It seems that you forgot to update the diff? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158363/new/ https://reviews.llvm.org/D158

[PATCH] D152752: [MS] Fix passing aligned records by value in some cases

rnk added a comment. Thanks, I think this is a clang bug. As I understand MSVC's behavior, we should not pass highly aligned variadic arguments indirectly: https://gcc.godbolt.org/z/Kr67xWTeE I'll follow up on that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D158476: [driver] Search for compatible Android runtime directories

smeenai added a comment. In D158476#4609243 , @srhines wrote: > This approach LGTM, assuming that https://reviews.llvm.org/D140925 lands as > well to ensure that the triple does use `androideabi`, since it would prevent > custom build setups from needin

[PATCH] D158657: [clang-tidy] Fix false-positives in misc-static-assert caused by non-constexpr variables

PiotrZSL created this revision. PiotrZSL added reviewers: alexfh, njames93, carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Ignore false-

[PATCH] D152752: [MS] Fix passing aligned records by value in some cases

aaron.ballman added a comment. In D152752#4611043 , @rnk wrote: > Thanks, I think this is a clang bug. As I understand MSVC's behavior, we > should not pass highly aligned variadic arguments indirectly: > https://gcc.godbolt.org/z/Kr67xWTeE > > I'll fol

[clang] b7a5492 - [OpenMP][FIX] Remove the version check line

Author: Johannes Doerfert Date: 2023-08-23T12:00:04-07:00 New Revision: b7a5492c1f84d7cff0a82e306f4d42374fb93879 URL: https://github.com/llvm/llvm-project/commit/b7a5492c1f84d7cff0a82e306f4d42374fb93879 DIFF: https://github.com/llvm/llvm-project/commit/b7a5492c1f84d7cff0a82e306f4d42374fb93879.d

[clang] 81792de - [OpenMP][FIX] Remove more version check lines

Author: Johannes Doerfert Date: 2023-08-23T12:02:28-07:00 New Revision: 81792de2b0a698d33a0685de698827f9f12320fd URL: https://github.com/llvm/llvm-project/commit/81792de2b0a698d33a0685de698827f9f12320fd DIFF: https://github.com/llvm/llvm-project/commit/81792de2b0a698d33a0685de698827f9f12320fd.d

[PATCH] D157547: Arm64EC entry/exit thunks, consolidated.

dpaoliello added a comment. Another issue: looks like the names in `AArch64Subtarget.h` need to be fully decorated, including the leading `#` - so `#__chkstk_arm64ec` and `#__security_check_cookie_arm64ec`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D158301: Add back overriding-t-options for -m-version-min diagnostic

aaron.ballman added inline comments. Comment at: clang/test/Driver/darwin-version.c:217 // RUN: FileCheck --check-prefix=CHECK-VERSION-TNO-OSV1 %s -// CHECK-VERSION-TNO-OSV1: overriding '-mmacos-version-min=10.6' option with '-target x86_64-apple-macos10.11.2' +// CHECK-VERSI

[PATCH] D158573: [clang][modules] Move `UNHASHED_CONTROL_BLOCK` up in the AST file

jansvoboda11 added a comment. Good suggestions all around, thanks! Comment at: clang/lib/Serialization/ASTWriter.cpp:1169 + writeSignature(Sig, Out); + std::copy_n(Out.begin(), Out.size(), Buffer.begin() + Offset); +}; I don't feel great about rem

[PATCH] D158558: [clang] - Add missing builtin name to AtomicExpr JSON dump

aaron.ballman added a comment. The changes LGTM as far as they go, but should we also update the `TextNodeDumper` at the same time? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158558/new/ https://reviews.llvm.org/D158558 ___

[PATCH] D158572: [clang][modules] Use relative offsets for input files

jansvoboda11 added inline comments. Comment at: clang/include/clang/Serialization/ModuleFile.h:249 + /// Absolute offset of the start of the input-files block. + uint64_t InputFilesOffsetBase; + benlangmuir wrote: > Doesn't `InputFilesCursor` already know where

[PATCH] D158433: [Clang] Do not change the type of captured vars when checking lambda constraints

erichkeane added a comment. I agree with this approach, and think we should backport this if at all possible. The original solution is a bit problematic, and I don't believe this solution is particularly risky. Comment at: clang/lib/Sema/SemaConcept.cpp:727 + } else +Fu

[clang] 0661533 - [AMDGPU] Prepend --no-undefined option for linker instead of append

Author: Jacob Lambert Date: 2023-08-23T12:25:01-07:00 New Revision: 0661533e4168202476d660d3b18bbe13db16cc43 URL: https://github.com/llvm/llvm-project/commit/0661533e4168202476d660d3b18bbe13db16cc43 DIFF: https://github.com/llvm/llvm-project/commit/0661533e4168202476d660d3b18bbe13db16cc43.diff

[PATCH] D158582: [AMDGPU] Prepend --no-undefined option for linker instead of append

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0661533e4168: [AMDGPU] Prepend --no-undefined option for linker instead of append (authored by lamb-j). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D158301: Add back overriding-t-options for -m-version-min diagnostic

MaskRay added inline comments. Comment at: clang/test/Driver/darwin-version.c:217 // RUN: FileCheck --check-prefix=CHECK-VERSION-TNO-OSV1 %s -// CHECK-VERSION-TNO-OSV1: overriding '-mmacos-version-min=10.6' option with '-target x86_64-apple-macos10.11.2' +// CHECK-VERSION-TNO

[PATCH] D158573: [clang][modules] Move `UNHASHED_CONTROL_BLOCK` up in the AST file

benlangmuir added inline comments. Comment at: clang/lib/Serialization/ASTWriter.cpp:1169 + writeSignature(Sig, Out); + std::copy_n(Out.begin(), Out.size(), Buffer.begin() + Offset); +}; jansvoboda11 wrote: > I don't feel great about removing `const

[PATCH] D158572: [clang][modules] Use relative offsets for input files

benlangmuir added inline comments. Comment at: clang/include/clang/Serialization/ModuleFile.h:249 + /// Absolute offset of the start of the input-files block. + uint64_t InputFilesOffsetBase; + jansvoboda11 wrote: > benlangmuir wrote: > > Doesn't `InputFilesCur

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

ldionne accepted this revision. ldionne added a comment. This revision is now accepted and ready to land. LGTM. I think what we discussed in https://reviews.llvm.org/D157757#inline-1534166 makes sense and we should do it, but it belongs to a different patch for sure. Anybody wants to take that

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

ldionne added a comment. Also we should figure out why the Clang modules build is failing on top of this, it doesn't look like a false positive. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157757/new/ https://reviews.llvm.org/D157757 __

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

iana marked 13 inline comments as done. iana added inline comments. Comment at: clang/lib/Headers/stddef.h:119-121 +namespace std { +typedef decltype(nullptr) nullptr_t; +} ldionne wrote: > You could reduce the diff by not reformatting this. That's what I did ini

[PATCH] D157283: [clang] Match -isysroot behaviour with system compiler on Darwin

PiotrZSL added a comment. I don't know how, but somehow this change breaks clang-tidy/infrastructure/clang-tidy-mac-libcxx.cpp test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157283/new/ https://reviews.llvm.org/D157283 __

[PATCH] D158665: [clang-tidy] Improve cppcoreguidelines-avoid-reference-coroutine-parameters check

PiotrZSL created this revision. PiotrZSL added reviewers: carlosgalvezp, njames93, ccotter. Herald added subscribers: ChuanqiXu, shchenz, kbarton, xazax.hun, nemanjai. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a

[PATCH] D158666: [Clang] Fix linker error for function multiversioning

eandrews created this revision. eandrews added reviewers: erichkeane, tahonermann, aaron.ballman, zsrkmyn. Herald added a project: All. eandrews requested review of this revision. Currently target_clones attribute results in a linker error when there are no multi-versioned function declarations i

[PATCH] D158666: [Clang] Fix linker error for function multiversioning

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. I think the .ifunc spelling was an oversight on my part when I implemented this, I didn't spend enough time investigating GCC's behavior when implementing this feature. I think the al

[PATCH] D158666: [Clang] Fix linker error for function multiversioning

erichkeane requested changes to this revision. erichkeane added a comment. This revision now requires changes to proceed. Accepted before I thought about the other order, so requesting changes so we can think this through... 1 thing we DO need to consider is how this works with OLDER versions of

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

iana marked an inline comment as done. iana added a comment. In D157757#4611425 , @ldionne wrote: > Also we should figure out why the Clang modules build is failing on top of > this, it doesn't look like a false positive. Where do you see that failure?

[PATCH] D158666: [Clang] Fix linker error for function multiversioning

eandrews added a comment. In D158666#4611481 , @erichkeane wrote: > I think the .ifunc spelling was an oversight on my part when I implemented > this, I didn't spend enough time investigating GCC's behavior when > implementing this feature. I think th

[PATCH] D158666: [Clang] Fix linker error for function multiversioning

erichkeane added a comment. In D158666#4611494 , @eandrews wrote: > In D158666#4611481 , @erichkeane > wrote: > >> I think the .ifunc spelling was an oversight on my part when I implemented >> this, I didn't spe

[PATCH] D157283: [clang] Match -isysroot behaviour with system compiler on Darwin

jroelofs added a comment. In D157283#4611447 , @PiotrZSL wrote: > I don't know how, but somehow this change breaks > clang-tidy/infrastructure/clang-tidy-mac-libcxx.cpp test. I think we have a patch for that... @ldionne WDYT about upstreaming 9edb9a711

[PATCH] D158666: [Clang] Fix linker error for function multiversioning

eandrews added a comment. In D158666#4611497 , @erichkeane wrote: > In D158666#4611494 , @eandrews > wrote: > >> In D158666#4611481 , @erichkeane >> wrote: >> >>> I thi

[PATCH] D157572: [clang] Add `[[clang::library_extension]]` attribute

philnik added a comment. In D157572#4606513 , @aaron.ballman wrote: > In D157572#4604595 , @philnik wrote: > >> In D157572#4604482 , >> @aaron.ballman wrote: >> Thi

[PATCH] D158668: Add getLikelyBranchWeight helper function

MatzeB created this revision. MatzeB added reviewers: lebedev.ri, spatel, davidxl, wenlei, hoy, paulkirth. Herald added subscribers: StephenFan, modimo, hiraditya, mcrosier. Herald added a project: All. MatzeB requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, w

[PATCH] D158668: Add getLikelyBranchWeight helper function

MatzeB added a comment. Putting this out as a strawman/RFC. Should we add this function to allow LLVM passes to construct "likely"/"unlikely" branch_weights metadata? (I need this in D158642 and D157462 ) Repository: rG LL

[clang] ebe82d4 - [Driver] Remove unneeded TargetTriple entry in TripleAliases. NFC

Author: Fangrui Song Date: 2023-08-23T13:53:36-07:00 New Revision: ebe82d4aa6c5223425e27a0eb0157f49701d1057 URL: https://github.com/llvm/llvm-project/commit/ebe82d4aa6c5223425e27a0eb0157f49701d1057 DIFF: https://github.com/llvm/llvm-project/commit/ebe82d4aa6c5223425e27a0eb0157f49701d1057.diff

[PATCH] D158671: [NFC][Clang] Fix static analyzer concerns

eandrews created this revision. eandrews added reviewers: aaron.ballman, tahonermann. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a reviewer: ributzka. Herald added a project: All. eandrews requested review of this revi

[PATCH] D158487: [PowerPC][altivec] Optimize codegen of vec_promote

nemanjai accepted this revision. nemanjai added a comment. This revision is now accepted and ready to land. LGTM. This is a good idea and we should go ahead with this for anyone that uses `vec_promote`, but it might be a good idea to improve codegen for the insert which might be more common.

[PATCH] D158223: [clang] Add clang::unnamed_addr attribute that marks globals' address as not significant

aeubanks updated this revision to Diff 552889. aeubanks edited the summary of this revision. aeubanks added a comment. add warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158223/new/ https://reviews.llvm.org/D158223 Files: clang/include/cl

[PATCH] D158223: [clang] Add clang::unnamed_addr attribute that marks globals' address as not significant

aeubanks added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1416-1417 +not significant. This allows global constants with the same contents to be +merged. This can break global pointer identity, i.e. two different globals have +the same address. + --

[PATCH] D158641: [AArch64][Android][DRAFT] Fix FMV ifunc resolver usage on old Android APIs.

rprichard added a comment. > further confirmation if android_get_device_api_level should work from > ifunc_resolver IIRC an ifunc resolver in Bionic can't generally call any functions in libc, including `android_get_device_api_level` or `__system_property_get`, because the ifunc resolver will

[PATCH] D158641: [AArch64][Android][DRAFT] Fix FMV ifunc resolver usage on old Android APIs.

MaskRay added inline comments. Comment at: clang/test/Driver/aarch64-features.c:10 // Check Function Multi Versioning option and rtlib dependency. -// RUN: %clang --target=aarch64-linux-android -rtlib=compiler-rt \ +// RUN: %clang --target=aarch64-linux-android23 -rtlib=compiler

[libunwind] 5eb44df - Make _LIBUNWIND_SUPPORT_FRAME_APIS a build-time option

Author: Sterling Augustine Date: 2023-08-23T14:34:40-07:00 New Revision: 5eb44df1b64dbd1a86b099128092a7fd2001c0ba URL: https://github.com/llvm/llvm-project/commit/5eb44df1b64dbd1a86b099128092a7fd2001c0ba DIFF: https://github.com/llvm/llvm-project/commit/5eb44df1b64dbd1a86b099128092a7fd2001c0ba.

[PATCH] D158641: [AArch64][Android][DRAFT] Fix FMV ifunc resolver usage on old Android APIs.

MaskRay added a comment. In D158641#4611731 , @rprichard wrote: > [...] > > I suspect Bionic ought to apply relocations to libraries in a bottom-up > fashion, so that libc.so is relocated before the executable or shared > objects, but I _think_ it's cur

[PATCH] D158223: [clang] Add clang::unnamed_addr attribute that marks globals' address as not significant

erichkeane added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1416-1417 +not significant. This allows global constants with the same contents to be +merged. This can break global pointer identity, i.e. two different globals have +the same address. +

[PATCH] D151575: [clang][diagnostics] Always show include stacks on top-level diagnostics

cjdb added a comment. In D151575#4607047 , @aaron.ballman wrote: > I am wrestling with this one because I think the status quo is unfortunate > (we silently drop relevant information in ways the user may not immediately > understand) but I think always

[PATCH] D158223: [clang] Add clang::unnamed_addr attribute that marks globals' address as not significant

aeubanks added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:1416-1417 +not significant. This allows global constants with the same contents to be +merged. This can break global pointer identity, i.e. two different globals have +the same address. + --

<    1   2   3   >