[PATCH] D148654: Modify BoundsSan to improve debuggability

oskarwirga updated this revision to Diff 550355. oskarwirga added a comment. Fix clang crash and retest Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148654/new/ https://reviews.llvm.org/D148654 Files: clang/lib/CodeGen/CGExpr.cpp clang/test/C

[PATCH] D157275: [Driver] Select newest GCC installation on Solaris

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:2258 - Prefixes.push_back(CandidatePrefix); + SolarisPrefixes.push_back(CandidatePrefix); } ---

[clang] eda9d27 - [clang][AST] TextNodeDumper learned to dump NRVO candidates of return stmts

Author: Timo Stripf Date: 2023-08-15T16:24:15Z New Revision: eda9d27a91e6f3bf6d7c65a300be729c410e93a7 URL: https://github.com/llvm/llvm-project/commit/eda9d27a91e6f3bf6d7c65a300be729c410e93a7 DIFF: https://github.com/llvm/llvm-project/commit/eda9d27a91e6f3bf6d7c65a300be729c410e93a7.diff LOG: [

[PATCH] D157687: [clang][AST] TextNodeDumper learned to dump NRVO candidates of return stmts

This revision was automatically updated to reflect the committed changes. Closed by commit rGeda9d27a91e6: [clang][AST] TextNodeDumper learned to dump NRVO candidates of return stmts (authored by strimo378). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D157963: [clang-format] Annotate constructor/destructor names

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/TokenAnnotator.cpp:3103 + if (!Next) +return Next; + if (Next->is(tok::comment)) Is a bit clea

[PATCH] D157994: [OpenMP] Migrate dispatch related utility functions from Clang codegen to OMPIRBuilder

TIFitis created this revision. TIFitis added reviewers: jsjodin, jdoerfert, raghavendhra. Herald added subscribers: guansong, hiraditya, yaxunl. Herald added a project: All. TIFitis requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jplehr, sstefan1. Herald adde

[PATCH] D157994: [OpenMP] Migrate dispatch related utility functions from Clang codegen to OMPIRBuilder

TIFitis added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPKinds.def:532 MemoryAttr(MemoryEffects::argMemOnly() | MemoryEffects::inaccessibleMemOnly(ModRefInfo::Ref))) -: AttributeSet(EnumAttr(NoUnwind))) __OMP_ATTRS_SET( ---

[PATCH] D157793: [Headers] Add missing __need_ macros to stdarg.h

jyknight added a comment. I'm a bit confused by this change vs its description. It looks like stdarg already supported `__need___va_list`, which is what you said Apple needs. Does Apple //also// require the other __need_va_copy/etc, too? If not, why add support for them? (I think we should pref

[PATCH] D157767: [Driver] move Haiku header search path management to the driver

nielx accepted this revision. nielx added a comment. This revision is now accepted and ready to land. I have applied the patch to a recent checkout of the llvm repository, and I then built clang. With this clang build I have built various source files that depend on headers that are in the syste

[PATCH] D157793: [Headers] Add missing __need_ macros to stdarg.h

iana added a comment. In D157793#4588909 , @jyknight wrote: > I'm a bit confused by this change vs its description. > > It looks like stdarg already supported `__need___va_list`, which is what you > said Apple needs. Does Apple //also// require the other

[PATCH] D157681: [clang][AST] TextNodeDumper learned to dump qualifiers (NestedNameSpecifier)

This revision was automatically updated to reflect the committed changes. Closed by commit rGcad3130a23da: [clang][AST] TextNodeDumper learned to dump qualifiers (NestedNameSpecifier) (authored by strimo378). Changed prior to commit: https://reviews.llvm.org/D157681?vs=549273&id=550387#toc Rep

[PATCH] D157808: [clang] Add missing field to VisibilityAttr json AST dump

DavidSpickett added a comment. We also had a failure looking for the mangled name on Windows on Arm: https://lab.llvm.org/buildbot/#/builders/65/builds/10954 The triple fix may take care of that too. > Also, consider spreading out commits a bit so that if one breaks something, > it's easily to

[PATCH] D155833: [Clang][Sema][RFC] Add Sema support for C++ Parallel Algorithm Offload

AlexVlx updated this revision to Diff 550391. AlexVlx added a comment. Update test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155833/new/ https://reviews.llvm.org/D155833 Files: clang/lib/Sema/SemaCUDA.cpp clang/lib/Sema/SemaExpr.cpp clang/lib/Sema/SemaStmtAsm.cpp clang/tes

[PATCH] D154869: [Flang] [FlangRT] Implement FlangRT library as solution to Flang's runtime LLVM integration

pscoro added inline comments. Comment at: flang/runtime/CMakeLists.txt:251 - INSTALL_WITH_TOOLCHAIN -) +if (DEFINED LLVM_ENABLE_RUNTIMES AND "flang-rt" IN_LIST LLVM_ENABLE_RUNTIMES) + add_flang_library(FortranRuntime STATIC efriedma wrote: > klausler wrote: >

[clang] f7f3e68 - [clang] Fix CCC_OVERRIDE_OPTIONS docstring to say "space separated" (NFC)

Author: Dave Lee Date: 2023-08-15T10:33:09-07:00 New Revision: f7f3e68419683f1498dcd93a9a3c86833b199e9c URL: https://github.com/llvm/llvm-project/commit/f7f3e68419683f1498dcd93a9a3c86833b199e9c DIFF: https://github.com/llvm/llvm-project/commit/f7f3e68419683f1498dcd93a9a3c86833b199e9c.diff LOG:

[clang] 6c36a70 - [clang] Fix f7f3e68419 (NFC)

Author: Dave Lee Date: 2023-08-15T10:36:00-07:00 New Revision: 6c36a70828d9f59cfd205cead109db3a79b50647 URL: https://github.com/llvm/llvm-project/commit/6c36a70828d9f59cfd205cead109db3a79b50647 DIFF: https://github.com/llvm/llvm-project/commit/6c36a70828d9f59cfd205cead109db3a79b50647.diff LOG:

[PATCH] D157833: [C++20] [Coroutines] Mark await_suspend as noinline if the awaiter is not empty

rjmccall added inline comments. Comment at: clang/docs/ReleaseNotes.rst:143 + after leaking the coroutine handle in the await_suspend may be converted to + unconditional access incorrectly. + (`#56301 `_) Sugg

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

efriedma added a comment. I was probably thinking of that, yes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126864/new/ https://reviews.llvm.org/D126864 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

steakhal added a comment. Thanks for the xrefs! It turns out I've already seen that one :D I'll look into it once more, with a fresh set of eyes. Thanks again! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126864/new/ https://reviews.llvm.org/D1268

[PATCH] D154869: [Flang] [FlangRT] Implement FlangRT library as solution to Flang's runtime LLVM integration

pscoro added a comment. Some of the testcases have been reformatted by clang-format when I updated the patch with arcanist. If the community is against introducing extra changes like these I would be happy to re-update my patch without clang-formatting these files. Repository: rG LLVM Githu

[PATCH] D155773: [llvm][MemoryBuiltins] Add alloca support to getInitialValueOfAllocation

jmciver added a comment. @nikic Thanks for responding. I will get a "work in progress" patch up in the next three days. In the API adaptation, instruction insertion is still being handled in the caller as some passes are only allowed removal and not insertion. Repository: rG LLVM Github Mon

[clang] cad3130 - [clang][AST] TextNodeDumper learned to dump qualifiers (NestedNameSpecifier)

Author: Timo Stripf Date: 2023-08-15T17:36:33Z New Revision: cad3130a23daa023d5bbf42b8ec8c06aa0532abf URL: https://github.com/llvm/llvm-project/commit/cad3130a23daa023d5bbf42b8ec8c06aa0532abf DIFF: https://github.com/llvm/llvm-project/commit/cad3130a23daa023d5bbf42b8ec8c06aa0532abf.diff LOG: [

[PATCH] D154869: [Flang] [FlangRT] Implement FlangRT library as solution to Flang's runtime LLVM integration

pscoro added a comment. In order to keep the scope of this patch manageable, and because further discussion is warranted first, no source files have been moved from flang into flang-rt. Although I would imagine that this may be something we would want to do in the future in order to continue ou

[PATCH] D158006: Member pack access in dependent context.

SlaterLatiao created this revision. Herald added a project: All. SlaterLatiao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D158006 Files: clang/include/clang/AST/ExprCXX.

[PATCH] D151567: [LLVM][Support] Report EISDIR when opening a directory on AIX

azhan92 updated this revision to Diff 550402. azhan92 added a comment. Address TOCTOU condition (will add updated test later). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151567/new/ https://reviews.llvm.org/D151567 Files: llvm/lib/Support/Uni

[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

hazohelet updated this revision to Diff 550403. hazohelet marked 16 inline comments as done. hazohelet added a comment. Address some review comments - Renamed `ConvertCharToString` to `WriteCharValueForDiagnostic` - Made the function static - Fixed the printing for unicode 0x80 ~ 0xFF - Added dec

[PATCH] D156312: [analyzer] Upstream BitwiseShiftChecker

steakhal accepted this revision. steakhal added a comment. In D156312#4588406 , @donat.nagy wrote: > After investigating this issue, I added the testcases > `signed_aritmetic_{good,bad}` which document the current sub-optimal state. > The root cause of

[PATCH] D154869: [Flang] [FlangRT] Implement FlangRT library as solution to Flang's runtime LLVM integration

efriedma added a comment. The test changes look good to me. Comment at: flang/lib/Decimal/CMakeLists.txt:52 -add_flang_library(FortranDecimal INSTALL_WITH_TOOLCHAIN - binary-to-decimal.cpp - decimal-to-binary.cpp -) +add_compile_options(-fPIC) + This `add_c

[PATCH] D158008: [AArch64] Add patterns for FMADD, FMSUB

overmighty created this revision. overmighty added reviewers: dmgreen, john.brawn, SjoerdMeijer. Herald added subscribers: arphaman, hiraditya, kristof.beyls. Herald added a project: All. overmighty requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llv

[PATCH] D154130: [lit][clang] Avoid realpath on Windows due to MAX_PATH limitations

tahonermann added inline comments. Comment at: clang/test/Lexer/case-insensitive-include-win.c:5-9 +// Note: We must use the real path here, because the logic to detect case +// mismatch relies on resolving the real path and checking that casing differs. +// If we use %t and we a

[PATCH] D154869: [Flang] [FlangRT] Implement FlangRT library as solution to Flang's runtime LLVM integration

pscoro added inline comments. Comment at: flang/lib/Decimal/CMakeLists.txt:52 -add_flang_library(FortranDecimal INSTALL_WITH_TOOLCHAIN - binary-to-decimal.cpp - decimal-to-binary.cpp -) +add_compile_options(-fPIC) + efriedma wrote: > This `add_compile_options

[PATCH] D157297: [clang] Fixes compile error that double colon operator cannot resolve macro with parentheses.

lygstate updated this revision to Diff 550413. lygstate added a comment. creating proper function definitions instead of macro define CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157297/new/ https://reviews.llvm.org/D157297 Files: clang/lib/Headers/bmiintrin.h Index: clang/lib/Head

[PATCH] D151567: [LLVM][Support] Report EISDIR when opening a directory on AIX

MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. Thanks for the patch, but there are two issues that should be fixed: (1) stat => fstat (2) change the subject to mean that this is not AIX specific (`[LLVM][Support] Report EISDIR

[PATCH] D74094: Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

lei added a comment. @nickdesaulniers I have verified this patch on top of `40ee8abee77a2e8fb0089d4c7f5723b71f27d416` passes our multistage bot http://lab.llvm.org:8011/builders/clang-ppc64be-linux-multistage Thank-you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

shenhan updated this revision to Diff 550423. shenhan marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157750/new/ https://reviews.llvm.org/D157750 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/li

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

shenhan marked 3 inline comments as done. shenhan added inline comments. Comment at: llvm/lib/CodeGen/TargetPassConfig.cpp:1278 } -addPass(createMachineFunctionSplitterPass()); +if (TM->getTargetTriple().isX86()) + addPass(createMachineFunctionSplitterPass()); -

[PATCH] D156897: [CodeGen] Clean up access to EmittedDeferredDecls, NFCI.

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. This looks reasonable to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156897/new/ https://reviews.llvm.org/D156897 ___

[PATCH] D156537: [CodeGen] Keep track of eagerly emitted globals

v.g.vassilev added a comment. In D156537#4587874 , @aaron.ballman wrote: > In D156537#4587832 , @v.g.vassilev > wrote: > >> @Hahnfeld, let's move forward and rely on a post-commit review here if >> necessary. >

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

hazohelet updated this revision to Diff 550433. hazohelet added a comment. Herald added subscribers: llvm-commits, wangpc, hoy, wlei, steakhal, abrachet, ormris, martong, MaskRay, hiraditya. Herald added a reviewer: NoQ. Herald added projects: LLVM, lld-macho. Herald added a reviewer: lld-macho.

[PATCH] D157479: [Clang][DebugInfo] Emit narrower base types for structured binding declarations that bind to struct bitfields

aprantl added a comment. New test LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157479/new/ https://reviews.llvm.org/D157479 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

nikic added a comment. Please split the warning fixes off into a separate patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152495/new/ https://reviews.llvm.org/D152495 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D156537: [CodeGen] Keep track of eagerly emitted globals

rjmccall added a comment. If we're avoiding the expense here when we're not emitting incremental extensions, this seems fine to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156537/new/ https://reviews.llvm.org/D156537 ___

[PATCH] D157379: [CodeGen] Restrict addEmittedDeferredDecl to incremental extensions

rjmccall accepted this revision. rjmccall added a comment. Thank you, this seems reasonable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157379/new/ https://reviews.llvm.org/D157379 ___ cfe-commits mai

[PATCH] D157994: [OpenMP] Migrate dispatch related utility functions from Clang codegen to OMPIRBuilder

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, but do not remove the Attribute from our set, add it to the tests. The functions are nounwind. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPKinds.def:532

[PATCH] D158016: [NFC] Remove unused variables declared in conditions

hazohelet created this revision. hazohelet added reviewers: nikic, aaron.ballman, MaskRay, tbaeder. Herald added subscribers: hoy, wlei, steakhal, abrachet, ormris, StephenFan, martong, hiraditya. Herald added a reviewer: NoQ. Herald added projects: lld-macho, All. Herald added a reviewer: lld-mac

[PATCH] D157150: [Driver] Update BoolOption to handle Visibility. NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0db9dfb19329: [Driver] Update BoolOption to handle Visibility. NFC (authored by bogner). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

hazohelet updated this revision to Diff 550443. hazohelet added a comment. Removed warning fixes that are now in D158016 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152495/new/ https://reviews.llvm.org/D152495 Files: clang/docs/ReleaseNotes.rst

[PATCH] D158006: [Clang][WIP]Experimental implementation of data member packs in dependent context.

cjdb added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:3292 + std::string NewFieldName = + PackedField->getName().str() + "@" + std::to_string(Arg); + PackedField->setDeclName(&Context.Idents.get(NewFieldName)); -

[clang] cda3198 - [clang] Add missing field to TLSModelAttr json AST dump

Author: serge-sans-paille Date: 2023-08-15T22:24:42+02:00 New Revision: cda319851fe7facf603c3930d5587e127d46b3b7 URL: https://github.com/llvm/llvm-project/commit/cda319851fe7facf603c3930d5587e127d46b3b7 DIFF: https://github.com/llvm/llvm-project/commit/cda319851fe7facf603c3930d5587e127d46b3b7.d

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

hazohelet added a comment. Thanks for the feedback. Comment at: clang/test/SemaCXX/warn-constant-evaluated-constexpr.cpp:38 constexpr int fn5() { - if constexpr (__builtin_is_constant_evaluated()) // expected-warning {{'__builtin_is_constant_evaluated' will always evaluate t

[PATCH] D158021: [clang][modules] Mark builtin header 'inttypes.h' for modules

benlangmuir created this revision. benlangmuir added reviewers: iana, jansvoboda11. Herald added a project: All. benlangmuir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Like the other enumerated builtin headers, inttypes.h can be declar

[PATCH] D158021: [clang][modules] Mark builtin header 'inttypes.h' for modules

iana added a subscriber: vsapsai. iana added a comment. Herald added a subscriber: ormris. Can you add @vsapsai to the reviewers please? He was looking at this one a year or two ago. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158021/new/ https:

[PATCH] D95299: Fix truncated __OPENMP_NVPTX__ preprocessor condition

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc49142e4f5c8: Fix truncated __OPENMP_NVPTX__ preprocessor condition (authored by r-burns, committed by mehdi_amini). Repository: rG LLVM Github Mo

[PATCH] D157445: [CodeGen][UBSan] Add support for handling attributed functions in getUBSanFunctionTypeHash.

usama54321 updated this revision to Diff 550475. usama54321 retitled this revision from "[CodeGen][UBSan] Add support for handling attributed functions in getUBSanFunctionTypeHash." to "[CodeGen][UBSan] Add support for handling attributed functions in getUBSanFunctionTypeHash.". usama54321 a

[PATCH] D158021: [clang][modules] Mark builtin header 'inttypes.h' for modules

benlangmuir updated this revision to Diff 550474. benlangmuir added a reviewer: vsapsai. benlangmuir added a comment. Add missing test updates: tests using the `Inputs/System/usr/include` should be using `-internal-isystem` to get the correct search path order with respect to the resource dir. T

[PATCH] D157445: [CodeGen][UBSan] Add support for handling attributed functions in getUBSanFunctionTypeHash.

usama54321 updated this revision to Diff 550477. usama54321 added a comment. Updated commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157445/new/ https://reviews.llvm.org/D157445 Files: clang/lib/CodeGen/CodeGenFunction.cpp clang/t

[PATCH] D157445: [CodeGen][UBSan] Add support for handling attributed functions in getUBSanFunctionTypeHash.

rapidsna accepted this revision. rapidsna added a comment. This revision is now accepted and ready to land. The changes look good to me. Ideally, we could add tests with multiple attributes and possibly with other sugar types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[clang] c49142e - Fix truncated __OPENMP_NVPTX__ preprocessor condition

Author: Ryan Burns Date: 2023-08-15T14:12:34-07:00 New Revision: c49142e4f5c8645a4d741d233f0cb55ef1ef87a2 URL: https://github.com/llvm/llvm-project/commit/c49142e4f5c8645a4d741d233f0cb55ef1ef87a2 DIFF: https://github.com/llvm/llvm-project/commit/c49142e4f5c8645a4d741d233f0cb55ef1ef87a2.diff LO

[clang] 43f314f - clang/HIP: Use abs builtins instead of implementing them

Author: Matt Arsenault Date: 2023-08-15T17:40:19-04:00 New Revision: 43f314f5e6cebe02ff63d5197c8e5c25204b20d2 URL: https://github.com/llvm/llvm-project/commit/43f314f5e6cebe02ff63d5197c8e5c25204b20d2 DIFF: https://github.com/llvm/llvm-project/commit/43f314f5e6cebe02ff63d5197c8e5c25204b20d2.diff

[PATCH] D157917: clang/HIP: Use abs builtins instead of implementing them

arsenm closed this revision. arsenm added a comment. 43f314f5e6cebe02ff63d5197c8e5c25204b20d2 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157917/new/ https://reviews.llvm.org/D157917 __

[PATCH] D157350: [clang][ExtractAPI] Add support for C++ variable templates

evelez7 updated this revision to Diff 550485. evelez7 added a comment. Get rid of unnecessary function for checking if global var Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157350/new/ https://reviews.llvm.org/D157350 Files: clang/include/cla

[clang] 64473f1 - [gcov] Use Joined = form for -coverage-notes-file and -coverage-data-file

Author: Fangrui Song Date: 2023-08-15T14:49:02-07:00 New Revision: 64473f1221fbc16af140407d5ea64d808f5853a7 URL: https://github.com/llvm/llvm-project/commit/64473f1221fbc16af140407d5ea64d808f5853a7 DIFF: https://github.com/llvm/llvm-project/commit/64473f1221fbc16af140407d5ea64d808f5853a7.diff

[PATCH] D154382: [ClangRepl] support code completion at a REPL

capfredf updated this revision to Diff 550489. capfredf marked 7 inline comments as done. capfredf added a comment. address @sammccall 's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154382/new/ https://reviews.llvm.org/D154382 Files:

[PATCH] D154382: [ClangRepl] support code completion at a REPL

capfredf added inline comments. Comment at: clang/include/clang/Frontend/ASTUnit.h:901 +SmallVectorImpl &OwnedBuffers, +std::function AfterBeginSourceFile = [](CompilerInstance& CI) -> void {}); sammccall wrote: > capfre

[PATCH] D154382: [ClangRepl] support code completion at a REPL

capfredf added a comment. @sammccall Thank you very much for your valuable input. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154382/new/ https://reviews.llvm.org/D154382 ___ cfe-commits mailing list c

[clang] 44e6c11 - [Driver] Remove -coverage-notes-file and -coverage-data-file in favor of their Joined = form

Author: Fangrui Song Date: 2023-08-15T14:58:55-07:00 New Revision: 44e6c114d974c80e4a88c1b93bfe646ac9b6d08d URL: https://github.com/llvm/llvm-project/commit/44e6c114d974c80e4a88c1b93bfe646ac9b6d08d DIFF: https://github.com/llvm/llvm-project/commit/44e6c114d974c80e4a88c1b93bfe646ac9b6d08d.diff

[PATCH] D158027: [clang][ExtractAPI] Visit method templates with better scheme

evelez7 created this revision. evelez7 added a reviewer: dang. Herald added a reviewer: ributzka. Herald added a project: All. evelez7 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Visit and serialize method templates and template special

[clang] 95ae517 - [Driver] Remove CLDXCFlag by allowing CLFlag to specify visibility. NFC

Author: Justin Bogner Date: 2023-08-15T15:00:19-07:00 New Revision: 95ae517bb4c332149b3c45cd7d1e6edf8b40077e URL: https://github.com/llvm/llvm-project/commit/95ae517bb4c332149b3c45cd7d1e6edf8b40077e DIFF: https://github.com/llvm/llvm-project/commit/95ae517bb4c332149b3c45cd7d1e6edf8b40077e.diff

[PATCH] D157445: [CodeGen][UBSan] Add support for handling attributed functions in getUBSanFunctionTypeHash.

MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/test/CodeGen/ubsan-function-attributed.c:3 + +// CHECK: .long248076293 +void __attribute__((ms_abi)) f(void) {} It's useful to add `// CHECK-LABEL: f:` interleaving with `.lo

[PATCH] D158027: [clang][ExtractAPI] Visit method templates with better scheme

evelez7 updated this revision to Diff 550500. evelez7 added a comment. Fix arbitrary include changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158027/new/ https://reviews.llvm.org/D158027 Files: clang/include/clang/ExtractAPI/API.h clang/i

[PATCH] D158029: [clang][ExtractAPI] Add support for C++ member templates

evelez7 created this revision. Herald added a reviewer: ributzka. Herald added a project: All. evelez7 requested review of this revision. Herald added a reviewer: dang. Herald added a project: clang. Herald added a subscriber: cfe-commits. Visit and serialize C++ fields by checking if a var templa

[clang] cf1c64b - [-Wunsafe-buffer-usage] Replace assert that declarations are always found

Author: Rashmi Mudduluru Date: 2023-08-15T15:41:56-07:00 New Revision: cf1c64b94d94105f61e308e57eb963b722d22d77 URL: https://github.com/llvm/llvm-project/commit/cf1c64b94d94105f61e308e57eb963b722d22d77 DIFF: https://github.com/llvm/llvm-project/commit/cf1c64b94d94105f61e308e57eb963b722d22d77.di

[PATCH] D157018: [-Wunsafe-buffer-usage] Replace assert that declarations are always found

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcf1c64b94d94: [-Wunsafe-buffer-usage] Replace assert that declarations are always found (authored by t-rasmud). Herald added a project: clang. Herald

[PATCH] D158031: [clang][ExtractAPI] Refactor C++ method and field visitation

evelez7 created this revision. evelez7 added a reviewer: dang. Herald added a reviewer: ributzka. Herald added a project: All. evelez7 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Refactor visitation for C++ record children by following

[PATCH] D157452: [RFC][Clang][Codegen] `std::type_info` needs special care with explicit address spaces

AlexVlx updated this revision to Diff 550516. AlexVlx added a comment. Remove unneeded cast, the dynamic case already emitted a generic pointer to `typeinfo` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157452/new/ https://reviews.llvm.org/D157452 Files: clang/lib/CodeGen/CGExprCXX

[PATCH] D157933: [OpenMP 5.1] Parsing and Sema support for `scope` construct

mdfazlay updated this revision to Diff 550521. mdfazlay added a comment. Updated nesting of regions checks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157933/new/ https://reviews.llvm.org/D157933 Files: clang/include/clang-c/Index.h clang/include/clang/AST/RecursiveASTVisitor.h

[clang] 95ab1cd - [Driver][DXC] Use the existing help and macro definition options. NFC

Author: Justin Bogner Date: 2023-08-15T16:04:50-07:00 New Revision: 95ab1cd712c27fc0c56f7b88a53e95e6e714ff36 URL: https://github.com/llvm/llvm-project/commit/95ab1cd712c27fc0c56f7b88a53e95e6e714ff36 DIFF: https://github.com/llvm/llvm-project/commit/95ab1cd712c27fc0c56f7b88a53e95e6e714ff36.diff

[PATCH] D155647: [RISCV] Add C intrinsics for scalar bitmanip and crypto

VincentWu added a comment. LGTM, But waiting for other reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155647/new/ https://reviews.llvm.org/D155647 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D157334: [clang] Define _MSC_EXTENSIONS on -gnu if -fms-extensions is set

aidengrossman updated this revision to Diff 550529. aidengrossman added a comment. Hoist _MSC_EXTENSIONS macro logic even further and add release note on chages. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157334/new/ https://reviews.llvm.org/D15

[PATCH] D150262: Disable sanitizer's on ifunc resolvers.

farzon added a comment. I feel like this change will break our use case and do so in a nontransparent way. We want to be able to use sanitizers even if IFUNC indirection is defined. So if the compiler toolchain is now going to disable santizer instrumentation overriding the preferences of the p

[PATCH] D155419: [Clang][CMake] Add CSSPGO support to LLVM_BUILD_INSTRUMENTED

Amir updated this revision to Diff 550532. Amir added a comment. Append to PGO_OPT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155419/new/ https://reviews.llvm.org/D155419 Files: clang/CMakeLists.txt clang/cmake/caches/CSSPGO.cmake clang/u

[PATCH] D158037: [Driver][DXC] Remove a bunch of options from DXC

bogner created this revision. bogner added reviewers: beanz, python3kgae. Herald added a subscriber: mcrosier. Herald added a reviewer: sscalpone. Herald added a project: All. bogner requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Remove DX

[clang] cb6fe61 - [Driver][DXC] Handle -Fo and -Fc flags

Author: Justin Bogner Date: 2023-08-15T16:37:17-07:00 New Revision: cb6fe61be3dee67bb8b080c73dd2c48f2d0ce2c7 URL: https://github.com/llvm/llvm-project/commit/cb6fe61be3dee67bb8b080c73dd2c48f2d0ce2c7 DIFF: https://github.com/llvm/llvm-project/commit/cb6fe61be3dee67bb8b080c73dd2c48f2d0ce2c7.diff

[PATCH] D157582: [Driver][DXC] Handle -Fo and -Fc flags

This revision was automatically updated to reflect the committed changes. Closed by commit rGcb6fe61be3de: [Driver][DXC] Handle -Fo and -Fc flags (authored by bogner). Changed prior to commit: https://reviews.llvm.org/D157582?vs=548879&id=550545#toc Repository: rG LLVM Github Monorepo CHANG

[PATCH] D157362: [RISCV] Add MC layer support for Zicfilp.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157362/new/ https://reviews.llvm.org/D157362 ___

[PATCH] D157331: [clang] Implement C23

ZijunZhao updated this revision to Diff 550547. ZijunZhao added a comment. 1. rename to .c file 2. create clang/test/C/C2x/n2683.c and add codegen tests and semantic tests 3. update clang/docs/ReleseNotes.rst 4. update clang/www/c_status.html 5. reformat PPDirectives.cpp 6. set __STDC_VERSION__ in

[PATCH] D152793: [RISCV] Add MC layer support for Zicfiss.

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZicfiss.td:88 + +let Predicates = [HasStdExtZicfiss, HasStdExtC] in { +let Uses = [SSP], Defs = [SSP], hasSideEffects = 0, mayLoad = 0, mayStore = 1 in Is it compatible with Zca?

[PATCH] D152793: [RISCV] Add MC layer support for Zicfiss.

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZicfiss.td:32 + +class RVC_SSInst rs1, RegisterClass reg_class, string opcodestr> : + RVInst16<(outs), (ins reg_class:$rs1), opcodestr, "$rs1", [], InstFormatOther> { Can you ca

[PATCH] D74094: Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

dexonsmith added a comment. Nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74094/new/ https://reviews.llvm.org/D74094 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[clang] 1e4d612 - [CMake] Add a few more missing dependencies on ClangDriverOptions

Author: Jon Roelofs Date: 2023-08-15T16:56:31-07:00 New Revision: 1e4d6122cda6529781ecf467c2ae84e5dd41acdf URL: https://github.com/llvm/llvm-project/commit/1e4d6122cda6529781ecf467c2ae84e5dd41acdf DIFF: https://github.com/llvm/llvm-project/commit/1e4d6122cda6529781ecf467c2ae84e5dd41acdf.diff L

[clang] aa2c701 - [Driver] move Haiku header search path management to the driver

Author: Brad Smith Date: 2023-08-15T19:58:40-04:00 New Revision: aa2c701b5dc04330b8ec4084a94d7cbe9cc938eb URL: https://github.com/llvm/llvm-project/commit/aa2c701b5dc04330b8ec4084a94d7cbe9cc938eb DIFF: https://github.com/llvm/llvm-project/commit/aa2c701b5dc04330b8ec4084a94d7cbe9cc938eb.diff LO

[PATCH] D157767: [Driver] move Haiku header search path management to the driver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaa2c701b5dc0: [Driver] move Haiku header search path management to the driver (authored by brad). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D158006: [Clang][WIP]Experimental implementation of data member packs in dependent context.

denik added inline comments. Comment at: clang/lib/Sema/SemaExprMember.cpp:528-529 +if (Field->getDeclName() == NameInfo.getName()) { + if (const PackExpansionType *PET = + dyn_cast(Field->getType())) { +isMemberPack = true; -

[PATCH] D157829: [clang-tidy] Added a new option to lambda-function-name to ignore warnings in macro expansion

felix642 updated this revision to Diff 550559. felix642 added a comment. Updated format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157829/new/ https://reviews.llvm.org/D157829 Files: clang-tools-extra/clang-tidy/bugprone/LambdaFunctionNameChe

[PATCH] D157829: [clang-tidy] Added a new option to lambda-function-name to ignore warnings in macro expansion

felix642 added a comment. HI @PiotrZSL, I do not have the rights to commit to the LLVM repository. Could you please commit those changes for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157829/new/ https://reviews.llvm.org/D157829 __

[clang] 818e76d - [RISCV] Add MC layer support for Zicfilp.

Author: Yeting Kuo Date: 2023-08-16T08:52:51+08:00 New Revision: 818e76d6f2dd90362e71e84f492c167958ef3257 URL: https://github.com/llvm/llvm-project/commit/818e76d6f2dd90362e71e84f492c167958ef3257 DIFF: https://github.com/llvm/llvm-project/commit/818e76d6f2dd90362e71e84f492c167958ef3257.diff LO

[PATCH] D157362: [RISCV] Add MC layer support for Zicfilp.

This revision was automatically updated to reflect the committed changes. Closed by commit rG818e76d6f2dd: [RISCV] Add MC layer support for Zicfilp. (authored by fakepaper56). Changed prior to commit: https://reviews.llvm.org/D157362?vs=550089&id=550562#toc Repository: rG LLVM Github Monorep

[PATCH] D152793: [RISCV] Add MC layer support for Zicfiss.

fakepaper56 added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoZicfiss.td:88 + +let Predicates = [HasStdExtZicfiss, HasStdExtC] in { +let Uses = [SSP], Defs = [SSP], hasSideEffects = 0, mayLoad = 0, mayStore = 1 in craig.topper wrote: > Is it

[PATCH] D157297: [clang] Fixes compile error that double colon operator cannot resolve macro with parentheses.

pengfei added a comment. I'd prefer macro to duplicated definitions. We have such precedents, e.g., https://github.com/llvm/llvm-project/blob/main/clang/lib/Headers/xmmintrin.h#L2994 Besides, you should update the summary as well. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157297/new

[PATCH] D152423: [RISCV] Add function that check extension name with version

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152423/new/ https://reviews.llvm.org/D152423 ___

<    1   2   3   >