[PATCH] D157129: [NFC] Fix unnecessary copy with auto.

srividya-sundaram created this revision. Herald added subscribers: luke, steakhal, frasercrmck, martong, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, niosHD, sabuasal, simoncook, johnrusso, rbar, asb

[PATCH] D157074: [clang][ExprConst] Add RHS source range to div by zero diags

aaron.ballman added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:2811-2813 +static bool handleIntIntBinOp(EvalInfo &Info, const BinaryOperator *E, + const APSInt &LHS, BinaryOperatorKind Opcode, + APSInt RHS

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

jhuber6 added inline comments. Comment at: openmp/libomptarget/plugins-nextgen/amdgpu/utils/UtilitiesRTL.h:36 -// The implicit arguments of AMDGPU kernels. -struct AMDGPUImplicitArgsTy { - uint64_t OffsetX; - uint64_t OffsetY; - uint64_t OffsetZ; - uint64_t HostcallPtr; -

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

arsenm added a comment. In D139730#4561540 , @jhuber6 wrote: > Could you explain briefly what the approach here is? I'm confused as to > what's actually changed and how we're handling this difference. I thought if > this was just the definition of some

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

jhuber6 added a comment. In D139730#4561573 , @arsenm wrote: > In D139730#4561540 , @jhuber6 wrote: > >> Could you explain briefly what the approach here is? I'm confused as to >> what's actually changed and how

[PATCH] D148997: [clang] Add a new annotation token: annot_repl_input_end

v.g.vassilev added a comment. In D148997#4561516 , @bnbarham wrote: > In D148997#4561211 , @v.g.vassilev > wrote: > > https://github.com/llvm/llvm-project/blob/df6b35e329ebecad6dc3bfb83183e482eb7a0020/clang/l

[PATCH] D157130: [RISCV] Check type size for lax conversions between RVV builtin types and VectorType::RVVFixedLengthDataVector.

craig.topper created this revision. craig.topper added reviewers: aaron.ballman, c-rhodes. Herald added subscribers: jobnoorman, luke, VincentWu, ctetreau, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfe

[PATCH] D157129: [NFC] Fix unnecessary copy with auto.

steakhal requested changes to this revision. steakhal added a comment. This revision now requires changes to proceed. I can only vouch for the SttaticAnalyzer portion. Those parts makes sense to me. However, I've seen cases where it doesn't resonate. As a rule of thumb, if we are "copying" only at

[PATCH] D156054: [Clang][Sema] DR722 (nullptr and varargs) and missing -Wvarargs diagnostics

MitalAshok updated this revision to Diff 547311. MitalAshok added a comment. No longer warn on printf("%p", nullptr) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156054/new/ https://reviews.llvm.org/D156054 Files: clang/docs/ReleaseNotes.rst

[PATCH] D89001: [clang] Don't look into for C++ headers if they are found alongside the toolchain

dexonsmith added a comment. I don't have access to rdar these days to look into the current state or to refresh my memory. My memory is that the high-level goal was to move the libc++ headers from the toolchain to the SDK. For the transition, this was staged in such a way that they were in bot

[PATCH] D148997: [clang] Add a new annotation token: annot_repl_input_end

bnbarham added a comment. In D148997#4561577 , @v.g.vassilev wrote: >> My other concern here is that it seems our use cases are somewhat different, >> eg. we wouldn't want any parsing differences and while I don't know why this >> is yet, the removal o

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

arsenm added a comment. In D139730#4561575 , @jhuber6 wrote: > In D139730#4561573 , @arsenm wrote: > >> In D139730#4561540 , @jhuber6 >> wrote: >> >>> Could you explain b

[PATCH] D148997: [clang] Add a new annotation token: annot_repl_input_end

v.g.vassilev added a comment. In D148997#4561614 , @bnbarham wrote: > In D148997#4561577 , @v.g.vassilev > wrote: > >>> My other concern here is that it seems our use cases are somewhat >>> different, eg. we wou

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

arsenm added a comment. In D139730#4561619 , @arsenm wrote: > In D139730#4561575 , @jhuber6 wrote: > >> In D139730#4561573 , @arsenm wrote: >> >>> In D139730#4561540

[PATCH] D157076: [clang][ExtractAPI] Add support for C++ class templates and concepts

evelez7 updated this revision to Diff 547314. evelez7 added a comment. Add documentation to template argument name deduction, add missing method declarations to visitor base Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157076/new/ https://reviews

[PATCH] D153071: [clang][dataflow] Refactor `DataflowWorklist` types and add a WTO version.

ymandel updated this revision to Diff 547315. ymandel added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153071/new/ https://reviews.llvm.org/D153071 Files: clang/include/clang/Analysis/FlowSensitive/DataflowWorklist.h clang

[PATCH] D157029: [llvm] Construct option's prefixed name at compile-time

jansvoboda11 updated this revision to Diff 547316. jansvoboda11 added a comment. Remove `OptTable::Info::Name`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157029/new/ https://reviews.llvm.org/D157029 Files: clang-tools-extra/clangd/CompileCom

[PATCH] D157029: [llvm] Construct option's prefixed name at compile-time

jansvoboda11 added a comment. In D157029#4561519 , @jansvoboda11 wrote: > In D157029#4561490 , @MaskRay wrote: > >> This increases the size of `Info` (static data size and static >> relocations). In return, som

[PATCH] D156749: [modules] Fix error about the same module being defined in different .pcm files when using VFS overlays.

vsapsai added a comment. Ping @jansvoboda11 , @benlangmuir in case you still have thoughts on this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156749/new/ https://reviews.llvm.org/D156749 ___ cfe-com

[PATCH] D157115: Revert "[clang][X86] Add __cpuidex function to cpuid.h"

mstorsjo added a comment. In D157115#4561497 , @aaron.ballman wrote: > Thank you for this! The revert LGTM, but please wait for @mstorsjo to confirm > this won't cause problems for MinGW folks. I guess this is fine. We should probably sync mingw-w64 a

[PATCH] D157115: Revert "[clang][X86] Add __cpuidex function to cpuid.h"

aidengrossman added a comment. Thanks for the quick response! Sorry for all the churn with this patch. I'm fine leaving this out of LLVM 17, so I'll land this patch, backport the commit to the 17 release branch, and then once we have the aux triple and MS extensions flag fixes I'll reland in ma

[clang] f3baf63 - Revert "[clang][X86] Add __cpuidex function to cpuid.h"

Author: Aiden Grossman Date: 2023-08-04T13:28:53-07:00 New Revision: f3baf63d9a1ba91974f4df6abb8f2abd9a0df5b5 URL: https://github.com/llvm/llvm-project/commit/f3baf63d9a1ba91974f4df6abb8f2abd9a0df5b5 DIFF: https://github.com/llvm/llvm-project/commit/f3baf63d9a1ba91974f4df6abb8f2abd9a0df5b5.diff

[PATCH] D157115: Revert "[clang][X86] Add __cpuidex function to cpuid.h"

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGf3baf63d9a1b: Revert "[clang][X86] Add __cpuidex function to cpuid.h" (authored by aidengrossman). Changed prior to commi

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM, things that are missing: - some crash protection (getName) - test for rbegin/rend Comment at: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp:333 +en

[PATCH] D156596: [Clang] Produce a warning instead of an error in unevaluated strings before C++26

hubert.reinterpretcast added a comment. In D156596#4558097 , @cor3ntin wrote: > Note: we are waiting for feedback from @hubert.reinterpretcast's people > before progressing this. The "full" build hit some (unrelated) snags, but the initial results look

[PATCH] D157135: [OpenMP][Docs] Update OpenMP supported features table

ddpagan created this revision. ddpagan added a reviewer: ABataev. Herald added subscribers: guansong, yaxunl. Herald added a project: All. ddpagan requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, jplehr, sstefan1. Herald added a project:

[PATCH] D155895: Anonymous unions should be transparent wrt `[[clang::trivial_abi]]`.

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/SemaCXX/attr-trivial-abi.cpp:258 + static_assert(__is_trivially_relocatable(TrivialAbiAttributeAppliedToAnonymousUnion), ""); +#endif +

[PATCH] D157057: [clang-tidy] Implement cppcoreguidelines CP.52

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/NoSuspendWithLockCheck.cpp:24-26 + hasType(recordDecl(hasAnyName( + "::std::unique_lock", "::std::lock_guard", +

[PATCH] D157057: [clang-tidy] Implement cppcoreguidelines CP.52

PiotrZSL added a comment. Consider ignoring template instances, to avoid generating lot of warnings for each instance. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157057/new/ https://reviews.llvm.org/D157057

[PATCH] D145138: [clang-tidy] Implement FixIts for C arrays

PiotrZSL added a comment. Test are failing, and I do not think that converting c-strings into std::array is a good idea Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145138/new/ https://reviews.llvm.org/D145138 ___

[PATCH] D156749: [modules] Fix error about the same module being defined in different .pcm files when using VFS overlays.

jansvoboda11 added a comment. In D156749#4552590 , @vsapsai wrote: > In D156749#4551596 , @jansvoboda11 > wrote: > >> Alternatively, we could keep VFS overlays out of the context hash but create >> `` from the o

[PATCH] D155773: [llvm][MemoryBuiltins] Add alloca support to getInitialValueOfAllocation

jmciver added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155773/new/ https://reviews.llvm.org/D155773 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D156928: [Clang][AMDGPU] Fix handling of -mcode-object-version=none arg

JonChesterfield added a comment. What does code objects version= none mean? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156928/new/ https://reviews.llvm.org/D156928 ___ cfe-commits mailing list cfe-com

[PATCH] D157028: [llvm] Extract common `OptTable` bits into macros

This revision was automatically updated to reflect the committed changes. Closed by commit rG3f092f37b736: [llvm] Extract common `OptTable` bits into macros (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157028/new/ https:

[PATCH] D157029: [llvm] Construct option's prefixed name at compile-time

jansvoboda11 updated this revision to Diff 547339. jansvoboda11 added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157029/new/ https://reviews.llvm.org/D157029 Files: clang-tools-extra/clangd/CompileCommands.cpp clang/lib/D

[PATCH] D156928: [Clang][AMDGPU] Fix handling of -mcode-object-version=none arg

arsenm added a comment. In D156928#4561811 , @JonChesterfield wrote: > What does code objects version= none mean? Handle any version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156928/new/ https://revi

[clang] e21b1dd - [clang][CFG] Fix 2 memory errors in interval computation.

Author: Yitzhak Mandelbaum Date: 2023-08-04T21:10:35Z New Revision: e21b1dd9cc5316c00216ba54f899f67fe473ab33 URL: https://github.com/llvm/llvm-project/commit/e21b1dd9cc5316c00216ba54f899f67fe473ab33 DIFF: https://github.com/llvm/llvm-project/commit/e21b1dd9cc5316c00216ba54f899f67fe473ab33.diff

[PATCH] D157033: [clang][CFG] Fix 2 memory errors in interval computation.

This revision was automatically updated to reflect the committed changes. Closed by commit rGe21b1dd9cc53: [clang][CFG] Fix 2 memory errors in interval computation. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157033/new/ htt

[PATCH] D156886: [CUDA][HIP] Reorganize options for documentation

yaxunl marked 2 inline comments as done. yaxunl added inline comments. Comment at: clang/include/clang/Driver/Options.td:155 +def offload_Group : OptionGroup<"">, Group, + DocName<"Common Offloading flags">; + MaskRay wrote: > The existing `flag

[clang] 00769d6 - [flang] Add -fppc-native-vector-element-order option to control the element order in PowerPC vector types

Author: Kelvin Li Date: 2023-08-04T17:11:30-04:00 New Revision: 00769d69fbaa39ecdcbbaf826a35ad999bdc951e URL: https://github.com/llvm/llvm-project/commit/00769d69fbaa39ecdcbbaf826a35ad999bdc951e DIFF: https://github.com/llvm/llvm-project/commit/00769d69fbaa39ecdcbbaf826a35ad999bdc951e.diff LOG

[PATCH] D155852: [flang] Add -fppc-native-vector-element-order option to control the element order in PowerPC vector types

This revision was automatically updated to reflect the committed changes. Closed by commit rG00769d69fbaa: [flang] Add -fppc-native-vector-element-order option to control the element… (authored by kkwli0). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLV

[PATCH] D153071: [clang][dataflow] Refactor `DataflowWorklist` types and add a WTO version.

ymandel updated this revision to Diff 547344. ymandel added a comment. rebase onto main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153071/new/ https://reviews.llvm.org/D153071 Files: clang/include/clang/Analysis/FlowSensitive/DataflowWorklis

[clang] 6b4de7b - [clang][deps] add support for dependency scanning with cc1 command line

Author: Connor Sughrue Date: 2023-08-04T14:13:18-07:00 New Revision: 6b4de7b1c71b6b701e130c2a533d285dc93b8370 URL: https://github.com/llvm/llvm-project/commit/6b4de7b1c71b6b701e130c2a533d285dc93b8370 DIFF: https://github.com/llvm/llvm-project/commit/6b4de7b1c71b6b701e130c2a533d285dc93b8370.diff

[PATCH] D156234: [clang][deps] add support for dependency scanning with cc1 command line

This revision was automatically updated to reflect the committed changes. Closed by commit rG6b4de7b1c71b: [clang][deps] add support for dependency scanning with cc1 command line (authored by cpsughrue, committed by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D156928: [Clang][AMDGPU] Fix handling of -mcode-object-version=none arg

JonChesterfield added a comment. In D156928#4561849 , @arsenm wrote: > In D156928#4561811 , > @JonChesterfield wrote: > >> What does code objects version= none mean? > > Handle any version So... That should be t

[PATCH] D157140: [clang][Sema][OpenMP] Fix capture region for 'target teams loop'

ddpagan created this revision. ddpagan added a reviewer: ABataev. ddpagan added projects: clang, OpenMP. Herald added subscribers: guansong, yaxunl. Herald added a project: All. ddpagan requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, jpl

[clang] f037b89 - [CUDA][HIP] Reorganize options for documentation

Author: Yaxun (Sam) Liu Date: 2023-08-04T17:23:15-04:00 New Revision: f037b895b7e987d39c30c7edb82474d774540bc1 URL: https://github.com/llvm/llvm-project/commit/f037b895b7e987d39c30c7edb82474d774540bc1 DIFF: https://github.com/llvm/llvm-project/commit/f037b895b7e987d39c30c7edb82474d774540bc1.dif

[PATCH] D156886: [CUDA][HIP] Reorganize options for documentation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. yaxunl marked 2 inline comments as done. Closed by commit rGf037b895b7e9: [CUDA][HIP] Reorganize options for documentation (authored by yaxunl). Herald added a project:

[clang] 043d03d - Revert "Reland "Fix __cfi_check not aligned to 4k on relocatable files with no executable code""

Author: Florian Mayer Date: 2023-08-04T14:24:26-07:00 New Revision: 043d03d25bd7eadef66685de298342b35fe6b466 URL: https://github.com/llvm/llvm-project/commit/043d03d25bd7eadef66685de298342b35fe6b466 DIFF: https://github.com/llvm/llvm-project/commit/043d03d25bd7eadef66685de298342b35fe6b466.diff

[PATCH] D157129: [NFC] Fix unnecessary copy with auto.

srividya-sundaram updated this revision to Diff 547350. srividya-sundaram added a comment. Added 'const' type qualifiers per review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157129/new/ https://reviews.llvm.org/D157129 Files: clang

[PATCH] D156054: [Clang][Sema] DR722 (nullptr and varargs) and missing -Wvarargs diagnostics

MitalAshok updated this revision to Diff 547353. MitalAshok added a comment. C99 7.15.1.1p2 explicitly allows a char* to be retrieved as a void* with va_arg, so the -Wformat-pedantic warning was incorrect. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D156580: [FunctionImport] Reduce string duplication (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG65e57bbed06d: [FunctionImport] Reduce string duplication (NFC) (authored by tejohnson). Changed prior to commit: https://reviews.llvm.org/D156580?

[clang] 65e57bb - [FunctionImport] Reduce string duplication (NFC)

Author: Teresa Johnson Date: 2023-08-04T14:43:11-07:00 New Revision: 65e57bbed06d55cab7bb64d54891d33ccb2d4159 URL: https://github.com/llvm/llvm-project/commit/65e57bbed06d55cab7bb64d54891d33ccb2d4159 DIFF: https://github.com/llvm/llvm-project/commit/65e57bbed06d55cab7bb64d54891d33ccb2d4159.diff

[PATCH] D153071: [clang][dataflow] Refactor `DataflowWorklist` types and add a WTO version.

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Mea culpa. Looks like I did not anticipate non-RPO worklists. Thanks for cleaning this up, looks good to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D156989: FloatingPointMode: Use -1 for "Dynamic"

arsenm added a comment. In D156989#4558486 , @sepavloff wrote: > Support of rounding mode in C standard is based on IEEE-754 model, where > rounding mode is a global state and affects all FP operations. The case of > two rounding modes does not fit this

[PATCH] D156928: [Clang][AMDGPU] Fix handling of -mcode-object-version=none arg

yaxunl added a comment. In D156928#4561890 , @JonChesterfield wrote: > In D156928#4561849 , @arsenm wrote: > >> In D156928#4561811 , >> @JonChesterfield wrote: >> >>> Wh

[PATCH] D157078: [include-cleaner] Handle files with unnamed buffers

lei added a comment. This is causing a ld.lld link failure in https://lab.llvm.org/buildbot/#/builders/57 FAILED: tools/clang/tools/extra/include-cleaner/unittests/ClangIncludeCleanerTests : && /home/buildbots/clang.15.0.4/bin/clang++ --gcc-toolchain=/usr -fPIC -fno-semantic-interposition

[PATCH] D157066: [clang][modules][deps] Create more efficient API for visitation of `ModuleFile` inputs

benlangmuir added a subscriber: vsapsai. benlangmuir added a comment. CC @vsapsai since he was also making name vs. name-as-requested change in modules Comment at: clang/include/clang/Serialization/ModuleFile.h:72 + bool TopLevel; + bool ModuleMap; }; Is th

[PATCH] D154550: [clang-format] Allow empty loops on a single line.

owenpan added a comment. In D154550#4529346 , @gedare wrote: > In D154550#4526386 , @owenpan wrote: > >> Like `while (a);`, `while (a) {}` is also an empty loop, so `NonEmpty` is >> misleading if it excludes the

[PATCH] D156928: [Clang][AMDGPU] Fix handling of -mcode-object-version=none arg

yaxunl added a comment. In D156928#4562023 , @yaxunl wrote: > In D156928#4561890 , > @JonChesterfield wrote: > >> In D156928#4561849 , @arsenm wrote: >> >>> In D156928#45

[PATCH] D157146: [Clang][Docs] Consolidate option hiding in ClangOptionDocEmitter

bogner created this revision. bogner added a reviewer: MaskRay. Herald added a subscriber: mcrosier. Herald added a project: All. bogner requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Update the `hasFlag` check to account for an Option's g

[PATCH] D157066: [clang][modules][deps] Create more efficient API for visitation of `ModuleFile` inputs

jansvoboda11 added inline comments. Comment at: clang/include/clang/Serialization/ModuleFile.h:72 + bool TopLevel; + bool ModuleMap; }; benlangmuir wrote: > Is there something using this new split? It seems like every user is using > `&&` for these You're rig

[PATCH] D157090: [Flang][Sema] Move directive sets to a shared location

kiranchandramohan added a comment. This looks OK. The only concern is whether we will lose the ability to inline the code for set membership. Can these sets be put in a header file with `inline constexpr`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[clang] 932c635 - [HIP] link HIP runtime library without --hip-link

Author: Yaxun (Sam) Liu Date: 2023-08-04T18:29:47-04:00 New Revision: 932c63550ad5752ba333a7a4e0045b559c65840b URL: https://github.com/llvm/llvm-project/commit/932c63550ad5752ba333a7a4e0045b559c65840b DIFF: https://github.com/llvm/llvm-project/commit/932c63550ad5752ba333a7a4e0045b559c65840b.dif

[PATCH] D156426: [HIP] link HIP runtime library without --hip-link

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. yaxunl marked an inline comment as done. Closed by commit rG932c63550ad5: [HIP] link HIP runtime library without --hip-link (authored by yaxunl). Herald added a project

[PATCH] D153071: [clang][dataflow] Refactor `DataflowWorklist` types and add a WTO version.

ymandel added a comment. In D153071#4561993 , @xazax.hun wrote: > Mea culpa. Looks like I did not anticipate non-RPO worklists. Thanks for > cleaning this up, looks good to me! Thanks! Not anticipating the future is pretty standard, no need to apologize

[PATCH] D157066: [clang][modules][deps] Create more efficient API for visitation of `ModuleFile` inputs

benlangmuir accepted this revision. benlangmuir added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Serialization/ModuleFile.h:72 + bool TopLevel; + bool ModuleMap; }; jansvoboda11 wrote: > benlangmuir wrote:

[PATCH] D151567: [LLVM][Support] Report EISDIR when opening a directory on AIX

hubert.reinterpretcast added inline comments. Comment at: llvm/lib/Support/Unix/Path.inc:1020 +struct stat Status; +if (stat(P.begin(), &Status) == -1) + return std::error_code(errno, std::generic_category()); Please try using `fstat` on the result

[PATCH] D151567: [LLVM][Support] Report EISDIR when opening a directory on AIX

hubert.reinterpretcast added a comment. I believe the unit tests should be updated to ensure that we get `EISDIR` when opening directories for reading and for writing: `llvm/unittests/Support/Path.cpp`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D157149: [Option] Add "Visibility" field and clone the OptTable APIs to use it

bogner created this revision. bogner added a reviewer: MaskRay. Herald added subscribers: pmatos, asb, ormris, kadircet, arphaman, steven_wu, hiraditya, sbc100, mcrosier. Herald added a reviewer: JDevlieghere. Herald added a reviewer: alexander-shaposhnikov. Herald added a reviewer: jhenderson. He

[PATCH] D157150: [Driver] Update BoolOption to handle Visibility. NFC

bogner created this revision. bogner added a reviewer: MaskRay. Herald added a subscriber: mcrosier. Herald added a reviewer: sscalpone. Herald added a project: All. bogner requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This updates the Bo

[PATCH] D156928: [Clang][AMDGPU] Fix handling of -mcode-object-version=none arg

JonChesterfield added a comment. Or, the front end could define those objects directly, without importing IR files that define the objects with the content clang used to choose the object file. E.g. instead of the argument daz=off (spelled differently) finding a file called daz.off.ll that defi

[PATCH] D157076: [clang][ExtractAPI] Add support for C++ class templates and concepts

evelez7 updated this revision to Diff 547389. evelez7 added a comment. Abstract the name deduction for generic template args to its own function. It's very helpful in other cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157076/new/ https://r

[PATCH] D157066: [clang][modules][deps] Create more efficient API for visitation of `ModuleFile` inputs

jansvoboda11 added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:2411 bool Transient = FI.Transient; - StringRef Filename = FI.Filename; + StringRef Filename = FI.FilenameAsRequested; uint64_t StoredContentHash = FI.ContentHash; jansv

[PATCH] D157157: [clang] Add clang support for Machine Function Splitting on AArch64

dhoekwater created this revision. dhoekwater added reviewers: shenhan, xur, snehasish, wenlei, mingmingl. Herald added subscribers: pengfei, kristof.beyls. Herald added a project: All. dhoekwater requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a proje

[clang] 9824ec8 - [clang][dataflow] Refactor `DataflowWorklist` types and add a WTO version.

Author: Yitzhak Mandelbaum Date: 2023-08-04T23:29:08Z New Revision: 9824ec875cecc533d55c1f11c0c0440520c34464 URL: https://github.com/llvm/llvm-project/commit/9824ec875cecc533d55c1f11c0c0440520c34464 DIFF: https://github.com/llvm/llvm-project/commit/9824ec875cecc533d55c1f11c0c0440520c34464.diff

[PATCH] D153071: [clang][dataflow] Refactor `DataflowWorklist` types and add a WTO version.

This revision was automatically updated to reflect the committed changes. Closed by commit rG9824ec875cec: [clang][dataflow] Refactor `DataflowWorklist` types and add a WTO version. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D156762: [-Wunsafe-buffer-usage][NFC] Refactor `getFixIts`---where fix-its are generated

ziqingluo-90 updated this revision to Diff 547405. ziqingluo-90 marked 6 inline comments as done. ziqingluo-90 added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156762/new/ https://reviews.llvm.org/D156762 Files: clang/lib/Analysis/UnsafeBufferUsage.cpp

[clang] 606b77d - Fix test hip-runtime-libs-msvc.hip

Author: Yaxun (Sam) Liu Date: 2023-08-04T19:54:37-04:00 New Revision: 606b77d82d95b723fdf965e772af507d4099289d URL: https://github.com/llvm/llvm-project/commit/606b77d82d95b723fdf965e772af507d4099289d DIFF: https://github.com/llvm/llvm-project/commit/606b77d82d95b723fdf965e772af507d4099289d.dif

[PATCH] D156928: [Clang][AMDGPU] Fix handling of -mcode-object-version=none arg

yaxunl added a comment. In D156928#4562239 , @JonChesterfield wrote: > Or, the front end could define those objects directly, without importing IR > files that define the objects with the content clang used to choose the > object file. E.g. instead of

[PATCH] D157164: [clang-tidy] Add fix-it support to `llvmlibc-inline-function-decl`

mcgrathr created this revision. mcgrathr added reviewers: abrachet, Caslyn, sivachandra, michaelrj. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. mcgrathr requested review of this revision. Herald added a project: clang

[PATCH] D142569: [OpenMP] Introduce kernel environment

dhruvachak added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:4065 + Constant *KernelEnvironmentGV = new GlobalVariable( + M, KernelEnvironment, /* IsConstant */ true, GlobalValue::ExternalLinkage, + KernelEnvironmentInitializer, KernelEnviro

[PATCH] D156749: [modules] Fix error about the same module being defined in different .pcm files when using VFS overlays.

vsapsai added a comment. In D156749#4561803 , @jansvoboda11 wrote: > My suggestion is to use the actual real on-disk path. Not > `FileEntryRef::getName()`, but something that always behaves as if > `use-external-name` was set to `true`. I believe this

[PATCH] D153059: [-Wunsafe-buffer-usage] Group parameter fix-its

ziqingluo-90 updated this revision to Diff 547422. ziqingluo-90 marked an inline comment as done. ziqingluo-90 added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153059/new/ https://reviews.llvm.org/D153059 Files: clang/include/clang/Analysis/Analyses/Un

[PATCH] D153059: [-Wunsafe-buffer-usage] Group parameter fix-its

ziqingluo-90 updated this revision to Diff 547425. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153059/new/ https://reviews.llvm.org/D153059 Files: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Analysis/UnsafeB

[PATCH] D156928: [Clang][AMDGPU] Fix handling of -mcode-object-version=none arg

JonChesterfield added a comment. In D156928#4562412 , @yaxunl wrote: > Some control variables are per-module. Clang cannot emit control variables > that have different values for different modules. Intrinsics should work > since it can take an argument

[PATCH] D153059: [-Wunsafe-buffer-usage] Group parameter fix-its

ziqingluo-90 added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:1891-1892 + for (unsigned i = 0; i < NumParms; i++) { +if (!ParmsMask[i]) + continue; + NoQ wrote: > Speaking of [[ https://reviews.llvm.org/D156762#inline-1517322

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter updated this revision to Diff 547433. ccotter marked 2 inline comments as done. ccotter added a comment. - Feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ https://reviews.llvm.org/D140760 Files: clang-tools-extra/clang

[PATCH] D142569: [OpenMP] Introduce kernel environment

tianshilei1992 added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:4065 + Constant *KernelEnvironmentGV = new GlobalVariable( + M, KernelEnvironment, /* IsConstant */ true, GlobalValue::ExternalLinkage, + KernelEnvironmentInitializer, KernelEn

[PATCH] D157170: [clang][AST]Don't increase depth in friend tempalte class declaration

jcsxky created this revision. jcsxky added reviewers: a.sidorin, shafik, balazske, steakhal, aaron.ballman, Michael137. jcsxky added projects: clang, clang-c. Herald added a project: All. jcsxky requested review of this revision. Herald added a subscriber: cfe-commits. Don't increase template par

[PATCH] D142569: [OpenMP] Introduce kernel environment

dhruvachak added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:4065 + Constant *KernelEnvironmentGV = new GlobalVariable( + M, KernelEnvironment, /* IsConstant */ true, GlobalValue::ExternalLinkage, + KernelEnvironmentInitializer, KernelEnviro

[PATCH] D157174: [clang][Interp] Convert logical binop operands to bool

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Move the logic for this into `visitBool`, where it bel

[PATCH] D157078: [include-cleaner] Handle files with unnamed buffers

tylanphear added a comment. Seeing the link error downstream. I think clangSerialization needs to be added to the link libraries. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157078/new/ https://reviews.llvm.org/D157078 _

[PATCH] D157178: [clang-tidy] Fix inline namespaces in llvm-namespace-comment

PiotrZSL created this revision. PiotrZSL added reviewers: njames93, carlosgalvezp. Herald added a subscriber: xazax.hun. Herald added a project: All. PiotrZSL requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Provide fixes for inl

<    1   2