[PATCH] D155814: Fix the linting problems which causes `clang/utils/ci/run-buildbot check-format` to return 1.

AMP999 added a comment. Thank You @ziqingluo-90! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155814/new/ https://reviews.llvm.org/D155814 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[clang] 36ac6ac - [RISCV] Merge rv32 and rv64 Zvb* intrinsic tests. NFC

Author: Craig Topper Date: 2023-08-02T00:08:01-07:00 New Revision: 36ac6ac1dbd0ffd5a4a5de0d6892141f969c130d URL: https://github.com/llvm/llvm-project/commit/36ac6ac1dbd0ffd5a4a5de0d6892141f969c130d DIFF: https://github.com/llvm/llvm-project/commit/36ac6ac1dbd0ffd5a4a5de0d6892141f969c130d.diff

[PATCH] D156851: [RISCV] Merge rv32 and rv64 Zvb* intrinsic tests. NFC

This revision was automatically updated to reflect the committed changes. Closed by commit rG36ac6ac1dbd0: [RISCV] Merge rv32 and rv64 Zvb* intrinsic tests. NFC (authored by craig.topper). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156851/new/ ht

[PATCH] D156856: [clang][dataflow] In `equivalentTo()`, ignore expression locations that are unlikely to matter.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The locations of some glvalue expressions are di

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

Hahnfeld added a comment. Hi, after this change I have three failing tests: Failed Tests (3): Clang :: Driver/lto.cu Clang :: Driver/openmp-offload-gpu.c Clang :: Driver/openmp-offload-jit.c I have CUDA installed on my system, not sure if a bot is testing this configuration... Cou

[PATCH] D156858: Add Documentation for Execution Results Handling in Clang-REPL

Krishna-13-cyber created this revision. Krishna-13-cyber added reviewers: v.g.vassilev, davidlange6, QuillPusher. Herald added a subscriber: arphaman. Herald added a project: All. Krishna-13-cyber requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commi

[PATCH] D156859: [clang][dataflow] In `ControlFlowContext`, handle `Decl` by reference instead of pointer.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `build()` guarantees that we'll always have a `D

[PATCH] D156658: [clang][dataflow] When checking `ExprToLoc` convergence, only consider children of block terminator.

mboehme added a comment. In D156658#4546955 , @xazax.hun wrote: >> It looks as if, instead, what we should be doing to improve convergence in a >> sound manner is to implement widening for ExprToLoc. I'll submit a >> corresponding patch shortly. > > +1,

[PATCH] D155370: [CodeComplete] Improve FunctionCanBeCall

nridge added a comment. In D155370#4550042 , @zyounan wrote: > in the context where `CanBeCall=false`, parameters don't disambiguate against > the overloads, so we'd end up with the same function name after selecting the > candidate I was thinking of f

[PATCH] D156861: [Driver] Remove references to Solaris 12

ro created this revision. ro added a reviewer: MaskRay. ro added a project: clang. Herald added a subscriber: fedor.sergeev. Herald added a project: All. ro requested review of this revision. Solaris 12 was re-christened as Solaris 11.4 while still in beta, so all references are long obsolete and

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

ro added a comment. It seems the latest commit of this patch has (re-)introduced two failures on the Solaris/amd64 buildbot : FAIL: Clang::clang_f_opts.c FAIL: Clang::lto.c I cannot really make sense of that. Repository: rG LLVM

[clang-tools-extra] 8af016a - [clangd][c++20] Add concept semantic highlighting test case

Author: Jens Massberg Date: 2023-08-02T10:37:30+02:00 New Revision: 8af016aefd8391d083cdf745420826ce162a41a5 URL: https://github.com/llvm/llvm-project/commit/8af016aefd8391d083cdf745420826ce162a41a5 DIFF: https://github.com/llvm/llvm-project/commit/8af016aefd8391d083cdf745420826ce162a41a5.diff

[PATCH] D155581: [clangd][c++20] Add concept semantic highlighting test case

This revision was automatically updated to reflect the committed changes. Closed by commit rG8af016aefd83: [clangd][c++20] Add concept semantic highlighting test case (authored by massberg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155581/new/

[PATCH] D127762: [Clang][AArch64] Add/implement ACLE keywords for SME.

rsandifo-arm added a comment. Mostly LGTM from a spec POV, but some comments below. Comment at: clang/include/clang/Basic/Attr.td:2439 def ArmStreaming : TypeAttr, TargetSpecificAttr { let Spellings = [RegularKeyword<"__arm_streaming">]; In current main,

[clang] 9a370a1 - Reland "For #64088: mark vtable as used if we might emit a reference to it."

Author: Dmitry Chernenkov Date: 2023-08-02T08:52:00Z New Revision: 9a370a1e586ca0ee1367ea58d7d61b8a86f660a3 URL: https://github.com/llvm/llvm-project/commit/9a370a1e586ca0ee1367ea58d7d61b8a86f660a3 DIFF: https://github.com/llvm/llvm-project/commit/9a370a1e586ca0ee1367ea58d7d61b8a86f660a3.diff

[PATCH] D156866: [Clang][LoongArch] Use the ClangBuiltin class to automatically generate support for CBE and CFE

wangleiat created this revision. wangleiat added reviewers: SixWeining, xen0n, xry111, gonglingqin, XiaodongLoong. Herald added a subscriber: hiraditya. Herald added a project: All. wangleiat requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-comm

[PATCH] D156867: Add a concept AST nodes.

massberg created this revision. massberg added reviewers: hokein, sammccall, erichkeane. Herald added subscribers: ChuanqiXu, kadircet, martong. Herald added a reviewer: shafik. Herald added a project: All. massberg requested review of this revision. Herald added subscribers: cfe-commits, ilya-biry

[PATCH] D156515: [RemarkUtil] Refactor llvm-remarkutil to include size-diff

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG24f320e48c83: [RemarkUtil] Refactor llvm-remarkutil to include size-diff (authored by zjaffal). Changed prior to commit: https://reviews.llvm.org/

[PATCH] D156867: [clang] Add a concept AST nodes.

massberg added a comment. @erichkeane Hi Erich, we would like to add an AST node for concepts (see description above) and we are interested in your opinion on the high level design.. This patch is a draft of what the new AST node could look like and how it would be part of the existing infrast

[PATCH] D155715: [clang][analyzer] Improve StdCLibraryFunctions socket send/recv functions.

donat.nagy accepted this revision. donat.nagy added a comment. This revision is now accepted and ready to land. LGTM, I don't have anything significant to add. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155715/new/ https://reviews.llvm.org/D1557

[clang] 77a38f4 - [clang-format] Supress aligning of trailing namespace comments

Author: Björn Schäpers Date: 2023-08-02T11:50:14+02:00 New Revision: 77a38f43b168e5c2a9395ab4c2bd1479a297ade5 URL: https://github.com/llvm/llvm-project/commit/77a38f43b168e5c2a9395ab4c2bd1479a297ade5 DIFF: https://github.com/llvm/llvm-project/commit/77a38f43b168e5c2a9395ab4c2bd1479a297ade5.diff

[clang] 2c3b12b - [clang-format][NFCish] Obey debug settings

Author: Björn Schäpers Date: 2023-08-02T11:50:14+02:00 New Revision: 2c3b12b5418fa4aa3aeb3f2154ae7bedbd1feac8 URL: https://github.com/llvm/llvm-project/commit/2c3b12b5418fa4aa3aeb3f2154ae7bedbd1feac8 DIFF: https://github.com/llvm/llvm-project/commit/2c3b12b5418fa4aa3aeb3f2154ae7bedbd1feac8.diff

[clang] f274ffc - [clang-format][NFC] Resort IO Mapping

Author: Björn Schäpers Date: 2023-08-02T11:50:14+02:00 New Revision: f274ffc3034192179de14edb3be1ed85615aac42 URL: https://github.com/llvm/llvm-project/commit/f274ffc3034192179de14edb3be1ed85615aac42 DIFF: https://github.com/llvm/llvm-project/commit/f274ffc3034192179de14edb3be1ed85615aac42.diff

[PATCH] D156228: [clang-format][NFCish] Obey debug settings

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2c3b12b5418f: [clang-format][NFCish] Obey debug settings (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. HazardyKnusperkeks marked an inline comment as done. Closed by commit rG77a38f43b168: [clang-format] Supress aligning of trailing namespace comments (authored by Hazard

[clang] fd05c34 - Stop using legacy helpers indicating typed pointer types. NFC

Author: Bjorn Pettersson Date: 2023-08-02T12:08:37+02:00 New Revision: fd05c34b18fbc3f37494bef9118c368f0c11595a URL: https://github.com/llvm/llvm-project/commit/fd05c34b18fbc3f37494bef9118c368f0c11595a DIFF: https://github.com/llvm/llvm-project/commit/fd05c34b18fbc3f37494bef9118c368f0c11595a.di

[PATCH] D156733: Stop using legacy helpers indicating typed pointer types. NFC

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfd05c34b18fb: Stop using legacy helpers indicating typed pointer t

[PATCH] D156556: [AggressiveInstCombine][NFC] Fix typo

kitaisreal updated this revision to Diff 546381. kitaisreal retitled this revision from "[AggressiveInstCombine] Fold strcmp eq, not eq operator improvements" to "[AggressiveInstCombine][NFC] Fix typo". kitaisreal edited the summary of this revision. kitaisreal added a comment. Herald added a revi

[PATCH] D156556: [AggressiveInstCombine][NFC] Fix typo

kitaisreal updated this revision to Diff 546386. kitaisreal added a comment. Uploaded correct patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156556/new/ https://reviews.llvm.org/D156556 Files: llvm/lib/Transforms/AggressiveInstCombine/Aggr

[PATCH] D155858: Add a concept AST node.

massberg created this revision. massberg added a reviewer: sammccall. Herald added subscribers: ChuanqiXu, martong. Herald added a reviewer: shafik. Herald added a project: All. massberg updated this revision to Diff 544722. massberg added a comment. massberg updated this revision to Diff 545601. m

[PATCH] D156867: [clang] Add a concept AST nodes.

massberg abandoned this revision. massberg added a comment. Abandon this revision in favor of https://reviews.llvm.org/D155858 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156867/new/ https://reviews.llvm.org/D156867 _

[clang-tools-extra] 778a5e9 - [include-cleaner] Introduce support for always_keep pragma

Author: Kadir Cetinkaya Date: 2023-08-02T12:47:53+02:00 New Revision: 778a5e9bc6335061d5c6c27795bb8c4f768af7f3 URL: https://github.com/llvm/llvm-project/commit/778a5e9bc6335061d5c6c27795bb8c4f768af7f3 DIFF: https://github.com/llvm/llvm-project/commit/778a5e9bc6335061d5c6c27795bb8c4f768af7f3.dif

[clang-tools-extra] 4397433 - [include-cleaner] Unify always_keep with rest of the keep logic

Author: Kadir Cetinkaya Date: 2023-08-02T12:47:53+02:00 New Revision: 43974333dd094e7ffef2bb75a799a47cf1b5ddbc URL: https://github.com/llvm/llvm-project/commit/43974333dd094e7ffef2bb75a799a47cf1b5ddbc DIFF: https://github.com/llvm/llvm-project/commit/43974333dd094e7ffef2bb75a799a47cf1b5ddbc.dif

[PATCH] D156122: [include-cleaner] Introduce support for always_keep pragma

This revision was automatically updated to reflect the committed changes. Closed by commit rG778a5e9bc633: [include-cleaner] Introduce support for always_keep pragma (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156122/new/ h

[PATCH] D156123: [include-cleaner] Unify always_keep with rest of the keep logic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG43974333dd09: [include-cleaner] Unify always_keep with rest of the keep logic (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D154130: [lit][clang] Avoid realpath on Windows due to MAX_PATH limitations

RKSimon added a comment. @MrTrillian This is failing for me with: C:\LLVM\ninja>ninja check-llvm-codegen-x86 [0/1/0/1] Running lit suite C:/LLVM/llvm-project/llvm/test/CodeGen/X86llvm-lit.py: C:\LLVM\llvm-project\llvm\utils\lit\lit\TestingConfig.py:151: fatal: unable to parse config file '

[PATCH] D156877: Update Clang-REPL docs with removing the redundant subsections

Krishna-13-cyber created this revision. Krishna-13-cyber added a reviewer: v.g.vassilev. Herald added a project: All. Krishna-13-cyber requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The Clang documentation is currently displaying 3 subsect

[PATCH] D156878: [OpenMP][OMPD][Doc] Update the implementation details of OMPD

Vigneshbalu created this revision. Herald added subscribers: sunshaoce, guansong, yaxunl. Herald added a project: All. Vigneshbalu requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, jplehr, sstefan1. Herald added a project: clang. OMPD is

[PATCH] D156616: [clang-tidy] Fix c_str() removal and cast addition when re-ordering arguments

mikecrowe updated this revision to Diff 546414. mikecrowe added a comment. Reinstate version I incorrectly replaced with D154287 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156616/new/ https://reviews.llvm.org/

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

jhuber6 added a comment. Also seems to have impacted one of the AMDGPU bots but not the other, not sure why https://lab.llvm.org/staging/#/builders/247/builds/4145. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156363/new/ https://reviews.llvm.org

[PATCH] D156205: wasm: link crt1 even in case of -shared

yamt updated this revision to Diff 546417. yamt added a comment. when -shared, use the reactor model by default Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156205/new/ https://reviews.llvm.org/D156205 Files: clang/lib/Driver/ToolChains/WebAsse

[PATCH] D154287: [clang-tidy] Add modernize-use-std-format check

mikecrowe updated this revision to Diff 546418. mikecrowe added a comment. Rebase on top of D156616 and add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154287/new/ https://reviews.llvm.org/D154287 Fi

[PATCH] D127762: [Clang][AArch64] Add/implement ACLE keywords for SME.

aaron.ballman added a comment. In D127762#4515055 , @sdesmalen wrote: > Gentle ping @aaron.ballman and @erichkeane. I've addressed all comments and > suggestions and believe we found agreement on the approach (to use a keyword > instead of an attribute)

[PATCH] D154130: [lit][clang] Avoid realpath on Windows due to MAX_PATH limitations

RKSimon added inline comments. Comment at: llvm/utils/lit/lit/discovery.py:60 +cfgpath = util.abs_path_preserve_drive(cfgpath) +target = config_map.get(cfgpath) if target: Found the problem - you have moved the os.path.normpat

[PATCH] D156596: [Clang] Produce a warning instead of an error in unevaluated strings before C++26

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:290 + "encoding prefix '%0' on an unevaluated string literal has no effect" + "%select{| and is incompatible with c++2c}1">, + InGroup>; cor3ntin wrote: > hubert.r

[PATCH] D155809: [NFC] [Clang] Fix strict weak ordering in ItaniumVTableBuilder

aaron.ballman added a comment. In D155809#4551876 , @danlark wrote: > In D155809#4551721 , @cor3ntin > wrote: > >> I think the test we want is a set of classes and virtuaal fuc >> >> In D155809#4551686

[PATCH] D155809: [NFC] [Clang] Fix strict weak ordering in ItaniumVTableBuilder

danlark added a comment. In D155809#4553690 , @aaron.ballman wrote: > In D155809#4551876 , @danlark wrote: > >> In D155809#4551721 , @cor3ntin >> wrote: >> >>> I think t

[PATCH] D155809: [NFC] [Clang] Fix strict weak ordering in ItaniumVTableBuilder

cor3ntin added a comment. @danlark OH! It make sense now! Thanks for the detailed explanation, having the whole context definitively helps understand the issue. Clang is violating the `sable_sort` preconditions, and that is only observed in some standard library implementations. In that light,

[PATCH] D155809: [NFC] [Clang] Fix strict weak ordering in ItaniumVTableBuilder

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D155809#4553694 , @danlark wrote: > In D155809#4553690 , @aaron.ballman > wrote: > >> In D1

[PATCH] D155809: [NFC] [Clang] Fix strict weak ordering in ItaniumVTableBuilder

aaron.ballman added a comment. In D155809#4553718 , @cor3ntin wrote: > However, it might be interesting to enable LIBCPP_ENABLE_HARDENED_MODE on > some build bots - I am assuming we already test to build clang with libc++ in > a two stage bot somewhere.

[PATCH] D155610: [Clang][ExprConstant] Print integer instead of character on static assertion failure

hazohelet added a comment. In D155610#4550346 , @cor3ntin wrote: > I've been thinking about it and I think I have a cleaner design for the > printing of characters: > > We need a `CharToString(unsigned, Qualtype) -> SmallString` method that takes > a va

[PATCH] D155809: [NFC] [Clang] Fix strict weak ordering in ItaniumVTableBuilder

ilya-biryukov added a comment. If we don't find existing buildbots owners with this, I can volunteer to add a new one with hardened libc++. I have set up the C++20 buildbot last year and getting a new one running over the same infrastructure should be easy. Repository: rG LLVM Github Monorep

[PATCH] D155809: [NFC] [Clang] Fix strict weak ordering in ItaniumVTableBuilder

danlark added a comment. In D155809#4553727 , @aaron.ballman wrote: > In D155809#4553694 , @danlark wrote: > >> In D155809#4553690 , >> @aaron.ballman wrote: >> >>> In D

[PATCH] D156794: [clang][Interp] Lazily visit unknown global declarations

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:2172-2173 + // Lazily visit global declarations we haven't seen yet. + // This happens in C. + if (const auto *VD = dyn_cast(D); Do we want to assert/limit this functio

[PATCH] D155809: [NFC] [Clang] Fix strict weak ordering in ItaniumVTableBuilder

aaron.ballman added a comment. In D155809#4553755 , @ilya-biryukov wrote: > If we don't find existing buildbots owners with easy addition for this > configuration, I can volunteer to add a new one with hardened libc++. > I have set up the C++20 buildbot

[PATCH] D156886: [CUDA][HIP] Reorganize options for documentation

yaxunl created this revision. yaxunl added reviewers: tra, MaskRay, jhuber6. Herald added subscribers: mattd, carlosgalvezp, Naghasan, Anastasia. Herald added a reviewer: sscalpone. Herald added a project: All. yaxunl requested review of this revision. Herald added a reviewer: jdoerfert. Herald add

[PATCH] D156886: [CUDA][HIP] Reorganize options for documentation

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. I think this is good, there's been some confusion around which ones goes to what. Comment at: clang/include/clang/Driver/Options.td:1021 +def offload_host_device : Flag<["

[clang] ecdded5 - [Clang] Fix strict weak ordering in ItaniumVTableBuilder

Author: Danila Kutenin Date: 2023-08-02T09:22:05-04:00 New Revision: ecdded5692f99626af338792a4191d39d2a2377e URL: https://github.com/llvm/llvm-project/commit/ecdded5692f99626af338792a4191d39d2a2377e DIFF: https://github.com/llvm/llvm-project/commit/ecdded5692f99626af338792a4191d39d2a2377e.diff

[PATCH] D155809: [NFC] [Clang] Fix strict weak ordering in ItaniumVTableBuilder

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGecdded5692f9: [Clang] Fix strict weak ordering in ItaniumVTableBuilder (authored by danlark, committed by aaron.ballman). Repository: rG LLVM Gith

[PATCH] D156205: wasm: link crt1 even in case of -shared

sbc100 accepted this revision. sbc100 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:80 - const char *Crt1 = "crt1.o"; + bool isCommand = true; + const char *Crt1; LLCM coding s

[PATCH] D156890: [clang] Remove outdated INSTALL.txt

stephanlachnit created this revision. Herald added a project: All. stephanlachnit requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Information in this file is outdated, and instead the information from clang/README.txt should be taken inste

[PATCH] D156027: [clang][Interp] Rework how initializers work

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:545-547 + // TODO(perf): For int and bool types, we can probably just skip this + // since we memset our Block*s to 0 and so we have the desired value + // without this. -

[PATCH] D57896: Variable names rule

sbc100 added a comment. Herald added a project: All. Is there still appetite to land this change?We made the switch over in LLD a while back without any issues that I know of. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57896/new/ https://re

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin updated this revision to Diff 546444. DiggerLin marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142660/new/ https://reviews.llvm.org/D142660 Files: clang/lib/Driver/OffloadBundler.cpp clang/test/lit.cfg.

[PATCH] D153276: [clang][Interp] Reject reinterpret_cast expressions

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:1761 + S.FFDiag(Loc, diag::note_constexpr_invalid_cast) + << static_cast(Kind) << S.Current->getRange(OpPC); + return false; probinson wrote: > Would you mind changing this cast from

[PATCH] D156509: [clang][Interp] Diagnose unknown parameter values

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156509/new/ https://reviews.llvm.org/D156509 ___ cfe-commits mailing lis

[PATCH] D153276: [clang][Interp] Reject reinterpret_cast expressions

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:1761 + S.FFDiag(Loc, diag::note_constexpr_invalid_cast) + << static_cast(Kind) << S.Current->getRange(OpPC); + return false; tbaeder wrote: > probinson wrote: > > Would you mind

[PATCH] D156244: [clang] Do not crash on use of a variadic overloaded operator

Fznamznon updated this revision to Diff 546445. Fznamznon added a comment. Rebase, add more test cases, fix assertion on variadic functions inside of `haveSameParameterTypes` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156244/new/ https://reviews

[PATCH] D156891: [CodeGen] Remove Constant arguments from linkage functions, NFCI.

Hahnfeld created this revision. Hahnfeld added reviewers: rjmccall, efriedma, asl. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This was unused since commit rGdd2362a8ba

[PATCH] D156244: [clang] Do not crash on use of a variadic overloaded operator

Fznamznon marked an inline comment as done. Fznamznon added inline comments. Comment at: clang/test/SemaCXX/overloaded-operator-decl.cpp:64 +class E {}; +void operator+(E, ...) {} // expected-error{{overloaded 'operator+' cannot be variadic}} +void d() { E() + E(); } ---

[PATCH] D154130: [lit][clang] Avoid realpath on Windows due to MAX_PATH limitations

RKSimon added inline comments. Comment at: llvm/utils/lit/lit/discovery.py:60 +cfgpath = util.abs_path_preserve_drive(cfgpath) +target = config_map.get(cfgpath) if target: RKSimon wrote: > Found the problem - you have moved th

[PATCH] D155145: [X86] Add AVX-VNNI-INT16 instructions.

anna added a comment. In D155145#4551621 , @craig.topper wrote: > In D155145#4551526 , @anna wrote: > >> In D155145#4544068 , @pengfei >> wrote: >> >>> In D155145#454332

[PATCH] D156743: clang/OpenCL: Add inline implementations of sqrt in builtin header

svenvh added a comment. If we go with this approach, please also remove sqrt from `clang/lib/Sema/OpenCLBuiltins.td` (and ideally add a comment pointing out that sqrt is handled in `opencl-c-base.h`) Comment at: clang/lib/Headers/opencl-c-base.h:832 + +inline float __ovld __c

[PATCH] D156896: [NFC][clang] Fix static analyzer concerns

Fznamznon created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ToolInvoc

[PATCH] D156856: [clang][dataflow] In `equivalentTo()`, ignore expression locations that are unlikely to matter.

mboehme updated this revision to Diff 546456. mboehme added a comment. Add a FIXME noting that this is a temporary solution. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156856/new/ https://reviews.llvm.org/D156856 Files: clang/include/clang/An

[PATCH] D156897: [CodeGen] Clean up access to EmittedDeferredDecls, NFCI.

Hahnfeld created this revision. Hahnfeld added reviewers: rjmccall, v.g.vassilev, junaire. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `GlobalDecl`s should only be added to `EmittedDeferredDecl` if

[PATCH] D57896: Variable names rule

michaelplatings added a comment. Hi Sam, I won't be able to take this forward but you have my encouragement. To facilitate this change I got as far as changing Git [1], and GitHub has been updated accordingly [2], but I ran out of steam before getting to the change itself. I'd be happy to let s

[PATCH] D156537: [CodeGen] Keep track of eagerly emitted globals

Hahnfeld added a comment. @v.g.vassilev do we have a means to detect this case? In D156897 , I'm refactoring all accesses to `EmittedDeferredDecl` to go via `addEmittedDeferredDecl`, so we should just add an early return when not emitting for a REPL. Reposito

[PATCH] D156900: [NFC][clang] Fix static analyzer concerns

Fznamznon created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. InterpSta

[PATCH] D152141: [Clang] Make __arm_streaming apply only to prototyped functions.

sdesmalen updated this revision to Diff 546465. sdesmalen added a comment. Remove changes that limited the attribute from being valid only when compiled with '+sme'. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152141/new/ https://reviews.llvm.or

[PATCH] D156901: [OpenMP] Change OpenMP default version in documentation and help text for --fopenmp-version

AntonRydahl created this revision. AntonRydahl added a reviewer: jdoerfert. Herald added subscribers: sunshaoce, guansong, yaxunl. Herald added a reviewer: sscalpone. Herald added a reviewer: awarzynski. Herald added projects: Flang, All. AntonRydahl requested review of this revision. Herald added

[PATCH] D156901: [OpenMP] Change OpenMP default version in documentation and help text for --fopenmp-version

tianshilei1992 added inline comments. Comment at: flang/test/Driver/driver-help.f90:55 ! HELP-NEXT: -fopenmp-version= -! HELP-NEXT:Set OpenMP version (e.g. 45 for OpenMP 4.5, 50 for OpenMP 5.0). Default value is 50 for Clang and 11 for Flang +! HELP-NEXT

[PATCH] D156904: [NFC][clang] Fix static analyzer concerns

Fznamznon created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. IdDeclInf

[PATCH] D156901: [OpenMP] Change OpenMP default version in documentation and help text for --fopenmp-version

AntonRydahl updated this revision to Diff 546477. AntonRydahl added a comment. I was a bit too fast. I changed OpenMPSupport.rst to point to both the OpenMP 5.0 and OpenMP 5.1 implementation status. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156

[PATCH] D154130: [lit][clang] Avoid realpath on Windows due to MAX_PATH limitations

RKSimon added inline comments. Comment at: llvm/utils/lit/lit/discovery.py:60 +cfgpath = util.abs_path_preserve_drive(cfgpath) +target = config_map.get(cfgpath) if target: RKSimon wrote: > RKSimon wrote: > > Found the problem

[PATCH] D127762: [Clang][AArch64] Add/implement ACLE keywords for SME.

sdesmalen updated this revision to Diff 546479. sdesmalen marked 19 inline comments as done. sdesmalen added a comment. - The attributes no longer require +sme to be passed. - Fixed IsInvalidSMECallConversion to consider the correct To/From types and added a corresponding test for the virtual ove

[PATCH] D127762: [Clang][AArch64] Add/implement ACLE keywords for SME.

sdesmalen added a comment. Thanks both for the detailed review and latest round of comments, I've tried to address them all. Comment at: clang/include/clang/AST/Type.h:3987 /// [implimits] 8 bits would be enough here. -uint16_t NumExceptionType = 0; +uint16_t NumE

[PATCH] D156901: [OpenMP] Change OpenMP default version in documentation and help text for --fopenmp-version

AntonRydahl added inline comments. Comment at: flang/test/Driver/driver-help.f90:55 ! HELP-NEXT: -fopenmp-version= -! HELP-NEXT:Set OpenMP version (e.g. 45 for OpenMP 4.5, 50 for OpenMP 5.0). Default value is 50 for Clang and 11 for Flang +! HELP-NEXT:

[PATCH] D156886: [CUDA][HIP] Reorganize options for documentation

MaskRay accepted this revision. MaskRay added inline comments. Comment at: clang/include/clang/Driver/Options.td:155 +def offload_Group : OptionGroup<"">, Group, + DocName<"Common Offloading flags">; + The existing `flags` uses are misnomer (`Fl

[PATCH] D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

foad added a comment. Herald added a project: All. Hi @erik.pilkington, I see this got reverted: commit e26c24b849211f35a988d001753e0cd15e4a9d7b Author: Erik Pilkington Date: Wed Feb 12 12:02:58 2020 -0800 Revert "[IRGen] Emit lifetime intrinsics around temporary aggregate argu

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

MaskRay added inline comments. Comment at: llvm/tools/llvm-ar/llvm-ar.cpp:74 + << " -U- Use actual timestamps and uids/gids\n" + << " -X{32|64|32_64|any} - Specifies which archive symbol tables " + "should be generated if they do not

[PATCH] D156658: [clang][dataflow] When checking `ExprToLoc` convergence, only consider children of block terminator.

xazax.hun added a comment. In D156658#4552965 , @mboehme wrote: > I've investigated this in more detail. Unfortunately, it turns out that it's > not quite as simple as just implementing widening on `ExprToLoc`. > > One of the reasons for this is that we

[PATCH] D156506: [clang][Interp] Check floating results for NaNs

aaron.ballman accepted this revision. aaron.ballman added a subscriber: jcranmer-intel. aaron.ballman added a comment. This revision is now accepted and ready to land. > This does not handle the builtin functions yet, since I'm not sure if I > should check for all nans or only signaling ones yet.

[PATCH] D152770: [clang][ExtractAPI] Add support for Objective-C categories

dang added inline comments. Comment at: clang/include/clang/ExtractAPI/ExtractAPIVisitor.h:488 + bool IsFromExternalModule = true; + for (const auto &Interface : API.getObjCInterfaces()) { +if (InterfaceDecl->getName() == Interface.second.get()->Name) { I t

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153557/new/ https://reviews.llvm.org/D153557 ___ cfe

[PATCH] D156537: [CodeGen] Keep track of eagerly emitted globals

v.g.vassilev added a comment. In D156537#4554052 , @Hahnfeld wrote: > @v.g.vassilev do we have a means to detect this case? In D156897 > , I'm refactoring all accesses to > `EmittedDeferredDecl` to go via `addEmittedDef

[PATCH] D156904: [NFC][clang] Fix static analyzer concerns

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156904/new/ https://reviews.llvm.org/D156904

[PATCH] D156900: [NFC][clang] Fix static analyzer concerns

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156900/new/ https://reviews.llvm.org/D156900

[PATCH] D156363: [Driver] -###: exit with code 1 if hasErrorOccurred

jhuber6 added a comment. Clang :: Driver/amdgpu-hip-system-arch.c Clang :: Driver/cuda-bad-arch.cu Clang :: Driver/hip-autolink.hip Clang :: Driver/hip-binding.hip Clang :: Driver/hip-cuid-hash.hip Clang :: Driver/hip-cuid.hip Clang :: Driver/hip-default-gpu-arch.hip Clang :: Drive

[PATCH] D156556: [AggressiveInstCombine][NFC] Fix typo

goldstein.w.n added a comment. Can you mark the title as NFC? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156556/new/ https://reviews.llvm.org/D156556 ___ cfe-commits mailing list cfe-commits@lists.llv

  1   2   3   >