[clang] c9d92e6 - [X86] Support -march=arrowlake, arrowlake-s, lunarlake

Author: Freddy Ye Date: 2023-07-28T15:05:54+08:00 New Revision: c9d92e66387baab18ceec1533503cc5f19048d91 URL: https://github.com/llvm/llvm-project/commit/c9d92e66387baab18ceec1533503cc5f19048d91 DIFF: https://github.com/llvm/llvm-project/commit/c9d92e66387baab18ceec1533503cc5f19048d91.diff LOG

[PATCH] D156239: [X86] Support -march=arrowlake, arrowlake-s, lunarlake

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc9d92e66387b: [X86] Support -march=arrowlake,arrowlake-s,lunarlake (authored by FreddyYe). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D149015: [clang-tidy] Added bugprone-inc-dec-in-conditions check

PiotrZSL added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone/inc-dec-in-conditions.rst:62 +means that if ``i`` were initially ``5``, the first operand ``i < 5`` would +evaluate to ``false`` and the second operand ``i > 2`` would not be evaluated.

[PATCH] D156511: [clang][Interp] Diagnose more unkonwn DeclRefExprs

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Diagnose used non-const and/or extern globals. Rep

[PATCH] D155572: [clang][Interp] Start implementing binary operators for complex types

tbaeder added a comment. In D155572#4539457 , @aaron.ballman wrote: > Is this intended to not handle all the binary operators in this patch? Yes, just a subset for now. > And also, is this intended to only impact initializers? Yes, due to problems wit

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

jhenderson added a comment. In D142660#4538936 , @DiggerLin wrote: >> As an alternative (but I think adds unnecessary complexity, due to needing >> an extra variable), you could have both tools read the environment variable >> into a string variable, th

[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

nridge added a comment. In D150124#4329163 , @ilya-biryukov wrote: > In `clangd` we also have `findExplicitReferences` and `targetDecl` functions > that seem to handle the `GoToStmt`. > In fact, I believe they are used in `findDocumentHighlights`, so I'

[PATCH] D147905: [clangd] Avoid passing -xobjective-c++-header to the system include extractor

nridge added a reviewer: sammccall. nridge added a comment. Adding Sam as well in case he has any thoughts on the discussion (another user ran into this recently and filed https://github.com/clangd/clangd/issues/1694) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D154262: [clang][Interp] LambdaThisCaptures

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154262/new/ https://reviews.llvm.org/D154262 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang] e56bf13 - [RISCV] Remove some instructions from Zvfbfwma by implying Zfbfmin according to the latest spec

Author: Jun Sha (Joshua) Date: 2023-07-28T15:52:03+08:00 New Revision: e56bf133170c9fd49c91fe943ded26a3f2b30a04 URL: https://github.com/llvm/llvm-project/commit/e56bf133170c9fd49c91fe943ded26a3f2b30a04 DIFF: https://github.com/llvm/llvm-project/commit/e56bf133170c9fd49c91fe943ded26a3f2b30a04.di

[PATCH] D155916: [RISCV] Remove some instructions from Zvfbfwma by implying Zfbfmin according to the latest spec

This revision was automatically updated to reflect the committed changes. Closed by commit rGe56bf133170c: [RISCV] Remove some instructions from Zvfbfwma by implying Zfbfmin according to… (authored by joshua-arch1). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed pr

[clang] 8c0acbf - [clang][dataflow] Avoid -Wunused-variable.

Author: Martin Braenne Date: 2023-07-28T07:57:50Z New Revision: 8c0acbf8370f29943798cd434cd0b91bbd554cdf URL: https://github.com/llvm/llvm-project/commit/8c0acbf8370f29943798cd434cd0b91bbd554cdf DIFF: https://github.com/llvm/llvm-project/commit/8c0acbf8370f29943798cd434cd0b91bbd554cdf.diff LOG

[PATCH] D156513: [clang] [libIndex] Remove unused 'RefD' parameter of IndexingContext::handleReference()

nridge created this revision. nridge added a reviewer: hokein. Herald added a subscriber: arphaman. Herald added a project: All. nridge requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.l

[PATCH] D156513: [clang] [libIndex] Remove unused 'RefD' parameter of IndexingContext::handleReference()

nridge added a comment. Noticed this while reviewing D150124 . No caller was providing a value for this parameter. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156513/new/ https://reviews.llvm.org/D156513 __

[clang] 1195bd4 - [clang][Interp][NFC] Rename a test file to be more correct

Author: Timm Bäder Date: 2023-07-28T10:12:36+02:00 New Revision: 1195bd48e017bb0f8237dec017e88d23d13ac2a9 URL: https://github.com/llvm/llvm-project/commit/1195bd48e017bb0f8237dec017e88d23d13ac2a9 DIFF: https://github.com/llvm/llvm-project/commit/1195bd48e017bb0f8237dec017e88d23d13ac2a9.diff LO

[clang] 62a251f - [Clang][BFloat16] Upgrade __bf16 by supporting increment/decrement operations

Author: Jun Sha (Joshua) Date: 2023-07-28T16:21:24+08:00 New Revision: 62a251f824f63a56563b246035b9bd24078aa98b URL: https://github.com/llvm/llvm-project/commit/62a251f824f63a56563b246035b9bd24078aa98b DIFF: https://github.com/llvm/llvm-project/commit/62a251f824f63a56563b246035b9bd24078aa98b.di

[PATCH] D152768: [Clang][BFloat16] Upgrade __bf16 by supporting increment/decrement operations

This revision was automatically updated to reflect the committed changes. Closed by commit rG62a251f824f6: [Clang][BFloat16] Upgrade __bf16 by supporting increment/decrement operations (authored by joshua-arch1). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior

[PATCH] D156515: [RemarkUtil] Refactor llvm-remarkutil to include size-diff

zjaffal created this revision. zjaffal added reviewers: fhahn, thegameg, paquette, anemet. Herald added subscribers: StephenFan, arphaman. Herald added a project: All. zjaffal requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

ckandeler updated this revision to Diff 545054. ckandeler added a comment. Addressed review comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150124/new/ https://reviews.llvm.org/D150124 Files: clang-tools-extra/clangd/unittests/XRefsTests.

[clang] c2273e3 - [clang][Interp] Implement __builtin_nan family

Author: Timm Bäder Date: 2023-07-28T10:28:55+02:00 New Revision: c2273e33bd13a227271a53cde5868546e41dc3bf URL: https://github.com/llvm/llvm-project/commit/c2273e33bd13a227271a53cde5868546e41dc3bf DIFF: https://github.com/llvm/llvm-project/commit/c2273e33bd13a227271a53cde5868546e41dc3bf.diff LO

[PATCH] D155356: [clang][Interp] Implement __builtin_nan family of functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc2273e33bd13: [clang][Interp] Implement __builtin_nan family (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D155356?vs=5

[PATCH] D154588: [CSKY] Optimize implementation of intrinsic 'llvm.cttz.i32'

zixuan-wu added inline comments. Comment at: clang/test/CodeGen/CSKY/csky-builtins.c:1 +// RUN: %clang_cc1 -triple csky -emit-llvm -o - %s | FileCheck %s + benshi001 wrote: > This file is pure test, has nothing to do with `llvm.cttz`, just to avoid > another pat

[PATCH] D156277: [Parser][ObjC] Fix parser crash on nested top-level block with better recovery path

danix800 updated this revision to Diff 545056. danix800 retitled this revision from "[Parser][ObjC] Stop parsing on eof" to "[Parser][ObjC] Fix parser crash on nested top-level block with better recovery path". danix800 edited the summary of this revision. danix800 added a comment. Delay consumi

[PATCH] D156337: [clang] Allow setting the uninitialized attribute on record

serge-sans-paille updated this revision to Diff 545060. serge-sans-paille added a comment. Take reviewers comment into account. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156337/new/ https://reviews.llvm.org/D156337 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Ba

[clang] b395e91 - [clang][Interp] Implement __builtin_inf() etc.

Author: Timm Bäder Date: 2023-07-28T10:50:13+02:00 New Revision: b395e91f2ef41e44c99857b5dd4e241a57d12b76 URL: https://github.com/llvm/llvm-project/commit/b395e91f2ef41e44c99857b5dd4e241a57d12b76 DIFF: https://github.com/llvm/llvm-project/commit/b395e91f2ef41e44c99857b5dd4e241a57d12b76.diff LO

[PATCH] D155367: [clang][Interp] Implement __builtin_inf() etc.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb395e91f2ef4: [clang][Interp] Implement __builtin_inf() etc. (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 57ca62d - [clang][Interp] Implement __builtin_copysign

Author: Timm Bäder Date: 2023-07-28T10:55:34+02:00 New Revision: 57ca62d5d35a424722059f42da4a6c75fbba2eb0 URL: https://github.com/llvm/llvm-project/commit/57ca62d5d35a424722059f42da4a6c75fbba2eb0 DIFF: https://github.com/llvm/llvm-project/commit/57ca62d5d35a424722059f42da4a6c75fbba2eb0.diff LO

[PATCH] D155368: [clang][Interp] __builtin_copysign

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG57ca62d5d35a: [clang][Interp] Implement __builtin_copysign (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D155368?vs=541

[PATCH] D156277: [Parser][ObjC] Fix parser crash on nested top-level block with better recovery path

danix800 updated this revision to Diff 545069. danix800 added a comment. Update `clang/docs/ReleaseNotes.rst`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156277/new/ https://reviews.llvm.org/D156277 Files: clang/docs/ReleaseNotes.rst clang/

[PATCH] D156277: [Parser][ObjC] Fix parser crash on nested top-level block with better recovery path

danix800 added inline comments. Comment at: clang/lib/Parse/ParseObjc.cpp:749 + if (!Tok.is(tok::eof)) +ConsumeToken(); break; rjmccall wrote: > danix800 wrote: > > rjmccall wrote: > > > aaron.ballman wrote: > > > > rjmccall wrote: > > > > > a

[clang] 9a0164a - [clang][Interp] Fix comparing nan/inf floating point values

Author: Timm Bäder Date: 2023-07-28T11:12:25+02:00 New Revision: 9a0164a0c66c28363fbc9410edd5656b28811427 URL: https://github.com/llvm/llvm-project/commit/9a0164a0c66c28363fbc9410edd5656b28811427 DIFF: https://github.com/llvm/llvm-project/commit/9a0164a0c66c28363fbc9410edd5656b28811427.diff LO

[PATCH] D155410: [clang][Interp] Fix comparing nan/inf floating point values

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9a0164a0c66c: [clang][Interp] Fix comparing nan/inf floating point values (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org

[clang] 1478d4d - [clang][Interp] Disable a float128/long double test

Author: Timm Bäder Date: 2023-07-28T11:19:35+02:00 New Revision: 1478d4dc8dc44c109bff1bbe0486cc40674a0ee2 URL: https://github.com/llvm/llvm-project/commit/1478d4dc8dc44c109bff1bbe0486cc40674a0ee2 DIFF: https://github.com/llvm/llvm-project/commit/1478d4dc8dc44c109bff1bbe0486cc40674a0ee2.diff LO

[PATCH] D156337: [clang] Allow setting the uninitialized attribute on record

serge-sans-paille updated this revision to Diff 545074. serge-sans-paille added a comment. (rebased on `main`) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156337/new/ https://reviews.llvm.org/D156337 Files: clang/include/clang/Basic/Attr.td clang/include/clang/Basic/AttrDocs.td

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

owenpan accepted this revision. owenpan added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:2964-2965 if (FormatTok->is(tok::l_brace)) { +FormatToken *LBrace = FormatTok; +LBrace->setFinalizedType(TT_NamespaceLBrace); + Nit. C

[PATCH] D156518: Fix handling of medial hyphens in Unicode Names.

cor3ntin created this revision. Herald added subscribers: mstorsjo, hiraditya, dschuff. Herald added a project: All. cor3ntin requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. In a Unicode name was stored in a way that cause

[clang] f04ccad - [Flang] Add support for fsave-optimization-record

Author: Victor Kingi Date: 2023-07-28T09:26:40Z New Revision: f04ccadf35441b2e13b3ab30edeef251818fa9c7 URL: https://github.com/llvm/llvm-project/commit/f04ccadf35441b2e13b3ab30edeef251818fa9c7 DIFF: https://github.com/llvm/llvm-project/commit/f04ccadf35441b2e13b3ab30edeef251818fa9c7.diff LOG:

[PATCH] D155452: [Flang] Add support for fsave-optimization-record

This revision was automatically updated to reflect the committed changes. Closed by commit rGf04ccadf3544: [Flang] Add support for fsave-optimization-record (authored by Victor Kingi , committed by kiranchandramohan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D156518: Fix handling of medial hyphens in Unicode Names.

tbaeder added inline comments. Comment at: llvm/lib/Support/UnicodeNameToCodepoint.cpp:350 bool DoesStartWith = startsWith(Name, Item.Prefix, Strict, Consummed, -NameStart, NeedleStart, /*isPrefix*/ true); +

[PATCH] D156247: [Clang] Add a warning on uses of coroutine keywords

ilya-biryukov added subscribers: thieta, tstellar. ilya-biryukov added a comment. @aaron.ballman the internal `-cc1` flag is good enough for us and should aleviate most of the concerns in this thread. We could also live without a libc++ change. I suggest to move forward with `-cc1` flag. Would t

[PATCH] D156518: Fix handling of medial hyphens in Unicode Names.

cor3ntin updated this revision to Diff 545078. cor3ntin added a comment. Fix comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156518/new/ https://reviews.llvm.org/D156518 Files: clang/docs/ReleaseNotes.rst clang/lib/Lex/LiteralSupport.cpp

[PATCH] D156405: [NFC][clang] Fix static analyzer concerns

Fznamznon updated this revision to Diff 545079. Fznamznon added a comment. Rebase to maybe pass precommit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156405/new/ https://reviews.llvm.org/D156405 Files: clang/lib/Frontend/FrontendAction.cpp I

[PATCH] D156406: [NFC][clang] Fix static analyzer concerns

Fznamznon updated this revision to Diff 545080. Fznamznon added a comment. Rebase to maybe pass precommit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156406/new/ https://reviews.llvm.org/D156406 Files: clang/include/clang/Sema/IdentifierResolv

[PATCH] D156415: [NFC][clang] Fix static analyzer concerns

Fznamznon updated this revision to Diff 545082. Fznamznon added a comment. Rebase to maybe pass precommit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156415/new/ https://reviews.llvm.org/D156415 Files: clang/include/clang/Analysis/CFGStmtMap.h

[PATCH] D105759: Implement P2361 Unevaluated string literals

cor3ntin added a comment. In D105759#4540716 , @hubert.reinterpretcast wrote: >> I hope this patch may allow to gather some data on that. > > @cor3ntin, I have reports that applications having encoding prefixes in > `static_assert` are failing to build.

[PATCH] D156247: [Clang] Add a warning on uses of coroutine keywords

cor3ntin added a comment. How does a -cc1 flag alleviate the burden concerns for libc++? It would still be something they would have to support, unless we plan to remove the flag before c++26 and you are happy with the inclusion of `` and `` producing subpar errors. However, in the C++26 cycle,

[PATCH] D156503: [clang][Interp] Don't assume throw stmts have a subexpr

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. This one was easy! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156503/new/ https://reviews.llvm.org/D156503 _

[PATCH] D155955: [Clang] Improve the handling of large arrays evaluation.

cor3ntin added a subscriber: rsmith. cor3ntin added a comment. @efriedma I sent a mail to core last night, some discussion is happening. @rsmith made some good point so hopefully we will be able to produce some hard error in that case, But given this is preexisting, I'm going to land that and h

[clang] 81fb216 - [clang][Diagnostics] Provide source range to invalid casts in const expr

Author: Timm Bäder Date: 2023-07-28T12:28:45+02:00 New Revision: 81fb216245784582277663a68d535dd7f66456cb URL: https://github.com/llvm/llvm-project/commit/81fb216245784582277663a68d535dd7f66456cb DIFF: https://github.com/llvm/llvm-project/commit/81fb216245784582277663a68d535dd7f66456cb.diff LO

[PATCH] D153241: [clang][Diagnostics] Provide source range to invalid casts in const expr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG81fb21624578: [clang][Diagnostics] Provide source range to invalid casts in const expr (authored by tbaeder). Repository: rG LLVM Github Monorepo

[PATCH] D156415: [NFC][analyzer] Fix static analyzer concerns

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156415/new/ https://reviews.llvm.org/D156415 ___

[clang] 7010a4f - [clang][Interp] Don't assume throw stmts have a subexpr

Author: Timm Bäder Date: 2023-07-28T12:44:53+02:00 New Revision: 7010a4f14e0bb397773915910fbcf557f6ad6816 URL: https://github.com/llvm/llvm-project/commit/7010a4f14e0bb397773915910fbcf557f6ad6816 DIFF: https://github.com/llvm/llvm-project/commit/7010a4f14e0bb397773915910fbcf557f6ad6816.diff LO

[PATCH] D156503: [clang][Interp] Don't assume throw stmts have a subexpr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7010a4f14e0b: [clang][Interp] Don't assume throw stmts have a subexpr (authored by tbaeder). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[clang] 3b34d69 - Revert "For #64088: mark vtable as used if we might emit a reference to it."

Author: Dmitry Chernenkov Date: 2023-07-28T10:49:53Z New Revision: 3b34d69ac7a643742364be3591b324ddd14ef9aa URL: https://github.com/llvm/llvm-project/commit/3b34d69ac7a643742364be3591b324ddd14ef9aa DIFF: https://github.com/llvm/llvm-project/commit/3b34d69ac7a643742364be3591b324ddd14ef9aa.diff

[PATCH] D156247: [Clang] Add a warning on uses of coroutine keywords

Endill added a comment. In D156247#4541756 , @ilya-biryukov wrote: > @aaron.ballman the internal -cc1 flag > > - internal `clang -cc1 -fno-coroutines`. I'm sorry, but I find this wording misleading. `-cc1 -fno-coroutines` is not internal in the same se

[PATCH] D156357: clang: Add elementwise bitreverse builtin

arsenm added inline comments. Comment at: clang/docs/LanguageExtensions.rst:634 the most negative integer remains the most negative integer - T __builtin_elementwise_fma(T x, T y, T z) fused multiply add, (x * y) + z.

[PATCH] D149172: [clang][Interp] Emit proper diagnostic when comparing unrelated pointers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9092acc51010: [clang][Interp] Emit proper diagnostic when comparing unrelated pointers (authored by tbaeder). Changed prior to commit: https://rev

[clang] 9092acc - [clang][Interp] Emit proper diagnostic when comparing unrelated pointers

Author: Timm Bäder Date: 2023-07-28T13:23:48+02:00 New Revision: 9092acc510108737e0e9e3857756a65032debc6f URL: https://github.com/llvm/llvm-project/commit/9092acc510108737e0e9e3857756a65032debc6f DIFF: https://github.com/llvm/llvm-project/commit/9092acc510108737e0e9e3857756a65032debc6f.diff LO

[PATCH] D155955: [Clang] Improve the handling of large arrays evaluation.

cor3ntin updated this revision to Diff 545099. cor3ntin edited the summary of this revision. cor3ntin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155955/new/ https://reviews.llvm.org/D155955 Files: clang/docs/ReleaseNot

[PATCH] D156523: [clang][DeclPrinter] Fix AST print to suppress output of implicit (non-written) constructor initializers

strimo378 created this revision. strimo378 added a reviewer: aaron.ballman. Herald added a project: All. strimo378 requested review of this revision. Herald added subscribers: cfe-commits, wangpc. Herald added a project: clang. DeclPrinter::PrintConstructorInitializers did output non-written const

[PATCH] D156523: [clang][DeclPrinter] Fix AST print to suppress output of implicit (non-written) constructor initializers

strimo378 added a comment. The current output of the test case can be shown here: https://godbolt.org/z/95ToPbqrP Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156523/new/ https://reviews.llvm.org/D156523 _

[PATCH] D156524: [flang][nfc] Simplify option forwarding

awarzynski created this revision. awarzynski added a reviewer: kiranchandramohan. Herald added a reviewer: sscalpone. Herald added a subscriber: sunshaoce. Herald added projects: Flang, All. awarzynski requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert, MaskRay. Her

[PATCH] D156247: [Clang] Add a warning on uses of coroutine keywords

ilya-biryukov added a comment. In D156247#4541826 , @cor3ntin wrote: > How does a -cc1 flag alleviate the burden concerns for libc++? It would still > be something they would have to support, unless we plan to remove the flag > before c++26 and you are

[PATCH] D156518: Fix handling of medial hyphens in Unicode Names.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/utils/UnicodeData/UnicodeNameMappingGenerator.cpp:100 +for (auto ChIt = Name.begin(); ChIt != Name.end(); + ChIt += IsBeforeMe

[PATCH] D156237: Complete the implementation of P2361 Unevaluated string literals

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a minor formatting nit that @Fznamznon had pointed out but was missed. Comment at: clang/lib/Parse/ParseDecl.cpp:431-436 +if (Expr.isInvalid()) {

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

aaron.ballman added a comment. In D112921#4535716 , @wangpc wrote: > I am not familiar with libcxx, can you please help me to fix these tests? I > hope we can catch up with the release of LLVM 17. I think it's too late to put this into Clang 17. This i

[PATCH] D156237: Complete the implementation of P2361 Unevaluated string literals

cor3ntin added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:431-436 +if (Expr.isInvalid()) { + SawError = true; + break; +} else { + Exprs.push_back(Expr.get()); +} aaron.ballman wrote: > Oups, sorry @Fznamznon, I'll fix

[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

kadircet added a comment. sorry for missing this review. Nathan's explanation around `targetDecl` vs `findRefs` is absolutely right (btw, thanks a lot Nathan for taking good care of clangd, I don't think I say that enough). hopefully one day we can switch clangd's usage of libindex to our inter

[PATCH] D156524: [flang][nfc] Simplify option forwarding

kiranchandramohan accepted this revision. kiranchandramohan added a comment. This revision is now accepted and ready to land. LG. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:146-147 + + Args.AddAllArgs(CmdArgs, {options::OPT_flang_experimental_hlfir, +

[PATCH] D155290: [PGO] Use Unique Profile Files when New Processes are Forked

qiongsiwu1 added a comment. Ping for review. Thanks so much! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155290/new/ https://reviews.llvm.org/D155290 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D156405: [NFC][clang] Fix static analyzer concerns

Fznamznon added a comment. The failures are unrelated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156405/new/ https://reviews.llvm.org/D156405 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D156406: [NFC][clang] Fix static analyzer concerns

Fznamznon added a comment. The failures are unrelated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156406/new/ https://reviews.llvm.org/D156406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D156415: [NFC][analyzer] Fix static analyzer concerns

Fznamznon added a comment. The failures are unrelated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156415/new/ https://reviews.llvm.org/D156415 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[clang] a623f4c - [NFC][clang] Fix static analyzer concerns

Author: Podchishchaeva, Mariya Date: 2023-07-28T05:29:56-07:00 New Revision: a623f4c7849838361c9a69324cf669100bc0e414 URL: https://github.com/llvm/llvm-project/commit/a623f4c7849838361c9a69324cf669100bc0e414 DIFF: https://github.com/llvm/llvm-project/commit/a623f4c7849838361c9a69324cf669100bc0e

[PATCH] D156405: [NFC][clang] Fix static analyzer concerns

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa623f4c78498: [NFC][clang] Fix static analyzer concerns (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] 9fe23fb - [NFC][analyzer] Fix static analyzer concerns

Author: Podchishchaeva, Mariya Date: 2023-07-28T05:30:34-07:00 New Revision: 9fe23fbb2318f86eab0a8404c5024ee04f1eb83d URL: https://github.com/llvm/llvm-project/commit/9fe23fbb2318f86eab0a8404c5024ee04f1eb83d DIFF: https://github.com/llvm/llvm-project/commit/9fe23fbb2318f86eab0a8404c5024ee04f1eb

[PATCH] D156415: [NFC][analyzer] Fix static analyzer concerns

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9fe23fbb2318: [NFC][analyzer] Fix static analyzer concerns (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[clang] a457067 - [NFC][clang] Fix static analyzer concerns

Author: Podchishchaeva, Mariya Date: 2023-07-28T05:32:41-07:00 New Revision: a457067d2c6b3416233d67e280c9b73dc170da46 URL: https://github.com/llvm/llvm-project/commit/a457067d2c6b3416233d67e280c9b73dc170da46 DIFF: https://github.com/llvm/llvm-project/commit/a457067d2c6b3416233d67e280c9b73dc170d

[PATCH] D156406: [NFC][clang] Fix static analyzer concerns

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa457067d2c6b: [NFC][clang] Fix static analyzer concerns (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151834: Include math-errno with fast-math

aaron.ballman added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2313-2315 + // Math intrinsics are generated only when math-errno is disabled. Any pragma + // or attribute that affect math-errno, should prevent or allow math + // intrincs to be generated. Intr

[clang] 45ab2b4 - [Clang] Improve the handling of large arrays evaluation.

Author: Corentin Jabot Date: 2023-07-28T14:38:22+02:00 New Revision: 45ab2b48bd55e50a86f6026ed31d2b60a118bdce URL: https://github.com/llvm/llvm-project/commit/45ab2b48bd55e50a86f6026ed31d2b60a118bdce DIFF: https://github.com/llvm/llvm-project/commit/45ab2b48bd55e50a86f6026ed31d2b60a118bdce.diff

[PATCH] D155955: [Clang] Improve the handling of large arrays evaluation.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG45ab2b48bd55: [Clang] Improve the handling of large arrays evaluation. (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 163a6e2 - [clang][CodeGen][NFC] remove trailing whitespace (fix check-format)

Author: dingfei Date: 2023-07-28T20:39:30+08:00 New Revision: 163a6e237596071dbe97fe46044fb3dca0464e6a URL: https://github.com/llvm/llvm-project/commit/163a6e237596071dbe97fe46044fb3dca0464e6a DIFF: https://github.com/llvm/llvm-project/commit/163a6e237596071dbe97fe46044fb3dca0464e6a.diff LOG:

[PATCH] D156201: [ASTImporter] Fix corrupted RecordLayout introduced by circular referenced fields

balazske added inline comments. Comment at: clang/lib/AST/ASTImporter.cpp:7418 + + return UO; } Why is it better to use `CreateEmpty` instead of the old code? Does `Create` do something that does not work at this situation (probably getting the layout)? If ye

[PATCH] D156247: [Clang] Add a warning on uses of coroutine keywords

aaron.ballman added a comment. Given the views expressed on this thread, I think this requires a wider community discussion to determine whether we want to support this idea or not, regardless of -cc1 or driver-level option. We should not be adding a novel language dialect as we're getting read

[PATCH] D156518: Fix handling of medial hyphens in Unicode Names.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG68410fbed769: Fix handling of medial hyphens in Unicode Names. (authored by cor3ntin). Changed prior to commit: https://reviews.llvm.org/D156518?v

[PATCH] D156518: Fix handling of medial hyphens in Unicode Names.

cor3ntin added inline comments. Comment at: llvm/utils/UnicodeData/UnicodeNameMappingGenerator.cpp:100 +for (auto ChIt = Name.begin(); ChIt != Name.end(); + ChIt += IsBeforeMedial ? 3 : 1) { + char Ch = *ChIt; aaron.ballman wrote: > Parens here m

[PATCH] D150124: [index][clangd] Consider labels when indexing function bodies

ckandeler added inline comments. Comment at: clang/lib/Index/IndexBody.cpp:150 +ParentDC, +unsigned(SymbolRole::NameReference)); + } kadircet wrote: > nridge wrote: > > `NameReference` was i

[PATCH] D156533: [clang][DeclPrinter] Fix missing semicolon in AST print for methods that are definitions without having a body

strimo378 created this revision. strimo378 added a reviewer: aaron.ballman. Herald added a project: All. strimo378 requested review of this revision. Herald added subscribers: cfe-commits, wangpc. Herald added a project: clang. DeclPrinter used FunctionDecl::isThisDeclarationADefinition to decide

[PATCH] D154189: [clang][Interp] Implement zero-init of record types

tbaeder updated this revision to Diff 545131. tbaeder marked 2 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154189/new/ https://reviews.llvm.org/D154189 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/In

[PATCH] D154189: [clang][Interp] Implement zero-init of record types

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:1240 + // Fields + for (const Record::Field &Field : R->fields()) { +const Descriptor *D = Field.Desc; aaron.ballman wrote: > It looks like you're not initializing base clas

[PATCH] D154189: [clang][Interp] Implement zero-init of record types

tbaeder added inline comments. Comment at: clang/test/AST/Interp/records.cpp:939 + }; +#endif + aaron.ballman wrote: > I think we should have more test coverage. I mentioned a few above, but other > things to test would be inner classes (and anonymous members),

[PATCH] D156533: [clang][DeclPrinter] Fix missing semicolon in AST print for methods that are definitions without having a body

strimo378 added a comment. https://github.com/llvm/llvm-project/issues/62996 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156533/new/ https://reviews.llvm.org/D156533 ___ cfe-commits mailing list cfe-co

[PATCH] D154093: [clang-format] Break long strings in Verilog

sstwcw added a comment. @owenpan What do you think about this revision especially the replacement part? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154093/new/ https://reviews.llvm.org/D154093 ___ cfe-

[PATCH] D155546: [clang][Interp] Implement __builtin_fmin

aaron.ballman added a comment. In D155546#4541144 , @tbaeder wrote: > Thanks for the info @jcranmer-intel. > > I see that the current intepreter doesn't check this for `__builtin_fmin`(GCC > does) either, but it does error out for e.g. `__builtin_nan("")

[PATCH] D154568: [Clang][OpenMP] GPU simd directive code generation

domada added a comment. Hi, thank you for your contribution. Could you fix assertion failure which was reported by Clang CI ( https://buildkite.com/llvm-project/premerge-checks/builds/166519#01898852-f9c9-4dd2-9933-b32be792c976 ) ? `Assertion failed: OpenMPRuntime != nullptr, file C:\ws\w9\llvm

[PATCH] D155546: [clang][Interp] Implement __builtin_fmin

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, we can handle NaN behavior in a follow-up. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155546/new/ https://reviews.llvm.org/D155546

[PATCH] D156537: [CodeGen] Keep track of eagerly emitted globals

Hahnfeld created this revision. Hahnfeld added reviewers: v.g.vassilev, rjmccall, aaron.ballman. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. An inline virtual function must be emitted, but we need t

[PATCH] D154189: [clang][Interp] Implement zero-init of record types

tbaeder updated this revision to Diff 545146. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154189/new/ https://reviews.llvm.org/D154189 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/ByteCodeExprGen.h clang/lib/AST/Interp/Descriptor.cpp clang/lib/AST/Interp

[PATCH] D156539: [Clang][CodeGen] `__builtin_alloca`s should care about address spaces too

AlexVlx created this revision. AlexVlx added reviewers: rjmccall, yaxunl. AlexVlx added a project: clang. Herald added a subscriber: arichardson. Herald added a project: All. AlexVlx requested review of this revision. Herald added a subscriber: cfe-commits. `alloca` instructions always return poin

  1   2   3   >