[PATCH] D155670: [c-index-test] Suppress -Wcast-qual after D153911

MaskRay created this revision. MaskRay added reviewers: AlexM, dblaikie. Herald added a subscriber: arphaman. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. free_remapped_files needs to discard the cast

[PATCH] D155147: [X86] Add SM3 instructions.

pengfei added inline comments. Comment at: clang/lib/Headers/sm3intrin.h:162 +/// \param imm8 +///A 128-bit vector of [4 x int]. +/// \returns This is `int` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155147/

[PATCH] D155671: [include-cleaner] allow spelling strategies to customize verbatim/system headers

sammccall created this revision. sammccall added a reviewer: kadircet. Herald added a project: All. sammccall requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Our use case is wanting to apply a spelling strategy to rewrite the sp

[clang] 0f0c3d4 - [tools] Ignore -Wcast-qual in c-index-test.c after D153911 (NFC)

Author: Jie Fu Date: 2023-07-19T10:55:12+08:00 New Revision: 0f0c3d45d7d75ba82a955246da654146a7d57a0d URL: https://github.com/llvm/llvm-project/commit/0f0c3d45d7d75ba82a955246da654146a7d57a0d DIFF: https://github.com/llvm/llvm-project/commit/0f0c3d45d7d75ba82a955246da654146a7d57a0d.diff LOG: [

[PATCH] D155147: [X86] Add SM3 instructions.

FreddyYe updated this revision to Diff 541824. FreddyYe marked an inline comment as done. FreddyYe added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155147/new/ https://reviews.llvm.org/D155147 Files: clang/docs/Re

[clang] 16d5078 - [tools] Fix buildbot build failure

Author: Jie Fu Date: 2023-07-19T11:39:00+08:00 New Revision: 16d50781e16374f5bf930ba0b9aa8cbbb034ee6c URL: https://github.com/llvm/llvm-project/commit/16d50781e16374f5bf930ba0b9aa8cbbb034ee6c DIFF: https://github.com/llvm/llvm-project/commit/16d50781e16374f5bf930ba0b9aa8cbbb034ee6c.diff LOG: [

[PATCH] D155647: [RISCV] Add C intrinsics for scalar crypto

wangpc added a comment. Can we run mem2reg pass in RUNs just like RVV tests (maybe another cleanup patch)? I think there are a lot of noises in CHECKS. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155647/new/ https://reviews.llvm.org/D155647 ___

[PATCH] D155356: [clang][Interp] Implement __builtin_nan family of functions

tbaeder updated this revision to Diff 541832. tbaeder marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155356/new/ https://reviews.llvm.org/D155356 Files: clang/lib/AST/Interp/InterpBuiltin.cpp clang/test/AST/Interp/builtin-functions.cpp Index: clang/t

[PATCH] D155356: [clang][Interp] Implement __builtin_nan family of functions

tbaeder marked 2 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/InterpBuiltin.cpp:106 +// 2008 revisions, MIPS interpreted sNaN-2008 as qNan and qNaN-2008 as +// sNaN. This is now known as "legacy NaN" encoding. +if (Signaling

[PATCH] D155356: [clang][Interp] Implement __builtin_nan family of functions

tbaeder updated this revision to Diff 541833. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155356/new/ https://reviews.llvm.org/D155356 Files: clang/lib/AST/Interp/InterpBuiltin.cpp clang/test/AST/Interp/builtin-functions.cpp Index: clang/t

[clang] 12f35b3 - [tools] Use "#pragma GCC" instead of "#pragma clang" to ignore -Wcast-qual in c-index-test.c (NFC)

Author: Jie Fu Date: 2023-07-19T12:05:05+08:00 New Revision: 12f35b39ee63e932d4bdf6b28cce2e3d07713c4d URL: https://github.com/llvm/llvm-project/commit/12f35b39ee63e932d4bdf6b28cce2e3d07713c4d DIFF: https://github.com/llvm/llvm-project/commit/12f35b39ee63e932d4bdf6b28cce2e3d07713c4d.diff LOG: [

[PATCH] D155356: [clang][Interp] Implement __builtin_nan family of functions

tbaeder added a comment. One thing I'm wondering though is: constexpr char A[] = {'1', '2', '3'}; constexpr double d = __builtin_nans(A); what's expected here? The given char array is not null-terminated. Should the interpreter ignore the null byte at the end if it's there? `StringRef::get

[PATCH] D155545: [clang][Interp] Pass CallExpr to builtin functions

tbaeder updated this revision to Diff 541834. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155545/new/ https://reviews.llvm.org/D155545 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Interp.h clang/lib/AST/Interp/InterpBuiltin.cpp clang/lib/AST/Interp/Opcod

[PATCH] D155670: [c-index-test] Suppress -Wcast-qual after D153911

MaskRay abandoned this revision. MaskRay added a comment. commit 0f0c3d45d7d75ba82a955246da654146a7d57a0d did this first Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155670/new

[PATCH] D155539: [CUDA][HIP] Use the same default language std as C++

yaxunl updated this revision to Diff 541836. yaxunl added a comment. update release note CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155539/new/ https://reviews.llvm.org/D155539 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/LangStandards.def clang/lib/Basic/LangS

[PATCH] D155239: [clang-format] Add SpacesInParens with SpacesInParensOptions

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. This looks good can you wait for one of the others to accept too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155239/new/ https

[PATCH] D155456: [RISCV] Support -m[no-]strict-align options

arichardson added inline comments. Comment at: clang/test/Driver/riscv-features.c:41 +// DEFAULT: "-target-feature" "-unaligned-scalar-mem" +// DEFAULT-NOT: "-target-feature" "+unaligned-scalar-mem" + This looks a bit fragile, can we just check all -target-featur

[PATCH] D155674: [RISCV] Update zihintntl to 1p0

BeMg created this revision. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, jdoerfert, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, nio

[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

cor3ntin added a comment. Note that you are probably need something like `SourceLocExprScopeGuard` to make source_location actually work, , it might be worth doing in this patch. The idea is to remember the location of a call when evaluating default arguments / default member initializers Repo

[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

cor3ntin added inline comments. Comment at: clang/test/AST/Interp/builtin-functions.cpp:153 + static_assert(__builtin_LINE() == 152, ""); +} what is missing to enable the existing source location tests with the new intterpreter? Repository: rG LLVM Github M

[clang] 95bdd6e - [NFC] [C++20] [Modules] Add C++20 modules related changes to Release Note

Author: Chuanqi Xu Date: 2023-07-19T14:16:01+08:00 New Revision: 95bdd6eed6f3f4b8a95523516120068ac18eccff URL: https://github.com/llvm/llvm-project/commit/95bdd6eed6f3f4b8a95523516120068ac18eccff DIFF: https://github.com/llvm/llvm-project/commit/95bdd6eed6f3f4b8a95523516120068ac18eccff.diff LO

[PATCH] D155625: [clang-tidy] Warn only for copyable/movable classes in cppcoreguidelines-avoid-const-or-ref-members

carlosgalvezp added a comment. In D155625#4512123 , @PiotrZSL wrote: > LGTM, but I'm not sure if isCopyableOrMovable will always work correctly, for > a user defined special members it looks ok, but for some implicit ones I > worry it may not always wor

[clang] bc3f29c - Revert "[NFC] [C++20] [Modules] Add C++20 modules related changes to Release Note"

Author: Chuanqi Xu Date: 2023-07-19T14:28:47+08:00 New Revision: bc3f29c5401f866380e5c4cedf5a1a8a8e503348 URL: https://github.com/llvm/llvm-project/commit/bc3f29c5401f866380e5c4cedf5a1a8a8e503348 DIFF: https://github.com/llvm/llvm-project/commit/bc3f29c5401f866380e5c4cedf5a1a8a8e503348.diff LO

[PATCH] D155610: [Clang][ExprConstant] Print integer instead of character on static assertion failure

cor3ntin added a comment. I agree with Aaron that in the current state, the common case diagnostics are made worse. But there is room for improvement! I think what we want to do here is modify `ConvertAPValueToString` so that it applies the same escape logic to `char` as we do in `pushEscapedSt

[PATCH] D144164: [clang][Interp] Handle PtrMemOps

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144164/new/ https://reviews.llvm.org/D144164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f5768ec - [NFC] [C++20] [Modules] Add C++20 modules related changes to Release Note

Author: Chuanqi Xu Date: 2023-07-19T14:33:09+08:00 New Revision: f5768ec9b1dcc3f72aae9ab90b92670c2828770b URL: https://github.com/llvm/llvm-project/commit/f5768ec9b1dcc3f72aae9ab90b92670c2828770b DIFF: https://github.com/llvm/llvm-project/commit/f5768ec9b1dcc3f72aae9ab90b92670c2828770b.diff LO

[PATCH] D155625: [clang-tidy] Warn only for copyable/movable classes in cppcoreguidelines-avoid-const-or-ref-members

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidConstOrRefDataMembersCheck.cpp:91-102 + Finder->addMatcher( + fieldDecl(unless(isMemberOfLambda()), +hasDeclContext(cxxRecordDecl(isCopyableOrMovable())), +

[clang] dfdfd30 - [Clang] Fix -Wconstant-logical-operand when LHS is a constant

Author: Shivam Gupta Date: 2023-07-19T12:12:11+05:30 New Revision: dfdfd306cfaf54fbc43e2d5eb36489dac3eb9976 URL: https://github.com/llvm/llvm-project/commit/dfdfd306cfaf54fbc43e2d5eb36489dac3eb9976 DIFF: https://github.com/llvm/llvm-project/commit/dfdfd306cfaf54fbc43e2d5eb36489dac3eb9976.diff

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGdfdfd306cfaf: [Clang] Fix -Wconstant-logical-operand when LHS is a constant (authored by shivam-amd). Changed prior to co

[clang-tools-extra] 036a1b2 - [clangd] Always run preamble indexing on a separate thread

Author: Kadir Cetinkaya Date: 2023-07-19T08:48:14+02:00 New Revision: 036a1b2202cb71aacfa72ef15145a88dc50a02cf URL: https://github.com/llvm/llvm-project/commit/036a1b2202cb71aacfa72ef15145a88dc50a02cf DIFF: https://github.com/llvm/llvm-project/commit/036a1b2202cb71aacfa72ef15145a88dc50a02cf.dif

[PATCH] D155619: [clangd] Always run preamble indexing on a separate thread

This revision was automatically updated to reflect the committed changes. Closed by commit rG036a1b2202cb: [clangd] Always run preamble indexing on a separate thread (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155619/new/ h

[clang] 64cfcde - [Clang] Fix the location of default init expressions

Author: Corentin Jabot Date: 2023-07-19T08:54:01+02:00 New Revision: 64cfcde31a48962c3bbc703753a4ea41200da7a8 URL: https://github.com/llvm/llvm-project/commit/64cfcde31a48962c3bbc703753a4ea41200da7a8 DIFF: https://github.com/llvm/llvm-project/commit/64cfcde31a48962c3bbc703753a4ea41200da7a8.diff

[PATCH] D155573: [Clang] Fix the location of default init expressions

This revision was automatically updated to reflect the committed changes. Closed by commit rG64cfcde31a48: [Clang] Fix the location of default init expressions (authored by cor3ntin). Changed prior to commit: https://reviews.llvm.org/D155573?vs=541473&id=541853#toc Repository: rG LLVM Github

[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

xgupta added a comment. Thanks, @nickdesaulniers for reviewing and @nathanchance for testing the change. @aaron.ballman, I also agree with @xbolva00 seems warning in kernel code is valid but I also agree with your comment about macro, may be better to track the macro-related issue with another

<    1   2   3   4