[PATCH] D153906: [clang] Allow disassembly of multi-module bitcode files

2023-07-10 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay requested changes to this revision. MaskRay added a comment. This revision now requires changes to proceed. > [clang] Allow disassembly of multi-module bitcode files The subject confused me as I did not recognize what disassembly means :) > Clang currently exits with an error message i

[PATCH] D154911: Enabling fstack_clash_protection for arm32 bit, thumb and thumb2 mode

2023-07-10 Thread Eli Friedman via Phabricator via cfe-commits
efriedma added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3460 + } else if (EffectiveTriple.isArm() || EffectiveTriple.isThumb()) { +CmdArgs.push_back("-mstack-probe-size=1024"); + } Why 1024? Comment at: llvm/lib/

[PATCH] D154709: [clang][ASTImporter] Add a 'Message' member to ASTImportError and use it throughout ASTImporter

2023-07-10 Thread Balázs Kéri via Phabricator via cfe-commits
balazske added a comment. The goal is to have a message always in `ASTImportError`? Then probably the constructor without message can be removed, at least to check if really the message is added at all places. I found that it is missing in `VisitObjCImplementationDecl`. I do not know what happe

[clang] e53da3e - [clang][dataflow][NFC] Expand a comment.

2023-07-10 Thread Martin Braenne via cfe-commits
Author: Martin Braenne Date: 2023-07-11T06:32:08Z New Revision: e53da3eab42e6efd448c1c60c14668e1eb3d907c URL: https://github.com/llvm/llvm-project/commit/e53da3eab42e6efd448c1c60c14668e1eb3d907c DIFF: https://github.com/llvm/llvm-project/commit/e53da3eab42e6efd448c1c60c14668e1eb3d907c.diff LOG

[PATCH] D154834: [clang][dataflow][NFC] Expand a comment.

2023-07-10 Thread Martin Böhme via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe53da3eab42e: [clang][dataflow][NFC] Expand a comment. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D154923: [CodeGen] Support bitcode input containing multiple modules

2023-07-10 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay created this revision. MaskRay added reviewers: ormris, efriedma, rjmccall, aaron.ballman. Herald added subscribers: steven_wu, hiraditya. Herald added a project: All. MaskRay requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When usi

[PATCH] D78038: [clangd] WIP: fix several bugs relating to include insertion

2023-07-10 Thread Thilo Vörtler via Phabricator via cfe-commits
voertler added a comment. We stumbled upon this issue too. What is needed to pull in this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78038/new/ https://reviews.llvm.org/D78038 ___ cfe-commits m

[PATCH] D154903: clangd: Provide the resource dir via environment variable

2023-07-10 Thread Nathan Ridge via Phabricator via cfe-commits
nridge added a reviewer: sammccall. nridge added a comment. Looks reasonable to me but Sam should OK this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154903/new/ https://reviews.llvm.org/D154903 ___ c

[clang] ffcf214 - [analyzer] NonParamVarRegion should prefer definition over canonical decl

2023-07-10 Thread Balazs Benics via cfe-commits
Author: Balazs Benics Date: 2023-07-11T08:50:59+02:00 New Revision: ffcf214b5d27453119575d4e075cac483d659024 URL: https://github.com/llvm/llvm-project/commit/ffcf214b5d27453119575d4e075cac483d659024 DIFF: https://github.com/llvm/llvm-project/commit/ffcf214b5d27453119575d4e075cac483d659024.diff

[PATCH] D154827: [analyzer] NonParamVarRegion should prefer definition over canonical decl

2023-07-10 Thread Balázs Benics via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGffcf214b5d27: [analyzer] NonParamVarRegion should prefer definition over canonical decl (authored by steakhal). Changed prior to commit: https://r

<    1   2   3