[PATCH] D154460: [ODRHash] Stop hashing `ObjCMethodDecl::isPropertyAccessor` as it doesn't capture inherent method quality.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf7e0aae7284b: [ODRHash] Stop hashing `ObjCMethodDecl::isPropertyAccessor` as it doesn't… (authored by vsapsai). Repository: rG LLVM Github Monorep

[PATCH] D143241: [Clang] Reset FP options before function instantiations

Jake-Egan added a comment. Hi, the following assertion is getting tripped on AIX: Assertion failed: *FpPragmaCurrentValue == SemaObj->FpPragmaStack.DefaultValue && "Expected a default pragma float_control value", file /scratch/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/llvm-project/c

[PATCH] D154559: [clang] Fix constant evaluation about static member function

yaxunl created this revision. yaxunl added reviewers: rjmccall, tra, rsmith. Herald added a project: All. yaxunl requested review of this revision. Currently, clang does not allow static constexpr member functions called through a const reference of an object in constant expression, e.g. the follo

[PATCH] D140727: [XRay] Add initial support for loongarch64

Ami-zhang updated this revision to Diff 537564. Ami-zhang added a comment. (1) Rebase (2) Make some minor changes to xray-attribute-instrumentation.ll Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140727/new/ https://reviews.llvm.org/D140727 Files

[PATCH] D153600: Implement -frecord-command-line for XCOFF

Jake-Egan updated this revision to Diff 537572. Jake-Egan added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153600/new/ https://reviews.llvm.org/D153600 Files: clang/lib/Driver/ToolChains/Clang.cpp llvm/include/ll

[PATCH] D153600: Implement -frecord-command-line for XCOFF

Jake-Egan added inline comments. Comment at: llvm/lib/MC/MCAsmStreamer.cpp:981 + + // Metadata needs to be padded out to an even word size. + size_t MetadataSize = Metadata.size(); scott.linder wrote: > stephenpeckham wrote: > > There's no requirement to pad th

[PATCH] D153205: [clang-format] Support block indenting array/struct list initializers

owenpan added a comment. Do you need to update the current diff to show the net change? For example, the unit tests you added don't show up as a diff right now. Comment at: clang/include/clang/Format/Format.h:95-98 /// \warning -/// Note: This currently only applies

[PATCH] D154531: [AMDGPU] Support -mcpu=native for OpenCL

yaxunl added a comment. In D154531#4475386 , @MaskRay wrote: > Seems reasonable. I assume that there isn't a way to add a portable test. Right. It is difficult to test it with lit tests, but we will test it with internal CI. CHANGES SINCE LAST ACTION

[PATCH] D154531: [AMDGPU] Support -mcpu=native for OpenCL

yaxunl marked an inline comment as done. yaxunl added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:86 +def warn_drv_multi_gpu_arch : Warning< + "multiple %0 architecture are detected: %1; only the first one is used for " + "'%2'">, InGroup; --

[PATCH] D154531: [AMDGPU] Support -mcpu=native for OpenCL

yaxunl updated this revision to Diff 537575. yaxunl marked an inline comment as done. yaxunl added a comment. revised by comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154531/new/ https://reviews.llvm.org/D154531 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td cla

[PATCH] D150221: Add option -fkeep-persistent-storage-variables to emit all variables that have a persistent storage duration

hubert.reinterpretcast added a comment. Update (looping back from offline discussion): The LTO use case is covered. There was some confusion over which meaning of "static" was meant by `-fkeep-static-consts`. The "static" meant was storage duration. Furthermore, there is some discussion over co

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops added inline comments. Comment at: clang/test/OpenMP/generic_loop_ast_print.cpp:26 //PRINT: T j, z; -//PRINT: #pragma omp loop collapse(C) reduction(+: z) lastprivate(j) bind(thread) +//PRINT: #pragma omp simd collapse(C) reduction(+: z) lastprivate(j) //PRINT: f

[PATCH] D140727: [XRay] Add initial support for loongarch64

MaskRay added inline comments. Comment at: compiler-rt/lib/xray/xray_loongarch64.cpp:153 + const XRaySledEntry &Sled) XRAY_NEVER_INSTRUMENT { + // FIXME: In the future we'd need to distinguish between non-tail exits and + // tail exits for better infor

[PATCH] D140727: [XRay] Add initial support for loongarch64

MaskRay added inline comments. Comment at: compiler-rt/lib/xray/xray_loongarch64.cpp:23 +enum PatchOpcodes : uint32_t { + PO_ADDID = 0x02c0, // addi.d rd, rj, imm + PO_SD = 0x29c0, // st.d rd, base, offset I think the `PO_` style actually harms rea

[PATCH] D154382: [ClangRepl] support code completion at a REPL

v.g.vassilev added a comment. Can you extend the commit log to include a description of how things are currently done? For example, it would be good to read about design and technical decisions, etc. Comment at: clang/lib/Interpreter/CodeCompletion.cpp:79 + if (auto Err = In

[PATCH] D154567: [RISCV] Use ClangBuiltin in IntrinsicsRISCV.td to map some scalar crypto builtins to IR intrinsic.

craig.topper created this revision. craig.topper added reviewers: asb, VincentWu, kito-cheng. Herald added subscribers: jobnoorman, luke, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones,

[PATCH] D154568: OpenMP GPU simd directive code generation

efwright created this revision. efwright added a reviewer: jdoerfert. Herald added subscribers: sunshaoce, guansong, hiraditya, yaxunl. Herald added a project: All. efwright requested review of this revision. Herald added subscribers: llvm-commits, openmp-commits, cfe-commits, jplehr, sstefan1. He

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops added inline comments. Comment at: clang/include/clang/Sema/Sema.h:11094 + bool checkLastPrivateForMappedDirectives(ArrayRef Clauses); + bool mapLoopConstruct(llvm::SmallVector *ClausesWithoutBind, ABataev wrote: > const member function? > Add a comment

[PATCH] D154479: [clang][dataflow] Bug fix: `BuiltinFnToFnPtr` cast does not produce a pointer.

mboehme added a comment. Pre-merge failure looks unrelated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154479/new/ https://reviews.llvm.org/D154479 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[clang] ca01be5 - [clang][dataflow] Bug fix: `BuiltinFnToFnPtr` cast does not produce a pointer.

Author: Martin Braenne Date: 2023-07-06T06:56:02Z New Revision: ca01be54c1e94c552eceb00fc21b4363fae63d6c URL: https://github.com/llvm/llvm-project/commit/ca01be54c1e94c552eceb00fc21b4363fae63d6c DIFF: https://github.com/llvm/llvm-project/commit/ca01be54c1e94c552eceb00fc21b4363fae63d6c.diff LOG

[PATCH] D154479: [clang][dataflow] Bug fix: `BuiltinFnToFnPtr` cast does not produce a pointer.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGca01be54c1e9: [clang][dataflow] Bug fix: `BuiltinFnToFnPtr` cast does not produce a pointer. (authored by mboehme). Repository: rG LLVM Github Mon

<    1   2   3