[PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

ChuanqiXu added a comment. > Yes, that was the decision at the last time we looked - because removing > decls would degrade this - if we have new information that changes our > preferred design, then fine. I remember the major reason for the last time to not remove the decls are that the desig

[PATCH] D154368: [Clang] Fix constraint checking of non-generic lambdas.

cor3ntin updated this revision to Diff 536976. cor3ntin added a comment. - Move the check for lambda conversion operator in CheckFunmctionConstraints so that it is always performed. - Add tests of constraints referring to parameters of the lambda Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D154357: [Driver] Recognize powerpc-unknown-eabi as a bare-metal toolchain

cwalther added a comment. Should I be worried about the build and test failures? At a glance, they look unrelated to my changes, so unless told otherwise I’m going to ignore them. Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:168 + + if (Triple.getVendor() != llvm::Tr

[PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

iains added a comment. In D126694#4470297 , @ChuanqiXu wrote: >> Yes, that was the decision at the last time we looked - because removing >> decls would degrade this - if we have new information that changes our >> preferred design, then fine. > > I rem

[PATCH] D126694: [C++20][Modules] Implementation of GMF decl elision.

ChuanqiXu added a comment. In D126694#4470358 , @iains wrote: > In D126694#4470297 , @ChuanqiXu > wrote: > >>> Yes, that was the decision at the last time we looked - because removing >>> decls would degrade thi

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

hokein added a comment. Thanks for the fix. Sorry for being late (I was looking through the emails and found this patch). Comment at: clang/lib/AST/ExprConstant.cpp:4921 + // value is. + if (isa(E)) +return false; The constant evaluator is not aware of t

[PATCH] D154417: [libc++] Disable tree invariant check in asserts mode

hans created this revision. hans added reviewers: var-const, ldionne. Herald added a project: All. hans requested review of this revision. Herald added a project: libc++. Herald added a subscriber: libcxx-commits. Herald added a reviewer: libc++. This is a follow-up to D153672

[PATCH] D154420: [clang][dataflow] Model variables / fields / funcs used in default initializers.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The newly added test fails without the other cha

[PATCH] D154421: [clang][dataflow] Add a test for a struct that is directly self-referential through a reference.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The ongoing migration to strict handling of value categories (see https://disc

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

RKSimon added inline comments. Comment at: clang/test/CodeGen/attr-cpuspecific-cpus.c:40 ATTR(cpu_specific(knm)) void CPU(void){} +ATTR(cpu_specific(cascadelake)) void CPU(void){} +ATTR(cpu_specific(cooperlake)) void CPU(void){} FreddyYe wrote: > In this patch,

[PATCH] D153340: [include-cleaner] Add an IgnoreHeaders flag to the command-line tool.

hokein updated this revision to Diff 536998. hokein marked 10 inline comments as done. hokein added a comment. address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153340/new/ https://reviews.llvm.org/D153340 Files: clang-tools

[PATCH] D153340: [include-cleaner] Add an IgnoreHeaders flag to the command-line tool.

hokein added inline comments. Comment at: clang-tools-extra/include-cleaner/test/tool.cpp:17 +//RUN: clang-include-cleaner -print=changes %s --ignore-headers="foobar\.h,foo\.h" -- -I%S/Inputs/ | FileCheck --match-full-lines --allow-empty --check-prefix=IGNORE %s +// I

[PATCH] D153612: [clang][analyzer] Add and change NoteTags in StdLibraryFunctionsChecker.

balazske updated this revision to Diff 537002. balazske added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153612/new/ https://reviews.llvm.org/D153612 Files: clang/lib/StaticAnalyzer/Checkers/ErrnoModeling.cpp clang/lib/Sta

[PATCH] D153776: [clang][analyzer] Display notes in StdLibraryFunctionsChecker only if interesting

balazske updated this revision to Diff 537003. balazske added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153776/new/ https://reviews.llvm.org/D153776 Files: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp

[PATCH] D154423: [clang][analyzer] Add all success/failure messages to StdLibraryFunctionsChecker.

balazske created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a reviewer: NoQ. Herald added a project:

[PATCH] D153493: [dataflow] avoid more accidental copies of Environment

sammccall closed this revision. sammccall added a comment. Herald added a subscriber: wangpc. This relanded as 1e010c5c4fae43c52d6f5f1c8e8920c26bcc6cc7 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn added a comment. @nikic Are you happy with the current patchset? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148216/new/ https://reviews.llvm.org/D148216 ___ cfe-commits mailing list cfe-commi

[PATCH] D154420: [clang][dataflow] Model variables / fields / funcs used in default initializers.

mboehme added a comment. pre-merge failure looks unrelated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154420/new/ https://reviews.llvm.org/D154420 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D154325: [analyzer][NFC] Move away from using raw-for loops inside StaticAnalyzer

xazax.hun accepted this revision. xazax.hun added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CoreEngine.h:501 public: +const iterator &operator*() const { return *this; } + Is this just a dummy to make sure this sat

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

sammccall marked 11 inline comments as done. sammccall added inline comments. Herald added a subscriber: wangpc. Comment at: clang/include/clang/Analysis/FlowSensitive/Formula.h:69 + + Atom atom() const { +assert(kind() == AtomRef); gribozavr2 wrote: > Shoul

[clang] 2fd614e - [dataflow] Add dedicated representation of boolean formulas

Author: Sam McCall Date: 2023-07-04T12:19:44+02:00 New Revision: 2fd614efc1bb9c27f1bc6c3096c60a7fe121e274 URL: https://github.com/llvm/llvm-project/commit/2fd614efc1bb9c27f1bc6c3096c60a7fe121e274 DIFF: https://github.com/llvm/llvm-project/commit/2fd614efc1bb9c27f1bc6c3096c60a7fe121e274.diff LO

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sammccall marked an inline comment as done. Closed by commit rG2fd614efc1bb: [dataflow] Add dedicated representation of boolean formulas (authored by sammccall). Chang

[PATCH] D151325: [analyzer] Differentiate lifetime extended temporaries

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Overall looks good to me. I think the changes to the notes already make the analyzer more useful so there are some observable benefits to this patch. Comment at: clan

[PATCH] D154421: [clang][dataflow] Add a test for a struct that is directly self-referential through a reference.

mboehme updated this revision to Diff 537029. mboehme added a comment. Actually make the test pass. It was missing an indirection. No idea how I missed this on the initial upload... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154421/new/ https:/

[PATCH] D151325: [analyzer] Differentiate lifetime extended temporaries

tomasz-kaminski-sonarsource marked an inline comment as done. tomasz-kaminski-sonarsource added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:1282 + LLVM_ATTRIBUTE_RETURNS_NONNULL + const Expr *getExpr() const { return Ex; } +

[clang] c68ba12 - [clang][modules] Mark fewer identifiers as out-of-date

Author: Jan Svoboda Date: 2023-07-04T12:58:44+02:00 New Revision: c68ba12abf490716fd7a57bba9c2dda1d537b19c URL: https://github.com/llvm/llvm-project/commit/c68ba12abf490716fd7a57bba9c2dda1d537b19c DIFF: https://github.com/llvm/llvm-project/commit/c68ba12abf490716fd7a57bba9c2dda1d537b19c.diff L

[PATCH] D151277: [clang][modules] Mark fewer identifiers as out-of-date

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc68ba12abf49: [clang][modules] Mark fewer identifiers as out-of-date (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D154339: [clang][dataflow] Make `runDataflowReturnError()` a non-template function.

mboehme added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:389 /// verify the results. -template -llvm::Error -runDataflowReturnError(llvm::StringRef Code, VerifyResultsT VerifyResults, - DataflowAnalysisOptions Opti

[PATCH] D154434: [clang-tidy] Don't emit the whole spelling include header in include-cleaner diagnostic message

hokein created this revision. hokein added a reviewer: kadircet. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. hokein requested review of this revision. Herald added a subscriber: ilya-biryukov. Herald added a project:

[PATCH] D154339: [clang][dataflow] Make `runDataflowReturnError()` a non-template function.

gribozavr2 added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:389 /// verify the results. -template -llvm::Error -runDataflowReturnError(llvm::StringRef Code, VerifyResultsT VerifyResults, - DataflowAnalysisOptions O

[PATCH] D154339: [clang][dataflow] Make `runDataflowReturnError()` a non-template function.

mboehme added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:389 /// verify the results. -template -llvm::Error -runDataflowReturnError(llvm::StringRef Code, VerifyResultsT VerifyResults, - DataflowAnalysisOptions Opti

[PATCH] D154421: [clang][dataflow] Add a test for a struct that is directly self-referential through a reference.

mboehme added a comment. Pre-merge failure looks unrelated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154421/new/ https://reviews.llvm.org/D154421 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D154417: [libc++] Disable tree invariant check in asserts mode

alexfh accepted this revision. alexfh added a comment. Thanks for the temporary fix, Hans! We're also affected by this. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154417/new/ https://reviews.llvm.org/D154417 __

[PATCH] D154339: [clang][dataflow] Make `runDataflowReturnError()` a non-template function.

gribozavr2 added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:389 /// verify the results. -template -llvm::Error -runDataflowReturnError(llvm::StringRef Code, VerifyResultsT VerifyResults, - DataflowAnalysisOptions O

[PATCH] D154417: [libc++] Disable tree invariant check in asserts mode

alexfh added a comment. Given the comment in https://reviews.llvm.org/D153672#4468348, I think, this should be fine to submit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154417/new/ https://reviews.llvm.org/D154417

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

yronglin marked 3 inline comments as done. yronglin added a comment. Thanks a lot for your comments! @hokein Comment at: clang/lib/AST/ExprConstant.cpp:4921 + // value is. + if (isa(E)) +return false; hokein wrote: > The constant evaluator is not aware of

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

uabelho added a comment. Failed Tests (6): Clang-Unit :: Analysis/FlowSensitive/./ClangAnalysisFlowSensitiveTests/BoolValueDebugStringTest/ComplexBooleanWithSomeNames Clang-Unit :: Analysis/FlowSensitive/./ClangAnalysisFlowSensitiveTests/BoolValueDebugStringTest/Conjunction Clang-U

[PATCH] D154325: [analyzer][NFC] Move away from using raw-for loops inside StaticAnalyzer

donat.nagy added a comment. I don't have concrete remarks, but I would like to note that I'm happy to see this cleanup :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154325/new/ https://reviews.llvm.org/D154325 _

[clang] 880f306 - [clang][dataflow] Add a test for a struct that is directly self-referential through a reference.

Author: Martin Braenne Date: 2023-07-04T12:06:13Z New Revision: 880f306226fcb97d85d422480954eb8765ff31c7 URL: https://github.com/llvm/llvm-project/commit/880f306226fcb97d85d422480954eb8765ff31c7 DIFF: https://github.com/llvm/llvm-project/commit/880f306226fcb97d85d422480954eb8765ff31c7.diff LOG

[clang] 1e7329c - [clang][dataflow] Model variables / fields / funcs used in default initializers.

Author: Martin Braenne Date: 2023-07-04T12:06:10Z New Revision: 1e7329cd79c53165f113edfe6a2ff06d12899632 URL: https://github.com/llvm/llvm-project/commit/1e7329cd79c53165f113edfe6a2ff06d12899632 DIFF: https://github.com/llvm/llvm-project/commit/1e7329cd79c53165f113edfe6a2ff06d12899632.diff LOG

[PATCH] D154420: [clang][dataflow] Model variables / fields / funcs used in default initializers.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1e7329cd79c5: [clang][dataflow] Model variables / fields / funcs used in default initializers. (authored by mboehme). Repository: rG LLVM Github M

[PATCH] D154421: [clang][dataflow] Add a test for a struct that is directly self-referential through a reference.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG880f306226fc: [clang][dataflow] Add a test for a struct that is directly self-referential… (authored by mboehme). Repository: rG LLVM Github Monor

[PATCH] D154437: [analyzer][NFC] Make AnalyzerConfig round-tripping deterministic

steakhal created this revision. steakhal added reviewers: NoQ, xazax.hun, jansvoboda11. Herald added subscribers: PiotrZSL, carlosgalvezp, manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, mgrang, szepet, baloghadamsoftware. Herald added a reviewer: Szeleth

[PATCH] D154339: [clang][dataflow] Make `runDataflowReturnError()` a non-template function.

mboehme updated this revision to Diff 537061. mboehme added a comment. Rename `runDataflowReturnError()` as discussed in review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154339/new/ https://reviews.llvm.org/D154339 Files: clang/include/clan

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

thakis added a comment. Looks like this breaks tests on windows: http://45.33.8.238/win/80815/step_7.txt Please take a look etc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153366/new/ https://reviews.llvm.org/D153366 ___

[PATCH] D154325: [analyzer][NFC] Move away from using raw-for loops inside StaticAnalyzer

steakhal planned changes to this revision. steakhal marked an inline comment as done. steakhal added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CoreEngine.h:501 public: +const iterator &operator*() const { return *this; } +

[PATCH] D154437: [analyzer][NFC] Make AnalyzerConfig round-tripping deterministic

jansvoboda11 added a comment. Has this not been addressed by D142861 already? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154437/new/ https://reviews.llvm.org/D154437 __

[PATCH] D151277: [clang][modules] Mark fewer identifiers as out-of-date

jansvoboda11 added a comment. I finally got around to testing this patch on compiles of explicit modules. The number of elapsed CPU cycles decreased (by up to 1.8% for large modules) and the cumulative size of PCM files decreased by 2% (though small modules are a few bytes larger). These findin

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

aaron.ballman added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:4921 + // value is. + if (isa(E)) +return false; yronglin wrote: > hokein wrote: > > The constant evaluator is not aware of the "error" concept, it is only > > aware of value-d

[clang-tools-extra] 2444fb9 - [clang-tidy] Don't emit the whole spelling include header in include-cleaner diagnostic message

Author: Haojian Wu Date: 2023-07-04T14:32:27+02:00 New Revision: 2444fb96435ecae73211f3ced3d06e48719afe97 URL: https://github.com/llvm/llvm-project/commit/2444fb96435ecae73211f3ced3d06e48719afe97 DIFF: https://github.com/llvm/llvm-project/commit/2444fb96435ecae73211f3ced3d06e48719afe97.diff LO

[PATCH] D154434: [clang-tidy] Don't emit the whole spelling include header in include-cleaner diagnostic message

This revision was automatically updated to reflect the committed changes. Closed by commit rG2444fb96435e: [clang-tidy] Don't emit the whole spelling include header in include-cleaner… (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

FreddyYe updated this revision to Diff 537065. FreddyYe marked 2 inline comments as done. FreddyYe added a comment. Add comments about Mangling and OnlyForCPUDispatchSpecific, and remove the supporting more/new CPU names for cpu_specific/dispatch feature. Repository: rG LLVM Github Monorepo C

[PATCH] D61508: [clang-tidy] bugprone-header-guard : a simple version of llvm-header-guard

aaron.ballman added a comment. In D61508#4469426 , @garymm wrote: > @aaron.ballman what's remaining for this to be mergeable? It needs to be rebased onto trunk and it looks like there's some test coverage missing for unsupported styles. It should probabl

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

TWeaver added a comment. Hello and good afternoon from the UK, I believe this change has introduced test failures on the following buildbot: https://lab.llvm.org/buildbot/#/builders/139/builds/44269 are you able to take a look see? Much appreciated, Tom W Repository: rG LLVM Github Monorep

[clang] d0be47c - [clang][dataflow] Make `runDataflowReturnError()` a non-template function.

Author: Martin Braenne Date: 2023-07-04T12:44:49Z New Revision: d0be47c51cfdb8b94eb20279c02e8e2875380919 URL: https://github.com/llvm/llvm-project/commit/d0be47c51cfdb8b94eb20279c02e8e2875380919 DIFF: https://github.com/llvm/llvm-project/commit/d0be47c51cfdb8b94eb20279c02e8e2875380919.diff LOG

[PATCH] D154339: [clang][dataflow] Make `runDataflowReturnError()` a non-template function.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd0be47c51cfd: [clang][dataflow] Make `runDataflowReturnError()` a non-template function. (authored by mboehme). Repository: rG LLVM Github Monorep

[PATCH] D152770: [clang][ExtractAPI] Add support for Objective-C categories

Ruturaj4 created this revision. Herald added a reviewer: ributzka. Herald added a project: All. Ruturaj4 added a reviewer: dang. Ruturaj4 edited the summary of this revision. Ruturaj4 edited the summary of this revision. Ruturaj4 updated this revision to Diff 537064. Ruturaj4 added a comment. Rutur

[PATCH] D154437: [analyzer][NFC] Make AnalyzerConfig round-tripping deterministic

steakhal added a comment. In D154437#4471225 , @jansvoboda11 wrote: > Has this not been addressed by D142861 > already? Hm, The same failure. This must be related. I'll have a look. But, you can try it yourself that t

[clang] 7a72ce9 - Revert "[dataflow] Add dedicated representation of boolean formulas"

Author: Tom Weaver Date: 2023-07-04T14:05:54+01:00 New Revision: 7a72ce98224be76d9328e65eee472381f7c8e7fe URL: https://github.com/llvm/llvm-project/commit/7a72ce98224be76d9328e65eee472381f7c8e7fe DIFF: https://github.com/llvm/llvm-project/commit/7a72ce98224be76d9328e65eee472381f7c8e7fe.diff LO

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

TWeaver added a comment. My apologies but I've had to revert this change for now until the author can address the buildbot failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153366/new/ https://reviews.llvm.org/D153366 __

[PATCH] D154417: [libc++] Disable tree invariant check in asserts mode

hans added a comment. In D154417#4471141 , @alexfh wrote: > Given the comment in https://reviews.llvm.org/D153672#4468348, I think, this > should be fine to submit. Sounds good to me. Happy to follow up if libc++ maintainers have more input. Repositor

[PATCH] D154417: [libc++] Disable tree invariant check in asserts mode

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG1e35e93e30c2: [libc++] Disable tree invariant check in asserts mode (authored by hans). Repository: rG LLVM Github Mono

[PATCH] D154443: [clangd] Downgrade deprecated warnings to hints

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. This tries t

[PATCH] D154443: [clangd] Downgrade deprecated warnings to hints

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154443/new/ https://reviews.llvm.org/D154443 __

[PATCH] D153366: [dataflow] Add dedicated representation of boolean formulas

sammccall added a comment. In D153366#4471320 , @TWeaver wrote: > My apologies but I've had to revert this change for now until the author can > address the buildbot failures. Thanks for the revert, and sorry for the disruption - I expected to be around

[clang-tools-extra] a59b24b - [clangd] Downgrade deprecated warnings to hints

Author: Kadir Cetinkaya Date: 2023-07-04T16:07:08+02:00 New Revision: a59b24be47ed6263c254d168567b9ebba391fac9 URL: https://github.com/llvm/llvm-project/commit/a59b24be47ed6263c254d168567b9ebba391fac9 DIFF: https://github.com/llvm/llvm-project/commit/a59b24be47ed6263c254d168567b9ebba391fac9.dif

[PATCH] D154443: [clangd] Downgrade deprecated warnings to hints

This revision was automatically updated to reflect the committed changes. Closed by commit rGa59b24be47ed: [clangd] Downgrade deprecated warnings to hints (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154443/new/ https://revi

[clang] 1c8c5a8 - [clang][Interp][NFC] Merge two if statements

Author: Timm Bäder Date: 2023-07-04T16:16:17+02:00 New Revision: 1c8c5a89c59cee16d6500a4e83c8c29b8a4a37a4 URL: https://github.com/llvm/llvm-project/commit/1c8c5a89c59cee16d6500a4e83c8c29b8a4a37a4 DIFF: https://github.com/llvm/llvm-project/commit/1c8c5a89c59cee16d6500a4e83c8c29b8a4a37a4.diff LO

[clang] 843ff75 - [clang][Interp][NFC] Return std::nullopt explicitly

Author: Timm Bäder Date: 2023-07-04T16:16:18+02:00 New Revision: 843ff7581408a02e852c0f1f7ebf176cabbc7527 URL: https://github.com/llvm/llvm-project/commit/843ff7581408a02e852c0f1f7ebf176cabbc7527 DIFF: https://github.com/llvm/llvm-project/commit/843ff7581408a02e852c0f1f7ebf176cabbc7527.diff LO

[clang] 044be8f - [clang][Interp][NFC] Add some missing const qualifiers

Author: Timm Bäder Date: 2023-07-04T16:16:17+02:00 New Revision: 044be8f5d12fcb35cb5c30fa05d95b1abbf19232 URL: https://github.com/llvm/llvm-project/commit/044be8f5d12fcb35cb5c30fa05d95b1abbf19232 DIFF: https://github.com/llvm/llvm-project/commit/044be8f5d12fcb35cb5c30fa05d95b1abbf19232.diff LO

[PATCH] D151325: [analyzer] Differentiate lifetime extended temporaries

tomasz-kaminski-sonarsource marked an inline comment as done. tomasz-kaminski-sonarsource added a comment. In D151325#4470832 , @xazax.hun wrote: > Overall looks good to me. I think the changes to the notes already make the > analyzer more useful so ther

[PATCH] D151325: [analyzer] Differentiate lifetime extended temporaries

tomasz-kaminski-sonarsource updated this revision to Diff 537092. tomasz-kaminski-sonarsource added a comment. Reformatting and link to revelant core issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151325/new/ https://reviews.llvm.org/D151325

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

yronglin marked 3 inline comments as done. yronglin added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:4921 + // value is. + if (isa(E)) +return false; aaron.ballman wrote: > yronglin wrote: > > hokein wrote: > > > The constant evaluator is n

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. Herald added a subscriber: StephenFan. LGTM > Fixed. Does this test case exist somewhere? I couldn't find it upstream. That wasn't an existing test case. Though if you add a `--check-globals all

[PATCH] D154450: [clangd][c++20] Drop first template argument in code completion in some contexts.

massberg created this revision. massberg added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. massberg requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. In

[PATCH] D151325: [analyzer] Differentiate lifetime extended temporaries

xazax.hun accepted this revision. xazax.hun added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h:1282 + LLVM_ATTRIBUTE_RETURNS_NONNULL + const Expr *getExpr() const { return Ex; } + LLVM_ATTRIBUTE_RETURNS_NONNULL ---

[PATCH] D154221: [analyzer] Fix false negative when pass implicit cast nil to nonnull

tripleCC updated this revision to Diff 537110. tripleCC added a comment. try to fix nullability-arc.mm test case error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154221/new/ https://reviews.llvm.org/D154221 Files: clang/lib/StaticAnalyzer/Che

[PATCH] D153273: [analyzer] Rework support for CFGScopeBegin, CFGScopeEnd, CFGLifetime elements

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. I'd appreciate some review on this, given that a lot of you would be affected by the changes of CFG. By changes I mean, fixes for goto statements, properly calling destructors and stuff.

[PATCH] D151325: [analyzer] Differentiate lifetime extended temporaries

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MoveChecker.cpp:556 + bool IsLocal = + isa_and_nonnull(MR) && + isa(MR->getMemorySpace()); I think strictly speaking this might be "unsound" resulting in false positives in

[PATCH] D154325: [analyzer][NFC] Move away from using raw-for loops inside StaticAnalyzer

steakhal added a comment. Fixed remarks, cleaned up residual includes, rebased. Should be read to land. Final thoughts? Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/CoreEngine.h:501 public: +const iterator &operator*() const { return *this; } +

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

yronglin added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:4921 + // value is. + if (isa(E)) +return false; yronglin wrote: > aaron.ballman wrote: > > yronglin wrote: > > > hokein wrote: > > > > The constant evaluator is not aware of the "er

[PATCH] D154221: [analyzer] Fix false negative when pass implicit cast nil to nonnull

tripleCC added inline comments. Comment at: clang/test/Analysis/nullability-arc.mm:26 [self foo:nil]; -#if __has_feature(objc_arc) - // expected-note@-2{{Calling 'foo:'}} - // expected-note@-3{{Passing nil object reference via 1st parameter 'param'}} -#endif + // expected-w

[PATCH] D154325: [analyzer][NFC] Move away from using raw-for loops inside StaticAnalyzer

xazax.hun accepted this revision. xazax.hun added a comment. I love it, I think we can land this as is. If there are further comments, we can address those in follow-up PRs. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngineCXX.cpp:1190 CXXRecordDecl::field_iterator CurFi

[PATCH] D151325: [analyzer] Differentiate lifetime extended temporaries

tomasz-kaminski-sonarsource marked an inline comment as done. tomasz-kaminski-sonarsource added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MoveChecker.cpp:556 + bool IsLocal = + isa_and_nonnull(MR) && + isa(MR->getMemorySpace()); xa

[clang] df5213c - [clang][Interp][NFC] Return a const pointer from Pointer::getRecord()

Author: Timm Bäder Date: 2023-07-04T17:21:51+02:00 New Revision: df5213c4420e40dace6506d39bba28459a91c2a4 URL: https://github.com/llvm/llvm-project/commit/df5213c4420e40dace6506d39bba28459a91c2a4 DIFF: https://github.com/llvm/llvm-project/commit/df5213c4420e40dace6506d39bba28459a91c2a4.diff LO

[PATCH] D151325: [analyzer] Differentiate lifetime extended temporaries

xazax.hun added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/MoveChecker.cpp:556 + bool IsLocal = + isa_and_nonnull(MR) && + isa(MR->getMemorySpace()); tomasz-kaminski-sonarsource wrote: > xazax.hun wrote: > > I think strictly speakin

[PATCH] D154437: [analyzer][NFC] Make AnalyzerConfig round-tripping deterministic

steakhal abandoned this revision. steakhal added a comment. Ah, D142861 is only on `main`, that's why we don't have that. I'll cherry-pick that then. @jansvoboda11 Thanks for the xref! Confirmed, that fixes the issue. Abandoning this one. Repository: rG LLV

[PATCH] D154221: [analyzer] Fix false negative when pass implicit cast nil to nonnull

tripleCC added inline comments. Comment at: clang/test/Analysis/nullability-arc.mm:25 [self foo:nil]; + // expected-warning@-1{{nil passed to a callee that requires a non-null 1st parameter}} I think there should be a warning when we call the foo: method

[clang] 74514e8 - [clang][Interp][NFC] Fix GetFnPtr signature

Author: Timm Bäder Date: 2023-07-04T17:35:28+02:00 New Revision: 74514e8713bfcd31faeb6f4cfd5e29824413e1c1 URL: https://github.com/llvm/llvm-project/commit/74514e8713bfcd31faeb6f4cfd5e29824413e1c1 DIFF: https://github.com/llvm/llvm-project/commit/74514e8713bfcd31faeb6f4cfd5e29824413e1c1.diff LO

[clang] a936357 - [clang][Interp][NFC] Return integer from Boolean::bitWidth()

Author: Timm Bäder Date: 2023-07-04T17:35:28+02:00 New Revision: a93635794813ab26a751f72ccb78534e288390b2 URL: https://github.com/llvm/llvm-project/commit/a93635794813ab26a751f72ccb78534e288390b2 DIFF: https://github.com/llvm/llvm-project/commit/a93635794813ab26a751f72ccb78534e288390b2.diff LO

[clang] 0d40973 - [clang][Interp][NFC] Move CastFP to Interp.h

Author: Timm Bäder Date: 2023-07-04T17:35:28+02:00 New Revision: 0d40973644ba7f3efe666735306646579a7ffe5e URL: https://github.com/llvm/llvm-project/commit/0d40973644ba7f3efe666735306646579a7ffe5e DIFF: https://github.com/llvm/llvm-project/commit/0d40973644ba7f3efe666735306646579a7ffe5e.diff LO

[PATCH] D154450: [clangd][c++20] Drop first template argument in code completion in some contexts.

sammccall added a comment. Cool! This makes sense, and is much cheaper than actually working out how to render the abbreviated arg list and store it in the index. Nice that TopLevel gives us some of these contexts, but I suspect it's not all. (If not, it's fine to handle just this case for now

[PATCH] D86993: Document Clang's expectations of the C standard library.

RalfJung added a comment. Herald added a subscriber: StephenFan. Herald added a project: All. What is the status of this patch? It has not been committed as far as I can tell. I was looking into this coming from Rust, where we do worry a bit about LLVM calling `memcpy`, `memmove` or `memset` in

[PATCH] D154417: [libc++] Disable tree invariant check in asserts mode

ldionne added a comment. LGTM, but as a matter of process, please try to wait for someone from the libc++ review group before submitting. Thanks for the fix! Comment at: libcxx/include/__tree:379-380 _LIBCPP_ASSERT_UNCATEGORIZED(__z != nullptr, "The node to remove should

[PATCH] D154221: [analyzer] Fix false negative when pass implicit cast nil to nonnull

steakhal added a comment. @tripleCC Could you clarify the status. Do you need some help or review? Do you have concerns? You made some inline comments that I couldn't put into context. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154221/new/ http

[PATCH] D153600: Implement -frecord-command-line for XCOFF

Jake-Egan updated this revision to Diff 537156. Jake-Egan edited the summary of this revision. Jake-Egan added a comment. Updated to use both a newline and null byte to separate command lines. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153600/new/ https://reviews.llvm.org/D153600 Fi

[PATCH] D153600: Implement -frecord-command-line for XCOFF

Jake-Egan updated this revision to Diff 537160. Jake-Egan added a comment. Fix formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153600/new/ https://reviews.llvm.org/D153600 Files: clang/lib/Driver/ToolChains/Clang.cpp llvm/include/llvm/CodeGen/AsmPrinter.h llvm/include/ll

[PATCH] D154450: [clangd][c++20] Drop first template argument in code completion in some contexts.

massberg updated this revision to Diff 537161. massberg added a comment. Update code by resolving comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154450/new/ https://reviews.llvm.org/D154450 Files: clang-tools-extra/clangd/CodeComplete.c

[PATCH] D154450: [clangd][c++20] Drop first template argument in code completion in some contexts.

massberg marked 7 inline comments as done. massberg added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:327 +return ""; + return "<" + Signature.substr(FirstComma + 2); +} sammccall wrote: > I don't love the arithmetic, the repetitio

[PATCH] D154459: [ODRHash] Stop hashing `ObjCMethodDecl::isOverriding` as it doesn't capture inherent method quality.

vsapsai created this revision. vsapsai added reviewers: ChuanqiXu, jansvoboda11, Bigcheese. Herald added a subscriber: ributzka. Herald added a project: All. vsapsai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `isOverriding` depends on

  1   2   >