[PATCH] D152473: [clang-format] Add test case for issue 63170

owenpan added a comment. Can you add the test to clang/unittests/Format/FormatTest.cpp instead? Please also include the full diff. See https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[clang] 2c44168 - [Clang] Remove typed pointer consistency assertions (NFC)

Author: Nikita Popov Date: 2023-06-09T09:45:43+02:00 New Revision: 2c44168381f0b06eb629cd093510a9fca6913066 URL: https://github.com/llvm/llvm-project/commit/2c44168381f0b06eb629cd093510a9fca6913066 DIFF: https://github.com/llvm/llvm-project/commit/2c44168381f0b06eb629cd093510a9fca6913066.diff

[clang] 96962d5 - [clang] set python3 as required build dependency

Author: Petr Hosek Date: 2023-06-09T07:52:48Z New Revision: 96962d5512fbc6af0ada0f13e6be332c026529cb URL: https://github.com/llvm/llvm-project/commit/96962d5512fbc6af0ada0f13e6be332c026529cb DIFF: https://github.com/llvm/llvm-project/commit/96962d5512fbc6af0ada0f13e6be332c026529cb.diff LOG: [c

[PATCH] D152418: [clang] set python3 as required build dependency

This revision was automatically updated to reflect the committed changes. Closed by commit rG96962d5512fb: [clang] set python3 as required build dependency (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152418/new/ https://revie

[PATCH] D152504: [clang][ThreadSafety] Analyze cleanup functions

tbaeder created this revision. tbaeder added reviewers: NoQ, aaron.ballman, krememek, dergachev.a, MikeStump. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When a declaration has a cleanup function att

[PATCH] D145965: [C++20][Modules] Fix incorrect visibilities in implementation units.

iains updated this revision to Diff 529852. iains marked 2 inline comments as done. iains added a comment. rebased and adjusted for upstream changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145965/new/ https://reviews.llvm.org/D145965 Files:

[PATCH] D143587: [Docs] Multilib design

phosek accepted this revision. phosek added a comment. LGTM Comment at: clang/docs/Multilib.rst:231 + +However, an exception is the normalization of -march. +-march for Arm architectures contains a list of enabled and disabled extensions Use backticks to render

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

t.p.northover added a comment. I don't think this handles the no-personality case properly. For example this code leads to a DWARF entry now: void bar(int *) noexcept; void foo() { int arr; bar(&arr); } Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D145965: [C++20][Modules] Fix incorrect visibilities in implementation units.

iains added a comment. about the comments that the patch seems to do multiple things; I do not think we can fix the lookup without touching the typo-fixes since it uses the same underlying machinery - if we do not adjust the typo fixes, we will regress diagnostics. Repository: rG LLVM Gith

[clang] dcbbdbe - [NFC] remove duplciated unittests for modules

Author: Chuanqi Xu Date: 2023-06-09T17:19:32+08:00 New Revision: dcbbdbe3e50214b550383510ba05d059dc38496a URL: https://github.com/llvm/llvm-project/commit/dcbbdbe3e50214b550383510ba05d059dc38496a DIFF: https://github.com/llvm/llvm-project/commit/dcbbdbe3e50214b550383510ba05d059dc38496a.diff LO

[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

vikramRH updated this revision to Diff 529865. vikramRH added a comment. Handled last set of review comments from @arsenm, would be willing to handle any new findings/concerns via additional patches Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150

[clang] 8b0ea48 - [Clang][CUDA] Disable diagnostics for neon attrs for GPU-side CUDA compilation

Author: Alexander Shaposhnikov Date: 2023-06-09T09:27:01Z New Revision: 8b0ea48740935d819618d8254fc45d98179b672c URL: https://github.com/llvm/llvm-project/commit/8b0ea48740935d819618d8254fc45d98179b672c DIFF: https://github.com/llvm/llvm-project/commit/8b0ea48740935d819618d8254fc45d98179b672c.d

[PATCH] D152403: [Clang][CUDA] Disable diagnostics for neon attrs for GPU-side CUDA compilation

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b0ea4874093: [Clang][CUDA] Disable diagnostics for neon attrs for GPU-side CUDA compilation (authored by alexander-shaposhnikov). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

tbaeder added inline comments. Comment at: clang/lib/CodeGen/CGExpr.cpp:2852 - "Should not use decl without marking it used!"); - if (ND->hasAttr()) { Question for other reviewers: If we want to keep this assertion, would it instead make sense to mark

[PATCH] D149437: [clangd] Emit ChangeAnnotation label and description for include-cleaner diagnostics.

kadircet added a comment. thanks, mostly LG. I think we need to be a little careful when generating insertions for all the missing includes though. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:169 -std::vector generateMissingIncludeDiagnostics( +using MissingInclu

[PATCH] D152436: [clang][analyzer] Move checker alpha.unix.StdCLibraryFunctions out of alpha.

Szelethus added a comment. > I am not sure about the exact requirements, this review can be a place for > discussion about what should be fixed (if any). D52984 added the "Making your checker better" section to the dev manual: https://clang-analyzer.llvm.org/c

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

Michael137 added a comment. Looks like the latest reland of this patch broke some debug-info `cross-project-tests` on the Arm64 macOS buildbots: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-as/263/execution/node/54/log/ Failed Tests (2): cross-project-tests :: debuginfo-tests

[PATCH] D151730: [RISCV] Support target attribute for function

BeMg updated this revision to Diff 529906. BeMg added a comment. 1. Update testcase 2. Remove supportsMultiVersioning for RISCV Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151730/new/ https://reviews.llvm.org/D151730 Files: clang/lib/Basic/Tar

[PATCH] D152436: [clang][analyzer] Move checker alpha.unix.StdCLibraryFunctions out of alpha.

steakhal added a comment. In D152436#4405558 , @balazske wrote: > These are reports that could be improved: > link >

[PATCH] D152520: [clangd] Unify printing policy for type hints

zyounan created this revision. zyounan added a reviewer: nridge. Herald added subscribers: kadircet, arphaman. Herald added a project: All. zyounan published this revision for review. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. (This pa

[PATCH] D152522: [NFC][SetVector] Update some usages of SetVector to SmallSetVector

0xdc03 created this revision. 0xdc03 added a reviewer: nikic. Herald added subscribers: ChuanqiXu, StephenFan, haicheng, hiraditya, MatzeB. Herald added a project: All. 0xdc03 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits.

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

aaron.ballman added a comment. In D150226#4404808 , @rupprecht wrote: > I suppose including this warning in `ShowInSystemHeader` with your diff above > would be a good first step anyway, right? If we're about to make it a hard > error anyway, then makin

[PATCH] D150910: [libclang] Add CXBinaryOperatorKind and CXUnaryOperatorKind (implements 29138)

aaron.ballman added a comment. In D150910#4406296 , @MineGame159 wrote: > I have added the new functions into the file and now it successfully compiles > the test. (but fails when running it - EDIT: guess I broke my dev env somehow) > > Also checked and

[PATCH] D152525: [clang][Diagnostics] Don't expand label fixit to the next line

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, cjdb. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Now that we print >1 line of code snippet, we printed another line of code

[PATCH] D151197: [Clang][SVE2p1] Add svpsel builtins

hassnaa-arm added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:9633-9635 +bool IsSVCount = isa(Ops[0]->getType()); +assert(((!IsSVCount || cast(Ops[0]->getType())->getName() == + "aarch64.svcount")) && hassnaa

[clang] f1aee32 - [HIP] Instruct lld to go through all archives

Author: Siu Chi Chan Date: 2023-06-09T08:50:44-04:00 New Revision: f1aee32f1c85aa476bce70ec110284011c6df354 URL: https://github.com/llvm/llvm-project/commit/f1aee32f1c85aa476bce70ec110284011c6df354 DIFF: https://github.com/llvm/llvm-project/commit/f1aee32f1c85aa476bce70ec110284011c6df354.diff

[PATCH] D152207: [HIP] Instruct lld to go through all archives

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf1aee32f1c85: [HIP] Instruct lld to go through all archives (authored by scchan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150910: [libclang] Add CXBinaryOperatorKind and CXUnaryOperatorKind (implements 29138)

MineGame159 updated this revision to Diff 529938. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150910/new/ https://reviews.llvm.org/D150910 Files: clang/docs/ReleaseNotes.rst clang/include/clang-c/Index.h clang/include/clang/AST/OperationKinds.def clang/tools/libclang/CIndex.cpp

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

erichkeane added a comment. In D150226#4408381 , @aaron.ballman wrote: > In D150226#4404808 , @rupprecht > wrote: > >> I suppose including this warning in `ShowInSystemHeader` with your diff >> above would be a

[PATCH] D150910: [libclang] Add CXBinaryOperatorKind and CXUnaryOperatorKind (implements 29138)

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Do you need me to commit on your behalf? If so, what name and email address would you like me to use for patch attribution? CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

sebastian-ne added inline comments. Comment at: cmake/Modules/GetClangResourceDir.cmake:15 + else() +string(REGEX MATCH "^[0-9]+" CLANG_VERSION_MAJOR ${PACKAGE_VERSION}) +set(ret_dir lib${LLVM_LIBDIR_SUFFIX}/clang/${CLANG_VERSION_MAJOR}) This fails in ou

[clang] 644917b - Remove unnecessary metadata check in test

Author: Akira Hatanaka Date: 2023-06-09T06:41:22-07:00 New Revision: 644917bb7c05d330b3dfa75ccd50414f9b9cd8ee URL: https://github.com/llvm/llvm-project/commit/644917bb7c05d330b3dfa75ccd50414f9b9cd8ee DIFF: https://github.com/llvm/llvm-project/commit/644917bb7c05d330b3dfa75ccd50414f9b9cd8ee.diff

[PATCH] D150910: [libclang] Add CXBinaryOperatorKind and CXUnaryOperatorKind (implements 29138)

MineGame159 added a comment. In D150910#4408585 , @aaron.ballman wrote: > LGTM! Do you need me to commit on your behalf? If so, what name and email > address would you like me to use for patch attribution? Yeah, this is my first contribution, thanks. M

[clang] 7fbc9de - [libclang] Add CXBinaryOperatorKind and CXUnaryOperatorKind

Author: MineGame159 Date: 2023-06-09T10:01:43-04:00 New Revision: 7fbc9de4553666a189b0529ca04e1d9966c0d4f8 URL: https://github.com/llvm/llvm-project/commit/7fbc9de4553666a189b0529ca04e1d9966c0d4f8 DIFF: https://github.com/llvm/llvm-project/commit/7fbc9de4553666a189b0529ca04e1d9966c0d4f8.diff L

[PATCH] D150910: [libclang] Add CXBinaryOperatorKind and CXUnaryOperatorKind (implements 29138)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7fbc9de45536: [libclang] Add CXBinaryOperatorKind and CXUnaryOperatorKind (authored by MineGame159, committed by aaron.ballman). Repository: rG LL

[PATCH] D150358: [clang][Interp] Remove args from called functions in more cases

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/AST/Interp/functions.cpp:262 +namespace CallWithArgs { + /// This used to call problems during checkPotentialConstantExpression()

[PATCH] D144943: [clang][Interp] Implement bitcasts (WIP)

aaron.ballman added a comment. There's still quite a few unaddressed comments, FWIW. Comment at: clang/lib/AST/Interp/Boolean.h:113 + + void bitcastToMemory(std::byte *Buff) { std::memcpy(Buff, &V, sizeof(V)); } + CHANGES SINCE LAST ACTION https://reviews

[PATCH] D144943: [clang][Interp] Implement bitcasts (WIP)

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. Making it clear that there's more work here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144943/new/ https://reviews.llvm.org/D144943 __

[PATCH] D149133: [clang][Interp] BaseToDerived casts

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149133/new/ https://reviews.llvm.org/D149133 ___ cfe-commits mailing lis

[PATCH] D150661: [clang][Interp] Allow evaluating standalone composite expressions

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but you should change the summary to `Allow evaluating standalone complex expressions` when landing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150661/new/ htt

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo added a comment. In D144999#4407934 , @t.p.northover wrote: > I don't think this handles the no-personality case properly. For example this > code leads to a DWARF entry now: > > void bar(int *) noexcept; > void foo() { > int arr; >

[PATCH] D152436: [clang][analyzer] Move checker alpha.unix.StdCLibraryFunctions out of alpha.

balazske added a comment. In D152436#4408301 , @steakhal wrote: > In D152436#4405558 , @balazske > wrote: > >> These are reports that could be improved: >> link >>

[PATCH] D152542: [clangd] Use include_cleaner spelling strategies in clangd.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo http

[PATCH] D149946: [LoongArch] Define `ual` feature and override `allowsMisalignedMemoryAccesses`

MaskRay added a comment. > [1]: > https://github.com/torvalds/linux/blob/master/arch/loongarch/include/asm/cpu.h#L77 > [2]: > https://github.com/torvalds/linux/blob/master/arch/loongarch/kernel/proc.c#L75 `master` will point to different commits. It'd be better to use a specific commit for fut

[PATCH] D152473: [clang-format] Add test case for issue 63170

paulkirth added a comment. In D152473#4407832 , @owenpan wrote: > Can you add the test to clang/unittests/Format/FormatTest.cpp instead? Please > also include the full diff. See > https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-in

[PATCH] D149946: [LoongArch] Define `ual` feature and override `allowsMisalignedMemoryAccesses`

MaskRay added a comment. I'll make `-munaligned-access` `TargetSpecific` (D151590 ) to report errors for unsupported targets. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149946/new/ https://reviews.llvm.org/D149

[PATCH] D152542: [clangd] Use include_cleaner spelling strategies in clangd.

VitaNuo updated this revision to Diff 529974. VitaNuo added a comment. Remove unrelated formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152542/new/ https://reviews.llvm.org/D152542 Files: clang-tools-extra/clangd/Hover.cpp clang-tool

[PATCH] D144943: [clang][Interp] Implement bitcasts (WIP)

tbaeder added a comment. Yes, FWIW I looked into this again last week and noticed a few unsolved problems as well. I'll post a comment once I consider it ready for actual review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144943/new/ https://reviews.llvm.org/D144943 __

[PATCH] D152525: [clang][Diagnostics] Don't expand label fixit to the next line

tbaeder added a comment. As far as the fixit goes, I guess the previous version was better, since it didn't leave an empty line behind? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152525/new/ https://reviews.llvm.org/D152525 ___

[PATCH] D152522: [NFC][SetVector] Update some usages of SetVector to SmallSetVector

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152522/new/ https://reviews.llvm.org/D152522 ___ c

[PATCH] D150358: [clang][Interp] Remove args from called functions in more cases

tbaeder added a subscriber: MaskRay. tbaeder added inline comments. Comment at: clang/test/AST/Interp/functions.cpp:262 +namespace CallWithArgs { + /// This used to call problems during checkPotentialConstantExpression() runs. + constexpr void g(int a) {} aaro

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

JOE1994 updated this revision to Diff 529976. JOE1994 added a comment. - Update uses of `PointerType::get(Ty)` & `PointerType::getUnqual` to be in overloaded form of `PointerType::get` that takes LLVMContext& - Remove more unnecessary bitcasts which were previously overlooked. - Remove pointee

[PATCH] D152473: [clang-format] Add test case for issue 63170

MyDeveloperDay added a comment. I presume the test fail, we don't check in tests that just fail without a fix, or the build would be stale. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152473/new/ https://reviews.llvm.org/D152473 ___

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

JOE1994 added inline comments. Comment at: clang/lib/CodeGen/CGBuilder.h:172 +auto *PtrTy = llvm::PointerType::get(Ty, Addr.getAddressSpace()); return Address(CreateBitCast(Addr.getPointer(), PtrTy, Name), Ty, Addr.getAlignment(), Addr.isKnownNonNull(

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

dblaikie added a comment. In D150226#4408563 , @erichkeane wrote: > In D150226#4408381 , @aaron.ballman > wrote: > >> In D150226#4404808 , @rupprecht >> wrote: >> >>> I

[PATCH] D152443: Add SpaceAfterOperatorKeyword & SpaceAfterOperatorKeywordInCall style options for clang-format

MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:4709 + +**SpaceAfterOperatorKeyword** (``Boolean``) :versionbadge:`clang-format 17` :ref:`¶ ` + If ``true``, a space will be inserted after the 'operator' keyword. could we

[PATCH] D152443: Add SpaceAfterOperatorKeyword & SpaceAfterOperatorKeywordInCall style options for clang-format

MyDeveloperDay added a comment. In D152443#4407438 , @KitsuneAlex wrote: > I had some issues with Git there because i messed up a merge, so the diff was > bad. Here's the proper diff. > NOTE: Clang-Format Team Automated Review Comment keep you hones

[PATCH] D142388: [clang] Add builtin_nondeterministic_value

ManuelJBrito added inline comments. Comment at: clang/test/CodeGen/builtins-nondeterministic-value.c:26 +// CHECK-LABEL: entry +// CHECK: [[A:%.*]] = alloca double, align 8 +// CHECK: store double [[X:%.*]], ptr [[A]], align 8 zixuan-wu wrote: > hi, @ManuelJBrito

[PATCH] D152447: [Clang] Remove -no-opaque-pointers cc1 flag

dblaikie added subscribers: t.p.northover, dblaikie. dblaikie added a comment. (I hope this doesn't come off as condescending/patronizing, I mean it quite genuinely) A deep thanks to everyone who worked on this, especially @aeubanks and @nikic, and @t.p.northover - it's been a long project and

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

dblaikie added a comment. When we migrated to github we gained higher fidelity for attributing authors (we can now commit on someone's behalf but have the commit author properly recorded as the real author - we couldn't do that back on Subversion) - but I think it's meant that fail-mail from bo

[PATCH] D152547: [clang][NFC] Drop alignment in builtin-nondeterministic-value test

ManuelJBrito created this revision. ManuelJBrito added reviewers: zixuan-wu, erichkeane. Herald added a subscriber: mgrang. Herald added a project: All. ManuelJBrito requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Drop alignment to allow te

[PATCH] D152548: [Clang][Interp] Diagnose uninitialized ctor of global record arrays

hazohelet created this revision. hazohelet added reviewers: aaron.ballman, tbaeder, shafik. Herald added a project: All. hazohelet requested review of this revision. Herald added a project: clang. This patch adds a check for uninitialized subobjects of global variables that are record arrays. e.g

[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. lgtm with nit Comment at: llvm/lib/Transforms/Utils/AMDGPUEmitPrintf.cpp:280 +} else { + auto AllocSize = M->getDataLayout().getTypeAllocSize(Args[i]->getType()); +

[PATCH] D152551: [clang] Remove dead parameter of CGBuilderTy::CreateElementBitCast (NFC)

JOE1994 created this revision. Herald added a project: All. JOE1994 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Remove the 'Name' parameter of `CreateElementBitcast()`, which is unused. Depends on D152321

[clang] 5548843 - [Driver] Mark many target-specific driver-only options as TargetSpecific

Author: Fangrui Song Date: 2023-06-09T09:26:37-07:00 New Revision: 5548843d692a92a7840f14002debc3cebcb3cdc3 URL: https://github.com/llvm/llvm-project/commit/5548843d692a92a7840f14002debc3cebcb3cdc3 DIFF: https://github.com/llvm/llvm-project/commit/5548843d692a92a7840f14002debc3cebcb3cdc3.diff

[PATCH] D152473: [clang-format] Add test case for issue 63170

paulkirth added a comment. The point of this patch was to show a regression. I'm not trying to fix anything per se. I'd like https://reviews.llvm.org/D151954 and anything that depends on it reverted, since it breaks `clang-format`. My understanding was that @owenpan was reluctant to revert sin

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

Michael137 added a comment. In D144999#4408248 , @Michael137 wrote: > Looks like the latest reland of this patch > (`e60b30d5e3878e7d91f8872ec4c4dca00d4a2dfc`) broke some debug-info > `cross-project-tests` on the Arm64 macOS buildbots: > https://green

[PATCH] D152554: [OpenMP] Migrate deviice code privatization from Clang CodeGen to OMPIRBuilder

TIFitis created this revision. TIFitis added reviewers: jsjodin, jdoerfert, kiranktp. Herald added subscribers: sunshaoce, guansong, hiraditya, yaxunl. Herald added a project: All. TIFitis requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jplehr, sstefan1. Hera

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivate[ForVarInit] try ConstExprEmitter fast-path first

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1279 + if (isa(E)) +return nullptr; + This needs a comment explaining why we're bailing out here. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:166

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

barannikov88 added a comment. Please use clang-format on the modified lines. Comment at: clang/lib/CodeGen/CGBuilder.h:170 Address CreateElementBitCast(Address Addr, llvm::Type *Ty, const llvm::Twine &Name = "") { +return Address(Addr.getP

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo added a comment. In D144999#4409149 , @Michael137 wrote: > In D144999#4408248 , @Michael137 > wrote: > >> Looks like the latest reland of this patch >> (`e60b30d5e3878e7d91f8872ec4c4dca00d4a2dfc`) broke

[PATCH] D152554: [OpenMP] Migrate deviice code privatization from Clang CodeGen to OMPIRBuilder

TIFitis added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:7170-7234 +const llvm::Value *DevPtr = nullptr; // In order to identify the right initializer we need to match the // declaration used by the mapping logic. In some cases we may get

[PATCH] D152473: [clang-format] Add test case for issue 63170

paulkirth updated this revision to Diff 52. paulkirth added a comment. Revert patches introducing regression & add unit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152473/new/ https://reviews.llvm.org/D152473 Files: clang/docs/ClangFo

[PATCH] D151587: [clang][ConstantEmitter] have tryEmitPrivate[ForVarInit] try ConstExprEmitter fast-path first

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1279 + if (isa(E)) +return nullptr; + efriedma wrote: > This needs a comment explaining why we're bailing out here. We might need to do a recursive visit still, to handl

[PATCH] D152473: [clang-format] Add test case for issue 63170

paulkirth updated this revision to Diff 530004. paulkirth edited the summary of this revision. paulkirth added reverted changes: rGd2627cf88d25: [clang-format] Add the KeepEmptyLinesAtEOF option, rG4b9764959dc4: [clang-format] Fix overlapping replacements before PPDirectives, D152305: [clang-form

[PATCH] D152561: [AST] Always set dependent-type for the CallExpr for error-recovery in C.

hokein created this revision. hokein added reviewers: aaron.ballman, sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang. When build CallExpr for error-recovery where we have any dependent child nodes), we should set a dependent type for

[PATCH] D149872: [OpenMP][OMPIRBuilder] Migrate emitOffloadingArrays and EmitNonContiguousDescriptor from Clang

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. If this passes all our tests, it looks fine. A few nits below, try to address if possible. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:4427 + M.getConte

[PATCH] D146557: [MLIR][OpenMP] Refactoring createTargetData in OMPIRBuilder

jdoerfert added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:1365 + // possible, or else at the end of the function. + void EmitBlock(BasicBlock *BB, Function *CurFn, bool IsFinished = false); + why are these capitalized?

[PATCH] D149548: [IR] Update to use new shufflevector semantics

ManuelJBrito added a comment. In D149548#4405173 , @qiucf wrote: > Why this changes IR output of following case? > > // RUN: clang vecpromote.c -S -o - -O0 -target s390x-linux-gnu -fzvector > -emit-llvm > #include > > vector int si; > int g;

[PATCH] D152561: [AST] Always set dependent-type for the CallExpr for error-recovery in C.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, though please add a release note about the fix. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152561/new/ https:/

[PATCH] D152412: [clang/test/CodeGen] Add test coverage for VarBypassDetector handling init statements and condition variables in switch clauses

dwang added a comment. @vitalybuka Thanks for the quick review! I need help landing this since I do not have commit permission. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152412/new/ https://reviews.llvm.org/D152412 ___

[PATCH] D142630: [clang][Interp] Implement virtual function calls

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:1560 + // is the furthest we might go up in the hierarchy. + ThisPtr = ThisPtr.getDeclPtr(); +} tbaeder wrote: > I think this test case was from the function pointer revi

[PATCH] D152443: Add SpaceAfterOperatorKeyword & SpaceAfterOperatorKeywordInCall style options for clang-format

HazardyKnusperkeks added a comment. In D152443#4407331 , @KitsuneAlex wrote: > Applied all suggested changes and added a suiting option for aformentioned > edge-case for call expressions. > Also added the missing release notes to the apropriate section.

[clang] b03abbb - [clang/test/CodeGen] Add test coverage for VarBypassDetector handling init statements and condition variables in switch clauses

Author: Wang Date: 2023-06-09T11:28:14-07:00 New Revision: b03abbb537e5403ab32f97e2ffcebafe4a92720d URL: https://github.com/llvm/llvm-project/commit/b03abbb537e5403ab32f97e2ffcebafe4a92720d DIFF: https://github.com/llvm/llvm-project/commit/b03abbb537e5403ab32f97e2ffcebafe4a92720d.diff LOG: [cl

[PATCH] D152412: [clang/test/CodeGen] Add test coverage for VarBypassDetector handling init statements and condition variables in switch clauses

This revision was automatically updated to reflect the committed changes. Closed by commit rGb03abbb537e5: [clang/test/CodeGen] Add test coverage for VarBypassDetector handling init… (authored by dwang, committed by vitalybuka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

aaron.ballman added subscribers: beanz, clang-vendors. aaron.ballman added a comment. In D151683#4384017 , @erichkeane wrote: > In D151683#4382408 , @philnik wrote: > >> No. I guess, since you are asking I should

[PATCH] D152473: [clang-format] Add test case for issue 63170

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152473/new/ https://reviews.llvm.org/D152473 ___

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

oontvoo added a comment. P.S This might have the same root-cause with the previous comment and could be fixed by D152540 as well. (not able to repro the failures yet - don't have arm64 readily available, will test it later this evening. but on linux x86-64 and

[PATCH] D152351: [clang] Add __builtin_isfpclass

sepavloff updated this revision to Diff 530041. sepavloff added a comment. Updated patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152351/new/ https://reviews.llvm.org/D152351 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNote

[PATCH] D151834: Include math-errno with fast-math

zahiraam updated this revision to Diff 530040. zahiraam marked 5 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151834/new/ https://reviews.llvm.org/D151834 Files: clang/include/clang/Basic/FPOptions.def clang/include/clang/Basic/LangOptions.h clang/lib/Code

[PATCH] D151834: Include math-errno with fast-math

zahiraam added inline comments. Comment at: clang/include/clang/Basic/FPOptions.def:30 OPTION(BFloat16ExcessPrecision, LangOptions::ExcessPrecisionKind, 2, FPEvalMethod) +OPTION(MathErrno, bool, 1, BFloat16ExcessPrecision) #undef OPTION andrew.w.kaylor wrote:

[PATCH] D152351: [clang] Add __builtin_isfpclass

arsenm added a comment. Typo builting in commit message Comment at: clang/docs/LanguageExtensions.rst:3418 + +This function never raises floating-point exceptions. + Maybe also mention it doesn't canonicalize its input Comment at: clang/test/

[PATCH] D152351: [clang] Add __builtin_isfpclass

sepavloff marked 8 inline comments as done. sepavloff added a comment. In D152351#4403904 , @aaron.ballman wrote: > In D152351#4402785 , @arsenm wrote: > >> Also should get mentioned in the builtin docs and relea

[PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

beanz added inline comments. Comment at: clang/test/ParserHLSL/group_shared.hlsl:14 -// expected-error@+1 {{expected expression}} float groupshared [[]] i = 12; aaron.ballman wrote: > philnik wrote: > > Should this also get an extension warning/should attribut

[PATCH] D152561: [AST] Always set dependent-type for the CallExpr for error-recovery in C.

shafik accepted this revision. shafik added a comment. Thank you for the quick fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152561/new/ https://reviews.llvm.org/D152561 ___ cfe-commits mailing list

[PATCH] D152351: [clang] Add __builtin_isfpclass

aaron.ballman added a comment. In D152351#4409725 , @sepavloff wrote: > In D152351#4403904 , @aaron.ballman > wrote: > >> In D152351#4402785 , @arsenm wrote: >> >>> Also

[PATCH] D152351: [clang] Add __builtin_isfpclass

arsenm added inline comments. Comment at: clang/test/CodeGen/isfpclass.c:2 +// RUN: %clang_cc1 -triple x86_64-linux-gnu -S -O1 -emit-llvm %s -o - | FileCheck %s + +_Bool check_isfpclass_finite(float x) { sepavloff wrote: > arsenm wrote: > > Can you also add a h

[PATCH] D152570: [clang] Fix file mapping template arguments

dankm created this revision. Herald added a project: All. dankm added a comment. dankm updated this revision to Diff 530046. dankm published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. I still need to make a unit test for this. Should be more-or

[PATCH] D128059: [Clang] Add a warning on invalid UTF-8 in comments.

tahonermann added a comment. @cor3ntin, sorry for failing to keep up with reviews; I know this has already been committed. I did spot a couple of typos should you feel inclined to address them. Comment at: clang/lib/Lex/Lexer.cpp:2695 + // diagnostic only once per entire ill

[PATCH] D151683: [clang] Enable C++11-style attributes in all language modes

philnik added inline comments. Comment at: clang/test/Parser/cxx-decl.cpp:316 #if __cplusplus >= 201103L -// expected-error@+3 {{expected}} +// expected-error@+2 {{expected}} // expected-error@-3 {{expected ';' after top level declarator}} aaron.ballman wrote:

  1   2   >