[PATCH] D151867: [Clang][RISCV] Make generic clz/ctz builtins defined for zero on RISCV targets.

Yunzezhu created this revision. Yunzezhu added reviewers: asb, craig.topper, kito-cheng. Yunzezhu added a project: clang. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult,

[PATCH] D150253: [RISCV] Add Zvfhmin extension for clang.

jacquesguan updated this revision to Diff 527312. jacquesguan added a comment. Update dependency. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150253/new/ https://reviews.llvm.org/D150253 Files: clang/include/clang/Basic/riscv_vector.td clang

[PATCH] D151720: [clang][ExprConstant] Fix display of syntactically-invalid note for member function calls

tbaeder added a comment. The only additional test I could come up with is one where the `->` is in the middle of an lvalue designator, like: struct A { constexpr int foo() { (void)(1/0); return 1;} }; struct B { A aa; A *a = &aa; }; struct C { B b; }; struc

[PATCH] D146023: [AMDGPU] Remove Code Object V2

Pierre-vh added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146023/new/ https://reviews.llvm.org/D146023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo updated this revision to Diff 527314. VitaNuo marked 5 inline comments as done. VitaNuo added a comment. Herald added a subscriber: ormris. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150185/new/ https://reviews.l

[clang] 4f0436d - [clang][analyzer] Merge apiModeling.StdCLibraryFunctions and StdCLibraryFunctionArgs checkers into one.

Author: Balázs Kéri Date: 2023-06-01T09:54:35+02:00 New Revision: 4f0436dd1532d7534d77e6fc211a7a50bbdd0c49 URL: https://github.com/llvm/llvm-project/commit/4f0436dd1532d7534d77e6fc211a7a50bbdd0c49 DIFF: https://github.com/llvm/llvm-project/commit/4f0436dd1532d7534d77e6fc211a7a50bbdd0c49.diff L

[PATCH] D151225: [clang][analyzer] Merge apiModeling.StdCLibraryFunctions and StdCLibraryFunctionArgs checkers into one.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4f0436dd1532: [clang][analyzer] Merge apiModeling.StdCLibraryFunctions and… (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151225/new/

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

hokein added a comment. The only thing is the source location, see my comments for details, otherwise looks good in general. Comment at: clang-tools-extra/clang-tidy/misc/IncludeCleanerCheck.cpp:116 + } + walkUsed(MainFileDecls, RecordedPreprocessor.MacroReferences, &Recorde

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 527317. VitaNuo added a comment. Update release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://reviews.llvm.org/D148793 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt cla

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo added inline comments. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Analysis.h:88 +class IncludeSpeller { +public: hokein wrote: > hokein wrote: > > I think this is an important API (we will create a subclass for our > >

[clang] 710749f - [clang][Interp] Optionally cast comparison result to non-bool

Author: Timm Bäder Date: 2023-06-01T10:36:33+02:00 New Revision: 710749f78695b0e00026e5ff7c9f94e08e7b482a URL: https://github.com/llvm/llvm-project/commit/710749f78695b0e00026e5ff7c9f94e08e7b482a DIFF: https://github.com/llvm/llvm-project/commit/710749f78695b0e00026e5ff7c9f94e08e7b482a.diff LO

[PATCH] D151869: [RISCV] Support more builtin for zvfhmin.

jacquesguan created this revision. jacquesguan added reviewers: craig.topper, asb, luismarques, frasercrmck, michaelmaitland. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfe

[PATCH] D150670: [InstCombine] Disable generation of fshl/fshr for rotates

pmatos updated this revision to Diff 527326. pmatos added a comment. Simplify code according to @nikic suggestion. Add tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150670/new/ https://reviews.llvm.org/D150670 Files: llvm/lib/Transforms/I

[PATCH] D150670: [InstCombine] Disable generation of fshl/fshr for rotates

pmatos added a comment. In D150670#4383823 , @nikic wrote: > Can you please drop all wasm related tests and instead add an InstCombine > test for the fsh+and pattern? > > It would also be good to have a test where we can fold one side to a > constant, b

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 527329. VitaNuo marked 6 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://reviews.llvm.org/D148793 Files: clang-too

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

VitaNuo added a comment. Thanks for the comments! Comment at: clang-tools-extra/clang-tidy/misc/IncludeCleanerCheck.cpp:88 +SourceLocation Loc = D->getLocation(); +if (!SM->isWrittenInMainFile(SM->getSpellingLoc(Loc))) + continue; hokein wrote: > V

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo updated this revision to Diff 527330. VitaNuo added a comment. Update test name. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150185/new/ https://reviews.llvm.org/D150185 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/cla

[PATCH] D142630: [clang][Interp] Implement virtual function calls

tbaeder updated this revision to Diff 527331. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142630/new/ https://reviews.llvm.org/D142630 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Context.cpp clang/lib/AST/Interp/Context.h clang/lib/AST/Interp/Descriptor

[PATCH] D142630: [clang][Interp] Implement virtual function calls

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:1560 + // is the furthest we might go up in the hierarchy. + ThisPtr = ThisPtr.getDeclPtr(); +} tbaeder wrote: > Just so I don't forget: The assignment to `ThisPtr` here is dea

[PATCH] D142630: [clang][Interp] Implement virtual function calls

tbaeder updated this revision to Diff 527336. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142630/new/ https://reviews.llvm.org/D142630 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Context.cpp clang/lib/AST/Interp/Context.h clang/lib/AST/Interp/Descriptor

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

akshaykhadse updated this revision to Diff 527345. akshaykhadse added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add CFE tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151863/new/ https://reviews.llvm.org

[PATCH] D144164: [clang][Interp] Handle PtrMemOps

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Context.cpp:122 + T->isFunctionProtoType() || + T->isSpecificBuiltinType(BuiltinType::BoundMember)) +return PT_FnPtr; aaron.ballman wrote: > Do you have test coverage for the bound memb

[PATCH] D144164: [clang][Interp] Handle PtrMemOps

tbaeder updated this revision to Diff 527346. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144164/new/ https://reviews.llvm.org/D144164 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Context.cpp clang/lib/AST/Interp/Interp.h clang/test/AST/Interp/literals.c

[PATCH] D144457: [clang][Interp] Handle global composite temporaries

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Pointer.cpp:10 #include "Pointer.h" +#include "Boolean.h" +#include "Context.h" shafik wrote: > Are all these headers really needed for the change below? We access `.toAPValue()` on all of them in t

[PATCH] D151730: [RISCV] Support target attribute for function

kito-cheng added a comment. Testcase for backend? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151730/new/ https://reviews.llvm.org/D151730 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[clang] 453e02c - [OpenMP] Add support for declare target initializer expressions

Author: Ritanya B Bharadwaj Date: 2023-06-01T05:27:23-05:00 New Revision: 453e02ca0903c9f65529d21c513925ab0fdea1e1 URL: https://github.com/llvm/llvm-project/commit/453e02ca0903c9f65529d21c513925ab0fdea1e1 DIFF: https://github.com/llvm/llvm-project/commit/453e02ca0903c9f65529d21c513925ab0fdea1e1

[PATCH] D146418: Support for OpenMP 5.0 sec 2.12.7 - Declare Target initializer expressions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG453e02ca0903: [OpenMP] Add support for declare target initializer expressions (authored by RitanyaB, committed by Sandeep Kosuri

[PATCH] D151876: [NVPTX] Signed char and (unsigned)long overloads of ldg and ldu

jchlanda created this revision. jchlanda added a reviewer: tra. Herald added subscribers: mattd, gchakrabarti, asavonic. Herald added a project: All. jchlanda requested review of this revision. Herald added subscribers: cfe-commits, jholewinski. Herald added a project: clang. This is a follow up t

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

skatrak updated this revision to Diff 527354. skatrak added a comment. Rebase and address reviewer's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147218/new/ https://reviews.llvm.org/D147218 Files: flang/include/flang/Lower/OpenMP.h

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks, just a few nits. I think it is in a good shape, let's ship it! Please make sure the premerge-test is happy before landing the patch, the windows premerge test is failing now (https://

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

skatrak marked 2 inline comments as done. skatrak added a comment. Thank you for the comments, they should have all been addressed now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147218/new/ https://reviews.llvm.org/D147218

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 527359. VitaNuo added a comment. Try to fix windows test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://reviews.llvm.org/D148793 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt

[clang] a26bd95 - [LinkerWrapper] Fix static library symbol resolution

Author: Joseph Huber Date: 2023-06-01T06:51:51-05:00 New Revision: a26bd95325f120d9737a0b03c80eabddb56f46db URL: https://github.com/llvm/llvm-project/commit/a26bd95325f120d9737a0b03c80eabddb56f46db DIFF: https://github.com/llvm/llvm-project/commit/a26bd95325f120d9737a0b03c80eabddb56f46db.diff

[PATCH] D151839: [LinkerWrapper] Fix static library symbol resolution

This revision was automatically updated to reflect the committed changes. Closed by commit rGa26bd95325f1: [LinkerWrapper] Fix static library symbol resolution (authored by jhuber6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151839/new/ https://

[PATCH] D151720: [clang][ExprConstant] Fix display of syntactically-invalid note for member function calls

hazohelet updated this revision to Diff 527363. hazohelet added a comment. Address comments from @tbaeder - Add new suggested test case - NFC stylistic changes in test cases CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151720/new/ https://reviews.llvm.org/D151720 Files: clang/docs/

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 527369. VitaNuo marked an inline comment as done. VitaNuo added a comment. Remove system-independent handling to see behavior on Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://review

[PATCH] D151720: [clang][ExprConstant] Fix display of syntactically-invalid note for member function calls

hazohelet marked 5 inline comments as done. hazohelet added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:1931 + else + Out << "."; +} else if (const auto *OCE = tbaeder wrote: > Did you `clang-format` these changes? The two if/els

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

hokein added a comment. thanks, left some comments per our offline discussion. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Analysis.h:104 +/// order is not specified. +std::function defaultHeaderMapper(); + VitaNuo wrote: > hoke

[clang] fca2109 - [clang][NFC] Make HeaderSearch::suggestPathToFileForDiagnostics method const.

Author: Haojian Wu Date: 2023-06-01T14:42:16+02:00 New Revision: fca2109047964ea884fcd86efe24bc4c4bfb940e URL: https://github.com/llvm/llvm-project/commit/fca2109047964ea884fcd86efe24bc4c4bfb940e DIFF: https://github.com/llvm/llvm-project/commit/fca2109047964ea884fcd86efe24bc4c4bfb940e.diff LO

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 527376. VitaNuo marked an inline comment as done. VitaNuo added a comment. Remove the regular expression. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://reviews.llvm.org/D148793 Files: cla

[PATCH] D147217: [OpenMP][OMPIRBuilder] OpenMPIRBuilder support for requires directive

skatrak updated this revision to Diff 527380. skatrak added a comment. Update with latest main branch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147217/new/ https://reviews.llvm.org/D147217 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clan

[clang-tools-extra] b3e38a1 - [clangd] NFC, remove an unused member in

Author: Haojian Wu Date: 2023-06-01T14:53:33+02:00 New Revision: b3e38a174373618ceef07b1b9b327408c7d132e2 URL: https://github.com/llvm/llvm-project/commit/b3e38a174373618ceef07b1b9b327408c7d132e2 DIFF: https://github.com/llvm/llvm-project/commit/b3e38a174373618ceef07b1b9b327408c7d132e2.diff LO

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

cseo added a comment. In D144654#4381893 , @nickdesaulniers wrote: > In D144654#4380488 , @john.brawn > wrote: > >> gcc has the same warning so I wasn't expecting this cause to change >> problems, but looking m

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

ABataev added inline comments. Comment at: clang/include/clang/Sema/Sema.h:11083 + bool CheckLastPrivateForMappedDirectives(ArrayRef Clauses); + `checkLastPrivateForMappedDirectives` Comment at: clang/lib/AST/StmtPrinter.cpp:745-746 + OpenM

[PATCH] D140690: [compiler-rt][dfsan] Enable loongarch64 and add test support

tangyouling added a comment. The patch will continue to be updated by @Ami-zhang Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140690/new/ https://reviews.llvm.org/D140690 ___ cfe-commits mailing list cf

[PATCH] D151837: [Clang][Parser] Accept GNU attributes preceding C++ style attributes on templates

eandrews updated this revision to Diff 527382. eandrews added a comment. Thanks for the review! I added a couple more tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151837/new/ https://reviews.llvm.org/D151837 Files: clang/lib/Parse/ParseTemplate.cpp clang/test/Parser/attr-or

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 527384. VitaNuo marked an inline comment as done. VitaNuo added a comment. Remove regex and path handling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://reviews.llvm.org/D148793 Files: cl

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 527385. VitaNuo added a comment. Remove regex and path handling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://reviews.llvm.org/D148793 Files: clang-tools-extra/clang-tidy/misc/CMakeLists

[PATCH] D151088: [flang][hlfir] Separate -emit-fir and -emit-hlfir for flang-new

tblah updated this revision to Diff 527386. tblah added a comment. Thanks again for review! Now there are two actions: - EmitFIR - EmitHLFIR EmitHLFIR will assert that lowering was set up to emit HLFIR. EmitFIR will use the HLFIR to FIR pipeline if lowering was set up to emit HLFIR. Repositor

[clang] 2ccb074 - [clang] NFC, make more HeaderSearch methods const.

Author: Haojian Wu Date: 2023-06-01T15:08:55+02:00 New Revision: 2ccb07452d8e1e62c545db2f6faad2bd794572be URL: https://github.com/llvm/llvm-project/commit/2ccb07452d8e1e62c545db2f6faad2bd794572be DIFF: https://github.com/llvm/llvm-project/commit/2ccb07452d8e1e62c545db2f6faad2bd794572be.diff LO

[PATCH] D150803: [WebAssembly] Add a new `wasm_async` clang attribute for marking async functions.

erichkeane added a comment. Couple of CFE comments, otherwise LGTM. Comment at: clang/docs/ReleaseNotes.rst:559 ^^^ +- Added ``attribute((wasm_async))`` to indicate that a function should be used with + JavaScript Promise Integration (JSPI).

[PATCH] D150670: [InstCombine] Disable generation of fshl/fshr for rotates

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM, let's give it a try. The patch description needs an update though. Comment at: llvm/lib/Transforms/InstCombine/InstCombineSimplifyDemanded.cpp:920 +return I;

[clang] 3ddd186 - [Tooling] NFC, use const HeaderSearch for isSelfContainedHeader.

Author: Haojian Wu Date: 2023-06-01T15:17:21+02:00 New Revision: 3ddd18640af186bd46cb36064cf3bbe00b4b5a52 URL: https://github.com/llvm/llvm-project/commit/3ddd18640af186bd46cb36064cf3bbe00b4b5a52 DIFF: https://github.com/llvm/llvm-project/commit/3ddd18640af186bd46cb36064cf3bbe00b4b5a52.diff LO

[PATCH] D151088: [flang][hlfir] Separate -emit-fir and -emit-hlfir for flang-new

awarzynski accepted this revision. awarzynski added a comment. Thanks for the updates, LGTM! Comment at: flang/test/HLFIR/flang-experimental-hlfir-flag.f90:7-12 +! | Action | -flang-experimental-hlfir? | Result | +! | === | ===

[PATCH] D151837: [Clang][Parser] Accept GNU attributes preceding C++ style attributes on templates

erichkeane added a comment. This needs a release note, otherwise LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151837/new/ https://reviews.llvm.org/D151837 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 527392. VitaNuo marked an inline comment as done. VitaNuo added a comment. Add debug statements for windows debugging. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://reviews.llvm.org/D148793

[clang-tools-extra] 7de5412 - [include-cleaner] NFC, use const HeaderSearch when possible.

Author: Haojian Wu Date: 2023-06-01T15:26:19+02:00 New Revision: 7de541235f24e53af95d481df2bf8b15f6656ad3 URL: https://github.com/llvm/llvm-project/commit/7de541235f24e53af95d481df2bf8b15f6656ad3 DIFF: https://github.com/llvm/llvm-project/commit/7de541235f24e53af95d481df2bf8b15f6656ad3.diff LO

[PATCH] D150670: [InstCombine] Disable generation of fshl/fshr for rotates

This revision was automatically updated to reflect the committed changes. Closed by commit rG9485d983ac0c: [InstCombine] Disable generation of fshl/fshr for rotates (authored by pmatos). Changed prior to commit: https://reviews.llvm.org/D150670?vs=527326&id=527395#toc Repository: rG LLVM Git

[PATCH] D150670: [InstCombine] Disable generation of fshl/fshr for rotates

pmatos added a comment. Landed, thanks for your patience. Lets hope it sticks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150670/new/ https://reviews.llvm.org/D150670 ___ cfe-commits mailing list cfe-

[PATCH] D151595: [BOLT][CMake] Redo the build and install targets

Amir added a comment. Merged the PR. Please reland Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151595/new/ https://reviews.llvm.org/D151595 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[clang-tools-extra] ad0543f - [clangd] NFC, use const HeaderSearch when possible.

Author: Haojian Wu Date: 2023-06-01T15:35:57+02:00 New Revision: ad0543f4ea82ec41c5e854af65758fa8d92d5553 URL: https://github.com/llvm/llvm-project/commit/ad0543f4ea82ec41c5e854af65758fa8d92d5553 DIFF: https://github.com/llvm/llvm-project/commit/ad0543f4ea82ec41c5e854af65758fa8d92d5553.diff LO

[PATCH] D150221: Add option -fkeep-static-variables to emit all static variables

erichkeane added a comment. This seems a little short on tests as well, are there any semantic implications here that should be validated? How does this work with function-local statics? What does the behavior look like in C? Else, I think @rjmccall felt the strongest about the semantics/desi

[clang] d4f0f17 - [z/OS] Disable pr59765-modules-global-ctor-dtor.cppm on z/OS to make it unsupported.

Author: Zibi Sarbinowski Date: 2023-06-01T08:44:30-05:00 New Revision: d4f0f171d7f890abe913023e4439018fd74aa175 URL: https://github.com/llvm/llvm-project/commit/d4f0f171d7f890abe913023e4439018fd74aa175 DIFF: https://github.com/llvm/llvm-project/commit/d4f0f171d7f890abe913023e4439018fd74aa175.di

[PATCH] D151828: [z/OS] Disable pr59765-modules-global-ctor-dtor.cppm on z/OS to make it unsupported.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd4f0f171d7f8: [z/OS] Disable pr59765-modules-global-ctor-dtor.cppm on z/OS to make it… (authored by zibi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1518

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 527402. VitaNuo added a comment. Remove debug statements. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://reviews.llvm.org/D148793 Files: clang-tools-extra/clang-tidy/misc/CMakeLists.txt

[PATCH] D149867: [M68k] Add Clang support for the new M68k_RTD CC

glaubitz added a comment. In D149867#4386271 , @jrtc27 wrote: > I disagree. Being experimental doesn't mean you should do the wrong thing. > Reusing stdcall in the frontend is ugly, pollutes non-m68k code paths (doing > your own thing _avoids_ that and

[PATCH] D151837: [Clang][Parser] Accept GNU attributes preceding C++ style attributes on templates

eandrews updated this revision to Diff 527406. eandrews added a comment. Thanks for the review! I've added a release note. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151837/new/ https://reviews.llvm.org/D151837 Files: clang/docs/ReleaseNotes.rst clang/lib/Parse/ParseTemplate.cpp

[PATCH] D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang

fahadnayyar updated this revision to Diff 527407. fahadnayyar added a comment. Rebasing to latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148266/new/ https://reviews.llvm.org/D148266 Files: clang/lib/Driver/ToolChains/Darwin.cpp cl

[PATCH] D150746: [CodeGen]Translating pointer arguments can require an address space cast

yaxunl added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:1630-1632 +LangAS AS = CGM.GetGlobalVarAddressSpace(nullptr); +QualType Q = Context.getAddrSpaceQualType(Context.VoidPtrTy, AS); +QualType T = Context.getPointerType(Q); Doe

[PATCH] D151837: [Clang][Parser] Accept GNU attributes preceding C++ style attributes on templates

erichkeane accepted this revision. erichkeane added a comment. 1 suggestion, otherwise LGTM. Comment at: clang/docs/ReleaseNotes.rst:416 + handled, resulting in compilation error. This has been corrected to match the + behaviour exhibited by GCC. CHANGES

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo updated this revision to Diff 527412. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150185/new/ https://reviews.llvm.org/D150185 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-ex

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo marked 4 inline comments as done. VitaNuo added a comment. Thanks for the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150185/new/ https://reviews.llvm.org/D150185 ___ cfe-commits mail

[PATCH] D150988: [clang][Darwin] Error out when missing requested libarclite library

fahadnayyar accepted this revision. fahadnayyar added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150988/new/ https://reviews.llvm.org/D150988 _

[PATCH] D151595: [BOLT][CMake] Redo the build and install targets

This revision was automatically updated to reflect the committed changes. Closed by commit rGf3269a94e729: [BOLT][CMake] Redo the build and install targets (authored by phosek). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151595/new/ https://revie

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo updated this revision to Diff 527420. VitaNuo added a comment. Remove extra path handling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150185/new/ https://reviews.llvm.org/D150185 Files: clang-tools-extra/clangd/Hover.cpp clang-tools

[clang] 2c3c190 - [Clang] Convert some tests to opaque pointers (NFC)

Author: Nikita Popov Date: 2023-06-01T17:04:48+02:00 New Revision: 2c3c1902a347a2a6d681e8dbe410a2dfe78389bb URL: https://github.com/llvm/llvm-project/commit/2c3c1902a347a2a6d681e8dbe410a2dfe78389bb DIFF: https://github.com/llvm/llvm-project/commit/2c3c1902a347a2a6d681e8dbe410a2dfe78389bb.diff

[PATCH] D150860: [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder

jplehr added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:10412 + CGF.Builder.GetInsertPoint()); + llvm::OpenMPIRBuilder::LocationDescription ompLoc(CodeGenIP); capitalize here? Comment at: clan

[clang] 5952664 - [OpenCL] Add CLK_UNORM_INT_101010_2 channel type

Author: Sven van Haastregt Date: 2023-06-01T16:21:54+01:00 New Revision: 595266456a3067f522081d6d8069df2a98adfa16 URL: https://github.com/llvm/llvm-project/commit/595266456a3067f522081d6d8069df2a98adfa16 DIFF: https://github.com/llvm/llvm-project/commit/595266456a3067f522081d6d8069df2a98adfa16.

[PATCH] D151837: [Clang][Parser] Accept GNU attributes preceding C++ style attributes on templates

eandrews added inline comments. Comment at: clang/docs/ReleaseNotes.rst:416 + handled, resulting in compilation error. This has been corrected to match the + behaviour exhibited by GCC. erichkeane wrote: > I'll make this change when I commit the patch. Thank

[PATCH] D148266: [clang][driver] Linking to just-built libc++.dylib when bootstrapping libc++ with clang

ldionne requested changes to this revision. ldionne added inline comments. This revision now requires changes to proceed. Comment at: clang/test/Driver/darwin-header-search-libcxx.cpp:119 // RUN: -nostdinc++ \ -// RUN: | FileCheck -DSYSROOT=%S/Inputs/basic_darwin_sdk_usr \

[PATCH] D151741: [Lex] Only warn on defining or undefining language-defined builtins

john.brawn updated this revision to Diff 527432. john.brawn added a comment. Put x86 tests in undef-x86.c. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151741/new/ https://reviews.llvm.org/D151741 Files: clang/lib/Lex/PPDirectives.cpp clang/test/Preprocessor/macro-reserved.c cla

[PATCH] D134334: [Clang] Fix crash in isCXXDeclarationSpecifier when attempting to annotate template name

shafik added a reviewer: clang-language-wg. shafik added a comment. Adding more reviewers for more visibility. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134334/new/ https://reviews.llvm.org/D134334 ___ cfe-commits mailing list cfe-commits

[PATCH] D148474: [Clang] Fix ResolveConstructorOverload to not select a conversion function if we are going use copy elision

shafik added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148474/new/ https://reviews.llvm.org/D148474 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D150746: [CodeGen]Translating pointer arguments can require an address space cast

AlexVlx added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:1630-1632 +LangAS AS = CGM.GetGlobalVarAddressSpace(nullptr); +QualType Q = Context.getAddrSpaceQualType(Context.VoidPtrTy, AS); +QualType T = Context.getPointerType(Q); ya

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo updated this revision to Diff 527435. VitaNuo added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150185/new/ https://reviews.llvm.org/D150185 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/Includ

[PATCH] D151895: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D1

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo updated this revision to Diff 527438. VitaNuo added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150185/new/ https://reviews.llvm.org/D150185 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/Includ

[PATCH] D151895: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo abandoned this revision. VitaNuo added a comment. Herald added a subscriber: ormris. Created by mistake. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151895/new/ https://reviews.llvm.org/D151895 ___

[PATCH] D134334: [Clang] Fix crash in isCXXDeclarationSpecifier when attempting to annotate template name

cor3ntin added a comment. I does think this patch probably makes sense but I agree with Erich that a comment is in order. I'm also wondering whether we can end up in a situation where Tok and NextToken() get replaced by a single annotation in which case this would not work. I don't think so.

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo updated this revision to Diff 527446. VitaNuo added a comment. Fix windows build. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150185/new/ https://reviews.llvm.org/D150185 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/cl

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo updated this revision to Diff 527447. VitaNuo added a comment. Add newline at file end. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150185/new/ https://reviews.llvm.org/D150185 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-ex

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo updated this revision to Diff 527448. VitaNuo added a comment. Add newline at file end. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150185/new/ https://reviews.llvm.org/D150185 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-ex

[PATCH] D151741: [Lex] Only warn on defining or undefining language-defined builtins

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Thanks for the patch! Comment at: clang/test/Preprocessor/undef-x86.c:2 +// RUN: %clang_cc1 -triple=i386-none-none -fsyntax-only -verify %s +// RUN: %clang_

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo updated this revision to Diff 527451. VitaNuo added a comment. Remove extra include. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150185/new/ https://reviews.llvm.org/D150185 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo updated this revision to Diff 527452. VitaNuo added a comment. Remove newline at file end. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150185/new/ https://reviews.llvm.org/D150185 Files: clang-tools-extra/clangd/Hover.cpp clang-tools

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

VitaNuo updated this revision to Diff 527457. VitaNuo added a comment. Re-introduce special path handling. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148793/new/ https://reviews.llvm.org/D148793 Files: clang-tools-extra/clang-tidy/misc/CMakeL

[PATCH] D151854: [clang] Use `FileEntryRef` in modular header search (part 1/2)

benlangmuir added a comment. Comment at: clang/include/clang/Lex/HeaderSearch.h:763 /// find this file due to requirements from \p RequestingModule. - bool findUsableModuleForHeader(const FileEntry *File, + bool findUsableModuleForHeader(OptionalFileEntryRef File,

[clang] 2129cc1 - [clang][Darwin] Error out when missing requested libarclite library

Author: Keith Smiley Date: 2023-06-01T09:32:59-07:00 New Revision: 2129cc1b3a14df5c24e5b2a680f18b88d5af4142 URL: https://github.com/llvm/llvm-project/commit/2129cc1b3a14df5c24e5b2a680f18b88d5af4142 DIFF: https://github.com/llvm/llvm-project/commit/2129cc1b3a14df5c24e5b2a680f18b88d5af4142.diff

[PATCH] D150988: [clang][Darwin] Error out when missing requested libarclite library

This revision was automatically updated to reflect the committed changes. Closed by commit rG2129cc1b3a14: [clang][Darwin] Error out when missing requested libarclite library (authored by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150988/n

[PATCH] D151852: [clang] NFCI: Use `FileEntryRef` in `ModuleMapCallbacks`

benlangmuir accepted this revision. benlangmuir added a comment. This revision is now accepted and ready to land. Nice simplification! Comment at: clang/include/clang/Lex/ModuleMap.h:72 /// \param Header The umbrella header to collect. - virtual void moduleMapAddUmbrellaHea

  1   2   3   >