junaire accepted this revision.
junaire added a comment.
This revision is now accepted and ready to land.
Thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151620/new/
https://reviews.llvm.org/D151620
__
Author: eopXD
Date: 2023-05-28T01:29:49-07:00
New Revision: 9efa4cdb5169ef77e6250473574980e7438fcf42
URL:
https://github.com/llvm/llvm-project/commit/9efa4cdb5169ef77e6250473574980e7438fcf42
DIFF:
https://github.com/llvm/llvm-project/commit/9efa4cdb5169ef77e6250473574980e7438fcf42.diff
LOG: [C
VoltrexMaster updated this revision to Diff 526316.
VoltrexMaster added a comment.
Pull upstream changes to fix build failures
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150579/new/
https://reviews.llvm.org/D150579
Files:
clang-tools-extra/do
H-G-Hristov created this revision.
Herald added a project: All.
H-G-Hristov requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
`weak_equality` and `strong_equality` are removed from the standard:
- https://wg21.link/P1959R0
- https://eel.is/c
Author: Martin Storsjö
Date: 2023-05-28T13:16:53+03:00
New Revision: 592e935e115ffb451eb9b782376711dab6558fe0
URL:
https://github.com/llvm/llvm-project/commit/592e935e115ffb451eb9b782376711dab6558fe0
DIFF:
https://github.com/llvm/llvm-project/commit/592e935e115ffb451eb9b782376711dab6558fe0.diff
This revision was automatically updated to reflect the committed changes.
Closed by commit rG592e935e115f: [clang-repl] Fix REPL_EXTERNAL_VISIBILITY and
building libclang-cpp.dll for… (authored by mstorsjo).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.o
Author: Ivan Murashko
Date: 2023-05-28T11:49:51+01:00
New Revision: f8536fb11e3d71d009c9002b5aa2ef32983ac7dc
URL:
https://github.com/llvm/llvm-project/commit/f8536fb11e3d71d009c9002b5aa2ef32983ac7dc
DIFF:
https://github.com/llvm/llvm-project/commit/f8536fb11e3d71d009c9002b5aa2ef32983ac7dc.diff
This revision was automatically updated to reflect the committed changes.
Closed by commit rGf8536fb11e3d: [clang][HeaderSearch] Fix implicit module when
using header maps (authored by ivanmurashko).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D1039
v.g.vassilev added inline comments.
Comment at: clang/include/clang/Interpreter/Interpreter.h:113
llvm::Expected CompileDtorCall(CXXRecordDecl
*CXXRD);
+ std::string CreateUniqName(std::string Base);
We should move this routine to its user in maybe ValuePr
AMS21 added a comment.
Bumping to ask for reviews
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148697/new/
https://reviews.llvm.org/D148697
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https:
kadircet added a comment.
thanks a lot! outline seems good. mostly some comments on implementation
details.
Comment at:
clang-tools-extra/include-cleaner/include/clang-include-cleaner/Analysis.h:92
+
+ virtual std::string operator()(llvm::StringRef HeaderPhysicalPath) const
Author: Vlad Serebrennikov
Date: 2023-05-28T15:58:52+03:00
New Revision: 5b4fed66efe245bb0cc246755a669ab3a17de9ed
URL:
https://github.com/llvm/llvm-project/commit/5b4fed66efe245bb0cc246755a669ab3a17de9ed
DIFF:
https://github.com/llvm/llvm-project/commit/5b4fed66efe245bb0cc246755a669ab3a17de9ed.
PiotrZSL accepted this revision.
PiotrZSL added a comment.
This revision is now accepted and ready to land.
On first glance, looks fine, but I didn't check it too deep.
Leave it open for 1-2 weeks. I will try to check it more deeply.
One thing that I see and do not like is duplication, maybe we c
AMS21 updated this revision to Diff 526326.
AMS21 marked 2 inline comments as done.
AMS21 added a comment.
Rename `cppcoreguidelines-noexcept-move-constructor` to
`cppcoreguidelines-noexcept-move-operations`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm
AMS21 updated this revision to Diff 526327.
AMS21 added a comment.
Removed unrelated change
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148697/new/
https://reviews.llvm.org/D148697
Files:
clang-tools-extra/clang-tidy/cppcoreguidelines/CppCoreG
sstwcw created this revision.
Herald added projects: All, clang, clang-format.
Herald added a subscriber: cfe-commits.
Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay.
sstwcw requested review of this revision.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.
yronglin added a comment.
The col number in diagnostic message seems not correct
https://godbolt.org/z/jnG5orhYW
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151121/new/
https://reviews.llvm.org/D151121
__
H-G-Hristov added inline comments.
Comment at: clang/unittests/Format/FormatTest.cpp:25716
+ "int param2,\n"
+ "int param3);\n",
+ Style);
Does this work with `BAS_BlockIndent`? I don't see any related tests.
Re
Author: Kazu Hirata
Date: 2023-05-28T12:11:26-07:00
New Revision: e2cc2939a30b9e61e8533ef95f818a7b22bd465f
URL:
https://github.com/llvm/llvm-project/commit/e2cc2939a30b9e61e8533ef95f818a7b22bd465f
DIFF:
https://github.com/llvm/llvm-project/commit/e2cc2939a30b9e61e8533ef95f818a7b22bd465f.diff
L
Author: Kazu Hirata
Date: 2023-05-28T12:11:25-07:00
New Revision: c194a5efb8c1122892d9f4a8441c237fd83dbd27
URL:
https://github.com/llvm/llvm-project/commit/c194a5efb8c1122892d9f4a8441c237fd83dbd27
DIFF:
https://github.com/llvm/llvm-project/commit/c194a5efb8c1122892d9f4a8441c237fd83dbd27.diff
L
Author: Kazu Hirata
Date: 2023-05-28T12:11:28-07:00
New Revision: d0e4119d848bbb8df6a7fa303ad8302a770fbab8
URL:
https://github.com/llvm/llvm-project/commit/d0e4119d848bbb8df6a7fa303ad8302a770fbab8
DIFF:
https://github.com/llvm/llvm-project/commit/d0e4119d848bbb8df6a7fa303ad8302a770fbab8.diff
L
Author: Hristo Hristov
Date: 2023-05-28T22:25:16+03:00
New Revision: fb250b8295b9f65590017c5b13d6de0b4f4617c1
URL:
https://github.com/llvm/llvm-project/commit/fb250b8295b9f65590017c5b13d6de0b4f4617c1
DIFF:
https://github.com/llvm/llvm-project/commit/fb250b8295b9f65590017c5b13d6de0b4f4617c1.diff
This revision was automatically updated to reflect the committed changes.
Closed by commit rGfb250b8295b9: [clang][c++20][NFC] `ComparisonCategoryType` -
updated comment, removed `std… (authored by Zingam).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.or
Endill created this revision.
Endill added reviewers: clang-language-wg, shafik.
Herald added a project: All.
Endill requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Also mark CWG78 as "no". CWG253 is the only issue that references 78, and t
Endill updated this revision to Diff 526342.
Endill added a comment.
Update cxx_dr_status.html
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151634/new/
https://reviews.llvm.org/D151634
Files:
clang/test/CXX/drs/dr0xx.cpp
clang/test/CXX/drs/dr
Author: Kazu Hirata
Date: 2023-05-28T13:13:12-07:00
New Revision: a82f2b2db34c58f18d7abbdbe7af51cc1e7ec3aa
URL:
https://github.com/llvm/llvm-project/commit/a82f2b2db34c58f18d7abbdbe7af51cc1e7ec3aa
DIFF:
https://github.com/llvm/llvm-project/commit/a82f2b2db34c58f18d7abbdbe7af51cc1e7ec3aa.diff
L
VoltrexMaster added a comment.
Does anyone know how to change the utils/tools to generate HTML with correct
syntax? I tried but there are test failures caused by them.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150579/new/
https://reviews.llvm.
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG9f6250f59105: [Clang][AArch64][SME] Add vector load/store
(ld1/st1) intrinsics (authored by bryanpkc).
Repository:
rG LLVM Github Monorepo
CHANGE
bryanpkc updated this revision to Diff 526351.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134677/new/
https://reviews.llvm.org/D134677
Files:
clang/include/clang/Basic/TargetBuiltins.h
clang/include/clang/Basic/arm_sme.td
clang/include/clang/Basic/arm_sve_sme_incl.td
clang/lib
denizevrenci updated this revision to Diff 526359.
denizevrenci added a comment.
Add tests for co_yield and co_await
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147417/new/
https://reviews.llvm.org/D147417
Files:
clang-tools-extra/clang-tidy/u
denizevrenci added a comment.
@PiotrZSL & @ChuanqiXu may I request a re-review? I addressed all comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D147417/new/
https://reviews.llvm.org/D147417
___
cf
Author: Manna, Soumi
Date: 2023-05-28T20:09:09-07:00
New Revision: b6a5aeadb5588dedc09eacc3b98b0278d6d53529
URL:
https://github.com/llvm/llvm-project/commit/b6a5aeadb5588dedc09eacc3b98b0278d6d53529
DIFF:
https://github.com/llvm/llvm-project/commit/b6a5aeadb5588dedc09eacc3b98b0278d6d53529.diff
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb6a5aeadb558: [NFC][CLANG] Fix issue with dereference null
return value in… (authored by Manna).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151469/new/
h
bryanpkc updated this revision to Diff 526361.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134678/new/
https://reviews.llvm.org/D134678
Files:
clang/include/clang/Basic/TargetBuiltins.h
clang/include/clang/Basic/arm_sme.td
clang/include/clan
RitanyaB updated this revision to Diff 526377.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146418/new/
https://reviews.llvm.org/D146418
Files:
clang/include/clang/Sema/Sema.h
clang/lib/Sema/SemaDecl.cpp
clang/lib/Sema/SemaOpenMP.cpp
clang/test/OpenMP/declare_target_messages.cpp
bryanpkc updated this revision to Diff 526379.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D134679/new/
https://reviews.llvm.org/D134679
Files:
clang/include/clang/Basic/arm_sme.td
clang/lib/CodeGen/CGBuiltin.cpp
clang/test/CodeGen/aarch64-sm
junaire updated this revision to Diff 526383.
junaire added a comment.
Make CreateUniqName a static helper
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146809/new/
https://reviews.llvm.org/D146809
Files:
clang/include/clang/Interpreter/Interpre
junaire added inline comments.
Comment at: clang/tools/clang-repl/CMakeLists.txt:40
+ ??6?$basic_ostream@DU?$char_traits@D@std@@@std@@QEAAAEAV01@PEBX@Z
+
??6?$basic_ostream@DU?$char_traits@D@std@@@std@@QEAAAEAV01@P6AAEAV01@AEAV01@@Z@Z
+
??$?6U?$char_traits@D@std@
shchenz added a comment.
gentle ping
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148490/new/
https://reviews.llvm.org/D148490
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.
v.g.vassilev added inline comments.
Comment at: clang/lib/Interpreter/IncrementalParser.h:86
+ Parser &getParser() { return *P; }
+
Is that used?
Comment at: clang/lib/Interpreter/ValuePrinter.cpp:262
+
+static llvm::Expected CompileDecl(Int
v.g.vassilev added inline comments.
Comment at: clang/lib/Interpreter/ValuePrinter.cpp:1
+#include "InterpreterUtils.h"
+#include "clang/AST/ASTContext.h"
Please add the llvm preamble.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://
41 matches
Mail list logo