[PATCH] D150528: [Clang] Fix the diagnoses when the argument to alignas is an incomplete type

yronglin marked 2 inline comments as done. yronglin added a comment. In D150528#4342600 , @aaron.ballman wrote: > In D150528#4342535 , @yronglin > wrote: > >> Thanks a lot for your review @aaron.ballman ! BTW, d

[clang] b763d6a - Add C++26 compile flags.

Author: Erich Keane Date: 2023-05-15T08:56:16-07:00 New Revision: b763d6a4ed4650c74c6846d743156468563b0e31 URL: https://github.com/llvm/llvm-project/commit/b763d6a4ed4650c74c6846d743156468563b0e31 DIFF: https://github.com/llvm/llvm-project/commit/b763d6a4ed4650c74c6846d743156468563b0e31.diff L

[PATCH] D150450: Add C++26 compile flags.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb763d6a4ed46: Add C++26 compile flags. (authored by erichkeane). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D150582: [clangd] Fix test failure when it's built with compiler flags unknown by clang

xry111 created this revision. xry111 added reviewers: thesamesam, MaskRay, uabelho. Herald added subscribers: kadircet, arphaman. Herald added a project: All. xry111 requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang-tools-extra.

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

aaron.ballman added inline comments. Comment at: clang/include/clang/Interpreter/Value.h:160-162 + // Interpreter, QualType are stored as void* to reduce dependencies. + void *Interp = nullptr; + void *OpaqueType = nullptr; junaire wrote: > v.g.vassilev wrote:

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

v.g.vassilev added a comment. This is looking good. Can you address my minor comments and run clang-format? Comment at: clang/lib/Interpreter/DeviceOffload.cpp:1 +//===-- Offload.cpp - CUDA Offloading ---*- C++ -*-===// +// v.g.vassilev

[PATCH] D149733: [clang][USR] Prevent crashes on incomplete FunctionDecls

kadircet added a comment. In D149733#4342300 , @aaron.ballman wrote: > But at the same time, it's become more obvious (at least to me) that clangd > has features that don't work with all of the invariants in Clang and I don't > know that we ever really

[clang] 0d1be98 - [clang][USR] Prevent crashes on incomplete FunctionDecls

Author: Kadir Cetinkaya Date: 2023-05-15T18:05:48+02:00 New Revision: 0d1be98a67e29b70ccfab23d86a2bea13de117d7 URL: https://github.com/llvm/llvm-project/commit/0d1be98a67e29b70ccfab23d86a2bea13de117d7 DIFF: https://github.com/llvm/llvm-project/commit/0d1be98a67e29b70ccfab23d86a2bea13de117d7.dif

[PATCH] D149733: [clang][USR] Prevent crashes on incomplete FunctionDecls

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0d1be98a67e2: [clang][USR] Prevent crashes on incomplete FunctionDecls (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D150586: [clang][AIX] Remove Newly Added Target Dependent Test Case

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: hubert.reinterpretcast, stephenpeckham, MaskRay, cebowleratibm. qiongsiwu1 added a project: clang. Herald added subscribers: kristof.beyls, nemanjai. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald adde

[PATCH] D150586: [clang][AIX] Remove Newly Added Target Dependent Test Case

qiongsiwu1 added a comment. I can revise the case and add it as a backend/llc test case if we would like to keep it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150586/new/ https://reviews.llvm.org/D150586 __

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added a comment. Patch to remove the problematic test case. https://reviews.llvm.org/D150586 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 ___ cfe-

[clang] eff52b1 - Fix test from b763d6a4ed4650c74c6846d743156468563b0e31

Author: Erich Keane Date: 2023-05-15T09:43:25-07:00 New Revision: eff52b1fca2b61fe3aa904026b5ce10d055dfe1d URL: https://github.com/llvm/llvm-project/commit/eff52b1fca2b61fe3aa904026b5ce10d055dfe1d DIFF: https://github.com/llvm/llvm-project/commit/eff52b1fca2b61fe3aa904026b5ce10d055dfe1d.diff L

[PATCH] D139586: [Clang][C++23] Lifetime extension in range-based for loops

rZhBoYao abandoned this revision. rZhBoYao added a comment. In D139586#4324857 , @cor3ntin wrote: > @rZhBoYao are you still working on this? Thanks! No. Sorry that I don't have the capacity to work on this. Repository: rG LLVM Github Monorepo CHANGE

[clang] 80cf56e - [clang][AIX] Remove Newly Added Target Dependent Test Case

Author: Qiongsi Wu Date: 2023-05-15T12:54:09-04:00 New Revision: 80cf56ea1bae05298a823b96b6b545ebca33b44a URL: https://github.com/llvm/llvm-project/commit/80cf56ea1bae05298a823b96b6b545ebca33b44a DIFF: https://github.com/llvm/llvm-project/commit/80cf56ea1bae05298a823b96b6b545ebca33b44a.diff LO

[PATCH] D150586: [clang][AIX] Remove Newly Added Target Dependent Test Case

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG80cf56ea1bae: [clang][AIX] Remove Newly Added Target Dependent Test Case (authored by qiongsiwu1). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added a comment. https://reviews.llvm.org/D150586 has landed and the problematic test case is removed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 _

[clang] cc7dc90 - [test] Fix const-str-array-decay.cl failure on PowerPC

Author: Sergei Barannikov Date: 2023-05-15T19:56:28+03:00 New Revision: cc7dc90481d93734a56098470879189cb2e2c127 URL: https://github.com/llvm/llvm-project/commit/cc7dc90481d93734a56098470879189cb2e2c127 DIFF: https://github.com/llvm/llvm-project/commit/cc7dc90481d93734a56098470879189cb2e2c127.d

[PATCH] D150520: [clang] Convert a few tests to opaque pointers

barannikov88 added a comment. In D150520#4342429 , @amyk wrote: > Hi, I just wanted to give a heads up that it appears that this patch is > causing failures on some of the PPC buildbots. > In particular, the `const-str-array-decay.cl` appears to be faili

[PATCH] D150114: [Headers][doc] Add "add/sub/mul" intrinsic descriptions to avx2intrin.h

RKSimon added a comment. @pengfei Any objections? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150114/new/ https://reviews.llvm.org/D150114 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D150403: [clang-format] Adjust braced list detection (try 2)

galenelias updated this revision to Diff 522245. galenelias edited the summary of this revision. galenelias added a comment. Addressed remaining review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150403/new/ https://reviews.llvm.org/D150403 Files: clang/lib/Format/Unwrapp

[PATCH] D150403: [clang-format] Adjust braced list detection (try 2)

galenelias marked 3 inline comments as done. galenelias added a comment. Thanks for the review and feedback. Sorry about the unfortunate timing between @sstwcw and my fix - we submitted our fixes less than 24 hours apart. I didn't think there would be another simultaneous fix for this 5 year o

[PATCH] D150226: [Clang] Remove ability to downgrade warning on the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

manojgupta added a comment. In D150226#4342516 , @aaron.ballman wrote: > In D150226#4340166 , @manojgupta > wrote: > >> https://github.com/bminor/binutils-gdb/blob/master/include/diagnostics.h >> >> gdb only sup

[clang-tools-extra] 2239fd5 - Fix build failure caused by https://reviews.llvm.org/D150352

Author: Amy Kwan Date: 2023-05-15T12:18:06-05:00 New Revision: 2239fd50bd807ce32c54e03d548cc0cc7c6e64dd URL: https://github.com/llvm/llvm-project/commit/2239fd50bd807ce32c54e03d548cc0cc7c6e64dd DIFF: https://github.com/llvm/llvm-project/commit/2239fd50bd807ce32c54e03d548cc0cc7c6e64dd.diff LOG:

[PATCH] D150520: [clang] Convert a few tests to opaque pointers

amyk added a comment. In D150520#4342943 , @barannikov88 wrote: > In D150520#4342429 , @amyk wrote: > >> Hi, I just wanted to give a heads up that it appears that this patch is >> causing failures on some of the

[PATCH] D139586: [Clang][C++23] Lifetime extension in range-based for loops

cor3ntin added a comment. In D139586#4342868 , @rZhBoYao wrote: > In D139586#4324857 , @cor3ntin > wrote: > >> @rZhBoYao are you still working on this? Thanks! > > No. Sorry that I don't have the capacity to work

[PATCH] D149733: [clang][USR] Prevent crashes on incomplete FunctionDecls

aaron.ballman added a comment. In D149733#4342705 , @kadircet wrote: > In D149733#4342300 , @aaron.ballman > wrote: > >> But at the same time, it's become more obvious (at least to me) that clangd >> has feature

[PATCH] D144004: [DebugMetadata][DwarfDebug] Fix DWARF emisson of function-local imported entities (3/7)

dzhidzhoev updated this revision to Diff 522254. dzhidzhoev added a comment. Herald added subscribers: mattd, gchakrabarti, asavonic, kerbowa, jvesely, jholewinski. Fixed split-dwarf-local-import*.ll tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[clang] f986987 - Enable frame pointer for all non-leaf functions on riscv64 Android

Author: AdityaK Date: 2023-05-15T10:29:49-07:00 New Revision: f98698714e2ebdfaad71a2d3f13e040de80eb444 URL: https://github.com/llvm/llvm-project/commit/f98698714e2ebdfaad71a2d3f13e040de80eb444 DIFF: https://github.com/llvm/llvm-project/commit/f98698714e2ebdfaad71a2d3f13e040de80eb444.diff LOG:

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf98698714e2e: Enable frame pointer for all non-leaf functions on riscv64 Android (authored by AdityaK <1894981+hiradi...@users.noreply.github.com>).

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

hiraditya updated this revision to Diff 522252. hiraditya added a comment. Addressed comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150490/new/ https://reviews.llvm.org/D150490 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/frame-pointer-elim.c clang/test

[PATCH] D144004: [DebugMetadata][DwarfDebug] Fix DWARF emisson of function-local imported entities (3/7)

dzhidzhoev updated this revision to Diff 522257. dzhidzhoev added a comment. Fixed split-dwarf-local-import*.ll tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144004/new/ https://reviews.llvm.org/D144004 Files: clang/test/CodeGenCXX/debug-

[PATCH] D150528: [Clang] Fix the diagnoses when the argument to alignas is an incomplete type

aaron.ballman added a subscriber: erichkeane. aaron.ballman added a comment. In D150528#4342646 , @yronglin wrote: > In D150528#4342600 , @aaron.ballman > wrote: > >> In D150528#4342535

[clang] 8097d01 - Revert "[AIX][tests] XFAIL -ftime-trace test for now"

Author: Jake Egan Date: 2023-05-15T13:50:21-04:00 New Revision: 8097d01260fc251c613e848607db1d7dbddaa22c URL: https://github.com/llvm/llvm-project/commit/8097d01260fc251c613e848607db1d7dbddaa22c DIFF: https://github.com/llvm/llvm-project/commit/8097d01260fc251c613e848607db1d7dbddaa22c.diff LOG

[PATCH] D148785: -fsanitize=function: use type hashes instead of RTTI objects

peter.smith added a comment. Should `HANDLER(__ubsan_handle_function_type_mismatch,"function")` be added to ubsan_minimal_runtime if this is supported in the minimal runtime? Comment at: clang/lib/CodeGen/CGExpr.cpp:5382 + getPointerAlign()); llvm::Value *Calle

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

hiraditya added a comment. > Is there more context on why Android enables the frame pointer? From what i gathered, this is more of an effort to have parity such that existing build flag overrides continue to be consistent. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150490/new/ http

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

aaron.ballman added inline comments. Comment at: clang/test/Preprocessor/macro-reserved.cpp:15 -#undef __cplusplus +#undef __cplusplus // expected-warning {{undefining builtin macro}} #define __cplusplus Why do we diagnose the undef but not the define? CHANG

[PATCH] D148827: -fsanitize=function: support C

peter.smith added a comment. I agree with the reasoning. Can you update the documentation in clang/docs/UndefinedBehaviorSanitizer.rst to include C and state the known limitation. After D148573 it says: - ``-fsanitize=function``: Indirect call of a function

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

enh added a comment. In D150490#4343128 , @hiraditya wrote: >> Is there more context on why Android enables the frame pointer? > > From what i gathered, this is more of an effort to have parity such that > existing build flag overrides continue to be con

[PATCH] D150111: [clang][Interp] Implement lambda static invokers

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeEmitter.cpp:100-103 + bool IsEligibleForCompilation = + FuncDecl->isConstexpr() || + (isa(FuncDecl) && + cast(FuncDecl)->isLambdaStaticInvoker()); I don't like the `isa

[PATCH] D147875: [clang][Diagnostics] Show line numbers when printing code snippets

aaron.ballman added inline comments. Comment at: clang/lib/Frontend/TextDiagnostic.cpp:1121-1138 +static unsigned getNumDisplayWidth(unsigned N) { + if (N < 10) +return 1; + if (N < 100) +return 2; + if (N < 1'000) +return 3; aaronpuchert wrote: >

[PATCH] D147732: [AMDGPU] Add type mangling for {read, write, readfirst, perm}lane intrinsics

yaxunl added a comment. In D147732#4343146 , @jrbyrnes wrote: > Hi @yaxunl thanks for the comment. > > I looked into AutoUpgrade, and it catches upgrades of this type (unmangled -> > mangled) by default (via remangleIntrinsicFunction). I've included test

[PATCH] D150597: [clang][AIX] Adding Revised xcoff-roptr CodeGen Test Case

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: hubert.reinterpretcast, stephenpeckham. qiongsiwu1 added a project: clang. Herald added a subscriber: nemanjai. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added a subscriber: cfe-commits. https://r

[PATCH] D149160: [clang][analyzer] Handle special value AT_FDCWD in affected standard functions

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149160/new/ https://reviews.llvm.org/D149160 ___

[PATCH] D150494: [clang][modules] NFC: Only sort interesting identifiers

ributzka added inline comments. Comment at: clang/lib/Serialization/ASTWriter.cpp:3646 // file. SmallVector IIs; for (const auto &ID : PP.getIdentifierTable()) Would it make sense to reduce the size of the SmallVector too? Repository: rG LLVM G

[PATCH] D150478: [clang][modules][deps] Parse "FW_Private" module map even after loading "FW" PCM

benlangmuir accepted this revision. benlangmuir added a comment. This revision is now accepted and ready to land. LGTM. I ran into a similar issue in a downstream branch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150478/new/ https://reviews.llvm

[PATCH] D150446: [analyzer] Check ArraySubscriptExprs in ArrayBoundCheckerV2

donat.nagy planned changes to this revision. donat.nagy added a comment. I started to create tests to demonstrate the differences from the baseline, and it turns out that my patch is handling multidimensional arrays incorrectly. I'll debug this issue and upload a fixed version of this patch. R

[PATCH] D150479: [clang][modules][deps] Allow skipping submodule definitions

benlangmuir added inline comments. Comment at: clang/test/ClangScanDeps/modules-private-framework-submodule.c:43 // CHECK-NEXT: "context-hash": "{{.*}}", -// CHECK-NEXT: "module-name": "FW2_Private" +// CHECK-NEXT: "module-name": "FW2"

[PATCH] D146358: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Did you end up requesting commit access? If not, now is probably a good time: https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access Comment

[PATCH] D149976: adding bf16 support to NVPTX

kushanam updated this revision to Diff 522283. kushanam added a comment. Addressing the review changed adn removing bf16 specific registers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149976/new/ https://reviews.llvm.org/D149976 Files: clang/i

[PATCH] D150479: [clang][modules][deps] Allow skipping submodule definitions

jansvoboda11 added inline comments. Comment at: clang/test/ClangScanDeps/modules-private-framework-submodule.c:43 // CHECK-NEXT: "context-hash": "{{.*}}", -// CHECK-NEXT: "module-name": "FW2_Private" +// CHECK-NEXT: "module-name": "FW2"

[PATCH] D149976: adding bf16 support to NVPTX

kushanam abandoned this revision. kushanam added a comment. Redundant to D144911 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149976/new/ https://reviews.llvm.org/D149976

[PATCH] D150494: [clang][modules] NFC: Only sort interesting identifiers

jansvoboda11 added inline comments. Comment at: clang/lib/Serialization/ASTWriter.cpp:3646 // file. SmallVector IIs; for (const auto &ID : PP.getIdentifierTable()) ributzka wrote: > Would it make sense to reduce the size of the SmallVector too? Tha

[PATCH] D150479: [clang][modules][deps] Allow skipping submodule definitions

benlangmuir added inline comments. Comment at: clang/test/ClangScanDeps/modules-private-framework-submodule.c:43 // CHECK-NEXT: "context-hash": "{{.*}}", -// CHECK-NEXT: "module-name": "FW2_Private" +// CHECK-NEXT: "module-name": "FW2"

[PATCH] D149976: adding bf16 support to NVPTX

kushanam updated this revision to Diff 522284. kushanam added a comment. Addressing review changed and removing bf16 registers Depends on D144911 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149976/new/ https://

[PATCH] D150221: Add option -fkeep-static-variables to emit all static variables

aaron.ballman added reviewers: rjmccall, efriedma. aaron.ballman added subscribers: efriedma, rjmccall. aaron.ballman added a comment. In D150221#4338500 , @qianzhen wrote: > This is useful in keeping the static variables in a patchable function > (https

[clang] f39fd75 - Revert "[-Wunsafe-buffer-usage] Remove an unnecessary const-qualifier"

Author: ziqingluo-90 Date: 2023-05-15T11:47:00-07:00 New Revision: f39fd750ab59cb2482688168b25db303dbebdb09 URL: https://github.com/llvm/llvm-project/commit/f39fd750ab59cb2482688168b25db303dbebdb09 DIFF: https://github.com/llvm/llvm-project/commit/f39fd750ab59cb2482688168b25db303dbebdb09.diff

[PATCH] D148785: -fsanitize=function: use type hashes instead of RTTI objects

MaskRay marked 2 inline comments as done. MaskRay added a comment. In D148785#4343112 , @peter.smith wrote: > Should `HANDLER(__ubsan_handle_function_type_mismatch,"function")` be added > to ubsan_minimal_runtime if this is supported in the minimal runt

[PATCH] D150352: [clang][dataflow] Don't analyze templated declarations.

mboehme added a subscriber: amyk. mboehme added a comment. In D150352#4342480 , @uabelho wrote: > Hello, > > > ../../clang-tools-extra/clang-tidy/bugprone/UncheckedOptionalAccessCheck.cpp:43:27: > error: 'build' is deprecated: Use the version that tak

[PATCH] D148785: -fsanitize=function: use type hashes instead of RTTI objects

MaskRay updated this revision to Diff 522286. MaskRay marked 2 inline comments as done. MaskRay added a comment. rename a variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148785/new/ https://reviews.llvm.org/D148785 Files: clang/docs/Undef

[PATCH] D148827: -fsanitize=function: support C

MaskRay updated this revision to Diff 522287. MaskRay added a comment. rebase the final patch in the series Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148827/new/ https://reviews.llvm.org/D148827 Files: clang/docs/UndefinedBehaviorSanitizer.r

[PATCH] D149976: adding bf16 support to NVPTX

kushanam updated this revision to Diff 522290. kushanam added a comment. Adressing review changes and removing bf16 registers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149976/new/ https://reviews.llvm.org/D149976 Files: clang/include/clang/B

[clang] 86c7e33 - Re-land "[-Wunsafe-buffer-usage] Remove an unnecessary const-qualifier"

Author: ziqingluo-90 Date: 2023-05-15T12:10:13-07:00 New Revision: 86c7e33b3fd0cc231b09b5af21ef42842f0ff97b URL: https://github.com/llvm/llvm-project/commit/86c7e33b3fd0cc231b09b5af21ef42842f0ff97b DIFF: https://github.com/llvm/llvm-project/commit/86c7e33b3fd0cc231b09b5af21ef42842f0ff97b.diff

[PATCH] D149516: [Sema] `setInvalidDecl` for error deduction declaration

HerrCai0907 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149516/new/ https://reviews.llvm.org/D149516 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D149612: [Sema] avoid merge error type

HerrCai0907 added a comment. Maybe return `QualType()` as a temporary solution to avoid crash? @erichkeane Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149612/new/ https://reviews.llvm.org/D149612 ___ c

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

craig.topper added a comment. In D150490#4343145 , @enh wrote: > In D150490#4343128 , @hiraditya > wrote: > >>> Is there more context on why Android enables the frame pointer? >> >> From what i gathered, this is

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

tlively added a comment. Thanks for the ping, will take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139010/new/ https://reviews.llvm.org/D139010 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D149612: [Sema] avoid merge error type

erichkeane added a comment. In D149612#4343440 , @HerrCai0907 wrote: > Maybe return `QualType()` as a temporary solution to avoid crash? @erichkeane I'm not sure at the moment... I'd like to have aaron take a look and chat it over with him. Repositor

[clang] 74f2078 - [clang] Fix emitVoidPtrVAArg for non-zero default alloca address space

Author: Jessica Clarke Date: 2023-05-15T20:26:49+01:00 New Revision: 74f207883bc5fe2a7300c4b4f1ff080a107ab148 URL: https://github.com/llvm/llvm-project/commit/74f207883bc5fe2a7300c4b4f1ff080a107ab148 DIFF: https://github.com/llvm/llvm-project/commit/74f207883bc5fe2a7300c4b4f1ff080a107ab148.diff

[PATCH] D132247: [clang] Fix emitVoidPtrVAArg for non-zero default alloca address space

This revision was automatically updated to reflect the committed changes. Closed by commit rG74f207883bc5: [clang] Fix emitVoidPtrVAArg for non-zero default alloca address space (authored by jrtc27). Changed prior to commit: https://reviews.llvm.org/D132247?vs=454033&id=522295#toc Repository:

[PATCH] D150602: [clang-tidy] Move formatDereference to FixitHintUtils

mikecrowe created this revision. mikecrowe added reviewers: njames93, carlosgalvezp, PiotrZSL. Herald added a subscriber: xazax.hun. Herald added a project: All. mikecrowe requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. I'd like

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added a comment. @erichkeane - I'll have stable internet ~soon and will try to look into the reported issue (but help would be greatly appreciated). To the best of my knowledge there are other problems with libstdc++'s ranges (even without this diff), but yeah, this regres

[PATCH] D150603: adding bf16 support to NVPTX

kushanam created this revision. Herald added subscribers: mattd, gchakrabarti, asavonic, hiraditya. Herald added a project: All. kushanam requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jdoerfert, jholewinski. Herald added projects: clang, LLVM. Currently, b

[PATCH] D150603: adding bf16 support to NVPTX

kushanam abandoned this revision. kushanam added a comment. redundant revision again on D144911 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150603/new/ https://reviews.llvm.org/D150603 _

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

erichkeane added a comment. In D146178#4343477 , @alexander-shaposhnikov wrote: > @erichkeane - I'll have stable internet ~soon and will try to look into the > reported issue (but help would be greatly appreciated). > To the best of my knowledge there a

[PATCH] D150490: Enable frame pointer for all non-leaf functions on riscv64 Android

MaskRay added a comment. In D150490#4343442 , @craig.topper wrote: > In D150490#4343145 , @enh wrote: > >> In D150490#4343128 , @hiraditya >> wrote: >> Is there mor

[PATCH] D150221: Add option -fkeep-static-variables to emit all static variables

efriedma added a comment. It's not unprecedented to add flags to copy the behavior of other compilers, to make porting easier, especially when it doesn't place much burden on compiler maintainers. But what compiler preserves the names/values of static variables by default? It's not the sort o

[PATCH] D147266: [AArch64] Sink operands to allow for bitselect instructions

pranavk updated this revision to Diff 522309. pranavk marked 3 inline comments as done. pranavk added a comment. address reviewer comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147266/new/ https://reviews.llvm.org/D147266 Files: llvm/lib

[PATCH] D147266: [AArch64] Sink operands to allow for bitselect instructions

pranavk added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:14361-14363 + for (unsigned Idx = 0; Idx < MainAnd->getNumOperands(); Idx++) { +if (MainAnd->getOperand(Idx) != IA) { + Ops.push_back(&MainAnd->getOperandU

[PATCH] D147266: [AArch64] Sink operands to allow for bitselect instructions

pranavk added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:14361-14363 + for (unsigned Idx = 0; Idx < MainAnd->getNumOperands(); Idx++) { +if (MainAnd->getOperand(Idx) != IA) { + Ops.push_back(&MainAnd->getOperandU

[clang-tools-extra] 6ccb806 - [clang-tidy] Extract areStatementsIdentical

Author: Piotr Zegar Date: 2023-05-15T20:05:12Z New Revision: 6ccb8061724fb6ee0b2598764656410ce3f2472c URL: https://github.com/llvm/llvm-project/commit/6ccb8061724fb6ee0b2598764656410ce3f2472c DIFF: https://github.com/llvm/llvm-project/commit/6ccb8061724fb6ee0b2598764656410ce3f2472c.diff LOG: [

[PATCH] D148995: [clang-tidy] Extract areStatementsIdentical

This revision was automatically updated to reflect the committed changes. Closed by commit rG6ccb8061724f: [clang-tidy] Extract areStatementsIdentical (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148995/new/ https://reviews.

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

erichkeane added a comment. There is probably more reduction work to be done, but I hit the end of my day here: https://godbolt.org/z/Tzfx31asK Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://reviews.llvm.org/D146178 __

[PATCH] D150539: [clang-format] Handle ud suffixes in IntegerLiteralSeparator

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Format/IntegerLiteralSeparatorFixer.cpp:116-117 if (Style.isCpp()) { - if (const auto Pos = Text.find_first_of("_i

[PATCH] D148997: [clang] Add a new annotation token: annot_repl_input_end

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. LGTM! Thanks for putting so much efforts into this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148997/new/ https://reviews.llvm.o

[clang] f60cc47 - [clang][modules] NFC: Only sort interesting identifiers

Author: Jan Svoboda Date: 2023-05-15T13:28:10-07:00 New Revision: f60cc473b82b16edc448199c84e612c1e5c3014c URL: https://github.com/llvm/llvm-project/commit/f60cc473b82b16edc448199c84e612c1e5c3014c DIFF: https://github.com/llvm/llvm-project/commit/f60cc473b82b16edc448199c84e612c1e5c3014c.diff L

[PATCH] D150494: [clang][modules] NFC: Only sort interesting identifiers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf60cc473b82b: [clang][modules] NFC: Only sort interesting identifiers (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D150608: [clang] Convert several OpenMP tests to opaque pointers

barannikov88 added inline comments. Comment at: clang/test/OpenMP/task_firstprivate_codegen.cpp:264 -// CHECK: alloca i32*, -// CHECK: [[PRIV_T_VAR_ADDR:%.+]] = alloca i32*, -// CHECK: [[PRIV_S_ARR_ADDR:%.+]] = alloca [2 x [[S_DOUBLE_TY]]]*, -// CHECK: [[PRIV_VEC_ADDR:%.+]] = a

[PATCH] D150253: [RISCV] Add Zvfhmin extension.

craig.topper added a subscriber: michaelmaitland. craig.topper added a comment. In D150253#4341545 , @jacquesguan wrote: > To enable specific EEW for specific insturction in instruction selection, I > will create some parent revisions. Here is the first

[PATCH] D150608: [clang] Convert several OpenMP tests to opaque pointers

barannikov88 added inline comments. Comment at: clang/test/OpenMP/task_firstprivate_codegen.cpp:264 -// CHECK: alloca i32*, -// CHECK: [[PRIV_T_VAR_ADDR:%.+]] = alloca i32*, -// CHECK: [[PRIV_S_ARR_ADDR:%.+]] = alloca [2 x [[S_DOUBLE_TY]]]*, -// CHECK: [[PRIV_VEC_ADDR:%.+]] = a

[PATCH] D150403: [clang-format] Adjust braced list detection (try 2)

galenelias added a comment. Thanks @HazardyKnusperkeks! I don't have commit access, so will need someone to land this for me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150403/new/ https://reviews.llvm.org/D150403 ___ cfe-commits mailing

[PATCH] D150614: [clang-format] Ignore first token when finding MustBreak

rymiel created this revision. rymiel added a project: clang-format. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. Herald added projects: All, clang. Herald added a subscriber: cfe-commits. rymiel requested review of this revision. When in ColumnLimit 0, the formatter looks f

[PATCH] D143967: [DebugInfo][BPF] Add 'btf:type_tag' annotation in DWARF

eddyz87 updated this revision to Diff 522338. eddyz87 edited the summary of this revision. eddyz87 added a comment. Changes to avoid attaching type tags to DWARF derived types for const/volatile/restrict qualifiers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D150608: [clang] Convert several OpenMP tests to opaque pointers

barannikov88 updated this revision to Diff 522342. barannikov88 added a comment. Throw in a few more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150608/new/ https://reviews.llvm.org/D150608 Files: clang/test/OpenMP/master_taskloop_codege

[PATCH] D139834: [clang-format] AllowShortCompoundRequirementOnASingleLine

rymiel accepted this revision. rymiel added a comment. This revision is now accepted and ready to land. I see nothing wrong with this patch alone as it currently stands, since it's a quite simple change to the LineJoiner, and I see it as one of the final stopgaps in clang-format's support for re

[PATCH] D150615: [clang][deps] Do not cache PCM files

jansvoboda11 created this revision. jansvoboda11 added a reviewer: Bigcheese. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. On incremental scan, caching an out

[PATCH] D150340: [SEH]:Fix assertion when try is used inside catch(...) block with /EHa

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM... but I don't think the IR we're generating is really correct overall; see https://github.com/llvm/llvm-project/issues/62723 On a side-note, other open issues related to -EHa/__try:

[PATCH] D150608: [clang] Convert several OpenMP tests to opaque pointers

jdoerfert added a comment. Did you manually update these tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150608/new/ https://reviews.llvm.org/D150608 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D143967: [DebugInfo][BPF] Add 'btf:type_tag' annotation in DWARF

yonghong-song added a comment. @dblaikie could you help take a look at this patch? Similar to https://reviews.llvm.org/D143966, this patch is the clang frontend change to support new btf_type_tag format, as we discussed and agreed with gcc community (https://lore.kernel.org/bpf/87r0w9jjoq@o

[PATCH] D150608: [clang] Convert several OpenMP tests to opaque pointers

barannikov88 added a comment. I first manually converted a few tests (mostly with regexes), then I checked that the script produces the same result. The result was identical to the letter. The rest of the

<    1   2   3   >