[PATCH] D147266: [AArch64] Add IR intrinsics for vbsl* C intrinsics

pranavk updated this revision to Diff 521115. pranavk added a comment. [AArch64] Change shouldSinkOperand to allow bitselect instructions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147266/new/ https://reviews.llvm.org/D147266 Files: llvm/lib/

[PATCH] D150318: [clang][deps] NFC: Pass around the whole scanning service

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, Bigcheese. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adding new field into t

[PATCH] D150319: [clang][deps] Always use -fmodules-validate-once-per-build-session

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, Bigcheese. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The dependency scanner

[PATCH] D150320: [clang][deps] Avoid relocatable modules checks

jansvoboda11 created this revision. jansvoboda11 added reviewers: benlangmuir, Bigcheese. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently, `ASTReader`

[PATCH] D150140: [NFC][CLANG] Fix Static Code Analysis Concerns

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. Looks good to me! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150140/new/ https://reviews.llvm.org/D150140 ___ cfe-commits mai

[PATCH] D150321: [clang] Document extensions from later standards

philnik created this revision. philnik added a reviewer: aaron.ballman. Herald added a project: All. philnik requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D150321 Files: c

[PATCH] D149718: [NFC][Clang] Fix Coverity issues of copy without assign

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. Looks good. Thanks @Manna! Comment at: clang/include/clang/Sema/Sema.h:1786 SemaDiagnosticBuilder(SemaDiagnosticBuilder &&D); +SemaDiagnosticBuilder &opera

[PATCH] D149718: [NFC][Clang] Fix Coverity issues of copy without assign

Manna added a comment. In D149718#4333563 , @tahonermann wrote: > Looks good. Thanks @Manna! Thank you @tahonermann for reviews! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149718/new/ https://reviews.llvm.org/D149718 _

[PATCH] D150140: [NFC][CLANG] Fix Static Code Analysis Concerns

Manna marked an inline comment as done. Manna added a comment. In D150140#4333552 , @tahonermann wrote: > Looks good to me! Thank you @tahonermann for reviews! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150140/new/ https://reviews.llvm.org

[PATCH] D150318: [clang][deps] NFC: Pass around the whole scanning service

benlangmuir added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningService.h:69 + /// The preprocessing mode used for scanning. + ScanningMode Mode; + /// The output format. Why drop `const`? Com

[PATCH] D150319: [clang][deps] Always use -fmodules-validate-once-per-build-session

benlangmuir added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningService.cpp:26 + ? BuildSessionTimestamp + : std::chrono::system_clock::now().time_since_epoch().count()) { // Initialize targets for object file su

[PATCH] D150320: [clang][deps] Avoid relocatable modules checks

benlangmuir accepted this revision. benlangmuir added a comment. This revision is now accepted and ready to land. With my naming comment addressed, LGTM Comment at: clang/include/clang/Lex/PreprocessorOptions.h:73 + /// Perform extra checks for relocatable modules when loading

[PATCH] D150291: [Clang] Rename internal type identifier(s) for `__bf16` to `BF16Ty`

tahonermann requested changes to this revision. tahonermann added a comment. This revision now requires changes to proceed. This looks great, thank you for doing this! Requested changes are just to undo some of the style changes. Comment at: clang/include/clang/Basic/Specifier

[PATCH] D150325: WIP: Prototype #ifdef-enforced DEPENDS on tablegen output

jroelofs created this revision. Herald added subscribers: steakhal, wenlei, martong, arphaman, hiraditya. Herald added a reviewer: NoQ. Herald added a reviewer: ributzka. Herald added a project: All. jroelofs requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, Ma

[PATCH] D150326: [WPD] Update llvm.public.type.test after importing functions

tejohnson created this revision. tejohnson added a reviewer: aeubanks. Herald added subscribers: ormris, steven_wu, hiraditya, emaste. Herald added a project: All. tejohnson requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added projects: clang, LLVM. I not

[PATCH] D150325: WIP: Prototype #ifdef-enforced DEPENDS on tablegen output

jroelofs added a comment. link back to the discourse thread: https://discourse.llvm.org/t/rfc-permanently-fixing-the-missing-tablegen-dependency-issue/70442/14?u=jroelofs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150325/new/ https://reviews.ll

[PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

codemzs updated this revision to Diff 521163. codemzs marked 4 inline comments as done. codemzs retitled this revision from "[Clang] Rename internal type identifier(s) for `__bf16` to `BF16Ty`" to "[Clang] Rename internal type identifier(s) for __bf16 to BF16Ty". codemzs added a comment. PR feed

[PATCH] D150291: [Clang] Rename internal type identifier(s) for __bf16 to BF16Ty

codemzs added a comment. Thank you for pointing that out and for reviewing my code. I appreciate your guidance. I was following the LLVM contribution guidelines to use git clang-format, but I understand the importance of maintaining existing code styles that may be altered by git-clang format.

[PATCH] D146342: [-Wunsafe-buffer-usage] Move the whole analysis to the end of a translation unit

ziqingluo-90 updated this revision to Diff 521176. ziqingluo-90 added a comment. Clean up the code for early return in case of ignoring `unsafe_buffer_usage` warnings. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146342/new/ https://reviews.llvm.org/D146342 Files: clang/include/cla

[PATCH] D146342: [-Wunsafe-buffer-usage] Move the whole analysis to the end of a translation unit

ziqingluo-90 updated this revision to Diff 521177. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146342/new/ https://reviews.llvm.org/D146342 Files: clang/include/clang/Sema/AnalysisBasedWarnings.h clang/lib/Sema/AnalysisBasedWarnings.cpp clang/lib/Sema/Sema.cpp clang/test/SemaCX

[PATCH] D148654: Modify BoundsSan to improve debuggability

oskarwirga updated this revision to Diff 521180. oskarwirga added a comment. Rebase on trunk :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148654/new/ https://reviews.llvm.org/D148654 Files: clang/lib/CodeGen/CGExpr.cpp clang/test/CodeGen/b

[PATCH] D146342: [-Wunsafe-buffer-usage] Move the whole analysis to the end of a translation unit

ziqingluo-90 updated this revision to Diff 521184. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146342/new/ https://reviews.llvm.org/D146342 Files: clang/include/clang/Sema/AnalysisBasedWarnings.h clang/lib/Sema/AnalysisBasedWarnings.cpp clang/lib/Sema/Sema.cpp clang/test/SemaCX

[PATCH] D150338: [-Wunsafe-buffer-usage][WIP] Improving insertion of the [[clang::unsafe_buffer_usage]] attribute

ziqingluo-90 created this revision. ziqingluo-90 added reviewers: jkorous, NoQ, malavikasamak, t-rasmud. Herald added a subscriber: jdoerfert. Herald added a project: All. ziqingluo-90 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For fix

[PATCH] D150181: [XCOFF][DWARF] XCOFF64 should be able to select the dwarf version under intergrated-as mode.

shchenz accepted this revision as: shchenz. shchenz added a comment. This revision is now accepted and ready to land. I think this is correct. DWARF spec indicates that DWARF64 should not be set as default. So it is right to change to DWARF32 by default for integrated-as mode for XCOFF64. LGTM

[PATCH] D148506: [C++] Don't filter using declaration when we perform qualified look up

ChuanqiXu updated this revision to Diff 521196. ChuanqiXu added a comment. Address comments and thank you for reviewing this! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148506/new/ https://reviews.llvm.org/D148506 Files: clang/lib/Sema/SemaDecl.cpp clang/test/Modules/pr62158.cpp

[PATCH] D150326: [WPD] Update llvm.public.type.test after importing functions

aeubanks accepted this revision. aeubanks added inline comments. This revision is now accepted and ready to land. Comment at: llvm/test/ThinLTO/X86/public-type-test.ll:31 ; HIDDEN-NOT: call {{.*}}@llvm.public.type.test ; HIDDEN: call {{.*}}@llvm.type.test sho

[PATCH] D146342: [-Wunsafe-buffer-usage] Move the whole analysis to the end of a translation unit

NoQ added inline comments. Comment at: clang/lib/Sema/AnalysisBasedWarnings.cpp:2340 + if (Node->doesThisDeclarationHaveABody()) +checkUnsafeBufferUsage(Node); + return true; This code will grow bigger when more warnings are added, and it's quit

[clang] 6e85d27 - [C++] Don't filter using declaration when we perform qualified look up

Author: Chuanqi Xu Date: 2023-05-11T10:21:52+08:00 New Revision: 6e85d2708115bc1c7cd1bf1674b64934a3cf6c25 URL: https://github.com/llvm/llvm-project/commit/6e85d2708115bc1c7cd1bf1674b64934a3cf6c25 DIFF: https://github.com/llvm/llvm-project/commit/6e85d2708115bc1c7cd1bf1674b64934a3cf6c25.diff LO

[PATCH] D148506: [C++] Don't filter using declaration when we perform qualified look up

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6e85d2708115: [C++] Don't filter using declaration when we perform qualified look up (authored by ChuanqiXu). Repository: rG LLVM Github Monorepo

[PATCH] D148490: [AIX] use system assembler for assembly files

shchenz added a comment. gentle ping... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148490/new/ https://reviews.llvm.org/D148490 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D150340: [SEH]:Fix assertion when try is used inside catch(...) block with /EHa

jyu2 created this revision. jyu2 added reviewers: asmith, efriedma, tentzen, pengfei. jyu2 added a project: clang. Herald added subscribers: kbarton, nemanjai. Herald added a project: All. jyu2 requested review of this revision. Current assert wiht /EHa with A single unwind edge may only enter one

[clang] 220e77a - [clang][CodeGenPGO] Don't use an invalid index when region counts disagree

Author: Nathan Lanza Date: 2023-05-10T22:53:53-04:00 New Revision: 220e77a83af19b3f6c47472596fdaaef8e305927 URL: https://github.com/llvm/llvm-project/commit/220e77a83af19b3f6c47472596fdaaef8e305927 DIFF: https://github.com/llvm/llvm-project/commit/220e77a83af19b3f6c47472596fdaaef8e305927.diff

[PATCH] D149504: [clang][CodeGenPGO] Don't use an invalid index when region counts disagree

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG220e77a83af1: [clang][CodeGenPGO] Don't use an invalid index when region counts disagree (authored by lanza). Changed prior to commit: https://rev

[PATCH] D148490: [AIX] use system assembler for assembly files

MaskRay added inline comments. Comment at: clang/test/Driver/aix-assembler.s:23 + +// RUN: %clang %s -### -c 2>&1 -fno-integrated-as \ +// RUN: --target=powerpc-ibm-aix7.1.0.0 \ I am not sure you need 6 RUN lines to test this. Whether a target uses integ

[PATCH] D150013: [Clang] Respect `-L` options when compiling directly for AMDGPU

jhuber6 updated this revision to Diff 521202. jhuber6 added a comment. Updating, @yaxunl does this look good? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150013/new/ https://reviews.llvm.org/D150013 Files: clang/lib/Driver/ToolChains/CommonArg

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

chaitanyav updated this revision to Diff 521203. chaitanyav added a comment. Remove extra parens Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147844/new/ https://reviews.llvm.org/D147844 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaE

[PATCH] D150191: [clang][Diagnostics] Provide a source range for 'use of undeclared identifier' diagnostics

tbaeder updated this revision to Diff 521215. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150191/new/ https://reviews.llvm.org/D150191 Files: clang/include/clang/Sema/Lookup.h clang/lib/Sema/SemaExpr.cpp Index: clang/lib/Sema/SemaExpr.cpp =

[PATCH] D150191: [clang][Diagnostics] Provide a source range for 'use of undeclared identifier' diagnostics

tbaeder added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:2187 else - SemaRef.Diag(TypoLoc, DiagnosticID) << Typo; + SemaRef.Diag(TypoRange.getEnd(), DiagnosticID) << Typo; return; I'm not passing the `TypoRange` here now, which r

<    1   2