[PATCH] D149361: [profiling] Improve error message for raw profile header mismatches

Dinistro added inline comments. Comment at: llvm/unittests/ProfileData/InstrProfTest.cpp:1359 auto RawProfileReaderOrErr = InstrProfReader::create(std::move(RawProfile)); ASSERT_TRUE(InstrProfError::take(RawProfileReaderOrErr.takeError()) == instrprof_error::

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

junaire updated this revision to Diff 517829. junaire added a comment. fix windows buildbots Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141215/new/ https://reviews.llvm.org/D141215 Files: clang/include/clang/Interpreter/Interpreter.h clang/

[PATCH] D148997: [clang] Add a new annotation token: annot_repl_input_end

junaire added a comment. This patch is part of D141215 . I split it as some jit people requested. I don't know if there's a good way to test the patch, please leave a comment if you have an idea. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D148997: [clang] Add a new annotation token: annot_repl_input_end

junaire added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:7219 void CodeGenModule::moveLazyEmissionStates(CodeGenModule *NewBuilder) { - assert(DeferredDeclsToEmit.empty() && - "Should have emitted all decls deferred to emit."); + // FIXME: Re-enab

[PATCH] D149259: [analyzer][NFC] Use std::optional instead of custom "empty" state

donat.nagy updated this revision to Diff 517831. donat.nagy edited the summary of this revision. donat.nagy added a comment. As I was finalizing this commit, I noticed that the logic of `RegionRawOffsetV2::computeOffset()` is presented in a ~~crazy~~ unconventional way; so I rewrote it (while pr

[PATCH] D148712: [clang] Diagnose shadowing of lambda's template parameter by a capture

Fznamznon updated this revision to Diff 517834. Fznamznon added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148712/new/ https://reviews.llvm.org/D148712 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaLambda.cpp cla

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

cor3ntin added a comment. In D149276#4302700 , @aaron.ballman wrote: > The changes generally LGTM, but: > >> in a way consistent with the proposed resolution to CWG1223. > > What are the chances that CWG changes their mind and picks a different > direct

[PATCH] D147197: [llvm-docs] Added documentation for the 'neg' operation

samtebbs added a comment. Since the instruction's don't exist now, would you mind abandoning this revision? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147197/new/ https://reviews.llvm.org/D147197 ___

[clang] e5d98c1 - Revert "[flang][driver] Allow main program to be in an archive"

Author: Andrzej Warzynski Date: 2023-04-28T09:39:27+01:00 New Revision: e5d98c15cb7ba467c5f93b5ef08ac9b18d390133 URL: https://github.com/llvm/llvm-project/commit/e5d98c15cb7ba467c5f93b5ef08ac9b18d390133 DIFF: https://github.com/llvm/llvm-project/commit/e5d98c15cb7ba467c5f93b5ef08ac9b18d390133.d

[PATCH] D146809: [WIP][clang-repl] Implement Value pretty printing

junaire updated this revision to Diff 517836. junaire added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146809/new/ https://reviews.llvm.org/D146809 Files: clang/include/clang/Interpreter/Interpreter.h clang/include/clang/I

[PATCH] D134821: [flang][driver] Allow main program to be in an archive

awarzynski added a comment. I've just reverted this patch - for context please see https://reviews.llvm.org/D149429. @sunshaoce This was committed without acknowledging @ekieri 's contribution, so didn't follow the official

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

skatrak updated this revision to Diff 517844. skatrak added a comment. Remove leftover unit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147218/new/ https://reviews.llvm.org/D147218 Files: flang/include/flang/Lower/OpenMP.h flang/lib/Low

[PATCH] D148944: [clang][Driver] Fix crash with unsupported architectures in MinGW and CrossWindows.

fhahn resigned from this revision. fhahn added a comment. Sorry, I am not familiar at all with this code. Perhaps @shafik could suggest more appropriate reviewers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148944/new/ https://reviews.llvm.org/D

[PATCH] D149006: [llvm][Support] Replace `%` operator with `&` in `Align::isAligned(...)`

fhahn added a comment. > it is easier to check reminder by conjunction with mask, which is (Pow2Value > - 1). Hmm, easier in what respect? Isn't the original code more straight-forward? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149006/new/ ht

[PATCH] D148944: [clang][Driver] Fix crash with unsupported architectures in MinGW and CrossWindows.

mstorsjo added a comment. I think the code changes make sense; these are trivial to hit by a user, so they shouldn't be `llvm_unreachable`. Comment at: clang/test/Driver/unsupported-target-arch.c:33 +// RUN: FileCheck --input-file=%t.err --check-prefix=CHECK-NOARCH-CROSSWINDOW

[clang] 8dec295 - Reapply D146987 "[Assignment Tracking] Enable by default"

Author: OCHyams Date: 2023-04-28T11:34:53+01:00 New Revision: 8dec295af0352fccb5825dc08e4ec21cb9ffe010 URL: https://github.com/llvm/llvm-project/commit/8dec295af0352fccb5825dc08e4ec21cb9ffe010 DIFF: https://github.com/llvm/llvm-project/commit/8dec295af0352fccb5825dc08e4ec21cb9ffe010.diff LOG:

[PATCH] D146987: [Assignment Tracking] Enable by default

Orlando added a comment. Great, thanks @paulkirth! I've just landed this again. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146987/new/ https://reviews.llvm.org/D146987 ___ cfe-commits mailing list cf

[PATCH] D149006: [llvm][Support] Replace `%` operator with `&` in `Align::isAligned(...)`

Stoorx added a comment. > easier in what respect? I mean, easier for CPU :-) The division operation reasonably seems to be more complex than bitwise AND. And since this function is pretty hot it can save a bit of performance. (Actually that's just my assumption. I did not make benchmark really.

[PATCH] D134821: [flang][driver] Allow main program to be in an archive

sunshaoce added a comment. In D134821#4304690 , @awarzynski wrote: > I've just reverted this patch - for context please see > https://reviews.llvm.org/D149429. > > @sunshaoce This was committed >

[PATCH] D149436: [clang] Do not attempt to zero-extend _BitInt(1) when not required

Fznamznon created this revision. Herald added a project: All. Fznamznon requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `ConvertTypeForMem` doesn't return wider type for _BitInt unless it is used in a bitfield, so no need to extend when try

[PATCH] D148457: [clangd] Support macro evaluation on hover

zyounan updated this revision to Diff 517865. zyounan added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148457/new/ https://reviews.llvm.org/D148457 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/unittes

[PATCH] D148457: [clangd] Support macro evaluation on hover

zyounan added a comment. Sorry for responding late and thank you for the good catch! I've updated the code and please feel free to leave comments. :) Comment at: clang-tools-extra/clangd/Hover.cpp:728 } + SelectionTree::createEach( + AST.getASTContext(), AST.getTokens(

[PATCH] D148457: [clangd] Support macro evaluation on hover

zyounan added a comment. Oops, an inline comment disappears accidentally. > #define PLUS_TWO + 2 > int x = 40 PLUS_TW^O; // huh, the value of "+ 2" is "42"? The reason is we're getting a `SelectionNode` with a wider range. Here is the layout of the tree: txt Built selection tree Tr

[PATCH] D146101: [clang-format] Add BracedInitializerIndentWidth option.

jp4a50 updated this revision to Diff 517868. jp4a50 added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146101/new/ https://reviews.llvm.org/D146101 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/ReleaseNotes.rst

[PATCH] D146101: [clang-format] Add BracedInitializerIndentWidth option.

jp4a50 added a comment. In D146101#4270509 , @owenpan wrote: > In D146101#4268487 , @jp4a50 wrote: > >> Would appreciate someone committing for me. > > Can you rebase it? I got a conflict in ReleaseNotes.rst. @ow

[PATCH] D149437: [clangd] Emit ChangeAnnotation label and description for include-cleaner diagnostics.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Mon

[clang] 0fb84bc - [clang] Diagnose shadowing of lambda's template parameter by a capture

Author: Mariya Podchishchaeva Date: 2023-04-28T07:26:30-04:00 New Revision: 0fb84bc7fdec1c20c2461e54d5c994939fe5b47f URL: https://github.com/llvm/llvm-project/commit/0fb84bc7fdec1c20c2461e54d5c994939fe5b47f DIFF: https://github.com/llvm/llvm-project/commit/0fb84bc7fdec1c20c2461e54d5c994939fe5b4

[PATCH] D148712: [clang] Diagnose shadowing of lambda's template parameter by a capture

This revision was automatically updated to reflect the committed changes. Closed by commit rG0fb84bc7fdec: [clang] Diagnose shadowing of lambda's template parameter by a capture (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D146389: [clang-repl][CUDA] Initial interactive CUDA support for clang-repl

SimeonEhrig added a comment. In D146389#4292984 , @tra wrote: > lib/CodeGen changes look OK to me. I can confirm the code change in CodeGen works as expected. `clang-repl` does not generate temporary files anymore, if a CUDA kernel is compiled. Compili

[PATCH] D148457: [clangd] Support macro evaluation on hover

sammccall added a comment. (This looks really cool, nice work! only a driveby comment from me I'm afraid) In D148457#4304915 , @zyounan wrote: > The dot prior to AST node kind indicates partial selection and the asterisk > indicates complete selection a

[PATCH] D149437: [clangd] Emit ChangeAnnotation label and description for include-cleaner diagnostics.

hokein added a comment. VSCode UI: - missing-include F27261997: image.png - unused-include F27262002: image.png Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149437/new/

[PATCH] D148131: Avoid unnecessarily aggressive line-breaking when using "LambdaBodyIndentation: OuterScope" with argument bin-packing.

jp4a50 added a comment. Hey @MyDeveloperDay @owenpan . I'd appreciate if you guys have time to consider this change. It's the last significant issue my team and I are tracking that's blocking our adoption of clang-format for multiple codebases that use KJ

[PATCH] D148462: [clang-tidy] Ignore declarations in bugprone-exception-escape

isuckatcs accepted this revision. isuckatcs added a comment. This revision is now accepted and ready to land. I think there's no point of holding back this patch. Even though I'm not 100% sure we want this change, I say let's merge it and see how our users react. It's a one line change anyway, s

[PATCH] D146054: [RISCV] Add --print-supported-extensions and -march=help support

kito-cheng added inline comments. Comment at: clang/tools/driver/cc1_main.cpp:187-188 +/// Print supported extensions of the given target. +static int PrintSupportedExtensions(std::string TargetStr) { + llvm::riscvMarchHelp(); + Plz make sure only RISC-V print t

[PATCH] D148223: [SiFive] Support C intrinsics for xsfvcp extension.

kito-cheng accepted this revision. kito-cheng added a comment. LGTM, but IMO the title should still contain [RISCV][clang] Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148223/new/ https://reviews.llvm.org/D148223 _

[PATCH] D148308: [RISCV] Split out SiFive VCIX C intrinsics from riscv_vector.td

kito-cheng accepted this revision. kito-cheng added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148308/new/ https://reviews.llvm.org/D148308 __

[PATCH] D149144: [clang][dataflow] Eliminate intermediate `ReferenceValue`s from `Environment::DeclToLoc`.

ymandel accepted this revision. ymandel added a comment. Really nice patch. Thanks for this improvement! Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:307-311 + auto &ParamLoc = + createStorageLocation(ParamDecl->getType().getNonReferenceTyp

[PATCH] D149361: [profiling] Improve error message for raw profile header mismatches

Dinistro added inline comments. Comment at: llvm/unittests/ProfileData/InstrProfTest.cpp:1359 auto RawProfileReaderOrErr = InstrProfReader::create(std::move(RawProfile)); ASSERT_TRUE(InstrProfError::take(RawProfileReaderOrErr.takeError()) == instrprof_error::

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

erichkeane added a comment. Hey! I wish you'd given me a chance to review this fix version before committing! I don't have concerns now looking at it, however please add a release note, since this is fixing a whole-bunch of regressions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[clang] d75e70d - [AArch64] Add preserve_all calling convention.

Author: Daniel Kiss Date: 2023-04-28T14:55:38+02:00 New Revision: d75e70d7ae1f84cea71f0be5fbee836bdc22138a URL: https://github.com/llvm/llvm-project/commit/d75e70d7ae1f84cea71f0be5fbee836bdc22138a DIFF: https://github.com/llvm/llvm-project/commit/d75e70d7ae1f84cea71f0be5fbee836bdc22138a.diff L

[PATCH] D135652: [AArch64] Add preserve_all calling convention.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd75e70d7ae1f: [AArch64] Add preserve_all calling convention. (authored by danielkiss). Herald added a project: clang. Herald added a subscriber: cfe-

[PATCH] D149163: [NFC][CLANG] Fix coverity remarks about large copy by values

Manna marked 4 inline comments as done. Manna added inline comments. Comment at: clang/lib/CodeGen/CGGPUBuiltin.cpp:128 -bool containsNonScalarVarargs(CodeGenFunction *CGF, CallArgList Args) { +bool containsNonScalarVarargs(CodeGenFunction *CGF, const CallArgList &Args) { re

[PATCH] D148822: [clang][BFloat] Avoid redefining bfloat16_t in arm_neon.h

simonbutcher added a comment. I can't see anything wrong with this patch and it looks pretty straightforward to me, but is it necessary? '-Wtypedef-redefinition' is documented as not applying to system headers

[PATCH] D148663: [RFC][clangd] Use interpolation for CDB pushed via LSP protocol

ilya-biryukov added a comment. In D148663#4301589 , @DmitryPolukhin wrote: > And, if they do so, this diff will just does nothing because there is an > exact match. It starts playing only if client provided partial CDB and > inference is required. (hy

[PATCH] D149444: [ARM] Allow codegen for Armv6m eXecute-Only (XO) sections

stuij created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. stuij requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clang, LLVM. This patch moves the overall lower-bound arch res

[PATCH] D146269: MIPS: allow o32 abi with 64bit CPU and 64 abi with 32bit triple

wzssyqa updated this revision to Diff 517903. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146269/new/ https://reviews.llvm.org/D146269 Files: clang/lib/Basic/Targets/Mips.cpp clang/test/Driver/mips-abi.c clang/test/Driver/mips-cpu64abi32.c llvm/lib/Target/Mips/MipsSubtarget.cpp

[PATCH] D147626: [clang] Reject flexible array member in a union in C++

Fznamznon added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147626/new/ https://reviews.llvm.org/D147626 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D149447: [clang][analyzer] Improve documentation of StdCLibraryFunctionArgs checker (NFC)

balazske created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a project: All. balazske requested review of this revision. Herald added a p

[PATCH] D149436: [clang] Do not attempt to zero-extend _BitInt(1) when not required

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. This looks right to me, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149436/new/ https://reviews.llvm.org/D149436

[PATCH] D148663: [RFC][clangd] Use interpolation for CDB pushed via LSP protocol

DmitryPolukhin added a comment. In D148663#4305202 , @ilya-biryukov wrote: > In D148663#4301589 , > @DmitryPolukhin wrote: > >> And, if they do so, this diff will just does nothing because there is an >> exact

[PATCH] D149364: [CUDA] Temporarily undefine __noinline__ when including bits/shared_ptr_base.h

yaxunl accepted this revision. yaxunl added a comment. LGTM. This issue does not affect HIP as HIP headers have removed `__noinline__` as a macro since https://reviews.llvm.org/D124866 and `__attribute__((__noinline__))` is equivalent to `__attribute__((noinline))` for HIP. Repository: rG

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis updated this revision to Diff 517921. TIFitis added a comment. Rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146557/new/ https://reviews.llvm.org/D146557 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp llvm/include/llvm/Frontend/O

[PATCH] D146557: [MLIR][OpenMP] Refactoring how map clause is processed

TIFitis planned changes to this revision. TIFitis added a comment. @kiranchandramohan I am in the process of submitting a new patch for review which moves the map processing from Clang Codegen to OMPIRBuilder. Once that is moved we can just use that for dealing with the map operands. Thus puttin

[PATCH] D148822: [clang][BFloat] Avoid redefining bfloat16_t in arm_neon.h

dim added a comment. In D148822#4305188 , @simonbutcher wrote: > I can't see anything wrong with this patch and it looks pretty > straightforward to me, but is it necessary? > > '-Wtypedef-redefinition' is documented as not applying to system headers >

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

aaron.ballman added inline comments. Comment at: clang/include/clang/Interpreter/Interpreter.h:96 + + size_t getEffectivePTUSize() const; + It looks like this can be private? Also, just a note (not something you have to deal with in this review), the local nam

[PATCH] D149259: [analyzer][NFC] Use std::optional instead of custom "empty" state

steakhal added a comment. Sure, Ill look at this on Tuesday. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149259/new/ https://reviews.llvm.org/D149259 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D149456: Basic documentation of -mrecip=... option

tim.schmielau created this revision. Herald added a project: All. tim.schmielau requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The documentation is still rather terse because it needs to fit onto a single line of clang --help output. But a

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

cor3ntin added a subscriber: rsmith. cor3ntin added a comment. @rsmith @hubert.reinterpretcast do you see any reason not to go ahead with this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149276/new/ https://reviews.llvm.org/D149276

[PATCH] D142967: [clangd] Introduce source.organizeImports code action.

hokein updated this revision to Diff 517948. hokein added a comment. rebase and polish the implementation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142967/new/ https://reviews.llvm.org/D142967 Files: clang-tools-extra/clangd/ClangdLSPServer

[PATCH] D149259: [analyzer][NFC] Use std::optional instead of custom "empty" state

donat.nagy marked an inline comment as done. donat.nagy added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149259/new/ https://reviews.llvm.org/D149259 ___ cfe-commits mailing list cf

[PATCH] D149458: [Driver] Pass --target2= to linker from baremetal toolchain

miyuki created this revision. miyuki added reviewers: peter.smith, phosek, michaelplatings. Herald added subscribers: abidh, kristof.beyls. Herald added a project: All. miyuki requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Accordin

[PATCH] D149162: [Clang][OpenMP][IRBuilder] Move registerTargetGlobalVariable & getAddrOfDeclareTargetVar into the OMPIRBuilder

agozillon updated this revision to Diff 517958. agozillon added a comment. - [Clang][OpenMP][IRBuilder] Tidy up function calls with helpful reviewer advice - [Clang][OpenMP][IRBuilder] Replace all getTargetEntryUniqueInfo with IRBuilder version - [Clang][OpenMP][IRBuilder] Run clang-format and ti

[PATCH] D149162: [Clang][OpenMP][IRBuilder] Move registerTargetGlobalVariable & getAddrOfDeclareTargetVar into the OMPIRBuilder

agozillon added a comment. rebased and clang-formatted the *hopefully* final file clang-format is angry at. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149162/new/ https://reviews.llvm.org/D149162 ___

[PATCH] D149458: [Driver] Pass --target2= to linker from baremetal toolchain

peter.smith accepted this revision. peter.smith added a comment. This revision is now accepted and ready to land. LGTM. This is consistent with the target2 support that I added to LLD several years ago in https://reviews.llvm.org/D25684 will be good to give some time for other reviewers to add a

[PATCH] D147626: [clang] Reject flexible array member in a union in C++

aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:58 Clang will only search for std::coroutine_traits for coroutines then. +- Clang doesn't accept flexible array members in unions in C++ anymore. Comment at: cla

[PATCH] D149460: [analyzer] ArrayBoundCheckerV2: suppress false positives from ctype macros

donat.nagy created this revision. donat.nagy added reviewers: gamesh411, Szelethus, steakhal, dkrupp. Herald added subscribers: manas, ASDenysPetrov, martong, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. don

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

shafik added a comment. I see that we do have an issue but so far the examples in the tests don't feel very natural and so I would like to understand if there is a larger motivation here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149276/new/

[PATCH] D149193: [Driver] Add -dumpdir and change -gsplit-dwarf .dwo names for linking

dblaikie added a comment. In D149193#4302981 , @scott.linder wrote: > I am OK to give LGTM, assuming the other reviewers don't still have > reservations? Some - planning to get to this next week. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D149461: [NFC] ][CLANG] Fix static code analyzer concerns

Manna created this revision. Manna added a reviewer: tahonermann. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Manna requested review of this revision. Herald added a reviewer: jdoerfert. Herald added sub

[PATCH] D149461: [NFC] ][CLANG] Fix static code analyzer concerns

Manna updated this revision to Diff 517964. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149461/new/ https://reviews.llvm.org/D149461 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp clang/lib/Serialization/ASTReader.cpp clang/lib/Serialization/ASTWriter.cpp Index: clang/lib/Seri

[PATCH] D148381: [WIP][Clang] Add element_count attribute

nickdesaulniers added inline comments. Comment at: clang/include/clang/Basic/Attr.td:4170 +private: + mutable SmallVector CountFieldRanges; +public: `mutable`...my least favorite keyword in C++. If you drop `const` from `addCountFieldSourceRange` t

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

cor3ntin added a comment. In D149276#4305780 , @shafik wrote: > I see that we do have an issue but so far the examples in the tests don't > feel very natural and so I would like to understand if there is a larger > motivation here. The context is that

[PATCH] D149458: [Driver] Pass --target2= to linker from baremetal toolchain

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149458/new/ https://reviews.llvm.org/D149458 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D149405: [Clang][Doc] Added an open project for improving command line docs

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. Thank you, this is a great suggestion! Just some minor wording changes, but otherwise LGTM. Comment at: clang/www/OpenProjects.html:40-44 other relevant

[PATCH] D148370: [Clang][Flang][OpenMP] Add loadOffloadInfoMetadata and createOffloadEntriesAndInfoMetadata into OMPIRBuilder's finalize and initialize

agozillon updated this revision to Diff 517968. agozillon added a comment. - Move hostIRFilePath initialize invocation to ModuleTranslation.cpp to respect TargetOp patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148370/new/ https://reviews.llv

[PATCH] D149464: [clang][dataflow] Expose DataflowAnalysisContext from DataflowEnvironment.

bazuzi created this revision. bazuzi added reviewers: ymandel, gribozavr2. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. bazuzi requested review of this revision. Herald added a project: clang. This will eliminate the need for more pass-th

[PATCH] D148370: [Clang][Flang][OpenMP] Add loadOffloadInfoMetadata and createOffloadEntriesAndInfoMetadata into OMPIRBuilder's finalize and initialize

agozillon added a comment. rebase to see if it clears up the buildbot issue (currently the failing test appears to be unrelated and passes on my machine after a rebase) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148370/new/ https://reviews.llvm

[PATCH] D149464: [clang][dataflow] Expose DataflowAnalysisContext from DataflowEnvironment.

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Thanks and welcome! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149464/new/ https://reviews.llvm.org/D149464 ___

[clang] 15f0491 - [NFC] Fix a mem-sanitizer found issue in AutoType

Author: Erich Keane Date: 2023-04-28T10:09:26-07:00 New Revision: 15f0491d3963d91202aef659acc20f59aa83fae7 URL: https://github.com/llvm/llvm-project/commit/15f0491d3963d91202aef659acc20f59aa83fae7 DIFF: https://github.com/llvm/llvm-project/commit/15f0491d3963d91202aef659acc20f59aa83fae7.diff L

[PATCH] D149361: [profiling] Improve error message for raw profile header mismatches

paquette added a comment. Sorry for the inconvenience and thanks for the fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149361/new/ https://reviews.llvm.org/D149361 ___ cfe-commits mailing list cfe-c

[PATCH] D147626: [clang] Reject flexible array member in a union in C++

Fznamznon added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:6241-6244 def ext_flexible_array_empty_aggregate_ms : Extension< "flexible array member %0 in otherwise empty " "%select{struct|interface|union|class|enum}1 is a Microsoft extensi

[PATCH] D149461: [NFC] ][CLANG] Fix static code analyzer concerns

Manna added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:4428 // Mark selectors as out of date. - for (auto Sel : SelectorGeneration) + for (const auto &Sel : SelectorGeneration) SelectorOutOfDate[Sel.first] = true; Here Object of

[PATCH] D149458: [Driver] Pass --target2= to linker from baremetal toolchain

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG024bb62ffd07: [Driver] Pass --target2= to linker from baremetal toolchain (authored by miyuki). Repository: rG LLVM Github Monorepo CHANGES SINCE

[clang] 024bb62 - [Driver] Pass --target2= to linker from baremetal toolchain

Author: Mikhail Maltsev Date: 2023-04-28T18:30:49+01:00 New Revision: 024bb62ffd072e9a90343e88c92e40b5849c2632 URL: https://github.com/llvm/llvm-project/commit/024bb62ffd072e9a90343e88c92e40b5849c2632 DIFF: https://github.com/llvm/llvm-project/commit/024bb62ffd072e9a90343e88c92e40b5849c2632.dif

[PATCH] D149461: [NFC] ][CLANG] Fix static code analyzer concerns

Manna added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:7696 if (isa(DC)) { -for (auto Lexical : TULexicalDecls) +for (const auto &Lexical : TULexicalDecls) Visit(Lexical.first, Lexical.second); This returns `std::vector`

[PATCH] D147626: [clang] Reject flexible array member in a union in C++

Fznamznon updated this revision to Diff 517985. Fznamznon edited the summary of this revision. Fznamznon added a comment. Apply some of the comments, rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147626/new/ https://reviews.llvm.org/D147626

[clang-tools-extra] a7b4fd9 - [clangd] Hover: resolve forwarding parameters for CalleeArgInfo

Author: Tom Praschan Date: 2023-04-28T21:46:32+02:00 New Revision: a7b4fd953f44b790f8832a5b57d7598bd12adfb2 URL: https://github.com/llvm/llvm-project/commit/a7b4fd953f44b790f8832a5b57d7598bd12adfb2 DIFF: https://github.com/llvm/llvm-project/commit/a7b4fd953f44b790f8832a5b57d7598bd12adfb2.diff

[PATCH] D147846: [clangd] Hover: resolve forwarding parameters for CalleeArgInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rGa7b4fd953f44: [clangd] Hover: resolve forwarding parameters for CalleeArgInfo (authored by tom-anders). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147846/

[PATCH] D149272: [clang] Call printName to get name of Decl

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but please add a release note when landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149272/new/ https://reviews.llvm.o

[PATCH] D147847: [clangd] Hover: Add CalleeArgInfo for constructor expressions

tom-anders updated this revision to Diff 517994. tom-anders marked an inline comment as done. tom-anders added a comment. Use ArrayRef instead of SmallVector to avoid copy (also fix 2 typos in the comment below) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D147626: [clang] Reject flexible array member in a union in C++

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:6241-6244 def ext_flexible_array_empty_aggregate_ms : Extension< "flexible array member %0 in otherwise empty " "%select{struct|interface|union|class|enum}1 is a Microsoft ext

[PATCH] D147847: [clangd] Hover: Add CalleeArgInfo for constructor expressions

tom-anders added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:986 + const FunctionDecl *FD = nullptr; + llvm::SmallVector Args; + nridge wrote: > tom-anders wrote: > > Unfortunately, while CallExpr and CXXConstructExpr basically have the same

[PATCH] D143112: [clang] Support parsing comments without ASTContext

tom-anders added a comment. (ping) Does this make sense or are more adjustments needed? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143112/new/ https://reviews.llvm.org/D143112 ___ cfe-commits mailing

[PATCH] D149405: [Clang][Doc] Added an open project for improving command line docs

xgupta updated this revision to Diff 517996. xgupta added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149405/new/ https://reviews.llvm.org/D149405 Files: clang/www/OpenProjects.html Index: clang/www/OpenProjects.ht

[clang] a704854 - [Clang][Doc] Added an open project for improving command line docs

Author: Shivam Gupta Date: 2023-04-28T23:32:37+05:30 New Revision: a70485493803d2e22cbc79184b78861b098ba416 URL: https://github.com/llvm/llvm-project/commit/a70485493803d2e22cbc79184b78861b098ba416 DIFF: https://github.com/llvm/llvm-project/commit/a70485493803d2e22cbc79184b78861b098ba416.diff

[PATCH] D149405: [Clang][Doc] Added an open project for improving command line docs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. xgupta marked an inline comment as done. Closed by commit rGa70485493803: [Clang][Doc] Added an open project for improving command line docs (authored by xgupta). Repo

[PATCH] D149405: [Clang][Doc] Added an open project for improving command line docs

xgupta added a comment. In D149405#4305856 , @aaron.ballman wrote: > Thank you, this is a great suggestion! Just some minor wording changes, but > otherwise LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D146654: [clang] replaces numeric SARIF ids with heirarchical names

Endill added inline comments. Comment at: clang/lib/Frontend/SARIFDiagnostic.cpp:51-52 + Diag->getDiags()->getDiagnosticIDs()->getStableName(Diag->getID()).str(); + std::replace(StableName.begin(), StableName.end(), '_', '.'); + SarifRule Rule = SarifRule::create().setRule

[PATCH] D146654: [clang] replaces numeric SARIF ids with heirarchical names

cjdb added inline comments. Comment at: clang/lib/Frontend/SARIFDiagnostic.cpp:51-52 + Diag->getDiags()->getDiagnosticIDs()->getStableName(Diag->getID()).str(); + std::replace(StableName.begin(), StableName.end(), '_', '.'); + SarifRule Rule = SarifRule::create().setRuleId

[PATCH] D149464: [clang][dataflow] Expose DataflowAnalysisContext from DataflowEnvironment.

bazuzi added a comment. Thanks! Seems like you have commit access, Yitzie; could you commit this for me as "Samira Bazuzi "? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149464/new/ https://reviews.llvm.org/D149464 __

  1   2   >