[PATCH] D148489: [clangd] Implement configs to stop clangd produce a certain semantic tokens

daiyousei-qz added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:1281 } +std::optional +highlightingKindFromString(llvm::StringRef Name) { I'm not sure if we should parse the enums here or in parsing configs using `EnumSwitch`.

[PATCH] D148474: [Clang] Fix ResolveConstructorOverload to not select a conversion function if we are going use copy elision

shafik updated this revision to Diff 514091. shafik marked 3 inline comments as done. shafik added a comment. - Fix up A3 test to be less malformed - Fix other test so we confirm we are attempting to call the right contructor CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148474/new/ htt

[PATCH] D148474: [Clang] Fix ResolveConstructorOverload to not select a conversion function if we are going use copy elision

shafik added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:746 + diag::note_template_class_instantiation_here) +<< CTD << Active->InstantiationRange; } else { rsmith wrote: > This diagnostic won't i

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

xgupta updated this revision to Diff 514093. xgupta added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148439/new/ https://reviews.llvm.org/D148439 Files: clang/tools/clang-rename/ClangRename.cpp Index: clang/tools/

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

xgupta marked an inline comment as done. xgupta added inline comments. Comment at: clang/tools/clang-rename/ClangRename.cpp:130 + } else { +errs() << "clang-rename: No input provided.\n"; +return 1; kbobyrev wrote: > Probably something like "input must b

[clang] 7261991 - [clang-rename] Exit gracefully when no input provided

Author: Shivam Gupta Date: 2023-04-17T10:23:53+05:30 New Revision: 726199146a0bb53315ade042e759c65e6d96d556 URL: https://github.com/llvm/llvm-project/commit/726199146a0bb53315ade042e759c65e6d96d556 DIFF: https://github.com/llvm/llvm-project/commit/726199146a0bb53315ade042e759c65e6d96d556.diff

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. xgupta marked an inline comment as done. Closed by commit rG726199146a0b: [clang-rename] Exit gracefully when no input provided (authored by xgupta). Repository: rG

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

dyung added a comment. Is there a reason a test was not added with this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148439/new/ https://reviews.llvm.org/D148439 ___ cfe-commits mailing list cfe

[clang] 06387f9 - Revert "[clang-rename] Exit gracefully when no input provided"

Author: Shivam Gupta Date: 2023-04-17T10:31:40+05:30 New Revision: 06387f94cfdf6bbd37ac3b925a50410e11a1fc9d URL: https://github.com/llvm/llvm-project/commit/06387f94cfdf6bbd37ac3b925a50410e11a1fc9d DIFF: https://github.com/llvm/llvm-project/commit/06387f94cfdf6bbd37ac3b925a50410e11a1fc9d.diff

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

xgupta added a comment. In D148439#4272810 , @dyung wrote: > Is there a reason a test was not added with this change? Sorry, I missed that. Adding. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148439/new/

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

dyung added a comment. This change is also causing 33 test failures on a build bot https://lab.llvm.org/buildbot/#/builders/139/builds/39267 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148439/new/ https://reviews.llvm.org/D148439 __

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

xgupta added a comment. In D148439#4272813 , @dyung wrote: > This change is also causing 33 test failures on a build bot > https://lab.llvm.org/buildbot/#/builders/139/builds/39267 Yes, checking for the reason, and honestly I never tried to run clang-re

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov updated this revision to Diff 514095. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://reviews.llvm.org/D146178 Files: clang/include/clang/Sema/Template.h clang/lib/Sema/SemaConcept.cpp clang/lib/Sema/Se

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added a comment. https://github.com/llvm/llvm-project/issues/62110 is still a blocker for this diff though (haven't investigated it yet) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146178/new/ https://reviews.llvm.org/D146

[PATCH] D144634: [Clang][OpenMP] Support for Code Generation of loop bind clause

koops updated this revision to Diff 514096. koops added a comment. 1. Adding semantic test clang/test/OpenMP/loop_bind_messages.cpp. 2. Changes suggested by Alexey. 3. >Why need to drop bind clause here? The new Directives to which loop directive is being mapped to, do not contain the bind clause

[PATCH] D148496: [compiler-rt] [test] Mark dfsan tests XFAIL on glibc-2.37

mgorny created this revision. mgorny added reviewers: browneee, vitalybuka, MaskRay, thesamesam, jianzhou.zh. Herald added subscribers: Enna1, dberris. Herald added a project: All. mgorny requested review of this revision. Mark the two dfsan tests that are known to be broken on glibc-2.37 as XFAIL

[PATCH] D148439: [clang-rename] Exit gracefully when no input provided

kbobyrev added a comment. Oh, wait, I'm sorry, I didn't look into it closely :( Yeah, the `Input` file is not really needed, most of the time the users of `clang-rename` (not sure there are many with `clangd` being developed) use CLI flags for that. It's better to revert this patch. My bad, sho

[PATCH] D148496: [compiler-rt] [test] Mark dfsan tests XFAIL on glibc-2.37

thesamesam accepted this revision. thesamesam added a comment. This revision is now accepted and ready to land. Yes, please. Obviously we want to fix it properly but right now it's a known issue and it's noise when checking for regressions weekly. CHANGES SINCE LAST ACTION https://reviews.llv

[clang-tools-extra] b507bda - [clang-tidy] Add alias cppcoreguidelines-use-default-member-init

Author: Carlos Galvez Date: 2023-04-17T06:09:59Z New Revision: b507bda4552347e00197032526c7ab4a80a853c2 URL: https://github.com/llvm/llvm-project/commit/b507bda4552347e00197032526c7ab4a80a853c2 DIFF: https://github.com/llvm/llvm-project/commit/b507bda4552347e00197032526c7ab4a80a853c2.diff LOG:

[PATCH] D148460: [clang-tidy] Add alias cppcoreguidelines-use-default-member-init

This revision was automatically updated to reflect the committed changes. Closed by commit rGb507bda45523: [clang-tidy] Add alias cppcoreguidelines-use-default-member-init (authored by carlosgalvezp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148

<    1   2