[PATCH] D147194: [clang-tidy] fix concat-nest-namespace fix hint remove the macro

HerrCai0907 updated this revision to Diff 511757. HerrCai0907 added a comment. Herald added a subscriber: ChuanqiXu. update according to comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147194/new/ https://reviews.llvm.org/D147194 Files: cl

[PATCH] D147733: Set rounding_mode to tonearest in presence of a #pragma STDC FENV_ACCESS OFF.

zahiraam updated this revision to Diff 511760. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147733/new/ https://reviews.llvm.org/D147733 Files: clang/lib/Sema/SemaAttr.cpp clang/test/CodeGen/pragma-fenv_access.c Index: clang/test/CodeGen/pragma-fenv_access.c ==

[PATCH] D147175: [clang] Add __is_trivially_equality_comparable

philnik updated this revision to Diff 511762. philnik marked 2 inline comments as done. philnik added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147175/new/ https://reviews.llvm.org/D147175 Files: clang/docs/Langua

[PATCH] D147175: [clang] Add __is_trivially_equality_comparable

philnik added a comment. In D147175#4251076 , @aaron.ballman wrote: > One thing I can't quite determine is whether we expect to call this type > trait often or not. Are either of the uses in libc++ going to be instantiated > frequently? I'm trying to f

[PATCH] D147194: [clang-tidy] fix concat-nest-namespace fix hint remove the macro

HerrCai0907 updated this revision to Diff 511763. HerrCai0907 marked 4 inline comments as done. HerrCai0907 added a comment. reorder fixhint Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147194/new/ https://reviews.llvm.org/D147194 Files: clang-

[PATCH] D147194: [clang-tidy] fix concat-nest-namespace fix hint remove the macro

HerrCai0907 marked 2 inline comments as done. HerrCai0907 added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/ConcatNestedNamespacesCheck.cpp:88 + StringRef TokText = getRawStringRef(TokRange, SM, LangOpts); + if (TokText != "// namespace " + ND->getNameA

[PATCH] D147743: [Clang][NFC] Rename methods/vars to reflect their real usage

void updated this revision to Diff 511772. void added a comment. Herald added a subscriber: kadircet. Herald added a project: clang-tools-extra. Fix compilation issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147743/new/ https://reviews.llvm.o

[PATCH] D147744: [clang][Sema] Add MultiLevelTemplateArgumentList::dump()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf799901c06c0: [Clang][Sema] Add MultiLevelTemplateArgumentList::dump (authored by alexander-shaposhnikov). Changed prior to commit: https://review

[clang] f799901 - [Clang][Sema] Add MultiLevelTemplateArgumentList::dump

Author: Alexander Shaposhnikov Date: 2023-04-07T19:36:59Z New Revision: f799901c06c015cc30cf123a8f0c01f8b107669e URL: https://github.com/llvm/llvm-project/commit/f799901c06c015cc30cf123a8f0c01f8b107669e DIFF: https://github.com/llvm/llvm-project/commit/f799901c06c015cc30cf123a8f0c01f8b107669e.d

[PATCH] D147655: Implement mangling rules for C++20 concepts and requires-expressions.

rsmith added a comment. In D147655#4251042 , @aaron.ballman wrote: > In D147655#4250922 , @royjacobson > wrote: > >> In D147655#4250056 , @rsmith wrote: >> >>> There has

[PATCH] D146054: [RISCV] Add -print-supported-marchs and -march=help support

craig.topper added inline comments. Comment at: clang/lib/Driver/Driver.cpp:4236 + +// Use the -march=help flag as the dummy input to cc1. +Actions.clear(); MaskRay wrote: > Why is the code needed? Can --print-supported-extensions reuse the approach > of

[PATCH] D147802: [clangd] Handle destructors in DefineOutline tweak

njames93 updated this revision to Diff 511780. njames93 added a comment. Clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147802/new/ https://reviews.llvm.org/D147802 Files: clang-tools-extra/clangd/refactor/tweaks/DefineOutline.cpp

[PATCH] D147808: [clangd] Support defaulted destructors in Define Outline tweak

njames93 created this revision. njames93 added reviewers: sammccall, kadircet. Herald added a subscriber: arphaman. Herald added a project: All. njames93 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Som

[clang] 33cf2a3 - [NFC][clang] Fix static analyzer tool remarks about large copies by values

Author: Manna, Soumi Date: 2023-04-07T16:38:07-04:00 New Revision: 33cf2a39cb11681068b1abaa20ffe1d4d732ae38 URL: https://github.com/llvm/llvm-project/commit/33cf2a39cb11681068b1abaa20ffe1d4d732ae38 DIFF: https://github.com/llvm/llvm-project/commit/33cf2a39cb11681068b1abaa20ffe1d4d732ae38.diff

[PATCH] D147708: [NFC][clang] Fix static analyzer tool remarks about large copies by values

Manna added a comment. Thanks @erichkeane. I have committed the patch here: https://reviews.llvm.org/rG33cf2a39cb11 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147708/new/ https://reviews.llvm.org/D147708 ___ cfe-commits mailing list cfe-co

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov added a comment. I've debugged a bit what's going on in https://godbolt.org/z/7h3sPe85h we pass ForConstaintInstantiation=true and this causes us for the in-class FunctionTemplateDecl pick up the outer layer of template args (i.e. MLTAL will contain NumRetainedOuterLevels:

[PATCH] D146897: [clang:diagnostics] Turning off warn_self_assignment_overloaded for user-defined compound assignments

python3kgae updated this revision to Diff 511795. python3kgae added a comment. Update the comment done by rjmccall. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146897/new/ https://reviews.llvm.org/D146897 Files: clang/lib/Sema/SemaExpr.cpp c

[PATCH] D147782: [clang] Fix 'operator=' lookup in nested class

shafik added inline comments. Comment at: clang/lib/Sema/SemaLookup.cpp:1328 // namespace scope - SearchNamespaceScope = false; + SearchNamespaceScope = Name.getCXXOverloadedOperator() == OO_Equal; } Maybe we should also add

[PATCH] D147815: [clang][deps] Print timing information

jansvoboda11 created this revision. jansvoboda11 added a reviewer: akyrtzi. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds new `-print-timing` o

[PATCH] D146269: MIPS: allow o32 abi with 64bit CPU and 64 abi with 32bit triple

nickdesaulniers added a comment. This came up in https://lore.kernel.org/llvm/ebe3e940-b8ee-4682-a1f6-1ccf98eac...@flygoat.com/ (follow up thread, FWIW: https://lore.kernel.org/llvm/20230407102721.14814-1-jiaxun.y...@flygoat.com/) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146269/new

[PATCH] D146269: MIPS: allow o32 abi with 64bit CPU and 64 abi with 32bit triple

nickdesaulniers added a comment. In D146269#4239702 , @wzssyqa wrote: > ping @maskray is offline until Tuesday April 11. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146269/new/ https://reviews.llvm.org/D146269 __

[PATCH] D147577: [Format/ObjC] Support NS_ERROR_ENUM in ObjC language guesser

benhamilton added a comment. Filed https://github.com/llvm/llvm-project/issues/62007 on the buildkite failure (despite it being in `git-clang-format`, I'm about 98% sure it's unrelated). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147577/new/ h

[clang] 00ea679 - [Format/ObjC] Support NS_ERROR_ENUM in ObjC language guesser

Author: Ben Hamilton Date: 2023-04-07T16:10:52-06:00 New Revision: 00ea6798959d358aff9d7ef0907bbe241be7f7a4 URL: https://github.com/llvm/llvm-project/commit/00ea6798959d358aff9d7ef0907bbe241be7f7a4 DIFF: https://github.com/llvm/llvm-project/commit/00ea6798959d358aff9d7ef0907bbe241be7f7a4.diff

[PATCH] D147577: [Format/ObjC] Support NS_ERROR_ENUM in ObjC language guesser

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG00ea6798959d: [Format/ObjC] Support NS_ERROR_ENUM in ObjC language guesser (authored by benhamilton). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D147577: [Format/ObjC] Support NS_ERROR_ENUM in ObjC language guesser

MyDeveloperDay added a comment. The build machines aren’t using a latest enough version of clang-format for our local .clang-format file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147577/new/ https://reviews.llvm.org/D147577 __

[PATCH] D147815: [clang][deps] Print timing information

akyrtzi added a comment. Could you also add a `-terse` option, to avoid printing the full dependency info, if you mainly want to get the timing? Something like this: T.stopTimer(); if (PrintTiming) llvm::errs() << llvm::format( "clang-scan-deps timing: %0.2fs wall, %0.2fs process

[PATCH] D147577: [Format/ObjC] Support NS_ERROR_ENUM in ObjC language guesser

benhamilton added a subscriber: goncharov. benhamilton added a comment. In D147577#4252225 , @MyDeveloperDay wrote: > The build machines aren’t using a latest enough version of clang-format for > our local .clang-format file Thanks, that's what I figur

[clang] a046d18 - [-Wunsafe-buffer-usage] FixableGadget for handling stand alone pointers under UPC

Author: MalavikaSamak Date: 2023-04-07T15:32:19-07:00 New Revision: a046d187720137d944cece4aa4561f4bceb54e3c URL: https://github.com/llvm/llvm-project/commit/a046d187720137d944cece4aa4561f4bceb54e3c DIFF: https://github.com/llvm/llvm-project/commit/a046d187720137d944cece4aa4561f4bceb54e3c.diff

[PATCH] D143676: [-Wunsafe-buffer-usage] FixableGadget for handling stand alone pointers under UPC.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa046d1877201: [-Wunsafe-buffer-usage] FixableGadget for handling stand alone pointers under… (authored by malavikasamak). Herald added a project: cla

[clang] c530232 - [clang:diagnostics] Turning off warn_self_assignment_overloaded for user-defined compound assignments

Author: Xiang Li Date: 2023-04-07T18:33:47-04:00 New Revision: c5302325b2a62d77cf13dd16cd5c19141862fed0 URL: https://github.com/llvm/llvm-project/commit/c5302325b2a62d77cf13dd16cd5c19141862fed0 DIFF: https://github.com/llvm/llvm-project/commit/c5302325b2a62d77cf13dd16cd5c19141862fed0.diff LOG:

[PATCH] D147714: [Attr] Introduce [[clang::nonportable_musttail]] as less strict version of [[clang::musttail]]

nickdesaulniers requested changes to this revision. nickdesaulniers added a comment. This revision now requires changes to proceed. In D147714#4249274 , @efriedma wrote: > Any thoughts on diagnostics here? If I'm not mistaken, with this patch, if > you

[PATCH] D147732: [AMDGPU] Add f32 permlane{16, x16} builtin variants

arsenm requested changes to this revision. arsenm added a comment. This revision now requires changes to proceed. There is a benefit to not having bitcast noise in the IR Comment at: llvm/include/llvm/IR/IntrinsicsAMDGPU.td:1962-1963 +// llvm.amdgcn.permlanex16.f32 +def i

[PATCH] D147782: [clang] Fix 'operator=' lookup in nested class

rsmith added a comment. What *should* happen here is that the lookup for `operator=` in `Inner::invokeAssign` should walk up the enclosing `Scope`s and `DeclContext`s, traversing both the results from the `IdResolver` and the results from `DeclContext` lookups. First, we should look in the scop

[PATCH] D147782: [clang] Fix 'operator=' lookup in nested class

rsmith added a comment. Ah, I see. In D147782#4251185 , @J-Camilleri wrote: > 2. Have the `IdResolver` declarations ordered by scope, going from most > nested to least nested. This is the intended behavior. But `Sema::PushOnScopeChains` doesn't correc

[PATCH] D103929: [clang] P2085R0: Consistent defaulted comparisons

aaronpuchert added a comment. Herald added a project: All. In the meantime, this has apparently been addressed via D104478 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103929/new/ https://reviews.llvm.org/D103929 ___

[PATCH] D147823: [clang-repl] Reduce dynamic-library.cpp test to only load shared library

zhuhan0 created this revision. Herald added subscribers: hoy, wenlei. Herald added a project: All. zhuhan0 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Follow-up to the discussion in https://reviews.llvm.org/D141824. Because the purpose

[PATCH] D141824: [clang-repl] Add a command to load dynamic libraries

zhuhan0 added a comment. I've put up https://reviews.llvm.org/D147823. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141824/new/ https://reviews.llvm.org/D141824 ___ cfe-commits mailing list cfe-commits@

[PATCH] D147834: [clang][driver] Pass `-femulated-tls` through to the linker in LTO mode

paulkirth created this revision. paulkirth added reviewers: phosek, MaskRay, enh, hiraditya, vit9696. Herald added subscribers: luismarques, s.egerton, PkmX, simoncook, asb, arichardson, inglorion. Herald added a project: All. paulkirth requested review of this revision. Herald added subscribers:

[clang] 231107a - Re-apply "[ORC] LLJIT updates: ExecutorNativePlatform, default ..." with fixes.

Author: Lang Hames Date: 2023-04-08T02:40:58Z New Revision: 231107a8b5be77d1c76975b0363976ba3211fa37 URL: https://github.com/llvm/llvm-project/commit/231107a8b5be77d1c76975b0363976ba3211fa37 DIFF: https://github.com/llvm/llvm-project/commit/231107a8b5be77d1c76975b0363976ba3211fa37.diff LOG: Re

[clang-tools-extra] 92910a5 - [clang-tidy] fix concat-nest-namespace fix hint remove the macro

Author: Congcong Cai Date: 2023-04-08T06:24:26+02:00 New Revision: 92910a51b9043550cec6c9e63a5b92a15d42c665 URL: https://github.com/llvm/llvm-project/commit/92910a51b9043550cec6c9e63a5b92a15d42c665 DIFF: https://github.com/llvm/llvm-project/commit/92910a51b9043550cec6c9e63a5b92a15d42c665.diff

[PATCH] D147194: [clang-tidy] fix concat-nest-namespace fix hint remove the macro

This revision was automatically updated to reflect the committed changes. Closed by commit rG92910a51b904: [clang-tidy] fix concat-nest-namespace fix hint remove the macro (authored by HerrCai0907). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14719

[PATCH] D147823: [clang-repl] Reduce dynamic-library.cpp test to only load shared library

v.g.vassilev added a comment. Could we use yaml2obj instead of uploading the binary? I see other tests using it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147823/new/ https://reviews.llvm.org/D147823 __

[PATCH] D147836: [clang] Add test for CWG1822

Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : CWG1822 is resolved by specifying that the body

[PATCH] D147733: Set rounding_mode to tonearest in presence of a #pragma STDC FENV_ACCESS OFF.

pengfei accepted this revision. pengfei added a comment. This revision is now accepted and ready to land. The change makes more sense to me, thanks! Comment at: clang/test/CodeGen/pragma-fenv_access.c:239 +// CHECK-LABEL: @func_20 +// STRICT: call float @llvm.experimental.const

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

ccotter updated this revision to Diff 511847. ccotter added a comment. - Rename Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146921/new/ https://reviews.llvm.org/D146921 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/CMakeLists.txt cla

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

ccotter added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/forwarding-reference-param-not-forwarded.cpp:138 + +} // namespace negative_cases ccotter wrote: > PiotrZSL wrote: > > what about when someone uses std::move

[PATCH] D147839: [clang] Add test for CWG2007

Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : CWG2007 is resolved by skipping unqualified look

[PATCH] D147840: [clang][Interp] Handle DiscardResult for DeclRef- and ParenExprs

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, tahonermann, shafik, erichkeane. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues

[PATCH] D147840: [clang][Interp] Handle DiscardResult for DeclRef- and ParenExprs

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:240 +return this->emitPop(*T, PE); + } + Next time this pattern shows up, I need to add a convenience function. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

alexander-shaposhnikov updated this revision to Diff 511854. alexander-shaposhnikov added a comment. This version is partially based on https://reviews.llvm.org/D147722. The case with self-friendship is problematic (had to add a workaround, any suggestions would be greatly appreciated). Added mor

[clang] e7f55bb - [clang][Interp][NFCI] Call* ops don't modify the PC

Author: Timm Bäder Date: 2023-04-08T08:49:22+02:00 New Revision: e7f55bbdb880eb0c096b05d915ee920fe1f2fb98 URL: https://github.com/llvm/llvm-project/commit/e7f55bbdb880eb0c096b05d915ee920fe1f2fb98 DIFF: https://github.com/llvm/llvm-project/commit/e7f55bbdb880eb0c096b05d915ee920fe1f2fb98.diff LO

<    1   2