[PATCH] D145138: [clang-tidy] Implement FixIts for C arrays

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/AvoidCArraysCheck.cpp:588 +: ClangTidyCheck(Name, Context), + IncludeInserter(Options.getLocalOrGlobal("IncludeStyle", + utils::IncludeSo

[PATCH] D141215: [clang-repl] Introduce Value to capture expression results

v.g.vassilev added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:554 +// Otherwise, eat the semicolon. +ExpectAndConsumeSemi(diag::err_expected_semi_after_expr); + } We seem to have more than one call to `ExpectAndConsumeSemi(diag::err_expe

[PATCH] D147377: [clang-format] Don't allow variable decls to have trailing return arrows

owenpan added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1922 } else if (Current.is(tok::arrow) && AutoFound && (Line.MustBeDeclaration || Line.InPPDirective) && Current.NestingLevel == 0 && It seems we c

[PATCH] D147377: [clang-format] Don't allow variable decls to have trailing return arrows

rymiel added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:1922 } else if (Current.is(tok::arrow) && AutoFound && (Line.MustBeDeclaration || Line.InPPDirective) && Current.NestingLevel == 0 && owenpan wrote:

[PATCH] D147377: [clang-format] Don't allow variable decls to have trailing return arrows

rymiel updated this revision to Diff 510315. rymiel marked an inline comment as done. rymiel added a comment. Use MightBeFunctionDecl instead Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147377/new/ https://reviews.llvm.org/D147377 Files: clang

[PATCH] D147377: [clang-format] Don't allow variable decls to have trailing return arrows

rymiel marked an inline comment as done. rymiel added inline comments. Comment at: clang/unittests/Format/TokenAnnotatorTest.cpp:1493 + + Tokens = annotate("auto foo() -> auto { return Val; }"); + ASSERT_EQ(Tokens.size(), 12u) << Tokens; owenpan wrote: > Can th

[PATCH] D147377: [clang-format] Don't allow variable decls to have trailing return arrows

rymiel updated this revision to Diff 510317. rymiel marked an inline comment as done. rymiel edited the summary of this revision. rymiel added a comment. update commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147377/new/ https://review

[PATCH] D142688: [Clang][Driver] Handle LoongArch multiarch tuples

xen0n updated this revision to Diff 510320. xen0n added a comment. Rebase and reflect the Toolchain Conventions change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142688/new/ https://reviews.llvm.org/D142688 Files: clang/lib/Driver/ToolChains

[clang] aeee4eb - Stop modifying trailing return types.

Author: Richard Smith Date: 2023-04-02T01:41:49-07:00 New Revision: aeee4ebd689171c963aa5d973e14cb6e731eb147 URL: https://github.com/llvm/llvm-project/commit/aeee4ebd689171c963aa5d973e14cb6e731eb147 DIFF: https://github.com/llvm/llvm-project/commit/aeee4ebd689171c963aa5d973e14cb6e731eb147.diff

[PATCH] D147281: Stop modifying trailing return types.

This revision was automatically updated to reflect the committed changes. Closed by commit rGaeee4ebd6891: Stop modifying trailing return types. (authored by rsmith). Changed prior to commit: https://reviews.llvm.org/D147281?vs=509840&id=510321#toc Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D142688: [Clang][Driver] Handle LoongArch multiarch tuples

xen0n marked 5 inline comments as done. xen0n added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/LoongArch.cpp:66 + default: +return IsLA32 ? "ilp32d" : "lp64d"; + } xry111 wrote: > SixWeining wrote: > > Better to be `f`? (Probably most 32-

[PATCH] D146042: [clang-format] Fix numerous issues with "LambdaBodyIndentation: OuterScope" option

owenpan added a comment. In D146042#4204651 , @jp4a50 wrote: > I'm confident that the patch will indent all those examples correctly when > they are at block scope which is the only place those snippets will actually > be valid code. I added an exceptio

[PATCH] D142688: [Clang][Driver] Handle LoongArch multiarch tuples

xen0n updated this revision to Diff 510333. xen0n marked an inline comment as done. xen0n added a comment. Rebase and add tests, also use Twine for concatenating strings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142688/new/ https://reviews.llvm

[PATCH] D142688: [Clang][Driver] Handle LoongArch multiarch tuples

xen0n marked 2 inline comments as done. xen0n added inline comments. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:41 /// so we provide a rough mapping here. std::string Linux::getMultiarchTriple(const Driver &D, const llvm::Triple &Ta

[PATCH] D147411: [clang-tidy] Fix readability-static-accessed-through-instance check for anonymous structs

AMS21 created this revision. AMS21 added reviewers: PiotrZSL, njames93, Eugene.Zelenko. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. AMS21 requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Previ

[PATCH] D147411: [clang-tidy] Fix readability-static-accessed-through-instance check for anonymous structs

AMS21 added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/StaticAccessedThroughInstanceCheck.cpp:78 + // Ignore anonymous structs/classes + if (StringRef(BaseTypeName).contains("(unnamed ")) +return; I wonder if there's a cleaner an

[clang] 806b74b - [HIP] clang should pass `-mno-amdgpu-ieee` to -cc1

Author: Yaxun (Sam) Liu Date: 2023-04-02T08:11:17-04:00 New Revision: 806b74b0de6e7354033ec36c833d43ca8ff13fa7 URL: https://github.com/llvm/llvm-project/commit/806b74b0de6e7354033ec36c833d43ca8ff13fa7 DIFF: https://github.com/llvm/llvm-project/commit/806b74b0de6e7354033ec36c833d43ca8ff13fa7.dif

[PATCH] D145721: [HIP] clang should pass `-mno-amdgpu-ieee` to -cc1

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG806b74b0de6e: [HIP] clang should pass `-mno-amdgpu-ieee` to -cc1 (authored by yaxunl). Herald added a project: clang. Repository: rG LLVM Github M

[PATCH] D146386: [MS ABI] Fix mangling references to declarations.

bolshakov-a updated this revision to Diff 510343. bolshakov-a edited the summary of this revision. bolshakov-a added a comment. Mangle array subscripts and base class members in references to subobjects. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146386/new/ https://reviews.llvm.org/

[clang] 6aa74ae - [HIP] Supports env var HIP_PATH

Author: Yaxun (Sam) Liu Date: 2023-04-02T08:46:19-04:00 New Revision: 6aa74ae29ffc01b486798552672171f5a622fc2a URL: https://github.com/llvm/llvm-project/commit/6aa74ae29ffc01b486798552672171f5a622fc2a DIFF: https://github.com/llvm/llvm-project/commit/6aa74ae29ffc01b486798552672171f5a622fc2a.dif

[PATCH] D145391: [HIP] Supports env var HIP_PATH

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6aa74ae29ffc: [HIP] Supports env var HIP_PATH (authored by yaxunl). Herald added a project: clang. Changed prior to commit: https://reviews.llvm.o

[PATCH] D146386: [MS ABI] Fix mangling references to declarations.

bolshakov-a updated this revision to Diff 510345. bolshakov-a added a comment. Minor refactoring. Don't hide function parameter with local variable. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146386/new/ https://reviews.llvm.org/D146386 Files: clang/lib/AST/MicrosoftMangle.cpp c

[PATCH] D147411: [clang-tidy] Fix readability-static-accessed-through-instance check for anonymous structs

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/StaticAccessedThroughInstanceCheck.cpp:78 + // Ignore anonymous structs/classes + if (StringRef(BaseTypeName).contains("(unnamed ")) +return; AMS21 wrote: > I wonder

[PATCH] D147411: [clang-tidy] Fix readability-static-accessed-through-instance check for anonymous structs

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/StaticAccessedThroughInstanceCheck.cpp:78 + // Ignore anonymous structs/classes + if (StringRef(BaseTypeName).contains("(unnamed ")) +return; carlosgalvezp wrote: > A

[PATCH] D147376: [clang-tidy] Small refactor for ExceptionAnalyzer

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147376/new/ https://reviews.llvm.org/D147376 __

[PATCH] D147194: [clang-tidy] fix concat-nest-namespace fix hint remove the macro

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/ConcatNestedNamespacesCheck.cpp:69 + } + SourceRange{ND->getBeginLoc(), Tok->getEndLoc()}.dump(SM); + return SourceRange{ND->getBeginLoc(), Tok->getEndLoc()}; Remove this debug

[PATCH] D146881: [clang-tidy] Fix findNextTokenSkippingComments & rangeContainsExpansionsOrDirectives

This revision was automatically updated to reflect the committed changes. Closed by commit rGd79715b6a09c: [clang-tidy] Fix findNextTokenSkippingComments &… (authored by PiotrZSL). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146881/new/ https://re

[clang-tools-extra] d79715b - [clang-tidy] Fix findNextTokenSkippingComments & rangeContainsExpansionsOrDirectives

Author: Piotr Zegar Date: 2023-04-02T16:05:15Z New Revision: d79715b6a09c538ac60a8259d540a94d17fbc824 URL: https://github.com/llvm/llvm-project/commit/d79715b6a09c538ac60a8259d540a94d17fbc824 DIFF: https://github.com/llvm/llvm-project/commit/d79715b6a09c538ac60a8259d540a94d17fbc824.diff LOG: [

[PATCH] D147414: [python] Expose clang_Location_isInSystemHeader

R2RT created this revision. R2RT added a reviewer: aaron.ballman. R2RT added a project: clang. Herald added a subscriber: arphaman. Herald added a project: All. R2RT requested review of this revision. Herald added a subscriber: cfe-commits. Add `is_in_system_header` property for `Location` class.

[PATCH] D147414: [python] Expose clang_Location_isInSystemHeader

R2RT added a comment. I thought about adding it into release notes, but recently Python section has got removed from ReleaseNotes.rst, so I am not sure what to do now: https://reviews.llvm.org/D142578 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D147417: [clang-tidy] Do not emit bugprone-exception-escape warnings from coroutines

denizevrenci created this revision. denizevrenci added a reviewer: njames93. Herald added subscribers: PiotrZSL, carlosgalvezp, ChuanqiXu, xazax.hun. Herald added a project: All. denizevrenci requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cf

[PATCH] D147419: [clang-tidy] ignore NRVO const variables in performance-no-automatic-move.

gnanabit created this revision. gnanabit added a reviewer: courbet. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. gnanabit requested review of this revision. Herald added a project: clang-tools-extra. Herald added a sub

[PATCH] D147419: [clang-tidy] ignore NRVO const variables in performance-no-automatic-move.

gnanabit updated this revision to Diff 510374. gnanabit added a comment. Fix typo in `CHECK-MESSAGES` (should warn about `obj2`, not `obj1`). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147419/new/ https://reviews.llvm.org/D147419 Files: clang

[PATCH] D147417: [clang-tidy] Do not emit bugprone-exception-escape warnings from coroutines

denizevrenci updated this revision to Diff 510378. denizevrenci added a comment. Remove line breaks in CHECK-MESSAGES lines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147417/new/ https://reviews.llvm.org/D147417 Files: clang-tools-extra/clang

[PATCH] D147417: [clang-tidy] Do not emit bugprone-exception-escape warnings from coroutines

denizevrenci updated this revision to Diff 510383. denizevrenci added a comment. Fix the line number for the warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147417/new/ https://reviews.llvm.org/D147417 Files: clang-tools-extra/clang-tidy/b

[PATCH] D147417: [clang-tidy] Do not emit bugprone-exception-escape warnings from coroutines

denizevrenci added a comment. I don't have commit access so after the review is complete, please commit this diff in my place. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147417/new/ https://reviews.llvm.org/D147417

[PATCH] D147327: [clang-format] Add option for having one port per line in Verilog

sstwcw updated this revision to Diff 510385. sstwcw added a comment. - Use lambda Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147327/new/ https://reviews.llvm.org/D147327 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Form

[PATCH] D145965: [C++20][Modules] Fix incorrect visibilities in implementation units.

iains updated this revision to Diff 510388. iains added a comment. rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145965/new/ https://reviews.llvm.org/D145965 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include/clang/S

[PATCH] D145965: [C++20][Modules] Fix incorrect visibilities in implementation units.

iains marked 2 inline comments as done. iains added a comment. I updated this because I am going to push the latest version of the `P1815` patch and that depends on the lookup changes. Comment at: clang/lib/Sema/SemaLookup.cpp:2082 +Module *DeclModule = SemaRef.getOwningMo

[PATCH] D147422: [clang-format] NFC Document the other space before colon option

sstwcw created this revision. sstwcw added reviewers: HazardyKnusperkeks, MyDeveloperDay, owenpan, rymiel. Herald added subscribers: cfe-commits, JDevlieghere. Herald added projects: All, clang, clang-format. sstwcw requested review of this revision. Herald added a comment. NOTE: Clang-Format Team

[PATCH] D146269: MIPS: allow o32 abi with 64bit CPU and 64 abi with 32bit triple

wzssyqa added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146269/new/ https://reviews.llvm.org/D146269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D145965: [C++20][Modules] Fix incorrect visibilities in implementation units.

ChuanqiXu added inline comments. Comment at: clang/lib/Sema/SemaLookup.cpp:2082 +Module *DeclModule = SemaRef.getOwningModule(D); +if (DeclModule && !DeclModule->isModuleMapModule() && +!SemaRef.isModuleUnitOfCurrentTU(DeclModule) && iains wrote:

[PATCH] D145965: [C++20][Modules] Fix incorrect visibilities in implementation units.

iains marked 2 inline comments as done. iains added inline comments. Comment at: clang/lib/Sema/SemaLookup.cpp:2082 +Module *DeclModule = SemaRef.getOwningModule(D); +if (DeclModule && !DeclModule->isModuleMapModule() && +!SemaRef.isModuleUnitOfCurrentTU(DeclModul

[PATCH] D147419: [clang-tidy] ignore NRVO const variables in performance-no-automatic-move.

courbet accepted this revision. courbet added a comment. This revision is now accepted and ready to land. Thanks for the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147419/new/ https://reviews.llvm.org/D147419

[PATCH] D147326: [clang][dataflow][NFC] Share code between Environment ctor and pushCallInternal().

mboehme updated this revision to Diff 510410. mboehme added a comment. Changes in response to review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147326/new/ https://reviews.llvm.org/D147326 Files: clang/include/clang/Analysis/FlowSens