[clang] e884e00 - [dataflow] Delete legacy aliases

Author: Sam McCall Date: 2023-03-27T09:29:53+02:00 New Revision: e884e005f36383218641a4512a89a6825059f8cf URL: https://github.com/llvm/llvm-project/commit/e884e005f36383218641a4512a89a6825059f8cf DIFF: https://github.com/llvm/llvm-project/commit/e884e005f36383218641a4512a89a6825059f8cf.diff LO

[PATCH] D146864: [dataflow] Delete legacy aliases

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe884e005f363: [dataflow] Delete legacy aliases (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D145671: [clang] Remove legacy -m(no)-code-object-v3 options

This revision was automatically updated to reflect the committed changes. Closed by commit rG30e7cd48778b: [clang] Remove legacy -m(no)-code-object-v3 options (authored by Pierre-vh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145671/new/ https:/

[clang] 30e7cd4 - [clang] Remove legacy -m(no)-code-object-v3 options

Author: pvanhout Date: 2023-03-27T09:33:59+02:00 New Revision: 30e7cd48778b3fbbf41b666f40423297c3b19d96 URL: https://github.com/llvm/llvm-project/commit/30e7cd48778b3fbbf41b666f40423297c3b19d96 DIFF: https://github.com/llvm/llvm-project/commit/30e7cd48778b3fbbf41b666f40423297c3b19d96.diff LOG:

[PATCH] D146866: [clang][ExtractAPI] Remove extra pointer indirection from declaration fragments for Obj-C lightweight generics on id

chaitanyav added a comment. @dang @ributzka Please review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146866/new/ https://reviews.llvm.org/D146866 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

sammccall updated this revision to Diff 508517. sammccall marked 4 inline comments as done. sammccall edited the summary of this revision. sammccall added a comment. Address Dmitri's comments Update demo link Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

sammccall updated this revision to Diff 508518. sammccall added a comment. Only show the filename, not the full path, to avoid overflowing the box Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146591/new/ https://reviews.llvm.org/D146591 Files:

[clang] 4a9dc94 - [clang] Test for AST Dumping of the template variables

Author: Tomasz Kamiński Date: 2023-03-27T09:53:47+02:00 New Revision: 4a9dc94d336ab0c68d718db21d1666ac19868642 URL: https://github.com/llvm/llvm-project/commit/4a9dc94d336ab0c68d718db21d1666ac19868642 DIFF: https://github.com/llvm/llvm-project/commit/4a9dc94d336ab0c68d718db21d1666ac19868642.dif

[PATCH] D145581: [clang-tidy] In C++17, callee is guaranteed to be sequenced before arguments.

PiotrZSL added a comment. And actually there is issue for this: https://github.com/llvm/llvm-project/issues/57758 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145581/new/ https://reviews.llvm.org/D145581 _

[PATCH] D146784: [clang] Test for AST Dumping of the template variables

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4a9dc94d336a: [clang] Test for AST Dumping of the template variables (authored by tomasz-kaminski-sonarsource). Repository: rG LLVM Github Monorep

[PATCH] D126959: [C++20][Modules] Introduce an implementation module.

bjope added a comment. In D126959#4222854 , @iains wrote: > In D126959#4222637 , @bjope wrote: > >> This seem to case problems when building with asan enabled >> (LLVM_USE_SANITIZER='Address'): > > investigating.

[PATCH] D146801: [clang] Fix consteval initializers of temporaries

Fznamznon updated this revision to Diff 508524. Fznamznon added a comment. Rebase, maybe this will get "pre-commit" started Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146801/new/ https://reviews.llvm.org/D146801 Files: clang/docs/ReleaseNotes

[PATCH] D146924: [clang] Add support for dollar sign in ud_suffix of numeric constants

cor3ntin added a comment. The commit message is certainly not correct, `$` is not allowed in identifiers by either the C or C++ standard and its support in compiler is hurting future evolution. that being said, given that we already do do use it in identifiers, why not in UCNs. I would like to

[PATCH] D146926: [clang-format] Add option to decorate reflowed block comments

MyDeveloperDay added a comment. no you need to run clang/doc/tools/dump_format_style.py This will regnerate ClangFormatStyleOptions.rst from the Format.h change you have here, you then need to include that rst file in the review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146449: [RISCV] Replace RISCV -> RISC-V in comments. NFC

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146449/new/ https://reviews.llvm.org/D146449 ___ cfe-

[PATCH] D146451: [RISCV] Replace RISCV->RISC-V in strings.

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. Not as compelling as user facing strings or comments that clearly refer to the RISC-V ISA rather than the "RISCV" LLVM backend. But I don't really see a good reason not to be consistent. LGTM. Rep

[PATCH] D146926: [clang-format] Add option to decorate reflowed block comments

MyDeveloperDay added inline comments. Comment at: clang/include/clang/Format/Format.h:2022 + /// \version 17 + bool DecorateReflowedComments; + you are not setting the default value for this so it could be uninitialized, you need to set that in the LLVMStyle s

[PATCH] D146188: [Clang][DOC] Add documentation in for __builtin_flt_rounds and __builtin_set_flt_rounds

xiongji90 added a comment. Hi, @rjmccall and @sepavloff In UserManual, we include a section `Controlling Floating Point Behavior`: https://github.com/llvm/llvm-project/blob/main/clang/docs/UsersManual.rst#controlling-floating-point-behavior , now we need to add a new section for floating-point

[PATCH] D142347: [NFC][Clang] Move DebugOptions to llvm/Frontend for reuse in Flang

SBallantyne updated this revision to Diff 508532. SBallantyne added a comment. Clang format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142347/new/ https://reviews.llvm.org/D142347 Files: clang/include/clang/Basic/CodeGenOptions.def clang/in

[PATCH] D146412: [NFC] Fix potential use-after-free in DumpModuleInfoAction::ExecuteAction()

Fznamznon added a comment. In D146412#4220021 , @kastiglione wrote: > I understand the potential for a use after free, since `OutputStream` is a > raw pointer, but I don't understand the fix. Okay, probably commit message is a little confusing. The pot

[PATCH] D146814: [Flang] Add debug flag to enable current debug information pass

SBallantyne updated this revision to Diff 508536. SBallantyne added a comment. Attempt 2 to add previous work as stacked patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146814/new/ https://reviews.llvm.org/D146814 Files: clang/include/clang/

[PATCH] D146924: [clang] Add support for dollar sign in ud_suffix of numeric constants

annara added a comment. After a second look at the standard, you are right. It's not in the range of any of the universal-character-names. That being said, it is allowed as an identifier by default in clang (as @tahonermann) mentioned. It also works in current versions of clang if you use the UCN

[PATCH] D144870: [Clang][DebugInfo] Emit zero size bitfields in the debug info to delimit bitfields in different allocation units.

jmmartinez updated this revision to Diff 508538. jmmartinez marked 3 inline comments as done. jmmartinez added a comment. - Took remarks into account Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144870/new/ https://reviews.llvm.org/D144870 Files:

[PATCH] D144870: [Clang][DebugInfo] Emit zero size bitfields in the debug info to delimit bitfields in different allocation units.

jmmartinez added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:1563 + + assert(PreviousBitfield->isBitField()); + probinson wrote: > Is this true for cases like > ``` > struct nonadjacent { > char a : 8; > char : 0; > int b; > char d : 8

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

4vtomat updated this revision to Diff 508539. 4vtomat added a comment. Herald added subscribers: jobnoorman, luke. Updated to spec version 20230206. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138810/new/ https://reviews.llvm.org/D138810 Files:

[PATCH] D146644: [documentation]Fixed Random Typos

samtebbs added a comment. I was about to commit it for you but think that "Random" should be removed from the title, are you OK with that? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146644/new/ https://reviews.llvm.org/D146644

[PATCH] D146644: [documentation]Fixed Random Typos

ipriyanshi1708 added a comment. Yes, I am OK with that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146644/new/ https://reviews.llvm.org/D146644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D146644: [documentation]Fixed Random Typos

This revision was automatically updated to reflect the committed changes. Closed by commit rG4071dcf3549f: [documentation] Fix Typos (authored by ipriyanshi1708, committed by samtebbs). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146644/new/ https

[PATCH] D146463: [CodeGen][RISCV] Change Shadow Call Stack Register to S11

asb added a comment. I've flagged this proposed change on Discourse (more the fact we're looking to change it, rather than the precise register we end up with). Repository: rG LLVM Github Monorepo

[PATCH] D146814: [Flang] Add debug flag to enable current debug information pass

SBallantyne updated this revision to Diff 508543. SBallantyne marked an inline comment as done. SBallantyne added a comment. Herald added subscribers: Moerafaat, zero9178, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joons

[PATCH] D146715: [NVPTX] Enforce half type support is present for builtins

jchlanda marked an inline comment as done. jchlanda added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:18313 // of its member: n*alignof(t)." -return MakeLdgLdu(Intrinsic::nvvm_ldg_global_i); - case NVPTX::BI__nvvm_ldg_h: - case NVPTX::BI__nvvm_ldg_h2:

[PATCH] D146242: [ARM] Fixing ABI mismatch for packed structs and fields

tmatheson added a comment. LGTM, but I'm not that familiar with the code that selects the alignment so it would be good to get a second opinion. Comment at: clang/lib/CodeGen/TargetInfo.cpp:5806 if (!IsWinVariadic && isHomogeneousAggregate(Ty, Base, Members)) { if (Kin

[PATCH] D146867: [Diagnostic] printing name of uninitialized subobject instead of its type

tbaeder added a comment. Yeah I think https://reviews.llvm.org/D146358 was first and this patch doesn't add much over it, correct me if I'm wrong. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146867/new/ https://reviews.llvm.org/D146867

[PATCH] D146376: Update static_assert message for redundant cases

tbaeder added a comment. Remember to upload you patches with context. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16732 +// Ignore BO_LOr operators at the toplevel. +if (Op->getOpcode() == BO_LOr) + return; You can just drop the comment and move thi

[PATCH] D145545: [clang][Interp] Fix local variable (destructor) management in loop bodies

tbaeder added a comment. Ping. Please prioritize this patch over the other interpreter patches since the others depend on it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145545/new/ https://reviews.llvm.org/D145545 ___ cfe-commits mailing

[PATCH] D144943: [clang][Interp] Implement bitcasts (WIP)

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144943/new/ https://reviews.llvm.org/D144943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D144457: [clang][Interp] Handle global composite temporaries

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144457/new/ https://reviews.llvm.org/D144457 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D144164: [clang][Interp] Handle PtrMemOps

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144164/new/ https://reviews.llvm.org/D144164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D143334: [clang][Interp] Fix diagnosing uninitialized ctor record arrays

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143334/new/ https://reviews.llvm.org/D143334 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D146030: [clang][Interp] Handle LambdaExprs

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146030/new/ https://reviews.llvm.org/D146030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D144709: [clang-format] Improve QualifierAlignment

AlexanderHederstaf added a comment. Okay thanks. If the + options works let's go with alexanderhederstaf+l...@gmail.com Thanks again for the review and answers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144709/new/ https://reviews.llvm.org/D14

[PATCH] D146814: [Flang] Add debug flag to enable current debug information pass

SBallantyne updated this revision to Diff 508552. SBallantyne marked an inline comment as done. SBallantyne added a comment. Update tests to check for warning at higher debug levels, as well as amend warning message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D146941: [clangd] Use all inputs to SystemIncludeExtractor in cache key

kadircet created this revision. kadircet added a reviewer: nridge. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Instead of pass

[PATCH] D146942: PowerPC ABI incompatibility with GNU on complex arguments

umesh.kalappa0 created this revision. umesh.kalappa0 added a reviewer: nikic. umesh.kalappa0 added projects: LLVM, clang. Herald added subscribers: StephenFan, shchenz, nemanjai. Herald added a project: All. umesh.kalappa0 requested review of this revision. Herald added a subscriber: cfe-commits.

[PATCH] D138546: Clangd: Preserve target flags in system includes extractor

kadircet added a comment. Sorry I was waiting for D139277 to land, but it seems to be stuck so sent out D146941 . Let's take a look at this again after that one lands CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1385

[clang] a826b90 - [clang] source range of variable template specialization should include initializer

Author: Tomasz Kamiński Date: 2023-03-27T12:22:06+02:00 New Revision: a826b9034bbd046a5d0708ba656a3d345d179920 URL: https://github.com/llvm/llvm-project/commit/a826b9034bbd046a5d0708ba656a3d345d179920 DIFF: https://github.com/llvm/llvm-project/commit/a826b9034bbd046a5d0708ba656a3d345d179920.dif

[PATCH] D146733: [clang] source range of variable template specialization should include initializer

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa826b9034bbd: [clang] source range of variable template specialization should include… (authored by tomasz-kaminski-sonarsource). Repository: rG L

[PATCH] D146892: [documentation]Fixed Random Typo

ayushi-8102 updated this revision to Diff 508557. ayushi-8102 added a comment. discarded changes from another commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146892/new/ https://reviews.llvm.org/D146892 Files: clang/docs/AutomaticReferenceC

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 updated this revision to Diff 508562. Michael137 added a comment. - Refine tests: - Check for type of template parameter - Add test for chained typedefs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145803/new/ https://reviews.llvm.

[PATCH] D145803: [clang][DebugInfo] Emit DW_AT_type of preferred name if available

Michael137 updated this revision to Diff 508563. Michael137 added a comment. - Fix function docstring Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145803/new/ https://reviews.llvm.org/D145803 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/lib

[PATCH] D142347: [NFC][Clang] Move DebugOptions to llvm/Frontend for reuse in Flang

kiranchandramohan accepted this revision. kiranchandramohan added a comment. This revision is now accepted and ready to land. LGTM. This refactoring helps share code between Clang and Flang. Please wait a couple of days before submitting. Additional notes in support of approval: -> The llvm comm

[PATCH] D145671: [clang] Remove legacy -m(no)-code-object-v3 options

aaron.ballman added a comment. These changes need a release note. Given that this has been deprecated, is there documentation that should have been removed as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145671/new/ https://reviews.llvm.org

[PATCH] D145581: [clang-tidy] In C++17, callee is guaranteed to be sequenced before arguments.

mboehme added a comment. In D145581#4215602 , @PiotrZSL wrote: > Switching status of review, once you will be ready with changes (or your > decision), just mark it ready for review again. Thanks, and sorry for the delayed response on this -- I've been j

[PATCH] D146591: [dataflow] add HTML logger: browse code/cfg/analysis timeline/state

sammccall added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/HTMLLogger.html:19 +Function + + gribozavr2 wrote: > Could you add the file name and line number of the start location of the > function? > > It might be helpful not only for the read

[PATCH] D146945: Add Release Note for -mcode-object-v3 removal

Pierre-vh created this revision. Pierre-vh added a reviewer: aaron.ballman. Herald added a project: All. Pierre-vh requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D146945 File

[PATCH] D145671: [clang] Remove legacy -m(no)-code-object-v3 options

Pierre-vh added a comment. In D145671#4223655 , @c wrote: > These changes need a release note. Given that this has been deprecated, is > there documentation that should have been removed as well? I can't find anything in the docs about `code-object-v3`

[PATCH] D145671: [clang] Remove legacy -m(no)-code-object-v3 options

aaron.ballman added a comment. In D145671#4223674 , @Pierre-vh wrote: > In D145671#4223655 , @c wrote: > >> These changes need a release note. Given that this has been deprecated, is >> there documentation that s

[PATCH] D146945: Add Release Note for -mcode-object-v3 removal

aaron.ballman accepted this revision. aaron.ballman added a reviewer: clang-vendors. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Adding the clang-vendors group for awareness since this technically could break some downstream (I don't expect it to given th

[PATCH] D146946: [RISCV][MC] Add support for experimental zicond extension

asb created this revision. asb added reviewers: reames, craig.topper. Herald added subscribers: jobnoorman, luke, wingo, pmatos, VincentWu, vkmr, frasercrmck, jdoerfert, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck,

[PATCH] D146867: [Diagnostic] printing name of uninitialized subobject instead of its type

aaron.ballman added a comment. (Btw, if you no longer plan to work on a patch, it's considered good form to "abandon" the patch in Phabricator. You can do this by clicking the Add Action drop-down menu and selecting Abandon Changes.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D146945: Add Release Note for -mcode-object-v3 removal

Pierre-vh added a comment. In D146945#4223677 , @aaron.ballman wrote: > LGTM! Adding the clang-vendors group for awareness since this technically > could break some downstream (I don't expect it to given that this was > deprecated, but you never know).

[PATCH] D146945: Add Release Note for -mcode-object-v3 removal

aaron.ballman added a comment. In D146945#4223702 , @Pierre-vh wrote: > In D146945#4223677 , @aaron.ballman > wrote: > >> LGTM! Adding the clang-vendors group for awareness since this technically >> could break

[clang] 4559e8e - Add Release Note for -mcode-object-v3 removal

Author: pvanhout Date: 2023-03-27T13:41:04+02:00 New Revision: 4559e8e8cd99a92ef4c02db00c0b9dc1dba86f28 URL: https://github.com/llvm/llvm-project/commit/4559e8e8cd99a92ef4c02db00c0b9dc1dba86f28 DIFF: https://github.com/llvm/llvm-project/commit/4559e8e8cd99a92ef4c02db00c0b9dc1dba86f28.diff LOG:

[PATCH] D146945: Add Release Note for -mcode-object-v3 removal

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4559e8e8cd99: Add Release Note for -mcode-object-v3 removal (authored by Pierre-vh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[clang] 5ca710a - Revert "Silence unused variable warning in NDEBUG builds"

Author: Mitch Phillips Date: 2023-03-27T05:01:53-07:00 New Revision: 5ca710ab148b0815c2b7b03fe2af643e637bbc7d URL: https://github.com/llvm/llvm-project/commit/5ca710ab148b0815c2b7b03fe2af643e637bbc7d DIFF: https://github.com/llvm/llvm-project/commit/5ca710ab148b0815c2b7b03fe2af643e637bbc7d.diff

[clang] 074f6fd - Revert "[C++20][Modules] Introduce an implementation module."

Author: Mitch Phillips Date: 2023-03-27T05:01:53-07:00 New Revision: 074f6fd61d382ff6bf108472ea701d214b02f64b URL: https://github.com/llvm/llvm-project/commit/074f6fd61d382ff6bf108472ea701d214b02f64b DIFF: https://github.com/llvm/llvm-project/commit/074f6fd61d382ff6bf108472ea701d214b02f64b.diff

[PATCH] D126959: [C++20][Modules] Introduce an implementation module.

hctim added a comment. Hi, yep, I've reverted upstream. If you could please also integrate https://reviews.llvm.org/rG8c7c1f11ffaacf762e612c65440fd2cbb58ee426 in the relanding, that would be great. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126

[PATCH] D146727: [clangd] Use expansion location for missing include diagnostics.

VitaNuo updated this revision to Diff 508586. VitaNuo marked 2 inline comments as done. VitaNuo added a comment. Address review comments. Use spelling locations for macro arguments, and expansion locations for everything else. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D146727: [clangd] Use expansion location for missing include diagnostics.

VitaNuo marked an inline comment as done. VitaNuo added a comment. Thanks for the comments! Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:382 -auto &Tokens = AST.getTokens(); -auto SpelledForExpanded = -Tokens.spelledForExpanded(Tokens.ex

[PATCH] D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

AMS21 added a comment. @PiotrZSL thanks for the quick response. I've tried to work on the `Field` test case but seem to have hit a roadblock. From what I can see the `FunctionProtoType` exception specificaion is `EST_Unevaluated` which causes it to give up because of the check on Line 41. I'm n

[PATCH] D146947: [docs][clang] Added extra information inside the flag -fsanitize=unsigned-shift-base for UndefinedBehaviorSanitizer Fix : #60712

aabhinavg created this revision. Herald added a project: All. aabhinavg requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D146947 Files: clang/docs/UndefinedBehaviorSanitizer.

[PATCH] D146326: [LinkerWrapper] Do not extract globals with no offloading language

jhuber6 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146326/new/ https://reviews.llvm.org/D146326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D146814: [Flang] Add debug flag to enable current debug information pass

awarzynski added a comment. What's the overall design goal here? 100% consistency with Clang? Could this be documented? Comment at: clang/include/clang/Driver/ToolChain.h:23 #include "llvm/ADT/StringRef.h" -#include "llvm/ADT/Triple.h" #include "llvm/Frontend/Debug/Options.h

[PATCH] D146924: [clang] Add support for dollar sign in ud_suffix of numeric constants

cor3ntin added a comment. I think it's worth pursuing and investigating as long as - We requires some prefix before the dollar ( like `_`), and `42$ is never valid - `-Wdollar-in-identifier-extension` is emitted - We have a better understanding of the current behavior for the euro sign - logical

[PATCH] D141497: [clang][Interp] Record initialization via conditional operator

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.h:182-183 + template + bool visitConditional(const AbstractConditionalOperator *E, VisitFn V); + erichkeane wrote: > tbaeder wrote: > > aaron.ballman wrote: > > > The template de

[PATCH] D146727: [clangd] Use expansion location for missing include diagnostics.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:380 +auto Loc = SM.getFileLoc(Ref.RefLocation); +auto Range = Lexer::makeFileCharRange( +CharSourceRange{SourceRange{Loc}, true}, SM, AST.getLangOpts()); --

[PATCH] D142347: [NFC][Clang] Move DebugOptions to llvm/Frontend for reuse in Flang

SBallantyne updated this revision to Diff 508617. SBallantyne added a comment. Remove references to non existing import Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142347/new/ https://reviews.llvm.org/D142347 Files: clang/include/clang/Basic/C

[PATCH] D146727: [clangd] Use expansion location for missing include diagnostics.

VitaNuo marked an inline comment as done. VitaNuo added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:380 +auto Loc = SM.getFileLoc(Ref.RefLocation); +auto Range = Lexer::makeFileCharRange( +CharSourceRange{SourceRange{Loc},

[PATCH] D146788: [clang][Interp] Fix zero-initializing of floating types

tbaeder updated this revision to Diff 508619. tbaeder marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146788/new/ https://reviews.llvm.org/D146788 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/floats.cpp Index: clang/test/AST/

[PATCH] D145579: [Clang][Flang][AMDGPU] Add support for AMDGPU to Flang driver

domada updated this revision to Diff 508618. domada retitled this revision from "[Flang][AMDGPU] Add support for AMDGPU to Flang driver" to "[Clang][Flang][AMDGPU] Add support for AMDGPU to Flang driver". domada edited the summary of this revision. domada added a comment. Rebase & applied review

[PATCH] D146727: [clangd] Use expansion location for missing include diagnostics.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:380 +auto Loc = SM.getFileLoc(Ref.RefLocation); +auto Range = Lexer::makeFileCharRange( +CharSourceRange{SourceRange{Loc}, true}, SM, AST.getLangOpts()); --

[PATCH] D146922: [clang-tidy] Fix false positve for defaulted move constructor in performance-noexcept-move-constructor

PiotrZSL added a comment. Don't waste time of Sema, no way to access it, as far as I know, it's already destroyed when checks are executed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146922/new/ https://reviews.llvm.org/D146922 ___

[PATCH] D145579: [Clang][Flang][AMDGPU] Add support for AMDGPU to Flang driver

domada added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:139-142 + // Clang does not append all target features to the clang -cc1 invocation. + // Some AMDGPU features are passed implicitly by the Clang frontend. + // That's why we need to extract impli

[PATCH] D134475: Add C++11 attribute msvc::constexpr

erichkeane added a comment. In D134475#4222805 , @RIscRIpt wrote: > I am sorry for protracting implementation. I am still interested to finish > this (if no volunteer takes over sooner). > > In D134475#4070995 ,

[PATCH] D145579: [Clang][Flang][AMDGPU] Add support for AMDGPU to Flang driver

yaxunl added a comment. LGTM about the AMDGPU TargetInfo change. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145579/new/ https://reviews.llvm.org/D145579 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D146148: Float_t and double_t types shouldn't be modified by #pragma clang fp eval_method

aaron.ballman added a comment. In D146148#4222306 , @zahiraam wrote: > In D146148#4221651 , @rjmccall > wrote: > >> In D146148#4220591 , @zahiraam >> wrote: >> >>> In D1

[PATCH] D146326: [LinkerWrapper] Do not extract globals with no offloading language

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146326/new/ https://reviews.llvm.org/D146326 __

[PATCH] D146420: Document the Clang policies on claiming support for a feature

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGce548b6130b6: Document the Clang policies on claiming support for a feature (authored by aaron.ballman). Repository: rG LLVM Github Monorepo CHAN

[clang] ce548b6 - Document the Clang policies on claiming support for a feature

Author: Aaron Ballman Date: 2023-03-27T09:55:47-04:00 New Revision: ce548b6130b675a433de7fecb37db8f3b56d5c5a URL: https://github.com/llvm/llvm-project/commit/ce548b6130b675a433de7fecb37db8f3b56d5c5a DIFF: https://github.com/llvm/llvm-project/commit/ce548b6130b675a433de7fecb37db8f3b56d5c5a.diff

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

jrmolin updated this revision to Diff 508639. jrmolin marked 2 inline comments as done. jrmolin added a comment. pulled main, re-generated the docs, then re-generated the diff. Also added a parse test and collapsed some nested `if` conditions. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D145579: [Clang][Flang][AMDGPU] Add support for AMDGPU to Flang driver

tschuett added a comment. Do you want to move the AMDGPU changes into AMDGPU.cpp next to AMD.cpp? From the conversation, there seems to be more target specific behaviours. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145579/new/ https://reviews.llvm.org/D145579 __

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

jrmolin marked an inline comment as done. jrmolin added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:4742-4748 + if (Left.is(tok::l_paren) && Style.AlwaysBreakBeforeFunctionParameters && + !Right.is(tok::r_paren) && Left.Previous) { + const FormatTo

[PATCH] D146418: Support for OpenMP 5.0 sec 2.12.7 - Declare Target initializer expressions

RitanyaB added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:2093-2115 +void ParseImplicitDeclareTargetAttr(Decl *TargetDecl) { + if (TargetDecl && TargetDecl->hasAttr() && + isa(TargetDecl)) { +VarDecl *TargetVarDecl = cast(TargetDecl); +Expr *Ex = Tar

[PATCH] D146727: [clangd] Use expansion location for missing include diagnostics.

VitaNuo updated this revision to Diff 508645. VitaNuo marked 3 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146727/new/ https://reviews.llvm.org/D146727 Files: clang-too

[PATCH] D142347: [NFC][Clang] Move DebugOptions to llvm/Frontend for reuse in Flang

awarzynski accepted this revision. awarzynski added a comment. LGTM, thanks! As @kiranchandramohan points out, this is in line with the overall direction that we agreed on a while back. This change will very likely affect various downstream consumers - it would be helpful to advertise this with

[PATCH] D146727: [clangd] Use expansion location for missing include diagnostics.

VitaNuo updated this revision to Diff 508648. VitaNuo added a comment. Format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146727/new/ https://reviews.llvm.org/D146727 Files: clang-tools-extra/clangd/IncludeCleaner.cpp clang-tools-extra/clan

[PATCH] D146947: [docs][clang] Added extra information inside the flag -fsanitize=unsigned-shift-base for UndefinedBehaviorSanitizer Fix : #60712

Eugene.Zelenko added inline comments. Comment at: clang/docs/UndefinedBehaviorSanitizer.rst:160 - ``-fsanitize=unsigned-shift-base``: check that an unsigned left-hand side of - a left shift operation doesn't overflow. + a left shift operation doesn't overflow.Issues

[PATCH] D144709: [clang-format] Improve QualifierAlignment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcd7ab4b5c168: [clang-format] Improve QualifierAlignment (authored by AlexanderHederstaf, committed by MyDeveloperDay). Changed prior to commit: ht

[PATCH] D146727: [clangd] Use expansion location for missing include diagnostics.

VitaNuo added a comment. thanks for the comments! Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:380 +auto Loc = SM.getFileLoc(Ref.RefLocation); +auto Range = Lexer::makeFileCharRange( +CharSourceRange{SourceRange{Loc}, true}, SM, AST.getLan

[clang] cd7ab4b - [clang-format] Improve QualifierAlignment

Author: Alexander Hederstaf Date: 2023-03-27T15:18:29+01:00 New Revision: cd7ab4b5c1684dcc60de027700177adfa096b98c URL: https://github.com/llvm/llvm-project/commit/cd7ab4b5c1684dcc60de027700177adfa096b98c DIFF: https://github.com/llvm/llvm-project/commit/cd7ab4b5c1684dcc60de027700177adfa096b98c

  1   2   3   >