[PATCH] D145815: [Flang][Driver] Add support for fopenmp-is-device and fembed-offload-object to Flang ToolChain

jhuber6 accepted this revision. jhuber6 added a comment. LGTM, it's much simpler for now since Flang doesn't support CUDA, HIP, OpenCL, OpenMP, etc. Comment at: flang/test/Driver/omp-frontend-forwarding.f90:1 +! REQUIRES: amdgpu-registered-target + agozillon w

[PATCH] D146164: Fix nomerge attribute not working with __builtin_trap().

zequanwu added a comment. In D146164#4200414 , @rsmith wrote: > FYI: this attribute appears to not work on (at least) x86 and arm currently, > because the backend also does some merging: https://godbolt.org/z/d43M83oax Thanks for reporting it. I'll look

[PATCH] D146247: [clang-format] Support TypeScript satisfies operator

MyDeveloperDay added a comment. I would like to see an annotator test just to be sure its getting annotated correctly. apart from that it looks pretty good, would you add this to the release notes please? Comment at: clang/unittests/Format/FormatTestJS.cpp:2186 +TEST_F(Forma

[PATCH] D125171: Add a new clang-format option AlwaysBreakBeforeFunctionParameters

MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:1372 +.. _AlwaysBreakBeforeFunctionParameters: + +**AlwaysBreakBeforeFunctionParameters** (``Boolean``) :versionbadge:`clang-format 16.0` jrmolin wrote: > MyDeveloperDay wro

[PATCH] D143704: [flang] Feature list plugin

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, as it doesn't affect core features. Comment at: flang/examples/FeatureList/FeatureList.cpp:40-43 +const auto [it, ins] = frequencies.insert({name, 1}); +if

[PATCH] D143967: [DebugInfo][BPF] Add 'btf:type_tag' annotation in DWARF

eddyz87 added a comment. In D143967#4200331 , @dfaust wrote: > In D143967#4197288 , @eddyz87 wrote: > >> ... >> I think there are two sides to this: >> >> - conceptual: is it ok to allow annotations for CVR modifi

[PATCH] D145815: [Flang][Driver] Add support for fopenmp-is-device and fembed-offload-object to Flang ToolChain

awarzynski added inline comments. Comment at: flang/test/Driver/omp-frontend-forwarding.f90:1 +! REQUIRES: amdgpu-registered-target + jhuber6 wrote: > agozillon wrote: > > awarzynski wrote: > > > Given that you use `-###`, I think that this can be skipped (please

[PATCH] D146255: [clang] Unconditionally add autolink hints for frameworks.

Bigcheese accepted this revision. Bigcheese added a comment. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146255/new/ https://reviews.llvm.org/D146255 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D146255: [clang] Unconditionally add autolink hints for frameworks.

ributzka added a comment. Thanks for the prompt reviews Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146255/new/ https://reviews.llvm.org/D146255 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] 29e2a4e - [clang] Unconditionally add autolink hints for frameworks.

Author: Juergen Ributzka Date: 2023-03-16T15:31:17-07:00 New Revision: 29e2a4eff8f62d12754f31f90d70e9a346bc2075 URL: https://github.com/llvm/llvm-project/commit/29e2a4eff8f62d12754f31f90d70e9a346bc2075 DIFF: https://github.com/llvm/llvm-project/commit/29e2a4eff8f62d12754f31f90d70e9a346bc2075.di

[PATCH] D146255: [clang] Unconditionally add autolink hints for frameworks.

This revision was automatically updated to reflect the committed changes. Closed by commit rG29e2a4eff8f6: [clang] Unconditionally add autolink hints for frameworks. (authored by ributzka). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146255/new/ h

[PATCH] D146178: [Clang][Sema] Fix comparison of constraint expressions

rsmith added a comment. The approach of attempting to adjust the depth here is not correct, and we should rip this whole mechanism out and reimplement it. Consider this closely related testcase: template concept Concept = true; template struct A { template V> void C(V&& t)

[PATCH] D146211: Make globals used for array initialization codegen constant

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146211/new/ https://reviews.llvm.org/D146211 ___

[libunwind] a7aade1 - [runtimes] Synchronize warnings flags between libc++/libc++abi/libunwind

Author: Nikolas Klauser Date: 2023-03-17T00:40:59+01:00 New Revision: a7aade1f36eb60161235b66bca46db12e5326a0c URL: https://github.com/llvm/llvm-project/commit/a7aade1f36eb60161235b66bca46db12e5326a0c DIFF: https://github.com/llvm/llvm-project/commit/a7aade1f36eb60161235b66bca46db12e5326a0c.dif

[PATCH] D145815: [Flang][Driver] Add support for fopenmp-is-device and fembed-offload-object to Flang ToolChain

agozillon added inline comments. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:128 + if (IsHostOffloadingAction) { +for (size_t i = 1; i < Inputs.size(); ++i) { + if (Inputs[i].getType() != types::TY_Nothing) awarzynski wrote: > jhuber6 wrote: > > a

[PATCH] D145815: [Flang][Driver] Add support for fopenmp-is-device and fembed-offload-object to Flang ToolChain

agozillon updated this revision to Diff 505957. agozillon edited the summary of this revision. agozillon added a comment. - [Flang][Driver] Expand further on the embed-offload-object comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145815/new/

[PATCH] D145815: [Flang][Driver] Add support for fopenmp-is-device and fembed-offload-object to Flang ToolChain

agozillon added a comment. Recent commit added some more detail to the comment on the fembed-offload-object argument as requested by @awarzynski Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145815/new/ https://reviews.llvm.org/D145815 __

[clang] 1029747 - [Sema] Fix null pointer dereference handleAlwaysInlineAttr.

Author: Craig Topper Date: 2023-03-16T17:49:34-07:00 New Revision: 10297470e953f4f3968c54c851c8af82b07af00b URL: https://github.com/llvm/llvm-project/commit/10297470e953f4f3968c54c851c8af82b07af00b DIFF: https://github.com/llvm/llvm-project/commit/10297470e953f4f3968c54c851c8af82b07af00b.diff

[PATCH] D146089: [Sema] Fix null pointer dereference handleAlwaysInlineAttr.

This revision was automatically updated to reflect the committed changes. Closed by commit rG10297470e953: [Sema] Fix null pointer dereference handleAlwaysInlineAttr. (authored by craig.topper). Changed prior to commit: https://reviews.llvm.org/D146089?vs=505596&id=505961#toc Repository: rG

[PATCH] D146269: MIPS: allow o32 abi with 64bit CPU

wzssyqa created this revision. wzssyqa added a reviewer: MaskRay. Herald added subscribers: atanasyan, jrtc27, arichardson, sdardis. Herald added a project: All. wzssyqa requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In general, MIPS suppo

[PATCH] D146269: MIPS: allow o32 abi with 64bit CPU and 64 abi with 32bit triple

jrtc27 added a comment. Tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146269/new/ https://reviews.llvm.org/D146269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D126959: [C++20][Modules] Introduce an implementation module.

ChuanqiXu added a comment. (I don't why I can't send emails in the original mail address. It told me that your email addressed is not recorded by MX, while I don't know what is MX. So I tried to reply your email here) This FIXME was added 6 years ago for Modules TS. (https://github.com/llvm/ll

RE: [clang] 1029747 - [Sema] Fix null pointer dereference handleAlwaysInlineAttr.

Hi Craig, There are some failures on the PS5 buildbot after this change. Could you take a look? https://lab.llvm.org/buildbot/#/builders/216/builds/18474 Thanks, Matt > -Original Message- > From: cfe-commits On Behalf Of Craig > Topper via cfe-commits > Sent: Thursday, March 16, 2023

[clang] e8a632d - Revert "[Sema] Fix null pointer dereference handleAlwaysInlineAttr."

Author: Craig Topper Date: 2023-03-16T20:05:33-07:00 New Revision: e8a632dac2204d66293dd5e0ba92eb65941c4aa3 URL: https://github.com/llvm/llvm-project/commit/e8a632dac2204d66293dd5e0ba92eb65941c4aa3 DIFF: https://github.com/llvm/llvm-project/commit/e8a632dac2204d66293dd5e0ba92eb65941c4aa3.diff

[PATCH] D126959: [C++20][Modules] Introduce an implementation module.

ChuanqiXu added a comment. I don't remember clearly if we have a test for the initializer in the implementation unit. Ignore this if we already have one. Comment at: clang/include/clang/Basic/Module.h:137 ImplicitGlobalModuleFragment, }; We may be ab

RE: [clang] 1029747 - [Sema] Fix null pointer dereference handleAlwaysInlineAttr.

LG. Thanks! > -Original Message- > From: Craig Topper > Sent: Thursday, March 16, 2023 8:01 PM > To: Voss, Matthew > Cc: Craig Topper ; cfe-commits@lists.llvm.org > Subject: Re: [clang] 1029747 - [Sema] Fix null pointer dereference > handleAlwaysInlineAttr. > > Thanks for the heads up.

[PATCH] D146187: [docs] Update the status for coroutines

ChuanqiXu updated this revision to Diff 505979. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146187/new/ https://reviews.llvm.org/D146187 Files: clang/docs/ReleaseNotes.rst clang/www/cxx_status.html Index: clang/www/cxx_status.html ==

[PATCH] D146187: [docs] Update the status for coroutines

ChuanqiXu added a comment. > but we don't define __cpp_­impl_­coroutine: > http://eel.is/c++draft/tab:cpp.predefined.ft We defined `__cpp_­impl_­coroutine`. And `__cpp_coroutines` is for Coroutines TS. I forgot to remove this too. I'll handle it in a separate patch. CHANGES SINCE LAST ACTION

[PATCH] D146090: [Clang] Updating handling of defaulted comparison operators to reflect changes from P2448R2

shafik updated this revision to Diff 505985. shafik marked 6 inline comments as done. shafik added a comment. - Updating diagnostic wording - Adding Reference to changes from p2448r2 to the comments - Modified p3 tests to have an extension pass as well CHANGES SINCE LAST ACTION https://reviews

[clang] e82d2e8 - Recommit "[Sema] Fix null pointer dereference handleAlwaysInlineAttr."

Author: Craig Topper Date: 2023-03-16T21:37:35-07:00 New Revision: e82d2e8c9ca34bcccb8fef67a8727543a978 URL: https://github.com/llvm/llvm-project/commit/e82d2e8c9ca34bcccb8fef67a8727543a978 DIFF: https://github.com/llvm/llvm-project/commit/e82d2e8c9ca34bcccb8fef67a8727543a978.diff

[PATCH] D146089: [Sema] Fix null pointer dereference handleAlwaysInlineAttr.

craig.topper added a comment. Recommitted at e82d2e8c9ca34bcccb8fef67a8727543a978 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146089/new/ https://reviews.llvm.org/D146089

[PATCH] D146090: [Clang] Updating handling of defaulted comparison operators to reflect changes from P2448R2

shafik updated this revision to Diff 505986. shafik added a comment. - Added release note - Update CXX status CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146090/new/ https://reviews.llvm.org/D146090 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/DiagnosticGroups.td

[PATCH] D146090: [Clang] Updating handling of defaulted comparison operators to reflect changes from P2448R2

shafik added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9410-9421 +def ext_incorrect_defaulted_comparison_constexpr : Extension< "defaulted definition of %select{%sub{select_defaulted_comparison_kind}1|" "three-way comparison operator}0 "

[PATCH] D146187: [docs] Update the status for coroutines

ChuanqiXu added a comment. > Should we also be updating InitPreprocessor.cpp at the same time, for > non-Windows targets? I didn't address this since we didn't do this before. (Defining feature macro according to the targets). Also I feel it may be bad for windows users. Since currently the co

[clang] 0818433 - Remove the outdated feature macro '__cpp_coroutines'

Author: Chuanqi Xu Date: 2023-03-17T13:52:18+08:00 New Revision: 0818433a5515df24c5d2cd95087e375ba8596cb0 URL: https://github.com/llvm/llvm-project/commit/0818433a5515df24c5d2cd95087e375ba8596cb0 DIFF: https://github.com/llvm/llvm-project/commit/0818433a5515df24c5d2cd95087e375ba8596cb0.diff LO

[PATCH] D145820: [Clang][OpenMP] Insert alloca for kernel args at function entry block instead of the launch point.

dhruvachak updated this revision to Diff 505987. dhruvachak added a comment. Fixed clang test OpenMP/target_map_codegen_hold.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145820/new/ https://reviews.llvm.org/D145820 Files: clang/lib/CodeGen

[PATCH] D145820: [Clang][OpenMP] Insert alloca for kernel args at function entry block instead of the launch point.

dhruvachak marked an inline comment as done. dhruvachak added inline comments. Comment at: clang/test/OpenMP/target_map_codegen_hold.cpp:211 +// CHECK-NOUSE-I386: @llvm.global_ctors = appending global [1 x { i32, ptr, ptr }] [{ i32, ptr, ptr } { i32 0, ptr @.omp_offloading.requi

<    1   2