mikecrowe updated this revision to Diff 504517.
mikecrowe marked 2 inline comments as done.
mikecrowe added a comment.
Documentation updates suggested by @PiotrZSL. Rebase.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145885/new/
https://reviews.l
francii updated this revision to Diff 504518.
francii added a comment.
Move `-r` check in `CommonArgs.cpp`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145899/new/
https://reviews.llvm.org/D145899
Files:
clang/lib/Driver/ToolChains/AIX.cpp
cl
PiotrZSL added inline comments.
Comment at:
clang-tools-extra/docs/clang-tidy/checks/readability/redundant-string-cstr.rst:18
+ or proper overload candidates that can do so should exist. This can be
+ used to configure functions such as fmt::format, spdlog::logger::info,
+
Pierre-vh added a comment.
I'll wait a couple of more days and then land, if no one has any objections.
As said before this has been deprecated for a long time, and clang was already
warning on use of those options. Removal has been pending for a while :)
Repository:
rG LLVM Github Monorepo
Author: Chuanqi Xu
Date: 2023-03-13T15:54:40+08:00
New Revision: 2e9977c2815653c141c6c060c4e0ab6c0db27911
URL:
https://github.com/llvm/llvm-project/commit/2e9977c2815653c141c6c060c4e0ab6c0db27911
DIFF:
https://github.com/llvm/llvm-project/commit/2e9977c2815653c141c6c060c4e0ab6c0db27911.diff
LO
lime updated this revision to Diff 504535.
lime added a comment.
Update and ping.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145491/new/
https://reviews.llvm.org/D145491
Files:
clang/docs/ReleaseNotes.rst
clang/lib/Sema/TreeTransform.h
clang/test/CodeGenCXX/decl-ref-inheritanc
mikecrowe updated this revision to Diff 504537.
mikecrowe edited the summary of this revision.
mikecrowe added a comment.
Quote types and functions correctly in redundant-string-cstr.rst.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145885/new/
ht
awarzynski added a comment.
Why does "flang/test/Driver/target-features.f90" list all RISC-V features? Why
not use
https://github.com/llvm/llvm-project/blob/main/flang/test/Driver/target-cpu-features.f90
instead?
Comment at: flang/test/Driver/target-features.f90:1
+! RUN: %
jrtc27 added inline comments.
Comment at: flang/test/Driver/target-features.f90:1
+! RUN: %flang --target=riscv64-linux-gnu --target=riscv64 -c %s -### 2>&1 \
+! RUN: | FileCheck %s -check-prefix=CHECK-RV64
awarzynski wrote:
> What happens if the RISC-V backend i
PiotrZSL accepted this revision.
PiotrZSL added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145885/new/
https://reviews.llvm.org/D145885
___
awarzynski added inline comments.
Comment at: flang/test/Driver/target-features.f90:1
+! RUN: %flang --target=riscv64-linux-gnu --target=riscv64 -c %s -### 2>&1 \
+! RUN: | FileCheck %s -check-prefix=CHECK-RV64
jrtc27 wrote:
> awarzynski wrote:
> > What happens i
jrtc27 added inline comments.
Comment at: flang/test/Driver/target-features.f90:1
+! RUN: %flang --target=riscv64-linux-gnu --target=riscv64 -c %s -### 2>&1 \
+! RUN: | FileCheck %s -check-prefix=CHECK-RV64
awarzynski wrote:
> jrtc27 wrote:
> > awarzynski wrote:
Author: Chuanqi Xu
Date: 2023-03-13T16:44:10+08:00
New Revision: e264fe89e37fc0b12e18d72ed98056cea1a9eba6
URL:
https://github.com/llvm/llvm-project/commit/e264fe89e37fc0b12e18d72ed98056cea1a9eba6
DIFF:
https://github.com/llvm/llvm-project/commit/e264fe89e37fc0b12e18d72ed98056cea1a9eba6.diff
LO
sunshaoce updated this revision to Diff 504548.
sunshaoce added a comment.
Based on everyone's comments, I merged the test into `target-cpu-features.f90`
and only kept the generic `-target-feature`. At the same time, I removed the
`switch (TC.getArch())` and passed the test on x86 and RISC-V 64.
hch12907 added inline comments.
Comment at: clang/unittests/Format/FormatTest.cpp:20273
+ Style.ColumnLimit = 20;
+ EXPECT_EQ(
+ "demo = std::array<\n"
MyDeveloperDay wrote:
> any reason you didn't use verifyFormat here?
No particular reason - I simply cop
Henric added a comment.
Hi
With this patch, the following code gives me a warning that I don't think is
intentional.
typedef struct S {
int x:4;
} S;
void foo(S s) {
for (int i=10; i > s.x; --i) ;
}
loop_var.c:6:22: warning: loop variable has narrower type 'int:4' than
i
mboehme created this revision.
Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun.
Herald added a reviewer: njames93.
Herald added a project: All.
mboehme requested review of this revision.
Herald added a project: clang-tools-extra.
Herald added a subscriber: cfe-commits.
As designated i
CarolineConcatto accepted this revision.
CarolineConcatto added a comment.
This revision is now accepted and ready to land.
Thank you Matt. It LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145505/new/
https://reviews.llvm.org/D145505
___
PiotrZSL added a comment.
Thank you for information, I will look into this
Indeed test for this scenario is missing.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142587/new/
https://reviews.llvm.org/D142587
___
hokein created this revision.
hokein added a reviewer: kadircet.
Herald added a subscriber: arphaman.
Herald added a project: All.
hokein requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
The old implementation has been
hokein created this revision.
hokein added a reviewer: kadircet.
Herald added a subscriber: arphaman.
Herald added a project: All.
hokein requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
This API was merely used in the
skatrak added inline comments.
Comment at: flang/test/Driver/omp-frontend-forwarding.f90:15
+! CHECK: "{{[^"]*}}flang-new" "-fc1" "-triple" "amdgcn-amd-amdhsa" {{.*}}
"-fopenmp" {{.*}} "-fopenmp-is-device" {{.*}}.f90"
+! CHECK: "{{[^"]*}}clang-offload-packager" {{.*}}
"--image=
dang added inline comments.
Comment at: clang/test/ExtractAPI/ignored-symbols-multifile.c:34
+//--- ignores-list1
+IGNORED_FILE1_1
+IGNORED_FILE1_2
This test doesn't check the symbol name sorting behavior across multiple files,
which is crucial `APIIgnoresList::
Szelethus added inline comments.
Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:449
// No diagnostic if region was modified inside the frame.
if (!CallExitLoc || isModifiedInFrame(N))
return nullptr;
We also lost this, unfortunately,
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
Good catch, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144453/new/
https://reviews.llvm.org/D144453
awarzynski added a comment.
Herald added a subscriber: jobnoorman.
> Fix the issue of .o file generated by Flang with Flags info is 0x0 under
> RISC-V.
TBH, I don't see how this is addressed in this patch. If that's something that
this patch is intending to fix, then there should be a regressio
kiranchandramohan added inline comments.
Comment at: clang/lib/Driver/ToolChains/Flang.cpp:112-114
+ case llvm::Triple::riscv64:
+getTargetFeatures(D, Triple, Args, CmdArgs, /*ForAs*/ false);
+break;
jrtc27 wrote:
> mnadeem wrote:
> > identical code, cou
hans created this revision.
hans added a reviewer: philnik.
hans added a project: libc++.
Herald added a project: All.
hans requested review of this revision.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.
Windows builds were failing due to missing include for std::add
vabridgers added a comment.
@balazske and I discussed, he will be commandeering this patch to improve.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145868/new/
https://reviews.llvm.org/D145868
___
cfe-c
kadircet created this revision.
kadircet added reviewers: sammccall, hokein.
Herald added a subscriber: arphaman.
Herald added a project: All.
kadircet requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
Also
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added subscribers: kadircet, arphaman.
Herald added a project: All.
hokein requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
This file was missing
karapsinie updated this revision to Diff 504577.
karapsinie marked an inline comment as done.
karapsinie added a comment.
Fulfilled the wishes of cor3ntin
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144878/new/
https://reviews.llvm.org/D144878
Files:
clang/include/clang/AST/Expr.h
hokein abandoned this revision.
hokein added a comment.
I didn't notice https://reviews.llvm.org/D145921, let's deprecate this one.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145922/new/
https://reviews.llvm.org/D145922
hokein added inline comments.
Comment at: clang-tools-extra/clangd/unittests/tweaks/SpecialMembersTests.cpp:21
EXPECT_UNAVAILABLE("struct S { ^ };");
- EXPECT_UNAVAILABLE("union ^U {};");
+ EXPECT_AVAILABLE("union ^U {};");
EXPECT_AVAILABLE("struct ^S { S(const S&); S(S&&
Arsenic updated this revision to Diff 504590.
Arsenic added a comment.
Update clang/test/ExtractAPI/ignored-symbols-multifile.c :
Shuffle the order of ignored symbols in test to check the sorting behaviour of
APIIgnoresList
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
http
MattDevereau updated this revision to Diff 504588.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145505/new/
https://reviews.llvm.org/D145505
Files:
clang/include/clang/Basic/AArch64SVEACLETypes.def
clang/lib/AST/ASTContext.cpp
clang/lib/AST/T
agozillon updated this revision to Diff 504592.
agozillon added a comment.
- [Flang][Driver] Try to fix failing omp-frontend-forwarding.f90 test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145815/new/
https://reviews.llvm.org/D145815
Files:
cl
dang added inline comments.
Comment at: clang/test/ExtractAPI/ignored-symbols-multifile.c:27
+
+// CHECK-NOT: IGNORED_1_FILE3
+// CHECK-NOT: IGNORED_7_FILE3
Should this not be a 6?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://revie
dang accepted this revision.
dang added a comment.
This revision is now accepted and ready to land.
LGTM once you fix the test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145869/new/
https://reviews.llvm.org/D145869
_
This revision was automatically updated to reflect the committed changes.
Closed by commit rGbe39daea846e: [clangd] Remove IWYU handling code that is
used only for the old unused-include… (authored by hokein).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm
Author: Haojian Wu
Date: 2023-03-13T12:34:34+01:00
New Revision: be39daea846e6b5d43a8ee0c387feb0a556ff386
URL:
https://github.com/llvm/llvm-project/commit/be39daea846e6b5d43a8ee0c387feb0a556ff386
DIFF:
https://github.com/llvm/llvm-project/commit/be39daea846e6b5d43a8ee0c387feb0a556ff386.diff
LO
Arsenic updated this revision to Diff 504594.
Arsenic added a comment.
fix test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145869/new/
https://reviews.llvm.org/D145869
Files:
clang/include/clang/Driver/Options.td
clang/include/clang/Extract
Author: Haojian Wu
Date: 2023-03-13T12:37:38+01:00
New Revision: fd299a7880ae80911001590242e2cbdb55f24a37
URL:
https://github.com/llvm/llvm-project/commit/fd299a7880ae80911001590242e2cbdb55f24a37
DIFF:
https://github.com/llvm/llvm-project/commit/fd299a7880ae80911001590242e2cbdb55f24a37.diff
LO
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGfd299a7880ae: [clangd] Remove the
IncludeStructure::isSelfContained API. (authored by hokein).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE
kadircet added a comment.
we can also handle them through the stdlib symbol mappings, see
https://github.com/llvm/llvm-project/issues/61373
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D127184/new/
https://reviews.llvm.org/D127184
___
kadircet updated this revision to Diff 504597.
kadircet marked an inline comment as done.
kadircet added a comment.
- Disable special members tweaks on unions
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145921/new/
https://reviews.llvm.org/D14592
kadircet marked an inline comment as done.
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/unittests/tweaks/SpecialMembersTests.cpp:21
EXPECT_UNAVAILABLE("struct S { ^ };");
- EXPECT_UNAVAILABLE("union ^U {};");
+ EXPECT_AVAILABLE("union ^U {};");
EXP
balazske commandeered this revision.
balazske edited reviewers, added: vabridgers; removed: balazske.
balazske added a comment.
Herald added subscribers: steakhal, Szelethus, dkrupp.
My opinion is that we can not omit importing the "underlying type". The
`TypedefType` has the type of the declarat
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
doh, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145921/new/
https://reviews.llvm.org/D145921
_
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks, lgtm!
Comment at: clang-tools-extra/clangd/CompileCommands.cpp:199
+ // use/change working directory, which ExpandResponseFiles doesn't).
+ FS = llvm::vfs::getR
Author: Kadir Cetinkaya
Date: 2023-03-13T13:06:31+01:00
New Revision: e26dad0a661e055076002d0de4ceb713b8ca6917
URL:
https://github.com/llvm/llvm-project/commit/e26dad0a661e055076002d0de4ceb713b8ca6917
DIFF:
https://github.com/llvm/llvm-project/commit/e26dad0a661e055076002d0de4ceb713b8ca6917.dif
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGe26dad0a661e: [clangd] Add missing unittests to build graph
(authored by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
krisb updated this revision to Diff 504602.
krisb added a comment.
Rebase.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143984/new/
https://reviews.llvm.org/D143984
Files:
clang/test/CodeGen/attr-btf_tag-disubprogram-callsite.c
clang/test/Cod
krisb updated this revision to Diff 504605.
krisb added a comment.
Rebase.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144004/new/
https://reviews.llvm.org/D144004
Files:
clang/test/CodeGenCXX/debug-info-namespace.cpp
llvm/include/llvm/IR/DI
krisb marked 2 inline comments as done.
krisb added inline comments.
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.cpp:698
+ // an inlined function: if a local variable has a templated type with
+ // a function-local type as a template parameter. See PR55680 for deta
krisb updated this revision to Diff 504608.
krisb marked an inline comment as done.
krisb added a comment.
Apply review comments and rebase.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144006/new/
https://reviews.llvm.org/D144006
Files:
clang/
ilammy updated this revision to Diff 504609.
ilammy added a comment.
Addressed feedback by @MaskRay. Thanks!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145848/new/
https://reviews.llvm.org/D145848
Files:
clang/include/clang/Driver/Options.td
clang/test/CodeGen/xray-function-inde
Author: Ankur
Date: 2023-03-13T18:05:16+05:30
New Revision: 58825d2cf947d0b4fb6590c17212c388cd3ff5cf
URL:
https://github.com/llvm/llvm-project/commit/58825d2cf947d0b4fb6590c17212c388cd3ff5cf
DIFF:
https://github.com/llvm/llvm-project/commit/58825d2cf947d0b4fb6590c17212c388cd3ff5cf.diff
LOG: [c
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG58825d2cf947: [clang][ExtractAPI] Add multiple file support
to --extract-api-ignores (authored by Arsenic).
Repository:
rG LLVM Github Monorepo
C
aaron.ballman added inline comments.
Comment at: clang/lib/AST/ASTContext.cpp:2817
+// unique representation.
+if (Field->isUnnamedBitfield() && BitfieldSize > 0)
+ return std::nullopt;
I think the check for a non-zero bit-field width might not be co
aaron.ballman added inline comments.
Comment at: clang/lib/AST/Interp/ByteCodeStmtGen.cpp:224
for (auto *D : DS->decls()) {
-if (isa(D))
+if (isa(D))
continue;
What about other kinds of declarations, such as typedefs or functions?
```
typedef in
paperchalice added a comment.
Ping.
Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangHost.cpp:56
+ const std::string clang_resource_path =
+ clang::driver::Driver::GetResourcesPath("bin/lldb", CLANG_RESOURCE_DIR);
Should be "${CMAKE_INSTALL_B
sunshaoce updated this revision to Diff 504616.
sunshaoce added a comment.
Add test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145883/new/
https://reviews.llvm.org/D145883
Files:
clang/lib/Driver/ToolChains/Flang.cpp
flang/test/Driver/code-
AlexanderHederstaf added a comment.
What is the next step in the process? Anything I should do?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144709/new/
https://reviews.llvm.org/D144709
___
cfe-commits
qiongsiwu1 added a comment.
Ping for review. Thank you!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144190/new/
https://reviews.llvm.org/D144190
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Author: Dmitry Polukhin
Date: 2023-03-13T06:08:22-07:00
New Revision: 34de7da6246cdfa6ff6f3d3c514583cddc0a10ec
URL:
https://github.com/llvm/llvm-project/commit/34de7da6246cdfa6ff6f3d3c514583cddc0a10ec
DIFF:
https://github.com/llvm/llvm-project/commit/34de7da6246cdfa6ff6f3d3c514583cddc0a10ec.dif
This revision was automatically updated to reflect the committed changes.
Closed by commit rG34de7da6246c: [clangd] Move standard options adaptor to
CommandMangler (authored by DmitryPolukhin).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143436/new
aaron.ballman added inline comments.
Comment at: clang/include/clang/Analysis/Analyses/ReachableCode.h:65
+ Callback &CB,
+ const bool UnreachableFallThroughDiagIsEnabled);
}} // end namespace clang::reachable_code
iains created this revision.
Herald added a project: All.
iains added a reviewer: ChuanqiXu.
iains updated this revision to Diff 504524.
iains added a comment.
iains updated this revision to Diff 504591.
iains added a reviewer: rsmith.
iains published this revision for review.
Herald added a projec
karapsinie updated this revision to Diff 504625.
karapsinie marked 3 inline comments as done.
karapsinie added a comment.
Fulfilled the wishes of cor3ntin №2
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144878/new/
https://reviews.llvm.org/D144878
Files:
clang/include/clang/AST/Expr
erichkeane added a subscriber: jansvoboda11.
erichkeane added a comment.
Patch topic needs "WIP" out of it I think?
Just some WIP comments, I don't believe I'd be the one to approve this anyway.
Comment at: clang/include/clang/Basic/DiagnosticOptions.h:109
+ /// The file to
benshi001 updated this revision to Diff 504631.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145659/new/
https://reviews.llvm.org/D145659
Files:
clang/lib/Basic/Targets/AVR.cpp
clang/lib/Basic/Targets/AVR.h
clang/test/CodeGen/avr/avr-inline-asm-constraints.c
Index: clang/test/Co
benshi001 marked an inline comment as done.
benshi001 added inline comments.
Comment at: clang/lib/Basic/Targets/AVR.cpp:433
+AVRTargetInfo::handleAsmEscapedChar(char EscChar) const {
+ char C;
+ switch (EscChar) {
jacquesguan wrote:
> redundant variable?
Remov
kpdev42 updated this revision to Diff 504632.
kpdev42 marked an inline comment as done.
kpdev42 added a comment.
Address review comments and rebase
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145227/new/
https://reviews.llvm.org/D145227
Files:
Author: Dmitry Polukhin
Date: 2023-03-13T07:00:56-07:00
New Revision: 2a84c53ccdc015a7f53a144aa4f7c0dddf839604
URL:
https://github.com/llvm/llvm-project/commit/2a84c53ccdc015a7f53a144aa4f7c0dddf839604
DIFF:
https://github.com/llvm/llvm-project/commit/2a84c53ccdc015a7f53a144aa4f7c0dddf839604.dif
DmitryPolukhin added a comment.
Had to revert this diff temporary due to broken ARM builds. It seems that X86
targets are disabled for that bots so tests are not passing. I'll fix upload
new version for review.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.
erichkeane accepted this revision.
erichkeane added a comment.
This revision is now accepted and ready to land.
Thanks for the ping. I don't have any better ideas/other thoughts, so LGTM.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145491/new/
https://reviews.llvm.org/D145491
__
aaron.ballman added a comment.
Thanks for the additional tests! Can you also add a release note to
`clang/docs/ReleaseNotes.rst` and document the new builtin in
`clang\docs\LanguageExtensions.rst`?
Comment at: clang/test/Sema/builtin_set_flt_rounds.c:1-11
+// RUN: %clang_cc1
erichkeane added a comment.
Generally looks good to me. Do we do anything special if there are multiple
initializers? Also, can we have a codegen test that validates that we actually
construct it correctly (and perhaps a constexpr test for the same!)?
Comment at: clang/lib/
Author: Collin Baker
Date: 2023-03-13T10:11:05-04:00
New Revision: 4d55a0b512a17dfaa2461b8803d37b79f6c9691d
URL:
https://github.com/llvm/llvm-project/commit/4d55a0b512a17dfaa2461b8803d37b79f6c9691d
DIFF:
https://github.com/llvm/llvm-project/commit/4d55a0b512a17dfaa2461b8803d37b79f6c9691d.diff
This revision was automatically updated to reflect the committed changes.
Closed by commit rG4d55a0b512a1: Fix include order in CXType.cpp (authored by
collinbaker, committed by aaron.ballman).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130303/new
Author: Liming Liu
Date: 2023-03-13T22:22:06+08:00
New Revision: 3951c28b37ff67c87da59df961c4af19818c24c2
URL:
https://github.com/llvm/llvm-project/commit/3951c28b37ff67c87da59df961c4af19818c24c2
DIFF:
https://github.com/llvm/llvm-project/commit/3951c28b37ff67c87da59df961c4af19818c24c2.diff
LO
This revision was automatically updated to reflect the committed changes.
Closed by commit rG3951c28b37ff: [clang] Replace Member Expressions During
Instantiation If Necessary (authored by lime).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145491/n
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc341d5030503: [libc++] Add missing include in
exception_ptr.h (authored by hans).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
kpdev42 updated this revision to Diff 504647.
kpdev42 added a comment.
Fix test case
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145227/new/
https://reviews.llvm.org/D145227
Files:
clang/include/clang/Basic/Attr.td
clang/include/clang/Driver
ChuanqiXu accepted this revision.
ChuanqiXu added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145886/new/
https://reviews.llvm.org/D145886
erichkeane accepted this revision.
erichkeane added a comment.
This revision is now accepted and ready to land.
sorry for the delay, just started unburying myself from the 16.0 release
process. Its unfortunate we don't have a great way to test this, but I can see
the value of having it anyway i
aaron.ballman accepted this revision.
aaron.ballman added a comment.
LGTM, though please add a release note for the fix. If you need someone to land
on your behalf, let us know what name and email address you'd like used for
patch attribution.
Comment at: clang/lib/AST/ExprCo
karapsinie updated this revision to Diff 504648.
karapsinie added a comment.
Updated a release note and documentation.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144878/new/
https://reviews.llvm.org/D144878
Files:
clang/docs/LanguageExtensions.rst
clang/docs/ReleaseNotes.rst
c
agozillon added inline comments.
Comment at: flang/test/Driver/omp-frontend-forwarding.f90:15
+! CHECK: "{{[^"]*}}flang-new" "-fc1" "-triple" "amdgcn-amd-amdhsa" {{.*}}
"-fopenmp" {{.*}} "-fopenmp-is-device" {{.*}}.f90"
+! CHECK: "{{[^"]*}}clang-offload-packager" {{.*}}
"--imag
awarzynski added inline comments.
Comment at: flang/test/Driver/code-gen-rv64.f90:12
+
+! CHECK: Flags: 0x5, RVC, double-float ABI
+end program
For those of us less familiar with RISC-V - could you explain what's
significant about this line? For example, [[
htt
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM! Do you need someone to land this on your behalf? If so, what name and
email address would you like used for patch attribution?
Repository:
rG LLVM Github Monorepo
CHANG
jhuber6 created this revision.
jhuber6 added reviewers: jdoerfert, JonChesterfield, arsenm, yaxunl, MaskRay.
Herald added subscribers: kosarev, kerbowa, tpr, dstuttard, jvesely, kzhuravl.
Herald added a project: All.
jhuber6 requested review of this revision.
Herald added subscribers: cfe-commits,
JonChesterfield added a reviewer: AMDGPU.
JonChesterfield added a comment.
Adding the amdgpu reviewer group. This change might be contentious - we
currently treat various broken code as calls to trap on the grounds that those
functions might not be executed. By analogy, functions that call undef
DavidSpickett accepted this revision.
DavidSpickett added a comment.
This revision is now accepted and ready to land.
Looks good in general. If there are some incorrect details you'll find them
later.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D1
jhuber6 created this revision.
jhuber6 added reviewers: jdoerfert, tianshilei1992, JonChesterfield, ye-luo.
Herald added subscribers: kosarev, mattd, gchakrabarti, asavonic, kerbowa, tpr,
dstuttard, yaxunl, jvesely, kzhuravl.
Herald added a project: All.
jhuber6 requested review of this revision.
jhuber6 updated this revision to Diff 504670.
jhuber6 added a comment.
Add help print.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145944/new/
https://reviews.llvm.org/D145944
Files:
clang/tools/amdgpu-arch/AMDGPUArch.cpp
clang/tools/amdgpu-
sunshaoce updated this revision to Diff 504672.
sunshaoce marked an inline comment as done.
sunshaoce added a comment.
Address @awarzynski's comment. Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145883/new/
https://reviews.llvm.org/D145883
jhuber6 added a comment.
This can be turned off with `-zundefs`. So we could instruct people to use
`-Wl,-zundefs` or `-Xoffload-linker -zundefs` if the old behavior is desired.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D145941/new/
https://rev
kerbowa added a comment.
Added AMDGPU group to reviewers.
Is there any objection to changing the defaults for subtargets that support
XNACK to always reserve extra SGPRs unless -xnack is explicitly requested? This
would impact graphics as well. The old defaults were doing the opposite and
only
1 - 100 of 320 matches
Mail list logo
