[PATCH] D144853: [Clang][RISCV] Add CMake options to configure default CPU

MaskRay added a comment. I object to this change which further complicates the build system and makes the difference difficult to observe by users. If your `clang` executable is at `bin/clang`, just create `bin/riscv64-unknown-linux-gnu.cfg` with `-mcpu=xxx`. You may configure `LLVM_DEFAULT_TARG

[PATCH] D144828: [clang-tidy] Add misc-header-include-cycle check

PiotrZSL created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. PiotrZSL updated this revision to Diff 500591. PiotrZSL added a comment. Eugene.Zelenko added reviewers: aaron.ballman, carlosgalvezp. Eugene.Zelenko a

[PATCH] D144853: [Clang][RISCV] Add CMake options to configure default CPU

pcwang-thead abandoned this revision. pcwang-thead added a comment. In D144853#4157629 , @MaskRay wrote: > I object to this change which further complicates the build system and makes > the difference difficult to observe by users. > If your `clang` exec

[PATCH] D144638: [lit] Detect Inconsistent File Access Times

jhenderson added inline comments. Comment at: llvm/utils/lit/lit/llvm/config.py:171 +# in the tests that do the same thing. +(_, try_touch_err) = self.get_process_output(["touch", "-a", "-t", "199505050555.55", f.name]) +if try_touch_err != ""

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

agozillon added a comment. In D144864#4156764 , @jdoerfert wrote: > Tests? Happy to add more, I am just a little unsure what the best way to test this is other than application of the attribute to the module when the flag was used and verification that

[PATCH] D144454: Add builtin for llvm set rounding

xiongji90 added a comment. In D144454#4142253 , @rjmccall wrote: > New builtins should be documented in the user manual. > > There are standard pragmas for changing the rounding mode, right? What's the > interaction between the ability to set this dynam

[PATCH] D72820: [FPEnv] Add pragma FP_CONTRACT support under strict FP.

pengfei added inline comments. Comment at: clang/lib/CodeGen/CGExprScalar.cpp:3386 +FMulAdd = Builder.CreateConstrainedFPCall( +CGF.CGM.getIntrinsic(llvm::Intrinsic::experimental_constrained_fmuladd, + Addend->getType()), A

[clang] f332498 - [Clang] Do not emit exception diagnostics from coroutines and coroutine lambdas

Author: Deniz Evrenci Date: 2023-02-28T11:41:07+01:00 New Revision: f332498f9880d276890562fb861a375a13bfd9d9 URL: https://github.com/llvm/llvm-project/commit/f332498f9880d276890562fb861a375a13bfd9d9 DIFF: https://github.com/llvm/llvm-project/commit/f332498f9880d276890562fb861a375a13bfd9d9.diff

[PATCH] D144352: Do not emit exception diagnostics from coroutines and coroutine lambdas

This revision was automatically updated to reflect the committed changes. Closed by commit rGf332498f9880: [Clang] Do not emit exception diagnostics from coroutines and coroutine lambdas (authored by denizevrenci, committed by nikic). Changed prior to commit: https://reviews.llvm.org/D144352?vs

[PATCH] D144903: [X86] Drop single use check for freeze(undef) in LowerAVXCONCAT_VECTORS

RKSimon added inline comments. Comment at: clang/test/CodeGen/X86/avx-cast-builtins.c:1 -// RUN: %clang_cc1 %s -O3 -flax-vector-conversions=none -ffreestanding %s -triple=x86_64-unknown-unknown -target-feature +avx -target-feature +avx512f -target-feature +avx512fp16 -S -o - |

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos marked 4 inline comments as done. pmatos added a comment. Thanks @aaron.ballman . I think I have now address all outstanding comments. Comment at: clang/include/clang/Basic/Attr.td:4129 + let Documentation = [WebAssemblyExportNameDocs]; + let Subjects = SubjectList<[Ty

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos updated this revision to Diff 501075. pmatos marked 3 inline comments as done. pmatos added a comment. Patch with all outstanding comments addressed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128440/new/ https://reviews.llvm.org/D128440

[PATCH] D144940: [clang][ExtractAPI] Handle platform specific unavailability correctly

dang requested changes to this revision. dang added a comment. This revision now requires changes to proceed. Nice! glad to see this getting fixed. You should add a lit test to ensure we don't regress this behavior in the future. Comment at: clang/include/clang/ExtractAPI/Avai

[PATCH] D144638: [lit] Detect Inconsistent File Access Times

lenary added a comment. In D144638#4155217 , @michaelplatings wrote: > I see some of these tests previously had `UNSUPPORTED: system-netbsd` but not > `UNSUPPORTED: system-windows` - do you know why? I'm not entirely sure why, but I have some ideas: -

[PATCH] D144903: [X86] Drop single use check for freeze(undef) in LowerAVXCONCAT_VECTORS

ManuelJBrito updated this revision to Diff 501079. ManuelJBrito added a comment. Recover mistakenly drop flag in avx-cast-builtins. I was experimenting and forgot i had removed it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144903/new/ https://r

[PATCH] D128440: [WebAssembly] Initial support for reference type funcref in clang

pmatos updated this revision to Diff 501081. pmatos added a comment. Add forgotten comment to test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128440/new/ https://reviews.llvm.org/D128440 Files: clang/include/clang/AST/DeclBase.h clang/incl

[PATCH] D144866: [clang] Fix aggregate initialization inside lambda constexpr

Fznamznon updated this revision to Diff 501084. Fznamznon added a comment. Apply suggestions and rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144866/new/ https://reviews.llvm.org/D144866 Files: clang/docs/ReleaseNotes.rst clang/lib/AS

[PATCH] D140562: [clang][ASTImporter] Improve import of InjectedClassNameType.

vabridgers added a comment. Hi @donat.nagy , no problem. That's ok for me. Best! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140562/new/ https://reviews.llvm.org/D140562 ___ cfe-commits mailing list cf

[PATCH] D140562: [clang][ASTImporter] Improve import of InjectedClassNameType.

vabridgers accepted this revision. vabridgers added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140562/new/ https://reviews.llvm.org/D140562 ___ cfe-commits mailing list cfe-commits@lis

Re: [clang] 6ed67cc - [Coroutines] Remove -fcoroutines-ts

Hi Bruno, We talked about removing `-fcoroutines-ts` in https://github.com/llvm/llvm-project/issues/59110 and https://reviews.llvm.org/D108697. I raised the example you used here. And the conclusion is that this is the clang's policy for `-f*-ts` options. The same thing happens for -fconcepts-t

[PATCH] D144272: [clang][Interp] Ignore StaticAssertDecls

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144272/new/ https://reviews.llvm.org/D144272

[PATCH] D144940: [clang][ExtractAPI] Handle platform specific unavailability correctly

Arsenic added a comment. In D144940#4158020 , @dang wrote: > Nice! glad to see this getting fixed. You should add a lit test to ensure we > don't regress this behavior in the future. I see a test checking for availability attribute already exists ( `cl

[PATCH] D144940: [clang][ExtractAPI] Handle platform specific unavailability correctly

dang added a comment. In D144940#4158143 , @Arsenic wrote: > In D144940#4158020 , @dang wrote: > >> Nice! glad to see this getting fixed. You should add a lit test to ensure we >> don't regress this behavior in t

[PATCH] D140794: [ASTMatcher] Add coroutineBodyStmt matcher

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Thanks @sammccall for weighing in, I appreciate it. :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140794/new/ https://re

[PATCH] D144285: [Clang] Implement CWG2518 - static_assert(false)

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Comment at: clang/test/SemaTemplate/instantiate-var-template.cpp:36 } + } :: gasps :: spurious whitespace change! :-D Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D143418: [libclang] Add API to override preamble storage path

aaron.ballman added inline comments. Comment at: clang/tools/c-index-test/c-index-test.c:79 +Opts.PreambleStoragePath = NULL; +Opts.InvocationEmissionPath = getenv("CINDEXTEST_INVOCATION_EMISSION_PATH"); + vedgy wrote: > aaron.ballman wrote: > > vedgy wr

[PATCH] D140803: [clang][Interp] Implement C++ Range-for loops

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140803/new/ https://reviews.llvm.org/D140803 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D138802: [clang][Interp] Implement DecompositionDecls

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138802/new/ https://reviews.llvm.org/D138802 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D138275: [clang][Interp] Avoid leaking init maps of local primitive arrays

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138275/new/ https://reviews.llvm.org/D138275 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D136751: [clang][Interp] This pointers are writable in constructors

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136751/new/ https://reviews.llvm.org/D136751 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos updated this revision to Diff 501110. pmatos marked an inline comment as done. pmatos added a comment. Address the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139010/new/ https://reviews.llvm.org/D139010 Files: clang/include/c

[PATCH] D144903: [X86] Drop single use check for freeze(undef) in LowerAVXCONCAT_VECTORS

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144903/new/ https://reviews.llvm.org/D144903 _

[PATCH] D144626: [C++20] [Modules] Trying to compare the trailing require clause of the primary template when performing ODR checking

erichkeane added a comment. In D144626#4157240 , @ChuanqiXu wrote: > This is another revision (https://reviews.llvm.org/D144707) which shouldn't > be related with libcxx's modular build. So the failures should be irrelevant > with the revision. @erichke

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos marked 3 inline comments as done. pmatos added inline comments. Comment at: clang/include/clang/AST/Stmt.h:456 - class ArrayOrMatrixSubscriptExprBitfields { + class AMTSubscriptExprBitfields { friend class ArraySubscriptExpr; aaron.ballman wrote:

[PATCH] D144961: [NVPTX] Add f16 and v2f16 ldg builtins

jchlanda created this revision. jchlanda added a reviewer: tra. Herald added subscribers: mattd, gchakrabarti, asavonic. Herald added a project: All. jchlanda requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jholewinski. Herald added projects: clang, LLVM. Ad

[PATCH] D140803: [clang][Interp] Implement C++ Range-for loops

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM; I suspect there's still lifetime issues we are not catching here, but this is incrementally forward progress and we can test the lifetime issues once we have more of the in

[PATCH] D138802: [clang][Interp] Implement DecompositionDecls

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138802/new/ https://reviews.llvm.org/D138802 ___ cfe-commits mailing lis

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 added a comment. Gentle ping for review. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D144190 ___ cfe-commits mailing list cfe-commits@lists.ll

[clang] 26202a5 - [CGProfile] Don't fetch BFI without profile (NFCI)

Author: Nikita Popov Date: 2023-02-28T15:23:07+01:00 New Revision: 26202a57e5e78b5473ef657737d181f0a68ed56d URL: https://github.com/llvm/llvm-project/commit/26202a57e5e78b5473ef657737d181f0a68ed56d DIFF: https://github.com/llvm/llvm-project/commit/26202a57e5e78b5473ef657737d181f0a68ed56d.diff

[PATCH] D128648: [Clang][AArch64][SME] Add vector read/write (mova) intrinsics

kmclaughlin added a comment. Hi @bryanpkc, thank you for updating this patch & applying the previous review comments here too. I just have a couple of minor suggestions: Comment at: clang/include/clang/Basic/arm_sme.td:103 +def NAME # _H : SInst<"svwrite_hor_" # n_suffix #

[PATCH] D144964: [clang][ExtractAPI] Handle platform specific unavailability correctly

Arsenic created this revision. Herald added a reviewer: ributzka. Herald added a project: All. Arsenic requested review of this revision. Herald added a reviewer: dang. Herald added a project: clang. Herald added a subscriber: cfe-commits. This Patch gives ExtractAPI the ability to emit correct av

[PATCH] D144866: [clang] Fix aggregate initialization inside lambda constexpr

Fznamznon added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:8763 if (isLambdaCallOperator(Info.CurrentCall->Callee)) { - // Ensure we actually have captured 'this'. (an error will have - // been previously reported if not). + // Ensure we actua

[clang] 523640f - [clang][Interp][NFC] Use qualified name in Function::getName()

Author: Timm Bäder Date: 2023-02-28T15:54:25+01:00 New Revision: 523640f7a4c0b038ce630939af161fdfa964dba4 URL: https://github.com/llvm/llvm-project/commit/523640f7a4c0b038ce630939af161fdfa964dba4 DIFF: https://github.com/llvm/llvm-project/commit/523640f7a4c0b038ce630939af161fdfa964dba4.diff LO

[PATCH] D144626: [C++20] [Modules] Trying to compare the trailing require clause of the primary template when performing ODR checking

ChuanqiXu added a comment. In D144626#4158290 , @erichkeane wrote: > In D144626#4157240 , @ChuanqiXu > wrote: > >> This is another revision (https://reviews.llvm.org/D144707) which shouldn't >> be related with

[PATCH] D144967: [PowerPC] Recognize long CPU name for -mtune in Clang

nemanjai created this revision. nemanjai added reviewers: PowerPC, nathanchance, MaskRay. Herald added subscribers: steven.zhang, shchenz, kbarton. Herald added a project: All. nemanjai requested review of this revision. Herald added a project: clang. There are two ways of specifying a CPU on Powe

[clang] edeb0f4 - [clang][Interp][NFC] Clean up InterpState.cpp

Author: Timm Bäder Date: 2023-02-28T16:36:16+01:00 New Revision: edeb0f49794c63d22a4c7fd6d2672c8544038dca URL: https://github.com/llvm/llvm-project/commit/edeb0f49794c63d22a4c7fd6d2672c8544038dca DIFF: https://github.com/llvm/llvm-project/commit/edeb0f49794c63d22a4c7fd6d2672c8544038dca.diff LO

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

aaron.ballman added a reviewer: jfb. aaron.ballman added a subscriber: jfb. aaron.ballman added a comment. Roping in @jfb because I know he's been heavily involve in WebAssembly in the past and he may have ideas/opinions. High-level question: are externref, funcref, and table types all part of t

[PATCH] D144709: [clang-format] Improve QualifierAlignment

AlexanderHederstaf updated this revision to Diff 501137. AlexanderHederstaf added a comment. Simplify insertQualifierAfter. Ignore decltype, typeof, and _Atomic. Set length of TT_TemplateCloser to 1. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144

[clang] 9e50578 - [C++20] [Modules] Trying to compare the trailing require clause from the primary template function

Author: Chuanqi Xu Date: 2023-02-28T23:41:48+08:00 New Revision: 9e50578ba43c49ee13ac3bb7d4868565824f9b29 URL: https://github.com/llvm/llvm-project/commit/9e50578ba43c49ee13ac3bb7d4868565824f9b29 DIFF: https://github.com/llvm/llvm-project/commit/9e50578ba43c49ee13ac3bb7d4868565824f9b29.diff LO

[PATCH] D144626: [C++20] [Modules] Trying to compare the trailing require clause of the primary template when performing ODR checking

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9e50578ba43c: [C++20] [Modules] Trying to compare the trailing require clause from the… (authored by ChuanqiXu). Repository: rG LLVM Github Monore

[PATCH] D144892: [clang][dataflow] unnamed bitfields should be discarded in InitListExpr

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG96d035c1dcd7: [clang][dataflow] unnamed bitfields should be discarded in InitListExpr (authored by paulsemel). Herald added a subscriber: cfe-commits

[clang] 96d035c - [clang][dataflow] unnamed bitfields should be discarded in InitListExpr

Author: Paul Semel Date: 2023-02-28T15:43:28Z New Revision: 96d035c1dcd795e3da76ef17796101006269f9c7 URL: https://github.com/llvm/llvm-project/commit/96d035c1dcd795e3da76ef17796101006269f9c7 DIFF: https://github.com/llvm/llvm-project/commit/96d035c1dcd795e3da76ef17796101006269f9c7.diff LOG: [c

[PATCH] D144709: [clang-format] Improve QualifierAlignment

AlexanderHederstaf added a comment. Discovered incorrect code generation for `llvm/include/llvm/ADT/StringMap.h`. using base = StringMapIterBase, const StringMapEntry>; was converted to, removing two characters. I checked the Token length in InsertQualifierAf

[PATCH] D144864: [Flang][Driver][MLIR] Add -fopenmp-is-device to Flang and link to an omp.is_device attribute

agozillon updated this revision to Diff 501141. agozillon added a comment. - [MLIR][OpenMP] Fix attribute helpers to apply to more than builtin.module Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144864/new/ https://reviews.llvm.org/D144864 Files

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos updated this revision to Diff 501143. pmatos marked an inline comment as done. pmatos added a comment. Address comments regarding tables and remove some unused code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139010/new/ https://reviews.l

[PATCH] D144889: [C2x] Support in freestanding

aaron.ballman added a comment. In D144889#4157257 , @jyknight wrote: > In D144889#4156974 , @rsmith wrote: > >> Likely because of GCC's perspective on this, the set of C headers provided >> by GCC, Clang, ICC, et

[PATCH] D144940: [clang][ExtractAPI] Handle platform specific unavailability correctly

Arsenic updated this revision to Diff 501148. Arsenic added a comment. Add test to check platform specific unavailability The update also remove the useless changes that were introduced by using clang format on the entire file instead of current commit. Repository: rG LLVM Github Monorepo CH

[PATCH] D144964: [clang][ExtractAPI] Handle platform specific unavailability correctly

Arsenic abandoned this revision. Arsenic added a comment. duplicate of https://reviews.llvm.org/D144940 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144964/new/ https://reviews.llvm.org/D144964 ___ cfe-

[PATCH] D144828: [clang-tidy] Add misc-header-include-cycle check

njames93 added a comment. This is a great check that I've been meaning to work on for ages but never had time. It mostly looks good but there are a few issues I feel there is another issue that this can be very spammy with diagnostics(though clang-tidy is likely suppressing the duplicated ones).

[clang] 00e2098 - [Clang] Implement CWG2518 - static_assert(false)

Author: Corentin Jabot Date: 2023-02-28T17:21:40+01:00 New Revision: 00e2098bf49f0ed45b3b8c22894cd3ac9a530e0f URL: https://github.com/llvm/llvm-project/commit/00e2098bf49f0ed45b3b8c22894cd3ac9a530e0f DIFF: https://github.com/llvm/llvm-project/commit/00e2098bf49f0ed45b3b8c22894cd3ac9a530e0f.diff

[PATCH] D144285: [Clang] Implement CWG2518 - static_assert(false)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG00e2098bf49f: [Clang] Implement CWG2518 - static_assert(false) (authored by cor3ntin). Changed prior to commit: https://reviews.llvm.org/D144285?v

[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

cor3ntin added a comment. @shafik Can you let me know if you are happy with the changes i made to address your feedback? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124351/new/ https://reviews.llvm.org/D124351 __

[PATCH] D144976: [clangd] Add provider info on symbol hover.

VitaNuo created this revision. VitaNuo added a reviewer: hokein. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repositor

[PATCH] D144940: [clang][ExtractAPI] Handle platform specific unavailability correctly

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. LGTM, It's worth noting that if the user specifies that an API is unavailable in a later redeclaration, this will be ignored. For example if I add a line to the test `void e(void) __attribute__((a

[PATCH] D144622: [clang[[ASTImporter] Import TemplateName correctly

balazske updated this revision to Diff 501161. balazske added a comment. Added a test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144622/new/ https://reviews.llvm.org/D144622 Files: clang/lib/AST/ASTImporter.cpp clang/unittests/AST/AST

[PATCH] D144976: [clangd] Add provider info on symbol hover.

VitaNuo updated this revision to Diff 501162. VitaNuo added a comment. Replace start with arrow for optional access. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144976/new/ https://reviews.llvm.org/D144976 Files: clang-tools-extra/clangd/Hover

[PATCH] D144977: [analyzer] Fix of the initialization list parsing.

earnol created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. earnol requested review of this revision. H

[PATCH] D144889: [C2x] Support in freestanding

bcraig added a comment. Let's talk about these use cases. > On the one hand, I think many users will want a libc that targets their > particular freestanding environment so that they get the best performance > characteristics (and other considerations) for their target. I think this fits kerne

[PATCH] D144272: [clang][Interp] Ignore StaticAssertDecls

shafik accepted this revision. shafik added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144272/new/ https://reviews.llvm.org/D144272 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D144967: [PowerPC] Recognize long CPU name for -mtune in Clang

nathanchance added a comment. Thanks for the fix, it appears to work fine for me against the kernel's `powernv_defconfig` target. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144967/new/ https://reviews.llvm.org/D144967 _

[PATCH] D143418: [libclang] Add API to override preamble storage path

vedgy added inline comments. Comment at: clang/tools/c-index-test/c-index-test.c:79 +Opts.PreambleStoragePath = NULL; +Opts.InvocationEmissionPath = getenv("CINDEXTEST_INVOCATION_EMISSION_PATH"); + aaron.ballman wrote: > vedgy wrote: > > aaron.ballman wr

[PATCH] D144709: [clang-format] Improve QualifierAlignment

rymiel added a comment. In D144709#4158555 , @AlexanderHederstaf wrote: > Discovered incorrect code generation for `llvm/include/llvm/ADT/StringMap.h`. > > using base = StringMapIterBase, > const StringMapEntry>; > > w

[clang] 8dbeb41 - [clang] Documents clang-scan-deps requirements.

Author: Mark de Wever Date: 2023-02-28T18:16:28+01:00 New Revision: 8dbeb41f8ebda2914433a8fb7ee1012602f20922 URL: https://github.com/llvm/llvm-project/commit/8dbeb41f8ebda2914433a8fb7ee1012602f20922 DIFF: https://github.com/llvm/llvm-project/commit/8dbeb41f8ebda2914433a8fb7ee1012602f20922.diff

[PATCH] D144894: [clang] Documents clang-scan-deps requirements.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8dbeb41f8ebd: [clang] Documents clang-scan-deps requirements. (authored by Mordante). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D144828: [clang-tidy] Add misc-header-include-cycle check

PiotrZSL added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/HeaderIncludeCycleCheck.cpp:106-110 +if (History.size() == 2U) { + Check.diag(Loc, "direct self-inclusion of header file '%0'") + << History.back(); + return; +}

[PATCH] D144889: [C2x] Support in freestanding

jyknight added a comment. > On the other hand, I think a not-insignificant number of users are interested > in freestanding environments for one-off/fun/experimental projects where ease > of access is more important than performance characteristics -- think: users > who are playing around with

[PATCH] D144981: [Driver] Allow to collect `-save-stats` data to a file specified in the environment variable.

vsapsai created this revision. vsapsai added reviewers: MatzeB, ahatanak. Herald added a subscriber: ributzka. Herald added a project: All. vsapsai requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Using two environment variables `CC_

[PATCH] D144967: [PowerPC] Recognize long CPU name for -mtune in Clang

nickdesaulniers accepted this revision. nickdesaulniers added a comment. This revision is now accepted and ready to land. Thanks for the patch! Comment at: clang/lib/Driver/ToolChains/Arch/PPC.cpp:37 -/// getPPCTargetCPU - Get the (LLVM) name of the PowerPC cpu we are targeti

[PATCH] D144680: [Coroutines] Avoid creating conditional cleanup markers in suspend block

weiwang updated this revision to Diff 501205. weiwang added a comment. add target triple Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144680/new/ https://reviews.llvm.org/D144680 Files: clang/lib/CodeGen/CGCoroutine.cpp clang/lib/CodeGen/CGEx

[PATCH] D144190: [AIX][clang] Storage Locations for Constant Pointers

qiongsiwu1 updated this revision to Diff 501211. qiongsiwu1 added a comment. Updating the release note and adding comments on the `-fdata-sections` requirement. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144190/new/ https://reviews.llvm.org/D14

[PATCH] D144866: [clang] Fix aggregate initialization inside lambda constexpr

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM, the modules failures is a previous known issue. Comment at: clang/lib/AST/ExprConstant.cpp:8763 if (isLambdaCallOperator(Info.CurrentCall->Callee)) { - // Ens

[PATCH] D144987: [clang][dataflow] Fix missed fields in field set construction.

ymandel created this revision. ymandel added reviewers: xazax.hun, sgatev, gribozavr2. Herald added subscribers: martong, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. When building the set of referenc

[PATCH] D144961: [NVPTX] Add f16 and v2f16 ldg builtins

tra accepted this revision. tra added inline comments. This revision is now accepted and ready to land. Comment at: llvm/test/CodeGen/NVPTX/ldu-ldg.ll:5-6 declare i8 @llvm.nvvm.ldu.global.i.i8.p1(ptr addrspace(1) %ptr, i32 %align) declare i32 @llvm.nvvm.ldu.global.i.i32.p1(pt

[PATCH] D143418: [libclang] Add API to override preamble storage path

aaron.ballman added inline comments. Comment at: clang/tools/c-index-test/c-index-test.c:79 +Opts.PreambleStoragePath = NULL; +Opts.InvocationEmissionPath = getenv("CINDEXTEST_INVOCATION_EMISSION_PATH"); + vedgy wrote: > aaron.ballman wrote: > > vedgy wr

[clang] 2ae3990 - Revert "[Modules] Don't check [temp.friend]p9 in ASTContext::isSameEntity"

Author: Mark de Wever Date: 2023-02-28T19:36:56+01:00 New Revision: 2ae39902506f38d6368a7dbe3d64109f57ad6f99 URL: https://github.com/llvm/llvm-project/commit/2ae39902506f38d6368a7dbe3d64109f57ad6f99 DIFF: https://github.com/llvm/llvm-project/commit/2ae39902506f38d6368a7dbe3d64109f57ad6f99.diff

[PATCH] D139028: [RFC][clang] Add attribute-like keywords

rsandifo-arm added a comment. Thanks @aaron.ballman and @erichkeane for the comments. I'll split it into stages and use tablegen more, like you say. In D139028#4150761 , @aaron.ballman wrote: > One thing that might also help is to split this into a fe

[PATCH] D144866: [clang] Fix aggregate initialization inside lambda constexpr

shafik added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:8763 if (isLambdaCallOperator(Info.CurrentCall->Callee)) { - // Ensure we actually have captured 'this'. (an error will have - // been previously reported if not). + // Ensure we actually

[PATCH] D144889: [C2x] Support in freestanding

aaron.ballman added a comment. In D144889#4158935 , @jyknight wrote: >> On the other hand, I think a not-insignificant number of users are >> interested in freestanding environments for one-off/fun/experimental >> projects where ease of access is more i

[clang] 003078b - [Clang][Driver] Add -mcpu=help and -mtune=help to clang

Author: Michael Maitland Date: 2023-02-28T10:45:35-08:00 New Revision: 003078b62d8d40fc000462a97c3b70e01cbe4458 URL: https://github.com/llvm/llvm-project/commit/003078b62d8d40fc000462a97c3b70e01cbe4458 DIFF: https://github.com/llvm/llvm-project/commit/003078b62d8d40fc000462a97c3b70e01cbe4458.di

[PATCH] D144914: [Clang][Driver] Add -mcpu=help to clang

This revision was automatically updated to reflect the committed changes. Closed by commit rG003078b62d8d: [Clang][Driver] Add -mcpu=help and -mtune=help to clang (authored by michaelmaitland). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144914/new

[PATCH] D144990: [Sema] Add missing entries to the arrays in GetImplicitConversionName and GetConversionRank.

craig.topper created this revision. craig.topper added reviewers: aaron.ballman, erichkeane. Herald added a project: All. craig.topper requested review of this revision. Herald added a project: clang. It appears that ICK_Zero_Queue_Conversion was inserted into the ICK enum without updating this ta

[clang] 73c9883 - [clang][dataflow] Fix missed fields in field set construction.

Author: Yitzhak Mandelbaum Date: 2023-02-28T18:56:54Z New Revision: 73c98831f6482371f9b773592478ea9e51a6b16a URL: https://github.com/llvm/llvm-project/commit/73c98831f6482371f9b773592478ea9e51a6b16a DIFF: https://github.com/llvm/llvm-project/commit/73c98831f6482371f9b773592478ea9e51a6b16a.diff

[PATCH] D144987: [clang][dataflow] Fix missed fields in field set construction.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG73c98831f648: [clang][dataflow] Fix missed fields in field set construction. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES S

[clang] 33e18cb - Revert "Revert "[Modules] Don't check [temp.friend]p9 in ASTContext::isSameEntity""

Author: Mark de Wever Date: 2023-02-28T20:03:54+01:00 New Revision: 33e18cb6ce7a478d3c381c1c7ef2501787fed6f4 URL: https://github.com/llvm/llvm-project/commit/33e18cb6ce7a478d3c381c1c7ef2501787fed6f4 DIFF: https://github.com/llvm/llvm-project/commit/33e18cb6ce7a478d3c381c1c7ef2501787fed6f4.diff

[PATCH] D144990: [Sema] Add missing entries to the arrays in GetImplicitConversionName and GetConversionRank.

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, good catch and nice solution! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144990/new/ https://reviews.llvm.org/D144990 __

[clang] 8ce6896 - [Sema] Add missing entries to the arrays in GetImplicitConversionName and GetConversionRank.

Author: Craig Topper Date: 2023-02-28T11:16:45-08:00 New Revision: 8ce68969b90288a3dc75c5c15283fc11f97b278a URL: https://github.com/llvm/llvm-project/commit/8ce68969b90288a3dc75c5c15283fc11f97b278a DIFF: https://github.com/llvm/llvm-project/commit/8ce68969b90288a3dc75c5c15283fc11f97b278a.diff

[PATCH] D144990: [Sema] Add missing entries to the arrays in GetImplicitConversionName and GetConversionRank.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8ce68969b902: [Sema] Add missing entries to the arrays in GetImplicitConversionName and… (authored by craig.topper). Repository: rG LLVM Github Mo

[PATCH] D144993: [OpenMP]Emit captured decls for target data if no devices were specified.

ABataev created this revision. ABataev added a reviewer: jhuber6. Herald added subscribers: guansong, yaxunl. Herald added a project: All. ABataev requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Herald added a project: clang. If use_devic

[PATCH] D144914: [Clang][Driver] Add -mcpu=help to clang

MaskRay added a comment. Sorry I just saw this but I am not sure this is a good idea. Why can't the user use `--print-supported-cpus` instead? The additional alias doesn't seem useful. If you can make GCC add this as well, it will be different. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D144914: [Clang][Driver] Add -mcpu=help to clang

MaskRay added a comment. FWIW I think this should be reverted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144914/new/ https://reviews.llvm.org/D144914 ___ cfe-commits mailing list cfe-commits@lists.ll

  1   2   >