[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

carlosgalvezp updated this revision to Diff 487844. carlosgalvezp marked 3 inline comments as done. carlosgalvezp added a comment. Revert changes to CheckOptions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141144/new/ https://reviews.llvm.org/D14

[PATCH] D141144: [clang-tidy][doc] Improve clang-tidy documentation

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/ClangTidyMain.cpp:34 +static StringRef TrimFirstChar(StringRef x) { return x.substr(1); } + njames93 wrote: > This seems a bit of a needless change, if you want to remove the ne

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137517/new/ https://reviews.llvm.org/D137517 ___

[PATCH] D141391: [NFC] [clang-tools-extra] Alphabetize clang-tidy release notes

carlosgalvezp added a comment. In D141391#4040044 , @Eugene.Zelenko wrote: > In D141391#4040002 , @ccotter wrote: > >> I can't land these myself, so if you are able to, would you mind doing so? >> Thanks! > > @c

[PATCH] D141350: Fix runtime problem for base class member data used in target region.

jyu2 updated this revision to Diff 487845. jyu2 added a comment. Thanks Alexey for code review. This is to address his comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141350/new/ https://reviews.llvm.org/D141350 Files: clang/lib/CodeGen

[PATCH] D141350: Fix runtime problem for base class member data used in target region.

jyu2 added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:8490 +if (MD) + if (const CXXRecordDecl *RD = dyn_cast(MD->getParent())) +HasBaseClass = RD->getNumBases() > 0; ABataev wrote: > `const auto *RD = dyn_cast(MD->getParen

[clang-tools-extra] 9fff1dd - [NFC] [clang-tools-extra] Alphabetize clang-tidy release notes

Author: Chris Cotter Date: 2023-01-10T17:37:19Z New Revision: 9fff1ddb560cbb14ba661af2c33b768f3071be9a URL: https://github.com/llvm/llvm-project/commit/9fff1ddb560cbb14ba661af2c33b768f3071be9a DIFF: https://github.com/llvm/llvm-project/commit/9fff1ddb560cbb14ba661af2c33b768f3071be9a.diff LOG:

[PATCH] D141391: [NFC] [clang-tools-extra] Alphabetize clang-tidy release notes

This revision was automatically updated to reflect the committed changes. Closed by commit rG9fff1ddb560c: [NFC] [clang-tools-extra] Alphabetize clang-tidy release notes (authored by ccotter, committed by carlosgalvezp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D141107: [clang-tidy] don't warn when returning the result for bugprone-standalone-empty

cjdb accepted this revision. cjdb added a comment. This revision is now accepted and ready to land. Excellent, let's wait for @denik's feedback before merging, but this LGTM. Thank you for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14

[PATCH] D139705: [clang] fix zero-initialization fix-it for variable template

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:3863 + SourceLocation EndLoc = VD->getEndLoc(); + if (const auto *VTSD = dyn_cast(VD)) { v1nh1shungry wrote: > aaron.ballman wrote: > > erichkeane wrote: > > > Hmm... it is strange to m

[PATCH] D141350: Fix runtime problem for base class member data used in target region.

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141350/new/ https://reviews.llvm.org/D141350 ___

[PATCH] D139705: [clang] fix zero-initialization fix-it for variable template

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:3863 + SourceLocation EndLoc = VD->getEndLoc(); + if (const auto *VTSD = dyn_cast(VD)) { erichkeane wrote: > v1nh1shungry wrote: > > aaron.ballman wrote: > > > erichkeane wrote: > >

[PATCH] D139705: [clang] fix zero-initialization fix-it for variable template

v1nh1shungry added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:3863 + SourceLocation EndLoc = VD->getEndLoc(); + if (const auto *VTSD = dyn_cast(VD)) { aaron.ballman wrote: > erichkeane wrote: > > v1nh1shungry wrote: > > > aaron.ballman wrote: >

[PATCH] D141283: [clang] Improve diagnostic for "initializer-string for char array is too long"

evansmal added a comment. Thanks all for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141283/new/ https://reviews.llvm.org/D141283 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D140639: clang: Fix handling of __builtin_elementwise_copysign

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140639/new/ https://reviews.llvm.org/D140639 ___ cfe-commits mailing lis

[PATCH] D139705: [clang] fix zero-initialization fix-it for variable template

v1nh1shungry added inline comments. Comment at: clang/test/FixIt/fixit-const-var-init.cpp:24 + +template <> constexpr float d; // expected-error {{must be initialized by a constant expression}} +// CHECK: fix-it:"{{.*}}":{24:42-24:42}:" = 0.0" aaron.ballman wrot

[PATCH] D140547: Perform access checking to private members in simple requirement.

usaxena95 updated this revision to Diff 487865. usaxena95 marked 6 inline comments as done. usaxena95 added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140547/new/ https://reviews.llvm.org/D140547 Files: clang/in

[PATCH] D140547: Perform access checking to private members in simple requirement.

usaxena95 added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:1375 +if (Trap.hasErrorOccurred()) + TransReq.getAs()->setSatisfied(false); + } ilya-biryukov wrote: > ilya-biryukov wrote: > > `TransReq` may be `ExprEr

[clang] 2e9c663 - clang/AMDGPU: Add missing tests for some builtin

Author: Matt Arsenault Date: 2023-01-10T13:07:01-05:00 New Revision: 2e9c663ab4a0385e619a64bc0726be0bb178c0b1 URL: https://github.com/llvm/llvm-project/commit/2e9c663ab4a0385e619a64bc0726be0bb178c0b1 DIFF: https://github.com/llvm/llvm-project/commit/2e9c663ab4a0385e619a64bc0726be0bb178c0b1.diff

[PATCH] D140547: Perform access checking to private members in simple requirement.

usaxena95 updated this revision to Diff 487866. usaxena95 added a comment. Remove new lines. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140547/new/ https://reviews.llvm.org/D140547 Files: clang/include/clang/AST/ExprConcepts.h clang/lib/Par

[PATCH] D140867: [C++20] [Modules] Don't generate global ctors/dtors for variables which are available externally

Jake-Egan added a comment. In D140867#4038388 , @ChuanqiXu wrote: > In D140867#4036239 , @Jake-Egan > wrote: > >> Hi, this test is failing on AIX, could you take a look please? >> https://lab.llvm.org/buildbot/#

[PATCH] D141107: [clang-tidy] don't warn when returning the result for bugprone-standalone-empty

denik accepted this revision. denik added a comment. Thanks @v1nh1shungry for the fix! The change and test cases look good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141107/new/ https://reviews.llvm.org/D141107 __

[PATCH] D139705: [clang] fix zero-initialization fix-it for variable template

aaron.ballman added inline comments. Comment at: clang/test/FixIt/fixit-const-var-init.cpp:24 + +template <> constexpr float d; // expected-error {{must be initialized by a constant expression}} +// CHECK: fix-it:"{{.*}}":{24:42-24:42}:" = 0.0" v1nh1shungry wrot

[PATCH] D141381: [codegen] Store address of indirect arguments on the stack

probinson added a subscriber: wolfgangp. probinson added a comment. Basically you're homing a pointer to the parameter, rather than the parameter itself, which makes sense in this context. I suspect the code size/perf impact on -O0 will not be huge, as this sounds like it's only for byval-but-n

[PATCH] D141051: [CUDA][HIP] Add support for `--offload-arch=native` to CUDA and refactor

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141051/new/ https://reviews.llvm.org/D141051 __

[PATCH] D139774: [libclang] Add API to set temporary directory location

aaron.ballman added a comment. In D139774#4040057 , @vedgy wrote: > In D139774#4039975 , @aaron.ballman > wrote: > >> Oh that is a good point! Apologies for not noticing that earlier -- that >> makes me wonder i

[PATCH] D139986: [clang][TypePrinter] Teach isSubstitutedDefaultArgument about integral types

dblaikie added a comment. In D139986#4040208 , @erichkeane wrote: > In D139986#4040185 , @ldionne wrote: > >> @dblaikie >> >> We added the libc++ tests to the Clang pre-commit CI after discussing with >> @erichk

[PATCH] D140992: clang: Add __builtin_elementwise_fma

aaron.ballman added inline comments. Herald added a subscriber: StephenFan. Comment at: clang/lib/Sema/SemaChecking.cpp:2615 QualType ArgTy = TheCall->getArg(0)->getType(); -QualType EltTy = ArgTy; - -if (auto *VecTy = EltTy->getAs()) - EltTy = VecTy->getElement

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:565 +returning a value. They can not write to memory, but may read memory that is +immutable between invocations of the function. + erichkeane wrote: > A quick sentence somewhere

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

erichkeane added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:565 +returning a value. They can not write to memory, but may read memory that is +immutable between invocations of the function. + lebedev.ri wrote: > erichkeane wrote: > > A qui

[PATCH] D140059: [APSInt] Fix bug in APSInt mentioned in https://github.com/llvm/llvm-project/issues/59515

Peter marked an inline comment as done. Peter added a comment. Herald added a subscriber: StephenFan. @pcc @efriedma Would you mind review the changes to clang when you are free? If they look good I'll merge them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D141414: [clang] add warning on shifting boolean type

angelomatnigoogle created this revision. angelomatnigoogle added reviewers: arsenm, shafik. Herald added a project: All. angelomatnigoogle requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang. Warn on operations "b << x" and "b >> x" Github

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

jrtc27 added inline comments. Comment at: llvm/lib/Target/RISCV/RISCV.td:581 + list f = []> + : ProcessorModel; + Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137517/new/ https:

[PATCH] D135405: fix handling of braced-init temporaries for modernize-use-emplace

BigPeet added a comment. GitHub username: BigPeet GitHub email: pwolf2...@gmail.com Thanks for your quick response. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135405/new/ https://reviews.llvm.org/D135405 ___

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

aaron.ballman added a comment. Precommit CI seems to have found relevant issues that need to be addressed. Comment at: clang/include/clang/Basic/Attr.td:4133 +def NoUnwind : DeclOrStmtAttr { + let Spellings = [Clang<"nounwind", /*allowInC =*/0>]; + let Accessors = [Accessor<"

[PATCH] D141414: [clang] add warning on shifting boolean type

shafik added a subscriber: aaron.ballman. shafik added a comment. Hey @aaron.ballman I made some suggestions in the bug report: https://github.com/llvm/llvm-project/issues/28334 do you think this is a reasonable approach? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D137753: [Clang][AIX][p]Enable -p Functionality

francii updated this revision to Diff 487907. francii added a comment. Add supports profiling check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137753/new/ https://reviews.llvm.org/D137753 Files: clang/include/clang/Basic/CodeGenOptions.def

[PATCH] D14119: [libcxxabi] Correctly align fallback heap

jdoerfert added a comment. > jdoerfert added a commit: rG10410534696e > : > [CallGraph][FIX] Ensure generic intrinsics are represented in the CG. My bad, I copied the review ID and dropped a 0. Supposed to be https://reviews.

[clang] 2ad4c3c - clang: Fix handling of __builtin_elementwise_copysign

Author: Matt Arsenault Date: 2023-01-10T14:45:23-05:00 New Revision: 2ad4c3c88d884684a3efb42181e87fe305df51bd URL: https://github.com/llvm/llvm-project/commit/2ad4c3c88d884684a3efb42181e87fe305df51bd DIFF: https://github.com/llvm/llvm-project/commit/2ad4c3c88d884684a3efb42181e87fe305df51bd.diff

[clang] 1fbbf92 - [perf-training] Check extension in findFilesWithExtension

Author: Amir Ayupov Date: 2023-01-10T11:46:51-08:00 New Revision: 1fbbf92e4fda3c7a3be1c02e1f7240135557846d URL: https://github.com/llvm/llvm-project/commit/1fbbf92e4fda3c7a3be1c02e1f7240135557846d DIFF: https://github.com/llvm/llvm-project/commit/1fbbf92e4fda3c7a3be1c02e1f7240135557846d.diff L

[PATCH] D141342: [perf-training] Check extension in findFilesWithExtension

This revision was automatically updated to reflect the committed changes. Closed by commit rG1fbbf92e4fda: [perf-training] Check extension in findFilesWithExtension (authored by Amir). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141342/new/ https:

[PATCH] D140639: clang: Fix handling of __builtin_elementwise_copysign

arsenm closed this revision. arsenm added a comment. 2ad4c3c88d884684a3efb42181e87fe305df51bd CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140639/new/ https://reviews.llvm.org/D140639 __

[PATCH] D141047: build: with -DCLANGD_ENABLE_REMOTE=ON, search for grpc++ dependencies too

serge-sans-paille accepted this revision. serge-sans-paille added a comment. This revision is now accepted and ready to land. LGTM, assuming, you actually tested that locally. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141047/new/ https://review

[PATCH] D137113: [Clang] refactor CodeGenFunction::EmitAsmStmt NFC

nickdesaulniers updated this revision to Diff 487927. nickdesaulniers added a comment. - rebase, format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137113/new/ https://reviews.llvm.org/D137113 Files: clang/lib/CodeGen/CGStmt.cpp Index: clang/

[PATCH] D136497: [Clang] support for outputs along indirect edges of asm goto

nickdesaulniers updated this revision to Diff 487929. nickdesaulniers added a comment. - rebase, format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136497/new/ https://reviews.llvm.org/D136497 Files: clang/docs/LanguageExtensions.rst clang/d

[PATCH] D140508: [clang] fix -Wuninitialized for asm goto outputs on indirect edges.

nickdesaulniers updated this revision to Diff 487931. nickdesaulniers added a comment. - rebase, format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140508/new/ https://reviews.llvm.org/D140508 Files: clang/lib/Analysis/UninitializedValues.cpp

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri added inline comments. Comment at: clang/include/clang/Basic/Attr.td:4133 +def NoUnwind : DeclOrStmtAttr { + let Spellings = [Clang<"nounwind", /*allowInC =*/0>]; + let Accessors = [Accessor<"isClangNoUnwind", [CXX11<"clang", "nounwind">]>]; aaron.ba

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri updated this revision to Diff 487933. lebedev.ri marked 10 inline comments as done. lebedev.ri added a comment. @aaron.ballman thank you for taking a look! Addressed all review notes other than the SEH question and the simplehandler one. (i'll deal with whitespace changes when committi

[PATCH] D141047: build: with -DCLANGD_ENABLE_REMOTE=ON, search for grpc++ dependencies too

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9f3081dc6fe8: build: with -DCLANGD_ENABLE_REMOTE=ON, search for grpc++ dependencies too (authored by sylvestre.ledru). Repository: rG LLVM Github

[PATCH] D141389: [DFSAN] Add support for strnlen, strncat, strsep, sscanf and _tolower

tkuchta updated this revision to Diff 487936. tkuchta added a comment. applied newer version of clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141389/new/ https://reviews.llvm.org/D141389 Files: compiler-rt/lib/dfsan/dfsan_custom.cpp compiler-rt/lib/dfsan/done_abilist.t

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

arphaman updated this revision to Diff 487944. arphaman marked 3 inline comments as done. arphaman added a comment. Herald added a subscriber: jdoerfert. Updated to address review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141324/new/ https://reviews.llvm.org/D141324 Files

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

arphaman added a comment. In D141324#4039629 , @erichkeane wrote: > I'm disturbed that the string-literal diagnostic you changed never shows up > in the tests. I suspect this attribute needs significantly better test > coverage. Please elaborate. All

[PATCH] D140059: [APSInt] Fix bug in APSInt mentioned in https://github.com/llvm/llvm-project/issues/59515

Peter updated this revision to Diff 487946. Peter added a comment. use const ref Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140059/new/ https://reviews.llvm.org/D140059 Files: clang/lib/CodeGen/CGDebugInfo.cpp llvm/include/llvm/ADT/APSInt.h

[PATCH] D139774: [libclang] Add API to set temporary directory location

vedgy added a comment. In D139774#4040705 , @aaron.ballman wrote: > At a point where we have a `CIndexer` object, we eventually call > `ASTUnit::LoadFromCommandLine()` and `ASTUnit` has a member > `FileSystemOptions FileSystemOpts`, and `FileSystemOpti

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

dblaikie added inline comments. Comment at: clang/lib/Driver/Driver.cpp:5733-5735 + if (!AtTopLevel && isa(JA) && + JA.getType() == types::TY_ModuleFile && + C.getArgs().hasArg(options::OPT_fmodule_output) && These conditions might be shared with the p

[PATCH] D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.

ldionne added subscribers: fahad, rprichard, MaskRay. ldionne added a comment. The code in libunwind does look fishy to me (before the change), so I think flagging this in the compiler is good. I don't know that code at all, though, so I'm pinging a few libunwind regulars so they can let us know

[PATCH] D141422: [clang][sema][Matrix] Move code from try-cast to `TypeLocVisitor`. NFC intended.

vsapsai created this revision. vsapsai added a reviewer: fhahn. Herald added subscribers: StephenFan, tschuett, ributzka. Herald added a project: All. vsapsai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `MatrixTypeLoc` is not "sugar" `T

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

erichkeane added a comment. In D141324#4041159 , @arphaman wrote: > In D141324#4039629 , @erichkeane > wrote: > >> I'm disturbed that the string-literal diagnostic you changed never shows up >> in the tests. I

[PATCH] D139114: [Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.

fahadnayyar updated this revision to Diff 487955. fahadnayyar retitled this revision from "[Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator. " to "[Clang][Sema] Enabled implicit conversion warning for CompoundAssignment operator.". fahadnayyar added a comment.

[PATCH] D141423: Trigger the Clang/libc++ CI pipeline even when libc++ has been modified

ldionne created this revision. Herald added subscribers: mstorsjo, arichardson. Herald added a project: All. ldionne requested review of this revision. Herald added projects: clang, libc++. Herald added subscribers: libcxx-commits, cfe-commits. Herald added a reviewer: libc++. Previously, we would

[PATCH] D141424: [clang][Sema] Fix uninitialized `SourceLocation` for types with multiple attributes and macros.

vsapsai created this revision. vsapsai added reviewers: rnk, leonardchan, yonghong-song. Herald added a subscriber: ributzka. Herald added a project: All. vsapsai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Some `TypeLoc`s are considere

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:4133 +def NoUnwind : DeclOrStmtAttr { + let Spellings = [Clang<"nounwind", /*allowInC =*/0>]; + let Accessors = [Accessor<"isClangNoUnwind", [CXX11<"clang", "nounwind">]>]; lebed

[PATCH] D141424: [clang][Sema] Fix uninitialized `SourceLocation` for types with multiple attributes and macros.

vsapsai updated this revision to Diff 487959. vsapsai added a comment. clang-format the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141424/new/ https://reviews.llvm.org/D141424 Files: clang/lib/Sema/SemaType.cpp clang/unittests/AST/S

[PATCH] D141008: [Clang][SPIR-V] Emit target extension types for OpenCL types on SPIR-V.

jcranmer-intel added a comment. Comment at: clang/lib/CodeGen/CGOpenCLRuntime.cpp:80 + + if (useSPIRVTargetExtType(CGM)) { +switch (cast(T)->getKind()) { Anastasia wrote: > Perhaps it's best to split into separate functions and reflect in naming what > t

[PATCH] D141008: [Clang][SPIR-V] Emit target extension types for OpenCL types on SPIR-V.

jcranmer-intel updated this revision to Diff 487960. jcranmer-intel added a comment. Fix some of the code review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141008/new/ https://reviews.llvm.org/D141008 Files: clang/include/clang-c/In

[PATCH] D141422: [clang][sema][Matrix] Move code from try-cast to `TypeLocVisitor`. NFC intended.

vsapsai added a comment. Doing this minor clean-up for D141424 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141422/new/ https://reviews.llvm.org/D141422 ___ cfe-commi

[PATCH] D141424: [clang][Sema] Fix uninitialized `SourceLocation` for types with multiple attributes and macros.

vsapsai added a comment. Want to note that originally the issue was noticed with the modules because we serialize and deserialize `PointerTypeLoc::starLoc` and on deserialization we assert if the value is too big. With uninitialized memory the value can be too big //sometimes// and clang was fa

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

fpetrogalli updated this revision to Diff 487962. fpetrogalli added a comment. Formatting changes in RISCV.td (NFC). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137517/new/ https://reviews.llvm.org/D137517 Files: clang/lib/Basic/Targets/RISCV.

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri marked 2 inline comments as done. lebedev.ri added inline comments. Comment at: clang/include/clang/Basic/Attr.td:4138 + "functions and statements">; + let SimpleHandler = 1; +} aaron.ballman wrote: > lebedev.ri wrote: > >

[PATCH] D139774: [libclang] Add API to set temporary directory location

aaron.ballman added a comment. In D139774#4041169 , @vedgy wrote: > In D139774#4040705 , @aaron.ballman > wrote: > >> At a point where we have a `CIndexer` object, we eventually call >> `ASTUnit::LoadFromCommand

[PATCH] D133392: [MTE] Add AArch64GlobalsTagging Pass

eugenis accepted this revision. eugenis added a comment. LGTM Comment at: llvm/lib/CodeGen/GlobalMerge.cpp:655 +// Don't merged tagged globals, as each global should have its own unique +// memory tag at runtime. TODO(hctim): This can be relaxed: constant globals ---

[PATCH] D141375: [SYCL][OpenMP] Fix compilation errors for unsupported __bf16 intrinsics

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. LGTM. I expect this to be a common issue for all single-source offloading programming models (i.e. CUDA and HIP in addition to SYCL and OpenMP offload). Probably we can generalize the code patt

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

bnbarham accepted this revision. bnbarham added a comment. This revision is now accepted and ready to land. LGTM, thanks Alex! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141324/new/ https://reviews.llvm.org/D141324 ___ cfe-commits mailing

[PATCH] D141324: [clang] extend external_source_symbol attribute with the USR clause

erichkeane requested changes to this revision. erichkeane added a comment. This revision now requires changes to proceed. Note both the Clang maintainer, and attributes maintainer have requested changes in some way, please let that finish before committing. CHANGES SINCE LAST ACTION https://r

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Attr.td:4138 + "functions and statements">; + let SimpleHandler = 1; +} lebedev.ri wrote: > aaron.ballman wrote: > > lebedev.ri wrote: > > > aaron.ballman wrot

[PATCH] D140795: [Flang] Add user option -funderscoring/-fnounderscoring to enable/disable ExternalNameConversionPass

kkwli0 added a comment. In D140795#4033559 , @awarzynski wrote: >> However, I don't think the patch does what we want. Given a procedure name >> `foo`, the `-fno-underscoring` option will give `_QPfoo` instead of `foo`. >> We will look into it. > > Nam

[PATCH] D138958: [clang] Better UX for Clang’s unwind-affecting attributes

lebedev.ri marked 2 inline comments as done. lebedev.ri added inline comments. Comment at: clang/include/clang/Basic/Attr.td:4138 + "functions and statements">; + let SimpleHandler = 1; +} aaron.ballman wrote: > lebedev.ri wrote: > >

[PATCH] D141283: [clang] Improve diagnostic for "initializer-string for char array is too long"

shafik accepted this revision. shafik added a comment. LGTM Comment at: clang/test/CXX/dcl.decl/dcl.init/dcl.init.string/p2.cpp:2 // RUN: %clang_cc1 -fsyntax-only -verify %s -char test1[1]="f"; // expected-error {{initializer-string for char array is too long}} +char test1[1]

[PATCH] D141432: Add two additional float8 types to MLIR and APFloat.

jakeh-gc created this revision. Herald added subscribers: Moerafaat, zero9178, bzcheeseman, sdasgup3, wenzhicui, wrengr, cota, teijeong, rdzhabarov, tatianashp, msifontes, jurahul, Kayjukh, grosul1, Joonsoo, liufengdb, aartbik, mgester, arpith-jacob, antiagainst, shauheen, rriddle, mehdi_amini,

[PATCH] D141384: [clang][dataflow] Fix 2 bugs in `MemberExpr` interpretation.

gribozavr2 added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141384/new/ https://reviews.llvm.org/D141384 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[clang] b597992 - Revert "[perf-training] Check extension in findFilesWithExtension"

Author: Amir Aupov Date: 2023-01-10T14:22:36-08:00 New Revision: b59799241b3902a460c3b1156477af369934a13e URL: https://github.com/llvm/llvm-project/commit/b59799241b3902a460c3b1156477af369934a13e DIFF: https://github.com/llvm/llvm-project/commit/b59799241b3902a460c3b1156477af369934a13e.diff LO

Re: [clang] b597992 - Revert "[perf-training] Check extension in findFilesWithExtension"

Reminder to please always mention the reason for the revert/recommit in the commit message. On Wed, Jan 11, 2023 at 1:22 AM Amir Aupov via cfe-commits wrote: > > > Author: Amir Aupov > Date: 2023-01-10T14:22:36-08:00 > New Revision: b59799241b3902a460c3b1156477af369934a13e > > URL: > https://git

[PATCH] D140956: [clang-format] Add an option for breaking after C++11 attributes

owenpan added a comment. In D140956#4038988 , @krasimir wrote: > It looks like this regressed the following example: > > % cat test.cc # formatted with older clang-format > a > &cc() {

[PATCH] D141437: [HIP] Use .hipi as preprocessor output extension

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added a project: All. yaxunl requested review of this revision. Herald added a subscriber: MaskRay. so that clang can recognize it and handle it automatically without -x hip-cpp-output https://reviews.llvm.org/D141437 Files:

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

paulkirth updated this revision to Diff 487999. paulkirth added a comment. Rebase. - Switch to multi-line remarks - Update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135488/new/ https://reviews.llvm.org/D135488 Files: clang/test/Fronte

[PATCH] D141440: [OpenMP] Adjust phases for AMDGPU offloading for OpenMP in save-temps mode

jhuber6 created this revision. jhuber6 added reviewers: arsenm, jdoerfert, tianshilei1992, yaxunl, JonChesterfield. Herald added subscribers: kosarev, kerbowa, guansong, tpr, dstuttard, jvesely, kzhuravl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscri

[PATCH] D140584: [Clang] Refactor "Designators" into a unified implementation [NFC]

void updated this revision to Diff 488005. void added a comment. Use EllipsisLoc instead of one of the Brackets. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140584/new/ https://reviews.llvm.org/D140584 Files: clang-tools-extra/clangd/FindTarge

[PATCH] D129570: [clang-tidy] Add new clang-tidy check to find implicit conversions from enum to integer.

pfultz2 added a comment. I would like to see this merged in. Is there anyone available to review or approve? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129570/new/ https://reviews.llvm.org/D129570 __

[PATCH] D141283: [clang] Improve diagnostic for "initializer-string for char array is too long"

evansmal updated this revision to Diff 488012. evansmal added a comment. Added additional test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141283/new/ https://reviews.llvm.org/D141283 Files: clang/include/clang/Basic/DiagnosticSemaKinds.t

[PATCH] D141441: [clang] Add ElaboratedType sugaring for types on implicit special members

brad.king created this revision. Herald added a subscriber: arphaman. Herald added a project: All. brad.king requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Extend the change from commit 15f3cd6bfc67

[PATCH] D141441: [clang] Add ElaboratedType sugaring for types on implicit special members

brad.king updated this revision to Diff 488021. brad.king edited the summary of this revision. brad.king added a comment. Clarify commit message Revise the message to clarify the changes are for implicitly generated members. Also link to the corresponding issue with a full URL. Repository: r

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

paulkirth updated this revision to Diff 488023. paulkirth added a comment. Add test for YAML output Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135488/new/ https://reviews.llvm.org/D135488 Files: clang/test/Frontend/stack-layout-remark.c llv

[PATCH] D135488: [codegen] Add a remarks based Stack Layout Analysis pass

thegameg added a comment. This looks great, thanks for updating this! A few more comments inline. Comment at: llvm/lib/CodeGen/StackFrameLayoutAnalysisPass.cpp:55 +Variable, // a Slot used to store a local data (could be a tmp) +Error // Its an error for

[clang] 07aaae1 - [NFC][AIX] Temporarily XFAIL test while investigating

Author: Jake Egan Date: 2023-01-10T19:53:44-05:00 New Revision: 07aaae13037dadcbf3988fb503c83fd90a3310b1 URL: https://github.com/llvm/llvm-project/commit/07aaae13037dadcbf3988fb503c83fd90a3310b1 DIFF: https://github.com/llvm/llvm-project/commit/07aaae13037dadcbf3988fb503c83fd90a3310b1.diff LOG

[PATCH] D141447: clang/OpenCL: Don't use a Function for the block type

arsenm created this revision. arsenm added reviewers: yaxunl, Anastasia. Herald added subscribers: kosarev, tpr. Herald added a project: All. arsenm requested review of this revision. Herald added a subscriber: wdng. The AMDGPU value for this is not really a function. Currently we're emitting IR t

[PATCH] D141310: [clang] add -Wcompare-function-pointers

cjdb added a comment. Thanks for working on this! Needs a bit of work, but we should be able to get this in very soon methinks. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7006 +def warn_typecheck_comparison_of_function_pointers : Warning< + "comparison of fu

[PATCH] D141310: [clang] add -Wcompare-function-pointers

cjdb added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7007 + "comparison of function pointers (%0 and %1)">, + InGroup, DefaultIgnore; def warn_typecheck_ordered_comparison_of_function_pointers : Warning< cjdb wrote: > It's v

[PATCH] D141448: [CMake][Fuchsia] Include llvm-ml in Fuchsia toolchain

haowei created this revision. haowei added a reviewer: phosek. Herald added a subscriber: abrachet. Herald added a project: All. haowei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change includes llvm-ml tool in Fuchsia toolchain.

[PATCH] D141448: [CMake][Fuchsia] Include llvm-ml in Fuchsia toolchain

phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141448/new/ https://reviews.llvm.org/D141448 ___

[PATCH] D141449: clang/OpenCL: Fix not setting convergent on block invoke kernels

arsenm created this revision. arsenm added reviewers: Anastasia, yaxunl, jdoerfert. Herald added subscribers: kosarev, kerbowa, jvesely. Herald added a project: All. arsenm requested review of this revision. Herald added a subscriber: wdng. Yet another example how convergent not being the default

<    1   2   3   >