[PATCH] D140543: [clang-format] Add an option to format integer literal separators

owenpan updated this revision to Diff 485188. owenpan added a comment. This revision is now accepted and ready to land. - Fixed an assertion failure. - Added unit tests . - Moved all unit tests to another file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140543/new/ https://reviews.ll

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140543/new/ https://reviews.llvm.org/D140543 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary 1 or 5)

jmciver added a comment. As Nuno mentioned we are targeting the proposal for next week. I will update the ticket with the Discourse link once it becomes available. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134410/new/ https://reviews.llvm.org/

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

efriedma added inline comments. Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1926 +DiagnosticsEngine &Diags = CGM.getContext().getDiagnostics(); +Diags.Report(diag::warn_for_global_ctor_for_dllimport) << D; +return nullptr;

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

owenpan updated this revision to Diff 485210. owenpan added a comment. Cleaned up the unit tests a little bit: - Made them a little more varied. - Removed some overlapping test cases. - Removed integer literal suffixes for JavaScript. - Added an octal `BigInt` test case for JavaScript. CHANGES

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG46c94e5067b5: [clang-format] Add an option to format integer literal separators (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGE

[clang] 46c94e5 - [clang-format] Add an option to format integer literal separators

Author: Owen Pan Date: 2022-12-24T15:35:17-08:00 New Revision: 46c94e5067b5f396c24bb950505c79bc819bd4b8 URL: https://github.com/llvm/llvm-project/commit/46c94e5067b5f396c24bb950505c79bc819bd4b8 DIFF: https://github.com/llvm/llvm-project/commit/46c94e5067b5f396c24bb950505c79bc819bd4b8.diff LOG:

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

thakis added a comment. This seems to break tests everywhere, eg http://45.33.8.238/linux/95289/step_7.txt Please take a look and revert for now if it takes a while to fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140543/new/ https://reviews

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

owenpan added a comment. In D140543#4016156 , @thakis wrote: > This seems to break tests everywhere, eg > http://45.33.8.238/linux/95289/step_7.txt > > Please take a look and revert for now if it takes a while to fix. I had run FormatTests on Windows an

[clang] 879bd91 - [clang-format] Disable FixRanges in IntegerLiteralSeparatorTest

Author: Owen Pan Date: 2022-12-24T18:55:24-08:00 New Revision: 879bd9146a2c9ea395abd7c1ebd0f76f414a4967 URL: https://github.com/llvm/llvm-project/commit/879bd9146a2c9ea395abd7c1ebd0f76f414a4967 DIFF: https://github.com/llvm/llvm-project/commit/879bd9146a2c9ea395abd7c1ebd0f76f414a4967.diff LOG:

[PATCH] D140543: [clang-format] Add an option to format integer literal separators

thakis added a comment. In D140543#4016181 , @owenpan wrote: > In D140543#4016156 , @thakis wrote: > >> This seems to break tests everywhere, eg >> http://45.33.8.238/linux/95289/step_7.txt >> >> Please take a lo

[PATCH] D140657: [Clang] Move AMDGPU IAS enabling to Generic_GCC::IsIntegratedAssemblerDefault, NFC

brad updated this revision to Diff 485218. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140657/new/ https://reviews.llvm.org/D140657 Files: clang/lib/Driver/ToolChains/AMDGPU.