[PATCH] D136554: Implement CWG2631

cor3ntin added a comment. In D136554#3986713 , @aeubanks wrote: > yes, it was chrome > I went ahead and tried the latest patch, it successfully compiles the file > that crashed before. I built all of chrome, and now I'm getting one last > linker error,

[PATCH] D112932: [WIP] Use llvm.is_fpclass to implement FP classification functions

sepavloff updated this revision to Diff 481901. sepavloff added a comment. Herald added a subscriber: pengfei. Prepare the patch for review In this patch the callback `TargetCodeGenInfo::testFPKind` is preserved, to make this change safer. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D136554: Implement CWG2631

cor3ntin added a comment. In D136554#3986779 , @cor3ntin wrote: > In D136554#3986713 , @aeubanks > wrote: > >> yes, it was chrome >> I went ahead and tried the latest patch, it successfully compiles the file >>

[PATCH] D139759: [analyzer] Fix assertion in getAPSIntType

vabridgers marked an inline comment as done. vabridgers added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueFactory.h:157-158 + Loc::isLocType(T)); return APSIntType(Ctx.getIntWidth(T), !T->isSi

[PATCH] D139786: [clang-format] AllowShortRequiresExpressionOnASingleLine and AllowShortCompoundRequirementOnASingleLine

Backl1ght created this revision. Backl1ght added a reviewer: OwenCax. Backl1ght added a project: clang-format. Herald added a project: All. Backl1ght requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. clang-format did not take requires into co

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

UnionType added inline comments. Comment at: clang/test/Interpreter/execute-stmts.cpp:34 + +for (; i > 4; --i) printf("i = %d\n", i); +// CHECK-NEXT: i = 5 It seems that top-level statements wrapped in braces cannot be handled, maybe I made a mistake. ``` for (;

[PATCH] D139759: [analyzer] Fix assertion in getAPSIntType

steakhal added a comment. I think we could settle on something like this: APSIntType getAPSIntType(QualType T) const { +if (T->isFixedPointType()) + return APSIntType(Ctx.getIntWidth(T), T->isUnsignedFixedPointType()); + // For the purposes of the analysis and constrain

[PATCH] D139745: [Clang]Use poison instead of undef where its used as placeholder[NFC]

ManuelJBrito updated this revision to Diff 481908. ManuelJBrito retitled this revision from "Use poison instead of undef where its used as placeholder[NFC]" to "[Clang]Use poison instead of undef where its used as placeholder[NFC]". ManuelJBrito added a comment. Splitting the diff Repository:

[PATCH] D139745: [Clang]Use poison instead of undef where its used as placeholder[NFC]

nlopes accepted this revision. nlopes added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139745/new/ https://reviews.llvm.org/D139745 ___

[clang] 2482dbf - [Clang] Use poison instead of undef where its used as placeholder [NFC]

Author: Manuel Brito Date: 2022-12-11T16:18:06Z New Revision: 2482dbff461e981203f9c691b24d6017de46a441 URL: https://github.com/llvm/llvm-project/commit/2482dbff461e981203f9c691b24d6017de46a441 DIFF: https://github.com/llvm/llvm-project/commit/2482dbff461e981203f9c691b24d6017de46a441.diff LOG:

[PATCH] D139745: [Clang]Use poison instead of undef where its used as placeholder[NFC]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2482dbff461e: [Clang] Use poison instead of undef where its used as placeholder [NFC] (authored by ManuelJBrito, committed by nlopes). Repository:

[PATCH] D139774: [libclang] Add API to set temporary directory location

vedgy updated this revision to Diff 481913. vedgy edited the summary of this revision. vedgy added a comment. Extract identical code from the two Path.inc files into Path.cpp One of the Path.inc files is #include-d into this Path.cpp file and nowhere else. Repository: rG LLVM Github Monorepo

[PATCH] D139786: [clang-format] AllowShortRequiresExpressionOnASingleLine and AllowShortCompoundRequirementOnASingleLine

rymiel added a comment. Please re-upload with full context. See https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface Comment at: clang/lib/Format/Format.cpp:811 Style.AllowShortEnumsOnASingleLine); +IO.mapOptional("AllowShort

[PATCH] D139786: [clang-format] AllowShortRequiresExpressionOnASingleLine and AllowShortCompoundRequirementOnASingleLine

Backl1ght updated this revision to Diff 481918. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139786/new/ https://reviews.llvm.org/D139786 Files: clang/include/clang/Format/Format.h clang/lib/Format/Format.cpp clang/lib/Format/UnwrappedLineFormatter.cpp clang/lib/Format/Unwrapped

[PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

Mordante marked an inline comment as done. Mordante added a comment. Thanks for all reviews! In D137724#3974764 , @thieta wrote: > I think this is ready to land @Mordante or is there anything else missing? No but I've been quite busy. I needed some time

[PATCH] D137724: [CMake] Warn when the version is older than 3.20.0.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Mordante marked an inline comment as done. Closed by commit rGd40dc417389e: [CMake] Warn when the version is older than 3.20.0. (authored by Mordante). Changed prior t

[PATCH] D139759: [analyzer] Fix assertion in getAPSIntType

vabridgers updated this revision to Diff 481940. vabridgers added a comment. correct handling of sign type per @steakhal comments. Thank you, sir :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139759/new/ https://reviews.llvm.org/D139759 Files:

[PATCH] D139759: [analyzer] Fix assertion in getAPSIntType

vabridgers marked an inline comment as done. vabridgers added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Core/PathSensitive/BasicValueFactory.h:157-158 + Loc::isLocType(T)); return APSIntType(Ctx.getIntWidth(T), !T->isSi

[PATCH] D136554: Implement CWG2631

aeubanks added a comment. no, I got $ ninja -C out/MyClang/ content_unittests ld.lld: error: undefined symbol: mojo::Receiver>::Receiver(content::mojom::TestInterfaceForDefer*) >>> referenced by mojo_binder_policy_applier_unittest.cc:90 (../../content/browser/mojo_binder_policy_applier_un

[PATCH] D137343: [clang] add -Wvla-stack-allocation

uecker added a comment. I would still suggest to change the behavior of -Wvla to warn only about VLAs which are allocated on the stack as the most useful warning. Portability warnings should be turned on for -Wc++-compat. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D139786: [clang-format] AllowShortRequiresExpressionOnASingleLine and AllowShortCompoundRequirementOnASingleLine

HazardyKnusperkeks added a comment. I don't know if adding two options at once (and I think you want to add a third), splitting that up might be a better idea. Anyway you need to tun `clang/docs/tools/dump_format_style.py` and add an entry in the changelog. Comment at: clang

[PATCH] D139759: [analyzer] Fix assertion in getAPSIntType

steakhal added a comment. Really good progress. Nicestuff. I really appreciate the unittest. However Ive got some minor comments there :D Comment at: clang/test/Analysis/fixed-point.c:9 + +enum en_t { en_0 = 1 }; + I would suggest 'Kind' or something similar. S

[PATCH] D139798: [clang-repl] Support compound statement as a top-level statement.

v.g.vassilev created this revision. v.g.vassilev added reviewers: aaron.ballman, rsmith. Herald added a project: All. v.g.vassilev requested review of this revision. This patch teaches our incremental compilation infrastructure to push and pop a fake function scope making the Parser happy when pa

[PATCH] D127284: [clang-repl] Support statements on global scope in incremental mode.

v.g.vassilev marked an inline comment as done. v.g.vassilev added inline comments. Comment at: clang/test/Interpreter/execute-stmts.cpp:34 + +for (; i > 4; --i) printf("i = %d\n", i); +// CHECK-NEXT: i = 5 UnionType wrote: > It seems that top-level statements wra

[PATCH] D139759: [analyzer] Fix assertion in getAPSIntType

vabridgers updated this revision to Diff 481951. vabridgers marked 7 inline comments as done. vabridgers added a comment. clean up pass per comments from @steakhal Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139759/new/ https://reviews.llvm.org/D

[PATCH] D139759: [analyzer] Fix assertion in getAPSIntType

vabridgers added a comment. I think that addresses the last comments. Thanks again :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139759/new/ https://reviews.llvm.org/D139759 ___ cfe-commits mailing li

[PATCH] D139759: [analyzer] Fix assertion in getAPSIntType

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. The fix feels suboptimal in readability but let it be whatever. Functionally feels good. Tests are there and gets the job done. I wont object. Comment at: clang/include

[PATCH] D139801: [clang-format] Adds 'friend' to QualifierOrder.

red1bluelost created this revision. red1bluelost added a reviewer: MyDeveloperDay. Herald added a project: All. red1bluelost requested review of this revision. Herald added a project: clang. For cases of defining friend functions, qualifier ordering can allow multiple positions for the 'friend' to

[PATCH] D139586: [Clang][C++23] Lifetime extension in range-based for loops

royjacobson added a comment. Thanks for picking this up! :) The (non-wording) paper makes a pretty convincing case to just apply this retroactively to any C++11 code (https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2022/p2644r1.pdf). I think we should apply this retroactively, maybe add a

[clang] 8d43423 - [openmp] Fix a doc comment issue found by -Wdocumentation

Author: Dmitri Gribenko Date: 2022-12-11T23:58:28+01:00 New Revision: 8d434235569fe4472c5de43d5f97e3a0bd1f URL: https://github.com/llvm/llvm-project/commit/8d434235569fe4472c5de43d5f97e3a0bd1f DIFF: https://github.com/llvm/llvm-project/commit/8d434235569fe4472c5de43d5f97e3a0bd1f.dif

[PATCH] D137722: [clang][analyzer] No new nodes when bug is detected in StdLibraryFunctionsChecker.

Szelethus added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:953 if (FailureSt && !SuccessSt) { - if (ExplodedNode *N = C.generateErrorNode(NewState)) + if (ExplodedNode *N = C.generateErrorNode(NewState, NewNode))

[PATCH] D135247: [clang][analyzer] Add stream functions to StdLibraryFunctionsChecker.

Szelethus added a comment. The patch looks OK now, I'll get to inspecting the others. In D135247#3977403 , @balazske wrote: > The "strange" test failures that showed up earlier were probably caused by a > bug that is fixed in the D137722

[PATCH] D139485: [LLVM] Remove redundant .c_str() and .get() calls where they are not needed.

gAlfonso-bit updated this revision to Diff 481954. Herald added subscribers: cfe-commits, arichardson, emaste. Herald added a project: clang-tools-extra. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139485/new/ https://reviews.llvm.org/D139485 Files: clang-tools-extra/modularize/Modul

[clang] 4d1c5b9 - [openmp] Fix a doc comment issue found by -Wdocumentation

Author: Dmitri Gribenko Date: 2022-12-12T00:14:01+01:00 New Revision: 4d1c5b946ad7f10d398b43e7f20a528407fb79b9 URL: https://github.com/llvm/llvm-project/commit/4d1c5b946ad7f10d398b43e7f20a528407fb79b9 DIFF: https://github.com/llvm/llvm-project/commit/4d1c5b946ad7f10d398b43e7f20a528407fb79b9.dif

[PATCH] D139759: [analyzer] Fix assertion in getAPSIntType

This revision was automatically updated to reflect the committed changes. Closed by commit rG443b46e6d313: [analyzer] Fix assertion in getAPSIntType (authored by einvbri ). Changed prior to commit: https://reviews.llvm.org/D139759?vs=481951&id=481955#toc Reposito

[clang] 443b46e - [analyzer] Fix assertion in getAPSIntType

Author: einvbri Date: 2022-12-11T17:56:51-06:00 New Revision: 443b46e6d3139c1306caddd06efa674dcea9f38f URL: https://github.com/llvm/llvm-project/commit/443b46e6d3139c1306caddd06efa674dcea9f38f DIFF: https://github.com/llvm/llvm-project/commit/443b46e6d3139c1306caddd06efa674dcea9f38f.diff LOG:

[PATCH] D139287: [WIP][OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 updated this revision to Diff 481960. tianshilei1992 added a comment. rebase and fix opt error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139287/new/ https://reviews.llvm.org/D139287 Files: openmp/libomptarget/plugins-nextgen/C

[PATCH] D136554: Implement CWG2631

cor3ntin added a comment. In D136554#3987122 , @aeubanks wrote: > no, I got > > $ ninja -C out/MyClang/ content_unittests > ld.lld: error: undefined symbol: > mojo::Receiver mojo::RawPtrImplRefTraits>::Receiver(content::mojom::TestInterfaceForDefer*)

[PATCH] D139387: [NFC][Clang] Add missing test cases for segment load

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4ca9c6a84f91: [NFC][Clang] Add missing test cases for segment load (authored by khchen, committed by 4vtomat). Repository: rG LLVM Github Monorepo

[clang] 4ca9c6a - [NFC][Clang] Add missing test cases for segment load

Author: Zakk Chen Date: 2022-12-11T19:02:47-08:00 New Revision: 4ca9c6a84f918be4314fc7066eb899f4e86f07f3 URL: https://github.com/llvm/llvm-project/commit/4ca9c6a84f918be4314fc7066eb899f4e86f07f3 DIFF: https://github.com/llvm/llvm-project/commit/4ca9c6a84f918be4314fc7066eb899f4e86f07f3.diff LOG

[PATCH] D139148: Fix nullptr dereference found by Coverity static analysis tool

schittir updated this revision to Diff 481974. schittir marked an inline comment as done. schittir added a comment. Fixed typo. Sorry! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139148/new/ https://reviews.llvm.org/D139148 Files: clang/lib/Sema/SemaInit.cpp Index: clang/lib/Sema

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

ChuanqiXu updated this revision to Diff 481975. ChuanqiXu marked 3 inline comments as done. ChuanqiXu edited the summary of this revision. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137058/new/ https://reviews.llvm.org/D137058 Files: cl

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

ChuanqiXu marked an inline comment as done. ChuanqiXu added inline comments. Comment at: clang/test/Driver/save-std-c++-module-file.cpp:8-9 +// +// RUN: %clang -std=c++20 %t/Hello.cppm -fmodule-output -o %t/output/Hello.o \ +// RUN: -### 2>&1 | FileCheck %t/Hello.cppm -DPREFIX=

[PATCH] D137059: [Driver] [C++20] [Modules] Support -fmodule-output= (2/2)

ChuanqiXu updated this revision to Diff 481978. ChuanqiXu added a comment. Update after D137058 updated. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137059/new/ https://reviews.llvm.org/D137059 Files: clang/include/clang/Driver/Options.td clang/

[PATCH] D139287: [WIP][OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 updated this revision to Diff 481980. tianshilei1992 added a comment. rebase and fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139287/new/ https://reviews.llvm.org/D139287 Files: openmp/libomptarget/plugins-nextgen/CM

[PATCH] D139148: Fix nullptr dereference found by Coverity static analysis tool

schittir updated this revision to Diff 481989. schittir added a comment. Fix typos CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139148/new/ https://reviews.llvm.org/D139148 Files: clang/lib/Sema/SemaInit.cpp Index: clang/lib/Sema/SemaInit.cpp ==