[PATCH] D139686: [lsan] Add lsan support for loongarch64

tangyouling updated this revision to Diff 481533. tangyouling added a comment. - Separate leak_check_segv.cpp modification. - Add some comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139686/new/ https://reviews.llvm.org/D139686 Files: cl

[PATCH] D139686: [lsan] Add lsan support for loongarch64

SixWeining added inline comments. Comment at: compiler-rt/test/lsan/TestCases/swapcontext.cpp:8 // Missing 'getcontext' and 'makecontext' on Android. -// UNSUPPORTED: arm,aarch64,powerpc64,android +// UNSUPPORTED: arm,aarch64,loongarch64,powerpc64,android Why

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

uweigand added a comment. In D139444#3982205 , @probinson wrote: > If you can tell me the `platform.system()` value to look for to detect z/OS, > I can do that. I don't know - this value is defined by the Python implementation on z/OS. On most platfor

[PATCH] D138807: [RISCV] Support vector crypto extension ISA string and assembly

4vtomat updated this revision to Diff 481540. 4vtomat added a comment. Address Eric Gouriou's comments, thanks for reviewing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138807/new/ https://reviews.llvm.org/D138807 Files: clang/test/Preprocess

[PATCH] D134410: [clang][CodeGen] Add noundef metadata to load instructions (preliminary 1 or 5)

nikic added a comment. In D134410#3898615 , @nlopes wrote: > In D134410#3898563 , @nikic wrote: > >> FWIW, I don't agree with this. It's fine to change load semantics, as long >> as bitcode autoupgrade is handled

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

iains added a comment. thanks all for the patience on this one - and for the collaborative discussion - I do think the outcome is going to be an easier to remember option name ;) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137058/new/ https://reviews.llvm.org/D137058 ___

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

cor3ntin added a comment. Thanks Tom, I replied to your comments Comment at: clang/lib/Lex/Lexer.cpp:3378-3379 - if (LooseMatch) + // If no diagnostic has been emitted yet we do not want to recover here + // to make sure this function will be called again and a diagnostic

[PATCH] D137051: [Clang] Allow additional mathematical symbols in identifiers.

cor3ntin added a comment. In D137051#3982833 , @tahonermann wrote: > Oh, also, the review summary mentions "UAX32" (twice); those should be > "UAX31". Just please make sure the commit message is correct. > > Also, I'm terribly sorry for being so slow to

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

ChuanqiXu added a comment. In D137058#3983687 , @iains wrote: > thanks all for the patience on this one - and for the collaborative > discussion - I do think the outcome is going to be an easier to remember > option name ;) Yeah. Thanks for your sugges

[PATCH] D139627: clang/X86: Don't emit "min-legal-vector-width"="0"

pengfei added a comment. In D139627#3982387 , @arsenm wrote: > In D139627#3982385 , @arsenm wrote: > >>> [1] `"min-legal-vector-width" = "0"` was clear to indicate there are only >>> scalar operations. >> >> It's

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

manas marked 13 inline comments as done. manas added a comment. In D112621#3978285 , @steakhal wrote: > For the test cases where we should be able to prove the case but return > `Unknown` instead, should be marked by a FIXME stating the expected value. >

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

manas updated this revision to Diff 481545. manas added a comment. Assert over non-empty ranges and add fixme for not handled cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112621/new/ https://reviews.llvm.org/D112621 Files: clang/lib/Stati

[PATCH] D139696: [include-cleaner] Add a unique_ptr-style member expr test in WalkASTTest.

hokein created this revision. hokein added a reviewer: VitaNuo. Herald added a subscriber: kadircet. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang-tools-extra. This is a test I missed to mention in https://reviews.llvm.org/D139087. Repositor

[PATCH] D139627: clang/X86: Don't emit "min-legal-vector-width"="0"

pengfei added a comment. In D139627#3982381 , @craig.topper wrote: > In D139627#3982349 , @jdoerfert > wrote: > >> Isn't this (inherently) X86 specific? > > Yes it is. We could qualify the attribute emission wit

[clang] 4faf000 - Recommit of 8ae18303f97d5dcfaecc90b4d87effb2011ed82e - part 2

Author: serge-sans-paille Date: 2022-12-09T10:07:02+01:00 New Revision: 4faf6cf989f3ae212912994022c0486a2dc4 URL: https://github.com/llvm/llvm-project/commit/4faf6cf989f3ae212912994022c0486a2dc4 DIFF: https://github.com/llvm/llvm-project/commit/4faf6cf989f3ae212912994022c0486a2dc4.d

[PATCH] D138571: Update ninja and cmake installation commands on LibASTMatchersTutorial

ismaelJimenez added a comment. Dear reviewers, I do not have commit access. Could you please commit this change in my behalf? Thank you very much for your support! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138571/new/ https://reviews.llvm.org/

[clang] d881fdf - Revert "Recommit of 8ae18303f97d5dcfaecc90b4d87effb2011ed82e - part 2"

Author: serge-sans-paille Date: 2022-12-09T10:15:41+01:00 New Revision: d881fdf72047fd18b88c6a65d0966cad542c95cd URL: https://github.com/llvm/llvm-project/commit/d881fdf72047fd18b88c6a65d0966cad542c95cd DIFF: https://github.com/llvm/llvm-project/commit/d881fdf72047fd18b88c6a65d0966cad542c95cd.d

[PATCH] D139544: [clang][dataflow] Add support for structured bindings of tuple-like types.

isuckatcs added a comment. Those `BindingDecl`s never appear in the CFG unless one of the is used. Take a look at the other cases. 1.) Arrays void foo() { int arr[2]; auto [i0, i1] = arr; } [B1] 1: int arr[2]; 2: arr 3: [B1.2] (ImplicitCastExpr, ArrayToPoint

[clang] c9a6713 - Implement CWG2631

Author: Corentin Jabot Date: 2022-12-09T10:25:44+01:00 New Revision: c9a6713b4788f10b81202b70993068e475b392f7 URL: https://github.com/llvm/llvm-project/commit/c9a6713b4788f10b81202b70993068e475b392f7 DIFF: https://github.com/llvm/llvm-project/commit/c9a6713b4788f10b81202b70993068e475b392f7.diff

[PATCH] D136554: Implement CWG2631

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc9a6713b4788: Implement CWG2631 (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D137051: [Clang] Allow additional mathematical symbols in identifiers.

cor3ntin updated this revision to Diff 481556. cor3ntin added a comment. Fix grammar in diagnostic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137051/new/ https://reviews.llvm.org/D137051 Files: clang/docs/ReleaseNotes.rst clang/include/cla

[PATCH] D137051: [Clang] Allow additional mathematical symbols in identifiers.

cor3ntin added a comment. Thanks Tom. I'm adding more reviewers in case someone else wants to look at it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137051/new/ https://reviews.llvm.org/D137051 ___ cfe

[PATCH] D139398: [AMDGPU] Add bf16 storage support

Pierre-vh added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:913 + else +RegisterVT = (ScalarVT == MVT::bf16 ? MVT::v2bf16 : MVT::v2f16); IntermediateVT = RegisterVT; arsenm wrote: > If you wanted the promote to i32,

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

manas updated this revision to Diff 481560. manas added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112621/new/ https://reviews.llvm.org/D112621 Files: clang/lib/StaticAnalyzer/Core/RangeConstraintManager.cpp clang/test/Ana

[clang] 138942c - Recommit of 8ae18303f97d5dcfaecc90b4d87effb2011ed82e - part 2

Author: serge-sans-paille Date: 2022-12-09T10:41:34+01:00 New Revision: 138942c833b3baa12d19216797efca6d4dd010d2 URL: https://github.com/llvm/llvm-project/commit/138942c833b3baa12d19216797efca6d4dd010d2 DIFF: https://github.com/llvm/llvm-project/commit/138942c833b3baa12d19216797efca6d4dd010d2.d

[PATCH] D139444: [ZOS] Convert tests to check 'target={{.*}}-zos'

uweigand added a comment. In D139444#3983679 , @uweigand wrote: > In D139444#3982205 , @probinson > wrote: > >> If you can tell me the `platform.system()` value to look for to detect z/OS, >> I can do that. > >

[clang] 9e2dc98 - [Clang] improve grammar in warn_utf8_symbol_homoglyph diagnostic

Author: Corentin Jabot Date: 2022-12-09T10:52:13+01:00 New Revision: 9e2dc984ba1b25625e6ddc38ba681b194172379a URL: https://github.com/llvm/llvm-project/commit/9e2dc984ba1b25625e6ddc38ba681b194172379a DIFF: https://github.com/llvm/llvm-project/commit/9e2dc984ba1b25625e6ddc38ba681b194172379a.diff

[PATCH] D137051: [Clang] Allow additional mathematical symbols in identifiers.

cor3ntin added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:129-130 InGroup>; def warn_utf8_symbol_homoglyph : Warning< "treating Unicode character as identifier character rather than " "as '%1' symbol">, InGroup>; tahon

[PATCH] D139686: [lsan] Add lsan support for loongarch64

tangyouling added inline comments. Comment at: compiler-rt/test/lsan/TestCases/swapcontext.cpp:8 // Missing 'getcontext' and 'makecontext' on Android. -// UNSUPPORTED: arm,aarch64,powerpc64,android +// UNSUPPORTED: arm,aarch64,loongarch64,powerpc64,android Six

[PATCH] D137059: [Driver] [C++20] [Modules] Support -fmodule-output= (2/2)

iains accepted this revision. iains added a comment. This revision is now accepted and ready to land. this LGTM ( but please wait for an ack from @dblaikie ) and again thanks for patience in seeing this through. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137059/new/ https://reviews.

[PATCH] D139409: [include-cleaner] Handle dependent type members in AST

hokein added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:67 + bool VisitCXXDependentScopeMemberExpr(CXXDependentScopeMemberExpr *E) { +QualType QT = E->getBaseType().getCanonicalType(); Rebase the current patch. Move the

[PATCH] D139700: [clang][Inter] Implement __builtin_expect

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, tahonermann, shafik, erichkeane. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This adds a `InterpStack::discard()` version that t

[PATCH] D138807: [RISCV] Support vector crypto extension ISA string and assembly

asb added a comment. I just wanted to document the discussion we had in the RISC-V sync call yesterday. There were no objections to treating the vector crypto work like any other experimental extension, per our current policy (I think the main reason people might object is if substantial churn

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

cor3ntin added a comment. Thanks Tom, I replied to your comments Comment at: clang/lib/Lex/Lexer.cpp:3386 + + if (!Result || CurPtr - StartPtr == (ptrdiff_t)(Buffer.size() + 4)) StartPtr = CurPtr; cor3ntin wrote: > tahonermann wrote: > > This is a bit of

[PATCH] D139701: [Clang] Don't emit "min-legal-vector-width"="0" for AMDGPU

pengfei created this revision. pengfei added reviewers: craig.topper, arsenm, RKSimon. Herald added subscribers: kosarev, StephenFan, jdoerfert, kerbowa, tpr, dstuttard, yaxunl, jvesely, kzhuravl. Herald added a project: All. pengfei requested review of this revision. Herald added subscribers: cfe

[clang-tools-extra] 526fb5f - [include-cleaner] Fix walkUsed only report a single macro ref.

Author: Haojian Wu Date: 2022-12-09T12:12:16+01:00 New Revision: 526fb5fae79f1b037eb084783d5eb082258ede9b URL: https://github.com/llvm/llvm-project/commit/526fb5fae79f1b037eb084783d5eb082258ede9b DIFF: https://github.com/llvm/llvm-project/commit/526fb5fae79f1b037eb084783d5eb082258ede9b.diff LO

[PATCH] D138779: [include-cleaner] Filter out references that not spelled in the main file.

hokein updated this revision to Diff 481591. hokein marked 4 inline comments as done. hokein added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138779/new/ https://reviews.llvm.org/D138779 Files: clang-tools-e

[PATCH] D138779: [include-cleaner] Filter out references that not spelled in the main file.

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang-tools-extra/include-cleaner/unittests/AnalysisTest.cpp:292 + R"cpp( +#define PLUS_ONE(X) X() + 1 +int a = $expa

[clang-tools-extra] edd5d77 - [clangd] NFC. Add a newline at the end of the file

Author: Ilya Biryukov Date: 2022-12-09T12:31:50+01:00 New Revision: edd5d777e981ab6a4952c14c35f3ead330c4a761 URL: https://github.com/llvm/llvm-project/commit/edd5d777e981ab6a4952c14c35f3ead330c4a761 DIFF: https://github.com/llvm/llvm-project/commit/edd5d777e981ab6a4952c14c35f3ead330c4a761.diff

[PATCH] D139586: [Clang][C++23] Lifetime extension in range-based for loops

cor3ntin added a comment. Thanks a lot for working on this. I will try to do a more detailed review later, but at least I think we might want more tests. Maybe codegen tests that do not rely on [[clang::lifetimebound]], and tests with more chaining (`a().b().c()`) . Repository: rG LLVM Gith

[PATCH] D139704: [clang][RISCV] Added target attributes to runtime functions

eklepilkina created this revision. Herald added subscribers: sunshaoce, VincentWu, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosH

[clang-tools-extra] bf6e655 - [include-cleaner] Filter out references that not spelled in the main file.

Author: Haojian Wu Date: 2022-12-09T12:59:34+01:00 New Revision: bf6e65516223586180d4082735b706bd4602ba11 URL: https://github.com/llvm/llvm-project/commit/bf6e65516223586180d4082735b706bd4602ba11 DIFF: https://github.com/llvm/llvm-project/commit/bf6e65516223586180d4082735b706bd4602ba11.diff LO

[PATCH] D138779: [include-cleaner] Filter out references that not spelled in the main file.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rGbf6e65516223: [include-cleaner] Filter out references that not spelled in the main file. (authored by hokein

[PATCH] D139705: [clang] fix zero-initialization fix-it for variable template

v1nh1shungry created this revision. v1nh1shungry added reviewers: aaron.ballman, erichkeane. Herald added a project: All. v1nh1shungry requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Current version there is a fix-it for cpp template

Re: [clang] d881fdf - Revert "Recommit of 8ae18303f97d5dcfaecc90b4d87effb2011ed82e - part 2"

Reminder to please always mention the reason for the revert in the commit message. On Fri, Dec 9, 2022 at 12:15 PM via cfe-commits wrote: > > > Author: serge-sans-paille > Date: 2022-12-09T10:15:41+01:00 > New Revision: d881fdf72047fd18b88c6a65d0966cad542c95cd > > URL: > https://github.com/llvm/

[clang] 77ab728 - [analyzer][solver] Introduce reasoning for not equal to operator

Author: Manas Date: 2022-12-09T13:30:57+01:00 New Revision: 77ab7281aa36800dc77dab07bd40e6e0fd9f0b78 URL: https://github.com/llvm/llvm-project/commit/77ab7281aa36800dc77dab07bd40e6e0fd9f0b78 DIFF: https://github.com/llvm/llvm-project/commit/77ab7281aa36800dc77dab07bd40e6e0fd9f0b78.diff LOG: [a

Re: [clang] d881fdf - Revert "Recommit of 8ae18303f97d5dcfaecc90b4d87effb2011ed82e - part 2"

Also, when recommiting these patches, please fix the commit message, the current one is very non-descriptive. On Fri, Dec 9, 2022 at 12:15 PM via cfe-commits wrote: > > > Author: serge-sans-paille > Date: 2022-12-09T10:15:41+01:00 > New Revision: d881fdf72047fd18b88c6a65d0966cad542c95cd > > URL:

[PATCH] D112621: [analyzer][solver] Introduce reasoning for not equal to operator

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG77ab7281aa36: [analyzer][solver] Introduce reasoning for not equal to operator (authored by manas, committed by steakhal). Changed prior to commit:

[PATCH] D139544: [clang][dataflow] Add support for structured bindings of tuple-like types.

ymandel added a comment. > Those BindingDecls never appear in the CFG unless one of the is used. Indeed. That''s the issue (which this discussion has helped clarify) -- the binding decls are not in the CFG and I was expecting them to be. > By the time you see this node, the variable has already

[clang] 3fffe68 - [Serialization] Add -ftime-trace block for reading loaded modules.

Author: Sam McCall Date: 2022-12-09T14:36:57+01:00 New Revision: 3fffe6826448ac2daf9c4feb8e48ae8d601aca06 URL: https://github.com/llvm/llvm-project/commit/3fffe6826448ac2daf9c4feb8e48ae8d601aca06 DIFF: https://github.com/llvm/llvm-project/commit/3fffe6826448ac2daf9c4feb8e48ae8d601aca06.diff LO

[clang] 1481fcf - [clang] Try to unbreak test/C/drs/dr324.c on Windows

Author: Nico Weber Date: 2022-12-09T08:57:28-05:00 New Revision: 1481fcf780bde7b115aa395064d71749b1a40889 URL: https://github.com/llvm/llvm-project/commit/1481fcf780bde7b115aa395064d71749b1a40889 DIFF: https://github.com/llvm/llvm-project/commit/1481fcf780bde7b115aa395064d71749b1a40889.diff LO

[PATCH] D139167: [clang][Windows]Ignore Options '/d1nodatetime' and '/d1import_no_registry'

hans added a comment. I see this landed in https://github.com/llvm/llvm-project/commit/4178671b2ed3d Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139167/new/ https://reviews.llvm.org/D139167 __

[PATCH] D139713: [Sema] Fix crash when evaluating nested call with value-dependent arg

Pierre-vh created this revision. Pierre-vh added reviewers: ahatanak, rsmith. Herald added a project: All. Pierre-vh requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fix an edge case `ExprConstant.cpp`'s `EvaluateWithSubstitution` when calle

[PATCH] D139713: [Sema] Fix crash when evaluating nested call with value-dependent arg

Pierre-vh updated this revision to Diff 481626. Pierre-vh added a comment. Missing newline at EOF Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139713/new/ https://reviews.llvm.org/D139713 Files: clang/lib/AST/ExprConstant.cpp clang/test/SemaC

[PATCH] D139713: [Sema] Fix crash when evaluating nested call with value-dependent arg

Pierre-vh added a comment. I think the right choice is to remove the assert as it's an invariant that can be broken in some cases, so I don't feel like the assert is worth it anymore. Alternatively I could add something to bypass the assert in that specific call to getParamSlot for Value-Depende

[PATCH] D139715: [include-cleaner] Print the line number of removal #includes.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang-tools-extra. I found that this information is helpful when using this tool. Repository: rG LLVM Github Monorepo https://reviews

[PATCH] D139716: [include-cleaner] Use expansion locations for macros.

VitaNuo created this revision. Herald added a subscriber: kadircet. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Use expansion locations for target symbol decls when finding headers for ma

[PATCH] D139716: [include-cleaner] Use expansion locations for macros.

VitaNuo updated this revision to Diff 481635. VitaNuo added a comment. Remove FIXME. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139716/new/ https://reviews.llvm.org/D139716 Files: clang-tools-extra/include-cleaner/lib/FindHeaders.cpp clang-

[PATCH] D139544: [clang][dataflow] Add support for structured bindings of tuple-like types.

ymandel added a comment. > Those BindingDecls never appear in the CFG unless one of the is used. Sorry, I should fix my response above: I *never* see the `BindingDecl`s in the CFG, whether or not they are used. Can you send me an example CFG that contains the BindingDecls? Repository: rG L

[PATCH] D137875: clang/AMDGPU: Drop volatile from builtin_atomic* pointers

arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137875/new/ https://reviews.llvm.org/D137875 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D139717: Revert "[Driver] Remove Joined -X"

rsundahl created this revision. Herald added a project: All. rsundahl requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change is breaking internal builds. We use the -Xfoo pattern but can now no longer manage whether we allow an unused

[PATCH] D139696: [include-cleaner] Add a unique_ptr-style member expr test in WalkASTTest.

VitaNuo accepted this revision. VitaNuo added a comment. This revision is now accepted and ready to land. Thank you! Comment at: clang-tools-extra/include-cleaner/unittests/WalkASTTest.cpp:200 + testWalk(R"cpp( + template struct unique_ptr { +T *operator->(); ---

[clang] 218b77c - [AArch64][NFC] Move hasFeature fields initiations to the declaration

Author: Daniel Kiss Date: 2022-12-09T16:23:26+01:00 New Revision: 218b77c85057e8aae153edcedfe365061270e70c URL: https://github.com/llvm/llvm-project/commit/218b77c85057e8aae153edcedfe365061270e70c DIFF: https://github.com/llvm/llvm-project/commit/218b77c85057e8aae153edcedfe365061270e70c.diff L

[PATCH] D139622: [AArch64][NFC] Move hasFeature fields initiations to the declaration

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG218b77c85057: [AArch64][NFC] Move hasFeature fields initiations to the declaration (authored by danielkiss). Herald added a project: clang. Herald ad

[PATCH] D139544: [clang][dataflow] Add support for structured bindings of tuple-like types.

isuckatcs added a comment. > Sorry, I should fix my response above: I *never* see the BindingDecls in the > CFG, whether or not they are used. It was my fault, I was wrong with the wording. I meant the `DeclRefExpr`s that refer to the `BindingDecl`s. You can access the `BindingDecl`s through t

[PATCH] D139652: Add the thread sanitizer support for X86_64 WatchOS simulators

rsundahl added a comment. In D139652#3983079 , @yln wrote: > @rsundahl: can you keep an eye on this and resolve any potential > Apple-internal conflicts? Thanks! Will do @yln. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D139544: [clang][dataflow] Add support for structured bindings of tuple-like types.

ymandel updated this revision to Diff 481651. ymandel added a comment. Simplifies the implementation and removes mention of any potential CFG problem. This new version does the work eagerly by forcing a location for the synthesized variable. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D139544: [clang][dataflow] Add support for structured bindings of tuple-like types.

ymandel added a comment. In D139544#3984532 , @isuckatcs wrote: >> Sorry, I should fix my response above: I *never* see the BindingDecls in the >> CFG, whether or not they are used. > > It was my fault, I was wrong with the wording. I meant the `DeclRefE

[PATCH] D139409: [include-cleaner] Handle dependent type members in AST

VitaNuo updated this revision to Diff 481659. VitaNuo marked 3 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139409/new/ https://reviews.llvm.org/D139409 Files: clang-too

[PATCH] D139409: [include-cleaner] Handle dependent type members in AST

VitaNuo marked an inline comment as done. VitaNuo added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:79 + +if (isa(UnqualifiedType)) { + const TemplateSpecializationType *TST = hokein wrote: > if we just aim to support t

[PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

Ericson2314 added inline comments. Comment at: bolt/lib/RuntimeLibs/RuntimeLibrary.cpp:32 SmallString<128> LibPath = llvm::sys::path::parent_path(Dir); - llvm::sys::path::append(LibPath, "lib" LLVM_LIBDIR_SUFFIX); + llvm::sys::path::append(LibPath, CMAKE_INSTALL_LIBDIR);

[PATCH] D129531: [clang][C++20] P0960R3 and P1975R0: Allow initializing aggregates from a parenthesized list of values

ilya-biryukov added inline comments. Comment at: clang/include/clang/AST/ExprCXX.h:4824 + const Expr *getArrayFiller() const { +return const_cast(this)->getArrayFiller(); + } NIT: maybe just use `return ArrayFiller`? The code is much simpler and since func

[PATCH] D131830: [OpenMP] Clang Support for taskwait nowait clause

mstorsjo added inline comments. Comment at: openmp/runtime/src/dllexports:348 __kmpc_omp_wait_deps243 +__kmpc_omp_taskwait_deps_51 292 __kmpc_cancel 244 This is missing a similar export of `_

[PATCH] D139717: Revert "[Driver] Remove Joined -X"

lebedev.ri added a comment. This is missing a test, like the original commit mentioned. Why can you not just use the the split variant, `-X clang ...`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139717/new/ https://reviews.llvm.org/D139717

[PATCH] D138316: [ASTContext] Avoid duplicating address space map. NFCI

arichardson updated this revision to Diff 481664. arichardson added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138316/new/ https://reviews.llvm.org/D138316 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST/ASTConte

[PATCH] D139720: [clang][PPC] Checking Unknown Values Passed to -mcpu

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: nemanjai, amyk. qiongsiwu1 added a project: clang. Herald added subscribers: shchenz, kbarton. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Currently `ppc::ge

[clang] e52b9bf - [STLExtras] Convert deref_or_none and zip_longest to std::optional

Author: Krzysztof Parzyszek Date: 2022-12-09T10:27:48-06:00 New Revision: e52b9bf64f0487f6ec5a6a7b24f95f31ab83fb8b URL: https://github.com/llvm/llvm-project/commit/e52b9bf64f0487f6ec5a6a7b24f95f31ab83fb8b DIFF: https://github.com/llvm/llvm-project/commit/e52b9bf64f0487f6ec5a6a7b24f95f31ab83fb8b

[clang] 707cc06 - Sema: diagnose PMFs passed through registers to inline assembly

Author: Saleem Abdulrasool Date: 2022-12-09T16:58:46Z New Revision: 707cc06e1570b5966efcd6a9124191c80fa7a754 URL: https://github.com/llvm/llvm-project/commit/707cc06e1570b5966efcd6a9124191c80fa7a754 DIFF: https://github.com/llvm/llvm-project/commit/707cc06e1570b5966efcd6a9124191c80fa7a754.diff

[PATCH] D138514: Sema: diagnose PMFs passed through registers to inline assembly

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. (Accepting Revision for Closing) I missed the trailing number of the differential revision, and it failed to tie it to this. The commit is at https://github.com/llvm/llvm-project/commit/

[PATCH] D139723: [OpenMP][AMDGPU] Enable use of abs labs and llabs function in C code

doru1004 created this revision. doru1004 added reviewers: jhuber6, arsenm, carlo.bertolli, gregrodgers, ronl. doru1004 added a project: OpenMP. Herald added subscribers: kosarev, guansong, tpr, dstuttard, yaxunl, jvesely, kzhuravl. Herald added a project: All. doru1004 requested review of this rev

[clang] e0fd86d - Revert "[OpenMP] Clang Support for taskwait nowait clause"

Author: Chi Chun Chen Date: 2022-12-09T11:06:45-06:00 New Revision: e0fd86db09a87f25df0eff6c1c755d86434dea0b URL: https://github.com/llvm/llvm-project/commit/e0fd86db09a87f25df0eff6c1c755d86434dea0b DIFF: https://github.com/llvm/llvm-project/commit/e0fd86db09a87f25df0eff6c1c755d86434dea0b.diff

Re: [clang] e0fd86d - Revert "[OpenMP] Clang Support for taskwait nowait clause"

Reminder to please always mention the reason for the revert in the commit message. On Fri, Dec 9, 2022 at 8:07 PM Chi Chun Chen via cfe-commits wrote: > > > Author: Chi Chun Chen > Date: 2022-12-09T11:06:45-06:00 > New Revision: e0fd86db09a87f25df0eff6c1c755d86434dea0b > > URL: > https://github.

[PATCH] D139717: Revert "[Driver] Remove Joined -X"

davide added a comment. In D139717#3984648 , @lebedev.ri wrote: > This is missing a test, like the original commit mentioned. > Why can you not just use the the split variant, `-X clang ...`? This breaks many projects internally. There's no real complex

[PATCH] D139398: [AMDGPU] Add bf16 storage support

arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:913 + else +RegisterVT = (ScalarVT == MVT::bf16 ? MVT::v2bf16 : MVT::v2f16); IntermediateVT = RegisterVT; Pierre-vh wrote: > arsenm wrote: > > If you wanted th

[PATCH] D139398: [AMDGPU] Add bf16 storage support

arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:5573-5576 + SDLoc SL(Op); + return DAG.getNode( + ISD::FP_EXTEND, SL, MVT::f32, + DAG.getNode(ISD::BITCAST, SL, MVT::f16, Op->getOperand(0))); arsenm wrote: > Pierre-v

[PATCH] D139544: [clang][dataflow] Add support for structured bindings of tuple-like types.

xazax.hun added a comment. This approach looks good to me. Some context: we kept the CFGs lightweight because it looks like we did not need to do any extensions for the Clang Static Analyzer. I'm glad the dataflow framework can also work with the current representation. On the other hand, I thi

[PATCH] D139723: [OpenMP][AMDGPU] Enable use of abs labs and llabs math functions in C code

jdoerfert added a comment. I'm not 100% sure if this was excluded on purpose or not. FWIW, in C, these functions are not defined in math.h (https://en.cppreference.com/w/c/numeric/math/abs), but in C++ they are (https://en.cppreference.com/w/cpp/numeric/math/abs). Once we enable libm_gpu it mi

[PATCH] D137058: [Driver] [Modules] Support -fmodule-output (1/2)

dblaikie requested changes to this revision. dblaikie added a comment. This revision now requires changes to proceed. Please update the patch description/commit message to reflect the new naming. Comment at: clang/test/Driver/save-std-c++-module-file.cpp:8-9 +// +// RUN: %clang

[PATCH] D131858: [clang] Track the templated entity in type substitution.

arphaman added a comment. Ping @mizvekov. Unfortunately I'm unable to revert this commit now so we won't be able to get the bot back to green until it's fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131858/new/ https://reviews.llvm.org/D13

[PATCH] D139544: [clang][dataflow] Add support for structured bindings of tuple-like types.

ymandel updated this revision to Diff 481677. ymandel added a comment. remove commented out code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139544/new/ https://reviews.llvm.org/D139544 Files: clang/lib/Analysis/FlowSensitive/Transfer.cpp cl

[PATCH] D139544: [clang][dataflow] Add support for structured bindings of tuple-like types.

ymandel marked an inline comment as done. ymandel added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139544/new/ https://reviews.llvm.org/D139544 ___ cfe-commits mailing list cfe-comm

[PATCH] D139544: [clang][dataflow] Add support for structured bindings of tuple-like types.

ymandel added a comment. In D139544#3984835 , @xazax.hun wrote: > This approach looks good to me. Some context: we kept the CFGs lightweight > because it looks like we did not need to do any extensions for the Clang > Static Analyzer. I'm glad the dataf

[PATCH] D139652: Add the thread sanitizer support for X86_64 WatchOS simulators

yfyang updated this revision to Diff 481679. yfyang added a comment. Addressing comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139652/new/ https://reviews.llvm.org/D139652 Files: clang/lib/Driver/ToolChains/Darwin.cpp clang/test/Drive

[PATCH] D139723: [OpenMP][AMDGPU] Enable use of abs labs and llabs math functions in C code

arsenm added a comment. In D139723#3984846 , @jdoerfert wrote: > I'm not 100% sure if this was excluded on purpose or not. FWIW, in C, these > functions are not defined in math.h > (https://en.cppreference.com/w/c/numeric/math/abs), but in C++ they are

[PATCH] D139652: Add the thread sanitizer support for X86_64 WatchOS simulators

yfyang updated this revision to Diff 481682. yfyang added a comment. Formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139652/new/ https://reviews.llvm.org/D139652 Files: clang/lib/Driver/ToolChains/Darwin.cpp Index: clang/lib/Driver/To

[PATCH] D139652: Add the thread sanitizer support for X86_64 WatchOS simulators

yfyang updated this revision to Diff 481684. yfyang added a comment. - Add TSAN support for Apple arm64 simulators - Formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139652/new/ https://reviews.llvm.org/D139652 Files: clang/lib/Driver/To

[PATCH] D139723: [OpenMP][AMDGPU] Enable use of abs labs and llabs math functions in C code

jdoerfert added a comment. In D139723#3984880 , @arsenm wrote: > In D139723#3984846 , @jdoerfert > wrote: > >> I'm not 100% sure if this was excluded on purpose or not. FWIW, in C, these >> functions are not def

[clang] 0073fd8 - Add the thread sanitizer support for X86_64 WatchOS simulators

Author: Yifan Yang Date: 2022-12-09T13:32:56-05:00 New Revision: 0073fd8d0dda533a5acb1c237a37ad270d24b711 URL: https://github.com/llvm/llvm-project/commit/0073fd8d0dda533a5acb1c237a37ad270d24b711 DIFF: https://github.com/llvm/llvm-project/commit/0073fd8d0dda533a5acb1c237a37ad270d24b711.diff LO

[PATCH] D139652: Add the thread sanitizer support for X86_64 WatchOS simulators

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0073fd8d0dda: Add the thread sanitizer support for X86_64 WatchOS simulators (authored by yfyang, committed by oontvoo). Repository: rG LLVM Githu

[PATCH] D139287: [WIP][OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 updated this revision to Diff 481686. tianshilei1992 added a comment. Herald added a subscriber: pcwang-thead. rebase and refine It currently crashes in `setupLLVMOptimizationRemarks` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139

  1   2   3   >