[PATCH] D139454: [CMake] Replace clang binary if using clang-bolt target

Amir created this revision. Amir added reviewers: bolt, phosek, MaskRay. Herald added subscribers: StephenFan, wenlei. Herald added a project: All. Amir requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Instead of creating a

[PATCH] D138402: [clang-format] Correctly count a tab's width in a comment

HazardyKnusperkeks updated this revision to Diff 480597. HazardyKnusperkeks marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138402/new/ https://reviews.llvm.org/D138402 Files: clang/lib/Format/BreakableToken.cpp clang/unittests/Format/FormatTestComment

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

HazardyKnusperkeks added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138263/new/ https://reviews.llvm.org/D138263 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D138373: [clang-format] Don't eat two semicolons after namespace

HazardyKnusperkeks added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138373/new/ https://reviews.llvm.org/D138373 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[PATCH] D139436: [C2x] Relaxing requirements for va_start

aaron.ballman updated this revision to Diff 480600. aaron.ballman added a comment. Adding some more test cases that demonstrate that you can still call these functions as you'd expect and that function pointer assignment works as expected. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D139458: [clangd] Full support for #import insertions

dgoldman created this revision. Herald added subscribers: kadircet, arphaman, javed.absar. Herald added a project: All. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. These are still disabled by

[clang] 5951b0b - Store OptTable::Info::Name as a StringRef

Author: serge-sans-paille Date: 2022-12-06T22:51:28+01:00 New Revision: 5951b0bb23f3265bea16f28c2af9d278b9d829c6 URL: https://github.com/llvm/llvm-project/commit/5951b0bb23f3265bea16f28c2af9d278b9d829c6 DIFF: https://github.com/llvm/llvm-project/commit/5951b0bb23f3265bea16f28c2af9d278b9d829c6.d

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

owenpan added a comment. Can you rebase (preferably after landing D138402 )? Comment at: clang/lib/Format/WhitespaceManager.cpp:991 +bool DontAlignThisComment = +i > 0 && Changes[i - 1].Tok->is(TT_NamespaceRBrace); bool WasAli

[clang] 15f121e - [clang-format] Fix an assertion failure in block parsing

Author: Owen Pan Date: 2022-12-06T14:14:20-08:00 New Revision: 15f121e853846d7c74c243a4249a069dd67ca166 URL: https://github.com/llvm/llvm-project/commit/15f121e853846d7c74c243a4249a069dd67ca166 DIFF: https://github.com/llvm/llvm-project/commit/15f121e853846d7c74c243a4249a069dd67ca166.diff LOG:

[PATCH] D139281: [clang-format] Fix an assertion failure in block parsing

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG15f121e85384: [clang-format] Fix an assertion failure in block parsing (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D139428: Handle char{8,16,32} and wchar_t in ASTContext::getIntegerRank()

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. Looks good to me! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139428/new/ https://reviews.llvm.org/D139428 ___ cfe-commits mai

[PATCH] D139148: Fix nullptr dereference found by Coverity static analysis tool

tahonermann requested changes to this revision. tahonermann added a comment. This revision now requires changes to proceed. Hmm, it seems the `assert` doesn't work in that location. The Linux and Windows builds both failed. It would be good to identify a simple test case for that. It seems we'll

[PATCH] D139274: Store OptTable::Info::Name as a StringRef

dyung added a comment. @serge-sans-paille Your change is causing 24 test failures on the Linux PS4 bot, mostly with an assertion failure it seems. Can you take a look? https://lab.llvm.org/buildbot/#/builders/139/builds/32263 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[clang] 6ab6085 - Revert "DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions"

Author: David Blaikie Date: 2022-12-06T22:52:47Z New Revision: 6ab6085c77ef9bcdabf842342f63fba4291791a4 URL: https://github.com/llvm/llvm-project/commit/6ab6085c77ef9bcdabf842342f63fba4291791a4 DIFF: https://github.com/llvm/llvm-project/commit/6ab6085c77ef9bcdabf842342f63fba4291791a4.diff LOG:

[PATCH] D138597: DebugInfo: Add/support new DW_LANG codes for recent C and C++ versions

probinson added a comment. Oh, right, PS4 defaults to C99. It's okay with me if you make those two unsupported for PS4. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138597/new/ https://reviews.llvm.org/D138597 __

[PATCH] D137996: Add support for a backdoor driver option that enables emitting header usage information in JSON to a file

jansvoboda11 added inline comments. Comment at: clang/lib/Frontend/HeaderIncludeGen.cpp:161 + case HIF_Textual: { +assert(!DepOpts.HeaderIncludeFiltering && + "header filtering is currently always disabled when output format is" ahatanak wrote: >

[PATCH] D139148: Fix nullptr dereference found by Coverity static analysis tool

schittir added a comment. Comment at: clang/lib/Sema/SemaInit.cpp:5947 if (TryOCLZeroOpaqueTypeInitialization(S, *this, DestType, Initializer)) return; #1/5 Coverity reported explicit null dereference of 'Initializer' Comment a

[PATCH] D139115: [clang][ExtractAPI] Add support for single symbol SGF

zixuw added inline comments. Comment at: clang/include/clang/ExtractAPI/API.h:128-130 + /// Store hierarchy information for a given record. + /// + /// This is roughly analogous to the DeclContext hierarchy for an AST Node. Misplaced comment? ===

[PATCH] D137379: [-Wunsafe-buffer-usage] Add warnings for unsafe buffer accesses by array subscript operations

ziqingluo-90 added inline comments. Comment at: clang/test/SemaCXX/warn-unsafe-buffer-usage.cpp:16 +void testArraySubscripts(int *p, int **pp) { + foo(p[0], // expected-warning{{unchecked operation on raw buffer in expression}} + pp[0][0], // expected-w

[PATCH] D139395: Add CFI integer types normalization

rcvalle updated this revision to Diff 480700. rcvalle retitled this revision from "Add support for integer types normalization" to "Add CFI integer types normalization". rcvalle edited the summary of this revision. rcvalle added a comment. Added documentation Repository: rG LLVM Github Monore

[PATCH] D137379: [-Wunsafe-buffer-usage] Add warnings for unsafe buffer accesses by array subscript operations

ziqingluo-90 updated this revision to Diff 480703. ziqingluo-90 added a comment. Addressing all the comments we have so far. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137379/new/ https://reviews.llvm.org/D137379 Files: clang/include/clang/Analysis/Analyses/UnsafeBufferUsageGadget

[clang] 303f20a - [C++20] [Modules] [Serialization] Deserialize

Author: Chuanqi Xu Date: 2022-12-07T10:52:02+08:00 New Revision: 303f20a2cab4554a10ec225fd853709146f8c51c URL: https://github.com/llvm/llvm-project/commit/303f20a2cab4554a10ec225fd853709146f8c51c DIFF: https://github.com/llvm/llvm-project/commit/303f20a2cab4554a10ec225fd853709146f8c51c.diff LO

[PATCH] D139406: C++20] [Modules] [Serialization] Deserialize LValuePathSerializationHelper's type properly

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG303f20a2cab4: [C++20] [Modules] [Serialization] Deserialize (authored by ChuanqiXu). Herald added a project: clang. Herald added a subscriber: cfe-co

[PATCH] D139496: [CMake] Use perf with LBR for clang-bolt (WIP)

Amir created this revision. Amir added reviewers: bolt, phosek. Herald added a project: All. Amir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `perf` provides a faster and easier way to collect BOLT profile. Generalize CMake handling of

[PATCH] D137996: Add support for a backdoor driver option that enables emitting header usage information in JSON to a file

ahatanak updated this revision to Diff 480737. ahatanak marked 3 inline comments as done. ahatanak added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137996/new/ https://reviews.llvm.org/D137996 Files: clang/

[PATCH] D139496: [CMake] Use perf with LBR for clang-bolt (WIP)

Amir updated this revision to Diff 480739. Amir added a comment. Fix dependence between bolt-profile and clang (either instrumented or not) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139496/new/ https://reviews.llvm.org/D139496 Files: clang/C

[clang] 4857b6f - Revert "Store OptTable::Info::Name as a StringRef"

Author: Douglas Yung Date: 2022-12-06T19:37:05-08:00 New Revision: 4857b6f8fff614c89ed35031c298df81394459af URL: https://github.com/llvm/llvm-project/commit/4857b6f8fff614c89ed35031c298df81394459af DIFF: https://github.com/llvm/llvm-project/commit/4857b6f8fff614c89ed35031c298df81394459af.diff

[PATCH] D139305: [clang][driver] Support option '-mcpu' on target AVR.

benshi001 updated this revision to Diff 480748. benshi001 retitled this revision from "[clang][driver] Make option '-mmcu' as an alias of option '-mcpu'" to "[clang][driver] Support option '-mcpu' on target AVR.". benshi001 edited the summary of this revision. CHANGES SINCE LAST ACTION https:/

[PATCH] D139305: [clang][driver] Support option '-mcpu' on target AVR.

benshi001 updated this revision to Diff 480749. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139305/new/ https://reviews.llvm.org/D139305 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp clang/test/Driver/avr-mmcu.c Index: clang/test/Driver/

[PATCH] D139305: [clang][driver] Support option '-mcpu' on target AVR.

benshi001 added a comment. In D139305#3974946 , @MaskRay wrote: > This makes `-mmcu=` available for non-AVR targets, which is not right. > Even for AVR, if this is a plain alias, is this really necessary? Usually > having more than one aliases for one fu

[PATCH] D139496: [CMake] Use perf with LBR for clang-bolt (WIP)

Amir updated this revision to Diff 480760. Amir added a comment. Fixed COMPILER_LAUNCHER, perf2bolt invocation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139496/new/ https://reviews.llvm.org/D139496 Files: clang/CMakeLists.txt clang/cmake/c

[PATCH] D139503: [Headers][ARM] Allow `struct _Unwind_Exception` in unwind.h

rprichard created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. rprichard requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Use the same approach as used in libunwind/include/unwind_arm_ehabi.h (D89570

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

tentzen added inline comments. Comment at: clang/test/CodeGen/windows-seh-EHa-CppCondiTemps.cpp:3 +// FIXME: this check appears to be miscompiled? +// XFAIL: * lebedev.ri wrote: > efriedma wrote: > > lebedev.ri wrote: > > > tentzen wrote: > > > > lebedev.ri wro

[PATCH] D139503: [Headers][ARM] Allow `struct _Unwind_Exception` in unwind.h

rprichard added a comment. As an aside, it seems interesting that libcxxabi/test/forced_unwind[12].pass.cpp don't compile for ARM EHABI when used with Clang's unwind.h. AFAICT it's been that way for a long time? $ /x/clang14/bin/clang -target arm-linux-gnueabi /x/llvm-upstream/llvm-project/l

[PATCH] D139378: [clang][CodeGen] Add noundef metadata to load instructions (preliminary 4 or 4)

jmciver updated this revision to Diff 480767. jmciver added a comment. Updating D139378 : [clang][CodeGen] Add noundef metadata to load instructions (preliminary 4 or 4) Update vector-noundef.cpp with rvalue element being stored in lvalue vector. Repository:

[PATCH] D139395: Add CFI integer types normalization

rcvalle updated this revision to Diff 480773. rcvalle added a comment. Added compression Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139395/new/ https://reviews.llvm.org/D139395 Files: clang/docs/ControlFlowIntegrity.rst clang/docs/UsersManu

[PATCH] D139507: [Intrinsic] Add get.rounding as alias to flt.rounds and rename related DAG nodes

qiucf created this revision. qiucf added reviewers: andrew.w.kaylor, sepavloff, kpn, RKSimon, craig.topper, nemanjai, cameron.mcinally. Herald added subscribers: jeroen.dobbelaere, StephenFan, frasercrmck, jdoerfert, luismarques, apazos, sameer.abuasal, pengfei, s.egerton, Jim, jocewei, PkmX, th

[PATCH] D139450: Warn about unsupported ibmlongdouble

nikic added a reviewer: PowerPC. nikic added a comment. Can you please upload the patch with full context (`-U9`)? The assumption here is that `libc++` is being compiled with a compiler that has the same ieeelongdouble default as the clang that is being built, right? I guess that's the most

[PATCH] D139395: Add CFI integer types normalization

rcvalle updated this revision to Diff 480775. rcvalle added a comment. Fixed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139395/new/ https://reviews.llvm.org/D139395 Files: clang/docs/ControlFlowIntegrity.rst clang/docs/UsersManual.

[PATCH] D139450: Warn about unsupported ibmlongdouble

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/PPCLinux.h:30 const llvm::opt::ArgList &Args) const; + bool SupportIBMLongDouble(const Driver &D, +const llvm::opt::ArgList &Args) const; --

[PATCH] D139505: [clang][CodeGen] Add noundef metadata to loading of references (preliminary 5 of 5)

jmciver created this revision. jmciver added reviewers: vitalybuka, jdoerfert, rjmccall, aqjune, efriedma, nikic. Herald added a project: All. jmciver retitled this revision from "[clang][CodeGen] Add noundef metadata to loading of references (item 5)" to "[clang][CodeGen] Add noundef metadata to

[PATCH] D135405: fix handling of braced-init temporaries for modernize-use-emplace

BigPeet added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135405/new/ https://reviews.llvm.org/D135405 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang-tools-extra] b70fbd0 - [clangd] Use std::nullopt instead of None (NFC)

Author: Kazu Hirata Date: 2022-12-06T23:50:19-08:00 New Revision: b70fbd0fd96f8ab64e44c37d8a532d58907fff6a URL: https://github.com/llvm/llvm-project/commit/b70fbd0fd96f8ab64e44c37d8a532d58907fff6a DIFF: https://github.com/llvm/llvm-project/commit/b70fbd0fd96f8ab64e44c37d8a532d58907fff6a.diff L

<    1   2   3