[PATCH] D139302: [RISCV] Add Syntacore SCR1 CPU model

dnpetrov-sc updated this revision to Diff 480352. dnpetrov-sc edited the summary of this revision. dnpetrov-sc added a comment. - fixed new line at end-of-file in RISCVSchedSCR1.td; - dropped scr1-min (RV32E unsupported). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D139397: [LoongArch] Add testcases for privileged intrinsic macros

gonglingqin created this revision. gonglingqin added reviewers: xen0n, xry111, SixWeining, wangleiat, MaskRay, XiaodongLoong. Herald added a subscriber: StephenFan. Herald added a project: All. gonglingqin requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D135750: [clang][Interp] Track initialization state of local variables

tbaeder marked 9 inline comments as done. tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:835 IsTemporary = true; Ty = E->getType(); } shafik wrote: > Do we really want to the type of the expression? If we have a `

[PATCH] D139398: [AMDGPU] Add bf16 storage support

Pierre-vh created this revision. Pierre-vh added reviewers: arsenm, foad, yaxunl. Herald added subscribers: kosarev, kerbowa, hiraditya, tpr, dstuttard, jvesely, kzhuravl. Herald added a project: All. Pierre-vh requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits,

[PATCH] D138651: [CUDA][HIP] Don't diagnose use for __bf16

Pierre-vh abandoned this revision. Pierre-vh added a comment. Added bf16 storage support instead: D139398 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138651/new/ https://reviews.llvm.org/D138651 ___

[PATCH] D128457: [clangd] Add new IncludeType to IncludeHeaderWithReferences

kadircet added a comment. it feels like rebasing went wrong. changes from 2 unrelated patches seem to be part of this one now. can you make sure this patch only contains the delta for symbolcollector/clangd pieces? Comment at: clang-tools-extra/clangd/Headers.h:50 + /// The

[PATCH] D139302: [RISCV] Add Syntacore SCR1 CPU model

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCV.td:637 +def : ProcessorModel<"scr1-min", SCR1Model, + [FeatureRV32E, FeatureStdExtC], + [TuneNoDefaultUnroll]>; dnpetrov-sc wrote: > craig.topper w

[PATCH] D139274: Store OptTable::Info::Name as a StringRef

serge-sans-paille updated this revision to Diff 480363. serge-sans-paille added a comment. fix test / compile errors CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139274/new/ https://reviews.llvm.org/D139274 Files: clang/lib/Driver/ToolChains/Gnu.cpp llvm/include/llvm/Option/OptTab

[PATCH] D139277: [clangd] Use all query-driver arguments in cache key

kadircet added a comment. thanks a lot for taking a look at this! Comment at: clang-tools-extra/clangd/SystemIncludeExtractor.cpp:301 llvm::StringRef Lang; +llvm::SmallVector AdditionalDriverArgs; + can we introduce a struct instead? ``` struct DriverA

[libunwind] ca0b4d5 - [libunwind][RISCV] Support reading of VLENB CSR register

Author: Sergey Kachkov Date: 2022-12-06T11:48:54+03:00 New Revision: ca0b4d58eaad405ea74b4db82ecb14b3cfdeccb7 URL: https://github.com/llvm/llvm-project/commit/ca0b4d58eaad405ea74b4db82ecb14b3cfdeccb7 DIFF: https://github.com/llvm/llvm-project/commit/ca0b4d58eaad405ea74b4db82ecb14b3cfdeccb7.diff

[PATCH] D139281: [clang-format] Fix an assertion failure in block parsing

owenpan updated this revision to Diff 480364. owenpan added a comment. Moved `isBlockBegin()` to `UnwrappedLineParser`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139281/new/ https://reviews.llvm.org/D139281 Files: clang/lib/Format/FormatToken.h clang/lib/Format/UnwrappedLinePar

[PATCH] D139274: Store OptTable::Info::Name as a StringRef

nikic added inline comments. Comment at: llvm/lib/Option/OptTable.cpp:44 if (a == '\0') return 0; The code in this function (and also StrCmpOptionName) depends on the terminating null byte, while a StringRef is not guaranteed to by directly follow

[PATCH] D139400: [clang] Show error when a local variables is passed as default template parameter

massberg created this revision. massberg added a reviewer: ilya-biryukov. Herald added a project: All. massberg requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I haven't found an existing error message for this in clang/include/clang/Basic/

[PATCH] D138779: [include-cleaner] Filter out references that not spelled in the main file.

hokein updated this revision to Diff 480367. hokein added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138779/new/ https://reviews.llvm.org/D138779 Files: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Analysi

[PATCH] D138779: [include-cleaner] Filter out references that not spelled in the main file.

hokein added a comment. this patch is ready for another review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138779/new/ https://reviews.llvm.org/D138779 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D139400: [clang] Show error when a local variables is passed as default template parameter

massberg updated this revision to Diff 480369. massberg added a comment. Fix test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139400/new/ https://reviews.llvm.org/D139400 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sem

[PATCH] D139288: [Clang][LoongArch] Add intrinsic for csrrd, csrwr and csrxchg

gonglingqin updated this revision to Diff 480371. gonglingqin added a comment. Add testcases for macros. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139288/new/ https://reviews.llvm.org/D139288 Files: clang/include/clang/Basic/BuiltinsLoongArc

[clang] b40e9dc - [clang-format] Avoid breaking )( with BlockIndent

Author: Gedare Bloom Date: 2022-12-06T01:04:51-08:00 New Revision: b40e9dce0a67beab352f7b7be43f13190f69b69c URL: https://github.com/llvm/llvm-project/commit/b40e9dce0a67beab352f7b7be43f13190f69b69c DIFF: https://github.com/llvm/llvm-project/commit/b40e9dce0a67beab352f7b7be43f13190f69b69c.diff

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb40e9dce0a67: [clang-format] Avoid breaking )( with BlockIndent (authored by gedare, committed by owenpan). Repository: rG LLVM Github Monorepo C

[PATCH] D138779: [include-cleaner] Filter out references that not spelled in the main file.

kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Analysis.h:36 /// Find and report all references to symbols in a region of code. +/// It will filter out references that are not spelled in the main file. /// --

[PATCH] D138821: [include-cleaner] Remove filtering from UsingDecl visit.

VitaNuo updated this revision to Diff 480375. VitaNuo added a comment. Re-introduce the isUsed check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138821/new/ https://reviews.llvm.org/D138821 Files: clang-tools-extra/include-cleaner/lib/WalkAST

[PATCH] D138821: [include-cleaner] Remove filtering from UsingDecl visit.

VitaNuo added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:86 report(UD->getLocation(), TD, IsUsed ? RefType::Explicit : RefType::Ambiguous); } hokein wrote: > VitaNuo wrote: > > kadircet wrote: > > > ho

[PATCH] D127844: [clangd] Pull suppression logic into common path, apply for driver diagnostics

kadircet added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127844/new/ https://reviews.llvm.org/D127844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D139087: [include-cleaner] Handle base class member access from derived class.

VitaNuo updated this revision to Diff 480378. VitaNuo added a comment. Address review comments, mostly style issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139087/new/ https://reviews.llvm.org/D139087 Files: clang-tools-extra/include-clea

[clang] 5b22c51 - [clang] Add test for CWG952

Author: Vlad Serebrennikov Date: 2022-12-06T12:27:22+03:00 New Revision: 5b22c5129c11f5c762c5092d7c52e1ac3d536903 URL: https://github.com/llvm/llvm-project/commit/5b22c5129c11f5c762c5092d7c52e1ac3d536903 DIFF: https://github.com/llvm/llvm-project/commit/5b22c5129c11f5c762c5092d7c52e1ac3d536903.

[PATCH] D139326: [clang] Add test for CWG952

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5b22c5129c11: [clang] Add test for CWG952 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D138788: [SVE] Change some bfloat lane intrinsics to use i32 immediates

david-arm marked an inline comment as done. david-arm added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:2527 -def int_aarch64_sve_bfdot_lane : SVE_4Vec_BF16_Indexed; -def int_aarch64_sve_bfmlalb_lane : SVE_4Vec_BF16_Indexed; -def int_aarch64_sve_bfm

[clang] 80bae9a - [clang] Add test for CWG405

Author: Vlad Serebrennikov Date: 2022-12-06T12:35:21+03:00 New Revision: 80bae9aacc1452d18bfb1fe7437f5dcd160614d3 URL: https://github.com/llvm/llvm-project/commit/80bae9aacc1452d18bfb1fe7437f5dcd160614d3 DIFF: https://github.com/llvm/llvm-project/commit/80bae9aacc1452d18bfb1fe7437f5dcd160614d3.

[PATCH] D139095: [clang] Add test for CWG405

This revision was automatically updated to reflect the committed changes. Closed by commit rG80bae9aacc14: [clang] Add test for CWG405 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139095/new/ https://reviews.llvm.org/D139095

[clang] 6d971cb - [clang] Mark CWG554 as N/A

Author: Vlad Serebrennikov Date: 2022-12-06T12:39:19+03:00 New Revision: 6d971cb840dbb3f05689469bf11e49046ce2fae1 URL: https://github.com/llvm/llvm-project/commit/6d971cb840dbb3f05689469bf11e49046ce2fae1 DIFF: https://github.com/llvm/llvm-project/commit/6d971cb840dbb3f05689469bf11e49046ce2fae1.

[PATCH] D139172: [clang] Mark CWG554 as N/A

This revision was automatically updated to reflect the committed changes. Closed by commit rG6d971cb840db: [clang] Mark CWG554 as N/A (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139172/new/ https://reviews.llvm.org/D139172 F

[clang] 2fbe3f9 - [Clang] make_cxx_dr_status download the issue list automatically

Author: Corentin Jabot Date: 2022-12-06T10:40:06+01:00 New Revision: 2fbe3f9e7941858e9c856474737b5a1420448eb8 URL: https://github.com/llvm/llvm-project/commit/2fbe3f9e7941858e9c856474737b5a1420448eb8 DIFF: https://github.com/llvm/llvm-project/commit/2fbe3f9e7941858e9c856474737b5a1420448eb8.diff

[PATCH] D139212: [Clang] make_cxx_dr_status download the issue list automatically

This revision was automatically updated to reflect the committed changes. Closed by commit rG2fbe3f9e7941: [Clang] make_cxx_dr_status download the issue list automatically (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139212/n

[clang] 7e31d07 - [clang] Add test for CWG600

Author: Vlad Serebrennikov Date: 2022-12-06T12:42:35+03:00 New Revision: 7e31d0723dbf8ab9355cb58cfc6309be51be3e25 URL: https://github.com/llvm/llvm-project/commit/7e31d0723dbf8ab9355cb58cfc6309be51be3e25 DIFF: https://github.com/llvm/llvm-project/commit/7e31d0723dbf8ab9355cb58cfc6309be51be3e25.

[PATCH] D139173: [clang] Add test for CWG600

This revision was automatically updated to reflect the committed changes. Closed by commit rG7e31d0723dbf: [clang] Add test for CWG600 (authored by Endill). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139173/new/ https://reviews.llvm.org/D139173

[clang] 3f65691 - [NFC] Remove const from return value of function

Author: Juan Manuel MARTINEZ CAAMAÑO Date: 2022-12-06T04:46:33-05:00 New Revision: 3f65691737641c3b46bee11c9cf0e52046af3a49 URL: https://github.com/llvm/llvm-project/commit/3f65691737641c3b46bee11c9cf0e52046af3a49 DIFF: https://github.com/llvm/llvm-project/commit/3f65691737641c3b46bee11c9cf0e52

[PATCH] D138200: [include-cleaner] Make use of locateSymbol in WalkUsed

sammccall added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/Analysis.cpp:44 + + // Cache for decl to header mappings, as the same decl might be referenced in + // multiple locations and finding providers for each location is expensive. ka

[PATCH] D138253: [-Wunsafe-buffer-usage] NFC: Implement fix-strategies and variable-use-claiming.

NoQ updated this revision to Diff 480394. NoQ marked 9 inline comments as done. NoQ added a comment. A cleaner way to implement the debug facility. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138253/new/ https://reviews.llvm.org/D138253 Files: clang/include/clang/Analysis/Analyses/

[PATCH] D137348: [-Wunsafe-buffer-usage] Introduce an abstraction for fixable code patterns.

NoQ updated this revision to Diff 480396. NoQ added a comment. A cleaner way to implement the debug facility. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137348/new/ https://reviews.llvm.org/D137348 Files: clang/include/clang/Analysis/Analyses/UnsafeBufferUsageGadgets.def clang/l

[PATCH] D138253: [-Wunsafe-buffer-usage] NFC: Implement fix-strategies and variable-use-claiming.

NoQ updated this revision to Diff 480397. NoQ added a comment. Whoops, sorry, wrong patch. I was trying to say, "Address review comments". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138253/new/ https://reviews.llvm.org/D138253 Files: clang/include/clang/Analysis/Analyses/UnsafeBuf

[PATCH] D138253: [-Wunsafe-buffer-usage] NFC: Implement fix-strategies and variable-use-claiming.

NoQ added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:17-19 +// Because the analysis revolves around variables and their types, we'll need to +// track uses of variables (aka DeclRefExprs). +using DeclUseList = SmallVector; aaron.ballma

[PATCH] D138807: [RISCV] Support vector crypto extension ISA string and assembly

ego added a comment. I have been working on a patch set to support Zvk. It will take me a few more days to prepare my patches to post them publicly. Your patches are in a very good shape and a lot of files end up looking pretty similar. I have a few comments, most minor. This is my first review

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

sammccall added a comment. For my part, I still need to understand why we want the `builtin`/`UserModified` modifier. (The `operator` highlight kind seems obvious to me). From earlier comments: >> Can you give some background here or on the bug tracker about what kind of >> distinction you're

[PATCH] D138821: [include-cleaner] Remove filtering from UsingDecl visit.

hokein added inline comments. Comment at: clang-tools-extra/include-cleaner/unittests/WalkASTTest.cpp:130 TEST(WalkAST, Using) { - // Make sure we ignore unused overloads. + // We should report unused overloads as ambiguous. testWalk(R"cpp( hokein wrote: >

[PATCH] D138722: Overload all llvm.annotation intrinsics for globals argument

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/test/Bitcode/upgrade-annotation.ll:14 + +declare i32 @llvm.annotation.i32(i32, i8*, i8*, i32) +; CHECK: declare i32 @llvm.annotation.i32.p0i8(i32, i8*, i8

[PATCH] D139409: [include-cleaner] Handle dependent type members in AST

VitaNuo created this revision. Herald added a subscriber: kadircet. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Handles dependent type members in AST. Repository: rG LLVM Github Monor

[PATCH] D138821: [include-cleaner] Remove filtering from UsingDecl visit.

VitaNuo updated this revision to Diff 480418. VitaNuo added a comment. Change/remove stale comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138821/new/ https://reviews.llvm.org/D138821 Files: clang-tools-extra/include-cleaner/lib/WalkAST.

[PATCH] D138200: [include-cleaner] Make use of locateSymbol in WalkUsed

kadircet marked 5 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/test/html.cpp:7 int n = foo(); +// CHECK: Symbol{{.*}}foo +// CHECK-NEXT: int foo() sammccall wrote: > I'd like to keep a very simple smoke t

[PATCH] D138200: [include-cleaner] Make use of locateSymbol in WalkUsed

kadircet updated this revision to Diff 480419. kadircet marked an inline comment as done. kadircet added a comment. - Drop the cache - Use `-print=changes` in lit test - Update unittest helper to limit decls to main file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D138821: [include-cleaner] Remove filtering from UsingDecl visit.

VitaNuo marked 2 inline comments as done. VitaNuo added inline comments. Comment at: clang-tools-extra/include-cleaner/unittests/WalkASTTest.cpp:130 TEST(WalkAST, Using) { - // Make sure we ignore unused overloads. + // We should report unused overloads as ambiguous. testWa

[PATCH] D138200: [include-cleaner] Make use of locateSymbol in WalkUsed

kadircet updated this revision to Diff 480420. kadircet added a comment. - Fix RUN: line in lit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138200/new/ https://reviews.llvm.org/D138200 Files: clang-tools-extra/include-cleaner/lib/Analysis

[PATCH] D139087: [include-cleaner] Handle base class member access from derived class.

hokein added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:68 bool VisitMemberExpr(MemberExpr *E) { -report(E->getMemberLoc(), E->getFoundDecl().getDecl()); +// Instead of the FieldDecl for MemberExpr, we report the Decl of +// the

[PATCH] D139125: [clang] Correctly handle by-reference capture with an initializer that is a pack expansion in lambdas.

massberg added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:13156 getSema().buildLambdaInitCaptureInitialization( - C->getLocation(), OldVD->getType()->isReferenceType(), + C->getLocation(), isReferenceType, Ellip

[PATCH] D139274: Store OptTable::Info::Name as a StringRef

serge-sans-paille updated this revision to Diff 480421. serge-sans-paille added a comment. Also simplify `StrCmpOptionNameIgnoreCase` implementation thanks to the move to StringRef CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139274/new/ https://reviews.llvm.org/D139274 Files: clan

[PATCH] D138200: [include-cleaner] Make use of locateSymbol in WalkUsed

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. looks good from my side. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138200/new/ https://reviews.llvm.org/D138200 ___

[PATCH] D139087: [include-cleaner] Handle base class member access from derived class.

VitaNuo updated this revision to Diff 480422. VitaNuo marked an inline comment as done. VitaNuo added a comment. Address review comments: change comment, add more test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139087/new/ https://reviews

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

ckandeler added a comment. In D136594#3973812 , @sammccall wrote: > For my part, I still need to understand why we want the > `builtin`/`UserModified` modifier. (The `operator` highlight kind seems > obvious to me). We make this distinction in our clie

[PATCH] D139274: Store OptTable::Info::Name as a StringRef

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LG Comment at: llvm/lib/Option/OptTable.cpp:41 + size_t MinSize = std::min(A.size(), B.size()); + if (int res = A.substr(0, MinSize).compare_insensitive(B.substr(0, MinSize))

[PATCH] D138755: [Clang][CodeGen] Use poison instead of undef for extra argument in __builtin_amdgcn_mov_dpp [NFC]

ManuelJBrito edited reviewers, added: arsenm; removed: yaxunl. ManuelJBrito added a comment. Herald added a subscriber: wdng. Is this change OK? It seems to me that here undef is just a placeholder. Was hoping that some AMDGPU folks could review it. Repository: rG LLVM Github Monorepo CHANGE

[clang] 83b3304 - [AArch64] Implement __arm_rsr128/__arm_wsr128

Author: Archibald Elliott Date: 2022-12-06T11:39:05Z New Revision: 83b3304dd2a3bee8b6b4f76282adb734a5d1c8ff URL: https://github.com/llvm/llvm-project/commit/83b3304dd2a3bee8b6b4f76282adb734a5d1c8ff DIFF: https://github.com/llvm/llvm-project/commit/83b3304dd2a3bee8b6b4f76282adb734a5d1c8ff.diff

[PATCH] D139086: [AArch64] Implement __arm_rsr128/__arm_wsr128

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG83b3304dd2a3: [AArch64] Implement __arm_rsr128/__arm_wsr128 (authored by lenary). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D138200: [include-cleaner] Make use of locateSymbol in WalkUsed

sammccall accepted this revision. sammccall added a comment. LG, thanks! Comment at: clang-tools-extra/include-cleaner/lib/Analysis.cpp:33 + for (auto &Loc : locateSymbol(S)) +// FIXME: findHeaders in theory returns the same result for all source +// locations in the s

[PATCH] D138755: [Clang][CodeGen] Use poison instead of undef for extra argument in __builtin_amdgcn_mov_dpp [NFC]

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. I think this is OK. It’s use of uninitialized value, those uninitialized values just happen to come from inactive lanes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D139395: Add support for integer types normalization

ojeda added subscribers: nathanchance, nickdesaulniers. ojeda added a comment. Cc @nickdesaulniers @nathanchance Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139395/new/ https://reviews.llvm.org/D139395 ___

[PATCH] D139398: [AMDGPU] Add bf16 storage support

Pierre-vh updated this revision to Diff 480431. Pierre-vh added a comment. - Only accept bf16 on AMDGCN; r600 doesn't support it (we could but it's not worth the effort I think; I'll look at it if we find out it's needed) - Remove bf16 types from a few register classes Repository: rG LLVM Git

[clang] 481170c - [Clang][CodeGen] Use poison instead of undef for extra argument in __builtin_amdgcn_mov_dpp [NFC]

Author: Manuel Brito Date: 2022-12-06T12:40:33Z New Revision: 481170cb551124ed89353dd55a89b1d9971e9a6d URL: https://github.com/llvm/llvm-project/commit/481170cb551124ed89353dd55a89b1d9971e9a6d DIFF: https://github.com/llvm/llvm-project/commit/481170cb551124ed89353dd55a89b1d9971e9a6d.diff LOG:

[PATCH] D138755: [Clang][CodeGen] Use poison instead of undef for extra argument in __builtin_amdgcn_mov_dpp [NFC]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG481170cb5511: [Clang][CodeGen] Use poison instead of undef for extra argument in… (authored by ManuelJBrito, committed by nlopes). Repository: rG

[PATCH] D139288: [Clang][LoongArch] Add intrinsic for csrrd, csrwr and csrxchg

SixWeining accepted this revision. SixWeining added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139288/new/ https://reviews.llvm.org/D139288 __

[PATCH] D139398: [AMDGPU] Add bf16 storage support

arsenm requested changes to this revision. arsenm added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Basic/Targets/AMDGPU.h:119 + bool hasBFloat16Type() const override { return isAMDGCN(getTriple()); } + const char *getBFloat16Mangling()

[PATCH] D139398: [AMDGPU] Add bf16 storage support

arsenm added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:147 addRegisterClass(MVT::f16, &AMDGPU::SReg_32RegClass); +addRegisterClass(MVT::bf16, &AMDGPU::SReg_32RegClass); Do you really need to add this to a register class? Th

[clang] 8ae1830 - Store OptTable::Info::Name as a StringRef

Author: serge-sans-paille Date: 2022-12-06T14:10:07+01:00 New Revision: 8ae18303f97d5dcfaecc90b4d87effb2011ed82e URL: https://github.com/llvm/llvm-project/commit/8ae18303f97d5dcfaecc90b4d87effb2011ed82e DIFF: https://github.com/llvm/llvm-project/commit/8ae18303f97d5dcfaecc90b4d87effb2011ed82e.d

[PATCH] D139274: Store OptTable::Info::Name as a StringRef

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8ae18303f97d: Store OptTable::Info::Name as a StringRef (authored by serge-sans-paille). Changed prior to commit: https://reviews.llvm.org/D139274

[PATCH] D139416: [clang-format] Don't require deduction guides to be templates

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The C++ standard doesn't require that class template dedu

[PATCH] D139274: Store OptTable::Info::Name as a StringRef

thakis added a comment. This breaks building lldb: http://45.33.8.238/linux/93366/step_4.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139274/new/ https://reviews.llvm.org/D139274 ___ cfe-commits mai

[clang] de4b6a1 - Revert "Store OptTable::Info::Name as a StringRef"

Author: Nico Weber Date: 2022-12-06T08:43:48-05:00 New Revision: de4b6a1bc64db33643f001ad45fae7b92b4a4688 URL: https://github.com/llvm/llvm-project/commit/de4b6a1bc64db33643f001ad45fae7b92b4a4688 DIFF: https://github.com/llvm/llvm-project/commit/de4b6a1bc64db33643f001ad45fae7b92b4a4688.diff LO

[PATCH] D139274: Store OptTable::Info::Name as a StringRef

thakis added a comment. Reverted in de4b6a1bc64db33643f001ad45fae7b92b4a4688 for now. (Note that there was a follow-up fix in e50a60d7349de151bd2b06d85a79201ebc372d8a

[PATCH] D139274: Store OptTable::Info::Name as a StringRef

serge-sans-paille added a comment. In D139274#3974176 , @thakis wrote: > Reverted in de4b6a1bc64db33643f001ad45fae7b92b4a4688 > for > now. (Note that there was a follow-up fix in > e

[clang] af95441 - [clang] Tweak test to tolerate clang being called "clang" instead of "clang-15"

Author: Nico Weber Date: 2022-12-06T08:50:37-05:00 New Revision: af95441ba7f3ca61c925409e58ee7e5486d84033 URL: https://github.com/llvm/llvm-project/commit/af95441ba7f3ca61c925409e58ee7e5486d84033 DIFF: https://github.com/llvm/llvm-project/commit/af95441ba7f3ca61c925409e58ee7e5486d84033.diff LO

[PATCH] D137275: [Driver][test] Fix test by creating empty archive instead of empty file

thakis added a comment. In D137275#3972773 , @thakis wrote: > This breaks check-clang: http://45.33.8.238/linux/93300/step_7.txt > > Please take a look and revert for now if it takes a while to fix. This ended up being a local config thing that I fixed i

[PATCH] D138200: [include-cleaner] Make use of locateSymbol in WalkUsed

kadircet marked 2 inline comments as done. kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/test/multiple-providers.cpp:1 +// RUN: clang-include-cleaner --print=changes %s -- -I %S/Inputs | FileCheck \ +// RUN: --allow-empty %s sammcc

[PATCH] D138200: [include-cleaner] Make use of locateSymbol in WalkUsed

kadircet updated this revision to Diff 480454. kadircet marked an inline comment as done. kadircet added a comment. - Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138200/new/ https://reviews.llvm.org/D138200 Files: clang-tools-

[PATCH] D138200: [include-cleaner] Make use of locateSymbol in WalkUsed

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG29a8eec1f9eb: [include-cleaner] Make use of locateSymbol in WalkUsed and HTMLReport (authored by kadircet). Repository: rG LLVM Github Monorepo C

[clang-tools-extra] 29a8eec - [include-cleaner] Make use of locateSymbol in WalkUsed and HTMLReport

Author: Kadir Cetinkaya Date: 2022-12-06T15:03:11+01:00 New Revision: 29a8eec1f9eb6df8d52d8621415754989595fb6a URL: https://github.com/llvm/llvm-project/commit/29a8eec1f9eb6df8d52d8621415754989595fb6a DIFF: https://github.com/llvm/llvm-project/commit/29a8eec1f9eb6df8d52d8621415754989595fb6a.dif

[PATCH] D138788: [SVE] Change some bfloat lane intrinsics to use i32 immediates

david-arm updated this revision to Diff 480451. david-arm added a comment. I did try to avoid having to create an intrinsic with a different name, but I was thwarted at every turn! It is with great regret that I report these two problems: 1. When you write an IR test file containing a declarati

[PATCH] D139428: Handle char{8,16,32} and wchar_t in ASTContext::getIntegerRank()

hans created this revision. hans added a reviewer: aaron.ballman. Herald added a project: All. hans requested review of this revision. Herald added a project: clang. They were previously not handled, causing the llvm_unreachable with "getIntegerRank(): not a built-in integer" message to be hit.

[PATCH] D128457: [clangd] Add new IncludeType to IncludeHeaderWithReferences

dgoldman updated this revision to Diff 480465. dgoldman marked 4 inline comments as done. dgoldman added a comment. Fixes + hopefully proper diffbase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128457/new/ https://reviews.llvm.org/D128457 Files:

[PATCH] D139409: [include-cleaner] Handle dependent type members in AST

VitaNuo updated this revision to Diff 480466. VitaNuo added a comment. Implement dependent type handling for template specialization types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139409/new/ https://reviews.llvm.org/D139409 Files: clang-t

[PATCH] D139409: [include-cleaner] Handle dependent type members in AST

VitaNuo updated this revision to Diff 480467. VitaNuo added a comment. Remove extra import. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139409/new/ https://reviews.llvm.org/D139409 Files: clang-tools-extra/include-cleaner/lib/WalkAST.cpp cla

[PATCH] D138788: [SVE] Change some bfloat lane intrinsics to use i32 immediates

paulwalker-arm accepted this revision. paulwalker-arm added inline comments. This revision is now accepted and ready to land. Comment at: llvm/include/llvm/IR/IntrinsicsAArch64.td:1517 -class SVE_4Vec_BF16_Indexed +class SVE_4Vec_BF16_Indexed_V2 : DefaultAttrsIntrinsic<[ll

[PATCH] D139409: [include-cleaner] Handle dependent type members in AST

VitaNuo updated this revision to Diff 480469. VitaNuo added a comment. Adjust implementation to handle pointer types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139409/new/ https://reviews.llvm.org/D139409 Files: clang-tools-extra/include-cle

[PATCH] D128457: [clangd] Add new IncludeType to IncludeHeaderWithReferences

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: clang/unittests/Tooling/HeaderAnalysisTest.cpp:69 + #include "foo.h" +#import "NSFoo.h" + indentation C

[clang] 26e50c4 - [ARM/Darwin] Convert tests to check 'target='

Author: Paul Robinson Date: 2022-12-06T06:58:39-08:00 New Revision: 26e50c4c4df10de7bd8fcad520bf11ab94331eac URL: https://github.com/llvm/llvm-project/commit/26e50c4c4df10de7bd8fcad520bf11ab94331eac DIFF: https://github.com/llvm/llvm-project/commit/26e50c4c4df10de7bd8fcad520bf11ab94331eac.diff

[PATCH] D139429: [clang] Add test for CWG418

Endill created this revision. Endill added a reviewer: clang-language-wg. Herald added a project: All. Endill requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P1787 : //CWG418

[PATCH] D139125: [clang] Correctly handle by-reference capture with an initializer that is a pack expansion in lambdas.

massberg updated this revision to Diff 480475. massberg added a comment. Moved check if we have a pack expansion with reference type to Sema::BuildLambdaExpr. I'm still not sure if this is the right place, or if `From.isCopyCapture()` should be `false` for pack expansions with refernece types.

[PATCH] D139398: [AMDGPU] Add bf16 storage support

Pierre-vh added inline comments. Comment at: clang/lib/Basic/Targets/AMDGPU.h:119 + bool hasBFloat16Type() const override { return isAMDGCN(getTriple()); } + const char *getBFloat16Mangling() const override { return "u6__bf16"; }; + arsenm wrote: > Don't unders

[PATCH] D135247: [clang][analyzer] Add stream functions to StdLibraryFunctionsChecker.

balazske added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp:786 /// constraints (and different return value constraints). - const NoErrnoConstraint ErrnoIrrelevant{}; + const NoErrnoConstraint ErrnoUnchanged{}; + const ResetE

[PATCH] D128677: [clang][Tooling] Add support for generating #import edits

dgoldman updated this revision to Diff 480482. dgoldman marked 9 inline comments as done. dgoldman added a comment. Fixes for review + fix diffbase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128677/new/ https://reviews.llvm.org/D128677 Files:

[PATCH] D128677: [clang][Tooling] Add support for generating #import edits

dgoldman added inline comments. Comment at: clang/unittests/Tooling/HeaderIncludesTest.cpp:65 +TEST_F(HeaderIncludesTest, InsertImportWithSameInclude) { + std::string Code = "#include \"a.h\"\n"; kadircet wrote: > can you also add a removal test? > > i know w

[PATCH] D137275: [Driver][test] Fix test by creating empty archive instead of empty file

thakis added a comment. …but even after that, things are still broken on macOS: http://45.33.8.238/macm1/50243/step_7.txt ar: no archive members specified usage: ar -d [-TLsv] archive file ... ar -m [-TLsv] archive file ... ar -m [-abiTLsv] position archive file ...

[PATCH] D139429: [clang] Add test for CWG418

cor3ntin added a comment. I'm not sure how I feel about this. Clang does not, implement correctly that paragraph at all, so I think the best course here is to create an issue on the llvm github and mark the dr resolved as part of fixing the bug in clang. The fact the previous wording was unclear

  1   2   3   >