[PATCH] D138376: Use None consistently (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1fa870b1bd6c: Use None consistently (NFC) (authored by kazu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D138371: [clang-format] Fix a crash due to dereferencing null MatchingParen

rymiel added a comment. Could the check be hoisted to the top of the loop? could that possibly catch more cases? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138371/new/ https://reviews.llvm.org/D138371 ___ cfe-commits mailing list cfe-comm

[PATCH] D138371: [clang-format] Fix a crash due to dereferencing null MatchingParen

rymiel added a comment. Oops, nevermind, I misunderstood the loop CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138371/new/ https://reviews.llvm.org/D138371 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D138378: [clang-format][NFC] Skip unneeded calculations

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, rymiel. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscribe

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

njames93 added a subscriber: sammccall. njames93 added a comment. @sammccall I have a feeling you're gonna want to examine this checks feasibility in clangd. Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyOnLastUseCheck.cpp:79 + +static auto findDeclRefBl

[PATCH] D22505: [clang-format] Access Modifier Use Normal Indent

HazardyKnusperkeks abandoned this revision. HazardyKnusperkeks added a comment. Closing because of the long silence. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D22505/new/ https://reviews.llvm.org/D22505 _

[PATCH] D138376: Use None consistently (NFC)

ayermolo added a comment. Is there an a RFC for this or something? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138376/new/ https://reviews.llvm.org/D138376 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Febbe added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyOnLastUseCheck.cpp:79 + +static auto findDeclRefBlock(CFG const *TheCFG, DeclRefExpr const *DeclRef) +-> FindDeclRefBlockReturn { njames93 wrote: > We generally

[PATCH] D138376: Use None consistently (NFC)

tschuett added a comment. https://discourse.llvm.org/t/deprecating-llvm-optional-x-hasvalue-getvalue-getvalueor/63716 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138376/new/ https://reviews.llvm.org/D138376 __

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Febbe updated this revision to Diff 476757. Febbe marked 3 inline comments as done and 3 inline comments as done. Febbe added a comment. Improved fixit suggestion. - No duplicated replacements. Removed replacements for macros, since they could be wrong somehow. Made some helperfunction non-trail

[clang] 4f0520f - [Clang] Add papers approved in Kona by WG21 to the C++ status page

Author: Corentin Jabot Date: 2022-11-20T18:51:52+01:00 New Revision: 4f0520f82e6693ef5f439d5e998765fe965f25ec URL: https://github.com/llvm/llvm-project/commit/4f0520f82e6693ef5f439d5e998765fe965f25ec DIFF: https://github.com/llvm/llvm-project/commit/4f0520f82e6693ef5f439d5e998765fe965f25ec.diff

[PATCH] D137020: [clang][AST] Handle variable declaration with unknown typedef in C

urazoff updated this revision to Diff 476766. urazoff added a comment. - Added test for AST dump of invalid C code - Added testcase for diagnostics - Some minor fixes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137020/new/ https://reviews.llvm.org/D137020 Files: clang/lib/Parse/Par

[PATCH] D138371: [clang-format] Fix a crash due to dereferencing null MatchingParen

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. In D138371#3939682 , @rymiel wrote: > Oops, nevermind, I misunderstood the loop To understand this is really a tough one. Took

[PATCH] D138263: [clang-format] Supress aligning of trailing namespace comments

HazardyKnusperkeks added a comment. In D138263#3938593 , @owenpan wrote: > Something like the following: > > diff --git a/clang/lib/Format/FormatToken.h b/clang/lib/Format/FormatToken.h > index 87515372046d..3dc5e411df55 100644 > --- a/clang/lib/For

[PATCH] D138385: [clang-format][NFC] Removed unused include

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, rymiel. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscribe

[PATCH] D137213: [clang][modules] NFCI: Pragma diagnostic mappings: write/read FileID instead of SourceLocation

alexfh added a comment. Heads up: this commit has broken compilation in a small number of cases: some #includes from modularized headers now fail to be found. I'm still trying to figure out what exactly happened, but some behavior has definitely changed by this commit. Repository: rG LLVM G

[PATCH] D138274: Add version to all LLVM cmake package

This revision was automatically updated to reflect the committed changes. Closed by commit rGad485b71b511: Add version to all LLVM cmake package (authored by thopre). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138274/new/ https://reviews.llvm.org

[clang] ad485b7 - Add version to all LLVM cmake package

Author: Thomas Preud'homme Date: 2022-11-20T21:09:50Z New Revision: ad485b71b51168ce13282ae159bd8feff48baf84 URL: https://github.com/llvm/llvm-project/commit/ad485b71b51168ce13282ae159bd8feff48baf84 DIFF: https://github.com/llvm/llvm-project/commit/ad485b71b51168ce13282ae159bd8feff48baf84.diff

[clang] 30f9eb1 - [clang] Remove unused forward declarations (NFC)

Author: Kazu Hirata Date: 2022-11-20T14:32:17-08:00 New Revision: 30f9eb1eb81cb3cac9016da1fb79e2ff80f766d6 URL: https://github.com/llvm/llvm-project/commit/30f9eb1eb81cb3cac9016da1fb79e2ff80f766d6 DIFF: https://github.com/llvm/llvm-project/commit/30f9eb1eb81cb3cac9016da1fb79e2ff80f766d6.diff L

[PATCH] D138387: [Clang] Implement static operator[]

royjacobson created this revision. royjacobson added reviewers: cor3ntin, erichkeane. Herald added a project: All. royjacobson requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. After accepted in Kona, update the code to accept static operator

[PATCH] D138387: [Clang] Implement static operator[]

cor3ntin added a comment. Thanks for working on this, it was fast! It looks good except for an issue with the diagnostic (which was partly pre-existing) Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9111-9115 def ext_operator_overload_static : ExtWarn< "decl

[PATCH] D137043: [clang] add implicit include for Linux/gnu compatibility

aaronpuchert added a comment. In D137043#3935526 , @Origami404 wrote: > In D137043#3935129 , @aaronpuchert > wrote: > >> This include-if-exists mechanism seems brittle to me. > > Do you mean the way that we used

[PATCH] D138371: [clang-format] Fix a crash due to dereferencing null MatchingParen

rymiel added a comment. In D138371#3939938 , @HazardyKnusperkeks wrote: > In D138371#3939682 , @rymiel wrote: > >> Oops, nevermind, I misunderstood the loop > > To understand this is really a tough one. Took me s

[clang] c2ec455 - [LoongArch] Add intrinsics for ibar, break and syscall

Author: gonglingqin Date: 2022-11-21T09:31:26+08:00 New Revision: c2ec455f183d88a63d3cffe23ca6ff1acf0d7d07 URL: https://github.com/llvm/llvm-project/commit/c2ec455f183d88a63d3cffe23ca6ff1acf0d7d07 DIFF: https://github.com/llvm/llvm-project/commit/c2ec455f183d88a63d3cffe23ca6ff1acf0d7d07.diff L

[PATCH] D138094: [LoongArch] Add intrinsics for ibar, break and syscall

This revision was automatically updated to reflect the committed changes. Closed by commit rGc2ec455f183d: [LoongArch] Add intrinsics for ibar, break and syscall (authored by gonglingqin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138094/new/ ht

[PATCH] D138378: [clang-format][NFC] Skip unneeded calculations

owenpan added inline comments. Comment at: clang/lib/Format/WhitespaceManager.cpp:1433 // assert((int)C.StartOfTokenColumn >= C.Spaces); - appendIndentText( - ReplacementText, C.Tok->IndentLevel, std::max(0, C.Spaces), - std::max((int)C.StartOfTokenC

[PATCH] D136594: [clangd] Add support for semantic token type "operator"

nridge added a comment. A couple of high-level thoughts on this: 1. Based on the discussion in https://github.com/clangd/clangd/issues/1115, I believe highlighting of **built-in** operators should be out of scope for semantic highlighting, at least in the default mode; client-side highlighting

[PATCH] D138350: [scudo] Add loongarch64 support for scudo

SixWeining accepted this revision. SixWeining added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138350/new/ https://reviews.llvm.org/D138350 __

[clang] eb3f788 - [clang-tblgen][NFC] renames Diagnostic.Text to Diagnostic.Summary

Author: Christopher Di Bella Date: 2022-11-21T03:44:37Z New Revision: eb3f7880a272b818940e2bd2510ae04b0e32873f URL: https://github.com/llvm/llvm-project/commit/eb3f7880a272b818940e2bd2510ae04b0e32873f DIFF: https://github.com/llvm/llvm-project/commit/eb3f7880a272b818940e2bd2510ae04b0e32873f.dif

[PATCH] D135820: [clang-tblgen] renames Diagnostic.Text to Diagnostic.Summary

This revision was automatically updated to reflect the committed changes. Closed by commit rGeb3f7880a272: [clang-tblgen][NFC] renames Diagnostic.Text to Diagnostic.Summary (authored by cjdb). Changed prior to commit: https://reviews.llvm.org/D135820?vs=467283&id=476793#toc Repository: rG LL

[clang] 196edb9 - Revert "[clang-tblgen][NFC] renames Diagnostic.Text to Diagnostic.Summary"

Author: Christopher Di Bella Date: 2022-11-21T04:35:41Z New Revision: 196edb9f3f4a036371af0013a3d8b857fe0924d5 URL: https://github.com/llvm/llvm-project/commit/196edb9f3f4a036371af0013a3d8b857fe0924d5 DIFF: https://github.com/llvm/llvm-project/commit/196edb9f3f4a036371af0013a3d8b857fe0924d5.dif

[PATCH] D138392: clang/HIP: Fix broken implementations of __make_mantissa* functions

arsenm created this revision. arsenm added reviewers: yaxunl, JonChesterfield, saiislam, scchan, AlexVlx, b-sumner. Herald added a project: All. arsenm requested review of this revision. Herald added a subscriber: wdng. The optimizer was folding the entire function to return 0. This meant to be c

[PATCH] D138394: HIP: Directly call fma builtins

arsenm created this revision. arsenm added reviewers: yaxunl, JonChesterfield, b-sumner. Herald added a project: All. arsenm requested review of this revision. Herald added a subscriber: wdng. https://reviews.llvm.org/D138394 Files: clang/lib/Headers/__clang_hip_math.h clang/test/Headers/__cl

[PATCH] D138395: HIP: Directly call fmin/fmax builtins

arsenm created this revision. arsenm added reviewers: yaxunl, b-sumner, JonChesterfield. Herald added a project: All. arsenm requested review of this revision. Herald added a subscriber: wdng. https://reviews.llvm.org/D138395 Files: clang/lib/Headers/__clang_hip_math.h clang/test/Headers/__cl

[PATCH] D138396: HIP: Directly call signbit builtins

arsenm created this revision. arsenm added reviewers: JonChesterfield, b-sumner, yaxunl. Herald added a project: All. arsenm requested review of this revision. Herald added a subscriber: wdng. https://reviews.llvm.org/D138396 Files: clang/lib/Headers/__clang_hip_math.h clang/test/Headers/__cl

[clang] 7994e51 - Revert "Revert "[clang-tblgen][NFC] renames Diagnostic.Text to Diagnostic.Summary""

Author: Christopher Di Bella Date: 2022-11-21T04:55:19Z New Revision: 7994e5144aa52530fca9af0d81ca7134368034fe URL: https://github.com/llvm/llvm-project/commit/7994e5144aa52530fca9af0d81ca7134368034fe DIFF: https://github.com/llvm/llvm-project/commit/7994e5144aa52530fca9af0d81ca7134368034fe.dif

[PATCH] D138105: [PowerPC] Support test data class intrinsic of 128-bit float

shchenz added a comment. The error message needs to be updated too: def err_ppc_invalid_test_data_class_type : Error< "expected a 'float' or 'double' for the first argument">; And can we add a test case for ibm float128 in the clang? Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D138399: HIP: Directly call isinf builtins

arsenm created this revision. arsenm added reviewers: b-sumner, JonChesterfield, yaxunl. Herald added a project: All. arsenm requested review of this revision. Herald added a subscriber: wdng. https://reviews.llvm.org/D138399 Files: clang/lib/Headers/__clang_hip_math.h clang/test/Headers/__cl

[PATCH] D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin

WowbaggersLiquidLunch added a comment. Hi, this seems to be causing some problems when generating Xcode project. When I try to generate the Xcode project with the following command: cmake -G "Xcode" -DCMAKE_BUILD_TYPE=Debug -DLLVM_TARGETS_TO_BUILD="X86" -DLLVM_ENABLE_PROJECTS="clang" -DLLVM_O

[PATCH] D136906: [Clang][LoongArch] Implement __builtin_loongarch_dbar builtin

gonglingqin added a comment. In D136906#3940289 , @WowbaggersLiquidLunch wrote: > Hi, this seems to be causing some problems when generating Xcode project. > > When I try to generate the Xcode project with the following command: > > cmake -G "Xcode" -D

[PATCH] D138402: [clang-format] Correctly count a tab's width in a comment

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: owenpan, MyDeveloperDay, rymiel. HazardyKnusperkeks added a project: clang-format. Herald added a project: All. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscribe