[PATCH] D138183: [Driver] move FreeBSD header search path management to the driver

mhjacobson updated this revision to Diff 476017. mhjacobson added a comment. Run clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138183/new/ https://reviews.llvm.org/D138183 Files: clang/lib/Driver/ToolChains/FreeBSD.cpp clang/lib/

[PATCH] D138183: [Driver] move FreeBSD header search path management to the driver

mhjacobson updated this revision to Diff 476018. mhjacobson added a comment. Clarify comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138183/new/ https://reviews.llvm.org/D138183 Files: clang/lib/Driver/ToolChains/FreeBSD.cpp clang/lib/D

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

owenpan added a comment. @gedare thanks for changing `EXPECT_EQ` to `verifyFormat`, but IMO we should do that in another patch so that it would be easier (at least for me) to review the new tests and to make sure no existing tests have been changed by accident. Comment at: cl

[PATCH] D138183: [Driver] move FreeBSD header search path management to the driver

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/FreeBSD.cpp:442 + + addExternCSystemInclude(DriverArgs, CC1Args, + concat(D.SysRoot, "/usr/include")); I think Fuchsia way of checking `if (!D.SysRoot.empty()) {` bef

[PATCH] D138179: MIPS: fix build from IR files, nan2008 and FpAbi

MaskRay added a comment. test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138179/new/ https://reviews.llvm.org/D138179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D138183: [Driver] move FreeBSD header search path management to the driver

mhjacobson added inline comments. Comment at: clang/lib/Driver/ToolChains/FreeBSD.cpp:442 + + addExternCSystemInclude(DriverArgs, CC1Args, + concat(D.SysRoot, "/usr/include")); MaskRay wrote: > I think Fuchsia way of checking `if (!D.Sys

<    1   2   3