[clang] 0b94525 - Revert "[libclang] Expose completion result kind in `CXCompletionResult`"

Author: Muhammad Omair Javaid Date: 2022-11-14T12:27:11+04:00 New Revision: 0b94525ddcfc069941a20abcbe447e659ffb6e33 URL: https://github.com/llvm/llvm-project/commit/0b94525ddcfc069941a20abcbe447e659ffb6e33 DIFF: https://github.com/llvm/llvm-project/commit/0b94525ddcfc069941a20abcbe447e659ffb6e

[PATCH] D136844: [libclang] Expose completion result kind in `CXCompletionResult`

omjavaid reopened this revision. omjavaid added a comment. This revision is now accepted and ready to land. Hi this broke https://lab.llvm.org/buildbot/#/builders/245/builds/761 I have reverted the change to make the buildbot green. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D137040: [clangd] Add heuristic for dropping snippet when completing member function pointer

tom-anders added a comment. In D137040#3924115 , @nridge wrote: > Thanks! Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137040/new/ https://reviews.llvm.org/D137040 ___

[clang-tools-extra] dd46a08 - Move the isSelfContainedHeader function from clangd to libtooling.

Author: Haojian Wu Date: 2022-11-14T09:40:45+01:00 New Revision: dd46a08008f76d6ac9fcc6a9e748b113bea3c758 URL: https://github.com/llvm/llvm-project/commit/dd46a08008f76d6ac9fcc6a9e748b113bea3c758 DIFF: https://github.com/llvm/llvm-project/commit/dd46a08008f76d6ac9fcc6a9e748b113bea3c758.diff LO

[PATCH] D137697: Move the isSelfContained function from clangd to libtooling.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdd46a08008f7: Move the isSelfContainedHeader function from clangd to libtooling. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D137698: [include-cleaner] Add self-contained file support for PragmaIncludes.

hokein updated this revision to Diff 475067. hokein marked 3 inline comments as done. hokein added a comment. rebase and address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137698/new/ https://reviews.llvm.org/D137698 Files: clang-to

[PATCH] D137677: [include-cleaner] add macro symbols and implicit refs to HTML report

sammccall updated this revision to Diff 475068. sammccall added a comment. format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137677/new/ https://reviews.llvm.org/D137677 Files: clang-tools-extra/include-cleaner/include/clang-include-cleaner/A

[PATCH] D137677: [include-cleaner] add macro symbols and implicit refs to HTML report

sammccall added a comment. Updated the demo link, PTAL (significant changes since last review) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137677/new/ https://reviews.llvm.org/D137677 ___ cfe-commits m

[PATCH] D137768: [opt][clang] Enable using -module-summary with -S / -emit-llvm

alexander-shaposhnikov updated this revision to Diff 475082. alexander-shaposhnikov added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137768/new/ https://reviews.llvm.org/D137768 Files: clang/lib/CodeGen/BackendUtil

[PATCH] D137927: Adapt unittests for isSelfContainedHeader to API

Hahnfeld created this revision. Hahnfeld added reviewers: hokein, kadircet. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The function now takes a FileEntry instead of a FileID. Repository: rG LLV

[PATCH] D137697: Move the isSelfContained function from clangd to libtooling.

Hahnfeld added a comment. @hokein it seems the unit test wasn't updated for the last-minute API change, which breaks `check-all` for me. I've posted https://reviews.llvm.org/D137927, could you take a look if that change is correct? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[clang] 5c4ae8a - Update the wrong isSelfContainedHeader API usage in the test.

Author: Haojian Wu Date: 2022-11-14T11:10:55+01:00 New Revision: 5c4ae8a86a865e622e2c663666c0c139334b5da2 URL: https://github.com/llvm/llvm-project/commit/5c4ae8a86a865e622e2c663666c0c139334b5da2 DIFF: https://github.com/llvm/llvm-project/commit/5c4ae8a86a865e622e2c663666c0c139334b5da2.diff LO

[PATCH] D137697: Move the isSelfContained function from clangd to libtooling.

hokein added a comment. In D137697#3924305 , @Hahnfeld wrote: > @hokein it seems the unit test wasn't updated for the last-minute API change, > which breaks `check-all` for me. I've posted > https://reviews.llvm.org/D137927, could you take a look if tha

[PATCH] D137927: Adapt unittests for isSelfContainedHeader to API

Hahnfeld abandoned this revision. Hahnfeld added a comment. Fixed in https://reviews.llvm.org/rG5c4ae8a86a865e622e2c663666c0c139334b5da2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137927/new/ https://reviews.llvm.org/D137927 ___

[PATCH] D137697: Move the isSelfContained function from clangd to libtooling.

Hahnfeld added a comment. No worries, thanks for fixing so quickly! I just happened to pull in the wrong moment... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137697/new/ https://reviews.llvm.org/D137697

[PATCH] D137787: [CodeGen] Relax assertion on generating destructor call

Hahnfeld added a comment. > Sorry, I don't understand well. Could you rewrite the reproducer in the style > I wrote? And in what cases it works fine? Okay, let me try to restate: I can reproduce the problem in ROOT/Cling which is an *interpreter* built on top of LLVM and CLang. The moment I put

[PATCH] D137677: [include-cleaner] add macro symbols and implicit refs to HTML report

hokein added a comment. The new UI looks good. Comment at: clang-tools-extra/include-cleaner/lib/Analysis.cpp:24 UsedSymbolCB CB) { + // This is duplicated in HTMLReport.cpp, changes should be mirrored there. tooling::stdlib::Recognizer Recognizer; --

[PATCH] D137851: [OPENMP]Initial support for at clause

ABataev added inline comments. Comment at: clang/include/clang/Parse/Parser.h:3302 + void ParseOpenMPClauses(OpenMPDirectiveKind DKind, + SmallVector *Clauses, + SourceLocation Loc); `SmallVectorImpl &` ===

[PATCH] D137714: Do not merge traps in functions annotated optnone

hnrklssn updated this revision to Diff 475104. hnrklssn marked an inline comment as done. hnrklssn added a comment. Add explicit labels to FileCheck checks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137714/new/ https://reviews.llvm.org/D137714

[PATCH] D137917: [cmake] Fix _GNU_SOURCE being added unconditionally

Trass3r added inline comments. Comment at: clang/CMakeLists.txt:417 -add_definitions( -D_GNU_SOURCE ) - Found when building with clang-cl. It's already handled correctly in the llvm config file. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

Re: How can Autoconf help with the transition to stricter compilation defaults?

On Sat, Nov 12, 2022 at 7:43 PM Paul Eggert wrote: > > On 2022-11-11 07:11, Aaron Ballman wrote: > > We believe the runtime behavior is sufficiently dangerous to > > warrant a conservative view that any call to a function will be a call > > that gets executed at runtime, hence a definitive signatu

[PATCH] D137920: [nfc] Mark classes final as reported by -Wsuggest-final-types

Trass3r updated this revision to Diff 475114. Trass3r added a comment. fix build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137920/new/ https://reviews.llvm.org/D137920 Files: clang/include/clang/AST/Decl.h clang/include/clang/AST/DeclCXX.h

[PATCH] D137787: [CodeGen] Relax assertion on generating destructor call

ChuanqiXu added a comment. In D137787#3924341 , @Hahnfeld wrote: >> Sorry, I don't understand well. Could you rewrite the reproducer in the >> style I wrote? And in what cases it works fine? > > Okay, let me try to restate: I can reproduce the problem in

[PATCH] D137939: [CGObjC] Open cleanup scope before SaveAndRestore CurrentFuncletPad and push CatchRetScope early

sgraenitz created this revision. sgraenitz added reviewers: theraven, rnk. Herald added a project: All. sgraenitz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Pushing the `CatchRetScope` early causes cleanups for catch parameters to be

[PATCH] D137381: [clang][compiler-rt] Exception escape out of an non-unwinding function is an undefined behaviour

lebedev.ri added subscribers: vitalybuka, glider, rsmith. lebedev.ri added a comment. Can someone from @Sanitizers please comment? :) @vitalybuka ? @glider ? @rsmith ? In D137381#3923911 , @MaskRay wrote: > I think improving diagnostic is useful but `-

[PATCH] D137720: Migrate getOrCreateInternalVariable from Clang to OMPIRBuilder.

TIFitis updated this revision to Diff 475125. TIFitis marked 2 inline comments as done. TIFitis added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137720/new/ https://reviews.llvm.org/D137720 Files: clang/lib/Code

[PATCH] D137720: Migrate getOrCreateInternalVariable from Clang to OMPIRBuilder.

TIFitis added inline comments. Comment at: llvm/include/llvm/Frontend/OpenMP/OMPIRBuilder.h:1729 + const llvm::StringRef &Name, + unsigned AddressSpace = 0); }; jdoerfert w

[PATCH] D137939: [CGObjC] Open cleanup scope before SaveAndRestore CurrentFuncletPad and push CatchRetScope early

sgraenitz added a comment. The approach follows the C++ try/catch implementation in clang/lib/CodeGen/CGException.cpp . I think this is the correct solution for what I attempted to fix with D134866

[PATCH] D137787: [CodeGen] Relax assertion on generating destructor call

Hahnfeld added a comment. Yes, I fully agree that having a test is desirable, I just didn't manage so far. Maybe it takes somebody with deep AST knowledge to explain under what circumstances `DtorDecl->getParent()` is *not* the canonical `Decl`. Maybe this could help crafting a test case, even

[PATCH] D137942: [CGObjC] Add run line for release mode in test arc-exceptions-seh.mm (NFC)

sgraenitz created this revision. Herald added a project: All. sgraenitz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In release mode the updated `arc-exceptions-seh.mm` test fails and needs `-enable-objc-arc-opts=false` to skip ObjC ARC

[PATCH] D137943: [clangd] Mark "override" and "final" as keywords

ckandeler created this revision. ckandeler added a reviewer: sammccall. Herald added subscribers: kadircet, arphaman. Herald added a project: All. ckandeler requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra.

[clang] 5c67cf0 - Add clang_CXXMethod_isMoveAssignmentOperator to libclang

Author: Luca Di Sera Date: 2022-11-14T15:21:36+01:00 New Revision: 5c67cf0a7fdc00c9b9c55578b770e768f5618bed URL: https://github.com/llvm/llvm-project/commit/5c67cf0a7fdc00c9b9c55578b770e768f5618bed DIFF: https://github.com/llvm/llvm-project/commit/5c67cf0a7fdc00c9b9c55578b770e768f5618bed.diff

[PATCH] D137246: Add clang_CXXMethod_isMoveAssignmentOperator to libclang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5c67cf0a7fdc: Add clang_CXXMethod_isMoveAssignmentOperator to libclang (authored by diseraluca). Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D137246: Add clang_CXXMethod_isMoveAssignmentOperator to libclang

diseraluca added a comment. In D137246#3919795 , @aaron.ballman wrote: > In D137246#3911881 , @diseraluca > wrote: > >> I finally had some time to look into the pre-merge failure. I couldn't >> replicate it on

[PATCH] D137917: [cmake] Fix _GNU_SOURCE being added unconditionally

tstellar added a comment. I think this looks OK. What kind of errors were you seeing before this fix? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137917/new/ https://reviews.llvm.org/D137917 ___ cfe-c

[PATCH] D137944: [ObjC][ARC] Teach the OptimizeSequences step of ObjCARCOpts about WinEH funclet tokens

sgraenitz created this revision. sgraenitz added reviewers: gottesmm, rjmccall, rnk. Herald added a subscriber: hiraditya. Herald added a project: All. sgraenitz requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. When optimizing retain-re

[PATCH] D137944: [ObjC][ARC] Teach the OptimizeSequences step of ObjCARCOpts about WinEH funclet tokens

sgraenitz added a comment. There was a similar effort for CleanupPads in the past: https://reviews.llvm.org/rG8b342680bf62722e5099074e8bd23491c71d92b3 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137944/new/ https://reviews.llvm.org/D137944

[PATCH] D137944: [ObjC][ARC] Teach the OptimizeSequences step of ObjCARCOpts about WinEH funclet tokens

sgraenitz added a comment. There doesn't seem to be a 1-to-1 relationship between deleted and inserted retain/release calls and thus we don't attempt to preserve bundle operands in general. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137944/new/

[PATCH] D137917: [cmake] Fix _GNU_SOURCE being added unconditionally

Trass3r added a comment. I only came across it when testing a PCH build. https://github.com/Trass3r/llvm-project/actions/runs/3423679621/jobs/5702548183 Warning: (1,9): warning: definition of macro '_GNU_SOURCE' does not match definition in precompiled header [-Wclang-cl-pch] It was set for c

[PATCH] D137787: [CodeGen] Relax assertion on generating destructor call

v.g.vassilev added a comment. In D137787#3924727 , @Hahnfeld wrote: > Yes, I fully agree that having a test is desirable, I just didn't manage so > far. Maybe it takes somebody with deep AST knowledge to explain under what > circumstances `DtorDecl->get

[PATCH] D137787: [CodeGen] Relax assertion on generating destructor call

v.g.vassilev added a reviewer: rsmith. v.g.vassilev added a subscriber: rsmith. v.g.vassilev added a comment. Usually @rsmith has something up in the sleeve in these situations ;) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137787/new/ https://re

[PATCH] D137948: [clang][dataflow] Add widening API and implement it for built-in boolean model.

ymandel created this revision. ymandel added reviewers: xazax.hun, gribozavr2, sgatev. Herald added subscribers: martong, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. - Adds API support for widening o

[PATCH] D137768: [opt][clang] Enable using -module-summary /-flto=thin with -S / -emit-llvm

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm, thanks! One small suggestion below. Comment at: clang/lib/CodeGen/BackendUtil.cpp:988 if (CodeGenOpts.PrepareForThinLTO && !CodeGenOpts.DisableLLVMPasses) {

[PATCH] D137787: [CodeGen] Relax assertion on generating destructor call

Hahnfeld added a comment. In D137787#3924857 , @v.g.vassilev wrote: > - Is the failure also not reproducible with clang9 (on which is based cling)? > - Is the failure also not reproducible with clang9 built on top of the > downstream patches? The failu

[PATCH] D137874: clang/AMDGPU: Use Support's wrapper around getenv

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137874/new/ https://reviews.llvm.org/D137874 ___ cfe-commits mailing list cfe-

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

gedare updated this revision to Diff 475164. gedare added a comment. - fixup: replace EXPECT_EQ with verifyFormat - fixup: port other EXPECT_EQ to verifyFormat Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137762/new/ https://reviews.llvm.org/D1377

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

gedare updated this revision to Diff 475165. gedare added a comment. - fixup: unit test formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137762/new/ https://reviews.llvm.org/D137762 Files: clang/lib/Format/ContinuationIndenter.cpp clan

[PATCH] D137917: [cmake] Fix _GNU_SOURCE being added unconditionally

Trass3r added a comment. Thanks could you also commit it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137917/new/ https://reviews.llvm.org/D137917 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D137269: [Clang][AArch64][Darwin] Enable GlobalISel by default for Darwin ARM64 platforms.

thakis added a comment. Heads-up: This very visibly broke web page rendering in Chromium (but only when using LTO) (https://crbug.com/1383873) . Not clear yet if this exposed UB on our end or not. One thing that we did notice is that adding `-fno-global-isel` to cflags and ldflags only had an

[clang] 780c539 - [RISCV] Implement assembler support for XVentanaCondOps

Author: Philip Reames Date: 2022-11-14T09:01:54-08:00 New Revision: 780c53984449e14f50e2418de993bbf560f54bfc URL: https://github.com/llvm/llvm-project/commit/780c53984449e14f50e2418de993bbf560f54bfc DIFF: https://github.com/llvm/llvm-project/commit/780c53984449e14f50e2418de993bbf560f54bfc.diff

[PATCH] D137350: [RISCV] Implement assembler support for XVentanaCondOps

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG780c53984449: [RISCV] Implement assembler support for XVentanaCondOps (authored by reames). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D137917: [cmake] Fix _GNU_SOURCE being added unconditionally

tstellar added a comment. In D137917#3925161 , @Trass3r wrote: > Thanks could you also commit it? Sure, what name and email should I use for you when committing? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D124823: [OpenMPIRBuilder] Introduce OMPRegionInfo managing the stack of OpenMP region constructs.

Meinersbur added a comment. Herald added a reviewer: nicolasvasilache. Herald added a reviewer: dcaballe. Herald added subscribers: Moerafaat, zero9178. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124823/new/ https://reviews.llvm.org/D124823

[clang] 87f652d - Migrate getOrCreateInternalVariable from Clang to OMPIRBuilder.

Author: Akash Banerjee Date: 2022-11-14T17:18:10Z New Revision: 87f652d31f6dcb493e4e3290d694e52c092cecb1 URL: https://github.com/llvm/llvm-project/commit/87f652d31f6dcb493e4e3290d694e52c092cecb1 DIFF: https://github.com/llvm/llvm-project/commit/87f652d31f6dcb493e4e3290d694e52c092cecb1.diff LOG

[PATCH] D137720: Migrate getOrCreateInternalVariable from Clang to OMPIRBuilder.

This revision was automatically updated to reflect the committed changes. Closed by commit rG87f652d31f6d: Migrate getOrCreateInternalVariable from Clang to OMPIRBuilder. (authored by TIFitis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137720/new

[PATCH] D137649: [Clang][OpenMP] Warn and discard write to host for const variable

jhuber6 accepted this revision. jhuber6 added a comment. This revision is now accepted and ready to land. LGTM, others feel free to comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137649/new/ https://reviews.llvm.org/D137649 ___

[PATCH] D137851: [OPENMP]Initial support for at clause

jyu2 updated this revision to Diff 475177. jyu2 added a comment. Thanks Alexey! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137851/new/ https://reviews.llvm.org/D137851 Files: clang/include/clang/AST/OpenMPClause.h clang/include/clang/AST/Re

[PATCH] D137851: [OPENMP]Initial support for at clause

jyu2 added inline comments. Comment at: clang/include/clang/Parse/Parser.h:3302 + void ParseOpenMPClauses(OpenMPDirectiveKind DKind, + SmallVector *Clauses, + SourceLocation Loc); ABataev wrote: > `SmallVectorImp

[clang] cbcf123 - [LegacyPM] Remove cl::opts controlling optimization pass manager passes

Author: Arthur Eubanks Date: 2022-11-14T09:38:17-08:00 New Revision: cbcf123af293ee56876cce16dac83c3008478dae URL: https://github.com/llvm/llvm-project/commit/cbcf123af293ee56876cce16dac83c3008478dae DIFF: https://github.com/llvm/llvm-project/commit/cbcf123af293ee56876cce16dac83c3008478dae.diff

[PATCH] D137917: [cmake] Fix _GNU_SOURCE being added unconditionally

Trass3r added a comment. `Andreas Hollandt ` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137917/new/ https://reviews.llvm.org/D137917 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D137851: [OPENMP]Initial support for at clause

ABataev added inline comments. Comment at: clang/include/clang/Sema/Sema.h:11293 + SourceLocation EndLoc, + bool InExContext = true); /// Called on well-formed '\#pragma omp barrier'.

[PATCH] D128457: [clangd] Add new IncludeType to IncludeHeaderWithReferences

dgoldman updated this revision to Diff 475180. dgoldman added a comment. Run clang format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128457/new/ https://reviews.llvm.org/D128457 Files: clang-tools-extra/clangd/SourceCode.cpp clang-tools-ext

[PATCH] D137269: [Clang][AArch64][Darwin] Enable GlobalISel by default for Darwin ARM64 platforms.

thakis added a comment. > One thing that we did notice is that adding `-fno-global-isel` to cflags and > ldflags only had an effect when manually blowing away the thinlto cache. > Maybe whatever decides when to invalidate the thinlto cache needs to learn to > invalidate it when the `-global-ise

[PATCH] D137960: [Lexer] Speedup LexTokenInternal

serge-sans-paille created this revision. serge-sans-paille added reviewers: lattner, nikic. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Only reset "NeedsCleaning" flag in case of re-entrant

[PATCH] D137960: [Lexer] Speedup LexTokenInternal

serge-sans-paille added a comment. Compile time tracker record : https://llvm-compile-time-tracker.com/compare.php?from=f71d32a0eea47b3d2bb43d6be15cf09d47ef6971&to=b4df7d2a01aacd29ae539b04e72b3667e2362aa1&stat=instructions:u The cost of preprocessing is hidden by the optimization time, but -O0 gi

[PATCH] D137885: [modules] Support zstd in .pcm file

dblaikie added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:1456 + const llvm::compression::Format F = + Blob.size() >= 2 && memcmp(Blob.data(), "\x1f\x8b", 2) == 0 + ? llvm::compression::Format::Zlib Worth a comme

[PATCH] D137375: [AIX][pg] Add Correct Search Paths for Profiled Libraries

francii updated this revision to Diff 475187. francii added a comment. Herald added a subscriber: ormris. Removed check for sysroot, it is not needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137375/new/ https://reviews.llvm.org/D137375 Files

[PATCH] D137962: [clang][Tooling] Make the filename behaviour consistent

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang. Dotdots were removed only when converting a relative path to absolute

[PATCH] D137375: [AIX][pg] Add Correct Search Paths for Profiled Libraries

francii updated this revision to Diff 475194. francii added a comment. Fix mixup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137375/new/ https://reviews.llvm.org/D137375 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/test/Driver/aix-ld.c

[PATCH] D137753: [Clang][GNU][AIX][p]Enable -p Functionality

francii updated this revision to Diff 475196. francii added a comment. Add profiled libraries check AIX Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137753/new/ https://reviews.llvm.org/D137753 Files: clang/include/clang/Basic/CodeGenOptions.de

[PATCH] D137375: [AIX][pg] Add Correct Search Paths for Profiled Libraries

francii updated this revision to Diff 475197. francii added a comment. Remove check for -p Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137375/new/ https://reviews.llvm.org/D137375 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/test/Driver/

Re: How can Autoconf help with the transition to stricter compilation defaults?

On 2022-11-14 04:41, Aaron Ballman wrote: it's generally a problem when autoconf relies on invalid language constructs Autoconf *must* rely on invalid language constructs, if only to test whether the language constructs work. And Clang therefore must be careful about how it diagnoses invalid

[PATCH] D137375: [AIX][pg] Add Correct Search Paths for Profiled Libraries

francii updated this revision to Diff 475203. francii added a comment. Add sysroot to test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137375/new/ https://reviews.llvm.org/D137375 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/test/D

Re: How can Autoconf help with the transition to stricter compilation defaults?

* Paul Eggert: > On 2022-11-14 04:41, Aaron Ballman wrote: >> it's generally a problem when autoconf relies on invalid >> language constructs > > Autoconf *must* rely on invalid language constructs, if only to test > whether the language constructs work. And Clang therefore must be > careful abou

Re: How can Autoconf help with the transition to stricter compilation defaults?

On Mon, Nov 14, 2022 at 1:14 PM Paul Eggert wrote: > > On 2022-11-14 04:41, Aaron Ballman wrote: > > it's generally a problem when autoconf relies on invalid > > language constructs > > Autoconf *must* rely on invalid language constructs, if only to test > whether the language constructs work. And

[PATCH] D133036: [InstCombine] Treat passing undef to noundef params as UB

aeubanks added a comment. I'll hold off on submitting this until that bug is figured out Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133036/new/ https://reviews.llvm.org/D133036 ___ cfe-commits mailing

[PATCH] D137968: [clang-tidy] Ignore overriden methods in `readability-const-return-type`.

ymandel created this revision. ymandel added reviewers: njames93, thomasetter. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang-tools-extra. Overrides are constrained by the signature of the ov

[clang] 840a793 - clang/AMDGPU: Use Support's wrapper around getenv

Author: Matt Arsenault Date: 2022-11-14T11:07:31-08:00 New Revision: 840a793375fec763c2b2781b82b764325635cc7a URL: https://github.com/llvm/llvm-project/commit/840a793375fec763c2b2781b82b764325635cc7a DIFF: https://github.com/llvm/llvm-project/commit/840a793375fec763c2b2781b82b764325635cc7a.diff

[PATCH] D137874: clang/AMDGPU: Use Support's wrapper around getenv

arsenm closed this revision. arsenm added a comment. 840a793375fec763c2b2781b82b764325635cc7a CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137874/new/ https://reviews.llvm.org/D137874 __

[PATCH] D137738: [clang-tidy] Suppress google-objc-avoid-throwing-exception in system macros 🫢

stephanemoore updated this revision to Diff 475222. stephanemoore added a subscriber: Eugene.Zelenko. stephanemoore added a comment. Included namespace comment linter fixes from D137740 as advised by @Eugene.Zelenko, Repository: rG LLVM Github Monorepo CHAN

[PATCH] D137968: [clang-tidy] Ignore overriden methods in `readability-const-return-type`.

ymandel updated this revision to Diff 475224. ymandel added a comment. Add test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137968/new/ https://reviews.llvm.org/D137968 Files: clang-tools-extra/clang-tidy/readability/ConstReturnTypeCheck.

[PATCH] D137851: [OPENMP]Initial support for at clause

jyu2 updated this revision to Diff 475225. jyu2 added a comment. Thanks Alexey! Address Alexey comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137851/new/ https://reviews.llvm.org/D137851 Files: clang/include/clang/AST/OpenMPClause.h

[PATCH] D137851: [OPENMP]Initial support for at clause

jyu2 added inline comments. Comment at: clang/include/clang/Sema/Sema.h:11293 + SourceLocation EndLoc, + bool InExContext = true); /// Called on well-formed '\#pragma omp barrier'. ABa

[PATCH] D137972: [clang-tidy] Optionally ignore findings in macros in `readability-const-return-type`.

ymandel created this revision. ymandel added reviewers: njames93, thomasetter. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang-tools-extra. Adds support for options-controlled configuration of

[PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

zequanwu added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137217/new/ https://reviews.llvm.org/D137217 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D137851: [OPENMP]Initial support for at clause

jdoerfert added a comment. Drive by: Please add commit messages to non trivial changes to explaining what's going on. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137851/new/ https://reviews.llvm.org/D137851 _

[PATCH] D137872: Try to implement lambdas with inalloca parameters by forwarding without use of inallocas.

efriedma added a comment. I'm not quite sure I understand what's happening here. Does this actually avoid generating two copies of the function body if both the call operator and the conversion are used? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D137968: [clang-tidy] Ignore overriden methods in `readability-const-return-type`.

njames93 accepted this revision. njames93 added a comment. Lg, but can you address that one nit before landing Comment at: clang-tools-extra/docs/ReleaseNotes.rst:169 +- Change the behavior of :doc:`readability-const-return-type + ` to not Can this be moved

[PATCH] D137851: [OPENMP]Initial support for at clause

jyu2 added a comment. In D137851#3925661 , @jdoerfert wrote: > Drive by: Please add commit messages to non trivial changes to explaining > what's going on. Thanks. Added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D137753: [Clang][GNU][AIX][p]Enable -p Functionality

francii updated this revision to Diff 475242. francii added a comment. Add sysroot check to aix-ld.c test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137753/new/ https://reviews.llvm.org/D137753 Files: clang/include/clang/Basic/CodeGenOp

[PATCH] D137917: [cmake] Fix _GNU_SOURCE being added unconditionally

This revision was automatically updated to reflect the committed changes. Closed by commit rG8da41fe69622: [cmake] Fix _GNU_SOURCE being added unconditionally (authored by Trass3r, committed by tstellar). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[clang] 8da41fe - [cmake] Fix _GNU_SOURCE being added unconditionally

Author: Andreas Hollandt Date: 2022-11-14T12:28:21-08:00 New Revision: 8da41fe69622f35e0a15b5a1754cd670e6057938 URL: https://github.com/llvm/llvm-project/commit/8da41fe69622f35e0a15b5a1754cd670e6057938 DIFF: https://github.com/llvm/llvm-project/commit/8da41fe69622f35e0a15b5a1754cd670e6057938.di

[PATCH] D137562: [clang][Interp] Start supporting virtual base classes

shafik added inline comments. Comment at: clang/lib/AST/Interp/Descriptor.cpp:126 + auto CtorSub = [=](unsigned SubOff, Descriptor *F, bool IsBase, + bool Recurse = true) { auto *Desc = reinterpret_cast(Ptr + SubOff) - 1; To recurse or n

[PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

tejohnson added a comment. The naming convention used here for COFF is actually very similar to what is done for other ThinLTO save-temps output files, which are placed at the input module locations. We may want to just do this across the board. @MaskRay wdyt? A few other questions/comments bel

[PATCH] D137823: [clang-format][NFC] Moved configuration parsing tests in own file

HazardyKnusperkeks marked 3 inline comments as done. HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/ConfigParseTest.cpp:1006 + +TEST(FormatStyle, GetStyleWithEmptyFileName) { + llvm::vfs::InMemoryFileSystem FS; owenpan wrote: > Othe

[PATCH] D137762: [clang-format] avoid breaking )( with BlockIndent

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:7215 Style.AlignAfterOpenBracket = FormatStyle::BAS_DontAlign; - EXPECT_EQ(StringRef("functionCall(paramA, paramB,\n" - "paramC);\n" - "vo

[PATCH] D137768: [opt][clang] Enable using -module-summary /-flto=thin with -S / -emit-llvm

alexander-shaposhnikov added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:988 if (CodeGenOpts.PrepareForThinLTO && !CodeGenOpts.DisableLLVMPasses) { if (!CodeGenOpts.ThinLinkBitcodeFile.empty()) { ThinLinkOS = openOutputFile(CodeGenOpts.Thin

[PATCH] D137563: [clang][Interp] Check declarations for constexpr-ness in Load() instructions

shafik added inline comments. Comment at: clang/lib/AST/Interp/Interp.cpp:101 +static bool CheckConstexpr(InterpState &S, CodePtr OpPC, const Pointer &Ptr) { + if (!S.inConstantContext()) Is `CheckConstexpr` descriptive enough? Would something like `CheckLoadI

[PATCH] D137865: [clang-format][NFC] Improve documentation on ReflowComments

HazardyKnusperkeks updated this revision to Diff 475253. HazardyKnusperkeks marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137865/new/ https://reviews.llvm.org/D137865 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h

[PATCH] D137865: [clang-format][NFC] Improve documentation on ReflowComments

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:3073-3076 + /// If ``true``, clang-format will attempt to re-flow comments. That is it + /// will touch a comment and *reflow* long comments into new lines, trying to + /// obey the ``Col

  1   2   >