[PATCH] D136936: [clang][Interp] Handle undefined functions better

tbaeder updated this revision to Diff 472853. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136936/new/ https://reviews.llvm.org/D136936 Files: clang/lib/AST/Interp/ByteCodeEmitter.cpp clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/lib/AST/Interp/Context.cpp clang/lib/AST/Interp/

[PATCH] D137240: [clang][Interp] Support alignof()

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:444 +// alignment of the referenced type. +if (const ReferenceType *Ref = ArgType->getAs()) + ArgType = Ref->getPointeeType(); aaron.ballman wrote: > You're missi

[PATCH] D137240: [clang][Interp] Support alignof()

tbaeder updated this revision to Diff 472855. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137240/new/ https://reviews.llvm.org/D137240 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/class-layout.cpp Index: clang/test/AST/Interp/class-layout.cpp =

[PATCH] D137082: [clang][Interp] Fix dereferencing arrays with no offset applied

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/Interp.h:966-967 return false; - S.Stk.push(Ptr.deref()); + // When getting the first value of an array, we need to offset to the + // first element. + if (Ptr.inArray() && Ptr.isRoot()) aar

[PATCH] D137316: [Clang][LoongArch] Implement __builtin_loongarch_crc_w_d_w builtin and add diagnostics

gonglingqin created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. gonglingqin requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch adds support to prevent __builtin_loongarch_crc_w

[clang] fdab9f1 - [Clang] Check for response file existence prior to check for recursion

Author: Serge Pavlov Date: 2022-11-03T14:49:58+07:00 New Revision: fdab9f1203eea48a7b8e4c55c7ceafc54653797c URL: https://github.com/llvm/llvm-project/commit/fdab9f1203eea48a7b8e4c55c7ceafc54653797c DIFF: https://github.com/llvm/llvm-project/commit/fdab9f1203eea48a7b8e4c55c7ceafc54653797c.diff

[PATCH] D137317: [X86][CET] Add Diags for targets pre to i686

pengfei created this revision. pengfei added a reviewer: nickdesaulniers. Herald added a project: All. pengfei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I intended to not adding test case since it is NFC to most modern X86 targets. F

[clang] 8cb9e3c - [AArch64] Install arm_neon_sve_bridge.h

Author: Peter Waller Date: 2022-11-03T07:55:57Z New Revision: 8cb9e3c3ce1e7e1658921f90420b68ca16bb98fc URL: https://github.com/llvm/llvm-project/commit/8cb9e3c3ce1e7e1658921f90420b68ca16bb98fc DIFF: https://github.com/llvm/llvm-project/commit/8cb9e3c3ce1e7e1658921f90420b68ca16bb98fc.diff LOG:

[PATCH] D137239: [AArch64] Install arm_neon_sve_bridge.h

This revision was automatically updated to reflect the committed changes. Closed by commit rG8cb9e3c3ce1e: [AArch64] Install arm_neon_sve_bridge.h (authored by peterwaller-arm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137239/new/ https://revie

[PATCH] D136796: [llvm-objdump][Offload] Use common offload extraction method

jhenderson added a comment. In D136796#3903393 , @jhuber6 wrote: > Is this good to land now? The LLVM community practice is to wait a week between pings unless there's something urgent (and if something is urgent, please say so). Aside from the clang b

[PATCH] D137153: [WIP][X86] Support -march=sierraforest, grandridge, graniterapids.

FreddyYe added inline comments. Comment at: llvm/include/llvm/Support/X86TargetParser.def:94 +X86_CPU_SUBTYPE(AMDFAM19H_ZNVER4,"znver4") +X86_CPU_SUBTYPE(INTEL_COREI7_SIERRAFOREST, "sierraforest") +X86_CPU_SUBTYPE(INTEL_COREI7_GRANITERAPIDS, "graniterapids") --

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

njames93 added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyOnLastUseCheck.cpp:7 +// +// Author: Fabian Keßler "Febbe" +//===--===// Author ditto.

[PATCH] D137153: [WIP][X86] Support -march=sierraforest, grandridge, graniterapids.

FreddyYe added inline comments. Comment at: llvm/include/llvm/Support/X86TargetParser.def:94 +X86_CPU_SUBTYPE(AMDFAM19H_ZNVER4,"znver4") +X86_CPU_SUBTYPE(INTEL_COREI7_SIERRAFOREST, "sierraforest") +X86_CPU_SUBTYPE(INTEL_COREI7_GRANITERAPIDS, "graniterapids") --

[clang] 4ecb2b8 - [DebugInfo][Metadata] Make AllEnumTypes holding TrackingMDNodeRef

Author: Kristina Bessonova Date: 2022-11-03T10:28:38+02:00 New Revision: 4ecb2b8ef6be69b55d46ac274f3b7a7103219f98 URL: https://github.com/llvm/llvm-project/commit/4ecb2b8ef6be69b55d46ac274f3b7a7103219f98 DIFF: https://github.com/llvm/llvm-project/commit/4ecb2b8ef6be69b55d46ac274f3b7a7103219f98.

[PATCH] D137067: [DebugInfo][Metadata] Make AllEnumTypes holding TrackingMDNodeRef

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4ecb2b8ef6be: [DebugInfo][Metadata] Make AllEnumTypes holding TrackingMDNodeRef (authored by krisb). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D137251: [clang][cuda/hip] Allow `__noinline__` lambdas

Pierre-vh updated this revision to Diff 472875. Pierre-vh marked 2 inline comments as done. Pierre-vh added a comment. Comments Not sure if the release note is in the right place though. As for the test, I did something quite targeted/minimal, hope it's fine? Repository: rG LLVM Github Monore

[PATCH] D137251: [clang][cuda/hip] Allow `__noinline__` lambdas

Pierre-vh added inline comments. Comment at: clang/lib/Parse/ParseExprCXX.cpp:1300 +ParseGNUAttributes(Attr, nullptr, &D); + } else if (Tok.is(tok::kw___noinline__)) { +IdentifierInfo *AttrName = Tok.getIdentifierInfo(); aaron.ballman wrote:

[PATCH] D137319: [include-cleaner] Add export IWYU pragma support.

hokein created this revision. hokein added reviewers: kadircet, sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang-tools-extra. - add support to PragmaIncludes to handle IWYU export/begin_exports/end_exports pragma; - implement an API t

[PATCH] D136846: [Driver] Add -fsample-profile-use-profi

HaoyuZhang updated this revision to Diff 472877. HaoyuZhang added a comment. 1. add the documentation for this driver. 2. fix a small grammer mistake in Options.td. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136846/new/ https://reviews.llvm.org/

[PATCH] D137320: [include-cleaner] Initial version for the "Location=>Header" step

hokein created this revision. hokein added reviewers: kadircet, sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang-tools-extra. This patch implements the initial version of "Location => Header" step: - define the interface; - integrate

[PATCH] D136846: [Driver] Add -fsample-profile-use-profi

HaoyuZhang added a comment. Hi @spupyrev , the using of profi algorithm is added as a user-facing flag in this patch. And I wrote the documentation in https://clang.llvm.org/docs/UsersManual.html#profile-guided-optimization. Do you have any comments about these? Hi @MaskRay , some updates have

[PATCH] D136846: [Driver] Add -fsample-profile-use-profi

HaoyuZhang added inline comments. Comment at: clang/include/clang/Driver/Options.td:1254 +HelpText<"Use profi to infer block and edge counts.">, +DocBrief<[{Profi - a flow-based profile inference algorithm is an extended + and significantly re-engineered cla

[clang] fa8aeab - [AArch64] Add support for the Cortex-A715 CPU

Author: Simi Pallipurath Date: 2022-11-03T09:28:46Z New Revision: fa8aeab606c1ca2756bf8b6a451998f20671ce52 URL: https://github.com/llvm/llvm-project/commit/fa8aeab606c1ca2756bf8b6a451998f20671ce52 DIFF: https://github.com/llvm/llvm-project/commit/fa8aeab606c1ca2756bf8b6a451998f20671ce52.diff L

[PATCH] D136957: [AArch64] Add support for the Cortex-A715 CPU

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfa8aeab606c1: [AArch64] Add support for the Cortex-A715 CPU (authored by simpal01). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137322: [clang][pdb] Don't include -fmessage-length in PDB buildinfo

thieta created this revision. thieta added reviewers: aganea, rnk, thakis, aeubanks. Herald added a subscriber: hiraditya. Herald added a project: All. thieta requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. As discussed in https://revi

[PATCH] D136474: [CodeView][clang] Add flag to disable emitting command line into CodeView

thieta added a comment. I posted https://reviews.llvm.org/D137322 to remove `-fmessage-length` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136474/new/ https://reviews.llvm.org/D136474 ___ cfe-commits m

[PATCH] D135859: [Includecleaner] Introduce RefType to ast walking

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. The current patch looks good from my side. There is a remaining discussion around the verbosity of unittests, but I think we should not be blocked by that. Comment at: clan

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

mizvekov added a comment. FYI just another data point, I haven't taken a closer look yet, but with the resugaring patches applied on top of this, we start diagnosing some deprecated uses of `std::experimental::pmr::polymorphic_allocator` on current libc++ linux CI: https://buildkite.com/llvm-p

[PATCH] D137320: [include-cleaner] Initial version for the "Location=>Header" step

kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Types.h:54 Header(tooling::stdlib::Header H) : Storage(H) {} + Header(llvm::StringRef VerbatimSpelling) : Storage(VerbatimSpelling.str()) {} can you

[PATCH] D137200: [clang] Template Specialization Resugaring - Expressions

mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 472886. Herald added a project: libc++. Herald added a subscriber: libcxx-commits. Herald added a reviewer: libc++. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1372

[PATCH] D137153: [WIP][X86] Support -march=sierraforest, grandridge, graniterapids.

RKSimon added inline comments. Comment at: llvm/lib/Target/X86/X86.td:1528 +ProcessorFeatures.TRMTuning>; +def : ProcModel<"grandridge", SLMModel, ProcessorFeatures.GRRFeatures, +ProcessorFeatures.TRMTuning>; SLMModel explicitly do

[PATCH] D135404: [clang-tidy] Add a checker for converting into C++17 variable template type traits

royjacobson abandoned this revision. royjacobson added a comment. Closing in favor of the much more mature D137302 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135404/new/ https://reviews.llvm.org/D135404

[PATCH] D137082: [clang][Interp] Fix dereferencing arrays with no offset applied

tbaeder updated this revision to Diff 472887. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137082/new/ https://reviews.llvm.org/D137082 Files: clang/lib/AST/Interp/Pointer.h clang/test/AST/Interp/arrays.cpp Index: clang/test/AST/Interp/arrays.cpp ==

[clang] 0fb763e - [flang] Add -f[no-]honor-infinities and -menable-no-infs

Author: Tom Eccles Date: 2022-11-03T10:38:09Z New Revision: 0fb763e7d0a4b8c9f5978675e7556ae50716d695 URL: https://github.com/llvm/llvm-project/commit/0fb763e7d0a4b8c9f5978675e7556ae50716d695 DIFF: https://github.com/llvm/llvm-project/commit/0fb763e7d0a4b8c9f5978675e7556ae50716d695.diff LOG: [f

[PATCH] D137072: [flang] Add -f[no-]honor-infinities and -menable-no-infs

This revision was automatically updated to reflect the committed changes. Closed by commit rG0fb763e7d0a4: [flang] Add -f[no-]honor-infinities and -menable-no-infs (authored by tblah). Herald added projects: clang, Flang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monore

[PATCH] D137313: [NFC] Remove redundant loads when has_device_addr is used.

ABataev added a comment. Whyt it is NFC? I assume it fixes the dereferencing of references, right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137313/new/ https://reviews.llvm.org/D137313 ___ cfe-commi

[PATCH] D137154: Adding nvvm_reflect clang builtin

hdelan marked an inline comment as not done. hdelan added a comment. In DPC++ for CUDA we use libclc as a wrapper around CUDA SDK's libdevice. Like libdevice we want to precompile libclc to bc for the CUDA backend without specializing for a particular arch, so that we can call different __nv fun

[PATCH] D137319: [include-cleaner] Add export IWYU pragma support.

kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Record.h:82 + llvm::DenseMap> + IWYUExportBy; what about a smallvector, instead of a denseset here? Comment at: clang-tools-extr

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

mstorsjo added a comment. In D137024#3901342 , @mgorny wrote: > Thanks! Let's hope it works this time. FYI, this broke builds of mine (https://github.com/mstorsjo/llvm-mingw/actions/runs/3382275510/jobs/5617040099), but I just need to change/add a work

[PATCH] D137327: [clang-format] Handle object instansiation in if-statements

thieta created this revision. thieta added reviewers: MyDeveloperDay, curdeius, owenpan. Herald added a project: All. thieta requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before this patch code like this: if (Class* obj{getObject()}) {

[PATCH] D137223: [clang-format] Remove special case for kw_operator when aligning decls

HazardyKnusperkeks added a comment. What Owen says. Apart from that looks good. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137223/new/ https://reviews.llvm.org/D137223 ___ cfe-commits mailing list cfe

[PATCH] D135740: [clang-format] Fix multiple preprocessor if sections parsing incorrectly

HazardyKnusperkeks added a comment. I'm lost at this topic. Is this change still needed? Is it superseded by or additional to D137052 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135740/new/ https://reviews.llv

[PATCH] D136919: [X86][RFC] Change mangle name of __bf16 from u6__bf16 to DF16b

RKSimon added a comment. What are the rules on this? Do we just handle this as an ABI breaking change and document it in the release notes - or do we need to provide any auto-upgrade path (with a warning?)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D96007: [AArch64] Enable stack clash protection for AArch64 linux in clang

samtebbs added inline comments. Herald added a subscriber: MaskRay. Herald added a project: All. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:1669-1672 +if (CodeGenOpts.StackProbeSize != 4096) + B.addAttribute("stack-probe-size", + llvm::utostr(Cod

[PATCH] D136796: [llvm-objdump][Offload] Use common offload extraction method

jhuber6 added a comment. In D136796#3904512 , @jhenderson wrote: > In D136796#3903393 , @jhuber6 wrote: > >> Is this good to land now? > > The LLVM community practice is to wait a week between pings unless there'

[clang] cdbe296 - [clang-format] Fix lambda formatting in conditional

Author: Björn Schäpers Date: 2022-11-03T13:08:14+01:00 New Revision: cdbe296853b1b3fc6415236f05770360e23f0d39 URL: https://github.com/llvm/llvm-project/commit/cdbe296853b1b3fc6415236f05770360e23f0d39 DIFF: https://github.com/llvm/llvm-project/commit/cdbe296853b1b3fc6415236f05770360e23f0d39.diff

[PATCH] D135918: [clang-format] Fix lambda formatting in conditional

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcdbe296853b1: [clang-format] Fix lambda formatting in conditional (authored by HazardyKnusperkeks). Changed prior to commit: https://reviews.llvm.

[clang] f97639c - [clang-format] Don't misannotate in CTor init list

Author: Björn Schäpers Date: 2022-11-03T13:08:48+01:00 New Revision: f97639ce13754e78e26f8d7f564830ddfe4f727c URL: https://github.com/llvm/llvm-project/commit/f97639ce13754e78e26f8d7f564830ddfe4f727c DIFF: https://github.com/llvm/llvm-project/commit/f97639ce13754e78e26f8d7f564830ddfe4f727c.diff

[PATCH] D136635: [clang-format] Don't misannotate in CTor init list

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf97639ce1375: [clang-format] Don't misannotate in CTor init list (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SI

[clang] 691774d - [clang-format][NFC] Fix document of AlignTrailingComments

Author: Yusuke Kadowaki Date: 2022-11-03T13:12:51+01:00 New Revision: 691774d4030d9b7f2941946d9a78acce92f87310 URL: https://github.com/llvm/llvm-project/commit/691774d4030d9b7f2941946d9a78acce92f87310 DIFF: https://github.com/llvm/llvm-project/commit/691774d4030d9b7f2941946d9a78acce92f87310.dif

[PATCH] D137075: [clang-format] Fix document of AlignTrailingComments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG691774d4030d: [clang-format][NFC] Fix document of AlignTrailingComments (authored by yusuke-kadowaki, committed by HazardyKnusperkeks). Repository:

[PATCH] D136919: [X86][RFC] Change mangle name of __bf16 from u6__bf16 to DF16b

pengfei added a comment. In D136919#3904925 , @RKSimon wrote: > What are the rules on this? Do we just handle this as an ABI breaking change > and document it in the release notes - or do we need to provide any > auto-upgrade path (with a warning?)? TB

[PATCH] D137172: [Clang] Implement CWG2358 Explicit capture of value

This revision was automatically updated to reflect the committed changes. Closed by commit rG742970920b7a: [Clang] Implement CWG2358 Explicit capture of value (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137172/new/ https://

[clang] 7429709 - [Clang] Implement CWG2358 Explicit capture of value

Author: Corentin Jabot Date: 2022-11-03T13:27:11+01:00 New Revision: 742970920b7a7fc2fe1cb6bca6fb04f03ab7d5d9 URL: https://github.com/llvm/llvm-project/commit/742970920b7a7fc2fe1cb6bca6fb04f03ab7d5d9 DIFF: https://github.com/llvm/llvm-project/commit/742970920b7a7fc2fe1cb6bca6fb04f03ab7d5d9.diff

[clang] b8ceb9f - [C++20] Diagnose invalid and reserved module names

Author: Aaron Ballman Date: 2022-11-03T08:29:59-04:00 New Revision: b8ceb9f4e4bdb69b5c3ea1ccf8505fa244ca0a1e URL: https://github.com/llvm/llvm-project/commit/b8ceb9f4e4bdb69b5c3ea1ccf8505fa244ca0a1e DIFF: https://github.com/llvm/llvm-project/commit/b8ceb9f4e4bdb69b5c3ea1ccf8505fa244ca0a1e.diff

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb8ceb9f4e4bd: [C++20] Diagnose invalid and reserved module names (authored by aaron.ballman). Changed prior to commit: https://reviews.llvm.org/D1

[PATCH] D136919: [X86][RFC] Change mangle name of __bf16 from u6__bf16 to DF16b

RKSimon added reviewers: stuij, tra. RKSimon added a comment. Do you think this patch needs to be expanded to handle ARM/AArch64/NVPTX - all of which override getBFloat16Mangling in similar ways? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136919

[PATCH] D124260: [clang-format] ColumnLimit check for trailing comments alignment acts wrong for multi-byte UTF-8 #47624

HazardyKnusperkeks abandoned this revision. HazardyKnusperkeks added a comment. You can reopen this, if you wish to continue working on it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124260/new/ https://reviews.llvm.org/D124260 ___ cfe-com

[PATCH] D137320: [include-cleaner] Initial version for the "Location=>Header" step

hokein updated this revision to Diff 472911. hokein marked 6 inline comments as done. hokein added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137320/new/ https://reviews.llvm.org/D137320 Files: clang-tools-extra/in

[PATCH] D98429: [clang-format] Add new option to clang-format: SpaceBeforeForLoopSemiColon

HazardyKnusperkeks abandoned this revision. HazardyKnusperkeks added a comment. More than a year silence. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98429/new/ https://reviews.llvm.org/D98429 ___ cfe-

[PATCH] D137320: [include-cleaner] Initial version for the "Location=>Header" step

hokein added inline comments. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Types.h:63 +// FIXME: use a real Class! +using SymbolLocation = std::variant; + kadircet wrote: > let's move this to `AnalysisInternal.h`, as it isn't used

[PATCH] D136554: Implement CWG2631

cor3ntin updated this revision to Diff 472912. cor3ntin added a comment. Add tests for consteval calls in init captures in default parameters. Clang behavior deviates from the wording of CWG2631 as it is not clear how we can implement the intended behavior in that corner case without introducin

[PATCH] D137334: [clang][dataflow] Generalize custom comparison to return tri-value result.

ymandel created this revision. ymandel added reviewers: xazax.hun, sgatev, gribozavr2. Herald added subscribers: martong, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. ymandel requested review of this revision. Herald added a project: clang. Currently, the API for a model's

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

HazardyKnusperkeks added a comment. Herald added a project: All. If you still want this to be landed, we need a name and email for the commit. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91950/new/ https://reviews.llvm.org/D91950 ___ cfe-co

[PATCH] D90121: clang-format: Add a consumer to diagnostics engine

HazardyKnusperkeks abandoned this revision. HazardyKnusperkeks added a comment. In D90121#3065063 , @dmikis wrote: > Since we used heavily patched version of clang-format (including this patch) > that problem didn't bugged us and I kinda moved on to other

[clang] 964c494 - Remove an unused local variable, NFC.

Author: Haojian Wu Date: 2022-11-03T13:57:46+01:00 New Revision: 964c4948cd4adb8e5d436796b02eb4bcd0b9641f URL: https://github.com/llvm/llvm-project/commit/964c4948cd4adb8e5d436796b02eb4bcd0b9641f DIFF: https://github.com/llvm/llvm-project/commit/964c4948cd4adb8e5d436796b02eb4bcd0b9641f.diff LO

[PATCH] D134267: [C++] [Modules] Support one phase compilation model for named modules

ben.boeckel added a comment. In D134267#3904257 , @ChuanqiXu wrote: > BTW, this patch should be discarded. And now we're pursuing D137059 > and D137058 > , where there is no modules ca

[PATCH] D137059: [Driver] [Modules] Introduce -fsave-std-c++-module-file= to specify the path of the module file (2/2)

ben.boeckel added a comment. In D137059#3904256 , @ChuanqiXu wrote: > In my mind, it is OK for CMake to support one-phase compilation model in the > short term. And the fact that clang also supports the 2-phase compilation > wouldn't affect CMake. Do I

[PATCH] D136919: [X86][RFC] Change mangle name of __bf16 from u6__bf16 to DF16b

pengfei added a comment. In D136919#3905024 , @RKSimon wrote: > Do you think this patch needs to be expanded to handle ARM/AArch64/NVPTX - > all of which override getBFloat16Mangling in similar ways? I thought of that. It would be great if we can make c

[PATCH] D137317: [X86][CET] Add Diags for targets pre to i686

pengfei updated this revision to Diff 472916. pengfei added a comment. Fix lit fail. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137317/new/ https://reviews.llvm.org/D137317 Files: clang/lib/Basic/Targets/X86.h Index: clang/lib/Basic/Targets

[PATCH] D137244: [Clang] Correctly capture bindings in dependent lambdas.

cor3ntin updated this revision to Diff 472920. cor3ntin added a comment. Use the `getPotentiallyDecomposedVarDecl` everywhere it makes sense. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137244/new/ https://reviews.llvm.org/D137244 Files: clang

[PATCH] D135740: [clang-format] Fix multiple preprocessor if sections parsing incorrectly

sstwcw abandoned this revision. sstwcw added a comment. It does some more than D137052 . But the addition stuff is not very important and no one can review it. So I am closing it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D136554: Implement CWG2631

cor3ntin updated this revision to Diff 472922. cor3ntin added a comment. Tweak comment in source_location tests with a suggestion Aaron made offline. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136554/new/ https://reviews.llvm.org/D136554 Files:

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

mgorny added a comment. > These workarounds are fine for me, but I wonder if it would be useful with a > more direct cmake option to tell it not look for these files at all. CMake has something like that built-in. I think it's `-DCMAKE_DISABLE_FIND_PACKAGE_LLVM=ON`. Repository: rG LLVM Gith

[PATCH] D135859: [Includecleaner] Introduce RefType to ast walking

kadircet updated this revision to Diff 472925. kadircet marked 5 inline comments as done. kadircet added a comment. - Fix typo - Change comment - Use Types.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135859/new/ https://reviews.llvm.org/D135859

[PATCH] D135859: [Includecleaner] Introduce RefType to ast walking

tschuett added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/WalkAST.cpp:25 namespace clang::include_cleaner { namespace { +using DeclCallback = There is a cuter way to use anonymous namespaces: https://llvm.org/docs/CodingStandards.html#an

[PATCH] D137320: [include-cleaner] Initial version for the "Location=>Header" step

kadircet added inline comments. Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/Types.h:54 + /// A verbatim header spelling, a string quoted with <> or "" that can be + /// #included directly + Header(StringRef VerbatimSpelling) : Storage(VerbatimS

[PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

serge-sans-paille created this revision. serge-sans-paille added reviewers: MaskRay, tstellar, mgorny, sylvestre.ledru. Herald added subscribers: libc-commits, libcxx-commits, Moerafaat, zero9178, Enna1, bzcheeseman, kosarev, ayermolo, sdasgup3, wenzhicui, wrengr, cota, StephenFan, teijeong, rdzh

[clang] 37f8010 - Silence a "not all control paths return" MSVC warning; NFC

Author: Aaron Ballman Date: 2022-11-03T10:27:16-04:00 New Revision: 37f80101a9120c95eb3c1022b8cc4a390f561700 URL: https://github.com/llvm/llvm-project/commit/37f80101a9120c95eb3c1022b8cc4a390f561700 DIFF: https://github.com/llvm/llvm-project/commit/37f80101a9120c95eb3c1022b8cc4a390f561700.diff

[clang] 9ea2b15 - [OpenMP][OMPIRBuilder] Migrate createOffloadEntriesAndInfoMetadata from clang to OpenMPIRBuilder

Author: Jan Sjodin Date: 2022-11-03T10:27:44-04:00 New Revision: 9ea2b150b5455b907ba3b9aa24703b5d4faabedd URL: https://github.com/llvm/llvm-project/commit/9ea2b150b5455b907ba3b9aa24703b5d4faabedd DIFF: https://github.com/llvm/llvm-project/commit/9ea2b150b5455b907ba3b9aa24703b5d4faabedd.diff LO

[PATCH] D136919: [X86][RFC] Change mangle name of __bf16 from u6__bf16 to DF16b

tschuett added subscribers: aaron.ballman, tschuett. tschuett added a comment. @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136919/new/ https://reviews.llvm.org/D136919 ___ cfe-commits ma

[PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

sylvestre.ledru added a comment. Maybe add it to the release notes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137337/new/ https://reviews.llvm.org/D137337 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Skylion007 added a comment. Use llvm::find_if instead of std::find_if Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137205/new/ https://reviews.llvm.org/D137205 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D137338: Fix dupe word typos

jhenderson added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: Michael137, sstefan1, JDevlieghere. This is going to be impossible to cleanly review as-is. Could it be broken into lots of smaller chunks? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137340: [clang-tidy] Add modernize-use-anonymous-namespace check

carlosgalvezp created this revision. Herald added a subscriber: xazax.hun. Herald added a project: All. carlosgalvezp requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.or

[PATCH] D137340: [clang-tidy] Add modernize-use-anonymous-namespace check

carlosgalvezp updated this revision to Diff 472946. carlosgalvezp added a comment. Fix release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137340/new/ https://reviews.llvm.org/D137340 Files: clang-tools-extra/clang-tidy/modernize/CMakeL

[PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

serge-sans-paille updated this revision to Diff 472945. serge-sans-paille added a comment. + Release Note CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137337/new/ https://reviews.llvm.org/D137337 Files: bolt/CMakeLists.txt bolt/include/bolt/RuntimeLibs/RuntimeLibraryVariables.inc.

[PATCH] D137338: Fix dupe word typos

glider added subscribers: pcc, glider. glider added inline comments. Comment at: clang/docs/DataFlowSanitizerDesign.rst:54 - /// Returns whether the given label label contains the label elem. + /// Returns whether the given label contains the label elem. int dfsan_has_labe

[PATCH] D125860: [clang] Only use major version in resource dir

mgorny added reviewers: serge-sans-paille, sylvestre.ledru, phosek, MaskRay. mgorny added a comment. Herald added subscribers: Michael137, StephenFan. To be honest, I've never seen much purpose in the x.y.z directory naming and I feel like it's making packaging unnecessarily more complex, at leas

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Skylion007 added a comment. I noticed one other bug from testing this out on some C++ codebases. Specifically in pybind11 we have an object class which is a child of the handle object. The object class is non-trivially copyable, while the handle object is not. Therefore, when we do not want to

[PATCH] D137340: [clang-tidy] Add modernize-use-anonymous-namespace check

carlosgalvezp updated this revision to Diff 472948. carlosgalvezp added a comment. Add reference to undeprecation of static. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137340/new/ https://reviews.llvm.org/D137340 Files: clang-tools-extra/clan

[PATCH] D137107: Allow MS extension: support of constexpr with __declspec(dllimport).

zahiraam added a comment. In D137107#3897568 , @mstorsjo wrote: > In D137107#3897326 , @rnk wrote: > >> Unless I'm missing something, I think Clang's behavior here is preferable to >> MSVC's. MSVC produces code w

[clang] 3edd188 - [AArch64] Add a baseline test for fp16 target intrinsics. NFC

Author: David Green Date: 2022-11-03T15:18:36Z New Revision: 3edd18876950693cbc69edda429f223616e3c052 URL: https://github.com/llvm/llvm-project/commit/3edd18876950693cbc69edda429f223616e3c052 DIFF: https://github.com/llvm/llvm-project/commit/3edd18876950693cbc69edda429f223616e3c052.diff LOG: [

[PATCH] D137340: [clang-tidy] Add modernize-use-anonymous-namespace check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/UseAnonymousNamespaceCheck.cpp:31 +static bool isInAnonymousNamespace(const Decl *Decl) { + const auto *DC = Decl->getDeclContext(); + if (DC && DC->isNamespace()) { Pleas

[PATCH] D125860: [clang] Only use major version in resource dir

serge-sans-paille added a comment. The consensus in the discourse thread you mention is not super strong, but I tend to agree with that patch. +1 for me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125860/new/ https://reviews.llvm.org/D125860

[PATCH] D137338: Fix dupe word typos

foad added a comment. I committed the lib/Target/AMDGPU parts as 5073ae2a883f . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137338/new/ https://reviews.llvm.org/D137338 __

[PATCH] D137287: [Test] Fix CHECK typo.

probinson added a comment. Nice work! have you verified that all the modified tests pass? naively it looks like you'd need at least 3 different targets to run them all (windows, webassembly, powerpc) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D137334: [clang][dataflow] Generalize custom comparison to return tri-value result.

sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:52 +/// Indicates the result of a tentative comparison. +enum class ComparisonStatus { + Same, Alternative that I slightly prefer - `ComparisonResult`. =

[PATCH] D137338: Fix dupe word typos

Meinersbur added a comment. Changes in `/polly/` look good to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137338/new/ https://reviews.llvm.org/D137338 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D137256: [AArch64] Alter arm_fp16.h to be target-based, not preprocessor based.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe7deca525058: [AArch64] Alter arm_fp16.h to be target-based, not preprocessor based. (authored by dmgreen). Herald added a project: clang. Herald add

  1   2   3   >