[PATCH] D135937: [X86] Support -march=raptorlake, meteorlake

FreddyYe updated this revision to Diff 472496. FreddyYe marked an inline comment as done. FreddyYe added a comment. Add X86_CPU_SUBTYPE_ALIAS and address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135937/new/ https://reviews.llvm.org/D

[PATCH] D135937: [X86] Support -march=raptorlake, meteorlake

FreddyYe added a comment. In D135937#3898501 , @FreddyYe wrote: > In D135937#3898228 , @FreddyYe > wrote: > >> For saving capacity of ProcessorSubtypes, gcc decided to not support part of >> compiler features of

[PATCH] D136146: [Clang][LoongArch] Handle -march/-m{single,double,soft}-float/-mfpu options

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/LoongArch.cpp:31 + options::OPT_msingle_float, + options::OPT_msoft_float)) { +if (A->getOption().matches(options::OPT_mdouble_f

[PATCH] D136146: [Clang][LoongArch] Handle -march/-m{single,double,soft}-float/-mfpu options

xry111 added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/LoongArch.cpp:44 + // Select abi based on -mfpu=xx. + if (const Arg *A = Args.getLastArg(options::OPT_mfpu_EQ)) { MaskRay wrote: > It's better to stick with just one canonical spelling

[PATCH] D135634: [clang][modules] Serialize VFS overlay paths into PCMs

jansvoboda11 added a comment. Ah, I now see that there are modes where `ASTUnit` gets configured with command-line arguments. I'm not very familiar with its clients, but I'd be inclined to: 1. If the original `HeaderSearchOptions` didn't have any VFS overlay files, adopt the PCM ones. 2. If th

[PATCH] D137071: [clang][Interp] Implement missing compound assign operators

tbaeder updated this revision to Diff 472503. tbaeder marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137071/new/ https://reviews.llvm.org/D137071 Files: clang/lib/AST/Interp/ByteCodeExprGen.cpp clang/test/AST/Interp/literals.cpp Index: clang/test/AST

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/UnnecessaryCopyOnLastUseCheck.cpp:1 +//===--- UnnecessaryCopyOnLastUseCheck.cpp - +// clang-tidy---===// Please make single line. Co

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/performance/unnecessary-copy-on-last-use.rst:4 +performance-unnecessary-copy-on-last-use +== + Please make same length as title.

[PATCH] D137224: clang/cmake: Simplify lit detection for standalone builds

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Hmm, I suppose it makes sense. At least at a first glance I don't see how it could yield different results. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D136936: [clang][Interp] Handle undefined functions better

tbaeder added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeEmitter.cpp:30 if (!FuncDecl->isDefined(FuncDecl) || - (!FuncDecl->hasBody() && FuncDecl->willHaveBody())) -return nullptr; + (FuncDecl->hasBody() && FuncDecl->willHaveBody())) +HasBody =

[PATCH] D137224: clang/cmake: Simplify lit detection for standalone builds

phosek accepted this revision. phosek added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137224/new/ https://reviews.llvm.org/D137224 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D137227: [asan] Default to -fsanitize-address-use-odr-indicator

MaskRay created this revision. MaskRay added reviewers: Sanitizers, eugenis, kcc, kstoimenov, vitalybuka. Herald added subscribers: Enna1, StephenFan, sunfish, hiraditya, dschuff. Herald added a project: All. MaskRay requested review of this revision. Herald added subscribers: llvm-commits, cfe-com

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

phosek accepted this revision. phosek added a comment. Still LGTM, thanks for the explanation. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137024/new/ https://reviews.llvm.org/D137024 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D137180: [LinkerWrapper] report on missing libraries

jdoerfert added inline comments. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:1278 + if (identify_magic((*BufferOrErr)->getBuffer()) != file_magic::archive) +continue; + jhuber6 wrote: > jdoerfert wrote: > > So if the library i

[clang] f33173a - [clang][modules][deps] System module maps might not be affecting

Author: Jan Svoboda Date: 2022-11-01T22:41:40-07:00 New Revision: f33173acd6875fa86448bb6d91bdac8f1296510a URL: https://github.com/llvm/llvm-project/commit/f33173acd6875fa86448bb6d91bdac8f1296510a DIFF: https://github.com/llvm/llvm-project/commit/f33173acd6875fa86448bb6d91bdac8f1296510a.diff L

[PATCH] D136007: [clang][modules][deps] System module maps might not be affecting

This revision was automatically updated to reflect the committed changes. Closed by commit rGf33173acd687: [clang][modules][deps] System module maps might not be affecting (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D136007?vs=467979&id=472508#toc Repository:

[PATCH] D135937: [X86] Support -march=raptorlake, meteorlake

pengfei added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:12940-12941 .Case(STR, {2u, static_cast(llvm::X86::ENUM)}) +#define X86_CPU_SUBTYPE_ALIAS(ENUM, STR) \ + .Case(STR, {2u, static_cast(llvm::X86::ENUM)}) #include

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

This revision was automatically updated to reflect the committed changes. Closed by commit rG23c665371a98: [compiler-rt] Switch from llvm-config to find_package(LLVM) (authored by mgorny). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137024/new/ ht

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

mgorny added a comment. Thanks! Let's hope it works this time. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137024/new/ https://reviews.llvm.org/D137024 ___ cfe-commits mailing list cfe-commits@lists.ll

<    1   2   3