[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

phosek added inline comments. Comment at: compiler-rt/cmake/Modules/CompilerRTUtils.cmake:274-275 + "LLVM_CONFIG_PATH is deprecated, please use LLVM_CMAKE_DIR instead") +get_filename_component(LLVM_CMAKE_DIR "${LLVM_CONFIG_PATH}" DIRECTORY) +get_filename_component(LL

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

philnik added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:282 + StringRef FirstComponentName = Path[0].first->getName(); + if (!getSourceManager().isInSystemHeader(Path[0].second) && + (FirstComponentName == "std" || aaron.ballman wrote: > p

[PATCH] D137180: [LinkerWrapper] report on missing libraries

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, tra, JonChesterfield. Herald added a project: All. jhuber6 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The linker wrapper does its own library searching

[PATCH] D137179: [clang][Lex] Header search case insensitivity

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM with minor nitpick: can you reflect in the title that this is related to header maps? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137179/ne

[PATCH] D136975: [Concepts] Correctly handle failure when checking concepts recursively

ychen added a comment. In D136975#3899717 , @erichkeane wrote: > In D136975#3899703 , @ychen wrote: > >> Thanks for the patch. It looks good to me. >> >> About >> >>> Note that we DO need to be careful to make su

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n created this revision. Herald added a project: All. goldstein.w.n requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I.e with: PPIndentWidth = 1 IndentWidth = 4 ``` #ifdef foo #define bar() if (A) { B(); } C(); #end

[clang] 00022c5 - [clang][Lex] Header map search case insensitivity

Author: Troy Johnson Date: 2022-11-01T11:33:00-07:00 New Revision: 00022c5613a7490148ae1147e25a695fc59c5f92 URL: https://github.com/llvm/llvm-project/commit/00022c5613a7490148ae1147e25a695fc59c5f92 DIFF: https://github.com/llvm/llvm-project/commit/00022c5613a7490148ae1147e25a695fc59c5f92.diff

[PATCH] D137179: [clang][Lex] Header map search case insensitivity

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG00022c5613a7: [clang][Lex] Header map search case insensitivity (authored by troyj). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D136975: [Concepts] Correctly handle failure when checking concepts recursively

ychen accepted this revision as: ychen. ychen added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136975/new/ https://reviews.llvm.org/D136975 ___ cfe-commits mailing list cfe-c

[clang] ab4c22e - [Concepts] Improve diagnostics on a missing 'auto' keyword.

Author: Erich Keane Date: 2022-11-01T11:39:46-07:00 New Revision: ab4c22e2b735c839c667e08be303f7f8cef3ccf6 URL: https://github.com/llvm/llvm-project/commit/ab4c22e2b735c839c667e08be303f7f8cef3ccf6 DIFF: https://github.com/llvm/llvm-project/commit/ab4c22e2b735c839c667e08be303f7f8cef3ccf6.diff L

[PATCH] D135220: [clang] Update ModuleMap::getModuleMapFile* to use FileEntryRef

benlangmuir added a comment. In D135220#3899674 , @dexonsmith wrote: > In D135220#3898849 , @hans wrote: > >> Relatedly, we ran into a problem with `clang-cl /showIncludes` not including >> all files in its outp

[PATCH] D136953: [C++20] Diagnose invalid and reserved module names

aaron.ballman added a comment. I believe we now have consensus on the patch. I'll land it in a few days in case any reviewers want to weigh in now that the discussion has stabilized. Comment at: clang/lib/Sema/SemaModule.cpp:282 + StringRef FirstComponentName = Path[0].first-

[PATCH] D137172: [Clang] Implement CWG2358 Explicit capture of value

aaron.ballman added a comment. Precommit CI seems to have caught valid failures this time. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:152 bool CheckDefaultArgumentVisitor::VisitLambdaExpr(const LambdaExpr *Lambda) { - // C++11 [expr.lambda.prim]p13: - // A lambda-expressio

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

MyDeveloperDay added a comment. This needs a unit test in clang/unittest/Format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137181/new/ https://reviews.llvm.org/D137181 ___ cfe-commits mailing list cfe

[PATCH] D135404: [clang-tidy] Add a checker for converting into C++17 variable template type traits

njames93 added a comment. I'd also suggest using the `IgnoreUnlessSpelledInSource` traversal kind here. Given that most of the time these will be instantiated we don't want to warn and emit a fix for each instantiation, Or you could just add `unless(isInTemplateInstantiation())` to your matcher

[PATCH] D136474: [CodeView][clang] Add flag to disable emitting command line into CodeView

rnk accepted this revision. rnk added a comment. I'm happy with this if it works for everyone else. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136474/new/ https://reviews.llvm.org/D136474 ___ cfe-comm

[clang] 2cee266 - [Concepts] Correctly handle failure when checking concepts recursively

Author: Erich Keane Date: 2022-11-01T12:18:58-07:00 New Revision: 2cee2663338ee65ff5786432c30ba22c8dcd711b URL: https://github.com/llvm/llvm-project/commit/2cee2663338ee65ff5786432c30ba22c8dcd711b DIFF: https://github.com/llvm/llvm-project/commit/2cee2663338ee65ff5786432c30ba22c8dcd711b.diff L

[PATCH] D136975: [Concepts] Correctly handle failure when checking concepts recursively

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2cee2663338e: [Concepts] Correctly handle failure when checking concepts recursively (authored by erichkeane). Herald added a project: clang. Change

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

mgorny added inline comments. Comment at: compiler-rt/cmake/Modules/CompilerRTUtils.cmake:274-275 + "LLVM_CONFIG_PATH is deprecated, please use LLVM_CMAKE_DIR instead") +get_filename_component(LLVM_CMAKE_DIR "${LLVM_CONFIG_PATH}" DIRECTORY) +get_filename_component(LL

[PATCH] D137024: [compiler-rt] Switch from llvm-config to find_package(LLVM)

mgorny updated this revision to Diff 472376. mgorny added a comment. Add an explanatory comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137024/new/ https://reviews.llvm.org/D137024 Files: compiler-rt/cmake/Modules/CompilerRTUtils.cmake compiler-rt/lib/xray/tests/CMakeLists.t

[PATCH] D136671: [analyzer] Fix crash for array-delete of UnknownVal values.

isuckatcs added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/ExprEngine.cpp:1244 SVal *ElementCountVal) { + assert(Region != nullptr && "Null-regions passed to prepareStateForArrayDestruction."); I me

[PATCH] D137052: [clang-format] Don't skip #else/#elif of #if 0

owenpan added a comment. In D137052#3899091 , @aaron.ballman wrote: > Can you also add a test for `#elifdef` and `#elifndef`? I added a test (lines 6130-6136) for `#elif` but not `#elifdef` and `#elifndef` because all three are on the same execution pa

[PATCH] D136651: [Clang] Give Clang the ability to use a shared stat cache

friss updated this revision to Diff 472379. friss added a comment. Fix unit test build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136651/new/ https://reviews.llvm.org/D136651 Files: clang/include/clang/Basic/DiagnosticFrontendKinds.td clang

[clang] 29a500b - [CodeView][clang] Add flag to disable emitting command line into CodeView

Author: Arthur Eubanks Date: 2022-11-01T13:04:37-07:00 New Revision: 29a500b346bdd998cac237f8570c6957730e086a URL: https://github.com/llvm/llvm-project/commit/29a500b346bdd998cac237f8570c6957730e086a DIFF: https://github.com/llvm/llvm-project/commit/29a500b346bdd998cac237f8570c6957730e086a.diff

[PATCH] D136474: [CodeView][clang] Add flag to disable emitting command line into CodeView

This revision was automatically updated to reflect the committed changes. Closed by commit rG29a500b346bd: [CodeView][clang] Add flag to disable emitting command line into CodeView (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D136624: [clang][modules] Account for non-affecting inputs in `ASTWriter`

jansvoboda11 added a comment. In D136624#3893607 , @dexonsmith wrote: > I'm curious; are system modules allowed to be non-affecting yet, or are they > still assumed to be affecting? (It's the system modules that I think are most > likely to be adjacent

[PATCH] D136624: [clang][modules] Account for non-affecting inputs in `ASTWriter`

jansvoboda11 marked 5 inline comments as done. jansvoboda11 added inline comments. Comment at: clang/include/clang/Serialization/ASTWriter.h:449-452 + /// Exclusive prefix sum of the lengths of preceding non-affecting inputs. + std::vector NonAffectingInputOffsetAdjustments; +

[PATCH] D137172: [Clang] Implement CWG2358 Explicit capture of value

cor3ntin updated this revision to Diff 472386. cor3ntin added a comment. Fix tests + address aaron's feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137172/new/ https://reviews.llvm.org/D137172 Files: clang/docs/ReleaseNotes.rst clang/l

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

mizvekov added a comment. In D136533#3899628 , @ldionne wrote: > It might be a problem, but I would argue we should still do it after fixing > any problematic cases. It seems like Clang's current behavior is broken, as > it basically ignores the `[[depr

[PATCH] D136790: [Clang][Sema] Add -Wincompatible-function-pointer-types-strict

nathanchance added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8217 + err_typecheck_convert_incompatible_function_pointer.Text>, + InGroup>, DefaultIgnore; def ext_typecheck_convert_discards_qualifiers : ExtWarn< aaron.ballma

[PATCH] D135822: [clang-tidy] Add option `RewriteVoidReturnType` to `modernize-use-trailing-return-type`

njames93 added a comment. The default behaviour of this check should be transform void return types as that's how it has been since the check was first created. Adding an option which defaults to changing this behaviour would be harmful to current users of this check. Commen

[clang] 0e9b8f4 - Fix release note indentation; NFC

Author: Aaron Ballman Date: 2022-11-01T16:54:39-04:00 New Revision: 0e9b8f4cb69d4e0abd635bfe671c8c5291fd06ad URL: https://github.com/llvm/llvm-project/commit/0e9b8f4cb69d4e0abd635bfe671c8c5291fd06ad DIFF: https://github.com/llvm/llvm-project/commit/0e9b8f4cb69d4e0abd635bfe671c8c5291fd06ad.diff

[PATCH] D136624: [clang][modules] Account for non-affecting inputs in `ASTWriter`

dexonsmith added a comment. In D136624#3900051 , @jansvoboda11 wrote: >> - Is there a change in cycles/instructions when the module cache is hot? >> (presumably the common case) > > I didn't notice this (but didn't look for it specifically). How could t

[PATCH] D137192: [clang][serialization] NFCI: Avoid re-reading input file info

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, vsapsai. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch resolves a FIXME

[PATCH] D137181: [clang-format] Don't use 'PPIndentWidth' inside multi-line macros

goldstein.w.n updated this revision to Diff 472397. goldstein.w.n added a comment. 1. Updating D137181 : [clang-format] Don't use 'PPIndentWidth' inside multi-line macros # 2. Enter a brief description of the changes included in this update. 3. The first line i

[PATCH] D136790: [Clang][Sema] Add -Wincompatible-function-pointer-types-strict

samitolvanen added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:8217 + err_typecheck_convert_incompatible_function_pointer.Text>, + InGroup>, DefaultIgnore; def ext_typecheck_convert_discards_qualifiers : ExtWarn< nathanchance

[PATCH] D135937: [X86] Support -march=raptorlake, meteorlake

MaskRay accepted this revision. MaskRay added inline comments. This revision is now accepted and ready to land. Herald added a subscriber: StephenFan. Comment at: clang/test/Driver/x86-march.c:91 // +// RUN: %clang --target=x86_64-unknown-unknown -c -### %s -march=raptorlake 2>

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 472405. ayzhao added a comment. clang-format + rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129531/new/ https://reviews.llvm.org/D129531 Files: clang/docs/ReleaseNotes.rst clang/include/clang-c/Inde

[PATCH] D137197: [clang][modules][deps] Transitive module maps are not affecting

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, vsapsai. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently, the algorithm fo

[PATCH] D136533: [clang] Fix missing diagnostic of declaration use when accessing TypeDecls through typename access

mizvekov updated this revision to Diff 472414. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136533/new/ https://reviews.llvm.org/D136533 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaDecl.cpp clang/li

[PATCH] D134113: [clang] store sugared converted arguments on TemplateSpecializationType

mizvekov updated this revision to Diff 472415. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134113/new/ https://reviews.llvm.org/D134113 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/AST/RecursiveASTVisitor.h clang/include/c

[PATCH] D127695: [clang] Template Specialization Resugaring - TypeDecl

mizvekov retitled this revision from "[clang] Implement Template Specialization Resugaring" to "[clang] Template Specialization Resugaring - TypeDecl". mizvekov edited the summary of this revision. mizvekov updated this revision to Diff 472416. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D137197: [clang][modules][deps] Transitive module maps are not affecting

jansvoboda11 updated this revision to Diff 472418. jansvoboda11 added a comment. Extract lambda, replace `while` with `for` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137197/new/ https://reviews.llvm.org/D137197 Files: clang/lib/Serialization

[PATCH] D137198: [clang][modules][deps] Parent module maps are affecting

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, vsapsai. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently, the algorithm fo

[PATCH] D137199: [clang] Template Specialization Resugaring - Template Type Alias

mizvekov created this revision. Herald added subscribers: jeroen.dobbelaere, ChuanqiXu. Herald added a project: All. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This implements resugaring of the pattern of template type aliases

[PATCH] D134115: [clang] Store in exprs the deduced arguments for function calls.

mizvekov updated this revision to Diff 472421. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134115/new/ https://reviews.llvm.org/D134115 Files: clang/include/clang/AST/ASTImporter.h clang/include/clang/AST/Expr.h clang/include/clang/Sema/Init

[PATCH] D134143: [clang] Misc type sugar preservation improvements

mizvekov updated this revision to Diff 472422. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134143/new/ https://reviews.llvm.org/D134143 Files: clang/lib/Sema/SemaCXXScopeSpec.cpp clang/lib/Sema/SemaExpr.cpp clang/lib/Sema/SemaType.cpp Index

[PATCH] D137200: [clang] Template Specialization Resugaring - Expressions

mizvekov created this revision. Herald added subscribers: ChuanqiXu, jdoerfert, arphaman. Herald added a reviewer: aaron.ballman. Herald added a project: All. mizvekov requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. WIP Signed-off-by: Math

[PATCH] D136786: Fix `unsafe-fp-math` attribute emission.

michele.scandale marked an inline comment as done. michele.scandale added inline comments. Comment at: clang/test/CodeGen/func-attr.c:5 // RUN: %clang -c -target x86_64 -funsafe-math-optimizations \ -// RUN: -emit-llvm -S -o - %s | FileCheck %s +// RUN: -fno-math-errno -ffp-cont

[PATCH] D136925: [clangd] Index unscoped enums inside classes for code completion

tom-anders updated this revision to Diff 472425. tom-anders marked 4 inline comments as done. tom-anders added a comment. Add additional test, don't bump index version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136925/new/ https://reviews.llvm.o

[PATCH] D137104: [clangd] Add scoped enum constants to all-scopes-completion

tom-anders updated this revision to Diff 472426. tom-anders added a comment. Rebase onto previous commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137104/new/ https://reviews.llvm.org/D137104 Files: clang-tools-extra/clangd/CodeComplete.cpp

[PATCH] D136925: [clangd] Index unscoped enums inside classes for code completion

tom-anders added inline comments. Comment at: clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp:2966 {cls("nx::Clangd1"), cls("ny::Clangd2"), cls("Clangd3"), - cls("na::nb::Clangd4")}, + cls("na::nb::Clangd4"), enmConstant("na::C::Clangd5")}, Opts

[PATCH] D136925: [clangd] Index unscoped enums inside classes for code completion

tom-anders updated this revision to Diff 472428. tom-anders added a comment. Fix accidental line break in comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136925/new/ https://reviews.llvm.org/D136925 Files: clang-tools-extra/clangd/CodeComp

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check - finds occurences of last uses, which are copied. - suggests adding a `std::move`. - detects assignments as last

Febbe created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. Febbe requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/

[PATCH] D129531: [clang][C++20] P0960R3: Allow initializing aggregates from a parenthesized list of values

ayzhao updated this revision to Diff 472441. ayzhao marked an inline comment as done. ayzhao added a comment. Merge CXXParenListInitExpr with VisitInitListExpr, also friendly ping as all comments are addressed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Febbe added a comment. I also have to add the http://clang.llvm.org/extra/clang-tidy/checks/performance-unnecessary-copy-on-last-use.html page, but I don't have any clue how, and where to start. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137205

[PATCH] D127695: [clang] Template Specialization Resugaring - TypeDecl

mizvekov added a comment. In D127695#3860316 , @rjmccall wrote: > I see, thank you. I know you've marked this a WIP, but it's always good to > describe these things in the patch description; that's what it's for. Done! I have also removed the WIP. While

[PATCH] D136624: [clang][modules] Account for non-affecting inputs in `ASTWriter`

jansvoboda11 marked 4 inline comments as done. jansvoboda11 added a comment. In D136624#3900183 , @dexonsmith wrote: > Partly, trying to dig into why read speeds got slower. But maybe that was > noise that went away though when you switched to cycles/in

[PATCH] D137206: [clang][modules][deps] Including module maps are affecting

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, vsapsai. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. With this patch, we mark mo

[PATCH] D136998: Try to implement lambdas with inalloca parameters by inlining the call operator function.

akhuang updated this revision to Diff 472447. akhuang added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136998/new/ https://reviews.llvm.org/D136998 Files: clang/lib/CodeGen/CGCall.cpp clang/lib/CodeGen/CGClass.cpp clang/

[PATCH] D136998: Try to implement lambdas with inalloca parameters by inlining the call operator function.

akhuang updated this revision to Diff 472450. akhuang added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136998/new/ https://reviews.llvm.org/D136998 Files: clang/lib/CodeGen/CGClass.cpp clang/lib/CodeGen/CodeGenFunction.h

[PATCH] D136624: [clang][modules] Account for non-affecting inputs in `ASTWriter`

dexonsmith added a comment. In D136624#3900593 , @jansvoboda11 wrote: > Ah, I forgot to mention this. Building the modules is now only 0.2% slower > and importing them 1.2% faster (compared to PCMs with all input files > serialized). Awesome. All upsi

[PATCH] D137209: [OPENMP]Initial support for error directive.

jyu2 created this revision. jyu2 added reviewers: ABataev, mikerice. jyu2 added projects: clang, OpenMP. Herald added subscribers: steakhal, martong, arphaman, guansong, yaxunl. Herald added a reviewer: NoQ. Herald added a project: All. jyu2 requested review of this revision. Herald added a reviewe

[clang] 6dda497 - [clang][modules] NFC: Remove unused lambda argument

Author: Jan Svoboda Date: 2022-11-01T16:58:11-07:00 New Revision: 6dda49794209e20514c58ead74fb105ff8bc6e4b URL: https://github.com/llvm/llvm-project/commit/6dda49794209e20514c58ead74fb105ff8bc6e4b DIFF: https://github.com/llvm/llvm-project/commit/6dda49794209e20514c58ead74fb105ff8bc6e4b.diff L

[PATCH] D137211: [clang][modules] NFCI: Unify FileID writing/reading

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, vsapsai. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds new functio

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

Febbe updated this revision to Diff 472458. Febbe added a comment. Added documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137205/new/ https://reviews.llvm.org/D137205 Files: clang-tools-extra/clang-tidy/performance/CMakeLists.txt cl

[PATCH] D137213: [clang][modules] NFCI: Pragma diagnostic mappings: write/read FileID instead of SourceLocation

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, vsapsai. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For pragma diagnostic mappi

[PATCH] D137214: [clang][modules] NFCI: Scaffolding for serialization of adjusted SourceManager offsets

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, vsapsai. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch is a

[PATCH] D137215: [clang] NFC: Extract lower-level SourceManager functions

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, vsapsai. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is a prep-

[PATCH] D137216: [clang][modules] NFCI: Avoid unnecessary serialization logic for non-affecting files

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, vsapsai. Herald added a subscriber: ributzka. Herald added a project: All. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch dela

[PATCH] D137217: [LTO][COFF] Use bitcode file names in lto native object file names.

zequanwu created this revision. zequanwu added reviewers: rnk, tejohnson, mehdi_amini. Herald added subscribers: pmatos, asb, ormris, steven_wu, hiraditya, arichardson, inglorion, sbc100, emaste. Herald added a reviewer: MaskRay. Herald added projects: lld-macho, All. Herald added a reviewer: lld-

[PATCH] D137215: [clang] NFC: Extract lower-level SourceManager functions

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137215/new/ https://reviews.llvm.org/D137215 __

[PATCH] D137214: [clang][modules] NFCI: Scaffolding for serialization of adjusted SourceManager offsets

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137214/new/ https://reviews.llvm.org/D137214 __

[PATCH] D137211: [clang][modules] NFCI: Unify FileID writing/reading

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137211/new/ https://reviews.llvm.org/D137211 __

[PATCH] D137213: [clang][modules] NFCI: Pragma diagnostic mappings: write/read FileID instead of SourceLocation

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM, although I there's format-is-probably-compatible-version as a courtesy for tooling, does that need a bump here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D137216: [clang][modules] NFCI: Avoid unnecessary serialization logic for non-affecting files

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137216/new/ https://reviews.llvm.org/D137216 __

[PATCH] D136624: [clang][modules] Account for non-affecting inputs in `ASTWriter`

jansvoboda11 updated this revision to Diff 472466. jansvoboda11 marked an inline comment as done. jansvoboda11 added a comment. Rebase, decrease nesting, test using `diff` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136624/new/ https://reviews.ll

[PATCH] D137213: [clang][modules] NFCI: Pragma diagnostic mappings: write/read FileID instead of SourceLocation

jansvoboda11 added a comment. In D137213#3900850 , @dexonsmith wrote: > LGTM, although I there's format-is-probably-compatible-version as a courtesy > for tooling, does that need a bump here? Good point, I'll bump `VERSION_MAJOR` in `clang/include/cla

[PATCH] D136624: [clang][modules] Account for non-affecting inputs in `ASTWriter`

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM, with one suggestion for the test inline. Comment at: clang/test/Modules/add-remove-irrelevant-module-map.m:22 +// Build modules with the non-affecting "a/module

[PATCH] D137180: [LinkerWrapper] report on missing libraries

jdoerfert added inline comments. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:1278 + if (identify_magic((*BufferOrErr)->getBuffer()) != file_magic::archive) +continue; + So if the library is found but not an archive we silently

[clang] fdbc55a - [clang][modules] NFCI: Unify FileID writing/reading

Author: Jan Svoboda Date: 2022-11-01T18:57:13-07:00 New Revision: fdbc55a51a792c65d4a1fd1f5d8e6ab19e0187d2 URL: https://github.com/llvm/llvm-project/commit/fdbc55a51a792c65d4a1fd1f5d8e6ab19e0187d2 DIFF: https://github.com/llvm/llvm-project/commit/fdbc55a51a792c65d4a1fd1f5d8e6ab19e0187d2.diff L

[PATCH] D137211: [clang][modules] NFCI: Unify FileID writing/reading

This revision was automatically updated to reflect the committed changes. Closed by commit rGfdbc55a51a79: [clang][modules] NFCI: Unify FileID writing/reading (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137211/new/ http

[PATCH] D137180: [LinkerWrapper] report on missing libraries

jhuber6 added inline comments. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:1278 + if (identify_magic((*BufferOrErr)->getBuffer()) != file_magic::archive) +continue; + jdoerfert wrote: > So if the library is found but not an ar

[clang] f61c135 - [clang][modules] NFCI: Pragma diagnostic mappings: write/read FileID instead of SourceLocation

Author: Jan Svoboda Date: 2022-11-01T18:59:17-07:00 New Revision: f61c135a69084e470b73c26a8134785808ee246f URL: https://github.com/llvm/llvm-project/commit/f61c135a69084e470b73c26a8134785808ee246f DIFF: https://github.com/llvm/llvm-project/commit/f61c135a69084e470b73c26a8134785808ee246f.diff L

[PATCH] D137213: [clang][modules] NFCI: Pragma diagnostic mappings: write/read FileID instead of SourceLocation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf61c135a6908: [clang][modules] NFCI: Pragma diagnostic mappings: write/read FileID instead of… (authored by jansvoboda11). Changed prior to commit:

[clang] 0bfc97e - [clang][modules] NFCI: Scaffolding for serialization of adjusted SourceManager offsets

Author: Jan Svoboda Date: 2022-11-01T19:06:55-07:00 New Revision: 0bfc97e4f4eb352f8e080872df8fdca51147683c URL: https://github.com/llvm/llvm-project/commit/0bfc97e4f4eb352f8e080872df8fdca51147683c DIFF: https://github.com/llvm/llvm-project/commit/0bfc97e4f4eb352f8e080872df8fdca51147683c.diff L

[PATCH] D137214: [clang][modules] NFCI: Scaffolding for serialization of adjusted SourceManager offsets

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0bfc97e4f4eb: [clang][modules] NFCI: Scaffolding for serialization of adjusted SourceManager… (authored by jansvoboda11). Repository: rG LLVM Gith

[clang] 9ae6e6a - [clang] NFC: Extract lower-level SourceManager functions

Author: Jan Svoboda Date: 2022-11-01T19:11:24-07:00 New Revision: 9ae6e6a50273abd683f61b017a4d4c34a964c703 URL: https://github.com/llvm/llvm-project/commit/9ae6e6a50273abd683f61b017a4d4c34a964c703 DIFF: https://github.com/llvm/llvm-project/commit/9ae6e6a50273abd683f61b017a4d4c34a964c703.diff L

[PATCH] D137215: [clang] NFC: Extract lower-level SourceManager functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9ae6e6a50273: [clang] NFC: Extract lower-level SourceManager functions (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SI

[clang] a13122c - [clang][modules] NFCI: Avoid unnecessary serialization logic for non-affecting files

Author: Jan Svoboda Date: 2022-11-01T19:23:02-07:00 New Revision: a13122c612a653026b2ac220e220c50783c3aa82 URL: https://github.com/llvm/llvm-project/commit/a13122c612a653026b2ac220e220c50783c3aa82 DIFF: https://github.com/llvm/llvm-project/commit/a13122c612a653026b2ac220e220c50783c3aa82.diff L

[PATCH] D137216: [clang][modules] NFCI: Avoid unnecessary serialization logic for non-affecting files

This revision was automatically updated to reflect the committed changes. Closed by commit rGa13122c612a6: [clang][modules] NFCI: Avoid unnecessary serialization logic for non-affecting… (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D136846: [Driver] Add -fsample-profile-use-profi

HaoyuZhang updated this revision to Diff 472487. HaoyuZhang added a comment. 1. Fix spelling grammar mistake in DocBrief. 2. Using tools::getLastProfileSampleUseArg instead of D.Diag(diag::err...) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136846

[PATCH] D136846: [Driver] Add -fsample-profile-use-profi

HaoyuZhang added a comment. New version updated. PTAL~ Comment at: clang/include/clang/Driver/Options.td:1257 + basic block counts to branch probabilites to fix them by extended + and re-engineered classic MCMF (min-cost max-flow) approach.}]>; def

[clang] 6924a49 - [clang][modules] Account for non-affecting inputs in `ASTWriter`

Author: Jan Svoboda Date: 2022-11-01T19:31:51-07:00 New Revision: 6924a49690eee074f6c341d3ada4e98d640b8a7e URL: https://github.com/llvm/llvm-project/commit/6924a49690eee074f6c341d3ada4e98d640b8a7e DIFF: https://github.com/llvm/llvm-project/commit/6924a49690eee074f6c341d3ada4e98d640b8a7e.diff L

[PATCH] D136624: [clang][modules] Account for non-affecting inputs in `ASTWriter`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6924a49690ee: [clang][modules] Account for non-affecting inputs in `ASTWriter` (authored by jansvoboda11). Changed prior to commit: https://review

[PATCH] D135411: Add generic KCFI operand bundle lowering

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:1082 SanitizerKind::CFICastStrict | SanitizerKind::FloatDivideByZero | - SanitizerKind::UnsignedIntegerOverflow | + SanitizerKind::KCFI | SanitizerKind::UnsignedIntegerOverflow | San

[PATCH] D135411: Add generic KCFI operand bundle lowering

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChain.cpp:1082 SanitizerKind::CFICastStrict | SanitizerKind::FloatDivideByZero | - SanitizerKind::UnsignedIntegerOverflow | + SanitizerKind::KCFI | SanitizerKind::UnsignedIntegerOverflow | San

[PATCH] D135411: Add generic KCFI operand bundle lowering

MaskRay added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/KCFI.cpp:47 + // Find call instructions with KCFI operand bundles. + SmallVector KCFICalls; + for (Instruction &I : instructions(F)) { You can omit `, 8` to use the default (also 8)

[PATCH] D137223: [clang-format] Remove special case for kw_operator when aligning decls

rymiel created this revision. rymiel added reviewers: HazardyKnusperkeks, owenpan, MyDeveloperDay. Herald added a project: All. rymiel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This change breaks no existing tests but does fix the lin

[PATCH] D137224: clang/cmake: Simplify lit detection for standalone builds

tstellar created this revision. tstellar added reviewers: mgorny, phosek, Ericson2314. Herald added a project: All. tstellar requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D137224 Files: clang/CMakeLists.txt In

<    1   2   3   >